Re: [Mesa-dev] [PATCH] nir: only override previous alu during loop analysis if supported

2019-03-18 Thread Timothy Arceri
Piglit test to trigger the crash: https://patchwork.freedesktop.org/patch/292855/ On 19/3/19 12:09 pm, Timothy Arceri wrote: Users of this function expect alu to be a supported comparision if the induction variable is not NULL. Since we attempt to override the return values if the first limit

[Mesa-dev] [PATCH] nir: only override previous alu during loop analysis if supported

2019-03-18 Thread Timothy Arceri
Users of this function expect alu to be a supported comparision if the induction variable is not NULL. Since we attempt to override the return values if the first limit is not a const, we must make sure we are dealing with a valid comparision before overriding the alu instruction. Fixes an

[Mesa-dev] [AppVeyor] mesa master #10461 completed

2019-03-18 Thread AppVeyor
Build mesa 10461 completed Commit a777c3d7cb by Bas Nieuwenhuizen on 3/18/2019 9:20 PM: radv: Use correct image view comparison for fast clears.\n\nThe if is actually returning true on success, enabling fast clears, so we\nneed to have the test succeed when

[Mesa-dev] [PATCH] virgl: close drm fd when destroying virgl screen.

2019-03-18 Thread Lepton Wu
This fd was create in virgl_drm_screen_create and should be closed in virgl_drm_screen_destroy. Signed-off-by: Lepton Wu --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c

[Mesa-dev] [PATCH] virgl: Set bind when creating temp resource.

2019-03-18 Thread Lepton Wu
virgl render complains about "Illegal resource" when running dEQP-EGL.functional.color_clears.single_context.gles2.rgb888_window, the reason is that a zero bind value was given for temp resource. Signed-off-by: Lepton Wu --- src/gallium/drivers/virgl/virgl_texture.c | 1 + 1 file changed, 1

[Mesa-dev] [PATCH] virgl: Use right key to insert resource to hash.

2019-03-18 Thread Lepton Wu
The old code could use gem name as key when inserting it to bo_handles hash table while trying to remove it from hash table with bo_handle as key in virgl_hw_res_destroy. This triggers use after free. Also, we should only reuse resource from bo_handle hash when the handle type is FD.

[Mesa-dev] Writing a glvnd vendor library - imports getProcAddress not getting called

2019-03-18 Thread mmarkd9
Hi, I'm trying to write a glvnd vendor library. I did set up the interface as the mesa one (https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/glx/glxglvnd.c#L73) but when executing glxgears, the first Glx call (glXChooseVisual) fails and the callback I did set up in

[Mesa-dev] [PATCH] swr: Fix build with llvm-9.0.

2019-03-18 Thread Vinson Lee
Fix build error after llvm-9.0svn r352827 ("[opaque pointer types] Add a FunctionCallee wrapper type, and use it."). In file included from ./rasterizer/jitter/builder.h:158:0, from swr_shader.cpp:35: ./rasterizer/jitter/gen_builder_meta.hpp: In member function ‘llvm::Value*

[Mesa-dev] [AppVeyor] mesa staging/19.0 #10460 failed

2019-03-18 Thread AppVeyor
Build mesa 10460 failed Commit cf2e4490c3 by Jason Ekstrand on 3/11/2019 11:47 PM: nir: Add a new pass to lower array dereferences on vectors\n\nThis pass was originally written for lowering TCS output reads and\nwrites but it is also applicable just about

Re: [Mesa-dev] [PATCH] st/mesa: implement "zombie" sampler views (v2)

2019-03-18 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 15.03.19 um 22:12 schrieb Brian Paul: > When st_texture_release_all_sampler_views() is called the texture may > have sampler views belonging to several contexts. If we unreference a > sampler view and its refcount hits zero, we need to be sure to destroy > the

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-18 Thread Eric Engestrom
On Monday, 2019-03-18 10:32:17 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2019-03-17 11:33:23) > > On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote: > > > There is merge request opened about this issue : > > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/429 > >

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-18 Thread Dylan Baker
Quoting Eric Engestrom (2019-03-17 11:33:23) > On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote: > > There is merge request opened about this issue : > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/429 > > > > I think the deps need to be moved from

[Mesa-dev] [Bug 110181] payment

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110181 Bug ID: 110181 Summary: payment Product: Mesa Version: 5.1 Hardware: Other OS: All Status: NEW Severity: critical Priority: medium

[Mesa-dev] [ANNOUNCE] mesa 18.3.5

2019-03-18 Thread Emil Velikov
Mesa 18.3.5 is now available. This release predominantly focuses on the ANV and RADV Vulkan drivers. See the shortlog below, for more details. -Emil Alok Hota (1): swr/rast: bypass size limit for non-sampled textures Andrii Simiklit (1): i965: re-emit index buffer state on a

Re: [Mesa-dev] [PATCH 0/9] Lima mesa driver

2019-03-18 Thread Qiang Yu
On Sun, Mar 17, 2019 at 10:20 PM Rob Clark wrote: > > Any chance you could submit a gitlab MR? Replying with comments > inline to the driver patch is a bit more than gmail can handle.. OK, I've created one: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/465 > > but quick comments: > >

[Mesa-dev] [Bug 110116] Neverball particles are broken (GL_POINT_SPRITE)

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110116 Denis changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Denis ---

Re: [Mesa-dev] MESA_Build_ERROR

2019-03-18 Thread Sergii Romantsov
Hello, seems my question was wrong - sorry. Actually looks like your toolchain doesn't support this sys-call. Think, you could try or update your toolchain if it possible to be containing SYS_memfd_create or you could try to use meson (

[Mesa-dev] [Bug 110116] Neverball particles are broken (GL_POINT_SPRITE)

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110116 --- Comment #7 from Denis --- yes, with your apitrace I see the issue -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

Re: [Mesa-dev] MESA_Build_ERROR

2019-03-18 Thread Milav
Hello Romantsov, Here i have sent uname -a result. teqdiligent@ubuntu:~$ uname -a Linux ubuntu 4.2.0-27-generic #32~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux teqdiligent@ubuntu:~$

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #8 from Timur Kristóf --- Can you tell me how to build libxatracker.la? Ie. what autotools command to use? Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] ac/nir_to_llvm: make sure to we are comparing ints in a couple of places

2019-03-18 Thread Timothy Arceri
Fixes llvm validation error in a Deus Ex shader on radeonsi. Both operands to ICmp instruction are not of the same type! --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH] radv: fix the NUM_RECORDS field for vertex bindings on GFX6/GFX7

2019-03-18 Thread Bas Nieuwenhuizen
I think this needs to be modified to get the vulkan out of bounds behavior. In particular whether a VS input is out of bounds or not can differ between attributes from the same buffer with the same index, and that is something not handled here. I guess we could fix by only using the offset in

[Mesa-dev] [Bug 110141] glesv1_cm.pc and glesv2.pc missing after b01524fff05eef66e8cd24f1c5aacefed4209f03

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110141 Heiko Becker changed: What|Removed |Added CC||heire...@exherbo.org -- You are

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #7 from Vinson Lee --- There is a similar build error with libxatracker.la. CXXLDlibxatracker.la /usr/bin/ld: ../../../../src/gallium/auxiliary/.libs/libgallium.a(tgsi_to_nir.o): in function `ttn_finalize_nir':

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #6 from Vinson Lee --- (In reply to Timur Kristóf from comment #5) > Okay, I think I got it. Can you please try with this patch: > https://gitlab.freedesktop.org/Venemo/mesa/commit/ > c1efd5b26d210b017118d29ecf16aaaeeb34a420 > > It