[Mesa-dev] [Bug 110268] enable storageBuffer16BitAccess feature in radv for SI and CIK

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110268 Bug ID: 110268 Summary: enable storageBuffer16BitAccess feature in radv for SI and CIK Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [Bug 110266] gpu error

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110266 Bug ID: 110266 Summary: gpu error Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 Kenneth Endfinger changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) -- You are

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 Bug ID: 110261 Summary: Segmentation fault when using vulkaninfo on Radeon Product: Mesa Version: 19.0 Hardware: x86 (IA32) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH v2 6/8] gallium: add lima driver

2019-03-27 Thread Qiang Yu
V3 driver could be reviewed at: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/465 Regards, Qiang On Tue, Mar 26, 2019 at 2:38 PM Qiang Yu wrote: > > On Tue, Mar 26, 2019 at 11:33 AM Alyssa Rosenzweig > wrote: > > > > > + [PPIR_INSTR_SLOT_ALU_VEC_MUL] = ppir_codegen_encode_vec_mul,

Re: [Mesa-dev] [PATCH v5 35/38] intel/compiler: validate region restrictions for mixed float mode

2019-03-27 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > From: Iago Toral Quiroga > > v2: > - Adapted unit tests to make them consistent with the changes done >to the validation of half-float conversions. > --- > src/intel/compiler/brw_eu_validate.c| 256 ++ > src/intel/compiler/test_eu_validate.cpp

Re: [Mesa-dev] [PATCH v5 33/38] intel/compiler: validate region restrictions for half-float conversions

2019-03-27 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > From: Iago Toral Quiroga > > v2: > - Consider implicit conversions in 2-src instructions too (Curro) > - For restrictions that involve destination stride requirements >only validate them for Align1, since Align16 always requires >packed data. > -

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #10 from Vinson Lee --- The diff fixes the entire build for me. diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am index db515e3097b7..807a100a7d0a 100644 ---

Re: [Mesa-dev] [PATCH v6 31/38] intel/compiler: implement SIMD16 restrictions for mixed-float instructions

2019-03-27 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > From: Iago Toral Quiroga > > --- > src/intel/compiler/brw_fs.cpp | 65 +++ > 1 file changed, 65 insertions(+) > > diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp > index 2fc7793709b..3616a7afc31 100644

[Mesa-dev] [PATCH] intel/disasm: Disassemble JIP offset for while

2019-03-27 Thread Sagar Ghuge
Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_disasm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c index efca3e2ce7d..440e51faa61 100644 --- a/src/intel/compiler/brw_disasm.c +++

Re: [Mesa-dev] [PATCH 1/2] softpipe/draw: fix vertex id in soft paths.

2019-03-27 Thread Roland Scheidegger
Am 27.03.19 um 20:47 schrieb Dave Airlie: > From: Dave Airlie > > This fixes the vertex id fetch in the non-llvm drawing paths. > > This vertex id in elt mode comes from the elts not just a linear > value. > > Note we don't bad add? > basevertex in the elts case as it's already included > in

[Mesa-dev] [PATCH] intel/compiler: Set flag reg/subreg number properly

2019-03-27 Thread Sagar Ghuge
If predicate control is set to None, then in that case we can simply set flag reg/subreg number to zero. This allows round-tripping through the assembler/disassembler Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_eu_emit.c| 7 +++ src/intel/compiler/brw_fs_generator.cpp | 1

Re: [Mesa-dev] [PATCH] nir: Lock around validation fail shader dumping

2019-03-27 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 28/3/19 3:22 am, Jason Ekstrand wrote: --- src/compiler/nir/nir_validate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index ef2e2b62783..f8327c0dd45 100644 ---

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #10 from Jason Ekstrand --- Fixed by the following commit in master: commit ce47999ceed7efe010a1b6cc592780514803670a (public/master) Author: Jason Ekstrand Date: Wed Mar 27 11:16:15 2019 -0500 Revert "anv/radv: release

[Mesa-dev] [PATCH 2/2] softpipe: add indirect store buffer/image unit

2019-03-27 Thread Dave Airlie
From: Dave Airlie The code to handle image unit indirect was missing Fixes piglit tests/spec/arb_arrays_of_arrays/execution/image_store/basic-imageStore-mixed-const-non-const-uniform-index.shader_test --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 36 -- 1 file changed,

[Mesa-dev] [PATCH 1/2] softpipe/draw: fix vertex id in soft paths.

2019-03-27 Thread Dave Airlie
From: Dave Airlie This fixes the vertex id fetch in the non-llvm drawing paths. This vertex id in elt mode comes from the elts not just a linear value. Note we don't bad basevertex in the elts case as it's already included in the elts by the looks of it (at least tests fail if I add it) Fixes

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 james.dut...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #8 from james.dut...@gmail.com --- git checkout master at point: git checkout 15f131b7b7fdb9baca69e19eedf16b4568ab32c8 is Good. The ACO benchmark test passes. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [ANNOUNCE] mesa 19.0.1

2019-03-27 Thread Dylan Baker
Hi List, I'd like to announce the availability of mesa 19.0.1. This is the first bug fix release of the 19.0 branch. It's been a pretty calm cycle, and there's not too much here. I think things are looking pretty good overall. Dylan shortlog: Andres Gomez (4): glsl: correctly validate

[Mesa-dev] [PATCH] intel/compiler/icl: Use tcs barrier id bits 24:30 instead of 24:27

2019-03-27 Thread Topi Pohjolainen
Similarly to 1cc17fb731466c68586915acbb916586457b19bc Fixes gpu hangs with dEQP-VK.tessellation.shader_input_output.barrier CC: Anuj Phogat CC: Clayton Craft Signed-off-by: Topi Pohjolainen --- src/intel/compiler/brw_fs_nir.cpp | 21 +++-- 1 file changed, 15 insertions(+), 6

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #7 from Jason Ekstrand --- Got a proper bisect: commit 4e1bbb000cdfe4ba01bee5a6868c54fed7285dae Author: Tapani Pälli Date: Tue Mar 19 11:01:53 2019 +0200 anv/radv: release memory allocated by glsl types during spirv_to_nir

[Mesa-dev] [PATCH] nir: Lock around validation fail shader dumping

2019-03-27 Thread Jason Ekstrand
--- src/compiler/nir/nir_validate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index ef2e2b62783..f8327c0dd45 100644 --- a/src/compiler/nir/nir_validate.c +++ b/src/compiler/nir/nir_validate.c @@ -26,6 +26,7 @@

[Mesa-dev] [Bug 110141] glesv1_cm.pc and glesv2.pc missing after b01524fff05eef66e8cd24f1c5aacefed4209f03

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110141 Eric Engestrom changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEEDINFO

Re: [Mesa-dev] [PATCH 5/5] panfrost: Wait for last job to finish in force_flush_fragment

2019-03-27 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Nice one :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/5] panfrost: Pass the context BOs to the kernel so they aren't unmapped while in use

2019-03-27 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig I concede when it's laid out like this, the number of scratchbuffers is a _little_ excessive. varying_mem is interesting since in the ES2 sense, it's purple internal scratch, but in ES3, it's a plain old CPU-usable buffer (which is how they implement transform

Re: [Mesa-dev] [PATCH 3/5] panfrost: Also tell the kernel about the checksum_slab

2019-03-27 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Good catch, thank you! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] panfrost: Set the GEM handle for AFBC buffers

2019-03-27 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] panfrost: Fix sscanf format options

2019-03-27 Thread Alyssa Rosenzweig
Should be "%" PRIx64, I think? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/5] panfrost: Fix sscanf format options

2019-03-27 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pandecode/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pandecode/cmdline.c b/src/gallium/drivers/panfrost/pandecode/cmdline.c index b2ba21cfe414..07bffdb5c493 100644

[Mesa-dev] [PATCH 4/5] panfrost: Pass the context BOs to the kernel so they aren't unmapped while in use

2019-03-27 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_drm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index 0a7cf47c6a36..887bf19148e7 100644 ---

[Mesa-dev] [PATCH 5/5] panfrost: Wait for last job to finish in force_flush_fragment

2019-03-27 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_drm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index 887bf19148e7..c30beaf2b500 100644 --- a/src/gallium/drivers/panfrost/pan_drm.c

[Mesa-dev] [PATCH 3/5] panfrost: Also tell the kernel about the checksum_slab

2019-03-27 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_drm.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index f4580da9f509..0a7cf47c6a36 100644 ---

[Mesa-dev] [PATCH 2/5] panfrost: Set the GEM handle for AFBC buffers

2019-03-27 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index d242c3f90cea..c513791615ea 100644 ---

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #6 from Jason Ekstrand --- This bug appears to be some sort of memory corruption in the type system. In particular, type names show up garbled in most of the validation fail dumps. I'm still working on where the corruption could

Re: [Mesa-dev] [PATCH] etnaviv: shrink struct etna_3d_state

2019-03-27 Thread Lucas Stach
Am Mittwoch, den 27.03.2019, 14:58 +0100 schrieb Christian Gmeiner: > Drop struct members which are only written to but never read from. > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >  src/gallium/drivers/etnaviv/etnaviv_emit.c | 17 - >  

Re: [Mesa-dev] [PATCH 2/2] etnaviv: flush all pending contexts when accessing a resource with the CPU

2019-03-27 Thread Christian Gmeiner
Am Mi., 27. März 2019 um 12:23 Uhr schrieb Lucas Stach : > > When setting up a transfer to a resource, all contexts where the resource > is pending must be flushed. Otherwise a write transfer might be started > in the current context before all contexts that access the resource in > shared (read)

Re: [Mesa-dev] [PATCH 1/2] etnaviv: don't flush own context when updating resource use

2019-03-27 Thread Christian Gmeiner
Am Mi., 27. März 2019 um 12:23 Uhr schrieb Lucas Stach : > > The context is self synchronizing at the GPU side, as commands are > executed in order. We must not flush our own context when updating the > resource use, as that leads to excessive flushing on effectively every > draw call, causing

Re: [Mesa-dev] [PATCH] etnaviv: only try to construct scanout resource when on KMS winsys

2019-03-27 Thread Christian Gmeiner
Am Mi., 27. März 2019 um 12:25 Uhr schrieb Lucas Stach : > > Trying to construct a scanout capable buffer will only ever work when > when we are on top of a KMS winsys, as the render node isn't capable > of allocating contiguous buffers. > > Tested-by: Marius Vlad > Signed-off-by: Lucas Stach

[Mesa-dev] [PATCH] etnaviv: shrink struct etna_3d_state

2019-03-27 Thread Christian Gmeiner
Drop struct members which are only written to but never read from. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 17 - src/gallium/drivers/etnaviv/etnaviv_internal.h | 6 -- 2 files changed, 23 deletions(-) diff --git

[Mesa-dev] [Bug 110259] radv: Sampling depth-stencil image in GENERAL layout returns nothing but zero (regression, bisected)

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110259 Bug ID: 110259 Summary: radv: Sampling depth-stencil image in GENERAL layout returns nothing but zero (regression, bisected) Product: Mesa Version: git Hardware: Other

[Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-03-27 Thread Emil Velikov
Hello list, The candidate for the Mesa 18.3.6 is now available. Currently we have: - 19 queued - 0 nominated (outstanding) - and 0 rejected patches Note: this is the final anticipated release in the 18.3 series. Users are encouraged to migrate to the 19.0 series in order to obtain future

[Mesa-dev] [PATCH] etnaviv: only try to construct scanout resource when on KMS winsys

2019-03-27 Thread Lucas Stach
Trying to construct a scanout capable buffer will only ever work when when we are on top of a KMS winsys, as the render node isn't capable of allocating contiguous buffers. Tested-by: Marius Vlad Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +- 1 file

[Mesa-dev] [PATCH 2/2] etnaviv: flush all pending contexts when accessing a resource with the CPU

2019-03-27 Thread Lucas Stach
When setting up a transfer to a resource, all contexts where the resource is pending must be flushed. Otherwise a write transfer might be started in the current context before all contexts that access the resource in shared (read) mode have been executed. Fixes: 64813541d575 (etnaviv: fix

[Mesa-dev] [PATCH 1/2] etnaviv: don't flush own context when updating resource use

2019-03-27 Thread Lucas Stach
The context is self synchronizing at the GPU side, as commands are executed in order. We must not flush our own context when updating the resource use, as that leads to excessive flushing on effectively every draw call, causing huge CPU overhead. Fixes: 64813541d575 (etnaviv: fix resource usage

Re: [Mesa-dev] [PATCH] ac: use llvm.amdgcn.fmed3 intrinsic for nir_op_fmed3

2019-03-27 Thread Bas Nieuwenhuizen
r-b On Mon, Mar 25, 2019 at 1:34 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c | 27 +++ > src/amd/common/ac_llvm_build.h | 4 > src/amd/common/ac_nir_to_llvm.c | 13 + > 3 files changed, 36

[Mesa-dev] [Bug 109159] [KBL-G][vulkan] dEQP-VK.api.version_check.entry_points test failed.

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109159 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Mesa-dev] [Bug 109805] GPU hangs with error VM_CONTEXT1_PROTECTION_FAULT_STATUS

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109805 --- Comment #13 from Samuel Pitoiset --- Are you able to reproduce the VM faults with mesa 19.0? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-27 Thread Samuel Pitoiset
This helps few compute shaders, mostly for F12017. 27670 shaders in 14347 tests Totals: SGPRS: 1231173 -> 1231173 (0.00 %) VGPRS: 866056 -> 865928 (-0.01 %) Spilled SGPRs: 24201 -> 24201 (0.00 %) Code Size: 46137040 -> 46144868 (0.02 %) bytes Max Waves: 232287 -> 232302 (0.01 %) Totals from

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #5 from james.dut...@gmail.com --- Created attachment 143786 --> https://bugs.freedesktop.org/attachment.cgi?id=143786=edit Log of wine output from "wine ACOdyssey.exe" after trying revert -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_{load, store}_deref_with_access() helpers

2019-03-27 Thread Samuel Pitoiset
On 3/27/19 1:25 AM, Jason Ekstrand wrote: You could make the old ones call these. It'd make for a smaller diff and less code to maintain. Pushed with the suggested change. Thanks for the reviews. On March 26, 2019 17:10:52 Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [Bug 110240] Assassins Creed Odyssey crashes with nir errors

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110240 --- Comment #4 from james.dut...@gmail.com --- git checkout 39da1deb497af55496308c0867b5ce5a0e9df56e git revert 3b3653c4cfbedf55a00cbddd0f341ebd1de81665 The game ACO still fails to work, with a NIR compile error. Although, it might be crashing

[Mesa-dev] [Bug 110253] glBlitFramebuffer fails on MSAA fbo source.

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110253 Bug ID: 110253 Summary: glBlitFramebuffer fails on MSAA fbo source. Product: Mesa Version: 19.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 110252] swr software rasterizer fall back to OpenGL 2.1

2019-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110252 Bug ID: 110252 Summary: swr software rasterizer fall back to OpenGL 2.1 Product: Mesa Version: 19.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW