Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-01 Thread Dave Airlie
On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: > > Marek's commit to add ARB_parallel_shader_compile broke some es1 tests > in the Intel CI. > > It appears the whatever generates the es1api isn't consistent, for > example glTranslatex on my local system is 1405 in es1api but is 1406 > in the gl

[Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-01 Thread Dave Airlie
Marek's commit to add ARB_parallel_shader_compile broke some es1 tests in the Intel CI. It appears the whatever generates the es1api isn't consistent, for example glTranslatex on my local system is 1405 in es1api but is 1406 in the gl api. I'm no expert on this area, Emil any ideas? Dave.

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-04-01 Thread Dieter Nützel
Am 01.04.2019 07:43, schrieb Jan Vesely: Hi, On Mon, 2019-04-01 at 06:24 +0200, Dieter Nützel wrote: Hello, commit #356ec7a2196 'gallium: fix autotools build of pipe_msm.la' broke Clover. biseted: 356ec7a21960d77db282f67af577dcdb46966b5a is the first bad commit commit

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-04-01 Thread Dieter Nützel
Am 01.04.2019 19:27, schrieb Dylan Baker: Quoting Jan Vesely (2019-03-31 22:43:50) Hi, On Mon, 2019-04-01 at 06:24 +0200, Dieter Nützel wrote: > Hello, > > commit #356ec7a2196 'gallium: fix autotools build of pipe_msm.la' broke > Clover. > > biseted: > 356ec7a21960d77db282f67af577dcdb46966b5a

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-01 Thread Rob Clark
+daniels On Mon, Apr 1, 2019 at 1:55 PM Jean Hertel wrote: > > Hi Rob, > > As we have spoken already in the past, I have the intention to move adriconf > under the mesa project umbrella, as an official tool for configuring DRI > options. > I would like to ask your advice, as well as other mesa

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-01 Thread Marek Olšák
On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely wrote: > On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: > > Does the attached patch fix the copy-buffer test? > > it does thanks. > Won't the compute only context still need some synchronization? > Is there anything else to guarantee that the data

[Mesa-dev] [PATCH] radeonsi: don't use PFP_SYNC_ME with compute-only contexts

2019-04-01 Thread Marek Olšák
From: Marek Olšák Fixes: a1378639ab1 "radeonsi: always use compute rings for clover on CI and newer (v2)" --- src/gallium/drivers/radeonsi/si_cp_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #16 from Ian Romanick --- (In reply to Hal Gentz from comment #10) > Created attachment 143764 [details] > Improved repo of the bug. I would very much like to see this as a piglit test. -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH v5 35/38] intel/compiler: validate region restrictions for mixed float mode

2019-04-01 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > On Wed, 2019-03-27 at 19:37 -0700, Francisco Jerez wrote: >> "Juan A. Suarez Romero" writes: >> >> > From: Iago Toral Quiroga >> > >> > v2: >> > - Adapted unit tests to make them consistent with the changes done >> >to the validation of half-float

[Mesa-dev] Move adriconf to mesa repositories

2019-04-01 Thread Jean Hertel
Hi Rob, As we have spoken already in the past, I have the intention to move adriconf under the mesa project umbrella, as an official tool for configuring DRI options. I would like to ask your advice, as well as other mesa developers, on how to properly do this. (If people is willing to accept

Re: [Mesa-dev] [PATCH] virgl: Set bind when creating temp resource.

2019-04-01 Thread Lepton Wu
On Tue, Mar 19, 2019 at 4:29 AM Erik Faye-Lund wrote: > On Mon, 2019-03-18 at 14:44 -0700, Lepton Wu wrote: > > virgl render complains about "Illegal resource" when running > > dEQP-EGL.functional.color_clears.single_context.gles2.rgb888_window, > > the reason is that a zero bind value was given

Re: [Mesa-dev] [PATCH] virgl: close drm fd when destroying virgl screen.

2019-04-01 Thread Lepton Wu
On Wed, Mar 20, 2019 at 2:26 PM Chia-I Wu wrote: > Reviewed-by: Chia-I Wu > Anything else to need for merging this? I think this is a straightforward leaking fix. > > On Mon, Mar 18, 2019 at 4:40 PM Lepton Wu wrote: > >> This fd was create in virgl_drm_screen_create and should be closed >>

Re: [Mesa-dev] [PATCH] virgl: Use right key to insert resource to hash.

2019-04-01 Thread Lepton Wu
On Wed, Mar 20, 2019 at 3:03 PM Chia-I Wu wrote: > On Mon, Mar 18, 2019 at 2:22 PM Lepton Wu wrote: > >> The old code could use gem name as key when inserting it to bo_handles >> hash table while trying to remove it from hash table with bo_handle as >> key in virgl_hw_res_destroy. This triggers

[Mesa-dev] New JIT Features in LLVM

2019-04-01 Thread preejackie
Hi I'm Praveen Velliengiri, student from India. I'm working on developing a Speculative compilation support in LLVM ORC JIT Infrastructure. As LLVM ORC supports compiling in multiple backend threads, it would be effective if we compile the functions speculatively before they are called by

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-04-01 Thread Dylan Baker
Quoting Jan Vesely (2019-03-31 22:43:50) > Hi, > > On Mon, 2019-04-01 at 06:24 +0200, Dieter Nützel wrote: > > Hello, > > > > commit #356ec7a2196 'gallium: fix autotools build of pipe_msm.la' broke > > Clover. > > > > biseted: > > 356ec7a21960d77db282f67af577dcdb46966b5a is the first bad

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-01 Thread Jan Vesely
On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: > Does the attached patch fix the copy-buffer test? it does thanks. Won't the compute only context still need some synchronization? Is there anything else to guarantee that the data is in place after return from resource_copy_region ? thanks,

[Mesa-dev] [Bug 110301] mesa-git reports Vulkan 1.1.90

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110301 Bug ID: 110301 Summary: mesa-git reports Vulkan 1.1.90 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #14 from Michel Dänzer --- (In reply to Jan Vesely from comment #13) > anyone feel free to correct me, my work on CL was mostly outside mesa, so I > might have misunderstood the state_tracker/pipe_driver split. You're spot on. Code

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #13 from Jan Vesely --- (In reply to Timur Kristóf from comment #12) > Jan, the commit you linked adds a dependency from the gallium auxiliary lib > to the glsl compiler. This is required by tgsi_to_nir for calling >

Re: [Mesa-dev] [PATCH] docs: Fix 19.0.x version numbers

2019-04-01 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Apr 1, 2019 at 5:58 PM Guido Günther wrote: > > The list has 19.0.2 twice. > > Signed-off-by: Guido Günther > --- > docs/release-calendar.html | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/release-calendar.html

Re: [Mesa-dev] [PATCH 6/6] radv: partially enable VK_KHR_shader_float16_int8

2019-04-01 Thread Bas Nieuwenhuizen
hmm, okay, r-b then. On Mon, Apr 1, 2019 at 5:24 PM Samuel Pitoiset wrote: > > > On 4/1/19 5:22 PM, Bas Nieuwenhuizen wrote: > > On Mon, Apr 1, 2019 at 4:15 PM Samuel Pitoiset > > wrote: > >> Only 8-bit integers for now, float16 requires a bit more work. > >> > >> Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] docs: Fix 19.0.x version numbers

2019-04-01 Thread Guido Günther
The list has 19.0.2 twice. Signed-off-by: Guido Günther --- docs/release-calendar.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index 0b0bb138b12..35965f68de8 100644 --- a/docs/release-calendar.html +++

Re: [Mesa-dev] [PATCH 6/6] radv: partially enable VK_KHR_shader_float16_int8

2019-04-01 Thread Samuel Pitoiset
On 4/1/19 5:22 PM, Bas Nieuwenhuizen wrote: On Mon, Apr 1, 2019 at 4:15 PM Samuel Pitoiset wrote: Only 8-bit integers for now, float16 requires a bit more work. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 8 src/amd/vulkan/radv_extensions.py | 1 +

Re: [Mesa-dev] [PATCH 5/6] ac: add 8-bit and 64-bit support to ac_build_bitfield_reverse()

2019-04-01 Thread Bas Nieuwenhuizen
Patches 1-5 are r-b me. On Mon, Apr 1, 2019 at 4:15 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c >

Re: [Mesa-dev] [PATCH 6/6] radv: partially enable VK_KHR_shader_float16_int8

2019-04-01 Thread Bas Nieuwenhuizen
On Mon, Apr 1, 2019 at 4:15 PM Samuel Pitoiset wrote: > > Only 8-bit integers for now, float16 requires a bit more work. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 8 > src/amd/vulkan/radv_extensions.py | 1 + > src/amd/vulkan/radv_shader.c | 1

Re: [Mesa-dev] [PATCH v5 35/38] intel/compiler: validate region restrictions for mixed float mode

2019-04-01 Thread Juan A. Suarez Romero
On Wed, 2019-03-27 at 19:37 -0700, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > From: Iago Toral Quiroga > > > > v2: > > - Adapted unit tests to make them consistent with the changes done > >to the validation of half-float conversions. > > --- > >

Re: [Mesa-dev] [PATCH 2/2] radv: do not lower 16-bit FMA

2019-04-01 Thread Samuel Pitoiset
On 4/1/19 4:02 PM, Bas Nieuwenhuizen wrote: This seems weird, do you know which tests are affected? All 16-bit fma tests. (I suspect what we really want to do is split into fmuladd and fma, and only lower fmuladd. If that does not work, something else is definitely going on) I will

Re: [Mesa-dev] [PATCH v3 3/3] egl: add config debug printout (v3)

2019-04-01 Thread Silvestrs Timofejevs
On Mon, Jan 14, 2019 at 08:20:09PM +, Emil Velikov wrote: > e aOn Fri, 11 Jan 2019 at 16:34, Silvestrs Timofejevs > wrote: > > > > Feature to print out EGL returned configs for debug purposes. > > > > 'eglChooseConfig' and 'eglGetConfigs' debug information printout is > > enabled when the

[Mesa-dev] [PATCH 4/6] ac: add 8-bit support to ac_build_umsb()

2019-04-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index f8d28a59cfe..8d749cc8eb0 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 3/6] ac: add 8-bit support to ac_find_lsb()

2019-04-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 6d26ab31a66..f8d28a59cfe 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 6/6] radv: partially enable VK_KHR_shader_float16_int8

2019-04-01 Thread Samuel Pitoiset
Only 8-bit integers for now, float16 requires a bit more work. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 8 src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_shader.c | 1 + 3 files changed, 10 insertions(+) diff --git

[Mesa-dev] [PATCH 2/6] ac: add 8-bit support to ac_build_bit_count()

2019-04-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index fe280b31368..6d26ab31a66 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 5/6] ac: add 8-bit and 64-bit support to ac_build_bitfield_reverse()

2019-04-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 8d749cc8eb0..54e90288bda 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 1/6] ac/nir: add support for nir_op_b2i8

2019-04-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 4e9af58538f..6739551ca26 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

Re: [Mesa-dev] [PATCH 2/2] radv: do not lower 16-bit FMA

2019-04-01 Thread Bas Nieuwenhuizen
This seems weird, do you know which tests are affected? (I suspect what we really want to do is split into fmuladd and fma, and only lower fmuladd. If that does not work, something else is definitely going on) On Mon, Mar 25, 2019 at 4:10 PM Samuel Pitoiset wrote: > > The lowering needs to be

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #12 from Timur Kristóf --- Jan, the commit you linked adds a dependency from the gallium auxiliary lib to the glsl compiler. This is required by tgsi_to_nir for calling gl_nir_lower_samplers and gl_nir_lower_samplers_as_deref,

[Mesa-dev] [Bug 109939] After upgrade mesa to 19.0.0 stop working the game Rise of the Tomb Raider

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109939 --- Comment #24 from Timur Kristóf --- Sorry for my late reply. Yes, I use the Fedora packages, so it might be the same problem. The issue is still there with 19.0.1 on Fedora 30. In fact, I can confirm that the game overall performs much worse

[Mesa-dev] [PATCH] gallium: ddebug: Add missing fence related wrappers

2019-04-01 Thread Guido Günther
Without that `GALLIUM_DDEBUG=always kmscube -A` would segfault like #0 0x in () #1 0xa72a3c54 in dri2_get_fence_fd (_screen=0xed4f2090, _fence=0xed9ef880) at ../src/gallium/state_trackers/dri/dri_helpers.c:140 #2 0xa8744824 in

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-04-01 Thread Emil Velikov
Hi all, On Wed, 27 Mar 2019 at 12:04, Emil Velikov wrote: > > Hello list, > > The candidate for the Mesa 18.3.6 is now available. Currently we have: > - 19 queued > - 0 nominated (outstanding) > - and 0 rejected patches > > > Note: this is the final anticipated release in the 18.3 series.

[Mesa-dev] [PATCH] iris: Adapt to variable ppGTT size

2019-04-01 Thread Chris Wilson
Not all hardware is made equal and some does not have the full complement of 48b of address space. Ask what the actual size of virtual address space allocated for contexts, and bail if that is not enough to satisfy our static partitioning needs. Cc: Kenneth Graunke ---

[Mesa-dev] [Bug 109548] Seeing visual corruption in totem after installing amdgpu 18.50 in Ubuntu 18.04.1

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109548 Michel Dänzer changed: What|Removed |Added CC||leonm...@gmail.com --- Comment #6 from

Re: [Mesa-dev] [PATCH v3 2/3] egl: introduce a log level getter function

2019-04-01 Thread Silvestrs Timofejevs
Hi Emil, thank you for your review. On Mon, Jan 14, 2019 at 07:55:07PM +, Emil Velikov wrote: > On Mon, 14 Jan 2019 at 18:20, Emil Velikov wrote: > > > > On 2019/01/11, Silvestrs Timofejevs wrote: > > > Being able to retrieve the log level can be useful to enable/disable > > > debug code.

[Mesa-dev] [Bug 108596] [RADV] Implement a HUD for monitoring GPU/CPU loads, FPS, temperature and more

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108596 --- Comment #7 from Samuel Pitoiset --- Yeah, and the plan is to expose more driver queries in the future, like what the GALLIUM_HUD actually does. -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 108596] [RADV] Implement a HUD for monitoring GPU/CPU loads, FPS, temperature and more

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108596 --- Comment #6 from Lionel Landwerlin --- (In reply to Samuel Pitoiset from comment #5) > The Vulkan overlay still doesn't allow to monitor GPU load/temperature, etc > (as requested). We need a new extension for that. There is still an MR that

[Mesa-dev] [Bug 108766] Mesa built with meson has RPATH entries

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108766 Eric Engestrom changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 1/5] ac/nir: fix nir_op_b2i16

2019-04-01 Thread Bas Nieuwenhuizen
r-b for the series. On Tue, Mar 26, 2019 at 11:31 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [Bug 108596] [RADV] Implement a HUD for monitoring GPU/CPU loads, FPS, temperature and more

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108596 Samuel Pitoiset changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Mesa-dev] [Bug 109805] GPU hangs with error VM_CONTEXT1_PROTECTION_FAULT_STATUS

2019-04-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109805 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---