Re: [Mesa-dev] [PATCH 00/11] i965 shader debug through KHR_debug

Did this get dropped on the ground? On Fri, Dec 7, 2018 at 12:07 PM Mark Janes wrote: > Ilia Mirkin writes: > > > On Thu, Dec 6, 2018 at 7:36 PM Mark Janes > wrote: > >> > >> This series provides Intel shader compilation debug information via > >> KHR_debug. Previously, shader assembly and

Re: [Mesa-dev] [PATCH] gallium: set PIPE_CAP_MAX_FRAMES_IN_FLIGHT to 2 for all drivers

On Tuesday, April 23, 2019 6:23:32 PM PDT Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_screen.c| 4 +++- > src/gallium/drivers/freedreno/freedreno_screen.c | 3 --- > src/gallium/drivers/i915/i915_screen.c | 3 --- >

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On 24/4/19 10:59 am, Jason Ekstrand wrote: On Tue, Apr 23, 2019 at 7:39 PM Timothy Arceri > wrote: On 24/4/19 1:45 am, Samuel Pitoiset wrote: > > On 4/23/19 5:16 PM, Jason Ekstrand wrote: >> On Tue, Apr 23, 2019 at 7:46 AM Samuel Pitoiset >>

[Mesa-dev] [PATCH] gallium: set PIPE_CAP_MAX_FRAMES_IN_FLIGHT to 2 for all drivers

From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c| 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 3 --- src/gallium/drivers/i915/i915_screen.c | 3 --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 3 ---

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On Tue, Apr 23, 2019 at 7:39 PM Timothy Arceri wrote: > On 24/4/19 1:45 am, Samuel Pitoiset wrote: > > > > On 4/23/19 5:16 PM, Jason Ekstrand wrote: > >> On Tue, Apr 23, 2019 at 7:46 AM Samuel Pitoiset > >> mailto:samuel.pitoi...@gmail.com>> wrote: > >> > >> > >> On 4/23/19 10:45 AM, Bas

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On 24/4/19 1:45 am, Samuel Pitoiset wrote: On 4/23/19 5:16 PM, Jason Ekstrand wrote: On Tue, Apr 23, 2019 at 7:46 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: On 4/23/19 10:45 AM, Bas Nieuwenhuizen wrote: > On Tue, Apr 23, 2019 at 9:35 AM Samuel Pitoiset >

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

Adam, did you notice my original suggestion "If there is at least 1 drm device, swrast won't be in the list."? which means swrast would be in the list for your "dumb" GPUs. Marek On Tue, Apr 23, 2019 at 7:52 PM Adam Jackson wrote: > On Tue, 2019-04-23 at 19:21 -0400, Marek Olšák wrote: > > >

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

On Tue, 2019-04-23 at 19:21 -0400, Marek Olšák wrote: > Then I think a separate EGL extension that exposes swrast would be > better. The thing with the device extensions is that swrast is not a > device. Enh. I've got dumb GPUs I need to support, they need to run OpenGL, and if they were running

[Mesa-dev] [Bug 110455] Land adaptive_sync support

https://bugs.freedesktop.org/show_bug.cgi?id=110455 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 110439] [TRACKER] Mesa 19.1 feature tracker

https://bugs.freedesktop.org/show_bug.cgi?id=110439 Bug 110439 depends on bug 110455, which changed state. Bug 110455 Summary: Land adaptive_sync support https://bugs.freedesktop.org/show_bug.cgi?id=110455 What|Removed |Added

Re: [Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

On Tue, Apr 23, 2019 at 7:30 PM Marek Olšák wrote: > On Tue, Apr 23, 2019 at 4:49 PM Kenneth Graunke > wrote: > >> On Monday, April 22, 2019 6:29:43 PM PDT Marek Olšák wrote: >> > From: Marek Olšák >> > >> > for better CPU-GPU parallelism >> > --- >> >

Re: [Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

On Tue, Apr 23, 2019 at 4:49 PM Kenneth Graunke wrote: > On Monday, April 22, 2019 6:29:43 PM PDT Marek Olšák wrote: > > From: Marek Olšák > > > > for better CPU-GPU parallelism > > --- > > src/gallium/state_trackers/dri/dri_drawable.c | 20 +-- > > 1 file changed, 10

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

On Tue, Apr 23, 2019 at 6:30 PM Eric Anholt wrote: > Marek Olšák writes: > > > On Tue, Apr 23, 2019 at 4:39 PM Mathias Fröhlich < > mathias.froehl...@gmx.net> > > wrote: > > > >> Hi, > >> > >> On Tuesday, 23 April 2019 22:23:45 CEST Marek Olšák wrote: > >> > On Tue, Apr 23, 2019 at 4:05 PM

[Mesa-dev] [Bug 110439] [TRACKER] Mesa 19.1 feature tracker

https://bugs.freedesktop.org/show_bug.cgi?id=110439 Andrés Gómez García changed: What|Removed |Added Depends on||110501 Referenced Bugs:

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

Marek Olšák writes: > On Tue, Apr 23, 2019 at 4:39 PM Mathias Fröhlich > wrote: > >> Hi, >> >> On Tuesday, 23 April 2019 22:23:45 CEST Marek Olšák wrote: >> > On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich < >> mathias.froehl...@gmx.net> >> > wrote: >> > >> > > Hi Marek, >> > > >> > > On

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

> Off the top of my head - none of the VL code should be build when we > have only a swrast driver. > Can you try and kill that bug, or shall I? Isn't that what this patch does? If there's only swrast, this patch prevents enabling any of the state trackers, so need_gallium_vl won't be set, and

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

On Tue, Apr 23, 2019 at 4:39 PM Mathias Fröhlich wrote: > Hi, > > On Tuesday, 23 April 2019 22:23:45 CEST Marek Olšák wrote: > > On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich < > mathias.froehl...@gmx.net> > > wrote: > > > > > Hi Marek, > > > > > > On Tuesday, 23 April 2019 20:22:15 CEST

Re: [Mesa-dev] [PATCH] gallium: document conservative rasterization flags

On Monday, April 22, 2019 10:25:57 AM PDT Marek Olšák wrote: [snip] > /** > * Conservative rasterization modes. > */ > enum pipe_conservative_raster_mode > { > PIPE_CONSERVATIVE_RASTER_OFF, > + > + /** > +* The post-snap mode means the conservative rasterization occurs after > +

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

On Monday, April 22, 2019 3:21:22 PM PDT Eric Anholt wrote: > Jason Ekstrand writes: > > > All, > > > > I've seen discussions come up several times lately about whether you should > > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them > > anyway. That got me thinking a

Re: [Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

On Monday, April 22, 2019 6:29:43 PM PDT Marek Olšák wrote: > From: Marek Olšák > > for better CPU-GPU parallelism > --- > src/gallium/state_trackers/dri/dri_drawable.c | 20 +-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

Hi, On Tuesday, 23 April 2019 22:23:45 CEST Marek Olšák wrote: > On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich > wrote: > > > Hi Marek, > > > > On Tuesday, 23 April 2019 20:22:15 CEST Marek Olšák wrote: > > > I'd like to remove swrast from devices. It doesn't work (eglInitialize > > > fails)

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich wrote: > Hi Marek, > > On Tuesday, 23 April 2019 20:22:15 CEST Marek Olšák wrote: > > I'd like to remove swrast from devices. It doesn't work (eglInitialize > > fails) and I don't think I like swrast there. Any objections? > > Yes, how do you

Re: [Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

No, the correct backport is attached. Marek On Tue, Apr 23, 2019 at 2:51 PM Dylan Baker wrote: > Hi Marek and Samuel, > > I've staged this for 19.0, but I had to fix some very minor rebase > conflicts. > I'm getting ready to make a release, could one of you take a peak at the > tip of > the

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

Hi Marek, On Tuesday, 23 April 2019 20:22:15 CEST Marek Olšák wrote: > I'd like to remove swrast from devices. It doesn't work (eglInitialize > fails) and I don't think I like swrast there. Any objections? Yes, how do you guarantee that at least one device can be returned in any case? Even if no

Re: [Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

Looks good to me. On 4/23/19 8:51 PM, Dylan Baker wrote: Hi Marek and Samuel, I've staged this for 19.0, but I had to fix some very minor rebase conflicts. I'm getting ready to make a release, could one of you take a peak at the tip of the staging/19.0 branch and let me know if what I did

[Mesa-dev] [Bug 110323] mesa-19.0.1 fails to compile with llvm-8.0.0 and Gallium swr driver

https://bugs.freedesktop.org/show_bug.cgi?id=110323 --- Comment #6 from Jan Zielinski --- That's correct, worked in 18.0.0 and 18.1.0. The change breaking 32-bit compilation was introduced in 18.2.0. It should be fixed in one of the upcoming releases. As a workaround (again!) to build 32-bit

Re: [Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

Hi Marek and Samuel, I've staged this for 19.0, but I had to fix some very minor rebase conflicts. I'm getting ready to make a release, could one of you take a peak at the tip of the staging/19.0 branch and let me know if what I did looks okay? Thanks, Dylan Quoting Samuel Pitoiset (2019-04-16

[Mesa-dev] [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI

https://bugs.freedesktop.org/show_bug.cgi?id=100105 --- Comment #13 from b...@besd.de --- Unfortunately it turns out that even a working opencl (used the closed AMD legacy driver) isnt getting the application i'm trying to run (see above) to work. At some point it complains that a data structure

[Mesa-dev] [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI

https://bugs.freedesktop.org/show_bug.cgi?id=100105 --- Comment #12 from b...@besd.de --- Seems about right CLOVER_DEVICE_VERSION_OVERRIDE=1.2 CLOVER_DEVICE_CLC_VERSION_OVERRIDE=1.2 DEVICE="opencl0:0" python3 -c "import pygpu;pygpu.test()" pygpu is installed in

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

I'd like to remove swrast from devices. It doesn't work (eglInitialize fails) and I don't think I like swrast there. Any objections? Marek On Wed, Apr 17, 2019 at 12:38 AM Mathias Fröhlich wrote: > > Hi, > > On Tuesday, 16 April 2019 17:50:33 CEST Marek Olšák wrote: > > On Wed, Apr 10, 2019 at

[Mesa-dev] [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI

https://bugs.freedesktop.org/show_bug.cgi?id=100105 --- Comment #11 from Jan Vesely --- It has been some time that I ran theano. Does the error happen even if it's built without clBLAS support? clBLAS depends on CL1.2 features which are not implemented, yet. (hence the dependence on 94273) --

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On 4/23/19 5:16 PM, Jason Ekstrand wrote: On Tue, Apr 23, 2019 at 7:46 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: On 4/23/19 10:45 AM, Bas Nieuwenhuizen wrote: > On Tue, Apr 23, 2019 at 9:35 AM Samuel Pitoiset > mailto:samuel.pitoi...@gmail.com>> wrote:

Re: [Mesa-dev] [PATCH] st/mesa/radeonsi: fix race between destruction of types and shader compilation

Reviewed-by: Marek Olšák Marek On Tue, Apr 23, 2019 at 2:04 AM Timothy Arceri wrote: > Commit 624789e3708c moved the destruction of types out of atexit() and > made use of a ref count instead. This is useful for avoiding a crash > where drivers such as radeonsi are still compiling in a thread

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On Tue, Apr 23, 2019 at 7:46 AM Samuel Pitoiset wrote: > > On 4/23/19 10:45 AM, Bas Nieuwenhuizen wrote: > > On Tue, Apr 23, 2019 at 9:35 AM Samuel Pitoiset > > wrote: > >> Signed-off-by: Samuel Pitoiset > >> --- > >> src/amd/vulkan/radv_shader.c | 2 +- > >>

Re: [Mesa-dev] [PATCH 1/3] pipebuffer: use new pb_usage_flags enum type

It was committed in early March: b286e74df66e25cadd1c82d9ddc4d1fc3887b646 -Brian On 04/23/2019 07:25 AM, Thomas Hellstrom wrote: Hi, Brian, Did this series get reviewed? I don't see any replies? /Thomas On Tue, 2019-03-05 at 20:48 -0700, Brian Paul wrote: Use a new enum type instead of

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #16 from Timur Kristóf --- Can you guys try this branch? https://gitlab.freedesktop.org/Venemo/mesa/commits/nir-lower-samplers It seems to work for me at least on radeonsi, but I haven't been able to test it thoroughly yet. --

Re: [Mesa-dev] [PATCH 1/3] pipebuffer: use new pb_usage_flags enum type

Hi, Brian, Did this series get reviewed? I don't see any replies? /Thomas On Tue, 2019-03-05 at 20:48 -0700, Brian Paul wrote: > Use a new enum type instead of 'unsigned' to make things a bit more > understandable. > --- > src/gallium/auxiliary/pipebuffer/pb_buffer.h | 34 >

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On 4/23/19 10:45 AM, Bas Nieuwenhuizen wrote: On Tue, Apr 23, 2019 at 9:35 AM Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 2 +- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_opt_if.c

[Mesa-dev] [PATCH] radv: do not load vertex attributes that are not provided by the pipeline

Per the Vulkan spec this is definitely invalid but X4 Foundations does that and it ends up by hanging the GPU. Found while enabling validation layers with the game. The issue will be reported to the developers. Cc: "19.0" mesa-sta...@lists.freedesktop.org Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH v2] st: require compatible driver in autotools

On Fri, 19 Apr 2019 at 19:53, Alyssa Ross wrote: > > The meson build system already has these checks. I've just copied them > to autotools. > > Without this, state trackers could be enabled when building with the > following set of options, which resulted in a compile error due to VL > being

Re: [Mesa-dev] [PATCH] radv: disable DCC for X4 Foundations to workaround a GPU hang

Please ignore this fix too, the GPU hang is actually unrelated to DCC. On 3/6/19 7:39 PM, Samuel Pitoiset wrote: The game apparently hangs inside a copy image operation, but only when DCC is enabled. I haven't figured out the root cause yet, but this workaround fixes the problem and allows

Re: [Mesa-dev] [PATCH] radv: increase aligment when allocating descriptors for meta operations

Please ignore this fix, it's incorrect and we shouldn't have to increase alignment. On 3/7/19 11:43 AM, Samuel Pitoiset wrote: We usually align to 0x100 when allocating descriptors and resources in the upload BO. I assume some data were corrupted because the alignment was too small. Be

Re: [Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

On Tue, 2019-04-23 at 10:00 +0300, Tapani Pälli wrote: > Remember to add: > > --- 8< --- > Fixes the following test: > KHR-GL44.enhanced_layouts.xfb_output_overlapping > --- 8< --- Good point. I developed this patch when this test was yet not "corrected" and failing for us. > > > See below

[Mesa-dev] [Bug 110462] Epic Games Launcher renders nothing with "-opengl" option

https://bugs.freedesktop.org/show_bug.cgi?id=110462 --- Comment #6 from Danylo --- > As far as I recall apitrace records the profile it was given not the profile > that the application requests. I have copied the function call itself which I think apitrace doesn't change. It can show a

[Mesa-dev] [Bug 110472] Graphical Fault (Desktop Freeze) on Specific OpenGL Application

https://bugs.freedesktop.org/show_bug.cgi?id=110472 Michel Dänzer changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

On Tue, Apr 23, 2019 at 9:35 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_shader.c | 2 +- > src/compiler/nir/nir.h | 3 ++- > src/compiler/nir/nir_opt_if.c| 17 ++--- >

[Mesa-dev] [PATCH 2/2] radv: workaround a GPU hang with No Man Sky by skipping split_alu_of_phi

This pass seems totally correct, as well as the generated NIR and LLVM IR for the revelant shader that hangs the GPU. This likely triggers a new bug in LLVM which has to be fixed. As LLVM 7&8 have already been released we need a workaround. According to my collection of vkpipeline-db shaders,

Re: [Mesa-dev] [PATCH 3/8] etnaviv: remember data offset into BO

Am Fr., 12. Apr. 2019 um 19:38 Uhr schrieb Lucas Stach : > > Imported resources might not start at offset 0 into the buffer object. > Make sure to remember the offset that is provided with the handle on > import. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH 7/8] etnaviv: improve PIPE_BIND_LINEAR handling

Am Fr., 12. Apr. 2019 um 19:38 Uhr schrieb Lucas Stach : > > We weren't handling this flag at all, which broke some assumptions > made by the users of the resource_create interface. As we can't render > to a linear surface and the usefulness of yet another layout transition > to handle this case

[Mesa-dev] [PATCH 1/2] nir: add an option for skipping split_alu_of_phi

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 2 +- src/compiler/nir/nir.h | 3 ++- src/compiler/nir/nir_opt_if.c| 17 ++--- src/freedreno/ir3/ir3_nir.c | 2 +-

Re: [Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

Remember to add: --- 8< --- Fixes the following test: KHR-GL44.enhanced_layouts.xfb_output_overlapping --- 8< --- See below for one addition: On 4/22/19 3:00 AM, Andres Gomez wrote: From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: " No aliasing in output buffers is allowed:

[Mesa-dev] [Bug 110476] Overwatch - some objects are rendered incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=110476 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/3] ac/nir: only use the new raw/struct image atomic intrinsics with LLVM 9+

On 4/22/19 7:19 PM, Marek Olšák wrote: Is "XXX" in the comment really necessary? No, but I already pushed the series. Marek On Thu, Apr 18, 2019 at 3:20 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: They are buggy with LLVM 8 because they weren't marked as source

[Mesa-dev] [Bug 110440] [REGRESSION] [BISECTED] [OpenGL CTS] dEQP-GLES2.functional.uniform_api.random.3

https://bugs.freedesktop.org/show_bug.cgi?id=110440 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] st/mesa/radeonsi: fix race between destruction of types and shader compilation

Commit 624789e3708c moved the destruction of types out of atexit() and made use of a ref count instead. This is useful for avoiding a crash where drivers such as radeonsi are still compiling in a thread when the app exits and has not called MakeCurrent to change from the current context. While