Yeah, I'll try to add descriptive commit messages next time.
Marek
On Wed, May 1, 2019 at 11:22 PM Timothy Arceri
wrote:
> I feel like I've asked this before but can you please try to add commit
> proper commit messages. Not adding a proper commit message might save
> you a minute or two but
The pattern of calling opt algebraic first seems to have originated
in i965. The order in OpenGL drivers generally doesn't matter
because the GLSL IR optimisations do constant folding before
opt algebraic.
However in Vulkan drivers calling opt algebraic first can result
in missed constant folding
Sorry, missed this one.
It seems
https://github.com/KhronosGroup/GLSL/blob/master/extensions/nv/GLSL_NV_compute_shader_derivatives.txt
don't explicitly mention the interaction with EXT_texture_array but
seems reasonable to enable those.
This patch is
Reviewed-by: Caio Marcelo de Oliveira Filho
I feel like I've asked this before but can you please try to add commit
proper commit messages. Not adding a proper commit message might save
you a minute or two but it cost much more than a minute or two for those
trying to review a patch or that have bisect to the commit, used git
blame, git
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 67 +++--
src/gallium/drivers/panfrost/pan_mfbd.c | 11 +++-
src/gallium/drivers/panfrost/pan_resource.c | 21 +--
src/gallium/drivers/panfrost/pan_screen.c | 8 +--
4 files changed, 78
If there is no other feedback, I'll push this tomorrow.
Marek
On Mon, Apr 29, 2019 at 6:12 PM Marek Olšák wrote:
> This patch might improve performance, because less submitted unfinished
> work means less used memory by the unfinished work.
>
> Marek
>
> On Mon, Apr 29, 2019 at 11:07 AM Michel
Ping
On Wed, Apr 24, 2019 at 1:30 PM Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/compiler/glsl/builtin_functions.cpp | 78 -
> 1 file changed, 24 insertions(+), 54 deletions(-)
>
> diff --git a/src/compiler/glsl/builtin_functions.cpp
>
Well, kinda a fix. Jason noticed that there were parts of the ext I
disabled but apparently implementations are required to enable them
(see 028ce527395642b68612d10c6030be5d4706a65e).
Though, I think this was backported under the assumption that
028ce527395642b68612d10c6030be5d4706a65e also was,
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, May 1, 2019 2:55 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; Deepak Singh Rawat; Thomas Hellstrom;
mesa-sta...@lists.freedesktop.org
Subject:
From: Charmaine Lee
This patch adds a host_log interface to svga_winsys and
moves the host logging code to the winsys layer.
Reviewed-by: Brian Paul
---
src/gallium/drivers/svga/Makefile.sources | 2 -
src/gallium/drivers/svga/meson.build | 1 -
valgrind crashes when we try to initialize host logging. This
env var can be used to disable logging.
v2: rebase onto "svga: move host logging to winsys".
Cc: mesa-sta...@lists.freedesktop.org
---
docs/envvars.html | 3 +++
src/gallium/drivers/svga/svga_screen.c | 16
https://bugs.freedesktop.org/show_bug.cgi?id=109560
Viktor Jägersküpper changed:
What|Removed |Added
CC||viktor_jaegerskuepper@freen
On Thu, 2 May 2019 at 05:36, Viktor Jaegerskuepper
wrote:
>
> Dave Airlie:
> > On Wed, 1 May 2019 at 12:34, Ilia Mirkin wrote:
> >>
> >> On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote:
> >>>
> >>> On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote:
>
> On Tue, 30 Apr 2019 at
LGTM
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, May 1, 2019 1:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca; Charmaine Lee
Subject: [PATCH] glsl: work around MinGW 7.x compiler bug
I'm not sure
Looks good to me.
Reviewed-by: Jose Fonseca
From: Brian Paul
Sent: Wednesday, May 1, 2019 21:28
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca; Charmaine Lee
Subject: [PATCH] glsl: work around MinGW 7.x compiler bug
I'm not sure what
https://bugs.freedesktop.org/show_bug.cgi?id=110573
--- Comment #3 from james.dut...@gmail.com ---
I have the same issue, bisected to the same commit as you.
I have a Vega 56 and LLVM 8 also.
FYI. If you edit it back to be
if (HAVE_LLVM >= 0x800) {
The artifacts and crashing disappear.
--
You
I'm not sure what triggered this, but building with
scons platform=windows toolchain=crossmingw machine=x86 build=profile
with MinGW g++ 7.3 or 7.4 causes an internal compiler error.
We can work around it by forcing -O1 optimization.
---
src/compiler/glsl/builtin_variables.cpp | 15
wait what? Are we backporting a new feature into a stable branch? Do we
really need that?
On 5/1/19 6:35 PM, GitLab Mirror wrote:
Module: Mesa
Branch: staging/19.0
Commit: a1cdab7bd4ecad7c1c518fb8430613a7559d4f9d
URL:
BTW, swrast doesn't have to exist on the system. It's not uncommon for me
to have no swrast on my development system.
Marek
On Wed, May 1, 2019 at 4:30 AM Mathias Fröhlich
wrote:
> Hi Marek, Emil,
>
> On Tuesday, 30 April 2019 15:36:08 CEST Emil Velikov wrote:
> > On Mon, 29 Apr 2019 at 22:50,
Dave Airlie:
> On Wed, 1 May 2019 at 12:34, Ilia Mirkin wrote:
>>
>> On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote:
>>>
>>> On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote:
On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote:
>
> On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin
https://bugs.freedesktop.org/show_bug.cgi?id=110350
--- Comment #9 from ant...@gmx.de ---
could you try reverting:
https://github.com/mesa3d/mesa/commit/b5ea4378c3260ff003532c8138a81a57091bdaa0#diff-078b981b454c93e62531f44768fca61d
ac/nir: only use the new raw/struct image atomic intrinsics
https://bugs.freedesktop.org/show_bug.cgi?id=110573
--- Comment #2 from ant...@gmx.de ---
Just FYI currently on running LLVM 8
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=110573
--- Comment #1 from ant...@gmx.de ---
I narrowed the issue to a specific commit:
https://github.com/mesa3d/mesa/commit/b5ea4378c3260ff003532c8138a81a57091bdaa0#diff-078b981b454c93e62531f44768fca61d
ac/nir: only use the new raw/struct image
LGTM.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Wednesday, May 1, 2019 9:48 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [Mesa-dev] [PATCH] llvmpipe: init some vars to NULL to silence MinGW
Looks reasonable to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Wednesday, May 1, 2019 9:48 AM
To: mesa-dev@lists.freedesktop.org
Cc: mesa-sta...@lists.freedesktop.org; Neha Bhende; Deepak Singh Rawat
https://bugs.freedesktop.org/show_bug.cgi?id=110573
Bug ID: 110573
Summary: Mesa vulkan-radeon 19.0.3 system freeze and visual
artifacts (RADV)
Product: Mesa
Version: 19.0
Hardware: x86-64 (AMD64)
OS: Linux
Hi Brian,
I belive svgascreen->sws->host_log is causing this issue, am I right?
If so shoudn't we handle this in vmw_svga_winsys_host_log if host_log
is called from other places as well? Other than this
Reviewed-by: Deepak Rawat
On Wed, 2019-05-01 at 10:48 -0600, Brian Paul wrote:
> valgrind
---
src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c
b/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c
index 9561c34..90b2be9 100644
---
valgrind crashes when we try to initialize host logging. This
env var can be used to disable logging.
Cc: mesa-sta...@lists.freedesktop.org
---
docs/envvars.html | 3 +++
src/gallium/drivers/svga/svga_screen.c | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff
On 2019-05-01 at 08:18, Juan A. Suarez Romero wrote:
> Fixes scons/mingw building:
>
> src/util/os_file.c: In function ‘os_read_file’:
> src/util/os_file.c:126:11: error: ‘NULL’ undeclared (first use in this
> function); did you mean ‘_DLL’?
> return NULL;
>^~~~
>
https://bugs.freedesktop.org/show_bug.cgi?id=109784
Eric Engestrom changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=101933
Eric Engestrom changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEW
This chip doesn't need the fixup. This fixes a bunch of
dEQP-VK.tessellation tests and avoid random GPU hangs.
Cc: "19.0"
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_nir_to_llvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/vulkan/radv_nir_to_llvm.c
https://bugs.freedesktop.org/show_bug.cgi?id=80848
Eric Engestrom changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Wed, May 1, 2019 at 12:30 AM Dave Airlie wrote:
>
> From: Dave Airlie
>
> If no view is bound we still should reset the override to 0
> and array mode.
>
> This should fix misrendering in firefox WebRender since
> the pbo sampler was removed.
>
> Fixes: 1250383e36 (st/mesa: remove sampler
https://bugs.freedesktop.org/show_bug.cgi?id=109599
--- Comment #27 from tempel.jul...@gmail.com ---
Yey, it seems it is fixed without any drawbacks, as far as I can tell. :)
HotS:
amdvlk:
https://abload.de/img/amdvlkbjjv9.png
radv old:
https://abload.de/img/radvoldl3kd3.png
radv new:
I've uploaded this MR :
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/776
Which actually highlights a bigger issue with our queries.
-Lionel
On 01/05/2019 11:58, Lionel Landwerlin wrote:
Experimenting a bit with the visibility of PIPE_CONTROL writes & MI_*
commands I realized those
Experimenting a bit with the visibility of PIPE_CONTROL writes & MI_*
commands I realized those are not coherent.
Essentially anything written with a PIPE_CONTROL will be visible to MI_*
commands only after some time.
In my experiment I had to insert 2 MI instructions after the
PIPE_CONTROL
https://bugs.freedesktop.org/show_bug.cgi?id=109599
--- Comment #26 from Samuel Pitoiset ---
Created attachment 144120
--> https://bugs.freedesktop.org/attachment.cgi?id=144120=edit
bias change
Can you try with this change applied?
--
You are receiving this mail because:
You are the
Hi Marek,
On Tuesday, 30 April 2019 01:10:42 CEST Marek Olšák wrote:
> I'm adding this hunk, which makes the test pass:
>
> diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c
> index 1ac0d5d0798..a46599a2872 100644
> --- a/src/mesa/main/buffers.c
> +++ b/src/mesa/main/buffers.c
> @@
Hi Marek, Emil,
On Tuesday, 30 April 2019 15:36:08 CEST Emil Velikov wrote:
> On Mon, 29 Apr 2019 at 22:50, Marek Olšák wrote:
> >
> > On Mon, Apr 29, 2019 at 4:00 AM Pekka Paalanen wrote:
> >>
> >> On Sat, 27 Apr 2019 09:38:27 -0400
> >> Marek Olšák wrote:
> >>
> >> > Those are all valid
Fixes scons/mingw building:
src/util/os_file.c: In function ‘os_read_file’:
src/util/os_file.c:126:11: error: ‘NULL’ undeclared (first use in this
function); did you mean ‘_DLL’?
return NULL;
^~~~
_DLL
src/util/os_file.c:126:11: note: each undeclared identifier is
42 matches
Mail list logo
