On Thu, 9 May 2019 at 17:16, Emil Velikov wrote:
>
> On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
> >
> > These tests add too much time to the total run time, and some of them
> > even hang the DUTs, even if I haven't been able to reproduce it locally.
> >
> > Signed-off-by: Tomeu Vizoso
>
From: Marek Olšák
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 4a2377f7e09..5b840caf885 100644
---
From: Marek Olšák
just a cleanup
---
src/amd/common/ac_llvm_build.c| 15 ++-
src/amd/common/ac_nir_to_llvm.c | 2 +-
src/amd/vulkan/radv_nir_to_llvm.c | 8 +---
3 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c
From: Marek Olšák
This allows a nice cleanup, because the winsys always handles it.
---
src/amd/common/ac_gpu_info.c | 2 --
src/amd/common/ac_gpu_info.h | 1 -
src/gallium/drivers/r600/r600_pipe_common.c | 16 ++-
From: Marek Olšák
To make it behave like amdgpu. I'm just trying to move this out of
radeonsi. The radeonsi code will be removed in the next commit.
---
src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 29 +++
src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 5
From: Marek Olšák
This is a prerequisite for the next commit.
Cc: 19.1
---
src/gallium/drivers/radeonsi/si_buffer.c | 7 +--
src/gallium/drivers/radeonsi/si_descriptors.c | 54 ---
src/gallium/drivers/radeonsi/si_state.h | 4 +-
3 files changed, 25 insertions(+),
From: Marek Olšák
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108824
Cc: 19.1
---
src/gallium/drivers/radeonsi/si_descriptors.c | 94 ---
src/gallium/drivers/radeonsi/si_pipe.h| 2 +
src/gallium/drivers/radeonsi/si_state_draw.c | 9 +-
3 files changed, 72
From: Marek Olšák
debugoptimized builds don't define NDEBUG, but they also don't define
DEBUG. We want to enable cheap debug code for these builds.
I only chose those occurences that I care about.
---
src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +-
From: Marek Olšák
Useful for dumping shaders.
---
src/mesa/state_tracker/st_debug.c | 4
src/mesa/state_tracker/st_debug.h | 6 --
2 files changed, 10 deletions(-)
diff --git a/src/mesa/state_tracker/st_debug.c
b/src/mesa/state_tracker/st_debug.c
index 27d50a17e5e..7faffb581ef 100644
From: Marek Olšák
---
src/amd/common/ac_binary.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c
index fabeb15a204..8f4755ebe16 100644
--- a/src/amd/common/ac_binary.c
+++ b/src/amd/common/ac_binary.c
@@ -281,25
The second half of si_shader_create that merges configs is now redundant,
isn't it?
I think the spi_ps_input_* stuff from patch 3 will also impact this patch,
right?
Patches 1-2, 5-9:
Reviewed-by: Marek Olšák
Marek
___
mesa-dev mailing list
I've got a bunch of cases where copy prop vars is getting things wrong
around casts, it finds a store to an vec2 but ends up with the
writemask staying at 0x3 but the item being store being a single
64-bit.
Debug is attached below.
Dave.
nir_lower_memcpy_deref
shader: MESA_SHADER_KERNEL
I'd like the beginning of the .c or .h file to describe what this is good
for, as it's not immediately obvious from the code.
See also below.
On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Using an explicit linker instead of just concatenating .text
> sections
Hi list,
Sorry I'm running a bit behind with this release, I was sick on Monday and had
to patch up some autotools problems in the mean time.
It's been a pretty active release, esepcially for how late in the cyle we are.
Radv was the busiest componenet, but there were also a few changes for
Heh, interesting!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=110345
--- Comment #20 from Thomas Rohloff ---
(In reply to Samuel Pitoiset from comment #18)
> What graphics settings are you using? Can you eventually record a video of
> the Video panel? That way I could try again with the same settings as you.
I
Found during code inspection.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.c
> Interesting, I wouldn't have split blend_factor from inverting the
> factor. I'm fine with it, though.
The rationale was that the code logic needs it split anyway, so the
split has to happen in one place or another... at least this way there's
less redundant enum'ing. TBH, I'd prefer Gallium
https://bugs.freedesktop.org/show_bug.cgi?id=110345
--- Comment #19 from Cameron Banfield ---
Cities: Skylines will crash in the same way (but on Ryzen PRO 7 2700U Vega 10)
so might help with re-producing and testing?
This is guaranteed to crash every time just by loading a map.
Have tested
Alyssa Rosenzweig writes:
> Complementing the new API-agnostic shader_enum blending style, we add
> helpers to translate between the two forms. Ideally, we could just use
> PIPE blending directly, but that makes Vulkan support challenging.
>
> Signed-off-by: Alyssa Rosenzweig
> Cc: Eric Anholt
Alyssa Rosenzweig writes:
> We add enums corresponding to (GLES) blend state to shader_enums.h,
> complementing the existing advanced blending enums in the file. This
> allows us to represent blending state in a driver-agnostic, API-agnostic
> way to permit lowering.
>
> Signed-off-by: Alyssa
Alyssa Rosenzweig writes:
>> Logic ops seem... challenging to emulate in the shader. That shader
>> would need the destination colors in the framebuffer storage format, and
>> I'm not sure that's always possible (maybe?).
>
> Alright, that's good to know.
>
> I will note that in Midgard, the
Since the using output optimization is only for back buffer case
Signed-off-by: Leo Liu
---
src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
index
https://bugs.freedesktop.org/show_bug.cgi?id=110655
--- Comment #4 from Jan Ziak (http://atom-symbol.net)
<0xe2.0x9a.0...@gmail.com> ---
(In reply to Lionel Landwerlin from comment #3)
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/853/
I confirm that the patch resolves the issue.
Quoting Emil Velikov (2019-05-09 03:30:14)
> On Wed, 8 May 2019 at 00:48, Dylan Baker wrote:
> >
> > Quoting Alyssa Ross (2019-05-07 06:17:15)
> > > On Mon, May 06, 2019 at 04:38:20PM -0700, Alyssa Rosenzweig wrote:
> > > > Wrong Alyssa, cc'ing the right one :)
> > >
> > > Thank you for the CC,
https://bugs.freedesktop.org/show_bug.cgi?id=110655
--- Comment #3 from Lionel Landwerlin ---
(In reply to Lionel Landwerlin from comment #2)
> https://bugs.freedesktop.org/show_bug.cgi?id=110655
Derp... https://gitlab.freedesktop.org/mesa/mesa/merge_requests/853/
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=110655
--- Comment #2 from Lionel Landwerlin ---
https://bugs.freedesktop.org/show_bug.cgi?id=110655
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 98272, which changed state.
Bug 98272 Summary: Europa Universalis IV, Hearts of Iron IV, and Stellaris fail
to display anything on XWayland
https://bugs.freedesktop.org/show_bug.cgi?id=98272
What|Removed
https://bugs.freedesktop.org/show_bug.cgi?id=110345
--- Comment #18 from Samuel Pitoiset ---
What graphics settings are you using? Can you eventually record a video of the
Video panel? That way I could try again with the same settings as you.
--
You are receiving this mail because:
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=110539
--- Comment #2 from Samuel Pitoiset ---
Can you reproduce the problem without OBS?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
On Thu, 9 May 2019 at 14:53, Christian Gmeiner
wrote:
>
> Am Fr., 3. Mai 2019 um 12:05 Uhr schrieb Philipp Zabel
> :
> >
> > Without this gbm_bo_get_offset() can return 0 where it shouldn't.
>
> Reviewed-by: Christian Gmeiner
>
Nice catch. Please include the stable tag so we get this in the
Patches 1-9 and 11 are:
Reviewed-by: Alyssa Rosenzweig
Exciting to see progress on CI on more devices... it's always an option
(if an annoying run) to run tests on a single dev device locally, but
supporting 2 devices at once!? CI truly is magic ;)
Here's to not regressing RK3288
On Thu, 9 May 2019 at 13:09, Tomeu Vizoso wrote:
>
> Just do what everybody else but Nouveau does and return 0.0f.
>
> This prevents the repeated logging of these messages on startup:
>
> Unexpected PIPE_CAPF 6 query
> Unexpected PIPE_CAPF 7 query
> Unexpected PIPE_CAPF 8 query
>
> Signed-off-by:
R-b, nice catch :)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
>
> These tests add too much time to the total run time, and some of them
> even hang the DUTs, even if I haven't been able to reproduce it locally.
>
> Signed-off-by: Tomeu Vizoso
> ---
> src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 ++
>
On Thu, 9 May 2019 at 15:49, Emil Velikov wrote:
>
> On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
> >
> > NIR_PASS will only set lower_flrp_progress if there's progress, and if
> > there isn't its value will be undefined.
> >
> > Fixes this Valgrind error:
> >
> > ==6589== Conditional jump
On Thu, 9 May 2019 at 07:36, Tomeu Vizoso wrote:
>
> As the functions operate on 16-byte blocks.
>
> Fixes this Valgrind error:
>
> Invalid read of size 4
>at 0x5857568: swizzle_bpp1_align16 (pan_swizzle.c:85)
>by 0x585780F: panfrost_texture_swizzle (pan_swizzle.c:171)
>by 0x584F587:
On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
>
> NIR_PASS will only set lower_flrp_progress if there's progress, and if
> there isn't its value will be undefined.
>
> Fixes this Valgrind error:
>
> ==6589== Conditional jump or move depends on uninitialised value(s)
> ==6589==at 0x55CA7E6:
On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
>
> Valgrind was complaining of those.
>
> NIR_PASS only sets progress to TRUE if there was progress.
>
> nir_const_load_to_arr() only sets as many constants as components has
> the instruction.
>
> This was causing some dEQP tests to flip-flop,
https://bugs.freedesktop.org/show_bug.cgi?id=108900
--- Comment #15 from Alex Deucher ---
(In reply to Eero Tamminen from comment #14)
>
> After looking at kernel firmware repo, I wonder whether the problem is
> firmware:
>
>
https://bugs.freedesktop.org/show_bug.cgi?id=108900
Eero Tamminen changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--- Comment #14 from Eero
https://bugs.freedesktop.org/show_bug.cgi?id=110655
--- Comment #1 from Lionel Landwerlin ---
Thanks, looks like it's incorrectly reusing semaphores.
Will fix.
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev
Am Fr., 3. Mai 2019 um 12:05 Uhr schrieb Philipp Zabel :
>
> Without this gbm_bo_get_offset() can return 0 where it shouldn't.
Reviewed-by: Christian Gmeiner
> ---
> src/gallium/drivers/etnaviv/etnaviv_resource.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=110655
Bug ID: 110655
Summary: VK_LAYER_MESA_OVERLAY_CONFIG=draw,fps renders
sporadically
Product: Mesa
Version: git
Hardware: Other
OS: All
Status:
https://bugs.freedesktop.org/show_bug.cgi?id=110654
Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> changed:
What|Removed |Added
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=110654
--- Comment #1 from Jan Ziak (http://atom-symbol.net)
<0xe2.0x9a.0...@gmail.com> ---
This seems to be a duplicate of issue 110606.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=110654
Bug ID: 110654
Summary: vulkan-overlay: overlay.cpp fails to build
Product: Mesa
Version: 19.1
Hardware: Other
OS: All
Status: NEW
Severity: normal
Just do what everybody else but Nouveau does and return 0.0f.
This prevents the repeated logging of these messages on startup:
Unexpected PIPE_CAPF 6 query
Unexpected PIPE_CAPF 7 query
Unexpected PIPE_CAPF 8 query
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_screen.c | 5
Move the calculation out of the compiler.
Signed-off-by: Christian Gmeiner
---
.../drivers/etnaviv/etnaviv_compiler.c| 28
.../drivers/etnaviv/etnaviv_compiler.h| 1 -
src/gallium/drivers/etnaviv/etnaviv_shader.c | 32 +--
3 files changed, 30
On Wed, 8 May 2019 at 00:48, Dylan Baker wrote:
>
> Quoting Alyssa Ross (2019-05-07 06:17:15)
> > On Mon, May 06, 2019 at 04:38:20PM -0700, Alyssa Rosenzweig wrote:
> > > Wrong Alyssa, cc'ing the right one :)
> >
> > Thank you for the CC, fellow Alyssa! :)
> >
Ahem, totally meant to do that :-)
https://bugs.freedesktop.org/show_bug.cgi?id=110636
Samuel Pitoiset changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEEDINFO
We need to know the number of rectangles.
This fixes new CTS dEQP-VK.draw.discard_rectangles.dynamic_*.
Fixes: 5db0bf99944 ("radv: Implement VK_EXT_discard_rectangles.")
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pipeline.c | 10 ++
1 file changed, 6 insertions(+), 4
This MR adds a low level ISA library containing APIs for asm, diasm
and meta information. One benefit of moving all this stuff out of the
gallium driver is that it opens the door for vulkan. Unit tests are
included and the current etnaviv disasm gets replaced with the new
one.
https://bugs.freedesktop.org/show_bug.cgi?id=108900
Samuel Pitoiset changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
As the functions operate on 16-byte blocks.
Fixes this Valgrind error:
Invalid read of size 4
at 0x5857568: swizzle_bpp1_align16 (pan_swizzle.c:85)
by 0x585780F: panfrost_texture_swizzle (pan_swizzle.c:171)
by 0x584F587: panfrost_tile_texture (pan_resource.c:489)
by 0x584F641:
This matches the current state of things on both RK3288 and RK3399.
Hopefully, from now on we'll only remove stuff from this list.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 86 ++-
1 file changed, 7 insertions(+), 79 deletions(-)
diff --git
There doesn't seem to actually be any noticeably memory leaks on Weston
when running dEQP. We do seem to leak quiet a bit in the client, so we
still have to run the dEQP runner in batches.
This removes the risk of Weston not restarting properly and introducing
spurious failures.
Signed-off-by:
These tests aren't giving reliable results. Mask them for now.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53 +--
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
Valgrind was complaining of those.
NIR_PASS only sets progress to TRUE if there was progress.
nir_const_load_to_arr() only sets as many constants as components has
the instruction.
This was causing some dEQP tests to flip-flop, such as:
NIR_PASS will only set lower_flrp_progress if there's progress, and if
there isn't its value will be undefined.
Fixes this Valgrind error:
==6589== Conditional jump or move depends on uninitialised value(s)
==6589==at 0x55CA7E6: st_nir_opts (st_glsl_to_nir.cpp:347)
==6589==by 0x55CC1DD:
Build artifacts for armhf and schedule them on a Veyron Chromebook with
RK3288.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/Dockerfile| 97 +---
src/gallium/drivers/panfrost/ci/arm.config| 45
.../drivers/panfrost/ci/deqp-runner.sh| 4
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
index a2133b489d6a..992560f8cd40 100644
To improve robustness, check that we got the expected number of results.
Right now we hard-code the expected number of tests run, but with some
effort we may be able to infer it.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 1 +
1 file changed, 1 insertion(+)
Hi,
these patches take the current CI for Panfrost to a more useful
stage.
Results should be much more stable now and we also run the tests on a
machine with a different SoC and a different Midgard IP (RK3288 with
T760).
Some tests that are unstable have been added to a list of flip-flops to
be
These tests add too much time to the total run time, and some of them
even hang the DUTs, even if I haven't been able to reproduce it locally.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git
Make sure we have only test case names in the list, excluding names of
test groups.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
66 matches
Mail list logo
