Re: [Mesa-dev] [PATCH 1/4] radv: remove remaining code related to 16 samples

2019-05-20 Thread Bas Nieuwenhuizen
r-b On Thu, May 16, 2019 at 11:50 AM Samuel Pitoiset wrote: > > The driver only supports up to 8 samples. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_private.h | 1 - > src/amd/vulkan/si_cmd_buffer.c | 50 -- > 2 files changed, 51

Re: [Mesa-dev] [PATCH 3/4] radv: emit correct centroid priority based on the number of samples

2019-05-20 Thread Bas Nieuwenhuizen
r-b On Thu, May 16, 2019 at 11:51 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/si_cmd_buffer.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c >

Re: [Mesa-dev] [PATCH 4/4] radv: fix the sample max distance value for 8x

2019-05-20 Thread Bas Nieuwenhuizen
r-b On Thu, May 16, 2019 at 11:51 AM Samuel Pitoiset wrote: > > It should be 7, not 8. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/si_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/si_cmd_buffer.c

Re: [Mesa-dev] [PATCH 6/8] egl/dri: flesh out and use dri2_create_drawable()

2019-05-20 Thread Mathias Fröhlich
Hi, I did not have time to really look into the series, but a quick retest: wflinfo --platform=gbm -a gl still crashes on my site. Can you recheck that? best Mathias On Thursday, 16 May 2019 19:01:38 CEST Emil Velikov wrote: > From: Emil Velikov > > Wrap the loader->createNewDrawable()

Re: [Mesa-dev] [PATCH] radeonsi: allow query functions for compute-only contexts

2019-05-20 Thread Jan Vesely
On Mon, May 13, 2019 at 6:40 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > src/gallium/drivers/radeonsi/si_query.c | 7 --- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c >

Re: [Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers

2019-05-20 Thread Charmaine Lee
>From: Brian Paul >Sent: Monday, May 20, 2019 6:39 AM >To: Charmaine Lee; mesa-dev@lists.freedesktop.org; Neha Bhende; >marek.ol...@amd.com >Subject: Re: [PATCH 2/2] mesa: unreference current winsys buffers when >unbinding winsys buffers >Both look OK to me. Do they need to be tagged with

[Mesa-dev] [Bug 110716] SWR doesn't work with OSMesa

2019-05-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110716 Bug ID: 110716 Summary: SWR doesn't work with OSMesa Product: Mesa Version: unspecified Hardware: Other OS: Linux (All) Status: NEW Severity: blocker

Re: [Mesa-dev] [PATCH 1/2] panfrost: ci: Switch to kernel 5.2-rc1

2019-05-20 Thread Alyssa Rosenzweig
Both patches are A-b, thank you! :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers

2019-05-20 Thread Brian Paul
Both look OK to me. Do they need to be tagged with "Cc: mesa-sta...@lists.freedesktop.org" for the stable branches? Reviewed-by: Brian Paul On 05/18/2019 07:46 PM, Charmaine Lee wrote: This fixes surface leak when no winsys buffers are bound. --- src/mesa/main/context.c | 4 1 file

[Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

2019-05-20 Thread Brian Paul
Silence two unused var warnings. And init elem_size, elem_align to zero to silence "maybe uninitialized" warnings. --- src/compiler/nir/nir_lower_int_to_float.c | 2 +- src/compiler/nir/nir_opt_copy_prop_vars.c | 4 +--- src/compiler/nir_types.cpp| 2 +- 3 files changed, 3

[Mesa-dev] [PATCH] svga: clamp max_const_buffers to SVGA_MAX_CONST_BUFS

2019-05-20 Thread Brian Paul
In case the device reports 15 (or more) buffers. --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 02c1a99..b70fd85 100644 ---

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-20 Thread Mike Lothian
I managed to trigger the bug remotely using that branch :( On Mon, 20 May 2019 at 09:03, Juan A. Suarez Romero wrote: > > On Sat, 2019-05-18 at 15:52 +0100, Mike Lothian wrote: > > This patch is causing strange behaviour for me (and someone else on > > IRC) on my Raven system > > > > Are you

Re: [Mesa-dev] [PATCH] radv: decompress FMASK before performing a MSAA decompress using FMASK

2019-05-20 Thread Bas Nieuwenhuizen
r-b On Thu, May 16, 2019 at 9:21 AM Samuel Pitoiset wrote: > > This fixes some CTS failures related to VK_EXT_sample_locations. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH 2/2] panfrost: ci: Avoid pulling Docker image on every run

2019-05-20 Thread Tomeu Vizoso
Jump over the container stage if we haven't changed any of the files that involved in building the container images. This saves 1-2 minutes in each run and helps conserve resources. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 52 +++ 1 file

[Mesa-dev] [PATCH 1/2] panfrost: ci: Switch to kernel 5.2-rc1

2019-05-20 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/ci/Dockerfile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/Dockerfile b/src/gallium/drivers/panfrost/ci/Dockerfile index 268edf224a20..8c4a4e0444ec 100644 ---

[Mesa-dev] [PATCH 3/3] radv: use only one descriptor in the fmask expand pass

2019-05-20 Thread Samuel Pitoiset
This removes one useless SMEM load operations which pointed to the same descriptor anyway. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fmask_expand.c | 27 +++-- 1 file changed, 3 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] radv: set ACCESS_NON_READABLE on the fmask expand pass output image

2019-05-20 Thread Samuel Pitoiset
The driver will emit GLC=1. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fmask_expand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_meta_fmask_expand.c b/src/amd/vulkan/radv_meta_fmask_expand.c index 12533935348..44068edc89e 100644 ---

[Mesa-dev] [PATCH 1/3] radv: remove one useless image type in the fmask expand shader

2019-05-20 Thread Samuel Pitoiset
Both input and output images use the same type. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fmask_expand.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fmask_expand.c b/src/amd/vulkan/radv_meta_fmask_expand.c index

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-20 Thread Juan A. Suarez Romero
On Sat, 2019-05-18 at 15:52 +0100, Mike Lothian wrote: > This patch is causing strange behaviour for me (and someone else on > IRC) on my Raven system > Are you testing with master branch? Could you try with the staging/19.1 branch (current HEAD is fb6cce5817d)? If the problem persists, I can