Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

2019-05-21 Thread Tapani Pälli
On 5/21/19 4:53 PM, Sumit Semwal wrote: Hello everyone, First up, my apologies on not being able to respond earlier; secondly, thanks very much for your review. On Wed, 15 May 2019 at 19:27, Emil Velikov wrote: Hi all, On Tue, 14 May 2019 at 08:18, Tapani Pälli wrote: On 5/13/19 6:52

Re: [Mesa-dev] nir_opt_copy_prop_vars doing the wrong thing

2019-05-21 Thread Dave Airlie
https://gitlab.freedesktop.org/airlied/mesa/tree/nir-copy-props-cast-test Contains a unit test that triggers it for me. Dave. On Sat, 11 May 2019 at 09:54, Jason Ekstrand wrote: > > We have unit tests for that pass. Maybe you could write one which exercises > the issue? It'd help in

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2019-05-21 Thread Ian Romanick
On 5/21/19 4:36 AM, Olivier Fourdan wrote: > Hi all, > > On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit > wrote: >>> Ugh... not so good. According to Oliver on the bug, this just make the >>> assert go away and doesn't actually fix anything. Likely this is needed >>> but not sufficient. >>

Re: [Mesa-dev] [PATCH v2] radv: implement VK_EXT_sample_locations

2019-05-21 Thread Bas Nieuwenhuizen
So this does not seem to use the sample locations during layout transitions? AFAIK those are needed for e.g. HTILE decompression as it is based on equations somehow. On Thu, May 16, 2019 at 11:51 AM Samuel Pitoiset wrote: > > Basically, this extension allows applications to use custom > sample

Re: [Mesa-dev] [PATCH 2/4] radv: clean up the sample locations codebase

2019-05-21 Thread Bas Nieuwenhuizen
r-b On Thu, May 16, 2019 at 11:50 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > src/amd/vulkan/radv_pipeline.c | 2 +- > src/amd/vulkan/radv_private.h| 4 +- > src/amd/vulkan/si_cmd_buffer.c | 166

Re: [Mesa-dev] [PATCH] radv: do not reset query pool during creation

2019-05-21 Thread Bas Nieuwenhuizen
r-b On Tue, May 21, 2019 at 1:36 PM Samuel Pitoiset wrote: > > From the Vulkan spec 1.1.108: >"After query pool creation, each query must be reset before > it is used." > > So, the driver doesn't need to do this at creation time. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [ANNOUNCE] mesa 19.0.5

2019-05-21 Thread Dylan Baker
Hi List, I'd like to announce the availability of mesa 19.0.5. Just as a reminder the plan is to have one more release of the 19.0 series in two weeks, but that is subject to change base on the 19.1 release progress. Things have slowed back down from the last release, which is good for this late

Re: [Mesa-dev] [PATCH] radeonsi: fix a regression in si_rebind_buffer

2019-05-21 Thread Gert Wollny
This fixes the issues I had when running Outast via vigl, thanks Tested-By: Gert Wollny On Di, 2019-05-21 at 14:34 -0400, Marek Olšák wrote: > From: Marek Olšák > > Don't update non-buffer images. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110701 > Fixes:

[Mesa-dev] [Bug 110707] llvm-config: unknown component name: x86asmprinter

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110707 --- Comment #1 from Roland Scheidegger --- Yes this component apparently disappeared. By the looks of it a lot of the code got moved into MCTargetDesc, but I'm not sure yet if it actually needs another lib added instead or if it can just be

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Marek Olšák
It should be fixed with: "[PATCH] radeonsi: fix a regression in si_rebind_buffer" Marek On Tue, May 21, 2019, 6:24 AM Mike Lothian wrote: > Can someone with access revert from master until this is fixed? It's > been broken for 3 days now > > On Tue, 21 May 2019 at 09:01, Juan A. Suarez Romero

[Mesa-dev] [PATCH] radeonsi: fix a regression in si_rebind_buffer

2019-05-21 Thread Marek Olšák
From: Marek Olšák Don't update non-buffer images. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110701 Fixes: 78e35df52aa2f7d770f929a0866a0faa89c261a9 "radeonsi: update buffer descriptors in all contexts after buffer invalidation" Cc: 19.1 ---

[Mesa-dev] [Bug 110716] SWR doesn't work with OSMesa

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110716 --- Comment #4 from Chuck Atkins --- > Comment # 1 on bug 110716 from Krzysztof Raszkowski > I've tried to reproduce it with master top mesa but without success (works > fine). What is exact version of mesa you've build? master as of this

[Mesa-dev] [Bug 110697] glXWaitForMscOML and glXWaitVideoSyncSGI may block indefinitely

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110697 QwertyChouskie changed: What|Removed |Added CC||asdfghrbljz...@outlook.com ---

[Mesa-dev] [Bug 110716] SWR doesn't work with OSMesa

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110716 --- Comment #3 from Krzysztof Raszkowski --- (In reply to Eric Engestrom from comment #2) > (In reply to Krzysztof Raszkowski from comment #1) > > And one comment to autotools->meson change. With autotools default build > > mode was without

[Mesa-dev] [Bug 110716] SWR doesn't work with OSMesa

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110716 --- Comment #2 from Eric Engestrom --- (In reply to Krzysztof Raszkowski from comment #1) > And one comment to autotools->meson change. With autotools default build > mode was without asserts. With meson default buildtype is debugoptimized. >

[Mesa-dev] [Bug 110716] SWR doesn't work with OSMesa

2019-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110716 --- Comment #1 from Krzysztof Raszkowski --- Hi Chuck, thanks for reporting this bug. I've tried to reproduce it with master top mesa but without success (works fine). What is exact version of mesa you've build? And one comment to

[Mesa-dev] [ANNOUNCE] mesa 19.1.0-rc3

2019-05-21 Thread Juan A. Suarez Romero
Hello, list. The third release candidate for Mesa 19.1.0 is now available. Remind that right now there are two bugs blocking the final release: #110302 - [bisected][regression] piglit egl-create-pbuffer-surface and egl-gl-colorspace regressions #110357 - [REGRESSION] [BISECTED] [OpenGL CTS]

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2019-05-21 Thread andrey simiklit
> > Hi all, > > On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit > wrote: > > > Ugh... not so good. According to Oliver on the bug, this just make > the assert go away and doesn't actually fix anything. Likely this is > needed but not sufficient. > > > > So as far as I understand Oliver found

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

2019-05-21 Thread Sumit Semwal
Hello everyone, First up, my apologies on not being able to respond earlier; secondly, thanks very much for your review. On Wed, 15 May 2019 at 19:27, Emil Velikov wrote: > > Hi all, > > On Tue, 14 May 2019 at 08:18, Tapani Pälli wrote: > > > > > > On 5/13/19 6:52 PM, Haehnle, Nicolai wrote: >

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Erik Faye-Lund
Right. I guess with an old enough bison version, this can happen. I'll see if I can come up with something better.On May 21, 2019 15:47, Brian Paul wrote:I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41

Re: [Mesa-dev] Mesa (master): glsl: do not use deprecated bison-keyword

2019-05-21 Thread Brian Paul
I think this change broke the MSVC build for us. I may not have time to investigate until later today. -Brian On 05/21/2019 05:41 AM, GitLab Mirror wrote: Module: Mesa Branch: master Commit: eb85124a9f6e9cb94d0d4a99f91bbae374777e3a URL:

[Mesa-dev] [PATCH] radv: fix the availability bit for timestamp queries

2019-05-21 Thread Samuel Pitoiset
The previous code was just wrong because it copied the timestamp value directly to the destination buffer. If the query pool was resetted just before, the value was 0x which is considered as available. The new logic uses a WRITE_DATA packet to always initialize the availability bit to

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2019-05-21 Thread Olivier Fourdan
Hi all, On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit wrote: > > Ugh... not so good. According to Oliver on the bug, this just make the > > assert go away and doesn't actually fix anything. Likely this is needed > > but not sufficient. > > So as far as I understand Oliver found the bad

[Mesa-dev] [PATCH] radv: do not reset query pool during creation

2019-05-21 Thread Samuel Pitoiset
From the Vulkan spec 1.1.108: "After query pool creation, each query must be reset before it is used." So, the driver doesn't need to do this at creation time. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Mike Lothian
Can someone with access revert from master until this is fixed? It's been broken for 3 days now On Tue, 21 May 2019 at 09:01, Juan A. Suarez Romero wrote: > > On Tue, 2019-05-21 at 09:36 +0200, Gert Wollny wrote: > > Hi Marek, > > > > it seems that this patch is causing a few issues [1], any

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Juan A. Suarez Romero
On Tue, 2019-05-21 at 09:36 +0200, Gert Wollny wrote: > Hi Marek, > > it seems that this patch is causing a few issues [1], any idea what is > going on? Maybe it is best to revert the patch for now? > > Best, > Gert > As this is commit is causing issues, I'm withdrawing it out of 19.1

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Gert Wollny
Hi Marek, it seems that this patch is causing a few issues [1], any idea what is going on? Maybe it is best to revert the patch for now? Best, Gert [1] https://bugzilla.freedesktop.org/show_bug.cgi?id=110701 On Fr, 2019-05-10 at 01:19 -0400, Marek Olšák wrote: > From: Marek Olšák > >