Re: [Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers

2019-05-24 Thread Dave Airlie
https://bugs.freedesktop.org/show_bug.cgi?id=110721 Maybe be a little less trigger happy with the tags, can we get these reverted in stable :-) and master as well maybe. Dave. On Tue, 21 May 2019 at 02:32, Charmaine Lee wrote: > > > >From: Brian Paul > >Sent: Monday, May 20, 2019 6:39 AM >

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

2019-05-24 Thread Eric Engestrom
On Friday, 2019-05-24 07:49:37 +0300, Tapani Pälli wrote: > > > On 5/23/19 8:22 PM, Sumit Semwal wrote: > > Hi Eric, > > > > On Thu, 23 May 2019 at 20:25, Eric Engestrom > > wrote: > > > > > > On Thursday, 2019-05-23 08:34:40 +0300, Tapani Pälli wrote: > > > > Hi; > > > > > > > > On 5/22/19

Re: [Mesa-dev] [RFC PATCH] nir/algebraic: Simplify max(abs(a), 0.0) -> abs(a)

2019-05-24 Thread Ilia Mirkin
On Fri, May 24, 2019 at 2:46 PM Alyssa Rosenzweig wrote: > > > I /think/ that should be adequate here too. > > Do inexact values not need to handle NaNs strictly, then? I'm not sure > what this corresponds to in the various GLs/CLs/Vulkan specs, hence > labeling this RFC. I don't know about

Re: [Mesa-dev] [RFC PATCH] nir/algebraic: Simplify max(abs(a), 0.0) -> abs(a)

2019-05-24 Thread Alyssa Rosenzweig
> I /think/ that should be adequate here too. Do inexact values not need to handle NaNs strictly, then? I'm not sure what this corresponds to in the various GLs/CLs/Vulkan specs, hence labeling this RFC. ___ mesa-dev mailing list

Re: [Mesa-dev] [RFC PATCH] nir/algebraic: Simplify max(abs(a), 0.0) -> abs(a)

2019-05-24 Thread Ian Romanick
On 5/23/19 7:54 PM, Ilia Mirkin wrote: > How does max(NaN, 0) work? IIRC there's some provision that this > becomes 0, while abs(NaN) = NaN. That is correct. There are a couple other algebraic patterns that have the same potential problem (e.g., the min(max()) -> sat() patterns), and we just

[Mesa-dev] [Bug 110707] llvm-config: unknown component name: x86asmprinter

2019-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110707 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] panfrost: Dereference sampled texture

2019-05-24 Thread Alyssa Rosenzweig
R-b, thank you! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] panfrost: Dereference sampled texture

2019-05-24 Thread Tomeu Vizoso
We are currently leaking resources if they were sampled from. Once we are done with a sampler, we should dereference that resource. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

2019-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110345 --- Comment #37 from Thomas Rohloff --- (In reply to antonh from comment #36) > Just as an update the issue in Far Cry New Dawn doesn't seem to occur when > using mesa 19.0.4 and llvm8 from the official arch repo. I'm not using Arch but will

Re: [Mesa-dev] [RFC PATCH] nir/algebraic: Simplify max(abs(a), 0.0) -> abs(a)

2019-05-24 Thread Elie Tournier
On Thu, May 23, 2019 at 10:54:38PM -0400, Ilia Mirkin wrote: > How does max(NaN, 0) work? IIRC there's some provision that this > becomes 0, while abs(NaN) = NaN. Yes max(NaN, 0) should return 0. At least it's what we do with i965. See

Re: [Mesa-dev] [PATCH 2/2] etnaviv: blt: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Hi Fabio, Am Fr., 24. Mai 2019 um 13:10 Uhr schrieb Fabio Estevam : > > Hi Christian, > > On Fri, May 24, 2019 at 7:52 AM Christian Gmeiner > wrote: > > > > Signed-off-by: Christian Gmeiner > > Maybe you could remove the '&& s/FALSE/false' from the Subject since > you are only replacing the

Re: [Mesa-dev] [PATCH 2/2] etnaviv: blt: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Fabio Estevam
Hi Christian, On Fri, May 24, 2019 at 7:52 AM Christian Gmeiner wrote: > > Signed-off-by: Christian Gmeiner Maybe you could remove the '&& s/FALSE/false' from the Subject since you are only replacing the TRUE occurrences in this patch. ___ mesa-dev

[Mesa-dev] [PATCH 1/2] etnaviv: rs: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c index a9d3872ad41..e64babfdd0a 100644 ---

[Mesa-dev] [PATCH 2/2] etnaviv: blt: s/TRUE/true && s/FALSE/false

2019-05-24 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c b/src/gallium/drivers/etnaviv/etnaviv_blt.c index 42190d75d4e..cb6e81999fc 100644 ---

Re: [Mesa-dev] [PATCH] scons: fix build with llvm 9.

2019-05-24 Thread Jose Fonseca
Reviewed-by: Jose Fonseca From: srol...@vmware.com Sent: Friday, May 24, 2019 02:47 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH] scons: fix build with llvm 9. From: Roland Scheidegger The x86asmprinter component is

Re: [Mesa-dev] [PATCH] gallivm: fix default cbuf info.

2019-05-24 Thread Jose Fonseca
Reviewed-by: Jose Fonseca Thanks. Jose From: srol...@vmware.com Sent: Friday, May 24, 2019 02:08 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH] gallivm: fix default cbuf info. From: Roland Scheidegger The default

[Mesa-dev] [PATCH] radv: flush pending query reset caches before copying results

2019-05-24 Thread Samuel Pitoiset
From the Vulkan spec 1.1.108: "vkCmdCopyQueryPoolResults is guaranteed to see the effect of previous uses of vkCmdResetQueryPool in the same queue, without any additional synchronization." Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 40

Re: [Mesa-dev] [PATCH v2] radv: implement VK_EXT_sample_locations

2019-05-24 Thread Samuel Pitoiset
It's a bit difficult and invasive to support variable sample locations during layout transitions actually. So for now, I disabled HTILE for depth/stencil images that might require sample locations. On 5/22/19 10:20 PM, Marek Olšák wrote: The depth decompress pass needs to know the sample

[Mesa-dev] [PATCH v3] radv: implement VK_EXT_sample_locations

2019-05-24 Thread Samuel Pitoiset
Basically, this extension allows applications to use custom sample locations. It doesn't support variable sample locations during subpass. Note that we don't have to upload the user sample locations because the spec doesn't allow this. HTILE is currently disabled for depth/stencil images that