[Mesa-dev] [Bug 111248] Navi10 Font rendering issue in Overwatch

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111248 --- Comment #5 from Matt --- Main menu frame https://send.firefox.com/download/73198043a0f77669/#J_dNWZXjNm3LXJaErpD7zA -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 3/4] iris/gen9: Optimize slice and subslice load balancing behavior.

2019-08-09 Thread Francisco Jerez
See "i965/gen9: Optimize slice and subslice load balancing behavior." for the rationale. Reviewed-by: Kenneth Graunke --- src/gallium/drivers/iris/iris_blorp.c | 6 ++ src/gallium/drivers/iris/iris_context.c | 1 + src/gallium/drivers/iris/iris_context.h | 3 +

[Mesa-dev] [PATCH 4/4] OPTIONAL: anv/gen9: Optimize slice and subslice load balancing behavior.

2019-08-09 Thread Francisco Jerez
See "i965/gen9: Optimize slice and subslice load balancing behavior." for the rationale. Marked optional because no performance evaluation has been done on this commit, it is provided to match the hashing settings of the Iris driver. Test reports welcome. --- src/intel/vulkan/anv_genX.h

[Mesa-dev] [PATCH 1/4] i965/gen9: Optimize slice and subslice load balancing behavior.

2019-08-09 Thread Francisco Jerez
The default pixel hashing mode settings used for slice and subslice load balancing are far from optimal under certain conditions (see the comments below for the gory details). The top-of-the-line GT4 parts suffer from a particularly severe performance problem currently due to a subslice load

[Mesa-dev] [PATCH 2/4] intel/genxml: Add GT_MODE hashing defs for Gen9.

2019-08-09 Thread Francisco Jerez
Reviewed-by: Kenneth Graunke --- src/intel/genxml/gen9.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 9df7cd82738..0d037489df9 100644 --- a/src/intel/genxml/gen9.xml +++ b/src/intel/genxml/gen9.xml @@ -6477,6

[Mesa-dev] [Patch] glx: Fix SEGV due to dereferencing a NULL ptr from XCB-GLX.

2019-08-09 Thread zegentzy
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1631/diffs?commit_id=a615f57eedad8e9c459784701a91cf0fc68a4f6d ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] panfrost: Add madvise support to BO cache

2019-08-09 Thread Alyssa Rosenzweig
Alright. Let's wait for Tomeu's ack, but R-b :) On Fri, Aug 09, 2019 at 01:53:13PM -0600, Rob Herring wrote: > The kernel now supports madvise ioctl to indicate which BOs can be freed > when there is memory pressure. Mark BOs purgeable when they are in the > BO cache. The BOs must also be

Re: [Mesa-dev] [PATCH 2/2] panfrost: Add madvise support to BO cache

2019-08-09 Thread Rob Herring
On Fri, Aug 9, 2019 at 2:49 PM Alyssa Rosenzweig wrote: > > I'm not one to care, but fwiw, spacing is inconsistent..? Context? I guess you mean the 'madv.retained = 0;' line. > > > + if (!ret && !madv.retained) { > > What's the logic here? (What does a 0/!0 return code mean

Re: [Mesa-dev] [PATCH 2/2] panfrost: Add madvise support to BO cache

2019-08-09 Thread Alyssa Rosenzweig
I'm not one to care, but fwiw, spacing is inconsistent..? > + if (!ret && !madv.retained) { What's the logic here? (What does a 0/!0 return code mean here?) I'm wondering if this meant to be ||? Or is the idea that an older kernel will have ret!=0 (since it doesn't recognize

Re: [Mesa-dev] [PATCH 1/2] panfrost: Sync UAPI header from kernel

2019-08-09 Thread Alyssa Rosenzweig
Patch #1 is R-b On Fri, Aug 09, 2019 at 01:53:12PM -0600, Rob Herring wrote: > Sync the panfrost_drm.h UAPI header with the latest from the kernel. > This adds madvise ioctl and GPU feature params. > > Signed-off-by: Rob Herring > --- > include/drm-uapi/panfrost_drm.h | 61

[Mesa-dev] [PATCH 9/9] panfrost: Implement transform feedback

2019-08-09 Thread Alyssa Rosenzweig
Midgard has no hardware support for transform feedback, so we simulate it in software. Lucky us. What Midgard does do is write out vertex shader outputs to main memory unconditonally. Fragment shaders read varyings back from main memory; there's no on-chip storage for varyings. Whether this was a

[Mesa-dev] [PATCH 3/9] panfrost: Set PIPE_CAP_TGSI_TEXCOORD

2019-08-09 Thread Alyssa Rosenzweig
It doesn't really make sense, since we don't have special texture coordinate varyings, but it'll make some code simpler for XFB and it doesn't hurt us, even if I lose a bit of my soul setting it. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_screen.c | 5 +

[Mesa-dev] [PATCH 5/9] panfrost: Import stream out utility from iris

2019-08-09 Thread Alyssa Rosenzweig
We'll need this in a moment. Ken's implementation, lightly edited for Panfrost. Signed-off-by: Alyssa Rosenzweig Suggested-by: Kenneth Graunke --- src/gallium/drivers/panfrost/pan_context.c | 40 ++ 1 file changed, 40 insertions(+) diff --git

[Mesa-dev] [PATCH 8/9] panfrost: Increment offsets[] per draw

2019-08-09 Thread Alyssa Rosenzweig
We have to maintain the internal offset ourselves. Per v3d. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 10 ++ src/gallium/drivers/panfrost/pan_context.h | 1 + 2 files changed, 11 insertions(+) diff --git

[Mesa-dev] [PATCH 6/9] panfrost: Route outputs_written through the compiler

2019-08-09 Thread Alyssa Rosenzweig
It's there in shader_info, but we need to access it from pan_context.c Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_assemble.c | 6 +- src/gallium/drivers/panfrost/pan_compute.c | 2 +- src/gallium/drivers/panfrost/pan_context.c | 5 -

[Mesa-dev] [PATCH 7/9] panfrost: Fixup stream out information per variant

2019-08-09 Thread Alyssa Rosenzweig
We could probably get away with doing this once per pipe_shader_state but let's not jump down that rabbit hole quite yet. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 7 +++ src/gallium/drivers/panfrost/pan_context.h | 2 ++ 2 files changed, 9

[Mesa-dev] [PATCH 4/9] panfrost: Flush when using transform feedback

2019-08-09 Thread Alyssa Rosenzweig
This is a huge hack to workaround incomplete BO flushing logic, but it's enough for the dEQP transform feedback tests, and doing the resource management to get this right is out-of-scope for this patch series. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 1 +

[Mesa-dev] [PATCH 2/9] panfrost: Wire up statistics for primitives

2019-08-09 Thread Alyssa Rosenzweig
GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN should now be handled. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_context.c

[Mesa-dev] [PATCH 1/9] panfrost: Implement callbacks for PRIMITIVES queries

2019-08-09 Thread Alyssa Rosenzweig
We're just going to compute them in the driver but let's get the structures setup to handle them. Implementation from v3d. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 52 -- src/gallium/drivers/panfrost/pan_context.h | 15 ++- 2

[Mesa-dev] [PATCH 2/2] panfrost: Add madvise support to BO cache

2019-08-09 Thread Rob Herring
The kernel now supports madvise ioctl to indicate which BOs can be freed when there is memory pressure. Mark BOs purgeable when they are in the BO cache. The BOs must also be munmapped when they are in the cache or they cannot be purged. We could optimize avoiding the madvise ioctl on older

[Mesa-dev] [PATCH 1/2] panfrost: Sync UAPI header from kernel

2019-08-09 Thread Rob Herring
Sync the panfrost_drm.h UAPI header with the latest from the kernel. This adds madvise ioctl and GPU feature params. Signed-off-by: Rob Herring --- include/drm-uapi/panfrost_drm.h | 61 + 1 file changed, 61 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 3/5] panfrost: Mark BOs as NOEXEC

2019-08-09 Thread Rob Herring
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote: > > Unless a BO has the EXECUTABLE flag, mark it as NOEXEC. > > v2: - Rework version detection (Alyssa). > > Signed-off-by: Tomeu Vizoso > --- > include/drm-uapi/panfrost_drm.h | 27 +++ Next time, I think this

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-09 Thread Rob Herring
On Fri, Aug 9, 2019 at 3:31 AM Tomeu Vizoso wrote: > > On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote: > > > > On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso > > wrote: > > > > > > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote: > > > > > > > > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso > > >

[Mesa-dev] [Bug 111308] [Regression, NIR, bisected] Black squares in Unigine Heaven via DXVK

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111308 Ian Romanick changed: What|Removed |Added Status|NEEDINFO|ASSIGNED --- Comment #7 from Ian

[Mesa-dev] [Bug 111340] [LLVM] DIRT 3 horrible performance when Shadows set to very high

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111340 Bug ID: 111340 Summary: [LLVM] DIRT 3 horrible performance when Shadows set to very high Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] android: intel/perf: fix missing include path in makefile

2019-08-09 Thread Lionel Landwerlin
Hey Mauro, I was kind of surprised that u_math.h would pull a gallium header file. So I pulled the thread a bit and came up with this MR : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1625 Sorry it's all over the place :( -Lionel On 09/08/2019 15:06, Mauro Rossi wrote: Fixes the

[Mesa-dev] [Bug 111248] Navi10 Font rendering issue in Overwatch

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111248 --- Comment #4 from Bas Nieuwenhuizen --- Anyone able to get a renderdoc capture for this? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] android: intel/perf: fix missing include path in makefile

2019-08-09 Thread Mauro Rossi
Fixes the following building error: In file included from external/mesa/src/intel/perf/gen_perf.c:42: external/mesa/src/util/u_math.h:42:10: fatal error: 'pipe/p_compiler.h' file not found ^~~ 1 error generated. Fixes: 018f9b8 ("intel/perf: refactor gen_perf_begin_query

Re: [Mesa-dev] [PATCH] util/anon_file: Fix build errors due to missing includes

2019-08-09 Thread Eduardo Lima Mitev
It was fixed already with c73988300f943e185a50aaba015f2f114ffcb262. Eduardo On 8/8/19 9:31 AM, Eduardo Lima Mitev wrote: > Including stdlib.h and stdio.h is required in some configurations: > > ../src/util/anon_file.c: In function ‘create_tmpfile_cloexec’: > ../src/util/anon_file.c:75:9: error:

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-09 Thread Tomeu Vizoso
On Thu, 8 Aug 2019 at 16:50, Rob Herring wrote: > > On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig > wrote: > > > > > This is using the > > > untranslated flags, but I think it should be the 'translated_flags' as > > > those are the ones changing the allocation. > > > > It's a little more

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-09 Thread Tomeu Vizoso
On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote: > > On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso > wrote: > > > > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote: > > > > > > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso > > > wrote: > > > > > > > > Instead of all shaders being stored in a

[Mesa-dev] [Bug 111248] Navi10 Font rendering issue in Overwatch

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111248 --- Comment #3 from Matt --- Created attachment 144991 --> https://bugs.freedesktop.org/attachment.cgi?id=144991=edit fonts correct on amdvlk (ignore snowy artefacts) -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 111248] Navi10 Font rendering issue in Overwatch

2019-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111248 Matt changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.