[Mesa-dev] [ANNOUNCE] mesa 19.2.0-rc3
Hi list, Mesa 19.2.0-rc3 is now available. There's a bit of everything here, but the majority of it is nir related changes. It's a nice size for an rc3, and I'm happy to report that we've closed about half the blocking bugs since rc2. I'm currently thinking that rc4 will be the last rc and we'll see 19.0.0 in two weeks. Dylan Shortlog Bas Nieuwenhuizen (1): Revert "ac/nir: Lower large indirect variables to scratch" Caio Marcelo de Oliveira Filho (1): nir/lower_explicit_io: Handle 1 bit loads and stores Connor Abbott (1): radv: Call nir_propagate_invariant() Dave Stevenson (1): broadcom/v3d: Allow importing linear BOs with arbitrary offset/stride. Dylan Baker (2): nir: Add is_not_negative helper function Bump version for rc3 Eric Engestrom (12): ttn: fix 64-bit shift on 32-bit `1` egl: fix deadlock in malloc error path util/os_file: fix double-close() anv: fix format string in error message freedreno/drm-shim: fix mem leak nir: fix memleak in error path anv: add support for driconf wsi: add minImageCount override anv: add support for vk_x11_override_min_image_count amd: move adaptive sync to performance section, as it is defined in xmlpool radv: add support for vk_x11_override_min_image_count drirc: override minImageCount=2 for gfxbench Erik Faye-Lund (1): gallium/auxiliary/indices: consistently apply start only to input Hal Gentz (1): glx: Fix SEGV due to dereferencing a NULL ptr from XCB-GLX. Jason Ekstrand (7): anv: Bump maxComputeWorkgroupSize nir: Handle complex derefs in nir_split_array_vars nir: Don't infinitely recurse in lower_ssa_defs_to_regs_block nir: Add a block_is_unreachable helper nir/repair_ssa: Repair dominance for unreachable blocks nir/repair_ssa: Insert deref casts when needed nir/dead_cf: Repair SSA if the pass makes progress Jonathan Marek (1): freedreno/a2xx: ir2: fix lowering of instructions after float lowering Kenneth Graunke (1): iris: Report correct number of planes for planar images Lepton Wu (1): virgl: Fix pipe_resource leaks under multi-sample. Lionel Landwerlin (2): egl: fix platform selection vulkan/overlay: bounce image back to present layout Marek Olšák (2): radeonsi/gfx10: don't call gfx10_destroy_query with compute-only contexts radeonsi/gfx10: fix wave occupancy computations Samuel Pitoiset (1): nir: do not assume that the result of fexp2(a) is always an integral Sergii Romantsov (1): intel/dri: finish proper glthread Timur Kristóf (1): st/nine: Properly initialize GLSL types for NIR shaders. Vinson Lee (2): swr: Fix build with llvm-9.0 again. travis: Fail build if any command in if statement fails. git tag: mesa-19.2.0-rc3 https://mesa.freedesktop.org/archive/release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz SHA256: 3679868b6dd446a38bd5125e84e20fd73dc9dc5a3475845363488167998821a0 release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz SHA512: 378bb27073d99032c489a0fcc44157017d27d01c24c3bb7e3e32f59b298cf0c7409351d18fbbfb1ccfb799e02f9166450dc73390e98a026f60a4ab0583944d68 release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz PGP: https://mesa.freedesktop.org/archive/release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz.sig signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111478] Add OpenGL ES (GLES) 1.0, 1.1 and 2.0 to docs/features.txt
https://bugs.freedesktop.org/show_bug.cgi?id=111478 --- Comment #8 from Creak --- (In reply to Rob Clark from comment #7) > hmm, [1] looks like an older iteration of drm-shim.. have a look at: > > ./src/freedreno/drm-shim > ./src/broadcom/drm-shim > > in the mesa src tree. They are an $LD_PRELOAD'd thing to spoof enough of > the kernel uabi to "run" the driver. Ie. you can't actually do drawing, but > it is enough to run shader-db. And so I think it should be pretty much > enough to run glxinfo. Thanks! Are broadcom and freedreno the only two drivers having drm-shim? Because in order to generate entirely features.txt, I guess all the drivers should have it, right? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp
On 9/10/19 10:53 PM, Brian Paul wrote:
> IIRC, designated initializers are not legal C++.
> Fixes the MSVC build.
>
> Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function")
> ---
> src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index 280a778..d6a0264 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -688,7 +688,7 @@ st_link_nir(struct gl_context *ctx,
> */
> if (shader_program->data->spirv) {
>static const gl_nir_linker_options opts = {
> - .fill_parameters = true,
> + true /*fill_parameters */
Could we get a comment in the definition of gl_nir_linker_options to
remind people to either add options only to the end or double check all
of the places that initialize the structures? If someone adds 'bool
do_foo_instead_of_bar' option at the beginning of that struct, it will
cause problems.
>};
>if (!gl_nir_link(ctx, shader_program, ))
> return GL_FALSE;
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111666] drm.h:50:9: error: unknown type name 'uint8_t'
https://bugs.freedesktop.org/show_bug.cgi?id=111666 Bug ID: 111666 Summary: drm.h:50:9: error: unknown type name 'uint8_t' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: NEW Keywords: bisected, regression Severity: not set Priority: not set Component: Other Assignee: mesa-dev@lists.freedesktop.org Reporter: v...@freedesktop.org QA Contact: mesa-dev@lists.freedesktop.org In file included from ../src/gallium/state_trackers/dri/dri_helpers.c:24: In file included from ../include/drm-uapi/drm_fourcc.h:27: ../include/drm-uapi/drm.h:50:9: error: unknown type name 'uint8_t' typedef uint8_t __u8; ^ ../include/drm-uapi/drm.h:52:9: error: unknown type name 'uint16_t' typedef uint16_t __u16; ^ ../include/drm-uapi/drm.h:54:9: error: unknown type name 'uint32_t' typedef uint32_t __u32; ^ ../include/drm-uapi/drm.h:56:9: error: unknown type name 'uint64_t' typedef uint64_t __u64; ^ 272f9cfe6a19212354c89dc443959473ac5d398e is the first bad commit commit 272f9cfe6a19212354c89dc443959473ac5d398e Author: Eric Anholt Date: Thu Aug 29 17:00:09 2019 -0700 dri: Use DRM_FORMAT_* instead of defining our own copy. We have only two defines that aren't from DRM_FORMAT_*: SARGB and SABGR. Keep only those as __DRI_IMAGE_FOURCC and garbage collect the rest. While this header is also used from the X server, the X server doesn't use any __DRI_IMAGE enums. Reviewed-by: Eric Engestrom Reviewed-by: Kristian H. Kristensen -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp
On Tue, Sep 10, 2019 at 10:54 PM Brian Paul wrote:
>
> IIRC, designated initializers are not legal C++.
> Fixes the MSVC build.
>
> Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function")
> ---
> src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> index 280a778..d6a0264 100644
> --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
> @@ -688,7 +688,7 @@ st_link_nir(struct gl_context *ctx,
> */
> if (shader_program->data->spirv) {
>static const gl_nir_linker_options opts = {
> - .fill_parameters = true,
> + true /*fill_parameters */
Probably intended to have a space after /*
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Moving libglvnd to FreeDesktop Gitlab
On 9/9/19 12:07 PM, Adam Jackson wrote: On Wed, 2019-09-04 at 14:27 -0600, Kyle Brenneman wrote: On 9/4/19 8:44 AM, Daniel Stone wrote: Hi, On Wed, 4 Sep 2019 at 15:12, Chuck Atkins wrote: Can we use Gitlab's GitHub import feature? https://gitlab.freedesktop.org/help/user/project/import/github.md I haven't used it before but it looks like it will migrate everything, i.e. repo, issues, prs, etc. Yeah, we definitely can. We can create a new namespace for GLVND and import the project into there. Who else should I add to the group? I'm not very familiar with the administrative side of GitLab -- does adding to the group just control who can check in new commits? It's fairly fine-grained, for details see: https://docs.gitlab.com/ee/user/permissions.html - ajax In that case, in addition to myself and the other NVIDIA engineers, Adam Jackson would probably make sense to add for push/merge permission. Not sure who else. Is there anything that's needed from me to get the GitHub repo ready to import? -Kyle ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] Propose: Add transform buffer in egl/drivers/dir2/platform_android.c
Hi Mesa developers, I would like to add a feature in egl/drivers/dir2/platform_android.c to respect he transform hint and rotation in Android buffer and transform buffer to pre-rotated buffer, so display hardware can do a simple linear read from the buffer to scan it out. It's my first time to do something in Mesa repository here. According to the document, I need propose first. If anyone has a different opinion, please let me know. Or I will go ahead to work on it. Best Regards! Cici Ruan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111529] EGL_PLATFORM=drm doesn't expose MESA_query_driver extension
https://bugs.freedesktop.org/show_bug.cgi?id=111529 Adam Jackson changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #19 from Adam Jackson --- commit 2c1983f75767765686e8308a5841c5c26b5a0348 Author: Jean Hertel Date: Tue Sep 10 21:00:07 2019 +0200 Fix missing dri2_load_driver on platform_drm Signed-off-by: Jean Hertel Acked-by: Eric Engestrom Reviewed-by: Adam Jackson -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111478] Add OpenGL ES (GLES) 1.0, 1.1 and 2.0 to docs/features.txt
https://bugs.freedesktop.org/show_bug.cgi?id=111478 --- Comment #7 from Rob Clark --- (In reply to Creak from comment #6) > (In reply to Rob Clark from comment #4) > > And now that we are using drm_shim to run shader-db in CI for a few drivers > > (freedreno and vc4), I'm secretly hoping someone comes up w/ a way to > > generate features.txt (at least for drivers w/ drm_shim support) by running > > glxinfo in CI, since features.txt requires that developers remember to > > actually update it. > > I took a look at drm_shim [1] and it seems that this tool helps faking the > driver at the kernel level, is that it? If it is, what I'm not so sure is > how that tool works. Looking at the readme, I don't understand the backend > options. I was hoping to see the same drivers as the ones listed in > features.txt. So.. apparently I'm missing something.. Could you explain it > to me? (you can PM me if you'd rather not go too off topic on this thread). > > [1] https://gitlab.freedesktop.org/anholt/drm-shim hmm, [1] looks like an older iteration of drm-shim.. have a look at: ./src/freedreno/drm-shim ./src/broadcom/drm-shim in the mesa src tree. They are an $LD_PRELOAD'd thing to spoof enough of the kernel uabi to "run" the driver. Ie. you can't actually do drawing, but it is enough to run shader-db. And so I think it should be pretty much enough to run glxinfo. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [ANNOUNCE] mesa 19.2.0-rc3
Hi List, I'm pleased to announce that mesa 19.2.0-rc3 is now available. This wasn't nearly as busy as the last rc, which is expected as it's only one week of work. There's a little but of everything in this release, but nir dominates the changes. We've seen a fair number of bugs on the release tracker closed between -rc2 and now, but I'm predicting that we'll have an -rc5 at least. Expect -rc4 at it's scheduled time next week. Dylan Shortlog: Bas Nieuwenhuizen (1): Revert "ac/nir: Lower large indirect variables to scratch" Caio Marcelo de Oliveira Filho (1): nir/lower_explicit_io: Handle 1 bit loads and stores Connor Abbott (1): radv: Call nir_propagate_invariant() Dave Stevenson (1): broadcom/v3d: Allow importing linear BOs with arbitrary offset/stride. Dylan Baker (2): nir: Add is_not_negative helper function Bump version for rc3 Eric Engestrom (12): ttn: fix 64-bit shift on 32-bit `1` egl: fix deadlock in malloc error path util/os_file: fix double-close() anv: fix format string in error message freedreno/drm-shim: fix mem leak nir: fix memleak in error path anv: add support for driconf wsi: add minImageCount override anv: add support for vk_x11_override_min_image_count amd: move adaptive sync to performance section, as it is defined in xmlpool radv: add support for vk_x11_override_min_image_count drirc: override minImageCount=2 for gfxbench Erik Faye-Lund (1): gallium/auxiliary/indices: consistently apply start only to input Hal Gentz (1): glx: Fix SEGV due to dereferencing a NULL ptr from XCB-GLX. Jason Ekstrand (7): anv: Bump maxComputeWorkgroupSize nir: Handle complex derefs in nir_split_array_vars nir: Don't infinitely recurse in lower_ssa_defs_to_regs_block nir: Add a block_is_unreachable helper nir/repair_ssa: Repair dominance for unreachable blocks nir/repair_ssa: Insert deref casts when needed nir/dead_cf: Repair SSA if the pass makes progress Jonathan Marek (1): freedreno/a2xx: ir2: fix lowering of instructions after float lowering Kenneth Graunke (1): iris: Report correct number of planes for planar images Lepton Wu (1): virgl: Fix pipe_resource leaks under multi-sample. Lionel Landwerlin (2): egl: fix platform selection vulkan/overlay: bounce image back to present layout Marek Olšák (2): radeonsi/gfx10: don't call gfx10_destroy_query with compute-only contexts radeonsi/gfx10: fix wave occupancy computations Samuel Pitoiset (1): nir: do not assume that the result of fexp2(a) is always an integral Sergii Romantsov (1): intel/dri: finish proper glthread Timur Kristóf (1): st/nine: Properly initialize GLSL types for NIR shaders. Vinson Lee (2): swr: Fix build with llvm-9.0 again. travis: Fail build if any command in if statement fails. git tag: mesa-19.2.0-rc3 https://mesa.freedesktop.org/archive/release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz SHA256: 3679868b6dd446a38bd5125e84e20fd73dc9dc5a3475845363488167998821a0 release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz SHA512: 378bb27073d99032c489a0fcc44157017d27d01c24c3bb7e3e32f59b298cf0c7409351d18fbbfb1ccfb799e02f9166450dc73390e98a026f60a4ab0583944d68 release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz PGP: https://mesa.freedesktop.org/archive/release/mesa/meson-dist/mesa-19.2.0-rc3.tar.xz.sig signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/3] panfrost/ci: Run dEQP with the surfaceless platform
Series A-b
On Tue, Sep 10, 2019 at 07:13:07PM +0100, Tomeu Vizoso wrote:
> Instead of running it with the Wayland platform, which introduces
> unwanted dependencies and complexity.
>
> Makes tests run 30% faster, as well.
>
> Signed-off-by: Tomeu Vizoso
> ---
> .../drivers/panfrost/ci/create-rootfs.sh | 2 +-
> .../drivers/panfrost/ci/debian-install.sh | 35 ---
> .../drivers/panfrost/ci/deqp-runner.sh| 10 ++
> src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 21 ---
> 4 files changed, 44 insertions(+), 24 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/ci/create-rootfs.sh
> b/src/gallium/drivers/panfrost/ci/create-rootfs.sh
> index e01ccb34cb4a..e84f2271f422 100644
> --- a/src/gallium/drivers/panfrost/ci/create-rootfs.sh
> +++ b/src/gallium/drivers/panfrost/ci/create-rootfs.sh
> @@ -2,7 +2,7 @@
>
> set -ex
>
> -apt-get -y install --no-install-recommends initramfs-tools libpng16-16
> weston strace libsensors5
> +apt-get -y install --no-install-recommends initramfs-tools libpng16-16
> strace libsensors5 libexpat1 libdrm2
> passwd root -d
> chsh -s /bin/sh
> ln -s /bin/sh /init
> diff --git a/src/gallium/drivers/panfrost/ci/debian-install.sh
> b/src/gallium/drivers/panfrost/ci/debian-install.sh
> index ec2aa6723a88..4205ae56e35d 100644
> --- a/src/gallium/drivers/panfrost/ci/debian-install.sh
> +++ b/src/gallium/drivers/panfrost/ci/debian-install.sh
> @@ -28,7 +28,6 @@ apt-get -y install --no-install-recommends \
> python3-jinja2 \
> bison \
> flex \
> - libwayland-dev \
> gettext \
> cmake \
> bc \
> @@ -49,6 +48,7 @@ apt-get -y install --no-install-recommends \
> gdc-9 \
> lld-8 \
> nasm \
> + libegl1-mesa-dev \
> \
> libdrm-dev:${DEBIAN_ARCH} \
> libx11-dev:${DEBIAN_ARCH} \
> @@ -70,31 +70,42 @@ apt-get -y install --no-install-recommends \
> libxrandr-dev:${DEBIAN_ARCH} \
> libxshmfence-dev:${DEBIAN_ARCH} \
> libelf-dev:${DEBIAN_ARCH} \
> - libwayland-dev:${DEBIAN_ARCH} \
> - libwayland-egl-backend-dev:${DEBIAN_ARCH} \
> zlib1g-dev:${DEBIAN_ARCH} \
> libglvnd-core-dev:${DEBIAN_ARCH} \
> - wayland-protocols:${DEBIAN_ARCH} \
> + libgles2-mesa-dev:${DEBIAN_ARCH} \
> + libegl1-mesa-dev:${DEBIAN_ARCH} \
> libpng-dev:${DEBIAN_ARCH}
>
> -
> ### Cross-build dEQP
> mkdir -p /artifacts/rootfs/deqp
>
> -wget
> https://github.com/KhronosGroup/VK-GL-CTS/archive/opengl-es-cts-3.2.5.0.zip
> -unzip -q opengl-es-cts-3.2.5.0.zip -d /
> -rm opengl-es-cts-3.2.5.0.zip
> +git config --global user.email "m...@example.com"
> +git config --global user.name "Mesa CI"
> +# XXX: Use --depth 1 once we can drop the cherry-picks.
> +git clone \
> +https://github.com/KhronosGroup/VK-GL-CTS.git \
> +-b opengl-es-cts-3.2.5.1 \
> +/VK-GL-CTS
> +cd /VK-GL-CTS
> +# Fix surfaceless build
> +git cherry-pick -x 22f41e5e321c6dcd8569c4dad91bce89f06b3670
> +git cherry-pick -x 1daa8dff73161ea60ead965bd6c9f2a0a2165648
> +
> +# surfaceless links against libkms and such despite not using it.
> +sed -i '/gbm/d' targets/surfaceless/surfaceless.cmake
> +sed -i '/libkms/d' targets/surfaceless/surfaceless.cmake
> +sed -i '/libgbm/d' targets/surfaceless/surfaceless.cmake
>
> -cd /VK-GL-CTS-opengl-es-cts-3.2.5.0
> python3 external/fetch_sources.py
>
> cd /artifacts/rootfs/deqp
> -cmake -DDEQP_TARGET=wayland \
> +cmake -G Ninja\
> + -DDEQP_TARGET=surfaceless \
>-DCMAKE_BUILD_TYPE=Release \
>-DCMAKE_C_COMPILER=${GCC_ARCH}-gcc \
>-DCMAKE_CXX_COMPILER=${GCC_ARCH}-g++\
> - /VK-GL-CTS-opengl-es-cts-3.2.5.0
> -make -j$(nproc)
> + /VK-GL-CTS
> +ninja
> rm -rf /artifacts/rootfs/deqp/external
> rm -rf /artifacts/rootfs/deqp/modules/gles31
> rm -rf /artifacts/rootfs/deqp/modules/internal
> diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> index bf37d75aeabb..11faf2350569 100644
> --- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> +++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> @@ -5,23 +5,18 @@ DEQP_OPTIONS="$DEQP_OPTIONS --deqp-visibility=hidden"
> DEQP_OPTIONS="$DEQP_OPTIONS --deqp-log-images=disable"
> DEQP_OPTIONS="$DEQP_OPTIONS --deqp-watchdog=enable"
> DEQP_OPTIONS="$DEQP_OPTIONS --deqp-crashhandler=enable"
> +DEQP_OPTIONS="$DEQP_OPTIONS --deqp-surface-type=pbuffer"
>
> -export XDG_RUNTIME_DIR=/tmp
> export LIBGL_DRIVERS_PATH=/mesa/lib/dri/
> export LD_LIBRARY_PATH=/mesa/lib/
> -export XDG_CONFIG_HOME=$(pwd)
> export MESA_GLES_VERSION_OVERRIDE=3.0
>
> DEVFREQ_GOVERNOR=`echo /sys/devices/platform/*.gpu/devfreq/devfreq0/governor`
> echo performance > $DEVFREQ_GOVERNOR
>
> -echo "[core]\nidle-time=0\nrequire-input=false\n[shell]\nlocking=false" >
> weston.ini
> -
> cd /deqp/modules/gles2
>
> # Generate
[Mesa-dev] [Bug 111478] Add OpenGL ES (GLES) 1.0, 1.1 and 2.0 to docs/features.txt
https://bugs.freedesktop.org/show_bug.cgi?id=111478 --- Comment #6 from Creak --- (In reply to Rob Clark from comment #4) > And now that we are using drm_shim to run shader-db in CI for a few drivers > (freedreno and vc4), I'm secretly hoping someone comes up w/ a way to > generate features.txt (at least for drivers w/ drm_shim support) by running > glxinfo in CI, since features.txt requires that developers remember to > actually update it. I took a look at drm_shim [1] and it seems that this tool helps faking the driver at the kernel level, is that it? If it is, what I'm not so sure is how that tool works. Looking at the readme, I don't understand the backend options. I was hoping to see the same drivers as the ones listed in features.txt. So.. apparently I'm missing something.. Could you explain it to me? (you can PM me if you'd rather not go too off topic on this thread). [1] https://gitlab.freedesktop.org/anholt/drm-shim -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, September 11, 2019 11:23 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; aio.olive...@intel.com
Subject: [PATCH] st/nir: fix illegal designated initializer in
st_glsl_to_nir.cpp
IIRC, designated initializers are not legal C++.
Fixes the MSVC build.
Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function")
---
src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
b/src/mesa/state_tracker/st_glsl_to_nir.cpp
index 280a778..d6a0264 100644
--- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
@@ -688,7 +688,7 @@ st_link_nir(struct gl_context *ctx,
*/
if (shader_program->data->spirv) {
static const gl_nir_linker_options opts = {
- .fill_parameters = true,
+ true /*fill_parameters */
};
if (!gl_nir_link(ctx, shader_program, ))
return GL_FALSE;
--
1.8.5.6
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
