Re: [Mesa-dev] Merging experimental r600/nir code

2020-02-11 Thread Dieter Nützel
Hello Gert, your merge 'broke' LTO and then later on PGO compilation/linking. I do generally compiling with '-Dgallium-drivers=r600,radeonsi,swrast' for testing radeonsi and (your) r600 work. ;-) After your merge I get several warnings in 'addrlib' with LTO and even a compiler error (gcc

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

2020-02-11 Thread Charmaine Lee
Those two patches are simple fixes to our svga driver and have been tested in house for a while already. So I thought it's ok to push the patches directly. Thanks for reminding me of the MR practice, will keep that in mind for next submits. -Charmaine

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

2020-02-11 Thread Michel Dänzer
On 2020-02-11 6:49 p.m., Charmaine Lee wrote: > > Those two patches are simple fixes to our svga driver and have been tested in > house for a while already. > So I thought it's ok to push the patches directly. > Thanks for reminding me of the MR practice, will keep that in mind for next >

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

2020-02-11 Thread Brian Paul
I'm going to update the docs regarding patches and gitlab. It's kind of a mess now. -Brian On 02/11/2020 03:03 AM, Michel Dänzer wrote: Hi Charmaine, it looks like you pushed this patch and another one directly to the main Mesa repository master branch. Pushing directly to the main

Re: [Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

2020-02-11 Thread Michel Dänzer
Hi Charmaine, it looks like you pushed this patch and another one directly to the main Mesa repository master branch. Pushing directly to the main Mesa repository is no longer common practice, and indeed discouraged, as it circumvents the pre-merge GitLab CI pipeline and forfeits all other