Re: [Mesa-dev] Playing with display timing -- VK_MESA_present_period

2020-02-17 Thread Keith Packard
Michel Dänzer writes: > Should this extension specify how it interacts with the various > VK_PRESENT_MODE_* modes? Yes. It needs to be clear on how this extension interacts with all existing display stuff. Thanks for pointing out one pretty important interaction. > For one example: With

Re: [Mesa-dev] [PATCH 8/8] nvc0: Add shader disk caching

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds shader disk caching for nvc0 to reduce the need to every time compile > shaders. Shaders are saved into disk_shader_cache from nvc0_screen structure. > > It serializes the input nv50_ir_prog_info to compute the hash key and > also to

Re: [Mesa-dev] [PATCH 7/8] nv50/ir: Move separateFragData

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Nv50_ir_prog_info (input) was in the wrong place, moved it to > nv50_ir_prog_info_out. > > Signed-off-by: Mark Menzynski > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 2 +- >

Re: [Mesa-dev] [PATCH 6/8] tgsi/util: Change boolean for bool

2020-02-17 Thread Karol Herbst
by the way: Mind creating a MR on gitlab with this and the 2nd patch? This way we can get them reviewed and tested there and merged before the nouveau related patches. On Mon, Feb 17, 2020 at 9:09 PM Karol Herbst wrote: > > Reviewed-by: Karol Herbst > > On Mon, Feb 17, 2020 at 6:41 PM Mark

Re: [Mesa-dev] [PATCH 6/8] tgsi/util: Change boolean for bool

2020-02-17 Thread Karol Herbst
Reviewed-by: Karol Herbst On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > I was getting errors with "boolean" when compiling. This patch changes > boolean to bool from . > > Signed-off-by: Mark Menzynski > --- > src/gallium/auxiliary/tgsi/tgsi_util.c | 2 +- >

Re: [Mesa-dev] [PATCH 5/8] nv50/ir: Add nv50_ir_prog_info serialize

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds a function for serializing a nv50_ir_prog_info structure, which is > needed for shader caching. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 4 + >

Re: [Mesa-dev] [PATCH 4/8] nv50/ir: Add prog_info_out print

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds a function for printing nv50_ir_prog_info_out structure > in JSON-like format, which could be used in debugging. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 3 + >

Re: [Mesa-dev] [PATCH 3/8] nv50/ir: Add nv50_ir_prog_info_out serialize and deserialize

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds functions for serializing and deserializing > nv50_ir_prog_info_out structure, which are needed for shader caching. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 44 >

Re: [Mesa-dev] [PATCH 2/8] util/blob: Add overwrite function for uint8

2020-02-17 Thread Karol Herbst
On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Overwrite function for this type was missing and I needed it for my project. > > Signed-off-by: Mark Menzynski > --- > src/util/blob.c | 9 + > src/util/blob.h | 15 +++ > 2 files changed, 24 insertions(+) > > diff

Re: [Mesa-dev] Playing with display timing -- VK_MESA_present_period

2020-02-17 Thread Michel Dänzer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2020-02-02 7:51 a.m., Keith Packard wrote: > > I spent some time over the last week experimenting with a different > way of doing frame timing. > > Instead of specifying *when* a particular frame should be > displayed, how about we specify how

[Mesa-dev] [PATCH 4/8] nv50/ir: Add prog_info_out print

2020-02-17 Thread Mark Menzynski
Adds a function for printing nv50_ir_prog_info_out structure in JSON-like format, which could be used in debugging. Signed-off-by: Mark Menzynski --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 3 + .../drivers/nouveau/codegen/nv50_ir_print.cpp | 155 ++ 2 files changed,

[Mesa-dev] [PATCH 8/8] nvc0: Add shader disk caching

2020-02-17 Thread Mark Menzynski
Adds shader disk caching for nvc0 to reduce the need to every time compile shaders. Shaders are saved into disk_shader_cache from nvc0_screen structure. It serializes the input nv50_ir_prog_info to compute the hash key and also to do a byte compare between the original nv50_ir_prog_info and the

[Mesa-dev] [PATCH 3/8] nv50/ir: Add nv50_ir_prog_info_out serialize and deserialize

2020-02-17 Thread Mark Menzynski
Adds functions for serializing and deserializing nv50_ir_prog_info_out structure, which are needed for shader caching. Signed-off-by: Mark Menzynski --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 44 .../nouveau/codegen/nv50_ir_emit_gk110.cpp| 14 +-

[Mesa-dev] [PATCH 2/8] util/blob: Add overwrite function for uint8

2020-02-17 Thread Mark Menzynski
Overwrite function for this type was missing and I needed it for my project. Signed-off-by: Mark Menzynski --- src/util/blob.c | 9 + src/util/blob.h | 15 +++ 2 files changed, 24 insertions(+) diff --git a/src/util/blob.c b/src/util/blob.c index 94d5a9dea74..5bf4b924c91

[Mesa-dev] [PATCH 1/8] nv50/ir: add nv50_ir_prog_info_out

2020-02-17 Thread Mark Menzynski
From: Karol Herbst Split out the output relevant fields from the nv50_ir_prog_info struct in order to have a cleaner separation between the input and output of the compilation. Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir.cpp | 49 ++--

[Mesa-dev] [PATCH 7/8] nv50/ir: Move separateFragData

2020-02-17 Thread Mark Menzynski
Nv50_ir_prog_info (input) was in the wrong place, moved it to nv50_ir_prog_info_out. Signed-off-by: Mark Menzynski --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +-

[Mesa-dev] [PATCH 6/8] tgsi/util: Change boolean for bool

2020-02-17 Thread Mark Menzynski
I was getting errors with "boolean" when compiling. This patch changes boolean to bool from . Signed-off-by: Mark Menzynski --- src/gallium/auxiliary/tgsi/tgsi_util.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_util.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/8] nv50/ir: Add nv50_ir_prog_info serialize

2020-02-17 Thread Mark Menzynski
Adds a function for serializing a nv50_ir_prog_info structure, which is needed for shader caching. Signed-off-by: Mark Menzynski --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 4 + .../nouveau/codegen/nv50_ir_serialize.cpp | 81 +++ 2 files changed, 85 insertions(+)