Re: [Mesa-dev] GitLab migration of Piglit

As we discussed offline, I think it should be part of the mesa project. As I understand your explanation: if piglit becomes a mesa group project then anyone in the mesa group would automatically get piglit write access, but we can still give specific people write access to the piglit repo (without

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

Quoting Laura Ekstrand (2018-05-24 17:27:09) > From: Jean Hertel > > This tells Sphinx how to build our website from reStructured Text. > > Signed-off-by: Jean Hertel > --- > docs/conf.py | 162 > +++ > 1 file changed, 162 insertions(+)

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

Quoting Eric Engestrom (2018-06-01 09:50:34) > On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-05-31 07:04:33) > > > Some people have mentioned they don't like the current get_reviewers.pl > > > script (the one from the ke

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

Quoting Samuel Pitoiset (2018-06-01 08:58:42) > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > > Quoting Alex Smith (2018-06-01 07:56:38) > >> On 1 June 2018 at 15:48, Dylan Baker wrote: > >> > >> Quoting Alex Smith (2018-05-31 08:4

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

Quoting Eric Engestrom (2018-06-01 02:41:36) > On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > > Quoting Laura Ekstrand (2018-05-24 17:27:09) > > > From: Jean Hertel > > > > > > This tells Sphinx how to build our website from reStructured Te

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

Quoting Alex Smith (2018-05-31 08:44:18) > With GFX9 merged shaders, active_stages would be set to the original > stages specified if shaders were not cached, but to the stages still > present after merging if they were. > > Be consistent and use the original stages. > > Signed-off-by: Alex

Re: [Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

('vl/vl_winsys_dri.c') >if with_dri3 > files_libgalliumvlwinsys += files('vl/vl_winsys_dri3.c') > -- > 2.17.0 > Fixes: b1b65397d0c4978e36a84c0a1c98a4bd6cb9588e ("meson: Build gallium auxiliary") Reviewed-by: Dylan Baker Do you need me to push this for you? Dyla

Re: [Mesa-dev] [PATCH mesa] travis: use correct form for array options

This seems fine to me, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-06-05 03:59:40) > I'd like to eventually drop support for the confusing "an array of > a single empty string is meant to be interpreted as an empty array", so > let's start by not using it anymo

Re: [Mesa-dev] [PATCH mesa] travis: use correct form for array options

You might also be interested in this: https://github.com/mesonbuild/meson/pull/3696 Quoting Eric Engestrom (2018-06-05 03:59:40) > I'd like to eventually drop support for the confusing "an array of > a single empty string is meant to be interpreted as an empty array", so > let's start by not

Re: [Mesa-dev] [PATCH mesa] vma/tests: cast away implementation detail of using strtoul()

Yeah, Scott and I thought that went to the list before I did an offer the shoulder review, then realized it didn't after pushing. On June 6, 2018 10:31:38 AM PDT, Eric Anholt wrote: >Eric Engestrom writes: > >> On MacOS, the build fails because of a compiler complaint about >> a downcast: >>

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

Quoting Adam Jackson (2018-05-29 06:50:46) > GL_LIB expands to GLX_mesa, but applications should not link against > that. -lGL is never wrong, just hardcode it. Actually There is this really stupid option in the autotools build called --gl-lib-name. We should remove that. Emil and I had also

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

Quoting Alex Smith (2018-06-01 07:56:38) > On 1 June 2018 at 15:48, Dylan Baker wrote: > > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, bu

[Mesa-dev] [ANNOUNCE] mesa 18.1.1

Hi List, 18.1.1 is now available. In this release we have: Numerous fixes for radv, a few fixes for i965, tegra, amd/addrlib, dri3, virgl, tgsi, nv30, opencl, core mesa, core vulkan, st/mesa, etnaviv and spirv all got fixes. A few specifically: Radv fixed one extension and several features

Re: [Mesa-dev] [PATCH mesa] meson: fix platforms check for `-D egl=true`

Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-06-04 03:46:32) > Fixes: 0ed6a87a106b6e2266e0 "meson: fix platforms=[]" > Reported-by: Christoph Haag > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

Quoting Daniel Stone (2018-06-03 13:19:51) > Hi Laura, > > On 25 May 2018 at 01:27, Laura Ekstrand wrote: > > When reviewing these patches, please note: > > 1. This patch series does *not* touch content. Please do not > > bikeshed > >the content of webpages here. That will

Re: [Mesa-dev] [PATCH 08/11] radeonsi: fix memory exhaustion issue with DCC statistics gathering with DRI2

Quoting Marek Olšák (2018-06-29 09:48:08) > On Fri, Jun 29, 2018 at 11:40 AM, Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-18 16:33:09) > >> From: Marek Olšák > >> > >> Cc: 18.1 > >> --- > >> src/gallium/drivers/radeonsi/si_blit.c |

[Mesa-dev] [ANNOUNCE] mesa 18.1.3

Hi List, Mesa 18.1.3 is now available. This is a bug fix point release in the 18.1 series. In this release we have: - numerous fixes for radv - some fixes for common radeon code - several meson fixes - fixes for autotools with non-gnu grep - fixes for both the nir and glsl compilers - An

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

Quoting Juan A. Suarez Romero (2018-06-19 00:08:27) > On Fri, 2018-06-15 at 09:36 -0700, Dylan Baker wrote: > > Quoting Juan A. Suarez Romero (2018-06-15 07:26:18) > > > On Thu, 2018-06-14 at 10:16 -0700, Dylan Baker wrote: > > > > Quoting Bas Nieuwenhuizen (2018-06

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

Quoting Emil Velikov (2018-06-26 06:19:08) > On 21 June 2018 at 16:15, Dylan Baker wrote: > > Quoting Emil Velikov (2018-04-24 10:49:21) > >> From: Emil Velikov > >> > >> Bring back the "detection" of the said variables, to allow > >> stan

Re: [Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

Quoting Marek Olšák (2018-06-18 16:33:08) > From: Marek Olšák > > Some fields shouldn't be initialized, like framebuffers_bound and other stats. > It's hopefully complete now. > > Cc: 18.1 > --- > src/gallium/drivers/radeonsi/si_texture.c | 31 ++- > 1 file changed, 25

Re: [Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

Quoting Marek Olšák (2018-06-26 09:31:40) > > > On Tue, Jun 26, 2018, 11:57 AM Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-18 16:33:08) > > From: Marek Olšák > > > > Some fields shouldn't be initialized, like framebuffers_bound an

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

Quoting Emil Velikov (2018-06-27 01:39:05) > On 26 June 2018 at 16:34, Dylan Baker wrote: > > > I just remembered that you can set two push remotes for a single branch, so > > I > > think I'll add a staging/18.1 branch to master as a second remote and push > > to

[Mesa-dev] [ANNOUNCE] mesa 18.1.3

Hi list, Mesa 18.1.3 is planned for Friday June 29th, at 10AM PDT. Statistics for this release: - 37 queued - 0 nominated - 2 rejected All rejected patches have already had author follow-ups. In the mesa repo, the branch "staging/18.1" in the mesa gitlab will (unless bugs are found) be

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

Quoting Dylan Baker (2018-06-21 08:15:20) > Quoting Emil Velikov (2018-04-24 10:49:21) > > From: Emil Velikov > > > > Bring back the "detection" of the said variables, to allow > > standalone execution. > > > > Fixes: db8cd8e36771 ("glc

Re: [Mesa-dev] [PATCH 1/4] radeonsi: disable DCC MSAA for 128bpp formats on Stoney

Quoting Marek Olšák (2018-06-22 14:16:36) > On Fri, Jun 22, 2018 at 12:48 PM, Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-20 18:01:55) > >> From: Marek Olšák > >> > >> Cc: 18.1 > >> --- > >> src/gallium/drivers/radeonsi/si_

Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions

ere are scripts that look over the master branch, and generate a list of commits to pull into the stable branch based on that. Dylan > > Cc: Dylan Baker > > Jason Ekstrand (2): > nir: Handle call instructions in foreach_src > nir/validate: Use the type from the tail of call

Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions

Quoting Jason Ekstrand (2018-06-25 12:36:39) > On June 25, 2018 12:09:50 Dylan Baker wrote: > > > Quoting Jason Ekstrand (2018-06-25 09:13:03) > >> These two patches are fixes for call instructions that get the basemark > >> shaders to pass NIR validation. Since t

Re: [Mesa-dev] [PATCH 01/19] radeonsi: clean up passing the is_monolithic flag for compilation

R300 had the same problem. Linking to amd_common ends up pulling in addrlib too. Jfyi On June 25, 2018 5:48:51 PM PDT, Timothy Arceri wrote: >On 26/06/18 09:51, Dieter Nützel wrote: >> Hello Marek, >> >> after this series landed I get this: >> >> Making all in targets/pipe-loader >> make[4]:

Re: [Mesa-dev] [PATCH 1/4] radeonsi: disable DCC MSAA for 128bpp formats on Stoney

Quoting Marek Olšák (2018-06-20 18:01:55) > From: Marek Olšák > > Cc: 18.1 > --- > src/gallium/drivers/radeonsi/si_texture.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_texture.c > b/src/gallium/drivers/radeonsi/si_texture.c > index

[Mesa-dev] [PATCH] meson: Fix typo that breaks -Dgalium-xvmc=false

_xmvc -> _xvmc. Sigh Fixes: a6943bb4ce99ea7af7222552f1326fb80823d0b2 ("meson: Fix auto option for xvmc") Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index e88616c9e82..b2722

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

Quoting Marek Olšák (2018-06-20 08:58:05) > On Wed, Jun 20, 2018 at 11:26 AM, Dylan Baker wrote: > > Quoting Marek Olšák (2018-06-08 20:16:54) > >> From: Marek Olšák > >> > >> This improves performance for certain games. > >> > >> Cc: 18.1 &

Re: [Mesa-dev] [Mesa-stable] [PATCH] opencl: autotools: Fix linking order for OpenCL target

Quoting Aaron Watry (2018-05-01 10:59:43) > Given the discussion that's ongoing, this patch might not land as-is, > but if it does: > Tested-By: Aaron Watry > > Note: The meson build currently works as-is and doesn't require an > equivalent patch. Just FYI, meson uses

[Mesa-dev] [PATCH] bin: force git show to use default pretty setting

I have pretty default to short, which breaks this script. cc: Emil Velikov <emil.veli...@collabora.com> cc: Andres Gomez <ago...@igalia.com> cc: Juan A. Suarez <jasua...@igalia.com> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- bin/get-fixes-pick-list.sh |

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

Quoting Emil Velikov (2018-04-26 11:04:01) > On 26 April 2018 at 18:45, Dylan Baker <dy...@pnwbakers.com> wrote: > > I have pretty default to short, which breaks this script. > > > Out of curiosity: why would you do this to yourself ;-) Because I use tig, so all I have to

Re: [Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

Quoting Emil Velikov (2018-04-26 10:35:50) > On 26 April 2018 at 18:24, Dylan Baker <dy...@pnwbakers.com> wrote: > > It turns out that the blocking target we had was hiding some race > > conditions in the anv driver with anv_extensions.h generation, we should > > fix tho

[Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

fd6d0f808e02 ("meson: remove workaround for custom target creating .h and .c files") Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/intel/vulkan/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/meson.build b/src/in

Re: [Mesa-dev] [ANNOUNCE] mesa 18.1.0-rc2

Quoting Emil Velikov (2018-05-03 03:40:47) > Hi Dylan, > > A few small nitpicks: > > On 27 April 2018 at 22:07, Dylan Baker <dy...@pnwbakers.com> wrote: > > Hi List, > > > s/List/list/ > > > Mesa 18.1.0-rc2 is now available. There are 20 nominate

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.1.0-rc2

On April 28, 2018 9:12:38 AM PDT, "Juan A. Suarez Romero" <jasua...@igalia.com> wrote: >On Fri, 2018-04-27 at 14:07 -0700, Dylan Baker wrote: >> Hi List, >> >> Mesa 18.1.0-rc2 is now available. There are 20 nominated patches, and >no queued >> or

Re: [Mesa-dev] [PATCH 3/4] meson: build libEGL

Quoting Daniel Stone (2017-10-19 07:34:28) > Hi Dylan, > > On 19 October 2017 at 01:55, Dylan Baker <dy...@pnwbakers.com> wrote: > > This is based heavily on Daniel Stone's work for the same, rebased on > > master and with a number of TODO's fixed. > > > &g

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

Quoting Emil Velikov (2017-10-19 09:44:37) > On 18 October 2017 at 18:27, Dylan Baker <dy...@pnwbakers.com> wrote: > > >> > +Note that in meson this defaults to "debug", and not setting it to > >> > +"release" will yield non-opti

[Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

afael.antogno...@intel.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- src/gallium/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/meson.build b/src/gallium/meson.build index a65b32c658e..97347819d60 100644 --- a/src/gallium/meson.b

[Mesa-dev] [PATCH 4/7] meson: build r300 driver

This is build tested only Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 4 +- meson_options.txt| 2 +- src/gallium/drivers/r300/meson.build | 156 +++ src/gallium/meson

[Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

to not have to override the std for gcc/clang, but ensure that it's not set to gnu99 when building with MSVC when there's a straightforward code change that allows removing the need for gnu99. I have compile tested this with GCC and Clang cc: Brian Paul <bri...@vmware.com> Signed-off-by: Dylan

[Mesa-dev] Meson for remaining gallium drivers (except SWR)

This series implements the rest of the remaining gallium drivers except SWR. I have a branch for SWR, but it needs some upstream meson patches that haven't landed, but will hopefully be in 0.44.0 Most of this is pretty straight forward, except for one change to svga. I have no hardware/software

[Mesa-dev] [PATCH 2/7] meson: add proper LLVM modules to check for RadeonSI as well

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1da1bb06798..64084d686e3 100644 --- a/meson.build +++ b/meson.build @@ -647,7 +647,7 @@ if with_gallium_freedreno

[Mesa-dev] [PATCH 7/7] meson: build virgl driver

Build tested only. cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build| 12 ++--- meson_options.txt | 2 +- src/gallium/drivers/virgl/meson.bui

[Mesa-dev] [PATCH 6/7] meson: build svga driver on linux

Build tested only. cc: Brian Paul <bri...@vmware.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 2 + meson_options.txt | 2 +- src/gallium/drivers/svga/meson.build| 88 ++

[Mesa-dev] [PATCH 3/7] meson: build i915g driver

Build tested only. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 7 +++- src/gallium/drivers/i915/meson.build| 70 + src/gallium/meson.build | 7 +++- src/gallium/targets/dri/meson

[Mesa-dev] [PATCH 5/7] meson: build r600

This has been build tested only. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 20 -- meson_options.txt| 2 +- src/gallium/drivers/r600/meson.build | 128 +++ src/gallium/meson

Re: [Mesa-dev] [PATCH mesa v2] meson: wire up selinux

I don't have an selinux enabled system to test with either, but this looks correct and doesn't break the build. Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Eric Engestrom (2017-10-26 09:30:24) > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- &

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

I have a few tiny nits, but otherwise this seems fine: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Eric Engestrom (2017-10-26 08:40:56) > Suggested-by: Jordan Justen <jordan.l.jus...@intel.com> > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> >

Re: [Mesa-dev] [PATCH mesa v2 2/2] meson: bring MESA_GIT_SHA1 in line with other build systems

one small nit, otherwise, Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Eric Engestrom (2017-10-26 08:40:57) > From: Eric Engestrom <e...@engestrom.ch> > > Meson's vcs_tag() uses the output of `git describe`, eg. > 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ >

Re: [Mesa-dev] [PATCH] meson: do not search for needless deps

Quoting Gert Wollny (2017-10-26 02:49:56) > > Am Mittwoch, den 25.10.2017, 10:24 +0200 schrieb Erik Faye-Lund: > > If we don't want to use these deps, there's no good reason to search > > for them in the first place. This should shave a bit of time for the > > initial build. > > --- > > > > This

Re: [Mesa-dev] meson for remaining class drivers

Quoting Eric Anholt (2017-10-26 10:33:11) > Dylan Baker <dy...@pnwbakers.com> writes: > > > [ Unknown signature status ] > > ping > > You had my r-b other than one comment. Are you pinging for something > else? Ilia and Timothy had expressed that they wante

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

Quoting Eric Engestrom (2017-10-26 02:40:20) > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > This has been tested with the osdemo from mesa-demos > > > > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > > --- > > meson.build

[Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

This fixes a race condition in the build. cc: Rob Clark <robdcl...@gmail.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27 04:55:25) > This avoids the following build-error when building with emtpy > vulkan-drivers and without glx=dri: > > Meson encountered

[Mesa-dev] [PATCH] meson: declare an empty xcb dependency

This is needed in cases where xcb isn't actually needed as a dependency, but may still be included somewhere. cc: Erik Faye-Lund <kusmab...@gmail.com> cc: Eric Engestrom <eric.engest...@imgtec.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- meson.build | 1 +

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

t looks off here, it looks like 4 space instead of 2, and the closing brace should be dedented. Otherwise this looks good to me, though it would be great if one of the ChromeOS guys could look at it (since I think that android builds are always done with android.mk, and this would only be f

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

Quoting Eric Engestrom (2017-10-27 02:28:05) > On Thursday, 2017-10-26 13:55:35 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-10-26 02:40:20) > > > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > > > +if with_shared_glapi > >

[Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

Fixes compiling the optional standalone glsl compiler. Reported-by: DrNick (on irc) Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- This is not compiled by default, but can be built by: meson build ninja -C build src/compiler/glsl/glsl_compiler src/compiler/glsl/meson.build | 2

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

Well, I went to push this, apparently this was in one of the osmesa patches as an unrelated change.. :/ So it's fixed. Dylan Quoting Dylan Baker (2017-10-27 10:25:33) > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. &

[Mesa-dev] [PATCH] scons: Fix glapi include path changes

fixes: 5daed06da2c0aaa4 ("osmesa: Include generated headers without path") cc: Mark Janes <mark.a.ja...@intel.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- src/mapi/glapi/SConscript | 1 + src/mesa/drivers/osmesa/SConscript | 4 +++- 2 files chang

Re: [Mesa-dev] [PATCH] scons: fix OSMesa driver build

Ah, I see that you fixed that already, Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Brian Paul (2017-10-27 15:35:09) > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- > src/mesa/drivers/osmesa/SConscript | 1 + > 1 file chang

Re: [Mesa-dev] [PATCH] scons: fix OSMesa driver build

I sent almost the same patch at exactly the same time. I also needed to add this path to src/map/glapi/Sconscript to get scons building. Maybe that's unrelated? Dylan Quoting Brian Paul (2017-10-27 15:35:09) > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- >

Re: [Mesa-dev] [PATCH v4 2/3] autotools: Include meson.build files in tarball

Quoting Eric Engestrom (2018-01-05 06:02:52) > On Thursday, 2018-01-04 10:28:41 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> > > Do we really want to use autotools' `dist` to package libdrm once meson > has landed? > I would've thou

Re: [Mesa-dev] [PATCH v4 3/3] README: Add note about meson

Quoting Eric Engestrom (2018-01-05 05:49:25) > On Thursday, 2018-01-04 10:28:42 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> > > Couple nitpicks, but: > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com&g

Re: [Mesa-dev] [PATCH v4 1/3] Add meson build system

Quoting Igor Gnatenko (2018-01-04 13:43:51) > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On Thu, 2018-01-04 at 10:28 -0800, Dylan Baker wrote: > > This patch adds a complete meson build system, including tests and > > install. It has the necessary h

[Mesa-dev] [PATCH v4 3/3] README: Add note about meson

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- README | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/README b/README index 26cab9d..58e55bc 100644 --- a/README +++ b/README @@ -15,9 +15,24 @@ with an older kernel. Com

[Mesa-dev] [PATCH v4 2/3] autotools: Include meson.build files in tarball

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- Makefile.am | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7b86214..66f70ca 100644 --- a/Makefile.am +++ b/Makefile.am @@ -135,7 +135,35 @@ if HAVE_

[Mesa-dev] [PATCH v4 0/3] Meson build system

build and install modetest (this was missed in the first version for some reason) - install amdgpu.ids as 644 instead of 444 Dylan Baker (3): Add meson build system autotools: Include meson.build files in tarball README: Add note about meson .editorconfig | 4 +- Makef

[Mesa-dev] [PATCH v4 1/3] Add meson build system

This patch adds a complete meson build system, including tests and install. It has the necessary hooks to allow it be used as a subproject for other meson based builds such as mesa. v4: - fix freedreno kgls check Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- .editor

[Mesa-dev] [PATCH 1/3] Add meson build system

This patch adds a complete meson build system, including tests and install. It has the necessary hooks to allow it be used as a subproject for other meson based builds such as mesa. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-and-tested-by: Igor Gnatenko <i.gn

[Mesa-dev] [PATCH 2/3] autotools: Include meson.build files in tarball

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- Makefile.am | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7b86214..66f70ca 100644 --- a/Makefile.am +++ b/Makefile.am @@ -135,7 +135,35 @@ if HAVE_

[Mesa-dev] [PATCH 3/3] README: Add note about meson

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- README | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/README b/README index 26cab9d..f3df9ac 100644 --- a/README +++ b/README @@ -15,9 +15,27 @@ with an older kernel. Com

Re: [Mesa-dev] [PATCH 14/14] meson: glsl: add missing nir header dependency

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Greg V (2017-12-31 08:55:28) > --- > src/compiler/glsl/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build > index 6aaa9

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

Quoting Greg V (2017-12-31 08:55:25) > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/meson.build >

Re: [Mesa-dev] [PATCH v3 3/4] meson: build clover

Quoting Jan Vesely (2018-01-05 14:16:41) > Hi, > > > sorry for the delay. I was mostly traveling during the holidays. No worries, I was also away over the holidays and didn't look at this until today. > > On Fri, 2017-12-15 at 10:54 -0800, Dylan Baker wrote: > > Th

[Mesa-dev] [PATCH 0/3] Meson build system

during compilation) - Don't assign file lists to variables when possible. In a few cases files need to be conditionally added, but if we're not in one of those cases just put the lists directly in the exectuable or library declaration. Dylan Baker (3): Add meson build system aut

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

Quoting Eric Engestrom (2018-01-05 05:34:53) > On Wednesday, 2018-01-03 13:31:28 -0800, Dylan Baker wrote: > > This patch adds a complete meson build system, including tests and > > install. It has the necessary hooks to allow it be used as a subproject > > for oth

Re: [Mesa-dev] [PATCH 08/14] meson: fix BSD build

Quoting Greg V (2017-12-31 08:55:22) > --- > meson.build | 43 ++- > 1 file changed, 22 insertions(+), 21 deletions(-) > > diff --git a/meson.build b/meson.build > index d9f7ea9b2c..af62baf437 100644 > --- a/meson.build > +++ b/meson.build > @@ -199,12

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Please add a comment that svn suffixes are stripped by meson as of 0.43, and git suffixes are strippped as of 0.44. With that, Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Greg V (2017-12-31 08:55:24) > When LLVM is built inside of a git repo (even way below, e.g. /usr/p

Re: [Mesa-dev] [PATCH 10/14] meson: handle LLVM 'x.x.xgit-revision' versions

Quoting Juan A. Suarez Romero (2018-01-05 04:42:05) > On Fri, 2018-01-05 at 10:35 +0100, Gert Wollny wrote: > > On Sun, 2017-12-31 at 19:55 +0300, Greg V wrote: > > > > When LLVM is built inside of a git repo (even way below, e.g. > > > > /usr/ports/.git > > > > exists, and LLVM is built in

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Thanks so much for working on this, especially the meson bits! Quoting Greg V (2017-12-31 08:55:14) > Hello everyone and happy new year! :) > > This set of patches makes the Meson build work on FreeBSD, including > RADV, ANV, wayland-egl, VAAPI, VDPAU. > > I also managed to get SWR working,

[Mesa-dev] [PATCH 4/8] meson: don't use intermediate variables that are immediately discarded

For things like: loop x = func() list += x end just do: loop list += func() end Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/broadcom/cle/meson.build | 3 +-- src/intel/genxml/meson.build | 3 +-- src/intel/isl/meson.build

[Mesa-dev] [PATCH 8/8] meson: add variable for including include/GL/internal

Signed-off-by: --- include/meson.build | 1 + src/glx/meson.build | 10 ++ src/glx/tests/meson.build | 4 ++-- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/include/meson.build b/include/meson.build index e4dae91..9b34490 100644

[Mesa-dev] [PATCH 6/8] meson: move libsensors dependency to libgallium

This simplifies the build by removing the need to link targets against libsensors. Suggested-by: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/auxiliary/meson.build | 2 +- src/gallium/drivers/etnaviv/meson.b

[Mesa-dev] [PATCH 2/8] meson: Use include variables

These were added after adderlib was mesonified, but it still good to use them instead of open coding them. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/amd/addrlib/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/addrlib/meson.build

Re: [Mesa-dev] [PATCH 08/14] meson: fix BSD build

On January 5, 2018 5:12:15 PM PST, Greg V <greg@unrelenting.technology> wrote: > >On 01/06/2018 01:06, Dylan Baker wrote: >> Quoting Greg V (2017-12-31 08:55:22) >>> +is_like_linux = host_machine.system() == 'linux' or >host_machine.system().contains('bsd') # FIXME

[Mesa-dev] [PATCH 3/8] meson: Use consistent style for tests

Don't use intermediate variables, use consistent whitespace. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/broadcom/qpu/meson.build| 12 ++- src/compiler/glsl/tests/meson.build | 90 -- src/compiler/nir/meson.build

[Mesa-dev] [PATCH 7/8] meson: define inc_gbm as empty if not otherwise assigned

Otherwise this could be undefined in the egl directory. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/meson.build b/src/meson.build index 5fc14ac..730b2ff 100644 --- a/src/meson.build +++ b/src/meson

[Mesa-dev] [PATCH 0/8] Meson cleanups, style fixes, and race hardening

for nir and nir's generated headers. This should make the code easier to maintain going forward. Dylan Baker (8): meson: Use consistent style meson: Use include variables meson: Use consistent style for tests meson: don't use intermediate variables that are immediately discarded meson: Use

[Mesa-dev] [PATCH 5/8] meson: Use dependencies for nir

. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/amd/common/meson.build| 5 +++-- src/amd/vulkan/meson.build| 6 +++--- src/broadcom/compiler/meson.build | 4 ++-- src/compiler/glsl/meson.build | 3 ++- src/compiler/meson

[Mesa-dev] [PATCH 1/8] meson: Use consistent style

Currently the meosn build has a mix of two styles: arg : [foo, ... bar], and arg :[ foo, ..., bar, ] For consistency let's pick one. I've picked the later style, which I think is more readable, and is more common in the mesa code base. Signed-off-by: Dylan Baker <dylanx.c

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

On January 5, 2018 5:00:59 PM PST, Greg V <greg@unrelenting.technology> wrote: >On 01/06/2018 01:36, Dylan Baker wrote: >> Quoting Greg V (2017-12-31 08:55:25) >>> --- >>> src/gallium/drivers/radeonsi/meson.build | 2 +- >>> src/mesa/meson.build

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

Please make sure the new .c file is added in the meson build as well before pushing. Dylan Quoting Christian König (2018-01-10 05:03:44) > My last status was that Leo wanted to commit this. > > Leo are you still waiting for something? > > Christian. > > Am 10.01.2018 um 10:29 schrieb Julien

Re: [Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

I also prefer Jason's approach of moving just the creation of the mako Template inside the if __main__ block, but leaving the actual string at the top level. Alternatively we could split anv_extensions.py into two files: one that has the constant data, and one that generates anv_extensions.c. I

Re: [Mesa-dev] [PATCH v2] anv: Import mako templates only during execution of anv_extensions

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Andres Gomez (2018-01-10 13:11:51) > anv_extensions usage from anv_icd was bringing the unwanted dependency > of mako templates for the latter. We don't want that since it will > force the dependency even for distributable

Re: [Mesa-dev] meson: vdpau broken on r600

I'm not sure off the top of my head. I don't have an r600 anymore, but I have an SI and a nouveau machine, so I'll see if I can reproduce the problem there and fix it. Dylan Quoting Marc Dietrich (2018-01-09 02:38:33) > Hi Dylan, > > just found that vdpau does not work on r600 with meson build.

[Mesa-dev] [PATCH] meson: generate translations for driconf

of make or ninja. I think this can be fixed upstream, but in the mean time this adds support for using translations. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/util/xmlpool/gen_translations.py | 91 +- src/util/xmlpool/meson.build

<    7   8   9   10   11   12   13   14   15   16   >