Re: [Mesa-dev] [PATCH] docs/release-calendar: restore the missing 18.1 column

Quoting Emil Velikov (2018-06-20 05:33:48) > From: Emil Velikov > > Earlier commit removed the column, instead of adjusting it's height. > > Cc: Dylan Baker > Fixes: 0d4f338a116 ("docs: Update release-notes and calendar") > Signed-off-by: Emil Velikov > ---

Re: [Mesa-dev] [PATCH 7/8] radeonsi: always put persistent buffers into GTT on radeon

Quoting Marek Olšák (2018-06-08 20:16:54) > From: Marek Olšák > > This improves performance for certain games. > > Cc: 18.1 > --- > src/gallium/drivers/radeonsi/si_buffer.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_buffer.c

Re: [Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers (v5)

ric Engestrom) > > > > v3: * check for -Wmissing-field-initializers warning and then disable > > it > > because gcc and clang always accept -Wno-* (Dylan Baker) > > * Also disable this warning for C++ > > > > v4: * meson.build add -Wno-missing

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

Quoting Emil Velikov (2018-04-24 10:49:21) > From: Emil Velikov > > Bring back the "detection" of the said variables, to allow > standalone execution. > > Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python > script") > Cc

Re: [Mesa-dev] [PATCH 1/3] meson: Correct behavior of vdpau=auto

Quoting Eric Engestrom (2018-06-21 08:43:56) > On Thursday, 2018-06-21 08:38:05 -0700, Dylan Baker wrote: > > Currently if vdpau is set to auto, it will be disabled only in cases > > where gallium is disabled or the host OS is not supported (mac, haiku, > > windows). However o

[Mesa-dev] [PATCH 3/3] meson: Fix auto option for va

The same as the previous two patches, but for the libva state tracker. Fixes: 724916c8a84b5bba8f880f17da936585d52c97b6 ("meson: dedup gallium-xvmc logic") Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

[Mesa-dev] [PATCH 1/3] meson: Correct behavior of vdpau=auto

the right thing, and not error if libvdpau is not installed. Fixes: 992af0a4b8224bdb4809e01c2f00d2f32546aee5 ("meson: dedup gallium-vdpau logic") Signed-off-by: Dylan Baker --- meson.build | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/mes

[Mesa-dev] [PATCH 2/3] meson: Fix auto option for xvmc

This fixes the same problem as the previous patch did for vdpau, but for xvmc. Fixes: 724916c8a84b5bba8f880f17da936585d52c97b6 ("meson: dedup gallium-xvmc logic") Signed-off-by: Dylan Baker --- meson.build | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

> > Fixes: 6a60beba408 ("intel/tools: Add an error state to aub translator") > > Cc: Jason Ekstrand > > Cc: Lionel Landwerlin > > Cc: Dylan Baker > > Signed-off-by: Andres Gomez > > Looks like I'll have to update some stuff on my branches. >

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

This seems like a fine thing to do, I don't know how many people actually build tools from the tarball, but making them work seems useful. Reviewed-by: Dylan Baker Quoting Andres Gomez (2018-08-02 09:39:06) > Tarball distribution is done through "make distcheck". We include the &g

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

Quoting Jordan Justen (2018-07-25 17:12:20) > During code review, Jason pointed out that: > > 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" > > Didn't account for INTEL_SCALER_* environment variables. > > To fix this, let the compiler return the disk_cache driver flags. >

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

Reviewed-by: Dylan Baker Quoting Jon Turney (2018-08-02 06:58:07) > With a sufficently recent meson, the following warning is produced: > > WARNING: Passed invalid keyword argument "extra_args". > WARNING: This will become a hard error in the future. > > It se

Re: [Mesa-dev] [PATCH] meson, install_megadrivers: Also remove stale symlinks

Quoting Gert Wollny (2018-08-03 02:55:36) > From: Gert Wollny > > os.path.exists doesn't return True for stale symlinks, but they are in > the way later, when a link/file with the same name is to be created. > For instance it is conceivable that the pointed to file is replaced by > a file with a

[Mesa-dev] [ANNOUNCE] mesa 18.1.5

sing nir_intrinsics.h error Danylo Piliaiev (1): i965: Sweep NIR after linking phase to free held memory Dave Airlie (1): r600: enable tess_input_info for TES Dylan Baker (6): docs: Add sha256 sums for 18.1.4 tarballs cherry-ignore: add 4a67ce886a7b3def5f66c1aedf9e5436d157

Re: [Mesa-dev] [PATCH] meson, install_megadrivers: Also remove stale symlinks

Quoting Gert Wollny (2018-08-03 11:12:47) > Am Freitag, den 03.08.2018, 08:47 -0700 schrieb Dylan Baker: > > Quoting Gert Wollny (2018-08-03 02:55:36) > > > From: Gert Wollny > > > > > > os.path.exists doesn't return True for stale symlinks, but they are >

Re: [Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

I pushed a patch earlier that *should* make mkdir and getpid work with msvc Dylan Quoting Andres Gomez (2018-08-01 11:53:04) > Opt-out the code using mkdir() and getpid() which are spitting > warnings in the MSVC build: > > Compiling src\gallium\auxiliary\driver_ddebug\dd_draw.c ... >

[Mesa-dev] Mesa 18.1.6 Release Notice

Hi list, Due to a busy week and a slip of my mind I didn't get out the announcement for 18.1.6 on Wednesday. Therefore, I'm planning to make the release Monday August 13th, at or around 10AM PDT. It's been another busy cycle for 18.1, currently we have: - 40 Queued - 0 Nominated - 0 Rejected

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 1/2] i965/miptree: Fix can_blit_slice()

's row_pitch in can_blit_slice instead of its blt_pitch. > > Fixes 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3 > ("i965/miptree: Use the correct BLT pitch") For the scripts in stable to pick this up I believe you need a ":", as in Fixes: abc123 ("some patch") Dylan >

[Mesa-dev] [PATCH v3 18/48] meson: build wgl state tracker

--- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 50 ++ 2 files changed, 53 insertions(+) create mode 100644 src/gallium/state_trackers/wgl/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index

[Mesa-dev] [PATCH v3 16/48] meson: Add necessary defines for mesa_gallium on windows

--- src/mesa/meson.build | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index 29633691ee7..fa086466443 100644 --- a/src/mesa/meson.build +++ b/src/mesa/meson.build @@ -728,11 +728,19 @@ libmesa_classic =

[Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

By including the proper headers for getpid and for mkdir. Signed-off-by: Dylan Baker Reviewed-by: Marek Olšák --- src/gallium/auxiliary/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/auxiliary/meson.build b/src/gallium/auxiliary/meson.build index 98542d7ef3e

[Mesa-dev] [PATCH v3 10/48] meson: Add a platform for windows

This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 788021c05e9..37c07eaa581 100644 --- a/meson.build +++

[Mesa-dev] [PATCH v3 19/48] meson: build libgl-gdi target

--- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 44 +++ 2 files changed, 45 insertions(+) create mode 100644 src/gallium/targets/libgl-gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index

[Mesa-dev] [PATCH v3 32/48] meson: don't define GLX_USE_TLS for windows

Because the macros for exporting dll symbols and using TLS are mutually exclusive. --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index aaa7d9990ab..100d12f475d 100644 --- a/meson.build +++ b/meson.build @@ -329,7 +329,10 @@ if

[Mesa-dev] [PATCH v3 28/48] meson: make nm binary optional

This makes nm not required, but used if found. In general I imagine that this means that on windows nm wont be found, and on other platforms it will. v2: - fix gbm and egl symbols check tests to only be run if nm is found - reword commit message to reflect the code change --- meson.build

[Mesa-dev] [PATCH v3 15/48] meson: Add windows defines to glapi

These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13 -

[Mesa-dev] [PATCH v3 47/48] appveyor: use chocolatey (cinst) to install winflexbison

v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 26f50ce2596..bbd7e1cddb0 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,13 +34,11 @@ branches: clone_depth: 100 cache: --

[Mesa-dev] [PATCH v3 40/48] meson: disable graw tests on mingw

I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 ---

[Mesa-dev] [PATCH v3 22/48] meson: Don't check for posix_memalign on windows

There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 4dc76732d4a..dfeeab8c11a

[Mesa-dev] [PATCH v3 09/48] meson: build getopt when using msvc

completely untested --- src/getopt/meson.build | 29 + src/meson.build| 5 + 2 files changed, 34 insertions(+) create mode 100644 src/getopt/meson.build diff --git a/src/getopt/meson.build b/src/getopt/meson.build new file mode 100644 index

[Mesa-dev] [PATCH v3 41/48] meson: don't build or run mesa-sha1 test on windows

It crashes hard (pop-up window and all). --- src/util/meson.build | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/util/meson.build b/src/util/meson.build index 6386d945a22..5e6766fc8ad 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@

[Mesa-dev] [PATCH v3 42/48] tests/vma: fix build with MSVC

--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++

[Mesa-dev] [PATCH v3 26/48] meson: don't look for rt on windows

--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c8a66942cff..39b542730a9 100644 --- a/meson.build +++ b/meson.build @@ -1101,7 +1101,9 @@ elif with_dri_i965 and get_option('shader-cache') endif # Determine whether or not

[Mesa-dev] [PATCH v3 23/48] meson: Add support for wrapping llvm

For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for

[Mesa-dev] [PATCH v3 03/48] meson: add a zlib subproject

To help windows build --- meson.build | 2 +- subprojects/zlib.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/zlib.wrap diff --git a/meson.build b/meson.build index cbaee5ceb22..6960db9e9de 100644 --- a/meson.build +++

[Mesa-dev] [PATCH v3 20/48] meson: build graw-gdi target

--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v3 29/48] meson: for incluse of inttypes.h for glcpp with msvc

Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index

[Mesa-dev] [PATCH v3 36/48] glsl/tests: define ssize_t on windows

--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@

[Mesa-dev] [PATCH v3 39/48] meson: Fix gtest linkage on msvc

We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 ---

[Mesa-dev] [PATCH v3 31/48] meson: add switches for SWR with MSVC

--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++

[Mesa-dev] [PATCH v3 13/48] meson: add windows compiler checks and libraries

--- meson.build | 129 1 file changed, 79 insertions(+), 50 deletions(-) diff --git a/meson.build b/meson.build index 25de31bfabd..4350e1af810 100644 --- a/meson.build +++ b/meson.build @@ -775,69 +775,96 @@ endif # TODO: this is very

[Mesa-dev] [PATCH v3 01/48] meson: always define libglapi

This allows the identifier to be used even if shared-glapi isn't build, which simplifies a bunch of things. --- src/mapi/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/meson.build b/src/mapi/meson.build index 798586bfb0c..0be80047e4d 100644 --- a/src/mapi/meson.build

[Mesa-dev] [PATCH v3 06/48] glapi: export glapi_destroy_multithread when building shared-glapi on windows

Which will allow meson to build a shared glapi build with mingw. --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a 100644 --- a/src/mapi/glapi/glapi.h +++

[Mesa-dev] [PATCH v3 44/48] meson: Use python module to find python2 on windows

Signed-off-by: Eric Engestrom Reviewed-by: Dylan Baker --- meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 100d12f475d..bbfd7c3c73f 100644 --- a/meson.build +++ b/meson.build @@ -710,7 +710,15 @@ if with_platform_haiku

[Mesa-dev] [PATCH v3 21/48] meson: fix gallium-osmesa to build for windows

v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v3 04/48] meson: add a expat subproject

--- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index 6960db9e9de..c7dd5ddfec6 100644 --- a/meson.build +++ b/meson.build @@ -1064,7

[Mesa-dev] [PATCH v3 00/48] Meson for windows

Mostly this is the same thing as before, just rebased on master. A couple of the patches from v2 have already landed. I've also fix the bad rebase of Erik's patch to use the python module for finding python, and updated the appveyor instance to work, and use msbuild instead of ninja. Dylan Baker

[Mesa-dev] [PATCH v3 37/48] meson: Set visibility and compat args for graw

--- src/gallium/targets/graw-gdi/meson.build | 1 + src/gallium/targets/graw-null/meson.build | 2 ++ src/gallium/targets/graw-xlib/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/targets/graw-gdi/meson.build b/src/gallium/targets/graw-gdi/meson.build index

[Mesa-dev] [PATCH v3 35/48] meson: Don't build glsl cache_test for windows

v2: - Use new with_shader_cache variable instead of host_machine.system() == 'windows' --- src/compiler/glsl/tests/meson.build | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build

[Mesa-dev] [PATCH v3 24/48] util/xmlconfig: include strndup.h for windows

--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index ba657294c1c..e204e52b71d 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -36,6 +36,7 @@ #include #include #include +#include "strndup.h" #include

[Mesa-dev] [PATCH v3 46/48] appveyor: Add support for meson as well as scons

--- appveyor.yml | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 86440f0d76a..26f50ce2596 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -42,20 +42,29 @@ os: Visual Studio 2015 environment:

[Mesa-dev] [PATCH v3 30/48] meson: disable sse4.1 optimizations with msvc

There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v3 07/48] glsl: fix general_ir_test with mingw

Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/tests/general_ir_test.cpp

[Mesa-dev] [PATCH v3 27/48] meson: Add support for using win_flex and win_bison on windows

--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 39b542730a9..b7d277b7bc0 100644 --- a/meson.build +++ b/meson.build @@ -1329,8 +1329,31 @@ endif # pthread stubs. Lets not and say we didn't

[Mesa-dev] [PATCH v3 48/48] use msbuild instead of ninja

I think that most windows users probably find using msbuild more interesting than ninja, even if ninja is faster. I've left the ninja build in case someone wants to look at it. --- appveyor.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/appveyor.yml b/appveyor.yml

[Mesa-dev] [PATCH v3 25/48] meson: fix pipe-loader compilation for windows

v2: - Add missing D to pound define - Simply define the variable rather than set it to 1 (mirrors android.mk not scons) --- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v3 33/48] meson: Add idep_getopt for tests

There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH v3 45/48] meson: Add linker arguments for windows

--- meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/meson.build b/meson.build index bbfd7c3c73f..594d3f804fc 100644 --- a/meson.build +++ b/meson.build @@ -887,6 +887,27 @@ else endforeach endif +# set linker arguments +if host_machine.system() ==

[Mesa-dev] [PATCH v3 11/48] meson: don't build glx or dri by default on windows

--- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 37c07eaa581..75f7f1c672d 100644 --- a/meson.build +++ b/meson.build @@ -264,8 +264,12 @@ if with_glx == 'auto' elif with_platform_haiku with_glx = 'disabled' elif

[Mesa-dev] [PATCH v3 17/48] meson: build gallium gdi winsys

--- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build b/src/gallium/meson.build index

[Mesa-dev] [PATCH v3 12/48] meson: don't allow glvnd on windows

--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 75f7f1c672d..25de31bfabd 100644 --- a/meson.build +++ b/meson.build @@ -356,7 +356,9 @@ endif with_glvnd = get_option('glvnd') if with_glvnd - if with_glx == 'xlib' or

[Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

--- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index c7dd5ddfec6..788021c05e9 100644 --- a/meson.build +++ b/meson.build @@ -1027,9 +1027,9 @@ endif if cc.has_function('dlopen') dep_dl = null_dep else - dep_dl =

[Mesa-dev] [PATCH v3 38/48] meson: don't build gallium trivial tests on windows

They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 ---

[Mesa-dev] [PATCH v3 43/48] meson: maintain names of shared API libraries

Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) --- meson.build | 16 +--- meson_options.txt | 5 +++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH v3 34/48] util/tests: Use define instead of VLA

To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++-

Re: [Mesa-dev] [PATCH 16/26] python: Explicitly use lists

Quoting Mathieu Bridon (2018-07-06 02:43:46) > On Thu, 2018-07-05 at 09:31 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:47) > > > On Python 2, the builtin functions filter() and zip() would return > > > lists. > > > >

Re: [Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

e content of the patch. > > Marek > > On Mon, Aug 6, 2018 at 8:50 PM, Dylan Baker wrote: > > By including the proper headers for getpid and for mkdir. > > > > Signed-off-by: Dylan Baker > > Reviewed-by: Marek Olšák > > --- > > src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

Quoting Mathieu Bridon (2018-07-06 02:34:56) > On Thu, 2018-07-05 at 09:14 -0700, Dylan Baker wrote: > > Does it make more sense to encode, or to use io.open and open the > > file in text mode? I've gone back and forth on this myself several > > times. > > Same here, bo

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >

Re: [Mesa-dev] [PATCH v3 10/26] python: Use explicit integer divisions

Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-25 02:53:54) > In Python 2, divisions of integers return an integer: > > >>> 32 / 4 > 8 > > In Python 3 though, they return floats: > > >>> 32 / 4 > 8.0 > > However,

Re: [Mesa-dev] [PATCH 12/26] python: Fix unequality comparisons

Quoting Mathieu Bridon (2018-07-06 02:25:53) > On Thu, 2018-07-05 at 09:10 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:43) > > > +def __ne__(self, other): > > > +return not self.__eq__(other) > > > > This can be

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:46) > We're trying to write a unicode string (i.e decoded) to a file opened > in binary (i.e encoded) mode. > > In Python 2 this works, because of the automatic conversion between > byte and unicode strings. &

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

Quoting Emil Velikov (2018-08-07 08:41:36) > On 6 August 2018 at 17:39, Dylan Baker wrote: > > Quoting Emil Velikov (2018-06-28 07:35:44) > >> From: Emil Velikov > >> > >> Helps when the native wayland-scanner is located outside of PATH. > >> Inspire

Re: [Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-17 13:57:39) > Python 3 doesn't call objects __cmp__() methods any more to compare > them. Instead, it requires implementing the rich comparison methods > explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() a

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

Quoting Eric Engestrom (2018-08-08 03:46:05) > On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > > > anv_extensions_c = custom_target( > > > @@ -36,10 +37,11 @@ anv_extensio

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

Quoting Emil Velikov (2018-08-08 04:04:51) > On 8 August 2018 at 06:42, Marek Olšák wrote: > > From: Marek Olšák > > > > This is needed for exposing the samplerBuffer functions under > > EXT_gpu_shader4. > > > > glTexBufferEXT is defined in glapi, but "make check" fails. > > What am I doing

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

This probably should have a Fixes tag? Quoting Alejandro Piñeiro (2018-08-13 07:50:38) > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > CC: > --- > src/amd/vulkan/Android.mk | 2 ++ > src/amd/vulkan/Makefile.am | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk > index cee3744f40b..51b03561fa7 100644

[Mesa-dev] [PATCH v2 2/5] meson: use python3 module to find python3

This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build

[Mesa-dev] [PATCH v2 1/5] meson: Ensure that mako is >= 0.8.0

It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif

[Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

v2: - Use distutils to do the version checking Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 659da72c1c3..aa7201a9715 100755 --- a/scons/gallium.py

[Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac

[Mesa-dev] [PATCH v2 4/5] scons: Require python 2.7

less than 2.7 is not supported. v2: - Remove check for python >= 2.0, since we've already enforced 2.7 --- SConstruct | 1 + scons/gallium.py | 4 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

Quoting Bas Nieuwenhuizen (2018-08-15 09:34:41) > On Wed, Aug 15, 2018 at 6:08 PM, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > >> CC: > >> --- > >> src/amd/vulkan/Android.mk | 2 ++ > >> src/amd/vulkan/Makefile.am | 2

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

Quoting Emil Velikov (2018-08-14 03:00:45) > On 8 August 2018 at 15:36, Juan A. Suarez Romero wrote: > > Like in the autotools target, make the list of drivers to be built in > > each of the Meson targets explicit. > > > > This will help to identify missing dependencies and other issues more > >

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

I don't think this will be picked up by the stable spotting scripts, does it need a Fixes: tag? Dylan Quoting Jason Ekstrand (2018-08-08 12:05:00) > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we can really enable this > sort of

Re: [Mesa-dev] [PATCH mesa] travis: install correct version of mako for each build system

Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-13 04:15:06) > Meson now uses python3, so let's add a block for Autotools, move that > line into the buildsys-specific blocks, and set the correct version for > Meson. > > Fixes: 2ee1c86d71bee5ddca2c "meson: Build wit

[Mesa-dev] [PATCH 2/5] meson: use python3 module to find python3

This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build

[Mesa-dev] [PATCH 1/5] meson: Ensure that mako is >= 0.8.0

It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif

[Mesa-dev] [PATCH 4/5] scons: Require python 2.7

less than 2.7 is not supported. --- SConstruct | 1 + 1 file changed, 1 insertion(+) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 --- a/SConstruct +++ b/SConstruct @@ -31,6 +31,7 @@ import common # Minimal scons version EnsureSConsVersion(2, 4)

[Mesa-dev] [PATCH 3/5] configure: Enforce python 2.7.x

We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac

[Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 92a762a0c1e..e05fb40f157 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -29,6 +29,7 @@

Re: [Mesa-dev] [PATCH mesa 1/3] bin: split `write_if_different()` out

Quoting Eric Engestrom (2018-08-14 10:24:11) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py > index 68a87e72ec563ce6298f..bc0279ccef16d42bb88d

Re: [Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

With the one nit, patches 1 and 3 are: Reviewed-by: Dylan Baker I'm not confident on patch 2 to give you an rb. Quoting Eric Engestrom (2018-08-14 10:24:13) > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

Quoting Jose Fonseca (2018-08-14 11:30:48) > On 14/08/18 18:34, Dylan Baker wrote: > > Bugzilla: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107565data=02%7C01%7Cjfonseca%40vmware.com%7C2d939ac68f9948737

Re: [Mesa-dev] [PATCH 2/2] configure: use distutils in ax_check_python_mako_module

Quoting Emil Velikov (2018-08-16 09:18:57) > From: Emil Velikov > > Handling the version comparison by hand is a bad idea. Python has a handy > module distutils for that - use it. > > Cc: Dylan Baker > Signed-off-by: Emil Velikov > --- > Not entirely sure if Loo

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

across the > > different OS. > > > > Use the handy AM_PATH_PYTHON which finds the correct name and checks for > > the version. > > > > Note: python2.7 has been an unofficial requirement for quite some time. > > Update the docs to reflect that. > > >

[Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

--- I didn't see any patches from anyone else, so I wrote some real quick. Please point to them if other patches already exist. src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6 -- src/compiler/glsl/tests/sexps.py | 9

[Mesa-dev] [PATCH 2/2] meson: Use python3 to run glsl tests

--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

<    10   11   12   13   14   15   16   17   18   19   >