[Mesa-dev] [PATCH 0/8] More state optimizations for st/mesa

Hi Marek This series of patches is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Tested following programs on AMD CYPRESS (HD 5850) - The Talos Principle - OpenMW - Uningine Heaven - Two Worlds - Dota 2 No issues and no regressions found. Thanks e

Re: [Mesa-dev] [PATCH 1/3] radeonsi: don't invoke DCC decompression in update_all_texture_descriptors

This patch fixes the bug uncovered. Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Mon, Jan 30, 2017 at 1:33 AM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > This fixes a bug uncovered

Re: [Mesa-dev] [PATCH 01/17] radeonsi: remove si_shader_context::param_tess_offchip

For the series: Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Tested with: * The Witcher 2 * Talos Principle * Shadow Tactics * Wasteland 2 * X3: AP * Pillars of Eternity * Uningine Heaven & Valley Thanks edmondo On Thu, Jan 26, 2017 at 5:04 PM, Marek Olšák <mar

Re: [Mesa-dev] [PATCH 10/10] gallium/radeon: remove the internal u_upload_mgr pointer

For the series: Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> The Talos Principle benchmark seems to be about 0.5% faster. Thanks edmondo On Fri, Jan 27, 2017 at 12:02 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> >

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

This series is Reviewed-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Tue, Feb 14, 2017 at 4:18 PM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > Mesa currently doesn't allow to create 3.1+ compatibility profiles > mainly because various features

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

On Feb 14, 2017 11:50 AM, "Marek Olšák" wrote: On Feb 14, 2017 4:11 AM, "Michel Dänzer" wrote: On 14/02/17 09:28 AM, Samuel Pitoiset wrote: > On 02/13/2017 11:43 PM, Marek Olšák wrote: >> On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák

Re: [Mesa-dev] [PATCH 6/7] gallium/hud: create files after graphs are created to get final names

Thanks for the patch, it looks good. Reviewed-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> On Thu, Feb 16, 2017 at 1:52 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > --- > src/gallium/auxilia

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Hi Marek Series is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> I've merged your series of patches on top of mesa git master and tested on a Radeon RX 470. No regressions found. OpenGL renderer string: Gallium 0.4 on AMD POLARIS10 (DRM 3.3.0 / 4.8.0-rc6, LLVM 3.9.0) OpenG

[Mesa-dev] [PATCH] st/mesa: fix sRGB blit errors

Hi Nicolai Patch is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

Reviewed-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> On Mon, Oct 10, 2016 at 1:25 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH] radeonsi: eliminate trivial constant VS outputs

Hi Marek Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> I tested the patch with Witcher 2. Thanks edmondo On Tue, Oct 18, 2016 at 6:28 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > These constant value VS

Re: [Mesa-dev] [PATCH 00/20] RadeonSI: Optimized shader variants and other improvements

Hi Marek This patch series is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> The performance of The Talos Principle benchmark has increased a bit on my configuration (RX 470). I repeated the test about 8 times and it was always better with your patches. Before: 36.5 FPS After

Re: [Mesa-dev] [PATCH] radeonsi: implement TC-compatible HTILE

Hi Marek This and the patch before are Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Tested with: * The Witcher 2 * Two Worlds * The Talos Principle No regressions. Performance seems similar. I'm quite CPU limited (Phenom II X3 720) so I don't expect a measurable perfo

[Mesa-dev] [PATCH] gallium/hud: add a path separator between dump directory and filename

It's more user friendly and it avoids to write files in unexpected places. --- src/gallium/auxiliary/hud/hud_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 779c116..cccdb26

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add a workaround for the Witcher 2 black transitions

Hi Marek This series is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> The black transitions in Witcher 2 are fixed for me. Thanks edmondo On Tue, Jan 3, 2017 at 8:17 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> &

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

Could be a patch like this useful for power users? Load custom drirc only when specified in env variable. Patch untested, not even compiled. edmondo (on mobile phone) diff --git a/docs/envvars.html b/docs/envvars.html index cf57ca5..a404ced 100644 --- a/docs/envvars.html +++

[Mesa-dev] [PATCH] mesa: load custom drirc only when specified in env variable

Define a new MESA_CUSTOM_DRIRC environment variable to load a drirc custom file, instead of blindly using the hardcoded ${HOME}/.drirc file created the driconf tool. Some more discussion about the driconf issues can be found in reading following mesa-dev thread:

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

On Mon, Jan 9, 2017 at 12:37 PM, Marek Olšák <mar...@gmail.com> wrote: > On Mon, Jan 9, 2017 at 12:16 PM, Edmondo Tommasina > <edmondo.tommas...@gmail.com> wrote: >> Could be a patch like this useful for power users? >> >> Load custom drirc only when specified i

[Mesa-dev] [PATCH 2/6] gallium/hud: add dump directory enviroment variable

Set GALLIUM_HUD_DUMP_DIR to dump values to files in this directory. No values are dumped if the environment variable is not set, the directory doesn't exist or the user doesn't have write access. --- src/gallium/auxiliary/hud/hud_driver_query.c | 12 +++- 1 file changed, 11

[Mesa-dev] [RFC 0/6] gallium/hud: write displayed graph values into files

Introduce a new envvar (GALLIUM_HUD_DUMP_DIR) to write the displayed hud values into files. For example: GALLIUM_HUD_DUMP_DIR="/tmp/" GALLIUM_HUD="fps,cpu+GPU-load" glxgears In the /tmp directory it will create 3 files (fps, cpu and GPU-load) with all the values inside.

[Mesa-dev] [PATCH 4/6] gallium/hud: set filedescriptor for cpu graph

--- src/gallium/auxiliary/hud/hud_cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/auxiliary/hud/hud_cpu.c index c06e777..c65444e 100644 --- a/src/gallium/auxiliary/hud/hud_cpu.c +++ b/src/gallium/auxiliary/hud/hud_cpu.c @@ -213,6

[Mesa-dev] [PATCH 6/6] docs: document GALLIUM_HUD_DUMP_DIR envvar

--- docs/envvars.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 5dd7bab..9eee8db 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -219,6 +219,8 @@ Mesa EGL supports different sets of environment variables. See the disable for

[Mesa-dev] [PATCH 5/6] gallium/hud: set filedescriptor for fps graph

--- src/gallium/auxiliary/hud/hud_fps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_fps.c b/src/gallium/auxiliary/hud/hud_fps.c index a360bc2..ddf30e4 100644 --- a/src/gallium/auxiliary/hud/hud_fps.c +++ b/src/gallium/auxiliary/hud/hud_fps.c @@ -88,5 +88,7

[Mesa-dev] [PATCH 1/6] gallium/hud: dump hud_driver_query values to files

Dump values for every selected data source in GALLIUM_HUD. Every data source has its own file and the filename is equal to the data source identifier. --- src/gallium/auxiliary/hud/hud_context.c | 6 ++ src/gallium/auxiliary/hud/hud_driver_query.c | 2 ++

[Mesa-dev] [PATCH 3/6] gallium/hud: move file initialization to a function

The function will be used later to create the filedescriptor for other metrics. --- src/gallium/auxiliary/hud/hud_context.c | 17 + src/gallium/auxiliary/hud/hud_driver_query.c | 12 +--- src/gallium/auxiliary/hud/hud_private.h | 2 ++ 3 files changed, 20

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

On Mon, Mar 27, 2017 at 9:23 AM, Gustaw Smolarczyk <wielkie...@gmail.com> wrote: > 26 mar 2017 22:32 "Edmondo Tommasina" <edmondo.tommas...@gmail.com> > napisał(a): > > Define a new MESA_USER_DRIRC environment variable to load a customized > drirc file.

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

On Mon, Mar 27, 2017 at 6:05 PM, Eric Anholt <e...@anholt.net> wrote: > Edmondo Tommasina <edmondo.tommas...@gmail.com> writes: > >> Define a new MESA_USER_DRIRC environment variable to load a customized >> drirc file. >> >> When the variable is not defin

[Mesa-dev] [PATCH v2 2/2] mesa: load a user defined drirc file specified via an environment variable

Introduce a new MESA_USER_DRIRC environment variable to load a customized drirc file. This can be used mostly for two things: 1. Force the load of a different user drirc configuration for an application without touching/creating a user global ${HOME}/.drirc file or passing their values

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

On Tue, Mar 28, 2017 at 9:31 PM, Eric Anholt <e...@anholt.net> wrote: > Edmondo Tommasina <edmondo.tommas...@gmail.com> writes: > >> On Mon, Mar 27, 2017 at 11:32 PM, Eric Anholt <e...@anholt.net> wrote: >>> Edmondo Tommasina <edmondo.tommas...@gmail.com&g

[Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

Define a new MESA_USER_DRIRC environment variable to load a customized drirc file. When the variable is not defined, nothing changes and the ${HOME}/.drirc file will be loaded. If the variable is set to a file, this file will be loaded instead of the the ${HOME}/.drirc. Example:

[Mesa-dev] [PATCH 1/2] mesa: print a notice when loading a user defined drirc file

... and avoid the load of ~/.drirc to go unnoticed. --- src/mesa/drivers/dri/common/xmlconfig.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c index d4649370ee..fef007996e 100644 ---

Re: [Mesa-dev] [PATCH 0/9] RadeonSI cleanups

This series is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> On Wed, Mar 29, 2017 at 7:58 PM, Marek Olšák <mar...@gmail.com> wrote: > General cleanups and cleanups in preparation for threaded gallium. > > Please review

Re: [Mesa-dev] [PATCH] [RFC v3] mesa/glthread: Call unmarshal_batch directly in glthread_finish

This patch helps against the massive performance drop of glthread with Two Worlds. The performance boost in Civ5 is not hurt by this patch. It looks good. Some trivial comments in the patch: On Wed, Mar 29, 2017 at 7:35 PM, Bartosz Tomczyk wrote: > I would be very

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

On Mon, Mar 27, 2017 at 11:32 PM, Eric Anholt <e...@anholt.net> wrote: > Edmondo Tommasina <edmondo.tommas...@gmail.com> writes: > >> On Mon, Mar 27, 2017 at 6:05 PM, Eric Anholt <e...@anholt.net> wrote: >>> Edmondo Tommasina <edmondo.tommas..

Re: [Mesa-dev] Empty files when dumping hud values selected with GALLIUM_HUD

vmpipe glxgears > > Cheers. > Julien > > On 4 April 2017 at 11:29, Edmondo Tommasina <edmondo.tommas...@gmail.com> > wrote: >> >> >> >> On Apr 4, 2017 11:26, "Julien Isorce" <julien.iso...@gmail.com> wrote: >> >> Hi, >> >>

[Mesa-dev] [PATCH] gallium/hud: set the dump file streams to line buffered

Flush the HUD value streams to the dump files after every newline. --- src/gallium/auxiliary/hud/hud_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 29ef9eee31..633e3650cc 100644 ---

Re: [Mesa-dev] Empty files when dumping hud values selected with GALLIUM_HUD

On Apr 4, 2017 11:26, "Julien Isorce" wrote: Hi, I noticed that GALLIUM_HUD does not write hud values into files properly. The destination files look empty at least for 5 min and then are filed in with some burst. I wonder if it could be a problem with the

Re: [Mesa-dev] [PATCH] gallium/hud: set the dump file streams to line buffered

On Wed, Apr 5, 2017 at 12:29 AM, Julien Isorce wrote: > I confirm it works, awesome! Thx! > Should you check that fopen succeeded ? because I think setvbuf would crash > otherwise. You are right. Thanks for the hint V2 coming after some testing. > That's said: >

[Mesa-dev] [PATCH v2] gallium/hud: set the dump file streams to line buffered

Flush the HUD value streams to the dump files after every newline. v2: check that fopen succeeded (Julien) Tested-by: Julien Isorce --- src/gallium/auxiliary/hud/hud_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH] drirc: whitelist glthread for Civilization 5

Performance delta on AMD Phenom II X3 720 Civilization 5: +28% --- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 69b735ce70..418e159e81 100644 ---

[Mesa-dev] [PATCH] drirc: whitelist glthread for The Witcher 2

Performance delta on AMD Phenom II X3 720 / RX 470 The Witcher 2: +18% --- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 69b735ce70..3108451090 100644 ---

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Tue, Jul 25, 2017 at 6:32 PM, Marek Olšák <mar...@gmail.com> wrote: > This will also go to stable. > > Marek > > On Tue, Jul 25, 2017 at 5:39 PM, Marek Olšák <mar...@gmail.com> wrot

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

Hi Marek I've also tested this series with nine and STALKER: CoC. Sadly it segfaults. Bisected to this patch: "gallium: remove pipe_index_buffer and set_index_buffer" edmondo On Sat, Apr 29, 2017 at 1:12 AM, Marek Olšák wrote: > Hi, > > This series shrinks various gallium

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix the DCE pass in presence of loops

The issue in Uningine Heaven is fixed. Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Tue, May 2, 2017 at 4:43 PM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > The TGSI DCE pass doesn't eliminate dead assignments like > MOV TEMP[0], T

[Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

This fixes the long-standing problem with black transitions in The Wicher 2. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238 --- This patch depends on Marek's series: https://patchwork.freedesktop.org/series/26089/

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Hi Marek In patch 5 you say the words KILL and WQM and I automatically think at Witcher 2. This series with a the drirc option set for Witcher 2 fixes the longstanding black transition bug. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238 It's quite probable that VP will not update

Re: [Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

The crash with STALKER: CoC is fixed with this patch. Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Mon, May 22, 2017 at 12:22 AM, Axel Davy <axel.d...@ens.fr> wrote: > A few cleanups and in particular initializing properly > the new pip

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move PSIZE and CLIPDIST unique IO indices after GENERIC

It improves Uningine Heaven performance here (RX 470). Before: 47.5 After: 47.7 For this series: Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Thanks edmondo On Sat, Jun 3, 2017 at 6:04 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@a

Re: [Mesa-dev] [PATCH 00/17] st/mesa cleanup

This series (on top to the other series) is Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> Tested on Radeon RX 470: * The Witcher 2 * Two Worlds * Uningine Heaven/Valley/Superposition * Civilization 5 * Wasteland 2 * The Talos Principle (OpenGL) Thanks edmondo On Mon, May 1

Re: [Mesa-dev] [PATCH] radv: Don't emit a warning on VI-GFX9.

Congratulations! Tested-by: Edmondo Tommasina <edmondo.tommas...@gmail.com> On Wed, Mar 7, 2018 at 4:42 PM, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > We are conformant: > > https://www.khronos.org/conformance/adopters/conformant-products#submission_308 >

Re: [Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

> Marek > > On Mon, Nov 12, 2018 at 4:31 PM Edmondo Tommasina < > edmondo.tommas...@gmail.com> wrote: > >> On Mon, Nov 12, 2018 at 6:43 PM Michel Dänzer wrote: >> >>> On 2018-11-08 6:23 a.m., Marek Olšák wrote: >>> > Thanks a lot man. I'll recons

Re: [Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

Hi Marek It would be nice to have the driconf part of this patch committed in master to make it easy to test with and without the L3 pinning, so this patch is: Reviewed-by: Edmondo Tommasina Now with this patch in place I'm starting to collect some numbers with and without the CCX affinity

Re: [Mesa-dev] [PATCH] st/mesa: disable L3 thread pinning

Patch is: Reviewed-by: Edmondo Tommasina On Mon, Nov 12, 2018 at 9:45 PM Marek Olšák wrote: > From: Marek Olšák > > This implementation can have massive drawbacks. > > Cc: 18.3 > --- > src/mesa/state_tracker/st_manager.c | 9 - > 1 file changed, 9 deletions

Re: [Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

On Mon, Nov 12, 2018 at 6:43 PM Michel Dänzer wrote: > On 2018-11-08 6:23 a.m., Marek Olšák wrote: > > Thanks a lot man. I'll reconsider this depending on the results I > receive. > > > > I may also just pin the Mesa threads and keep the app thread intact. It > > should perform OK with glthread,