[Mesa-dev] [PATCH 19/40] gallium: rename libpipe_loader to libpipe_loader_dynamic

2015-10-17 Thread Emil Velikov
With the next commits we'll introduce a 'static' version, which will essentially load the statically linked-in pipe-drivers, rather than the standalone pipe-$foo.so ones. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/Makefile.am | 8 src/gallium/targ

[Mesa-dev] [PATCH 39/40] targets/nine: remove unused static functions

2015-10-17 Thread Emil Velikov
Dead code since commit 8f50614910c40366d94964fe2c5da5772aff2f96 Cc: Axel Davy Cc: Tiziano Bacocco Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/drm.c | 36 --- 1 file changed, 36 deletions(-) diff --git a/src/gallium/targets/d3dadapter9/drm.c

[Mesa-dev] [PATCH 37/40] targets/nine: add note about fd owndership

2015-10-17 Thread Emil Velikov
Cc: Axel Davy Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 1 + src/gallium/targets/d3dadapter9/drm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/gallium/targets/d3dadapter9/Makefile.am b/src/gallium/targets/d3dadapter9/Makefile.am index

[Mesa-dev] [PATCH 32/40] {st, targets}/nine: use static/dynamic pipe-loader

2015-10-17 Thread Emil Velikov
Analogous to previous commits. Cc: Axel Davy Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 13 - src/gallium/targets/d3dadapter9/drm.c | 24 +++- 2 files changed, 7 insertions(+), 30 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 35/40] st/dri: NULL check the pscreen earlier

2015-10-17 Thread Emil Velikov
We delay the null check only to jump through hoops to work around that. Check early to make our lives easier. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/dri2.c | 22 -- src/gallium/state_trackers/dri/dri_screen.c | 5 - src/gallium

[Mesa-dev] [PATCH 40/40] util: use RTLD_LOCAL with util_dl_open()

2015-10-17 Thread Emil Velikov
Otherwise we risk things blowing up due to conflicting symbols. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/util/u_dl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_dl.c b/src/gallium/auxiliary/util/u_dl.c index aca435d..9b97d8d

[Mesa-dev] [PATCH 33/40] target-helpers: remove inline_drm_helper.h

2015-10-17 Thread Emil Velikov
As of earlier all the targets use the non inline version. Don't forget to remove the function prototypes/declarations. Signed-off-by: Emil Velikov --- .../auxiliary/target-helpers/inline_drm_helper.h | 339 - src/gallium/include/state_tracker/drm_driver.h | 6

[Mesa-dev] [PATCH 36/40] auxiliary/vl: Don't close the drm fd on failure

2015-10-17 Thread Emil Velikov
Ported from an identically named commit in st/xa commit 35cf3831d71770211f29da6608313dc1f6213d7b Author: Thomas Hellstrom Date: Thu Jul 3 02:07:36 2014 -0700 st/xa: Don't close the drm fd on failure v2 Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 2

[Mesa-dev] [PATCH 28/40] pipe-loader: add preliminary Android support

2015-10-17 Thread Emil Velikov
Add a 'static' pipe-loader build, which will be used with follow-up commits. Signed-off-by: Emil Velikov --- src/gallium/Android.mk | 1 + src/gallium/auxiliary/pipe-loader/Android.mk | 49 2 files changed, 50 insertions(+) create m

[Mesa-dev] [PATCH 27/40] pipe-loader: add preliminary scons support

2015-10-17 Thread Emil Velikov
Add a 'static' pipe-loader build, which will be used with follow-up commits. Signed-off-by: Emil Velikov --- src/gallium/SConscript| 1 + src/gallium/auxiliary/pipe-loader/Makefile.am | 2 ++ src/gallium/auxiliary/pipe-loader/SConsc

[Mesa-dev] [PATCH 20/40] pipe-loader: add a dummy 'static' pipe-loader

2015-10-17 Thread Emil Velikov
: Francisco Jerez Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/Makefile.am | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/pipe-loader/Makefile.am b/src/gallium/auxiliary/pipe-loader/Makefile.am index 974cf08

[Mesa-dev] [PATCH 15/40] pipe-loader: rework the sw backend

2015-10-17 Thread Emil Velikov
Move the winsys into the pipe-target, bla bla bla XXX: separate pipe-drivers are likely to be busted Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 94 +- src/gallium/include/state_tracker/sw_driver.h | 21 + src/gallium

[Mesa-dev] [PATCH 17/40] pipe-loader: annotate the ops as const data

2015-10-17 Thread Emil Velikov
Already defined as such in struct pipe_loader_device::ops. Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 4 ++-- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 4 ++-- 2 files changed, 4 insertions(+), 4

[Mesa-dev] [PATCH 21/40] pipe-loader: wire up the 'static' drm pipe-loader

2015-10-17 Thread Emil Velikov
XXX: More than happy to rename things - header/functions/etc. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/Makefile.am | 6 +- .../auxiliary/pipe-loader/pipe_loader_drm.c| 119 - .../auxiliary/target-helpers/drm_helper_public.h | 34

[Mesa-dev] [PATCH 29/40] {st, targets}/dri: use static/dynamic pipe-loader

2015-10-17 Thread Emil Velikov
XXX: configure knob ? Signed-off-by: Emil Velikov --- .../auxiliary/target-helpers/inline_drm_helper.h | 24 --- .../auxiliary/target-helpers/inline_sw_helper.h| 28 -- src/gallium/drivers/softpipe/Automake.inc | 3 --- src/gallium/state_tra

[Mesa-dev] [PATCH 31/40] {st, targets}/xa: use static/dynamic pipe-loader

2015-10-17 Thread Emil Velikov
Analogous to previous commits. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/xa/Makefile.am | 5 - src/gallium/state_trackers/xa/xa_tracker.c | 16 ++-- src/gallium/targets/xa/Makefile.am | 7 +-- src/gallium/targets/xa/target.c| 2 +- 4

[Mesa-dev] [PATCH 38/40] targets/nine: add note about messy header inclusion order

2015-10-17 Thread Emil Velikov
Cc: Axel Davy Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c index dc040dc..c9559b9 100644 --- a/src/gallium/targets/d3dadapter9/drm.c +++ b

[Mesa-dev] [PATCH 16/40] pipe-loader: teardown the winsys, if create_screen fails

2015-10-17 Thread Emil Velikov
i.e. plug some (hard to hit) memory leaks. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c b/src/gallium/auxiliary/pipe-loader

[Mesa-dev] [PATCH 34/40] st/dri: Don't close the drm fd on failure

2015-10-17 Thread Emil Velikov
Ported from an identically named commit in st/xa commit 35cf3831d71770211f29da6608313dc1f6213d7b Author: Thomas Hellstrom Date: Thu Jul 3 02:07:36 2014 -0700 st/xa: Don't close the drm fd on failure v2 Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/dri2.c | 4 ++

[Mesa-dev] [PATCH 26/40] pipe-loader: don't mix code and variable declarations

2015-10-17 Thread Emil Velikov
We cannot use this C99 feature here quite yet, as the code needs to be ok with MSVC prior to 2013. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe-loader

[Mesa-dev] [PATCH 30/40] {auxiliary, targets}/vl: use static/dynamic pipe-loader

2015-10-17 Thread Emil Velikov
Analogous to previous commit. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/Makefile.am| 6 -- src/gallium/auxiliary/vl/vl_winsys_dri.c | 8 src/gallium/targets/omx/Makefile.am | 7 +-- src/gallium/targets/omx/target.c | 2 +- src/gallium/targets/va

Re: [Mesa-dev] [PATCH 15/40] pipe-loader: rework the sw backend

2015-10-18 Thread Emil Velikov
On 17 October 2015 at 23:57, Emil Velikov wrote: > Move the winsys into the pipe-target, bla bla bla > > XXX: separate pipe-drivers are likely to be busted > The XXX: is a left over and the pipe-drivers should be fine. Upon a second thought this whole "keep the sw winsys+dri

Re: [Mesa-dev] [PATCH 37/40] targets/nine: add note about fd owndership

2015-10-18 Thread Emil Velikov
On 17 October 2015 at 23:58, Emil Velikov wrote: > Cc: Axel Davy > Signed-off-by: Emil Velikov > --- > src/gallium/targets/d3dadapter9/Makefile.am | 1 + > src/gallium/targets/d3dadapter9/drm.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/src/gal

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-18 Thread Emil Velikov
Hi Timothy, On 17 October 2015 at 23:19, Timothy Arceri wrote: > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e > > We don't care about the swizzle when building the name so just skip over it. > --- > > New piglit test: http://patchwork.freedesktop.org/patch/62111/ > > src/g

Re: [Mesa-dev] [RFC 1/2] gallium: add renderonly driver

2015-10-19 Thread Emil Velikov
Hi Lucas, Pardon for jumping it like this. On 19 October 2015 at 10:25, Lucas Stach wrote: [snip] > This series implements a way to fuse multiple DRM devices into a single > EGL device, solely on the base that current EGL users expect that a > single device is able to render and scanout at the s

Re: [Mesa-dev] [PATCH] glsl: fix SSBO regression

2015-10-19 Thread Emil Velikov
On 18 October 2015 at 13:45, Timothy Arceri wrote: > On Sun, 2015-10-18 at 11:34 +0100, Emil Velikov wrote: >> Hi Timothy, >> >> On 17 October 2015 at 23:19, Timothy Arceri >> wrote: >> > Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e >&

Re: [Mesa-dev] [PATCH 1/2] i965: remove cache_aux_free_func array

2015-10-19 Thread Emil Velikov
Ping on these two trivial patches ? -Emil On 7 October 2015 at 12:38, Emil Velikov wrote: > There is only one function that can be called, which is well known at > compilation time. > > The abstraction used here seems unnecessary, so let's use a direct call > to brw_stage_p

Re: [Mesa-dev] [RFC] [PATCH 00/10] NIR header (C++ compilation) TLC

2015-10-19 Thread Emil Velikov
On 7 October 2015 at 11:11, Emil Velikov wrote: > Hi all, > > A while back we had a case where NIR had C99 initializers in its public > headers. That's not desired as ISO C++ does not allow them. > > So I took a quick look about wiring up a compilation test at 'ma

[Mesa-dev] [PATCH 7/7] i965: enable ARB_shader_clock on gen7+

2015-10-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- docs/relnotes/11.1.0.html| 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index dcf425e..3d948eb 100644 --- a/docs/relnotes/11.1.0

[Mesa-dev] [PATCH 0/7] ARB_shader_clock support

2015-10-19 Thread Emil Velikov
Hi all, This is a resent of the previous RFC series with a few minor changes - fs_reg:;smear() has been moved out of get_timestamp() - clock2x32ARB() has proper return value - the nir intrinsic no longer claims to have a variable I'm still rocking a SNB hardware so I did not really got the cha

[Mesa-dev] [PATCH 6/7] i965: Implement nir_intrinsic_shader_clock

2015-10-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 + src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++ 2 files changed, 19 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH 2/7] glsl: add ARB_shader_clock infrastructure

2015-10-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 1d7a3af..4acccf7 100644 --- a

[Mesa-dev] [PATCH 5/7] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-19 Thread Emil Velikov
We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. The in the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 3/7] glsl: add support for the clock2x32ARB function

2015-10-19 Thread Emil Velikov
v2: correctly set the return type Signed-off-by: Emil Velikov --- src/glsl/builtin_functions.cpp | 43 ++ 1 file changed, 43 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index aae25f8..509a57b 100644 --- a

[Mesa-dev] [PATCH 1/7] mesa: add infra for ARB_shader_clock

2015-10-19 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index b2c88c3..64972fa 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main

[Mesa-dev] [PATCH 4/7] nir: add shader_clock intrinsic

2015-10-19 Thread Emil Velikov
v2: Add flags and inline comment/description. v3: None of the input/outputs are variables Signed-off-by: Emil Velikov --- src/glsl/nir/glsl_to_nir.cpp | 6 ++ src/glsl/nir/nir_intrinsics.h | 8 2 files changed, 14 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: fix field picture type 0 poc disorder

2015-10-19 Thread Emil Velikov
On 19 October 2015 at 15:55, Liu, Leo wrote: > Ping... > FYI adding actual commit message does make reviewers happy. Then again, although it makes sense, I don't feel qualified to review this :( -Emil ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-19 Thread Emil Velikov
On 17 October 2015 at 00:14, Julien Isorce wrote: > Also add RGBA, RGBX and BGRX. > Also extend ChromaToPipe and implement PipeToYCbCr. > > Note that gstreamer-vaapi check all the VAImageFormat fields. > > Signed-off-by: Julien Isorce > --- > src/gallium/state_trackers/va/image.c | 10 +

Re: [Mesa-dev] [PATCH 4/7] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

2015-10-19 Thread Emil Velikov
On 17 October 2015 at 00:14, Julien Isorce wrote: > Inspired from > http://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_drv_video.c > Please mention the actual usecase here and/or how you've tested this. > Signed-off-by: Julien Isorce > --- > src/gallium/state_trackers/va/context.c

Re: [Mesa-dev] [PATCH 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

2015-10-19 Thread Emil Velikov
tbl; Did you actually experience the crash or did you notice this while browsing through ? Either way - abeit unlikely we can return NULL, so let's avoid the crash. Cc: "11.0" Reviewed-by: Emil Velikov Thanks Emil g ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH 3/7] st/va: in VaPutImage only destroy previous buffer if pipe->create_video_buffer succeeds

2015-10-19 Thread Emil Velikov
fer_format = old_surf_format; > + return VA_STATUS_ERROR_ALLOCATION_FAILED; > + } > + >if (surf->buffer) Drop the if (unconditionally destroy the buffer). We're already checking it before we get here. With the above sorted Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-19 Thread Emil Velikov
On 17 October 2015 at 00:14, Julien Isorce wrote: > This patch allows to use gallium vaapi without requiring > a X server running for your second graphic card. > I've sent a lengthy series which should mitigate the need of some hunks. > Signed-off-by: Julien Isorce > --- > src/gallium/state_tra

Re: [Mesa-dev] [PATCH 5/7] st/va: implement dmabuf import for VaCreateSurfaces2

2015-10-19 Thread Emil Velikov
On 17 October 2015 at 00:14, Julien Isorce wrote: > For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. > > Signed-off-by: Julien Isorce > --- > src/gallium/state_trackers/va/surface.c| 90 > +- > src/gallium/state_trackers/va/va_private.h | 1 + > 2 files

Re: [Mesa-dev] [PATCH 6/7] st/va: add initial Video Post Processing support

2015-10-19 Thread Emil Velikov
On 17 October 2015 at 00:14, Julien Isorce wrote: > Improve following functions to support VA_PROFILE_NONE profile (vpp): > vlVaQueryConfigProfiles > vlVaQueryConfigEntrypoints > vlVaCreateConfig > vlVaQueryConfigAttributes > > Add VADriverVTableVPP and improve following functions to support vpp:

Re: [Mesa-dev] [PATCH 6/7] st/va: add initial Video Post Processing support

2015-10-19 Thread Emil Velikov
On 19 October 2015 at 18:17, Ilia Mirkin wrote: > On Mon, Oct 19, 2015 at 1:10 PM, Emil Velikov > wrote: >> On 17 October 2015 at 00:14, Julien Isorce wrote: >>> if (!ctx) >>>return VA_STATUS_ERROR_INVALID_CONTEXT; >>> >>> - if (!(

[Mesa-dev] [PATCH v2 16/40] pipe-loader: teardown the winsys, if create_screen fails

2015-10-19 Thread Emil Velikov
i.e. plug some (hard to hit) memory leaks. v2: really teardown the winsys (it rebase fallout), per Brian. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe

Re: [Mesa-dev] [PATCH 15/40] pipe-loader: rework the sw backend

2015-10-19 Thread Emil Velikov
On 19 October 2015 at 17:03, Brian Paul wrote: > On 10/17/2015 04:57 PM, Emil Velikov wrote: >> >> Move the winsys into the pipe-target, bla bla bla >> >> XXX: separate pipe-drivers are likely to be busted >> >> Signed-off-by: Emil Velikov >&g

Re: [Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

2015-10-19 Thread Emil Velikov
On 19 October 2015 at 17:07, Brian Paul wrote: > On 10/17/2015 04:57 PM, Emil Velikov wrote: >> >> Hi all, >> >> Here goes a series (which is slightly overdue), that reworks the >> target-helpers into a pipe-loader like interface. As such the >> state-trac

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-20 Thread Emil Velikov
On 20 October 2015 at 17:06, Julien Isorce wrote: > > > On 19 October 2015 at 17:16, Emil Velikov wrote: >> >> On 17 October 2015 at 00:14, Julien Isorce >> wrote: >> > This patch allows to use gallium vaapi without requiring >> > a X server runni

[Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

2015-10-20 Thread Emil Velikov
v2: Add flags and inline comment/description. v3: None of the input/outputs are variables v4: Drop clockARB reference, relate code motion barrier comment wrt intrinsic flag. Signed-off-by: Emil Velikov --- Matt, Hopefully the updated comment makes more sense (the clockARB reference was an

[Mesa-dev] [PATCH 5/7] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-20 Thread Emil Velikov
We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. In the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. v2: Tweak the comment - The caller -> We (Matt, Connor). Signed-off-by: Emil

[Mesa-dev] [PATCHv2 6/7] i965: Implement nir_intrinsic_shader_clock

2015-10-20 Thread Emil Velikov
v2: - Add a few const qualifiers for good measure. - Drop unneeded retype()s (Matt) - Convert timestamp to SIMD8/16, as fs_visitor::get_timestamp() returns SIMD4 (Connor) Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 +++ src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 0/7] ARB_shader_clock support

2015-10-20 Thread Emil Velikov
On 19 October 2015 at 19:39, Matt Turner wrote: > On Mon, Oct 19, 2015 at 7:45 AM, Emil Velikov > wrote: >> Hi all, >> >> This is a resent of the previous RFC series with a few minor changes >> - fs_reg:;smear() has been moved out of get_timestamp() >> - cl

Re: [Mesa-dev] [PATCH] mesa/glformats: Undo code changes from _mesa_base_tex_format() move

2015-10-21 Thread Emil Velikov
hose modifications. > > v2. Actually include ASTC support again. > Thanks Nanley. I take it that with this in place the KHR_texture_compression_astc_ldr piglits/tests are back online (pass) ? I have double-checked and this patch does fix the erroneous reverts by c6bf1cd. Review

Re: [Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

2015-10-21 Thread Emil Velikov
On 20 October 2015 at 19:58, Connor Abbott wrote: > On Tue, Oct 20, 2015 at 12:55 PM, Emil Velikov > wrote: [snip] >> +/* >> + * Shader clock intrinsic with semantics analogous to the clock2x32ARB() >> + * GLSL intrinsic. >> + * The latter can be used as code moti

[Mesa-dev] [PATCHv5 4/7] nir: add shader_clock intrinsic

2015-10-21 Thread Emil Velikov
From: Emil Velikov v2: Add flags and inline comment/description. v3: None of the input/outputs are variables v4: Drop clockARB reference, relate code motion barrier comment wrt intrinsic flag. v5: Drop the "thus we can eliminate..." comment (Connor) Signed-off-by: Emil Velikov R

[Mesa-dev] [PATCHv3 5/7] i965/fs: move the fs_reg::smear() from

2015-10-21 Thread Emil Velikov
From: Emil Velikov We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. In the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. v2: Tweak the comment - The caller -> We (Matt, Con

[Mesa-dev] [PATCHv3 6/7] i965: Implement nir_intrinsic_shader_clock

2015-10-21 Thread Emil Velikov
From: Emil Velikov v2: - Add a few const qualifiers for good measure. - Drop unneeded retype()s (Matt) - Convert timestamp to SIMD8/16, as fs_visitor::get_timestamp() returns SIMD4 (Connor) v3: - Remove unneeded temporary + MOV (Connor) Signed-off-by: Emil Velikov Reviewed-by: Connor

[Mesa-dev] New stable-branch 11.0 candidate pushed

2015-10-21 Thread Emil Velikov
ild gallium DRI drivers if --disable-dri is set Emil Velikov (3): i965: store reference to the context within struct brw_fence egl/dri2: expose srgb configs when KHR_gl_colorspace is available mesa; add get-extra-pick-list.sh script into bin/ Ian Romanick (1): i965: Fix is-rend

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-21 Thread Emil Velikov
On 20 October 2015 at 05:08, Matt Turner wrote: > Otherwise we'd emit a MOV from the null register (which isn't allowed). > Would you say it's a good idea to push the check down to the MOV() implementation ? If not perhaps we should add an assert() to easily catch cases like these in the future ?

Re: [Mesa-dev] [PATCH 1/2] i965: remove cache_aux_free_func array

2015-10-21 Thread Emil Velikov
On 21 October 2015 at 21:33, Kenneth Graunke wrote: > On Monday, October 19, 2015 02:54:56 PM Emil Velikov wrote: >> Ping on these two trivial patches ? >> >> -Emil > > Oh, sorry, I thought I'd sent R-bs for these... > > Both are > Reviewed-by: Kennet

Re: [Mesa-dev] [PATCH 1/2] i965: remove cache_aux_free_func array

2015-10-22 Thread Emil Velikov
On 21 October 2015 at 22:44, Matt Turner wrote: > On Wed, Oct 21, 2015 at 2:16 PM, Emil Velikov > wrote: >> On 21 October 2015 at 21:33, Kenneth Graunke wrote: >>> On Monday, October 19, 2015 02:54:56 PM Emil Velikov wrote: >>>> Ping on these two trivial pat

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-22 Thread Emil Velikov
On 20 October 2015 at 16:43, Nanley Chery wrote: > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: >> >> Also, the FIXME comment should be on its own line. >> > > I moved it aside to make editing the table easier. However, since the > formatting of the > table is unlikely to change much after

Re: [Mesa-dev] [RFC 04/21] mesa/extensions: Move entries entries to seperate file

2015-10-22 Thread Emil Velikov
On 19 October 2015 at 23:36, Nanley Chery wrote: > From: Nanley Chery > > With this infrastructure set in place, we can now reuse the entries to > generate useful code. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 321 > +-- > s

Re: [Mesa-dev] [RFC 05/21] mesa/extensions: Add extension::version

2015-10-22 Thread Emil Velikov
On 19 October 2015 at 23:36, Nanley Chery wrote: > From: Nanley Chery > > Enable limiting advertised extension support by context version with > finer granularity. GLuint is chosen over smaller datatypes because, > when this field is eventually used, usage of this datatype provides > the smallest

Re: [Mesa-dev] [RFC 06/21] mesa/extensions: Create _mesa_extension_supported()

2015-10-22 Thread Emil Velikov
On 19 October 2015 at 23:36, Nanley Chery wrote: > From: Nanley Chery > > Create a function which determines if an extension is supported in the > current context. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 17 + > 1 file changed, 17 insertions(+) > > d

Re: [Mesa-dev] [RFC 10/21] mesa: Remove equality check in helper functions

2015-10-22 Thread Emil Velikov
On 22 October 2015 at 07:43, Erik Faye-Lund wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: >> From: Nanley Chery >> >> Since the version numbers being compared are integral and we don't ever >> expect gl_context::Version to be equal to 0, subtract 1 from the rhs of >> the equatio

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

2015-10-22 Thread Emil Velikov
On 19 October 2015 at 23:44, Nanley Chery wrote: > From: Nanley Chery > > Aside from those modified in this commit, all gl_extensions structs are > zero-initialized by default. There is therefore no need to memset the > structs to 0. Also, remove the open-coded memset in > _mesa_init_extensions()

Re: [Mesa-dev] [RFC 20/21] mesa: Remove gl_extensions::dummy

2015-10-22 Thread Emil Velikov
On 19 October 2015 at 23:44, Nanley Chery wrote: > From: Nanley Chery > > This variable existed to provide an unsigned error value for > name_to_offset(). Since o(extension_sentinel) is also a valid unsigned > error value, save space and replace this mysterious variable with > a less mysterious o

Re: [Mesa-dev] [PATCH 2/9] i965: Fill out instruction list.

2015-10-22 Thread Emil Velikov
On 21 October 2015 at 23:58, Matt Turner wrote: > Add some instructions: illegal, movi, sends, sendsc. > > Remove some instructions with reused opcodes: msave, mrestore, push, > pop, goto. I did have some gross code for disassembling opcodes > per-generation, but there's very little meaningful ove

Re: [Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-10-22 Thread Emil Velikov
On 21 October 2015 at 23:58, Matt Turner wrote: > Initially just checks that sources are non-NULL, which would have > alerted us to the problem fixed by commit 6c846dc5. What are the chances of combining this with and/or removing fs_visitor::validate() ? Afaict both of these validations are at di

Re: [Mesa-dev] [PATCH 21/40] pipe-loader: wire up the 'static' drm pipe-loader

2015-10-22 Thread Emil Velikov
On 22 October 2015 at 15:07, Nicolai Hähnle wrote: > On 18.10.2015 00:57, Emil Velikov wrote: >> >> Add a list of driver descriptors and select one from the list, during >> probe time. >> >> As we'll need to have all the driver pipe_foo_screen_create() funct

Re: [Mesa-dev] [PATCH 21/40] pipe-loader: wire up the 'static' drm pipe-loader

2015-10-22 Thread Emil Velikov
On 22 October 2015 at 16:32, Emil Velikov wrote: > On 22 October 2015 at 15:07, Nicolai Hähnle wrote: >> On 18.10.2015 00:57, Emil Velikov wrote: >>> >>> Add a list of driver descriptors and select one from the list, during >>> probe time. >>

Re: [Mesa-dev] [RFC 20/21] mesa: Remove gl_extensions::dummy

2015-10-23 Thread Emil Velikov
On 23 October 2015 at 00:34, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 3:40 AM, Emil Velikov > wrote: >> >> On 19 October 2015 at 23:44, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > This variable existed to provide an unsigned e

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-23 Thread Emil Velikov
On 22 October 2015 at 23:22, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov > wrote: >> >> That aside, I'm in favour of keeping the comments as is. The editing >> comment does not apply imho. >> > > Since, there isn't a unanim

[Mesa-dev] Mesa 11.0.4

2015-10-25 Thread Emil Velikov
possible nv30: include the header of ffs prototype Chris Wilson (1): i965: Remove early release of DRI2 miptree Dave Airlie (1): mesa/uniforms: fix get_uniform for doubles (v2) Emil Velikov (3): docs: add sha256 checksums for 11.0.3 Update version to 11.0.4

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

2015-10-26 Thread Emil Velikov
On 23 October 2015 at 19:46, Jordan Justen wrote: > On 2015-10-22 03:32:58, Emil Velikov wrote: >> On 19 October 2015 at 23:44, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Aside from those modified in this commit, all gl_extensions structs are >

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-10-27 Thread Emil Velikov
On 22 October 2015 at 00:16, Julien Isorce wrote: > The real fix is in nouveau_drm_winsys.c by setting dev to 0. > Which means dev's ownership has been passed to previous call. > Other changes are there to be consistent with what the > screen_create functions already do on errors. > > Encountered

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-10-27 Thread Emil Velikov
On 27 October 2015 at 10:50, samuel.pitoiset wrote: > On 27/10/2015 11:37, Emil Velikov wrote: >> >> On 22 October 2015 at 00:16, Julien Isorce >> wrote: >>> >>> The real fix is in nouveau_drm_winsys.c by setting dev to 0. >>> Which means

Re: [Mesa-dev] [PATCH] mesa: set the texture target in VDPAUMapSurfacesNV

2015-10-27 Thread Emil Velikov
king about the following but I'm sure you can think of something better. "With the said commit the initialization of the Target{,Index} was moved from glBindTexture to glTextureView. One does not need the latter for GL VDPAU interop thus things broke." With those Revi

Re: [Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

2015-10-29 Thread Emil Velikov
Hi Nanley, On 28 October 2015 at 21:50, Nanley Chery wrote: > From: Nanley Chery > > A prior, literal reading of the ASTC spec led to the prohibition > of some compressed formats being used against the targets: > TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Since the spec does not specify > interactio

[Mesa-dev] [PATCH 1/6] virgl: fix drm.h include path

2015-10-29 Thread Emil Velikov
From: Emil Velikov The drm/ prefix is required, if using the kernel provided headers. As most distros don't ship them it and we already depend on libdrm (which adds the relevant -I flag) just drop the drm/ from the include. Once a libdrm release with the virtgpu_drm.h header is released, w

[Mesa-dev] [PATCH 3/6] winsys/virgl/vtest: list all files in Makefile.sources

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/vtest/Makefile.sources | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/vtest/Makefile.sources b/src/gallium/winsys/virgl/vtest/Makefile.sources index ab72560..410763f 100644 --- a/src

[Mesa-dev] [PATCH 5/6] virgl: remove the _FILE_OFFSET_BITS defines

2015-10-29 Thread Emil Velikov
From: Emil Velikov The build already sets it as needed. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 3 --- src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c | 2 -- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 2 -- 3 files changed, 7

[Mesa-dev] [PATCH 0/6] virgl: trivial build fixes/cleanups

2015-10-29 Thread Emil Velikov
Hi all, Some mostly trivial fixes which I came across whist trying to build virgl. Build tested only. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/6] winsys/virgl/drm: add all files to the tarball

2015-10-29 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/Makefile.sources | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/drm/Makefile.sources b/src/gallium/winsys/virgl/drm/Makefile.sources index c0baed8..eca8eb6 100644

[Mesa-dev] [PATCH 6/6] virgl: straighten the includes confusion

2015-10-29 Thread Emil Velikov
From: Emil Velikov Use the relevant GALLIUM_foo_CFLAGS which has all the requirements (not to mention VISIBITY_CFLAGS) and keep ../ out of the include directives. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.am | 5 + src/gallium/drivers/virgl/virgl.h

[Mesa-dev] [PATCH 2/6] virgl: move sources list to Makefile.sources

2015-10-29 Thread Emil Velikov
From: Emil Velikov ... and add the missing files while we're at it. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.am | 12 ++-- src/gallium/drivers/virgl/Makefile.sources | 17 + 2 files changed, 19 insertions(+), 10 deletions(-) create

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

[Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
Hi all, A slightly longer series (that builds on top of the previous sent a minute ago), that moves/renames a couple of files, adds a few inline wrappers, 'includes what you want' and related fixes. As some of these can be seen as bikeshedding, although rest assured there is a method to the ma

Re: [Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 11:12, Emil Velikov wrote: > Hi all, > > A slightly longer series (that builds on top of the previous sent a > minute ago), that moves/renames a couple of files, adds a few inline > wrappers, 'includes what you want' and related fixes. > >

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 09:24, Ivan Kalvachev wrote: > On 10/29/15, Ilia Mirkin wrote: >> On Wed, Oct 28, 2015 at 8:52 PM, Ivan Kalvachev >> wrote: >>> I'm attaching v3 of the patch. Same as v2, but without the extra empty >>> line. >> >> FYI, there's a lot of overhead to reviewing an attached pat

[Mesa-dev] [PATCH 01/15] virgl: move virgl_hw.h into the driver dir

2015-10-29 Thread Emil Velikov
Strictly speaking virgl_hw.h should reside in the driver folder, as it describes the hardware. Moving it allows us to nuke the following strange dependency winsys/vtest > driver > winsys/drm Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources | 1 + src/g

[Mesa-dev] [PATCH 14/15] virgl: unwrap the includes

2015-10-29 Thread Emil Velikov
Include what you want, rather than relying on a header foo.h N levels down the include chain, to provide something that you need. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 ++ src/gallium/drivers/virgl/virgl_context.c | 7 ++- src

[Mesa-dev] [PATCH 02/15] virgl: rename virgl.h to virgl_screen.h

2015-10-29 Thread Emil Velikov
Provide a more meaningful name considering it's purpose. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources | 2 +- src/gallium/drivers/virgl/virgl.h | 51 -- src/gallium/drivers/virgl/virgl_context.c | 2 +- src/gallium/dr

[Mesa-dev] [PATCH 12/15] winsys/virgl: always memset prior to ioctl

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index 11542f5..d9b4d58 100644 --- a

[Mesa-dev] [PATCH 15/15] winsys/virgl: rework line wrapping/indent

2015-10-29 Thread Emil Velikov
Wrap some of the 'omg it's getting out of hand' long lines, and re-indent where things feel off. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c| 83 --- .../winsys/virgl/vtest/virgl_vtest_socket.c| 13 ++- .../win

[Mesa-dev] [PATCH 03/15] virgl: remove sw_winsys pointer from virgl_screen

2015-10-29 Thread Emil Velikov
The screen already has a pointer to the (base) winsys object. With the latter of which implemented/sub-classed as either drm or sw based one, depending on the target. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_public.h | 1 - src/gallium/drivers/virgl/virgl_screen.c | 1

[Mesa-dev] [PATCH 04/15] winsys/virgl/drm: drop unneeded forward declaration

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h index eac1d3e..a547654 100644 --- a/src/gallium/winsys/virgl/drm

<    1   2   3   4   5   6   7   8   9   10   >