[Mesa-dev] [PATCH 06/15] virgl: introduce and use virgl_transfer/texture/resource inline wrappers

2015-10-29 Thread Emil Velikov
The only two remaining cases of (struct virgl_resource *) require a closer look. Either the error checking is missing or the arguments provided feel wrong. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 +- src/gallium/drivers/virgl/virgl_context.c | 28

[Mesa-dev] [PATCH 09/15] winsys/virgl: throw in some inline wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 10 +- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 14 ++ src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 10 +- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.h

[Mesa-dev] [PATCH 11/15] winsys/virgl: use MALLOC to match FREE

2015-10-29 Thread Emil Velikov
The uppercase versions are wrappers which must be matched. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm

[Mesa-dev] [PATCH 13/15] winsys/virgl: remove temporary ret variable

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index d9b4d58..0616de3 100644 --- a

[Mesa-dev] [PATCH 10/15] winsys/virgl: remove calloc/malloc casts

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 5 ++--- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl

[Mesa-dev] [PATCH 07/15] virgl: use virgl_screen/surface upcast wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_context.c | 2 +- src/gallium/drivers/virgl/virgl_encode.c | 4 ++-- src/gallium/drivers/virgl/virgl_encode.h | 5 + src/gallium/drivers/virgl/virgl_resource.c | 4 ++-- src/gallium/drivers/virgl/virgl_screen.h | 2 +- 5

[Mesa-dev] [PATCH 05/15] virgl: add virgl_context/sampler_view/so_target() upcast wrappers

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 6 +- src/gallium/drivers/virgl/virgl_context.c | 98 ++--- src/gallium/drivers/virgl/virgl_context.h | 17 + src/gallium/drivers/virgl/virgl_encode.c| 2 +- src/gallium/drivers

[Mesa-dev] [PATCH 08/15] virgl: introduce virgl_query() inline wrapper

2015-10-29 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_query.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_query.c b/src/gallium/drivers/virgl/virgl_query.c index ea50f2f..b06635b 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Emil Velikov
Hi Emmanuel, On 29 October 2015 at 15:22, Emmanuel Gil Peyrot wrote: > This was causing compilation issues when one of its providers wasn’t > already included before gbm.h. Cc: "11.0" Reviewed-by: Emil Velikov I'll push this later on today. For future patches please in

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 17:15, Grazvydas Ignotas wrote: > Hi, > > On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov > wrote: >> On 29 October 2015 at 15:22, Emmanuel Gil Peyrot >> wrote: >>> This was causing compilation issues when one of its providers wasn’t >>

Re: [Mesa-dev] [PATCH v2 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-29 Thread Emil Velikov
On 20 October 2015 at 17:34, Julien Isorce wrote: > static inline enum pipe_video_chroma_format > ChromaToPipe(int format) > { > switch (format) { > + case VA_RT_FORMAT_YUV400: > + return PIPE_VIDEO_CHROMA_FORMAT_400; Intentional ? We're barely handling it so might as well not bothe

Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 17:40, Julien Isorce wrote: > + > +VAStatus > +vlVaCreateSurfaces2(VADriverContextP ctx, unsigned int format, > +unsigned int width, unsigned int height, > +VASurfaceID *surfaces, unsigned int num_surfaces, > +VASurf

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-29 Thread Emil Velikov
Hi Julien, One can separate the errors checks and get those separately (+stable). I'll let others be the judge of that - I'm just going to point the sections I have in mind. On 29 October 2015 at 17:40, Julien Isorce wrote: > @@ -73,6 +76,10 @@ vlVaBufferSetNumElements(VADriverContextP ctx, VAB

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-29 Thread Emil Velikov
wants to hack on something different it'll be fine :-P Although we should consider splitting out the non platform specifics out of vl_winsys_dri.c and perhaps fetching the xlib/xcb symbols via dlsym/dlopen. > Emil any further comments? With the VA_RT_FORMAT_YUV400 handling dropped, and th

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-29 Thread Emil Velikov
On 20 October 2015 at 17:40, Arnaud Vrac wrote: > On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov > wrote: >> >> On 20 October 2015 at 17:06, Julien Isorce >> wrote: >> > >> > >> > On 19 October 2015 at 17:16, Emil Velikov >> > w

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 23:04, Arnaud Vrac wrote: > On Thu, Oct 29, 2015 at 11:28 PM, Emil Velikov > wrote: >> >> On 20 October 2015 at 17:40, Arnaud Vrac wrote: >> > On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov >> > wrote: >> >> >> >

Re: [Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

2015-10-29 Thread Emil Velikov
On 29 October 2015 at 22:56, Nicolai Hähnle wrote: > On 29.10.2015 14:13, Marek Olšák wrote: >> >> On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle >> wrote: >>> >>> Without the clamping by NumLevels, the state tracker would reallocate the >>> texture storage (incorrect) and even fail to copy the

Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

2015-10-30 Thread Emil Velikov
On 30 October 2015 at 09:59, Julien Isorce wrote: > > > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: 29 October 2015 19:04 > To: Julien Isorce > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH v4 3/9] st/va: impleme

Re: [Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

2015-10-30 Thread Emil Velikov
On 29 October 2015 at 21:50, Dave Airlie wrote: > On 29 October 2015 at 21:12, Emil Velikov wrote: >> On 29 October 2015 at 11:12, Emil Velikov wrote: >>> Hi all, >>> >>> A slightly longer series (that builds on top of the previous sent a >>> minu

Re: [Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

2015-10-30 Thread Emil Velikov
On 19 October 2015 at 18:41, Emil Velikov wrote: > On 19 October 2015 at 17:07, Brian Paul wrote: >> >> I'm not too familiar with this code or these changes but I'm wondering how >> much of chance there is of this breaking any driver/target builds. >>

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-30 Thread Emil Velikov
On 30 October 2015 at 14:48, Daniel Stone wrote: > Hi Julien, > > On 30 October 2015 at 11:32, Julien Isorce wrote: >> Thx for pointing this out. Where are the files related to >> winsys/presentation :) ? > > The one you're changing. ;) > > src/gbm already has a great deal of infrastructure for h

[Mesa-dev] Unused (?) duplicated GLSL IR state in NIR

2015-11-02 Thread Emil Velikov
Hi all, From a quick look, it seems that NIR copies (almost ?) all the state from GLSL IR even if it doesn't use it. The particular piece that I'm thinking about is nir_variable::data. Afaict this is a remnant from the early days, when the intent was to kill off the GLSL IR and use NIR directly.

Re: [Mesa-dev] Unused (?) duplicated GLSL IR state in NIR

2015-11-03 Thread Emil Velikov
On 2 November 2015 at 19:41, Jason Ekstrand wrote: > On Mon, Nov 2, 2015 at 9:33 AM, Connor Abbott wrote: >> On Mon, Nov 2, 2015 at 8:35 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> From a quick look, it seems that NIR copies (almost ?) all the sta

Re: [Mesa-dev] [PATCH 04/24] i965: Make 'dw1' and 'bits' unnamed structures in brw_reg.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > Generated by > >sed -i -e 's/\.bits\././g' *.c *.h *.cpp >sed -i -e 's/dw1\.//g' *.c *.h *.cpp > > and then reverting changes to comments in gen7_blorp.cpp and > brw_fs_generator.cpp. > > There wasn't any utility offered by forcing the prog

Re: [Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > Put fields that are meaningless with an immediate in the same storage > with the immediate. There is something funky here. Should it be "Put fields that are meaningless _without_ an immediate in the same storage _as_ the immediate..." -Emil _

Re: [Mesa-dev] [PATCH 06/24] i965: Add and use enum brw_reg_file.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_defines.h| 10 ++ > src/mesa/drivers/dri/i965/brw_eu_emit.c| 2 +- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 +++-- > src/mesa/drivers/dri/i965/brw_reg.h| 25

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: Please add a bit of commit message - "Mostly unused as of last commit. Fold the remaining cases (GRF only?) to use the base brw_reg struct." or anything else that you feel is appropriate. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > The test (file == BAD_FILE) works on registers for which the constructor > has not run because BAD_FILE is zero. The next commit will move > BAD_FILE in the enum so that it's no longer zero. Doesn't the DECLARE_RALLOC_CXX_OPERATORS macro and fs_r

Re: [Mesa-dev] [PATCH 17/24] i965: Replace HW_REG with ARF/GRF.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > @@ -422,7 +423,7 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, > uint8_t vf3) > fs_reg::fs_reg(struct brw_reg reg) : > backend_reg(reg) > { > - this->file = HW_REG; > + this->file = (enum register_file)reg.file; You're not ad

Re: [Mesa-dev] [PATCH 18/24] i965: Combine register file field.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > index 6eeafd5..3d2b051 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > @@ -423,7 +423,6 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, > uint8_t vf3) > fs_reg::fs_reg(struct brw_reg re

Re: [Mesa-dev] [PATCH 20/24] Revert "i965: Have brw_imm_vf4() take the vector components as integer values."

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > This reverts commit bbf8239f92ecd79431dfa41402e1c85318e7267f. > > I didn't like that commit to begin with -- computing things at compile > time is fine -- but for purposes of verifying that the resulting values > are correct, looking up 0x00 and 0x

Re: [Mesa-dev] [PATCH 23/24] i965/vec4: Replace src_reg(imm) constructors with brw_imm_*().

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > @@ -387,7 +342,9 @@ vec4_visitor::opt_vector_float() > >remaining_channels &= ~inst->dst.writemask; >if (remaining_channels == 0) { > - vec4_instruction *mov = MOV(inst->dst, imm); > + unsigned vf; > + memcp

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-03 Thread Emil Velikov
Hi Matt, On 3 November 2015 at 00:29, Matt Turner wrote: > backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a > brw_reg that's used for "hardware regs" -- precolored registers or > architecture > registers. This leads to properties like source modifiers, the register type,

Re: [Mesa-dev] MSVC (2015) builds

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 15:48, Brian Paul wrote: > On 11/02/2015 08:42 PM, Janusz Ganczarski wrote: >> >> Hello, >> In attachment fixed Visual C++ 2015 (VC 14) builds for Mesa. >> Currently only gallium softpipe driver support. Gallium llvmpipe >> driver support work in progress. > > > I'm not sure

Re: [Mesa-dev] gallium/hud: control visibility at startup and runtime.

2015-11-03 Thread Emil Velikov
Hello Jimmy, Please add your name to your git config. On 3 November 2015 at 10:43, boombatower wrote: > - env GALLIUM_HUD_VISIBLE: control default visibility > - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal > --- > docs/envvars.html | 6 ++ > src/galliu

Re: [Mesa-dev] [PATCH 05/24] i965: Reorganize brw_reg fields.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 17:27, Matt Turner wrote: > On Tue, Nov 3, 2015 at 2:38 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >>> Put fields that are meaningless with an immediate in the same storage >>> with the immediate. >> There i

Re: [Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 18:02, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:05 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >>> The test (file == BAD_FILE) works on registers for which the constructor >>> has not run because BAD_FILE is

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 17:55, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:04 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >> >> Please add a bit of commit message - "Mostly unused as of last commit. >> Fold the remaining cases (GR

Re: [Mesa-dev] [PATCH 18/24] i965: Combine register file field.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 18:10, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:07 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >> >>> index 6eeafd5..3d2b051 100644 >>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp >>>

Re: [Mesa-dev] [PATCH 23/24] i965/vec4: Replace src_reg(imm) constructors with brw_imm_*().

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 18:20, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:09 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >> >>> @@ -387,7 +342,9 @@ vec4_visitor::opt_vector_float() >>> >>>remaining_chann

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: fix stream qualifier for blocks with an instance name

2015-11-05 Thread Emil Velikov
On 17 October 2015 at 10:51, Timothy Arceri wrote: > This also removes the validation from the parser as it is not required > and once arb_enhanced_layouts comes along we wont be able to do validation > on the stream qualifier in the parser anyway as it adds constant expression > support to the st

[Mesa-dev] [PATCH 02/13] fixup! i965: Combine register file field.

2015-11-05 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index e2f8a0a..6975a19 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4

[Mesa-dev] [PATCH 0/13] i965: do not use memset in *_reg() ctors

2015-11-05 Thread Emil Velikov
Hi all, This is a series that builds on top of Matts "i965: Refactor register classes". As Matt's branch has some additional changes, the first two patches are fixups that could be merged directly. The follow-up four patches removes/reworks some of the constructors, in order to avoid reworking

[Mesa-dev] [PATCH 03/13] i965/fs: remove unneeded fs_reg(...) ctor

2015-11-05 Thread Emil Velikov
From: Emil Velikov By using a default value for brw_reg_type the compiler will reuse the existing constructor. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs.cpp | 9 - src/mesa/drivers/dri/i965/brw_ir_fs.h | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions

[Mesa-dev] [PATCH 01/13] fixup! i965: Combine register file field.

2015-11-05 Thread Emil Velikov
From: Emil Velikov Remove unneeded this->file assignment in dst_reg(const src_reg &f) ctor Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_v

[Mesa-dev] [PATCH 04/13] i965/vec4: kill off the final possible dst_reg ctor

2015-11-05 Thread Emil Velikov
From: Emil Velikov By providing default values for type and writemask, the compiler will 'create' the constructor for us. The values chosen are the exact same ones, used in the default ctor - dst_reg(), as such the compiler should be smart enough to optimise the duplicated (identical)

[Mesa-dev] [PATCH 08/13] i965: do not memcmp to check if brw_regs are equal

2015-11-05 Thread Emil Velikov
From: Emil Velikov As of last commit one can easily the whole brw_reg as two unsigned values. Lets use that and avoid the nastylooking memcmp + casts. XXX: reladdr looks a bit strange. we tend to do dst_reg<>src_reg and in some cases this might cause someheadaches. should we zero it

[Mesa-dev] [PATCH 10/13] i965/fs: properly construct fs_reg

2015-11-05 Thread Emil Velikov
From: Emil Velikov Rather than doing memset(), implicitly use the backend_reg ctor(s) which will initialise its variables. For the fs_reg ones, set them manually. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs.cpp | 18 +++--- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 05/13] i965/vec4: one dst_reg() constructor less

2015-11-05 Thread Emil Velikov
From: Emil Velikov Just fold the brw_type_for_base_type() and use a delegated constructor. Note this is a c++11 feature and the compiler will warn us if it's set/defaults to an earlier version of the standard. XXX: Should we just toggle c++11 on ? We seem to be using some of its function

[Mesa-dev] [PATCH 12/13] i965/vec4: sort dst_reg ctors like the src_reg ones

2015-11-05 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_ir_vec4.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_ir_vec4.h b/src/mesa/drivers/dri/i965/brw_ir_vec4.h index b70dca5..2c7293d 100644 --- a/src/mesa

[Mesa-dev] [PATCH 06/13] i965/vec4: remove the explicitly sized vec4_visitor src_reg ctor

2015-11-05 Thread Emil Velikov
From: Emil Velikov Just default the size to 1, and let the compiler do its magic. XXX: Not 100% sure this is correct. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_ir_vec4.h| 3 +-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 19 +++ 2 files

[Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
From: Emil Velikov This commits partially reverts "i965: Initialize registers' file to BAD_FILE." No longer needed as of commit "i965/fs: properly construct fs_reg" which removes the memset(...0...), and correctly sets BAD_FILE. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 09/13] i965: initialise the backend_reg members in the ctor

2015-11-05 Thread Emil Velikov
From: Emil Velikov Step one towards having a normal constructors for the *_reg primitives, and removing a handful of somewhat ugly code. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.h | 11 +-- src/mesa/drivers

[Mesa-dev] [PATCH 07/13] i965: make brw_reg imm attibs accessible as a value

2015-11-05 Thread Emil Velikov
From: Emil Velikov Will allow us an easy once-off get/set of the attribs. Thus we can drop all the memset/memcmp + magic casting. XXX: alternative name(s) are welcome Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_reg.h | 21 + 1 file changed, 13 insertions

[Mesa-dev] [PATCH 11/13] i965/vec4: rework the src_reg/dst_reg constructors

2015-11-05 Thread Emil Velikov
From: Emil Velikov Analogous to the previous (fs) commit - drop the explicit memset and set the non-inherited variables (reladdr) manually. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_ir_vec4.h| 13 +++ src/mesa/drivers/dri/i965/brw_vec4.cpp | 48

Re: [Mesa-dev] [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.

2015-11-05 Thread Emil Velikov
On 3 November 2015 at 18:02, Matt Turner wrote: > On Tue, Nov 3, 2015 at 8:05 AM, Emil Velikov wrote: >> On 3 November 2015 at 00:29, Matt Turner wrote: >>> The test (file == BAD_FILE) works on registers for which the constructor >>> has not run because BAD_FILE is

Re: [Mesa-dev] [PATCH 08/24] i965: Remove fixed_hw_reg field from backend_reg.

2015-11-05 Thread Emil Velikov
On 3 November 2015 at 16:04, Emil Velikov wrote: >> @@ -1596,8 +1586,7 @@ vec4_visitor::lower_attributes_to_hw_regs(const int >> *attribute_map, >> reg.type = inst->dst.type; >> reg.writemask = inst->dst.writemask; >> >> -

Re: [Mesa-dev] [PATCH 4/4] st/va: add support for RGBX and BGRX in VPP

2015-11-05 Thread Emil Velikov
Hi Julien, On 5 November 2015 at 08:24, Julien Isorce wrote: > Before it was only possible to convert a NV12 surface to > RGBA or BGRA. This patch uses the same post processing > function, "handleVAProcPipelineParameterBufferType", but > add definitions for RGBX and BGRX. > > This patch also make

Re: [Mesa-dev] [PATCH 3/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 08:24, Julien Isorce wrote: > Some lines were using 4 indentation spaces instead of 3. > > The switch in vlVaAcquireBufferHandle actually had wrong brackets > surrounding case+default. > Please don't mix whitespace (trivial) patches and bugfixes. -Emil __

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 16:18, Emil Velikov wrote: > From: Emil Velikov > > This commits partially reverts "i965: Initialize registers' file to > BAD_FILE." > > No longer needed as of commit "i965/fs: properly construct fs_reg" which > removes th

Re: [Mesa-dev] [PATCH 1/2] main: Don't restrict several KHR_debug enum to desktop GL

2015-11-05 Thread Emil Velikov
debug_state_int(ctx, cap, state); There is another similar hunk in _mesa_IsEnabled. With that the patch is Reviewed-by: Emil Velikov I will send a "append KHR to function names when in ES context" patch and with that we can enable the extension. Thanks for bringing this up ! Emil __

[Mesa-dev] [PATCH] mesa: use the correct string for the ES GL_KHR_debug functions

2015-11-05 Thread Emil Velikov
As defined in the spec when implemented in an OpenGL ES context, all entry points defined by this extension must have a "KHR" suffix. Signed-off-by: Emil Velikov --- The final piece afaict for KHR_debug + ES contexts. Mildly related - the enum tests seems somewhat busted/

[Mesa-dev] [PATCHv2] mesa: use the correct string for the ES GL_KHR_debug functions

2015-11-05 Thread Emil Velikov
As defined in the spec when implemented in an OpenGL ES context, all entry points defined by this extension must have a "KHR" suffix. Signed-off-by: Emil Velikov --- Actually build tested this time. src/mesa/main/errors.c | 40 ---

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:15, Matt Turner wrote: > On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> This commits partially reverts "i965: Initialize registers' file to >> BAD_FILE." >> >> No longer needed a

Re: [Mesa-dev] [PATCH 05/13] i965/vec4: one dst_reg() constructor less

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:04, Matt Turner wrote: > On Thu, Nov 5, 2015 at 8:17 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> Just fold the brw_type_for_base_type() and use a delegated >> constructor. >> >> Note this is a c++11 feature and the compil

Re: [Mesa-dev] [PATCH 08/13] i965: do not memcmp to check if brw_regs are equal

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 16:17, Emil Velikov wrote: > From: Emil Velikov > > As of last commit one can easily the whole brw_reg as two unsigned The about above should read "... one can easily _access_ the whole..." -Emil ___ mesa-de

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 22:06, Matt Turner wrote: > On Thu, Nov 5, 2015 at 12:24 PM, Emil Velikov > wrote: >> On 5 November 2015 at 19:15, Matt Turner wrote: >>> On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov >>> wrote: >>>> From: Emil Velikov >

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:43, Christian König wrote: >> >> +/** >> + * >> + * Copyright 2009 Younes Manton. >> + * All Rights Reserved. > > You probably want to change the copyright here. > Heh considering that 90% of the follo

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow dec/enc/transcode without X > Are we talking about multi GPU setup where X is running on one, and OMX on another, or a true "without X" case ? I'm leaning that the latter isn't really possible, yet. > Signed-off-by: Leo Liu > --- > s

Re: [Mesa-dev] [PATCH 0/4] st/va: indent, leak fix and RGBx/BGRx for vpp

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 23:13, Julien Isorce wrote: > On 5 November 2015 at 14:22, Christian König > wrote: >> >> Patches #1-#3 are Reviewed-by: Christian König >> >> Please split patch #4 in two with first adding the new vl_video_buffer >> formats and then using them in the state tracker. > > > M

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 21:00, Leo Liu wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > Reviewed-by: Christian König > --- > src/gallium/state_trackers/va/buffer.c | 24 +- > src/gallium/state_trackers/va/context.c| 7 ++ > src/gallium/state_trackers/va/picture.c|

[Mesa-dev] [RFC PATCH] main/tests: add inverse lookup test

2015-11-05 Thread Emil Velikov
Seems that we've been forgetting to update this test, leading to decreased usefulness. Thus lets add a test which walks over the mesa generated enums and checks the string (if non "0x" prefixed) against the local table. Signed-off-by: Emil Velikov --- I'm not 100% sure on

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-06 Thread Emil Velikov
c4: Replace src_reg(imm) constructors with brw_imm_*(). Keep the memcpy(), although we really should address the uninitialised imm[] warning/bug. In a separate commit of course and optionally nuke the memcpy. With these and a jenkins spin to catch any subtle bugs the series is Reviewed-by: Emil Vel

Re: [Mesa-dev] [PATCH 1/6] mesa: add ARB_enhanced_layouts

2015-11-06 Thread Emil Velikov
Hi Tim, A few comments below On 5 November 2015 at 11:17, Timothy Arceri wrote: > From: Timothy Arceri > > Set to dummy_false until the remaining features are added. > --- > src/glsl/glcpp/glcpp-parse.y| 1 + > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h | 2 ++

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-06 Thread Emil Velikov
On 5 November 2015 at 11:17, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preperation for compile-time constant support. typo "preparation" > > Also fix up the locations for some of the extension checking > error messages in the parser. We now correctly give the location > of the

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

2015-11-06 Thread Emil Velikov
Hi Tim, In my (limited) experience going through the glsl code, I've noticed that in a few cases we tend to do the same "flags.q.foo && validate_foo()" in a number of occasions. In some cases we silently ignore errors, while on others we omit checking the return value of validate_foo() all togethe

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-06 Thread Emil Velikov
On 6 November 2015 at 03:19, Liu, Leo wrote: >>-Original Message- >>From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >>Sent: Thursday, November 05, 2015 6:30 PM >>To: Liu, Leo >>Cc: ML mesa-dev >>Subject: Re: [Mesa-dev] [PATCH 4/4] st/omx: add head

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-06 Thread Emil Velikov
Hello Leo, On 6 November 2015 at 16:00, Liu, Leo wrote: > Hi Emil, > >>Shorten the variable name - OMX_RENDER_NODE ? debug_get_option is only >>available on debug builds so better use getenv. >> > > The debug_get_*_option() functions are used all around mesa, and functions > are explicitly prefe

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

2015-11-06 Thread Emil Velikov
Hi Brian, On 31 October 2015 at 13:38, Brian Paul wrote: > Very long line loops which spanned 3 or more vertex buffers were not > handled correctly and could result in stray lines. > > The piglit lineloop test draws 1 vertices by default, and is not > long enough to trigger this. Even 'linel

Re: [Mesa-dev] [PATCH v2 4/4] st/omx: add headless support

2015-11-06 Thread Emil Velikov
Hi Leo, I've suggested a few things before, yet I might have been too subtle. Let me try again. On 6 November 2015 at 16:40, Leo Liu wrote: > This will allow dec/enc/transcode without X Please add "running" in the above sentence "... without running X" or similar. > > v2: -use env override eve

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-06 Thread Emil Velikov
On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow the state trackers to use render nodes > with screen creation > > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/Makefile.sources | 3 +- > src/gallium/auxiliary/vl/vl_winsys.h | 6 +++ > src/gallium/auxiliary/vl/vl_wins

Re: [Mesa-dev] fix VC-1 simple/main profile

2015-11-06 Thread Emil Velikov
On 6 November 2015 at 10:58, Christian König wrote: > Hi list, > > we haven't fixed all the issues yet, but this is a clearly step in the > right direction. > > If nobody has any more objections I'm going to push these by the end of today. > On behalf of everyone using the 11.0 series - thank you

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

2015-11-06 Thread Emil Velikov
Hi Mauro On 6 November 2015 at 03:31, Mauro Rossi wrote: > These changes are necessary to avoid building errors in glsl and i965 > --- > src/glsl/Android.mk | 6 -- > src/mesa/drivers/dri/i965/Android.mk | 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-06 Thread Emil Velikov
On 6 November 2015 at 18:01, Liu, Leo wrote: > >>> +#if GALLIUM_STATIC_TARGETS >>> + vscreen->pscreen = dd_create_screen(fd); >>> +#else >>> + if (pipe_loader_drm_probe_fd(&vscreen->dev, fd)) { >>Add a dup() in the above. So that it reads >> >>if (pipe_loader_drm_probe_fd(&vscreen->dev, dup(fd

Re: [Mesa-dev] [PATCH] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

2015-11-07 Thread Emil Velikov
On 6 November 2015 at 19:26, Marek Olšák wrote: > On Fri, Nov 6, 2015 at 8:24 PM, Marek Olšák wrote: >> On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov >> wrote: >>> On 3 October 2015 at 12:19, Emil Velikov wrote: >>>> On 3 October 2015 at 02:12, Marek Olšá

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

2015-11-07 Thread Emil Velikov
On 6 November 2015 at 17:50, Brian Paul wrote: > On 11/06/2015 09:40 AM, Emil Velikov wrote: >> >> Hi Brian, >> >> On 31 October 2015 at 13:38, Brian Paul wrote: >>> >>> Very long line loops which spanned 3 or more vertex buffers were not >>

[Mesa-dev] Mesa 11.1.0 release plan

2015-11-07 Thread Emil Velikov
Hi all, It's time to get the idea of where were are wrt the next Mesa release - 11.1.0. As usual here is the normal plan, although everyone interested in more than welcome to chime in November 20th 2015 - Feature freeze/Release candidate 1 November 27th 2015 - Release candidate 2 December 04th 20

[Mesa-dev] New stable-branch 11.0 candidate pushed

2015-11-07 Thread Emil Velikov
d XRGB format to intel_screen_make_configs Brian Paul (1): configure: don't try to build gallium DRI drivers if --disable-dri is set Dave Airlie (1): gallium/swrast: fix front buffer blitting. (v2) Emil Velikov (3): i965: store reference to the context within struct brw_fence

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

2015-11-07 Thread Emil Velikov
Hi Dave, On 9 October 2015 at 01:38, Dave Airlie wrote: > From: Dave Airlie > > So I've known this was broken before, cogl has a workaround > for it from what I know, but with the gallium based swrast > drivers BlitFramebuffer from back to front or vice-versa > was pretty broken. > > The legacy

Re: [Mesa-dev] New stable-branch 11.0 candidate pushed

2015-11-08 Thread Emil Velikov
On 7 November 2015 at 19:18, Kenneth Graunke wrote: > On Saturday, November 07, 2015 04:37:05 PM Emil Velikov wrote: >> Jason, Kenneth, >> >> I had to pick a few extra commits as prerequirements to the "nir: >> Properly invalidate metadata in nir_foo" patc

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

2015-11-08 Thread Emil Velikov
Hi Mark, On 7 November 2015 at 23:26, Mark Janes wrote: > Hi Emil, > > I get this regression testing the new branch: > > piglit.spec.oes_compressed_paletted_texture.basic api > > /tmp/build_root/m64/lib/piglit/bin/oes_compressed_paletted_texture-api -auto > -fbo > Trying glTexImage2D... > Trying

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

2015-11-08 Thread Emil Velikov
[Dropping Jason, Ken, adding Roland to CC list] Hi Oded, On 8 November 2015 at 09:22, Oded Gabbay wrote: > Hi Emil, > > I would like to propose the following patch to be added to 11.0.5: > 39b4dfe6ab1003863778a25c091c080e098833ec llvmpipe: use simple coeffs > calc for 128bit vectors > > It fixe

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

2015-11-08 Thread Emil Velikov
On 8 November 2015 at 11:41, Christian König wrote: > On 06.11.2015 20:28, Ilia Mirkin wrote: >> >> On Fri, Nov 6, 2015 at 2:15 PM, Christian König >> wrote: >>> >>> On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: > > Hi Emil, >

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

2015-11-08 Thread Emil Velikov
On 7 November 2015 at 21:57, Dave Airlie wrote: > On 8 November 2015 at 02:47, Emil Velikov wrote: >> Hi Dave, >> >> On 9 October 2015 at 01:38, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> So I've known this was broken before, cogl h

Re: [Mesa-dev] [PATCH 1/6] mesa: add ARB_enhanced_layouts

2015-11-08 Thread Emil Velikov
Hi Tim, On 6 November 2015 at 21:09, Timothy Arceri wrote: > On Fri, 2015-11-06 at 13:02 +0000, Emil Velikov wrote: >> Hi Tim, >> >> A few comments below >> >> On 5 November 2015 at 11:17, Timothy Arceri wrote: >> > From: Timothy Arceri >> > &

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-08 Thread Emil Velikov
On 6 November 2015 at 21:13, Timothy Arceri wrote: > On Fri, 2015-11-06 at 13:16 +0000, Emil Velikov wrote: >> On 5 November 2015 at 11:17, Timothy Arceri wrote: >> > From: Timothy Arceri >> > >> > This is in preperation for compile-time constant support. >

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

2015-11-08 Thread Emil Velikov
Hi Mauro, On 8 November 2015 at 12:59, Mauro Rossi wrote: > Update2: I'm getting the building error in both x86 target and x86_64 > target. > > I'm relieved it's not arch dependend, I suspect that export will require a > dependency to be declared, > because if i965_dri module is built before gls

Re: [Mesa-dev] [PATCH v2 2/4] vl: add drm support for vl_screen

2015-11-09 Thread Emil Velikov
Hi Leo, Please, if you do not understand what was said earlier ask for clarification rather than just ignoring it. For example: On 6 November 2015 at 18:43, Leo Liu wrote: > This will allow the state trackers to use render nodes > with screen creation > > v2 -dup fd for pipe loader > > Signed-o

Re: [Mesa-dev] [PATCH v3 4/4] st/omx: add headless support

2015-11-09 Thread Emil Velikov
Hi Leo, I'm glad that you've caught the places where I was day dreaming but again, please don't just ignore suggestions. If you believe there is something wrong with them just say so (as you did with debug_get_options). On 6 November 2015 at 18:43, Leo Liu wrote: > This will allow dec/enc/transc

Re: [Mesa-dev] [PATCH 1/7] radeonsi: initialize SX_PS_DOWNCONVERT to 0 on Stoney

2015-11-09 Thread Emil Velikov
On 8 November 2015 at 21:45, Marek Olšák wrote: > From: Marek Olšák > > otherwise the SX or CB blocks can go bananas > --- Should we get this into stable as well, considering Alex requested that we have Stoney support there ? It seems that other fixes d57ede92b78 are missing the tag. Can we get

<    1   2   3   4   5   6   7   8   9   10   >