-Dtools=etnaviv -Dplatforms=wayland -Dglx=disabled \
>build/
>
> Cc: Alexander von Gluck IV
> Cc: Dylan Baker
> Cc: Boris Brezillon
> Reported-by: Boris Brezillon
> Fixes: 834d221512f ("meson: Add Haiku platform support v4")
> Signed-off-by: Emil Velikov
Revie
e = _eglAddDevice(dri2_dpy->fd, true);
> + assert(dpy->Device);
>
> - return false;
> + dri2_dpy->driver_name = strdup("swrast");
> + if (!dri2_dpy->driver_name)
> + return false;
> +
> + if (!dri2_load_driver_swrast(dpy))
free(dri2_dpy
ES 32
> struct dri2_egl_display *dri2_dpy = dpy->DriverData;
> - const int limit = 64;
Any reason to drop the 64 down to 32?
Other than that, looks good to me:
Reviewed-by: Eric Engestrom
> - const int base = 128;
> - int fd;
> - int i;
> -
> - /* Attempt to find D
On Tuesday, 2019-02-05 15:31:08 +, Emil Velikov wrote:
> From: Emil Velikov
>
> VGEM and kms_swrast were introduced to work with one another.
>
> All we do is CPU rendering to dumb buffers. There is no reason to carve
> out GPU memory, increasing the memory pressure on a device that could
>
On Monday, 2019-02-18 17:31:41 +, Daniel Stone wrote:
> Hi all,
> A few people have noted that Mesa's GitLab CI is just too slow, and
> not usable in day-to-day development, which is a massive shame.
Agreed :/
>
> I looked into it a bit this morning, and also discussed it with Emil,
> though
ast) {
> + /* Use kms swrast only with vgem */
> + if (strcmp(driver_name, "vgem") == 0)
> +dri2_dpy->driver_name = strdup("kms_swrast");
> + free(driver_name);
> + } else {
> + /* Use the given hardware driver
On Tuesday, 2019-02-19 15:30:39 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Some platforms lack O_CLOEXEC. The loader_open_device() handles those
> appropriately, so use the helper.
>
> Signed-off-by: Emil Velikov
I'll review 1 & 3 later, but 2 & 4 a
Hi all,
The GitLab CI translated from Travis is really resource-hungry (see the
discussion DanielS started [1]).
Efforts are ongoing to make it nicer to its runners, but as
a (hopefully) temporary measure, the CI is now opt-in to avoid wasting
cycles if the dev pushing commits didn't want to run
On Monday, 2019-02-25 11:57:20 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Mention the tick-box otherwise only the MR author can rebase the series.
I thought it was already mentioned... oops.
Reviewed-by: Eric Engestrom
>
> Cc: Jordan Justen
> Cc: Dylan Baker
&g
ect... :]
Fixes: cc15460e182148292be8 "meson: drop GLESv1 .so version back to 1.0.0"
Reviewed-by: Eric Engestrom
> ---
> src/mapi/es1api/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mapi/es1api/meson.build b/src/mapi/es1api
nce sys/types.h is included through another
> system headers
Reviewed-by: Eric Engestrom
> ---
> src/gallium/winsys/svga/drm/vmw_screen.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/winsys/svga/drm/vmw_screen.h
> b/src/gallium/winsys/svga/drm/vmw_sc
On Sunday, 2019-03-03 21:10:50 +0100, Mauro Rossi wrote:
> Necessary to avoid building error in Android,
> due to 'compiler/glsl/float64_glsl.h' file not found
>
> Fixes: cb4e3e3 ("st/mesa: add support for lowering fp64/int64 for nir
> drivers")
> Signed-off-by: Mauro Rossi
> ---
> src/mesa/And
option.
Thanks! I left a couple comments below, but this is:
Reviewed-by: Eric Engestrom
> ---
> docs/contents.html | 2 +-
> docs/meson.html| 138
> +++--
> 2 files changed, 104 insertions(+), 36 deletions(-)
>
> diff -
On Friday, 2019-03-08 15:54:37 -0700, Brian Paul wrote:
> ---
> docs/meson.html | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/docs/meson.html b/docs/meson.html
> index 7ffef81..43090aa 100644
> --- a/docs/meson.html
> +++ b/docs/meson.html
> @@ -274,6 +274,19 @@ on the s
t64_t *array, size_t array_size, uint64_t needle)
There could be other places that could use this function (or its
u32/s64/s32 equivalents), there's no reason to prevent its adoption with
a too specific name :)
With a generic name (and the missing `inline` Christian also mentioned),
the series is:
Reviewed-by: Eric Engestrom
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Friday, 2019-03-15 21:25:33 +1100, Timothy Arceri wrote:
> This was added in 8a7d4092d260 but no longer seems to have any
> impact on performance.
> ---
> src/amd/vulkan/radv_device.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.
On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote:
> There is merge request opened about this issue :
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/429
>
> I think the deps need to be moved from src/vulkan/wsi/meson.build into
> src/vulkan/meson.build as they apply to the
On Monday, 2019-03-18 10:32:17 -0700, Dylan Baker wrote:
> Quoting Eric Engestrom (2019-03-17 11:33:23)
> > On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote:
> > > There is merge request opened about this issue :
> > > https://gitlab.freedesktop.org/m
Good idea!
For the whole series:
Reviewed-by: Eric Engestrom
On Tue, Apr 12, 2016 at 07:37:43AM +0100, Jose Fonseca wrote:
> ---
> src/mesa/main/imports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c
3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all
VK_PROTOTYPES to VK_NO_PROTOTYPES
This brings the Intel header in line with the rest of the Vulkan code.
Signed-off-by: Eric Engestrom
---
This might break code that was using the old guard scheme (not sure how
that could've worked a
Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the
VK_PROTOTYPES to VK_NO_PROTOTYPES
This brings the Intel header in line with the rest of the Vulkan code.
Signed-off-by: Eric Engestrom
---
This might break code that was using the old guard scheme (not sure how
that could've w
On Thu, Apr 21, 2016 at 01:24:45PM +0100, Emil Velikov wrote:
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index 120696e..3eb0475 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -53,6 +53,9 @@ typedef struct xcb_connectio
3; break;
> case 4: op = nir_op_bany_inequal4; break;
> + default: unreachable("not reached");
I'll admit I don't know this code very well, but I'm sure one can write
a more informative message :)
"invalid number of components" for instance?
Wit
clearer.
>
> This would typically break the bo size computation, but we don't use
> that except when mmaping, and we don't mmap YUV buffers much.
>
> Signed-off-by: Kristian Høgsberg Kristensen
> ---
Why does that even compile…
Reviewed-by: Eric Engestrom
___
`size_t offset` can never be `< 0`
Signed-off-by: Eric Engestrom
---
src/compiler/glsl/blob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/blob.c b/src/compiler/glsl/blob.c
index dd4341b..ef17255 100644
--- a/src/compiler/glsl/blob.c
+++ b/src/compi
These two lines have been here since the file was created.
I'm guessing the second one was just for testing during dev, so it's the
one that's going away.
CoverityID: 1296205
Signed-off-by: Eric Engestrom
---
This should probably be tested by someone who knows what they'r
CoverityID: 1358935
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 046777d..e451138 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src
`unsigned j` would never fail `j >= 0`, leading to an infinite loop as
`j--` wraps around.
Signed-off-by: Eric Engestrom
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/m
Signed-off-by: Eric Engestrom
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 7db5639..d3f3589 100644
--- a/.gitignore
+++ b/.gitignore
@@ -48,3 +48,4 @@ Makefile
Makefile.in
.install-mesa-links
.install-gallium-links
+TAGS
--
2.8.3
From strncpy's man page:
Warning: If there is no null byte among the first n bytes of src, the
string placed in dest will not be null-terminated.
CoverityID: 1320457, 1320458, 1255671
Signed-off-by: Eric Engestrom
---
src/gallium/targets/d3dadapter9/description.c
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp
b/src/gallium/drivers/swr/rasterizer/common
CoverityID: 1337953
Signed-off-by: Eric Engestrom
---
Note that I do not know this code at all; I'm blindly following Coverity's
advice on this one :]
---
src/gallium/state_trackers/va/image.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/va/imag
nly output is already what we want. I'd find
something like this cleaner, but your patch also works:
printf '#define MESA_GIT_SHA1 "git-%s"\n' > git_sha1.h \
$(git --git-dir=$(top_srcdir)/.git rev-parse --short HEAD)
Either way, th
On Tue, May 31, 2016 at 06:33:53AM -0600, Brian Paul wrote:
> On 05/30/2016 07:26 PM, Eric Engestrom wrote:
> > These two lines have been here since the file was created.
> > I'm guessing the second one was just for testing during dev, so it's the
> > one that&#x
return VA_STATUS_ERROR_ALLOCATION_FAILED;
> > >}
> > >
> > >surf->buffer->destroy(surf->buffer);
> > >surf->buffer = tmp_buf;
> > > + surf->templat.buffer_format = format;
> > > }
> > >
> &
On Wed, Jun 08, 2016 at 03:44:39PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> With earlier commit we've handled the `make distclean' out of tree
> build, yet we failed to attribute that for in-tree builds the test
> condition will return 1. Thus effectively the target will be considered
On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote:
Since you didn't send this patch from your primary email account,
you might want to add this line here, otherwise the author will be
"stephan.bergmann.second...@googlemail.com":
From: Stephan Bergmann
> ...when Function::domTree
On Fri, Jun 10, 2016 at 12:28:38PM +0200, Stephan Bergmann wrote:
> On 06/10/2016 12:09 PM, Eric Engestrom wrote:
> > On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote:
> >
> > Since you didn't send this patch from your primary email account,
> >
name_str, driver_cap, gll_ver, glc_ver, gles_ver, gles2_ver,
> ) \
> +{ .name = "GL_" #name_str, .offset = o(driver_cap), \
> + .version = { \
> + [API_OPENGL_COMPAT] = gll_ver, \
> +[API_OPENGL_CORE] = glc_ver, \
> +
On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote:
> static enum { extension_table_size =
> ARRAY_SIZE(extension_table_for_size) };
Sorry, I don't know how that `static` snuck in here, but it obviously shouldn't
be here.
On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote:
>
> > diff --git a/src/mesa/main/extensions_table.c
> > b/src/mesa/main/extensions_table.c
> > new file mode 100644
> > index 000..1e37fbc
> > --- /dev/null
> > +++ b/src/mesa/ma
On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote:
> You can add an entry to the end of the enum defined in extensions.h called
> "MESA_EXTENSION_COUNT" or similar.
This is a good idea, but with one caveat:
I've seen twice already bugs caused by people using ALL_CAPS counter
entries in
-> v2:
> - use a final enum to obtain number of extensions
> - move calculation of the gl version to be once per shader, for better reuse
> - bake GL version into the "supported_versions" struct
> - while we're at it, fix supported_versions size, it was off by 1
On Wed, Jun 15, 2016 at 03:38:05PM +0530, Nayan Deshmukh wrote:
> Signed-off-by: Nayan Deshmukh
> ---
> src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/r200/r200_swtcl.c
> b/src/mesa/drivers/dri/r200/r200
On Wed, Jun 15, 2016 at 09:07:23PM +0530, Nayan Deshmukh wrote:
> Signed-off-by: Nayan Deshmukh
After all the fuss :)
Reviewed-by: Eric Engestrom
> ---
> src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sr
On Wed, Jun 15, 2016 at 03:38:04PM +0530, Nayan Deshmukh wrote:
> Signed-off-by: Nayan Deshmukh
Reviewed-by: Eric Engestrom
> ---
> src/gallium/auxiliary/draw/draw_pipe_clip.c | 2 +-
> src/gallium/auxiliary/gallivm/lp_bld_arit.c | 4 ++--
> src/gallium/drivers/i915/i9
-b on the v2.
> has nothing to do with the use of "f" and "F". Regarding replacing the "F"
> with "f", maybe someone can shed some light as to why "F" was used
> specifically.
>
> Regards,
> Nayan.
>
> On Wed, Jun 15, 2016 at 6:3
On Wed, Jun 15, 2016 at 11:19:28PM +0530, Nayan Deshmukh wrote:
> Hi Eric,
>
> Could you please push both the patches as I don't have the push access.
>
> Thanks,
> Nayan.
I don't have push access either. Emil will probably be happy to do it
for you though, seeing as this was his idea :)
Cheers
On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote:
> To match what's done in the automake build.
> ---
> src/SConscript | 43 +++
> src/mesa/SConscript | 43 ++-
> 2 files changed, 45 insertions(+), 41 de
On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote:
> On 06/16/2016 07:35 AM, Eric Engestrom wrote:
> > That fixed truncation can give non-unique hashes. Switching to rev-parse
> > (suggested above) fixes this.
>
> rev-parse --short produces a 7-char hash.
No i
On Thu, Jun 16, 2016 at 11:15:55AM -0600, Brian Paul wrote:
> To match what's done in the automake build.
>
> v2: Use git rev-parse to get a 10-character hash ID
> Fix Python imports
> ---
Perfect, thanks!
Reviewed-by: Eric Engestrom
On Fri, Jun 17, 2016 at 04:09:55PM +0200, ⚛ wrote:
> Hello. Are you editing those files by hand?
Yup, editing everything by hand. You just need a magnetized needle and
a steady hand. I'm still learning to use C-x M-c M-butterfly though,
haven't mastered that yet.
__
On Fri, Jun 17, 2016 at 06:29:40PM +0100, Frank Binns wrote:
> When trying to get a device name for an fd using sysfs, it would always fail
> as it was expecting key/value pairs to be delimited by '\0', which is not the
> case.
>
> Signed-off-by: Frank Binns
For both p
s.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: Vedran Miletić
> Cc: Francisco Jerez
> Signed-off-by: Emil Velikov
> ---
LGTM
Reviewed-by: Eric Engestrom
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
h's timestamp in this case, since that would be
the only thing that would be changed, and said timestamp would be within
the same second anyway.
I suggest to drop the `if` and unconditionally do the move.
Since this wouldn't change the behaviour anyway, with or without my
suggestion th
On Wed, Jun 22, 2016 at 01:04:42PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> It has proven subtle to get it right both form the build side POV (see
s/form/from/
Reviewed-by: Eric Engestrom
> commit list below) and builders due to their varying workflows.
>
> F
On Wed, Jun 22, 2016 at 04:57:39PM +0100, Eric Engestrom wrote:
> On Wed, Jun 22, 2016 at 01:04:41PM +0100, Emil Velikov wrote:
> > From: Emil Velikov
[...]
> > diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
> > index 4d9ff90..8332ae5 100644
>
On Thu, Jun 23, 2016 at 03:54:11PM +0530, Gurkirpal Singh wrote:
> ---
Yes, and this reminds me I forgot to send similar fixes I made in this file ^^
Reviewed-by: Eric Engestrom
You might also want to add a Signed-off-by: line with your name (although
I don't think this is a requirement
Signed-off-by: Eric Engestrom
---
src/gbm/main/gbm.c | 8
src/gbm/main/gbm.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c
index 0f4657a..a464f3c 100644
--- a/src/gbm/main/gbm.c
+++ b/src/gbm/main/gbm.c
@@ -232,7 +232,7
Good catch!
Reviewed-by: Eric Engestrom
On 25 May 2017 10:26:18 BST, Andres Gomez wrote:
>Signed-off-by: Andres Gomez
>---
> docs/release-calendar.html | 2 +-
> docs/releasing.html| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/docs/re
Fixes: de9dd4f9f1bb5984c554 ("ac/radeonsi: move struct radeon_info to
ac_gpu_info.h")
Cc: Nicolai Hähnle
Cc: Marek Olšák
Signed-off-by: Eric Engestrom
---
src/amd/Makefile.common.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/Makefile.common.am b/src/amd/Makefile
On Friday, 2017-05-26 16:32:52 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Add a couple of forward declarations and drop the amdgpu.h requirement.
>
> With this we can build the r300 and r600 drivers without the need for
> amdgpu.
>
> Cc: Nicolai Hähnle
> Cc: Marek Olšák
> Bugzilla: h
Since they haven't been altered for the last 9-12 revisions, and in
order to reduce the load of patches to rebase and carry, I just landed
the EGL side (patches 1-7), with my r-b added on the couple patches
I hadn't reviewed.
Cheers,
Eric
On Tuesday, 2017-05-30 17:23:40 +0530, Varad Gautam wrot
f the
dri2_display_destroy() helper")
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/platform_drm.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b/src/egl/drivers/dri2/platform_drm.c
index
it's not
> _EGL_INVALID_PLATFORM, it should not cause problems in practice.
>
> Cc: Eric Engestrom
> Fixes: 7adb9b0948 "egl/display: remove unnecessary code and make it easier to
> read"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252
> Signe
has updated it since.
This means the platform detected in the thread might not be the platform
returned by the function, but this is a different issue that will need
to be discussed when this becomes possible.
Reported-by: Grazvydas Ignotas
Signed-off-by: Eric Engestrom
---
This is unnecessary
splay: remove unnecessary code and
make it easier to read")
Signed-off-by: Eric Engestrom
---
src/egl/main/egldisplay.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldispl
On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote:
> Fixes for:
>
> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open'
> [-Werror=implicit-function-declaration]
> int fd = open("/dev/urandom", O_RDONLY);
> ^~~~
> src/util/rand_xor.c:60:34: erro
Simple search for a backslash followed by two newlines.
If one of the newlines were to be removed, this would cause issues, so
let's just remove these trailing backslashes.
Signed-off-by: Eric Engestrom
---
I can split the patch by module if you want, but this seems trivial
enough?
A simpl
Signed-off-by: Eric Engestrom
---
configure.ac | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index b57be07e24..5caf316089 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1066,16 +1066,12 @@ AC_SUBST([LLVM_INCLUDEDIR])
dnl
dnl libunwind
On Thursday, 2017-06-01 16:15:41 +0200, Nicolas Dechesne wrote:
> On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom
> wrote:
> > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote:
> >> Fixes for:
> >>
> >> src/util/rand_xor.c:60:13: error:
On Saturday, 2017-06-03 20:11:38 +0200, Thomas Helland wrote:
> Also, prepare for the next commit by correcting some coding style
> changes. This should be all non-functional changes.
> ---
> src/util/u_dynarray.h | 27 ---
> 1 file changed, 12 insertions(+), 15 deletions(-
*)nir_array_grow(arr, sizeof(type)) = (elem)
> -
> -#define nir_array_foreach(arr, type, elem) \
> - for (type *elem = (type *)(arr)->data; \
> -elem < (type *)((char *)(arr)->data + (arr)->size); elem++)
> -
> -#ifdef __cplusplus
> -} /* extern &quo
+ int patch = patch_string ? atoi(patch_string + 1) : 0;
> + if (strstr(VERSION, "devel")) {
> + if (patch == 0) {
> + patch = 99;
> + if (minor == 0) {
> +minor = 99;
> +--major;
> + } else
> +
On Tuesday, 2017-06-06 14:40:28 +0200, Samuel Pitoiset wrote:
> Also add ALWAYS_INLINE to blit_framebuffer().
>
> Signed-off-by: Samuel Pitoiset
> ---
>
> NOTE: Patch introduced between 9 and 10 in this series. Nothing changed
> except some rebase conflicts.
>
> src/mesa/main/blit.c | 35 +
On Monday, 2017-06-05 17:04:28 +0100, Emil Velikov wrote:
> > + * If the width of the passed rect is greater than the surface's
> > + * width then it is clamped to the width of the surface. Same with
> > + * height.
> > + */
> > +
> > +static void
> > +_eglSetDamageRegionKHRClampRects(_EGLDisplay*
On Monday, 2017-06-05 19:37:55 +0530, Harish Krupo wrote:
> This patch adds support for the EGL_KHR_partial_update extension for
> android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
> 1 test not supported.
>
> v2: add fallback for eglSetDamageRegionKHR (Tapani)
>
> v3: Th
fPlaneModifiersLo[0].Value &
> 0x);
To be clear, the fix is to cast Lo before OR'ing it, right?
The rest is just aesthetic?
Reviewed-by: Eric Engestrom
>has_modifier = true;
> } else {
>modifier = DRM_FORMAT_MOD_INVALID;
> --
return 0;
> + return -1;
> }
>
> - return dri2_surf->back->age;
> + return dri2_surf->back ? dri2_surf->back->age : 0;
Nit: this could be a separate commit.
Regardless, as one or two commits it all gets:
Reviewed-by: Eric Engestrom
Cc: mesa
> Wasn't sure about the return values of the perform method. Window.h
> documents only -ENOENT. Sure, I will make this change.
> I will send the patch immediately after the fix for buffer age is merged.
>
Indeed, the only documented [1] return value is -ENOENT:
> returns -ENOENT
071
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Emil Velikov
Series is:
Reviewed-by: Eric Engestrom
I think you should push 1+3+4, 2 can wait for the various confirmations
you requested.
> ---
> configure.ac | 5 +
> 1 file changed, 5 insertions(+)
>
&
diately when n_rects is 0. Place function's entrypoint
> in alphabetical order. (Eric Engestrom)
>
> v5: Replace unnecessary calloc with malloc (Eric)
> Check for BAD_ALLOC error (Emil)
> Check for error in native_window_set_damage_region. (Emil, Tapani,
> Eric).
od to me:
Reviewed-by: Eric Engestrom
>
> On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas wrote:
> > This will allow to constify other things.
> >
> > Signed-off-by: Grazvydas Ignotas
> > ---
> > src/compiler/nir/nir.h | 25 +--
Let's (try to) set damages before swapping buffers.
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2_fallbacks.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/egl_dri2_fallbacks.h
b/src/egl/drivers/dri2/egl_dri2_fallbacks.h
index d8363c9bdd..604db
This is completely untested, as I don't have access to an Android
test device, which is the only platform that can benefit from this
improvement so far.
Can someone run dEQP-EGL.functional.swap_buffers_with_damage.*
on Android for me?
Cheers,
Eric
---
Eric Engestrom (2):
egl: im
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/platform_android.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl/drivers/dri2/platform_android.c
index 7a73419d14..629ee593d0 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b
From: Eric Le Bihan
KHR/khrplatform.h is required by the EGL, GLES and VG headers, but is
only installed if Mesa3d is compiled with EGL support.
This patch installs this header file unconditionally.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77240
Signed-off-by: Eric Le Bihan
---
On Monday, 2017-06-12 09:39:15 +0300, Tapani Pälli wrote:
> Hi Eric;
>
> EGL_KHR_swap_buffers_with_damage is implemented by Android's EGL wrapper
> library so these tests are passing already, no implementation required in
> Mesa side.
Right, I keep forgetting that android intercepts some stuff an
On Tuesday, 2017-06-13 20:01:07 +0200, Nicolas Dechesne wrote:
> On Thu, Jun 1, 2017 at 4:53 PM, Emil Velikov wrote:
> > Should be handled now. See the documentation for future stable nominations
> > [1].
>
> Actually, I don't see the patch in 17.1.2, was it expected?
It was nominated, which (a
+ }
> + ret = draw->ext->image->queryImage(image, __DRI_IMAGE_ATTRIB_STRIDE,
> + &buffer->strides[i]);
> + if (!ret) {
> + if (image != pixmap_buffer)
> +draw->ext->image->destroyI
On Monday, 2017-10-16 07:04:18 +, Louis-Francis Ratté-Boulianne wrote:
> If PresentCompleteNotify event says the pixmap was presented
> with mode PresentCompleteModeSuboptimalCopy, it means the pixmap
> could possibly have been flipped instead if allocated with a
> different format/modifier.
>
On Monday, 2017-10-16 07:04:15 +, Louis-Francis Ratté-Boulianne wrote:
> From: Daniel Stone
>
Patches 3-5 are:
Reviewed-by: Eric Engestrom
> ---
> src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 +++
> src/mesa/drivers/dri/i965/intel_screen.c | 17 +++--
> 2
On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote:
> On 13 October 2017 at 19:49, Harish Krupo wrote:
> > This passes 33/37 deqp tests related to partial_update, 4 are not
> > supported.
> >
> Mildly related:
> Android's .swap_buffers_with_damage seems to be missing. AFAICT should
> be able
On Monday, 2017-10-16 15:37:31 +, Emil Velikov wrote:
> On 16 October 2017 at 16:21, Eric Engestrom wrote:
> > On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote:
> >> On 13 October 2017 at 19:49, Harish Krupo
> >> wrote:
> >> > This passes 33/
On Monday, 2017-10-16 14:28:57 +, Brian Paul wrote:
> On 10/16/2017 04:24 AM, Eric Engestrom wrote:
> > On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote:
> > > The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the
> > > wrong place
> >
>
All 4 other version strings do it like this.
((Also, double parentheses just look confusing))
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/svga/svga_screen.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_screen.c
b/src
world issue).
Verified to work and give the same output as before on both python 2
and 3 :)
Signed-off-by: Eric Engestrom
---
bin/git_sha1_gen.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py
index 87e06a8d9368e7f
On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote:
> Hi Harish,
>
> Overall looks great, a few comments/questions inline.
>
I agree with everything Emil said :)
> On 13 October 2017 at 19:49, Harish Krupo wrote:
> > This passes 33/37 deqp tests related to partial_update, 4 are not
> > s
eRegionKHR
>
> There's something strange happening here. For now simply note about the
> 'lack' of eglSwapBuffersWithDamageKHR support.
>
> Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
> ---
> src/egl/drivers/dri2/platform_android.c | 2 +-
> 1
On Monday, 2017-10-16 16:04:06 +, Emil Velikov wrote:
> From: Emil Velikov
>
> The function can fail. Check and teardown accordingly.
>
> Fixes: a43d286ef7f ("gbm: Add import from fd")
> Cc: Kristian Høgsberg
> Signed-off-by: Emil Velikov
> ---
> src/gbm/backends/dri/gbm_dri.c | 8 +++
301 - 400 of 2141 matches
Mail list logo
