Re: [Mesa-dev] [PATCH 3/3] README: Add note about meson

2018-01-12 Thread Eric Engestrom
On Friday, 2018-01-05 12:01:00 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > README | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index 26cab9d..f3df9ac

Re: [Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

2018-01-15 Thread Eric Engestrom
On Sunday, 2018-01-14 23:59:48 +0200, Grazvydas Ignotas wrote: > Trivial. Found by Coccinelle. Series is: Reviewed-by: Eric Engestrom > --- > src/mesa/drivers/osmesa/osmesa.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/drivers/osmesa/osmesa.c > b/sr

Re: [Mesa-dev] [PATCH v1] egl/android: Implement the eglSwapinterval for Android.

2018-01-16 Thread Eric Engestrom
store the interval in surf->SwapInterval to return it later, which is done here, so I expect it should all pass. With a 7/7 pass on those, and with the comments from Emil addressed, the patch is: Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_android.c | 16 ++

Re: [Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Eric Engestrom
On Tuesday, 2018-01-16 10:36:49 -0500, Chuck Atkins wrote: > When only a single SWR architecture is being used, this allows that > architecture to be builtin rather than as a separate libswrARCH.so that > gets loaded via dlopen. Since there are now several different code > paths for each detected

Re: [Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-16 Thread Eric Engestrom
On Tuesday, 2018-01-16 10:36:50 -0500, Chuck Atkins wrote: > Signed-off-by: Chuck Atkins > CC: Tim Rowley > CC: Bruce Cherniak > --- > src/gallium/drivers/swr/swr_loader.cpp | 41 > +- > 1 file changed, 25 insertions(+), 16 deletions(-) > > diff --git a/src/gal

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Eric Engestrom
t; + value of ANativeWindow::maxSwapInterval. > + */ > + dri2_setup_swap_interval(dpy, 1); My C<->C++ interaction skills are more than rusty, but is it possible to use `ANativeWindow.maxSwapInterval` or something like this? Given that the dEQP tests all pass, whether wi

Re: [Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-18 Thread Eric Engestrom
On Tuesday, 2018-01-16 19:38:25 +, Chuck Atkins wrote: > > > +#define debug_printf(...) if(mesa_debug) { fprintf(stderr, > > __VA_ARGS__); } > > > > `do {} while(0)` > > > > Forgive me but I don't understand, what you're saying here. Sorry, I guess I could've used a few more characters to typ

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 19:07:06 +, Emil Velikov wrote: > On 18 January 2018 at 17:43, Eric Engestrom wrote: > > On Thursday, 2018-01-18 07:52:42 +, Zhongmin Wu wrote: > >> Implement the eglSwapinterval for Android platform to > >> enable the async mode for

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

2018-01-18 Thread Eric Engestrom
r this? One note below (in src/gallium/drivers/swr/Makefile.am), but with that fixed: Acked-by: Eric Engestrom > --- > Makefile.am | 7 ++- > src/Makefile.am | 2 +- > src/amd/Makefile.am

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

2018-01-18 Thread Eric Engestrom
7,6 +57,12 @@ dri_drivers_path = get_option('dri-drivers-path') > if dri_drivers_path == '' >dri_drivers_path = join_paths(get_option('libdir'), 'dri') > endif > +_search = get_option('dri-search-path') > +if _search != '' >

Re: [Mesa-dev] [PATCH 4/5] docs: move untar line in basic testing instructions for coherence

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 23:06:40 +, Andres Gomez wrote: > For scons, windows/mingw dealing with LLVM_CONFIG is done before > untarring. Isn't this a no-op change? > This is also more convenient for copy and paste. No objection though, this and the rest of the series is Rev

Re: [Mesa-dev] [PATCH v2 1/4] meson: fix BSD build

2018-01-19 Thread Eric Engestrom
On Wednesday, 2018-01-17 23:54:15 +0300, Greg V wrote: > Reviewed-by: Dylan Baker A couple questions and a nit-pick for the error messages, but with that: Reviewed-by: Eric Engestrom > --- > meson.build | 44 +++- > 1 file changed, 23 inser

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-19 Thread Eric Engestrom
On Tuesday, 2018-01-16 18:35:40 +, Emil Velikov wrote: > On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: > > Found with the help of following Coccinelle semantic patch: > > // > > @@ > > expression E; > > @@ > > > > \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) > > ... > > (

[Mesa-dev] [PATCH mesa] docs/submittingpatches: add 'test each commit' instructions

2017-09-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/submittingpatches.html | 12 1 file changed, 12 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index ecf9590a95..0581391b29 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html

[Mesa-dev] [PATCH mesa] i965: drop unused variables

2017-09-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/brw_gs.c| 1 - src/mesa/drivers/dri/i965/intel_batchbuffer.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965/brw_gs.c index 5a170de845..179ccc4c6f 100644

Re: [Mesa-dev] [PATCH] travis: replace omx feature flag with omx-bellagio one

2017-09-16 Thread Eric Engestrom
On Saturday, 2017-09-16 17:24:50 +, Andres Gomez wrote: > Fixes: 6a8aa11c207 ("st/omx_bellagio: Rename state tracker and > option") > Signed-off-by: Andres Gomez > Cc: Gurkirpal Singh > Cc: Eric Engestrom Reviewed-by: Eric Engestrom > Cc: Emil Veliko

[Mesa-dev] [PATCH mesa] docs: update sourcetree following omx rename

2017-09-16 Thread Eric Engestrom
Fixes: 6a8aa11c207b99920b93 "st/omx_bellagio: Rename state tracker and option" Cc: Gurkirpal Singh Signed-off-by: Eric Engestrom --- docs/sourcetree.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sourcetree.html b/docs/sourcetree.html index 9448df58c9..

Re: [Mesa-dev] [PATCH] gbm: Add gbm_device_get_format_modifier_plane_count to test

2017-09-16 Thread Eric Engestrom
erence, both are: Reviewed-by: Eric Engestrom I'll let Andres pick which one to land. > --- > Submitter has no mesa-git write access. > > src/gbm/gbm-symbols-check | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-

Re: [Mesa-dev] [PATCH] swr/rast: Fix GetEnv() returned value

2017-09-18 Thread Eric Engestrom
w_bug.cgi?id=101832 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101832 Reviewed-by: Eric Engestrom I could've sworn I had already seen this patch on the ML though? > Fixes: a25093de718 ("swr/rast: Implement JIT shader caching to disk") > --- > src/gallium/dri

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

2017-09-18 Thread Eric Engestrom
rd Rosenkraenzer > [Emil Velikov: make an actual commit from the misc diff] > Signed-off-by: Emil Velikov Laurent just sent this to the ML an hour before you, but this commit message is much better. Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/swr/rasterizer/core/u

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

2017-09-18 Thread Eric Engestrom
llvm-toolchain-trusty-3.7 You can drop this line now :) Don't 4.0 and 5.0 need the same binutils-2.26 as 3.9? Speaking of, I think the OVERRIDE_PATH you added is the only way to do this. With the above fixed or justified, the series is: Reviewed-by: Eric Engestrom One thing before anyone pus

Re: [Mesa-dev] [PATCH 1/7] clover: add missing include to compat.h

2017-09-18 Thread Eric Engestrom
On Saturday, 2017-09-16 22:05:39 -0400, Jan Vesely wrote: > Fixes build issues with llvm-3.6 > Fixes: 3115687f9b9830417c408228db2bc679e346bba6 (clover: Fix build after > LLVM r313390) > > Signed-off-by: Jan Vesely R-b and pushed this with Gert's t-b, without waiting any longer since the build is

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

2017-09-18 Thread Eric Engestrom
On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote: > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote: > > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote: > > > v2: Use direct llvm repo link instead of alias > > > Enable > > &

[Mesa-dev] [PATCH mesa 1/2] glsl: replace conditional compilation with MAYBE_UNUSED

2017-09-18 Thread Eric Engestrom
Suggested-by: Nicolai Hähnle Signed-off-by: Eric Engestrom --- src/compiler/glsl/ir_validate.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index 50d611500c..e368224a9b 100644 --- a/src/compiler

[Mesa-dev] [PATCH mesa 2/2] radv: replace conditional compilation with MAYBE_UNUSED

2017-09-18 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index 8a551c48bb..c9d4bbce8b 100644 --- a/src/amd/vulkan/radv_wsi.c +++ b/src/amd/vulkan/radv_wsi.c @@ -27,12

[Mesa-dev] [PATCH mesa] amdgpu/addrlib: add missing va_end() after va_copy()

2017-09-19 Thread Eric Engestrom
d alignment calculator" Cc: Marek Olšák Signed-off-by: Eric Engestrom --- src/amd/addrlib/core/addrobject.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/addrlib/core/addrobject.cpp b/src/amd/addrlib/core/addrobject.cpp index dcdb1bffc2..390ddd9127 100644 --- a/src/

[Mesa-dev] [PATCH mesa 3/6] scons: use python3-compatible lists

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- SConstruct | 3 +-- scons/custom.py | 8 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/SConstruct b/SConstruct index 0215aa83073f120fe9df..a59a8ea210e956bb67de 100644 --- a/SConstruct +++ b/SConstruct @@ -152,8 +152,7 @@ try

[Mesa-dev] [PATCH mesa 2/6] scons: use python3-compatible list-key check

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/gallium.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scons/gallium.py b/scons/gallium.py index db7764544145accaacf9..9772eb32bf271de6f358 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -193,15 +193,15 @@ def

[Mesa-dev] [PATCH mesa 5/6] scons: use python3-compatible exceptions

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/crossmingw.py | 2 +- scons/dxsdk.py | 2 +- scons/llvm.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scons/crossmingw.py b/scons/crossmingw.py index 34129450a56cdf14d8da..609cd00418e4ce9e8f1d 100644 --- a/scons

[Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index 0767ba936d410167116d..978ee5f9ec7c23a74cb9 100644 --- a/scons/custom.py +++ b/scons/custom.py @@ -257,7 +257,7 @@ def parse_source_list

[Mesa-dev] [PATCH mesa 4/6] scons: use python3-compatible maps

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gallium/drivers/swr/SConscript | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr/SConscript index fdced66463c912048e04..3b624ceccad4fc8bade2 100644 --- a/src/gallium

[Mesa-dev] [PATCH mesa 1/6] scons: use python3-compatible print()

2017-09-19 Thread Eric Engestrom
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102852 Reported-by: Alex Granni Signed-off-by: Eric Engestrom --- SConstruct | 8 scons/gallium.py| 22 +++--- scons/llvm.py | 16

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-19 Thread Eric Engestrom
ch I was the least-sure about. Dropping it from the series. I also just realized I forgot to mention how I generated these changes; I'll add this to the commit messages: These changes were generated using python's `2to3` tool. Cheers, Eric > > On Tue, Sep 19, 2017 at 10:1

[Mesa-dev] [PATCH mesa v2] scons: use python3-compatible exceptions

2017-09-20 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/crossmingw.py | 2 +- scons/dxsdk.py | 2 +- scons/llvm.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scons/crossmingw.py b/scons/crossmingw.py index 34129450a56cdf14d8da..609cd00418e4ce9e8f1d 100644 --- a/scons

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-20 Thread Eric Engestrom
s to remove a handful of platform specific names of the > library. > > Cc: Jonathan Gray > Cc: Jon Turney > Cc: Julien Isorce > Cc: Rob Herring > Cc: Tomasz Figa > Signed-off-by: Emil Velikov Nice cleanup! Assuming the build systems stuff works (with Rob's sug

Re: [Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

2017-09-20 Thread Eric Engestrom
On Tuesday, 2017-09-19 20:33:47 +, Jason Ekstrand wrote: > Fixes: 1d0be5b3fe548ee33d4520092f583c76d42510a6 > Cc: Emil Velikov Reviewed-by: Eric Engestrom > --- > src/egl/wayland/wayland-drm/wayland-drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] amd/addrlib: fix missing va_end() after va_copy()

2017-09-20 Thread Eric Engestrom
ode is indeed unnecessary, so: Reviewed-by: Eric Engestrom Fixes: e7fc664b91a5d886c270 "winsys/amdgpu: add addrlib - texture addressing and alignment calculator" > > CID: 1418113 > --- > I have a slight preference for this variant. > -- > s

Re: [Mesa-dev] [PATCH mesa v2] scons: use python3-compatible exceptions

2017-09-20 Thread Eric Engestrom
Apologies, I didn't double-check what I was sending, and sent the wrong patch... please disregard. On Wednesday, 2017-09-20 10:13:27 +0000, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > scons/crossmingw.py | 2 +- > scons/dxsdk.py | 2 +- > scons/llvm.py

[Mesa-dev] [PATCH mesa v2] scons: use python3-compatible generator

2017-09-20 Thread Eric Engestrom
Suggested-by: Ilia Mirkin Signed-off-by: Eric Engestrom --- v2: use generator instead of list comprehension (Ilia) --- src/gallium/drivers/swr/SConscript | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr

Re: [Mesa-dev] [PATCH] amd/addrlib: fix missing va_end() after va_copy()

2017-09-21 Thread Eric Engestrom
Hmm, just noticed the title should be fixed. Something like this? > amd/addrlib: drop unnecessary va_copy() On Wednesday, 2017-09-20 14:48:46 +, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > There's no reason to use va_copy here. > > CID: 1418113 > --- > I have a slight preference for t

Re: [Mesa-dev] [PATCH] osdemos: support building via cmake

2017-09-22 Thread Eric Engestrom
On Friday, 2017-09-22 11:37:43 +, Tommy wrote: > Uses pkg-config to find osmesa, and builds only if found. Thanks! Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom Do you want me to push this for you? > --- > CMakeLists.txt | 1 + > src/CMakeLists.txt

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-25 Thread Eric Engestrom
On Saturday, 2017-09-23 13:37:29 +0900, Tomasz Figa wrote: > On Wed, Sep 20, 2017 at 7:47 PM, Eric Engestrom > wrote: > > On Tuesday, 2017-09-19 17:19:59 +, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> In order to build EGL, one has to use sha

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-25 Thread Eric Engestrom
I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: > On 19/09/17 15:14, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > scons/custom.py | 2 +- > > 1 file

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-26 Thread Eric Engestrom
On 25 September 2017 12:01:33 BST, Tomasz Figa wrote: > On Mon, Sep 25, 2017 at 7:21 PM, Eric Engestrom > wrote: > > On Saturday, 2017-09-23 13:37:29 +0900, Tomasz Figa wrote: > >> On Wed, Sep 20, 2017 at 7:47 PM, Eric Engestrom > >> wrote: > >> > O

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-26 Thread Eric Engestrom
On Tuesday, 2017-09-19 17:19:59 +, Emil Velikov wrote: > From: Emil Velikov > > In order to build EGL, one has to use shared glapi - libglapi.so. > > Thus the dlopen/dlsym dance is no longer needed and we can link to the > library directly. > > This allows us to remove a handful of platform

Re: [Mesa-dev] [PATCH] vc4: Fix infinite retry in vc4_bo_alloc()

2017-09-26 Thread Eric Engestrom
tion. Reviewed-by: Eric Engestrom Fixes: 78087676c98aa8884ba92 "vc4: Restructure the simulator mode." Cc: Eric Anholt > While we're at it, move the create variable with the other local > variables and explicitly reset its content in the retry path. That was actually change

[Mesa-dev] [PATCH mesa 1/6] egl_dri2: move glFlush out of struct dri2_egl_driver

2017-09-26 Thread Eric Engestrom
There's no reason to store this there, it doesn't depend on the driver. Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 44 ++--- src/egl/drivers/dri2/egl_dri2.h | 2 -- 2 files changed, 19 insertions(+), 27 deletions(-) diff -

[Mesa-dev] [PATCH mesa 0/6] egl: remove unnecessary code

2017-09-26 Thread Eric Engestrom
ps two empty structs, deduplicates some alloc/init code, and removes a redundant memset. Eric Engestrom (6): egl_dri2: move glFlush out of struct dri2_egl_driver egl: replace _egl_driver->Unload() callback with a simple free() egl_dri2: drop dri2_egl_driver struct egl_haiku: drop haiku_egl_dr

[Mesa-dev] [PATCH mesa 5/6] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

2017-09-26 Thread Eric Engestrom
Note: dropping the EGL_BAD_ALLOC in egl_haiku because it's overwritten by the EGL_NOT_INITIALIZED in eglInitialize(). Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 13 ++--- src/egl/drivers/haiku/egl_haiku.cpp | 13 ++--- src/egl/main/READM

[Mesa-dev] [PATCH mesa 2/6] egl: replace _egl_driver->Unload() callback with a simple free()

2017-09-26 Thread Eric Engestrom
Bonus: fixes a memleak on haiku when unloading the driver Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 9 - src/egl/drivers/haiku/egl_haiku.cpp | 9 - src/egl/main/egldriver.c| 5 + src/egl/main/egldriver.h| 7 --- 4

[Mesa-dev] [PATCH mesa 3/6] egl_dri2: drop dri2_egl_driver struct

2017-09-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 101 +++- src/egl/drivers/dri2/egl_dri2.h | 5 -- 2 files changed, 49 insertions(+), 57 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index

[Mesa-dev] [PATCH mesa 4/6] egl_haiku: drop haiku_egl_driver struct

2017-09-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/haiku/egl_haiku.cpp | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index a98470f62d..fea38e76ed 100644 --- a/src

[Mesa-dev] [PATCH mesa 6/6] egl: drop memset(0) of calloc'ed memory

2017-09-26 Thread Eric Engestrom
`_EGLDriver *drv` is a freshly calloc()'ed object, memset(0)'ing some of it is a no-op. Signed-off-by: Eric Engestrom --- src/egl/main/eglfallbacks.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/main/eglfallbacks.c b/src/egl/main/eglfallbacks.c index 1575ab5f79..

Re: [Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

2017-09-27 Thread Eric Engestrom
On Tuesday, 2017-09-26 23:38:11 +, Dylan Baker wrote: > It is possible to have DEBUG disabled but asserts on (NDEBUG(, which parentheses typo other than that: Reviewed-by: Eric Engestrom and I think you should've pushed these first two patches instead of carrying them in your u

[Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Eric Engestrom
Cc: Dylan Baker Signed-off-by: Eric Engestrom --- REVIEWERS | 5 + 1 file changed, 5 insertions(+) diff --git a/REVIEWERS b/REVIEWERS index 0b5d9a4fd31bd652cf02..0d97b29309cc98b9a295 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -103,6 +103,11 @@ F: CleanSpec.mk F: */Android.*mk F

Re: [Mesa-dev] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Eric Engestrom
On Thursday, 2017-09-28 16:10:51 +, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > A tempting alternative fix would be adding a lock/unlock pair in > util_queue_fence_is_signalled. However, that wouldn't actually > improve anything in the semantics of util_queue_fence_is_signalled, > while

Re: [Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Eric Engestrom
elp at first; I guess I'll be "learning on the job" :P > > Otherwise I probably am the guy to look at meson, > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017-09-28 05:37:02) > > Cc: Dylan Baker > > Signed-off-by: Eric Engestrom > > --

Re: [Mesa-dev] [PATCH] util/queue: fix a race condition in the fence code

2017-09-29 Thread Eric Engestrom
On Thursday, 2017-09-28 20:23:16 +0200, Nicolai Hähnle wrote: > On 28.09.2017 18:37, Eric Engestrom wrote: > > On Thursday, 2017-09-28 16:10:51 +, Nicolai Hähnle wrote: > > > From: Nicolai Hähnle > > > > > > A tempting alternative fix w

[Mesa-dev] [PATCH mesa] meson: fix version typo + grammar

2017-09-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5353a4174849334b6db5..02f43eec23092c753002 100644 --- a/meson.build +++ b/meson.build @@ -56,7 +56,7 @@ prog_python2 = find_program('python2&#x

Re: [Mesa-dev] [PATCH v2] meson: change vulkan icd config to - instead of _

2017-10-02 Thread Eric Engestrom
alue : > 'x11,wayland', > description : 'comma separated list of window systems to support. > wayland, x11, surfaceless, drm, etc.') > option('vulkan-drivers', type : 'string', value : 'intel,amd', > descript

[Mesa-dev] [PATCH mesa] egl/wayland: simplify LIBGL_ALWAYS_SOFTWARE logic

2017-10-02 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index ae3347756bc1a4629b69..011dddfabf422f30cb6c 100644

Re: [Mesa-dev] [PATCH] egl/surfaceless: Use KMS swrast fallback

2017-10-02 Thread Eric Engestrom
On Friday, 2017-09-29 23:57:32 +, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > The kms_swrast extension is an actively developed software fallback, > and platform_surfaceless can use it if there are no available > hardware drivers. > --- > src/egl/drivers/dri2/platform_surf

Re: [Mesa-dev] [PATCH 4/5] meson: convert gtest to an internal dependency

2017-10-02 Thread Eric Engestrom
On Sunday, 2017-10-01 03:58:27 +, Dylan Baker wrote: > In truth gtest is an external dependency that upstream expects you to > "vendor" into your own tree. As such, it makes sense to treat it more > like a dependency than an internal library, and collect it's > requirements together in a depend

Re: [Mesa-dev] [PATCH 5/5] travis: add meson build for vulkan drivers.

2017-10-02 Thread Eric Engestrom
der since one is missing on the Travis instance >- mkdir -p linux >- printf "%s\n" \ > @@ -510,3 +540,9 @@ script: >test -n "$OVERRIDE_CXX" && export CXX="$OVERRIDE_CXX"; >scons $SCONS_TARGET && eval $SCONS_CHECK_CO

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Eric Engestrom
On Monday, 2017-10-02 14:16:02 +, Trevor (CIMdata) wrote: > Hello Emil, > Yes, I did see the AppVeyor integraton for MSVC. It could be quite > easy to add the MinGW scope to the metrix. > > I don’t really know how to ‘upsteam’ the patches I use mostly because > I am not the author. Do I just s

Re: [Mesa-dev] [PATCH] util: include stdlib.h in u_string.h to silence MinGW warning

2017-10-03 Thread Eric Engestrom
On Monday, 2017-10-02 22:33:46 +, Brian Paul wrote: > Otherwise we don't get a prototype for malloc(). Reviewed-by: Eric Engestrom and pushed. > --- > src/util/u_string.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/u_string.h b/src/util/u_s

Re: [Mesa-dev] [PATCH] android: fix build issues with brw_nir_trig_workarounds.c

2017-10-03 Thread Eric Engestrom
On Tuesday, 2017-10-03 08:08:49 +, Tapani Pälli wrote: > Fixes: 848da66222 ("intel: use a flag instead of setting PYTHONPATH") > Signed-off-by: Tapani Pälli Reviewed-by: Eric Engestrom > --- > src/intel/Android.compiler.mk | 2 +- > 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 2/2] egl/surfaceless: Use KMS swrast fallback

2017-10-03 Thread Eric Engestrom
t into 2 patches, use booleans, check LIBGL_ALWAYS_SOFTWARE, > and modify the eglLog level (Emil, Eric, Tomasz). Thanks, this is perfect :) Reviewed-by: Eric Engestrom Do you want me to push this for you? It might be worth running deqp and other test suites to make sure everything is wired u

Re: [Mesa-dev] [PATCH] travis: add meson build for vulkan drivers.

2017-10-03 Thread Eric Engestrom
port CXX="$OVERRIDE_CXX"; >scons $SCONS_TARGET && eval $SCONS_CHECK_COMMAND; > fi > + > + - if test "x$BUILD" = xmeson; then > + export CC="$CC -isystem`pwd`"; I also missed that in the make script :] I'd feel mor

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

2017-10-03 Thread Eric Engestrom
On Friday, 2017-09-29 16:32:36 +, Jan Vesely wrote: > On Mon, 2017-09-18 at 16:46 +0100, Eric Engestrom wrote: > > On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote: > > > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote: > > > > On Sunday, 2017-09

Re: [Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

2017-10-03 Thread Eric Engestrom
On Tuesday, 2017-10-03 12:28:54 -0400, Jan Vesely wrote: > On Tue, 2017-10-03 at 17:26 +0100, Eric Engestrom wrote: > > On Friday, 2017-09-29 16:32:36 +, Jan Vesely wrote: > > > On Mon, 2017-09-18 at 16:46 +0100, Eric Engestrom wrote: > > > > On Monday, 2017-09

Re: [Mesa-dev] [PATCH 2/2] egl/surfaceless: Use KMS swrast fallback

2017-10-03 Thread Eric Engestrom
hset as well. You mean deqp, or another one? I assume the results were "100% success"? > > Best wishes, > Gurchetan > > On Tue, Oct 3, 2017 at 7:02 AM, Eric Engestrom > wrote: > > > On Monday, 2017-10-02 20:48:24 +, gurchetansi...@chromium.org wrote: > &

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

2017-10-03 Thread Eric Engestrom
ely > Cc: Aaron Watry > Cc: Francisco Jerez > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom Can you add a link to the ML discussion? > --- > Vedran can we volunteer you for the cleanup ;-) > --- > .travis.yml | 38 -- >

[Mesa-dev] [PATCH mesa] travis: move include path from $CC to $CFLAGS

2017-10-04 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2c87f60ec12c7a287a2c..19fd6acf3b9e4d6d9a8e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -507,7 +507,7 @@ script: test -n "$OVERRID

Re: [Mesa-dev] [PATCH mesa] travis: move include path from $CC to $CFLAGS

2017-10-04 Thread Eric Engestrom
On Wednesday, 2017-10-04 14:23:46 +0100, Emil Velikov wrote: > On 4 October 2017 at 14:10, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > Considering things still work (I'll push the wayland fix in a second) Yeah, it worked for the meson build, but the make one is

Re: [Mesa-dev] [PATCH v3 05/22] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper

2017-10-04 Thread Eric Engestrom
On Wednesday, 2017-10-04 06:50:17 +, Gwan-gyeong Mun wrote: > To share common free outdated buffers and update size code. > This compares width and height arguments with current egl surface dimension, > if the compared surface dimension is differ, then it free local buffers and > updates dimens

Re: [Mesa-dev] [PATCH v3 22/22] docs: add a high level info about Tizen / Tizen Porting Layer (TPL) for EGL / Tizen Buffer Manager (TBM) / etc

2017-10-04 Thread Eric Engestrom
On Wednesday, 2017-10-04 06:50:34 +, Gwan-gyeong Mun wrote: > It gives a quick overview and references of developing OpenGLES / EGL > Driver for Tizen. Thanks for that; haven't read through it, but it should be quite useful :) One request below. > > Signed-off-by: Mun Gwan-gyeong > --- > d

Re: [Mesa-dev] [PATCH 5/7] configure.ac: add llvm_add_optional_component helper

2017-10-05 Thread Eric Engestrom
On Thursday, 2017-10-05 10:19:07 +, Emil Velikov wrote: > From: Emil Velikov > > We want to add "optional" components, which have been added with later > LLVM versions. > > One such in-tree example is inteljitevents. Others are to follow > shortly. > > Cc: mesa-sta...@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 5/6] st_api: remove unused get_resource_for_egl_image

2017-10-09 Thread Eric Engestrom
ook up and return the info of a resource for EGLImage. > -* > -* This function is optional. > -*/ > - boolean (*get_resource_for_egl_image)(struct st_context_iface *stctxi, > - struct st_context_resource *stres); This will break th

Re: [Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-10 Thread Eric Engestrom
it SHA1 with git rev-parse.""" > > +git_dir = os.path.join(os.path.dirname(sys.argv[0]), '..', '.git') > > +try: > > +git_sha1 = subprocess.check_output([ > > +'git', > > +'--

Re: [Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

2017-10-10 Thread Eric Engestrom
#x27;t threaded so I missed it, but my r-b applies to v2 too: Reviewed-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 39 ++- > 1 file changed, 26 insertions(+), 13 deletions(-) > > diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen

Re: [Mesa-dev] [PATCH] eglmesaext: add forward declaration for struct wl_buffers

2017-10-12 Thread Eric Engestrom
oving the deprecation warning coming from the Wayland > headers. > > Cc: Greg V > Fixes: 5cddb1ce3c9 ("wayland: Add an extension to create wl_buffers from > EGLImages") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103225 > Signed-off-by: Emil Velikov Re

[Mesa-dev] [PATCH mesa] egl: remove left over _EGLMain_t

2017-10-12 Thread Eric Engestrom
Fixes: b174a1ae720cb404738c "egl: Simplify the "driver" interface" Cc: Adam Jackson Signed-off-by: Eric Engestrom --- src/egl/main/egldriver.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/main/egldriver.h b/src/egl/main/egldriver.h index

Re: [Mesa-dev] [PATCH mesa] egl: remove left over _EGLMain_t

2017-10-12 Thread Eric Engestrom
On Thursday, 2017-10-12 13:38:47 +, Emil Velikov wrote: > On 12 October 2017 at 14:32, Eric Engestrom wrote: > > Fixes: b174a1ae720cb404738c "egl: Simplify the "driver" interface" > > Cc: Adam Jackson > > Signed-off-by: Eric Engestrom > Out of cu

[Mesa-dev] [PATCH mesa v2 1/3] egl_dri2: move glFlush out of struct dri2_egl_driver

2017-10-12 Thread Eric Engestrom
From: Eric Engestrom There's no reason to store this there, it doesn't depend on the driver. Signed-off-by: Eric Engestrom --- v2: add lock around setting `glFlush` (Emil) --- src/egl/drivers/dri2/egl_dri2.c | 47 +++-- src/egl/drivers/dri2/egl_d

Re: [Mesa-dev] [PATCH mesa v2 1/3] egl_dri2: move glFlush out of struct dri2_egl_driver

2017-10-12 Thread Eric Engestrom
Sorry, misleading subject line: I'm only sending this patch in v2 as the rest of them don't change. On Thursday, 2017-10-12 15:05:01 +0000, Eric Engestrom wrote: > From: Eric Engestrom > > There's no reason to store this there, it doesn't depend on the driver. >

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Eric Engestrom
On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: > The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the > wrong place Can you explain why this was wrong, so that one doesn't make the same mistake next time? Maybe add that as a comment atop the array? (Is it a simple case of "a

[Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-05 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/common/drirc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index af84ee82e8..97297b7a1c 100644 --- a/src/mesa/drivers/dri/common

Re: [Mesa-dev] [PATCH] gbm-dri: Duplicate image after checking its format.

2017-01-23 Thread Eric Engestrom
igned-off-by: Mateusz Polrola You are correct, so this patch is: Reviewed-by: Eric Engestrom However, when I looked at the code, it looks like a lot more places leak `image`. I'll send another patch in a minute (to be applied on top of yours). Cheers, Eric > --- > src/gbm/back

[Mesa-dev] [PATCH mesa] gbm/dri: fix memory leaks in error path

2017-01-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_dri.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 45cb42a862..ef96185848 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-23 Thread Eric Engestrom
On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: > Reviewed-by: Edward O'Callaghan Thanks; can you push this for me please? Cheers, Eric > > On 01/06/2017 08:06 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > s

[Mesa-dev] [PATCH mesa 2/2] egl: EGL_PLATFORM_SURFACELESS_MESA is now upstream

2017-01-24 Thread Eric Engestrom
EGL_PLATFORM_SURFACELESS_MESA is in eglext.h as of last commit. Signed-off-by: Eric Engestrom --- include/EGL/eglmesaext.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h index 405d0e9ee4..3a1b88e3d1 100644 --- a/include/EGL

[Mesa-dev] [PATCH mesa 1/2] egl: update headers from registry

2017-01-24 Thread Eric Engestrom
Khronos introduced a new macro (suggested by Google) to avoid using C-style casts in C++ code, as those generate warnings. Khronos Bugzilla: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16113 Signed-off-by: Eric Engestrom --- include/EGL/egl.h | 24 +++--- include/EGL/eglext.h

Re: [Mesa-dev] [PATCH 1/9] android: always set __STDC_*_MACROS for C++ sources

2017-01-26 Thread Eric Engestrom
t; > Cc: Rob Herring > Cc: Chih-Wei Huang > Signed-off-by: Emil Velikov Assuming android and scons behave as expected, the series is: Reviewed-by: Eric Engestrom ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: don't assert on out of memory descriptor pool in debug mode

2017-01-26 Thread Eric Engestrom
On Thursday, 2017-01-26 11:27:00 +, Lionel Landwerlin wrote: > Fixes: >dEQP-VK.api.descriptor_pool.out_of_pool_memory > > Signed-off-by: Lionel Landwerlin Reviewed-by: Eric Engestrom But is there any reason not to add support for all the other errors in vulkan.h as well

[Mesa-dev] [PATCH mesa 1/2] anv: add missing core errors in vk_errorf()

2017-01-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c index 5fbc7cc113..289d01ecb0 100644 --- a/src/intel/vulkan/anv_util.c +++ b/src/intel/vulkan/anv_util.c @@ -82,7 +82,10

[Mesa-dev] [PATCH mesa 2/2] anv: add missing extension errors in vk_errorf()

2017-01-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Feel free to reject this if you prefer to add extension errors when each extension is implemented :) --- src/intel/vulkan/anv_util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c index

[Mesa-dev] [PATCH mesa 1/2] radv: add missing core errors in vk_errorf()

2017-01-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Similar to the anvil series: https://lists.freedesktop.org/archives/mesa-dev/2017-January/142187.html --- src/amd/vulkan/radv_util.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/vulkan/radv_util.c index c642bb7539

[Mesa-dev] [PATCH mesa 2/2] radv: add missing extension errors in vk_errorf()

2017-01-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Feel free to reject this if you prefer to add extension errors when each extension is implemented :) --- src/amd/vulkan/radv_util.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/vulkan/radv_util.c index

[Mesa-dev] [PATCH mesa] docs/repository: fix name of main branch

2017-01-26 Thread Eric Engestrom
This is git, not svn :P Signed-off-by: Eric Engestrom --- I also noticed some difference between this file and the one on mesa3d.org; it might be worth making sure everything is sync'ed between the two (most likely just push the version on git to the webserver). --- docs/repository.htm

<    5   6   7   8   9   10   11   12   13   14   >