Re: [Mesa-dev] [PATCH] mesa: Allow setting GL_TEXTURE_MAX_LEVEL to 0 with GL_TEXTURE_RECTANGLE.

2014-04-01 Thread Iago Toral
On Mon, 2014-03-31 at 08:10 -0600, Brian Paul wrote: On 03/31/2014 02:04 AM, Iago Toral Quiroga wrote: Currently, we raise an error when doing this which breaks a conformance test from the OpenGL samples pack. Even if this is a bit silly it is not an error. From https

Re: [Mesa-dev] [BUG] mesa/mesa fails to build

2014-04-08 Thread Iago Toral
Hi Knut, this should be now fixed in master by commit dff3439fef8690192bcc40108729da711fcf706b. Thanks, Iago On Tue, 2014-04-08 at 10:49 +0200, Knut Petersen wrote: Building fails in i830_state.c Broken version: 73f80c20f68cd30421c13da29d7d7801ed096101 Last known good version:

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Iago Toral
Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net wrote: Iago Toral Quiroga ito...@igalia.com writes: Commit 11baad35088dfd4bdabc1710df650dbfb413e7a3 produces a regression when switching a single context

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-10 Thread Iago Toral
On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net wrote: Iago Toral Quiroga ito...@igalia.com writes: Commit

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-11 Thread Iago Toral
On Thu, 2014-04-10 at 12:22 -0700, Ian Romanick wrote: On 04/10/2014 03:39 AM, Iago Toral wrote: On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: Hi Kristian, On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt e...@anholt.net

Re: [Mesa-dev] [PATCH] glsl: Small optimization for constant conditionals

2014-04-17 Thread Iago Toral
Hi Kenneth, El 2014-04-17 08:57, Kenneth Graunke escribió: On 04/15/2014 03:30 AM, Iago Toral Quiroga wrote: Once the relevant branch has been identified do not iterate over the instructions in the branch, do a linked list insertion instead to avoid the loop. --- src/glsl

Re: [Mesa-dev] [PATCH] i965: Relax accumulator dependency scheduling on Gen 6

2014-05-07 Thread Iago Toral
On Tue, 2014-05-06 at 11:45 -0700, Matt Turner wrote: Nice work. On Tue, May 6, 2014 at 1:16 AM, Iago Toral Quiroga ito...@igalia.com wrote: diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 6e74803..37d3eab 100644 --- a/src/mesa

Re: [Mesa-dev] [PATCH v2] i965: Relax accumulator dependency scheduling on Gen 6

2014-05-13 Thread Iago Toral
+0200, Iago Toral Quiroga wrote: Many instructions implicitly update the accumulator on Gen 6. The instruction scheduling code just calls add_barrier_deps() for each accumulator access on these platforms, but a large class of operations don't actually update the accumulator -- mostly move

[Mesa-dev] i965: Need help testing patches to fix bogus antaliasing in Gen4/Gen5

2014-05-23 Thread Iago Toral
Hi, Short story: I have two implementations of a patch to fix this bug: https://bugs.freedesktop.org/show_bug.cgi?id=78679 I would need help testing both on Gen4 (I don't have Gen4 hardware available) and I would also like to understand why only on of them works on Gen5. There is a patch making

Re: [Mesa-dev] [PATCH 2/3] i965: Add runtime checks for line antialiasing in Gen 6.

2014-05-29 Thread Iago Toral
Hi Kenneth, On Wed, 2014-05-28 at 12:42 -0700, Kenneth Graunke wrote: On 05/27/2014 03:50 AM, Iago Toral Quiroga wrote: In Gen 6 the hardware generates a runtime bit that indicates whether AA data has to be sent as part of the framebuffer write SEND message. This affects

Re: [Mesa-dev] [PATCH 2/3] i965: Add runtime checks for line antialiasing in Gen 6.

2014-06-03 Thread Iago Toral
On Thu, 2014-05-29 at 08:31 -0700, Kenneth Graunke wrote: (...) + emit(IF(BRW_PREDICATE_NORMAL)); + { + /* Shift message header one register since we are not sending + * AA data stored in base_mrf+2 + */ + do_emit_fb_write(target, base_mrf +

Re: [Mesa-dev] [PATCH v2 1/4] i965: Always set a valid block end pointer

2014-06-09 Thread Iago Toral
On Mon, 2014-06-09 at 02:22 -0700, Kenneth Graunke wrote: On Thursday, June 05, 2014 03:03:05 PM Iago Toral Quiroga wrote: When a instruction stream ends in a block structure (like a IF/ELSE/ENDIF) the last block's end pointer will not be set, leading to a crash later

Re: [Mesa-dev] [PATCH v2 4/4] i965/fs: Add Gen 6 runtime checks for line antialiasing.

2014-06-09 Thread Iago Toral
On Mon, 2014-06-09 at 02:31 -0700, Kenneth Graunke wrote: On Thursday, June 05, 2014 03:03:08 PM Iago Toral Quiroga wrote: In Gen 6 the hardware generates a runtime bit that indicates whether AA data has to be sent as part of the framebuffer write SEND message. This affects

Re: [Mesa-dev] [PATCH 1/2] i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

2014-06-11 Thread Iago Toral
state first, and force it again around the single MOV. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Iago Toral Quiroga ito...@igalia.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) I originally Piglit those

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-11 Thread Iago Toral
this with a standalone program. We will check what already exists in piglit and add missing test cases. Iago -- Chris On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote: This series brings multi-stream support to geometry shaders as defined by ARB_gpu_shader5. It also covers

Re: [Mesa-dev] [PATCH 05/18] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-11 Thread Iago Toral
. On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote: Outputs that are linked to inputs in the next stage must be output to stream 0, otherwise we should fail to link. --- src/glsl/link_varyings.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 05/18] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-12 Thread Iago Toral
; } On Thu, 2014-06-12 at 07:43 +1200, Chris Forbes wrote: I had misread it -- yes, this looks correct. On Thu, Jun 12, 2014 at 12:02 AM, Iago Toral ito...@igalia.com wrote: I am a bit confused here: Reading the code it looks like input_var should be NULL if there is no consumer stage

Re: [Mesa-dev] [PATCH 11/18] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-13 Thread Iago Toral
then get inlined like any other function leaving a bare ir_emit_vertex / ir_end_primitive with a constant operand. If one of the optimization passes eats that, then it's broken. On Wed, Jun 11, 2014 at 7:49 PM, Iago Toral Quiroga ito...@igalia.com wrote: --- src/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH 11/18] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-13 Thread Iago Toral
is detroyed or not. Iago On Fri, 2014-06-13 at 10:09 +0200, Iago Toral wrote: After debugging I have more information about what is going on. There are two problems, one is that the stream variable in ir_emit_vertex gets trashed and the other one is that even if we manage to avoid that it won't get its

Re: [Mesa-dev] [PATCH 11/18] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-13 Thread Iago Toral
On Fri, 2014-06-13 at 10:28 +0200, Iago Toral wrote: I forgot to add an important piece of info. I also had to add this in the opt_dead_code.cpp, do_dead_code(): if (strcmp(entry-var-name, stream) == 0) continue; without that, the variable referenced by ir_emit_vertex() gets trashed

Re: [Mesa-dev] [PATCH 11/18] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-16 Thread Iago Toral
. On Fri, Jun 13, 2014 at 11:52 PM, Iago Toral ito...@igalia.com wrote: On Fri, 2014-06-13 at 10:28 +0200, Iago Toral wrote: I forgot to add an important piece of info. I also had to add this in the opt_dead_code.cpp, do_dead_code(): if (strcmp(entry-var-name, stream) == 0

Re: [Mesa-dev] [PATCH] glsl: Expand matrix flip optimization pass to cover more cases.

2014-06-17 Thread Iago Toral
Hi Ian, On Mon, 2014-06-16 at 12:20 -0700, Ian Romanick wrote: On 04/21/2014 04:38 AM, Iago Toral Quiroga wrote: Currently it only considers the cases of gl_ModelViewProjectionMatrix and gl_TextureMatrix. The same optimization can be done also for gl_ModelViewMatrix, gl_ProjectionMatrix

Re: [Mesa-dev] [PATCH v2] glsl: Expand matrix flip optimization pass to cover more cases.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 14:43 -0700, Ian Romanick wrote: On 06/18/2014 05:03 AM, Iago Toral Quiroga wrote: Also, as suggested by Ian Romanick, make it so we don't need a bunch of individual handles to flippable matrices, instead we register matrix/transpose_matrix pairs in a hash table

Re: [Mesa-dev] [PATCH v2 04/23] glsl: Assign GLSL StreamIds to transform feedback outputs.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 12:56 -0700, Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Inter-shader outputs must be on stream 0, which is the default. --- src/glsl/link_varyings.cpp | 12 +--- src/glsl/link_varyings.h | 7 +++ 2 files changed, 16

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Check if non-zero streams are used. Fail to link if emitting to unsupported streams or emitting to non-zero streams with output type other than GL_POINTS. --- src/glsl/linker.cpp

Re: [Mesa-dev] [PATCH v2 22/23] mesa: Init Geom.UsesEndPrimitive in shader programs.

2014-06-19 Thread Iago Toral
need to do something else other than adding the CC tag in the commit message? Should I send the patch also to mesa-sta...@lists.freedesktop.org? Iago This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/mesa/main

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:05 -0700, Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: On Intel hardware when a geometry shader outputs GL_POINTS primitives we only need to emit vertex control bits if it emits vertices to non-zero streams, so use a flag to track

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: This patch should be split into several patches: 1. Modify ir_emit_vertex to have a stream. This patch also needs to update ir_to_mesa.cpp and st_glsl_to_tgsi.cpp. 2. Modify ir_end_primitive to have a stream. This patch also needs to

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 11:16 -0700, Ian Romanick wrote: (...) Please replace this comment with the following spec quotation: /* Section 4.3.8.2 (Output Layout Qualifiers) of the OpenGL 4.00 I think you meant the GLSL spec. * spec says: * * If

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
ir_end_primitive to have a stream. This patch also needs to update ir_to_mesa.cpp and st_glsl_to_tgsi.cpp. 3. Add the new built-in functions. A couple other minor comments below... On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/glsl/builtin_functions.cpp | 52

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-19 Thread Iago Toral
Samuel has reminded me that Ilia has already done some changes to Gallium in order to check a piglit test for multi-stream support there, so adding to the CC. On Thu, 2014-06-19 at 12:37 +0200, Iago Toral wrote: After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I have some

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-20 Thread Iago Toral
On Thu, 2014-06-19 at 15:18 -0700, Ian Romanick wrote: On 06/19/2014 03:37 AM, Iago Toral wrote: After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I have some comments and questions about this: On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote: This patch should

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-20 Thread Iago Toral
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: (...) + /* From the ARB_gpu_shader5 spec: + * + * Multiple vertex streams are supported only if the output primitive + *type is declared to be points

Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

2014-06-24 Thread Iago Toral
review Iago El 2014-06-18 11:51, Iago Toral Quiroga escribió: This series addresses review comments of the previous version and adds a few things. Summary of the changes in version 2: Patch 1: - Ian: multiple layout(location=) qualifiers + This was not a problem in the end. - Chris: s

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-25 Thread Iago Toral
will increment. -- Chris On Wed, Jun 18, 2014 at 9:51 PM, Iago Toral Quiroga ito...@igalia.com wrote: So far we have been using CL_INVOCATION_COUNT to resolve this query but this is no good with streams, as only stream 0 reaches the clipping stage. From ARB_transform_feedback3

[Mesa-dev] i965: possible hardware bug affecting multi-stream support

2014-06-26 Thread Iago Toral
Hello, while testing various scenarios for multi-stream support in geometry shaders I came across one that I think might be a hardware bug, or at the very least, a hardware limitation that creates a problem to implement correct behavior according to ARB_transform_feedback3. The conflictive

Re: [Mesa-dev] i965: possible hardware bug affecting multi-stream support

2014-06-27 Thread Iago Toral
not do anything in EmitStreamVertex if there are no varyings captured to that stream? On Thu, Jun 26, 2014 at 10:26 PM, Iago Toral ito...@igalia.com wrote: Hello, while testing various scenarios for multi-stream support in geometry shaders I came across one that I think might be a hardware

Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

2014-06-29 Thread Iago Toral
it if they could be pushed out, even if you're still working out hw-related issues with i965 so that the gallium mesa/st integration work can be pushed out as well. Thanks, -ilia On Tue, Jun 24, 2014 at 4:10 AM, Iago Toral ito...@igalia.com wrote: Hi, this is a summary

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
On Wed, 2014-07-02 at 08:49 +0200, Iago Toral wrote: Hello Kenneth, Steven: On Tue, 2014-07-01 at 17:25 -0700, Kenneth Graunke wrote: Previously, we only emitted 3DSTATE_SO_BUFFER and 3DSTATE_SO_DECL_LIST when transform feedback was active. When it was inactive, we disabled the SOL

Re: [Mesa-dev] [PATCH 2/2] i965: Disable SOL buffers and decls when not doing transform feedback.

2014-07-02 Thread Iago Toral
better: https://bugs.freedesktop.org/attachment.cgi?id=102118 Iago On Wed, 2014-07-02 at 10:09 +0200, Iago Toral wrote: On Wed, 2014-07-02 at 08:49 +0200, Iago Toral wrote: Hello Kenneth, Steven: On Tue, 2014-07-01 at 17:25 -0700, Kenneth Graunke wrote: Previously, we only emitted

[Mesa-dev] i965: overwriting parts of a register and optimization passes

2014-07-08 Thread Iago Toral
Hi, I have some code that first initializes a register and then overwrites a specific subregister. However, after the optimization passes in brw_vec4.cpp the initialization instruction goes away. I see that live intervals are computed for the destination register without considering if we

Re: [Mesa-dev] i965: overwriting parts of a register and optimization passes

2014-07-10 Thread Iago Toral
Hi Kenneth, El 2014-07-09 17:19, Kenneth Graunke escribió: On Tuesday, July 08, 2014 11:19:38 AM Iago Toral wrote: Hi, I have some code that first initializes a register and then overwrites a specific subregister. However, after the optimization passes in brw_vec4.cpp

Re: [Mesa-dev] [PATCH 37/37] i965/gen6: enable OpenGL 3.2

2014-08-14 Thread Iago Toral
Hi Mike, I don't really know, probably someone from Intel should confirm this. Iago On Thu, 2014-08-14 at 14:14 +0100, Mike Lothian wrote: Isn't everything already added for GL 3.3? On 14 Aug 2014 12:13, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH 00/37] Geometry shader support in Sandy Bridge

2014-08-20 Thread Iago Toral
El 2014-08-16 09:11, Jordan Justen escribió: On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga ito...@igalia.com wrote: Hi, this series brings support for geometry shaders in Sandy Bridge (gen6) and is combined work from Samuel and myself. A few notes: 1.- Some patches have been based

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in builtin_builder::_image_prototype.

2014-10-06 Thread Iago Toral
On Fri, 2014-10-03 at 13:27 +0300, Francisco Jerez wrote: Kenneth Graunke kenn...@whitecape.org writes: On Thursday, October 02, 2014 11:28:35 AM Ian Romanick wrote: Since this is Curro's code, I'm CC'ing me. On 10/01/2014 03:12 AM, Iago Toral Quiroga wrote: in_var calls

Re: [Mesa-dev] [PATCH] mesa/main: Fix unpack_R5G6B5_UNORM.

2014-10-07 Thread Iago Toral
El 2014-10-07 21:46, Jason Ekstrand escribió: On Oct 7, 2014 12:04 PM, Iago Toral Quiroga ito...@igalia.com wrote: There is a comment warning about the fact that this is not doing what we expect, so fix it. This should be doing the same as unpack_B5G6R5_UNORM but swapping B and R

Re: [Mesa-dev] [PATCH] mesa/main: Fix unpack_R5G6B5_UNORM.

2014-10-24 Thread Iago Toral
El 2014-10-08 07:11, Jason Ekstrand escribió: On Oct 8, 2014 6:36 AM, Iago Toral ito...@igalia.com wrote: El 2014-10-07 21:46, Jason Ekstrand escribió: On Oct 7, 2014 12:04 PM, Iago Toral Quiroga ito...@igalia.com wrote:     There is a comment warning about the fact

Re: [Mesa-dev] [PULL] i965: rename brw_gs - brw_ff_gs; rename brw_vec4_gs - brw_gs.

2014-10-29 Thread Iago Toral
On Tue, 2014-10-28 at 19:27 -0700, Kenneth Graunke wrote: Hello, I'd like to rename some files in i965: - brw_gs.c - brw_ff_gs.c - brw_gs.h - brw_ff_gs.h - brw_gs_emit.c - brw_ff_gs_emit.c - brw_vec4_gs.c - brw_gs.c - brw_vec4_gs.h - brw_gs.h The current brw_gs files are

Re: [Mesa-dev] [PATCH 00/20] Auto-generate pack/unpack functions

2014-11-18 Thread Iago Toral
it from that link too if it does not reach the list in the end. Iago On Tue, 2014-11-18 at 09:43 +0100, Iago Toral Quiroga wrote: This is the fist of two series of patches to address: https://bugs.freedesktop.org/show_bug.cgi?id=84566 The idea is that we have a lot of format conversion code

Re: [Mesa-dev] [PATCH 09/20] mesa: Add a concept of an array format

2014-11-18 Thread Iago Toral
On Tue, 2014-11-18 at 10:46 -0800, Jason Ekstrand wrote: On Tue, Nov 18, 2014 at 12:43 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Jason Ekstrand jason.ekstr...@intel.com An array format is a 32-bit integer format identifier that can represent

Re: [Mesa-dev] [PATCH 16/29] mesa: use master conversion function to implement get_tex_rgba_uncompressed()

2014-11-18 Thread Iago Toral
On Tue, 2014-11-18 at 08:00 -0700, Brian Paul wrote: On 11/18/2014 02:23 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com This covers glGetTexImage for uncompressed color formats. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com Signed

Re: [Mesa-dev] [PATCH 00/20] Auto-generate pack/unpack functions

2014-11-19 Thread Iago Toral
. Thanks for looking into these patches so fast! Iago --Jason On Tue, Nov 18, 2014 at 12:43 AM, Iago Toral Quiroga ito...@igalia.com wrote: This is the fist of two series of patches to address: https://bugs.freedesktop.org/show_bug.cgi?id=84566 The idea

Re: [Mesa-dev] [PATCH 00/20] Auto-generate pack/unpack functions

2014-11-19 Thread Iago Toral
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote: On 18.11.2014 17:43, Iago Toral Quiroga wrote: For software drivers we worked with a trimmed set of piglit tests (related to format conversion), ~5700 tests selected with the following filter: -t format -t color -t tex -t image

Re: [Mesa-dev] Using the 'f' suffix to create a float from an integer literal

2014-11-19 Thread Iago Toral
On Wed, 2014-11-19 at 10:27 -0800, Ian Romanick wrote: On 11/19/2014 03:47 AM, Iago Toral Quiroga wrote: Hi, I came across a GLSL test that checks that doing something like this in a shader should fail: Is this one of the dEQP tests? Yes. float value = 1f; It seems like we have

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-19 Thread Iago Toral
to set this to true. Iago On Wed, 2014-11-19 at 11:31 -0800, Jason Ekstrand wrote: I'm not sure what I think about this. Does it make a functional change other than consistancy? --Jason On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: In order

Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-19 Thread Iago Toral
that it only cared for the base format in these two scenarios, so I thought that maybe the conversions cases that could be affected are all handled in those two paths. I'll check again though, just in case I missed something. On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote

Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-19 Thread Iago Toral
value of 1. That's correct. In the implementation of readpixels and getteximage we had to rebase the results in some cases to account for that. Iago On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: In general, if the dst base internal format

Re: [Mesa-dev] [PATCH 09/29] mesa: Add _mesa_swap2_copy and _mesa_swap4_copy

2014-11-20 Thread Iago Toral
to the other version. Do you prefer the other solution? Iago On Wed, 2014-11-19 at 12:00 -0800, Jason Ekstrand wrote: Any reason why you added 2 new functions, instead of just altering the ones we have and updating where they are used? On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-20 Thread Iago Toral
On Wed, 2014-11-19 at 12:04 -0800, Jason Ekstrand wrote: Can you remind me again as to what formats hit these paths? I remember you hitting them, but I'm still not really seeing how it happens. --Jason On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote

Re: [Mesa-dev] [PATCH 07/29] mesa: Add helper to convert a GL format and type to a mesa (array) format.

2014-11-20 Thread Iago Toral
On Wed, 2014-11-19 at 12:11 -0800, Jason Ekstrand wrote: General comment: Maybe this would be better in gltypes rather than in mesa_formats Ok, I'll move it. On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: --- src/mesa/main/formats.c | 285

Re: [Mesa-dev] [PATCH 09/29] mesa: Add _mesa_swap2_copy and _mesa_swap4_copy

2014-11-20 Thread Iago Toral
On Wed, 2014-11-19 at 14:15 -0600, Patrick Baggett wrote: On Tue, Nov 18, 2014 at 3:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: We have _mesa_swap{2,4} but these do in-place byte-swapping only. The new functions receive an extra parameter so we can swap

Re: [Mesa-dev] [PATCH 14/20] mesa: Add non-normalized formats support for ubyte packing functions

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 08:15 +0100, Samuel Iglesias Gonsálvez wrote: On Tue, 2014-11-18 at 11:08 -0800, Jason Ekstrand wrote: On Tue, Nov 18, 2014 at 12:44 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com

Re: [Mesa-dev] Using the 'f' suffix to create a float from an integer literal

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 08:08 +0100, Iago Toral wrote: On Wed, 2014-11-19 at 10:27 -0800, Ian Romanick wrote: On 11/19/2014 03:47 AM, Iago Toral Quiroga wrote: Hi, I came across a GLSL test that checks that doing something like this in a shader should fail: Is this one

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-20 Thread Iago Toral
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Jason Ekstrand jason.ekstr...@intel.com v2 by Iago Toral ito...@igalia.com: - When testing if we can directly pack we should use the src format to check

Re: [Mesa-dev] [PATCH 05/29] mesa: Consider internal base format in _mesa_format_convert

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 08:42 +0100, Iago Toral wrote: On Wed, 2014-11-19 at 11:43 -0800, Jason Ekstrand wrote: A couple of specific comments are below. More generally, why are you only considering the base format on two cases? Do we never use it for anything else? I thought about

Re: [Mesa-dev] [PATCH 06/29] mesa: Avoid pack/unpack fast paths if base internal format != base format

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 10:49 -0800, Jason Ekstrand wrote: On Wed, Nov 19, 2014 at 11:58 PM, Iago Toral ito...@igalia.com wrote: On Wed, 2014-11-19 at 11:57 -0800, Jason Ekstrand wrote: A couple of general comments on this patch: 1

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 10:40 -0800, Jason Ekstrand wrote: On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral ito...@igalia.com wrote: Hi Jason, we discussed this some weeks ago actually, the detailed explanation is here: https

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-21 Thread Iago Toral
On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote: On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral ito...@igalia.com wrote: On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote: By and large, this looks good to me. Most of my comments are cosmetic

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-21 Thread Iago Toral
On Fri, 2014-11-21 at 17:40 +0900, Michel Dänzer wrote: On 21.11.2014 17:07, Iago Toral wrote: On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote: On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral ito...@igalia.com wrote: Just out of curiosity: is there any gain in avoiding the GL

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-21 Thread Iago Toral
On Thu, 2014-11-20 at 21:35 -0800, Jason Ekstrand wrote: On Thu, Nov 20, 2014 at 9:33 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral ito...@igalia.com wrote: It is explained here

Re: [Mesa-dev] Using the 'f' suffix to create a float from an integer literal

2014-11-24 Thread Iago Toral
an error and fails to compile a shader that uses that syntax. Iago - Neil Iago Toral ito...@igalia.com writes: On Thu, 2014-11-20 at 08:08 +0100, Iago Toral wrote: On Wed, 2014-11-19 at 10:27 -0800, Ian Romanick wrote: On 11/19/2014 03:47 AM, Iago Toral Quiroga wrote: Hi, I came

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

2014-11-26 Thread Iago Toral
Thanks Neil! I was planning to fix this once I was done with the format conversion stuff, so you saved me some work :) I tested the patch and it fixes the following dEQP tests: dEQP-GLES3.functional.shaders.constants.float_int_f_suffix_0_vertex

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect the cases where _mesa_base_tex_format returns -1 doesn't work

Re: [Mesa-dev] [PATCH v2 16/23] mesa: Add _mesa_pack_uint_rgba_row() format conversion function

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 11:14 -0800, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com We will use this later on to handle uint conversion scenarios

Re: [Mesa-dev] [PATCH 04/10] mesa: Recompute LegalTypesMask if the GL API has changed

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 09:24 -0700, Brian Paul wrote: On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com The current code computes ctx-Array.LegalTypesMask just once, however, computing this needs to consider ctx-API so we need to make sure

Re: [Mesa-dev] [PATCH v2 09/29] mesa: Add _mesa_swap2_copy and _mesa_swap4_copy

2014-12-03 Thread Iago Toral
On Mon, 2014-12-01 at 09:18 -0700, Brian Paul wrote: On 12/01/2014 04:05 AM, Iago Toral Quiroga wrote: We have _mesa_swap{2,4} but these do in-place byte-swapping only. The new functions receive an extra parameter so we can swap bytes on a source input array and store the results

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-03 Thread Iago Toral
On Wed, 2014-12-03 at 14:29 -0800, Ian Romanick wrote: On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect the cases where _mesa_base_tex_format returns -1 doesn't work. Fixing the assertion breaks

Re: [Mesa-dev] [PATCH v2 10/23] mesa: Add a concept of an array format

2014-12-04 Thread Iago Toral
On Wed, 2014-12-03 at 14:58 -0800, Jason Ekstrand wrote: On Wed, Dec 3, 2014 at 2:52 PM, Ian Romanick i...@freedesktop.org wrote: On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: From: Jason Ekstrand jason.ekstr...@intel.com (...) +enum

Re: [Mesa-dev] [PATCH v2 10/23] mesa: Add a concept of an array format

2014-12-04 Thread Iago Toral
On Thu, 2014-12-04 at 17:39 +0900, Michel Dänzer wrote: On 04.12.2014 17:17, Iago Toral wrote: On Wed, 2014-12-03 at 14:58 -0800, Jason Ekstrand wrote: On Wed, Dec 3, 2014 at 2:52 PM, Ian Romanick i...@freedesktop.org wrote: On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote

Re: [Mesa-dev] [PATCH v2 01/23] mesa/format_utils: Fix a bug in unorm_to_float helper function

2014-12-04 Thread Iago Toral
, it should. Should I add Cc: 10.4 mesa-sta...@lists.freedesktop.org then? Iago On 12/01/2014 03:04 AM, Iago Toral Quiroga wrote: From: Jason Ekstrand jason.ekstr...@intel.com This patch fixes the return of a wrong value when x is lower

Re: [Mesa-dev] [PATCH v3 00/24] auto-generate pack/unpack functions

2014-12-09 Thread Iago Toral
On Tue, 2014-12-09 at 13:06 +0100, Iago Toral Quiroga wrote: This is the first of two series that aim to address: https://bugs.freedesktop.org/show_bug.cgi?id=84566 A branch with this series is available here: https://github.com/Igalia/mesa/tree/itoral-autogen-packing-review-v3

Re: [Mesa-dev] [PATCH v3 16/28] gallium: Use _mesa_format_convert to implement st_GetTexImage.

2014-12-09 Thread Iago Toral
On Tue, 2014-12-09 at 15:01 +0100, Roland Scheidegger wrote: This ought to be st/mesa: not gallium: in the shortlog. Otherwise makes sense. Roland Fixed locally. Thanks! Iago Am 09.12.2014 um 13:07 schrieb Iago Toral Quiroga: Instead of using _mesa_pack_rgba_span_float. This should

[Mesa-dev] Precision of float and trigonometric functions on i965

2014-12-11 Thread Iago Toral
Hi, there are a bunch of dEQP tests that check precision of trigonometric functions and float qualifiers that fail on i965. The way these tests usually operate is that they define a float (with a lowp, mediump or highp precision qualifier) and assign the result of a trigonometric function to it.

Re: [Mesa-dev] [PATCH 05/16] i965: Fix bitcast operations with negate

2014-12-11 Thread Iago Toral
On Thu, 2014-12-11 at 16:52 -0800, Kenneth Graunke wrote: On Thursday, December 11, 2014 11:34:11 PM Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com For code such as this in a vertex or fragment shader: uniform float in0; flat out float out0; ... out0 = ceil

Re: [Mesa-dev] [PATCH v3 10/24] main: Add a concept of an array format

2014-12-11 Thread Iago Toral
On Thu, 2014-12-11 at 11:24 -0800, Jason Ekstrand wrote: On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Jason Ekstrand jason.ekstr...@intel.com An array format is a 32-bit integer format identifier that can represent

Re: [Mesa-dev] [PATCH v3 10/24] main: Add a concept of an array format

2014-12-11 Thread Iago Toral
On Fri, 2014-12-12 at 08:21 +0100, Iago Toral wrote: On Thu, 2014-12-11 at 11:24 -0800, Jason Ekstrand wrote: On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Jason Ekstrand jason.ekstr...@intel.com An array format is a 32

Re: [Mesa-dev] [PATCH 04/16] mesa: Depth ans stencil attachments must be the same in OpenGL ES3

2014-12-12 Thread Iago Toral
On Thu, 2014-12-11 at 18:10 -0800, Ian Romanick wrote: On 12/11/2014 02:34 PM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com From the OpenGL ES3 spec: 9.4. FRAMEBUFFER COMPLETENESS ... Depth and stencil attachments, if present, are the same image

Re: [Mesa-dev] [PATCH v3 05/28] mesa: Let _mesa_swizzle_and_convert take array format types instead of GL types

2014-12-14 Thread Iago Toral
to this position in the series. Iago --Jason On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga ito...@igalia.com wrote: In the future we would like to have a format conversion library that is independent of GL so we can share it with Gallium. This is a step

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-15 Thread Iago Toral
On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga ito...@igalia.com wrote: For glReadPixels with a Luminance destination format we compute luminance values from RGBA as L=R+G+B. This, however, requires ad

Re: [Mesa-dev] [PATCH 05/16] i965: Fix bitcast operations with negate

2014-12-15 Thread Iago Toral
On Fri, 2014-12-12 at 09:36 -0800, Matt Turner wrote: On Thu, Dec 11, 2014 at 2:34 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For code such as this in a vertex or fragment shader: uniform float in0; flat out float out0; ... out0

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-15 Thread Iago Toral
On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote: On Mon, Dec 15, 2014 at 3:12 AM, Iago Toral ito...@igalia.com wrote: On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga ito

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-16 Thread Iago Toral
On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote: On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote: On Mon, Dec 15, 2014 at 3:12 AM, Iago Toral ito...@igalia.com wrote: On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: On Tue

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-16 Thread Iago Toral
On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote: On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral ito...@igalia.com wrote: On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote: On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-17 Thread Iago Toral
On Wed, 2014-12-17 at 03:51 -0800, Jason Ekstrand wrote: On Tue, Dec 16, 2014 at 11:37 PM, Iago Toral ito...@igalia.com wrote: On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote: On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral ito

Re: [Mesa-dev] [PATCH] i965: Fix bitcast operations with negate (ceil)

2014-12-17 Thread Iago Toral
On Wed, 2014-12-17 at 04:19 -0800, Jason Ekstrand wrote: On Wed, Dec 17, 2014 at 1:24 AM, Iago Toral Quiroga ito...@igalia.com wrote: Commit 0ae9ca12a8 put source modifiers out of the bitcast operations by adding a MOV operation that would handle them separately

Re: [Mesa-dev] [PATCH 02/11] glsl: Add link time checks for GLSL precision qualifiers

2015-02-06 Thread Iago Toral
On Fri, 2015-02-06 at 10:47 +0200, Ian Romanick wrote: On 01/26/2015 10:09 AM, Iago Toral wrote: On Tue, 2015-01-20 at 12:34 +0100, Iago Toral wrote: On Mon, 2015-01-19 at 19:39 -0800, Ian Romanick wrote: On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito

[Mesa-dev] Expected wide line rendering with clipping

2015-02-06 Thread Iago Toral
Hi, Eduardo and I have been looking into a few dEQP test failures that deal with wide line rendering. There are a few of them that fail because of how clipping is implemented for this case. The problem in these cases seems to be that the hw renders the wide line as a parallelogram so that if an

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Iago Toral
On Sat, 2015-02-07 at 13:41 +0100, Erik Faye-Lund wrote: On Fri, Feb 6, 2015 at 1:11 PM, Iago Toral ito...@igalia.com wrote: Hi, Eduardo and I have been looking into a few dEQP test failures that deal with wide line rendering. There are a few of them that fail because of how clipping

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Iago Toral
On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: Am 06.02.2015 um 13:11 schrieb Iago Toral: Hi, Eduardo and I have been looking into a few dEQP test failures that deal with wide line rendering. There are a few of them that fail because of how clipping is implemented

Re: [Mesa-dev] [PATCH 07/11] glsl: error out on empty declarations

2015-01-20 Thread Iago Toral
On Mon, 2015-01-19 at 19:03 -0800, Ian Romanick wrote: On 01/19/2015 04:52 AM, Erik Faye-Lund wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com So far we have only been emitting a warning. Fixes

  1   2   3   4   5   6   7   8   9   10   >