Re: [Mesa-dev] [PATCH v5 12/70] glsl: implement unsized array length

On Sun, 2015-12-13 at 23:10 -0500, Ilia Mirkin wrote: > On Thu, Sep 10, 2015 at 9:35 AM, Iago Toral Quiroga <ito...@igalia.com> wrote: > > +ir_expression * > > +lower_ubo_reference_visitor::process_ssbo_unsized_array_length(ir

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Map program UBOs and SSBOs to Interface Blocks

On Thu, 2015-12-31 at 11:20 -0800, Jordan Justen wrote: > v2: > * Fill UboInterfaceBlockIndex and SsboInterfaceBlockIndex in >split_ubos_and_ssbos (Iago) > > Cc: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > Cc: Iago Toral <ito...@igalia.com> > Signed-of

Re: [Mesa-dev] [PATCH v2 2/2] mesa: Use separate indices for UBO & SSBO during binding

i?id=93322 > Cc: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > Cc: Iago Toral <ito...@igalia.com> > Cc: Tapani Pälli <tapani.pa...@intel.com> > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Reviewed-by: Juha-Pekka Heikkila <juhapekka.

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: Add more lowering

b), 'options->lower_usub_borrow'), Don't we need to use b2i with uadd_carry and usub_borrow? ult seems to return NIR_TRUE (~0u) instead of 1. With that change (or confirmation that is not needed): Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> Iago > ] >

Re: [Mesa-dev] [PATCH 3/3] i965/compiler: Enable more lowering in NIR

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Wed, 2016-01-06 at 15:30 -0800, Jason Ekstrand wrote: > We don't need these for GLSL or ARB, but we need them for SPIR-V > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 5 + > 1 file changed, 5 insertions(+) > &g

Re: [Mesa-dev] [PATCH v2 23/42] glsl: Add lowering pass for shared variable references

On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > In this lowering pass, shared variables are decomposed into intrinsic > calls. > > v2: > * Send mem_ctx as a parameter (Iago) > > Signed-off-by: Jordan Justen > --- > src/glsl/Makefile.sources | 1

Re: [Mesa-dev] [PATCH v2 24/42] nir: Translate glsl shared var load intrinsic to nir intrinsic

On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/nir/glsl_to_nir.cpp | 29 + > src/glsl/nir/nir_intrinsics.h | 1 + > 2 files changed, 30 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v2 26/42] i965: Disable vector splitting on shared variables

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 1 + > 1 file changed, 1 insertion(+) &g

Re: [Mesa-dev] [PATCH v2 21/42] glsl: Add default matrix ordering in lower_buffer_access

On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > For compute shader shared variable we will set a default of column > major. > > Signed-off-by: Jordan Justen > --- > src/glsl/lower_buffer_access.cpp | 5 +++-- > src/glsl/lower_buffer_access.h | 10

Re: [Mesa-dev] [PATCH v2 25/42] nir: Translate glsl shared var store intrinsic to nir intrinsic

/src/glsl/nir/nir_intrinsics.h > index de15128..6912258 100644 > --- a/src/glsl/nir/nir_intrinsics.h > +++ b/src/glsl/nir/nir_intrinsics.h > @@ -277,5 +277,6 @@ LOAD(shared, 0, 1, NIR_INTRINSIC_CAN_ELIMINATE) > STORE(output, 0, 0, 0, 0) > STORE(per_vertex_output, 1, 1, 0, 0)

Re: [Mesa-dev] [PATCH v2 22/42] glsl: Don't lower_variable_index_to_cond_assign for shared variables

rage: >return this->lower_uniforms; > > + case ir_var_shader_shared: > + return false; I suppose the right thing to do here is to add a lower_shared_variables parameter to this and take its value from a compiler option that we set to false, like we do with the other types, bu

Re: [Mesa-dev] [PATCH v2 30/42] i965: Lower shared variable references to intrinsic calls

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [Mesa-dev] [PATCH v2 40/42] i965: Enable ARB_compute_shader extension on supported hardware

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Enable ARB_compute_shader on gen7+, on hardware that supports the > OpenGL 4.3 requirements of a local group size of 1024. > > With SIMD16 support, this is lim

Re: [Mesa-dev] [PATCH v2 36/42] glsl: Buffer atomics are supported for compute shaders

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > src/glsl/builtin_functions.cpp | 70 > +++--- > 1 file ch

Re: [Mesa-dev] [PATCH v2 39/42] i965/nir: Implement shared variable atomic operations

On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 60 > > 2 files changed, 62 insertions(+) >

Re: [Mesa-dev] [PATCH v2 28/42] i965/fs: Handle nir shared variable store intrinsic function

On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 54 > > 1 file changed, 54 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v2 29/42] i965: Enable shared local memory for CS shared variables

is in 4k increments, but must be a power of 2. */ > + slm_size = 4 * 1024; > + while (slm_size < 64 * 1024 && slm_size < prog_data->total_shared) total_shared is guaranteed to be <= 64KB because of the assert above so we should not need the "slm_size &l

Re: [Mesa-dev] [PATCH v2 27/42] i965/fs: Handle nir shared variable load intrinsic

On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 33 > > 2 files changed, 35 insertions(+) >

Re: [Mesa-dev] [PATCH v2 31/42] glsl: Allow atomic functions to be used with shared variables

On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > --- > src/glsl/ast_function.cpp | 1

Re: [Mesa-dev] [PATCH v2 35/42] glsl: Translate atomic intrinsic functions on shared variables

On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > When an intrinsic atomic operation is used on a shared variable, we > translate it to a new 'share variable' specific intrinsic function s/share/shared > call. > > For example, add call to __intrinsic_atomic_add when used on a shared >

Re: [Mesa-dev] [PATCH v2 37/42] glsl: Disable several optimizations on shared variables

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Shared variables can be accessed by other threads within the same > local workgroup. This prevents us from performing certain > optimizations with shared variables.

Re: [Mesa-dev] [PATCH v2 38/42] nir: Add nir intrinsics for shared variable atomic operations

On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/nir/glsl_to_nir.cpp | 53 > +++ > src/glsl/nir/nir_intrinsics.h | 25 > 2 files changed, 78

Re: [Mesa-dev] [PATCH v2 42/42] docs: Add ARB_compute_shader to 11.1.0 release notes

I think we are too late for 11.1.0. On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > docs/relnotes/11.1.0.html | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html

Re: [Mesa-dev] [PATCH v2 41/42] docs: Mark ARB_compute_shader as done for i965

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > docs/GL3.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 29/42] i965: Enable shared local memory for CS shared variables

On Mon, 2015-11-30 at 00:43 -0800, Jordan Justen wrote: > On 2015-11-25 03:24:38, Iago Toral wrote: > > On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > > > --- > > > src/

Re: [Mesa-dev] [PATCH] glsl/dead_builin_varyings: Fix gl_FragData array lowering

On Mon, 2015-11-30 at 09:56 +0200, Tapani Pälli wrote: > Hi; > > On 11/27/2015 02:14 PM, Iago Toral Quiroga wrote: > > The current implementation looks for array dereferences on gl_FragData and > > immediately then proceeds to lower them, however this is not enough because

Re: [Mesa-dev] [PATCH v3 25/44] glsl: Add lowering pass for shared variable references

lways use 430 packing (Iago) > * Comment / whitespace cleanup (Iago) > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > --- > src/glsl/Makefile.sources | 1 + > src/glsl/ir_optimization.h

Re: [Mesa-dev] [PATCH v3 30/44] i965/fs: Handle nir shared variable store intrinsic

On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 52 > > 1 file changed, 52 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH v3 41/44] i965/nir: Implement shared variable atomic operations

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Update based on latest SSBO code (Iago) > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@igalia.com&

Re: [Mesa-dev] [PATCH v3 44/44] docs: Add ARB_compute_shader to 11.2.0 release notes

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-12-01 at 00:20 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > --- > docs/relnotes/11.2.0.html | 1 + > 1 file

Re: [Mesa-dev] [PATCH v3 29/44] i965/fs: Handle nir shared variable load intrinsic

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Remove extra #includes (Iago) > * Use recently added GEN7_BTI_SLM instead of BRW_SLM_SURFACE_INDEX (curro) > > Signed-off-by: Jordan Justen <jordan.

Re: [Mesa-dev] [PATCH v3 37/44] glsl: Translate atomic intrinsic functions on shared variables

sed on a shared For example, a call to ... Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > variable will be translated to a call to > __intrinsic_atomic_add_shared. > > v3: > * Fix stale comments copied from SSBOs (Iago) > > Signed-off-by: Jordan Justen &l

Re: [Mesa-dev] [PATCH v3 31/44] i965: Enable shared local memory for CS shared variables

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Check shared variable size at link time > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@igalia.com&

Re: [Mesa-dev] [PATCH v3 40/44] nir: Add nir intrinsics for shared variable atomic operations

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-12-01 at 00:19 -0800, Jordan Justen wrote: > v3: > * Update min/max based on latest SSBO code (Iago) > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@iga

Re: [Mesa-dev] [PATCH v2 24/42] nir: Translate glsl shared var load intrinsic to nir intrinsic

On Wed, 2015-11-25 at 10:17 -0500, Connor Abbott wrote: > On Wed, Nov 25, 2015 at 4:48 AM, Iago Toral <ito...@igalia.com> wrote: > > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > >> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > >>

Re: [Mesa-dev] [PATCH v2 21/42] glsl: Add default matrix ordering in lower_buffer_access

On Wed, 2015-11-25 at 11:59 -0800, Jordan Justen wrote: > On 2015-11-25 01:32:37, Iago Toral wrote: > > > > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > > > For compute shader shared variable we will set a default of column > > > major. > >

Re: [Mesa-dev] [PATCH v2 19/42] glsl ubo/ssbo: Move common code into lower_buffer_access::setup_buffer_access

: > * Add comment for lower_buffer_access::setup_buffer_access > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Samuel Iglesias Gonsalvez <sigles...@igalia.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > Reviewed-by: Iago Toral Quiroga <ito...@ig

Re: [Mesa-dev] [PATCH v2 15/42] glsl ubo/ssbo: Use enum to track current buffer access type

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > v2: > * Rename ssbo_get_array_length to ssbo_unsized_array_length_access (Iago) > * Use always use this-> when referencing buffer_access_type (Iago) > > Sign

Re: [Mesa-dev] [PATCH v2 17/42] glsl ubo/ssbo: Add lower_buffer_access class

ten <jordan.l.jus...@intel.com> > Cc: Samuel Iglesias Gonsalvez <sigles...@igalia.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > --- > src/glsl/Makefile.sources| 2 + > src/glsl/lower_buffer_access.cpp | 218 >

Re: [Mesa-dev] [PATCH v2 33/42] glsl: Check for SSBO variable in SSBO atomic lowering

Iago) > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Samuel Iglesias Gonsalvez <sigles...@igalia.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > --- > src/glsl/lower_ubo_

Re: [Mesa-dev] [PATCH v2 34/42] glsl: Check for SSBO variable in check_for_ssbo_store

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:55 -0800, Jordan Justen wrote: > The compiler probably already blocks this earlier on, but we should be > checking for an SSBO here. > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com&g

Re: [Mesa-dev] [PATCH v2 20/42] glsl: Remove mem_ctx as member variable in lower_ubo_reference_visitor

Reviewed-by:; Iago Toral Quiroga <ito...@igalia.com> On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Iago Toral Quiroga <ito...@igalia.com> > --- > src/gls

[Mesa-dev] Link failure when copying big arrays stored in SSBOs

Hi, Jordan sent a piglit test that produces a link failure with the ssbo code [1]. Doing something like this is sufficient to reproduce the problem: [fragment shader] #version 330 #extension GL_ARB_shader_storage_buffer_object: require #define SIZE 6 layout (std430) buffer SSBO { mat4

Re: [Mesa-dev] Link failure when copying big arrays stored in SSBOs

On Fri, 2015-11-20 at 13:07 +0100, Iago Toral wrote: > Hi, > > Jordan sent a piglit test that produces a link failure with the ssbo > code [1]. Doing something like this is sufficient to reproduce the > problem: > > [fragment shader] > #

Re: [Mesa-dev] [PATCH 2/2] i965: Test that nonrepresentable floats cannot be converted to VF.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Thu, 2015-11-19 at 22:43 -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 0/9] Early fp64 fixes

On Thu, 2015-11-19 at 11:05 +0100, Iago Toral Quiroga wrote: > These patches are fixes extracted from Connor's fp64 branch that > I would like to review and land ahead of the rest. They are > independent of the rest of the series, some of them are even > general fixes unrelated to fp6

Re: [Mesa-dev] [PATCH 1/2] i965: Use ldexpf() in VF float test set up.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Thu, 2015-11-19 at 22:43 -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 0/9] Early fp64 fixes

On Thu, 2015-11-19 at 10:54 -0500, Connor Abbott wrote: > On Thu, Nov 19, 2015 at 5:05 AM, Iago Toral Quiroga <ito...@igalia.com> wrote: > > These patches are fixes extracted from Connor's fp64 branch that > > I would like to review and land ahead of the rest. They are > &

Re: [Mesa-dev] [PATCH 0/9] Early fp64 fixes

On Thu, 2015-11-19 at 12:19 -0800, Matt Turner wrote: > For the next patches you send from Connor, please use > --suppress-cc=author so that every reply doesn't generate a bounce > message about his disabled @intel email. :) > Yeah, will do :) Iago

Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled

On Thu, 2015-11-19 at 10:14 -0500, Connor Abbott wrote: > I think Ken already pushed a similar patch so we can drop this. I don't see that in master, but sure, we can hold this back if he is planning to push the same thing. Iago > On Thu, Nov 19, 2015 at 5:05 AM, Iago Toral Quirog

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

tian Høgsberg <k...@bitplanet.net> > >> wrote: > >>> On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga <ito...@igalia.com> > >>> wrote: > >>>> From: Connor Abbott <connor.w.abb...@intel.com> > >>>> > >>>&g

Re: [Mesa-dev] [PATCH] glsl: split ssbo array copies into element copies

On Fri, 2015-11-20 at 11:09 -0800, Jordan Justen wrote: > On 2015-11-20 06:48:27, Iago Toral Quiroga wrote: > > Improves register pressure, since otherwise we end up emitting > > loads for all the elements in the RHS and them emitting > > stores for all elements in th

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

On Mon, 2015-11-23 at 14:03 -0800, Ian Romanick wrote: > On 11/23/2015 02:01 PM, Ian Romanick wrote: > > On 11/23/2015 10:54 AM, Jason Ekstrand wrote: > >> This fixes a regression introduced in b1a83b5d1 that caused basically all > >> shaders to fail to compile on 32-bit platforms. > > > > Here's

Re: [Mesa-dev] [PATCH] glsl: Pass ast_type_qualifier by const reference.

ast_cs_input_layout(const struct YYLTYPE , > - ast_layout_expression **local_size) > + ast_layout_expression *const *local_size) I think this change does not belong in this patch. Otherwise: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com>

Re: [Mesa-dev] [PATCH 1/4] glsl: remove trailing spaces in ast_to_hir.cpp

On Tue, 2015-11-24 at 12:26 +, Emil Velikov wrote: > Hi Iago, > > I'm not sure how others feel on the topic, but imho it's not that > useful to have XX patches where each addresses a couple of lines of > whitespace issues. Squashing the lot per section (one for glsl, > another for i965) seems

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Skip assertion on NaN.

On Tue, 2016-01-12 at 11:53 -0800, Matt Turner wrote: > On Tue, Jan 12, 2016 at 1:41 AM, Iago Toral <ito...@igalia.com> wrote: > > On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: > >> A shader in Unreal4 uses the result of divide by zero in its color > >> out

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On Tue, 2016-01-12 at 10:29 -0500, Ilia Mirkin wrote: > IIRC this should come out as b2i + i2d. You should be able to test > this with llvmpipe/softpipe, which support fp64. I see, thanks for the quick reply, I'll check this on intel. Iago > On Jan 12, 2016 9:49 AM, "Iago Toral

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On Tue, 2016-01-12 at 12:41 -0500, Ilia Mirkin wrote: > On Tue, Jan 12, 2016 at 12:33 PM, Ian Romanick wrote: > > On 01/12/2016 07:29 AM, Ilia Mirkin wrote: > >> IIRC this should come out as b2i + i2d. You should be able to test this > >> with llvmpipe/softpipe, which

Re: [Mesa-dev] [PATCH 2/9] glsl: Delete the ir_binop_bfm and ir_triop_bfi opcodes.

Looks good to me, FWIW I built radeonsi and llvmpipe with this change just in case and I saw no issues. Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-11 at 14:48 -0800, Matt Turner wrote: > From: Kenneth Graunke <kenn...@whitecape.org> > > TGSI doesn'

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add debugging to constant combining pass.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: > --- > .../drivers/dri/i965/brw_fs_combine_constants.cpp | 21 > - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH 1/9] nir: Fix constant evaluation of bfm.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-11 at 14:48 -0800, Matt Turner wrote: > NIR's bfm, like Intel/AMD's hardware instructions and GLSL IR's > ir_binop_bfm takes as src0 and as src1. > --- > src/glsl/nir/nir_opcodes.py | 2 +- > 1 file chang

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Skip assertion on NaN.

On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: > A shader in Unreal4 uses the result of divide by zero in its color > output, producing NaN and triggering this assertion since NaN is not > equal to itself. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93560 > --- >

Re: [Mesa-dev] [PATCH] glsl: Make read_from_write_only_variable_visitor ignore .length().

Makes sense, Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-11 at 16:15 -0800, Kenneth Graunke wrote: > .length() on an unsized SSBO variable doesn't actually read any data > from the SSBO, and is allowed on variables marked 'writeonly'. > > Fixes compute

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

On Mon, 2016-06-06 at 16:45 +0200, Jakob Sinclair wrote: > On 2016-06-06 15:48, Iago Toral wrote: > > Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > > > > I don't have push access so I would be very happy if you could push this > patch for me. Thanks! Sure

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: > Could cause issues if you tried to read from an uninitialised pointer. > This just initalises the pointer to null to avoid that being a problem. > Discovered by Cov

Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

I guess this makes sense: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com Out of curiosity, in which case do we get here and can't find a function name? On Mon, 2016-06-06 at 07:00 +1000, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > This fixes

Re: [Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

On Tue, 2016-06-07 at 15:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > One piece of ARB_shader_subroutine I ignored was the fact that it > needs to store the subroutine index data per context and not per > shader program. > > There is one CTS test that tests this: >

Re: [Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

On Thu, 2016-05-26 at 15:13 +0100, Emil Velikov wrote: > On 19 May 2016 at 10:00, Iago Toral <ito...@igalia.com> wrote: > > I have just noticed that this was never pushed, right? I noticed this > > while working on providing double-precision implementation for the other &g

Re: [Mesa-dev] [PATCH] i965/fs: Fix regs_written for SIMD-lowered instructions some more.

On Fri, 2016-06-10 at 22:39 -0700, Francisco Jerez wrote: > ISTR having suggested this during review of the recent FP64 changes to > the SIMD lowering pass, but it doesn't look like it was taken into > account in the end. Using the fs_reg::component_size helper instead > of this open-coded

Re: [Mesa-dev] [PATCH 1/2] i965: Add _NEW_POINT to a couple of comments.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Wed, 2016-06-01 at 21:25 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> > Cc: "12.0" <mesa-sta...@lists.freedesktop.org> > --- > src/mesa/drivers/dri/i965/gen6_s

Re: [Mesa-dev] [PATCH] glsl: re-enable varying packing in GL4.4+

On Thu, 2016-05-26 at 14:50 +1000, Timothy Arceri wrote: > The i965 backend currently expects doubles to be packed. This patch is: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> With that said, I think these two patches from Samuel might have fixed i965 to handle unpacke

Re: [Mesa-dev] [PATCH] i965/xfb: skip components in correct buffer.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Wed, 2016-06-01 at 14:13 +1000, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > The driver was adding the skip components but always for buffer 0. > > This fixes: > GL45-CTS.gtf4

Re: [Mesa-dev] [PATCH] i965: Fix isoline reads in scalar TES.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2016-05-31 at 22:45 -0700, Kenneth Graunke wrote: > Isolines aren't reversed. commit 5b2d8c2273c6f fixed this for the vec4 > TES backend, but not the scalar one. > > Found while debugging GL45-CTS.t

Re: [Mesa-dev] [PATCH 2/2] glsl/mesa: stop duplicating geom and tcs layout values

.0cd420e 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mtypes.h > @@ -2718,17 +2718,6 @@ struct gl_shader_program > enum gl_frag_depth_layout FragDepthLayout; > > /** > -* Tessellation Control shader state from layout qualifiers. > -*/ > - struct

Re: [Mesa-dev] [PATCH V2 1/2] glsl/mesa: stop duplicating tes layout values

an be while making it somewhat clearer where these > values originate from. > > V2: remove unessisary NULL check unnecessary > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > Reviewed-by: Iago Toral <ito...@igalia.com> > --- > src/compiler/glsl/lin

Re: [Mesa-dev] [PATCH] i965: move vs outputs written into a helper

On Wed, 2016-06-22 at 11:34 +1000, Timothy Arceri wrote: > On Mon, 2016-06-20 at 17:38 +0200, Iago Toral wrote: > > On Mon, 2016-06-20 at 21:11 +1000, Timothy Arceri wrote: > > > > > > We will reuse this for fs key generation for the on disk shader > > > cach

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

On Wed, 2016-06-22 at 09:54 +1000, Timothy Arceri wrote: > On Tue, 2016-06-21 at 17:45 +0200, Iago Toral wrote: > > On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > > > > > > We already store this in gl_shader and gl_program here we > > > remove it

Re: [Mesa-dev] [PATCH 18/27] i965: avoid int64 induced warnings

Patches 18 and 18 are: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-06-20 at 15:07 +1000, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Just add types into unsupported or double > equivalent spots. > > Signed-off-by: D

Re: [Mesa-dev] [PATCH] i965: get PrimitiveMode from the program rather than the shader struct

On Mon, 2016-06-20 at 17:40 +1000, Timothy Arceri wrote: > This is more consitent with what we do elsewhere and will allow consistent Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > us to only cache one of the values in the shader cache. > --- > src/mes

Re: [Mesa-dev] [PATCH] i965: move vs outputs written into a helper

only amends the bitfield with some special outputs... maybe something like brw_vs_amend_outputs_written would be more accurate. What do you think? Either way: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > +{ > + if (key->copy_edgeflag) { > + outputs_written |=

Re: [Mesa-dev] [PATCH] glsl/mesa: stop duplicating tess layout values

On Tue, 2016-06-21 at 12:21 +1000, Timothy Arceri wrote: > We already store this in gl_shader and gl_program here we > remove it from gl_shader_program and just use the values > from gl_shader. > > This will allow us to keep the shader cache restore code as > simple as it can be while making it

Re: [Mesa-dev] [PATCH] glsl: Don't abbreviate tessellation shader stage names.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-18 at 06:02 -0800, Kenneth Graunke wrote: > I have a patch that writes shaders as .shader_test files, and it uses > this function to create the headers (i.e. [vertex shader]). > > [tess ctrl shader] isn't a v

Re: [Mesa-dev] [PATCH 02/10] glsl: keep track of ssbo variable being accessed, add access params

e intrinsics. This patch is Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> It does not add the NIR implementation so if someone wants to use this with NIR we will have to add the glsl_to_nir code to read this last parameter and update the ssbo intrinsics in NIR to include it as well.

Re: [Mesa-dev] [PATCH] mesa: remove dead program parameter functions

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Thu, 2016-02-04 at 21:55 +1100, Timothy Arceri wrote: > --- > src/mesa/program/prog_parameter.c | 70 > --- > src/mesa/program/prog_parameter.h | 7 > 2 files changed, 77 d

Re: [Mesa-dev] [PATCH] glsl: simplify setting of image access qualifiers

current_var = var; > + this->prog = prog; No reason to assign this every time we find a variable, we should do this in the constructor of the parcel object instead. With that change, Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> >field_counter = 0; >

Re: [Mesa-dev] [PATCH] glsl: Ensure glsl/ exists before making the lexer/parser.

Looks good to me, Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Wed, 2016-02-03 at 12:04 -0800, Matt Turner wrote: > Reported-by: Jan Ziak <0xe2.0x9a.0...@gmail.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93989 > --- > src/compiler/Makefile.am

Re: [Mesa-dev] [PATCH] i965/fs: Replace subreg_offset with brw_reg's subnr.

On Thu, 2016-02-11 at 19:12 -0800, Kenneth Graunke wrote: > On Thursday, February 11, 2016 5:49:55 PM PST Matt Turner wrote: > > On Thu, Feb 11, 2016 at 3:33 PM, Francisco Jerez > wrote: > > > Would be really nice if we could also get rid of reg_offset as we're at > > >

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

ffset is also valid. Anyway, I am not blocking anything, the patches are a small thing and they might help in some cases so feel to go ahead with them. If you still need a Reviewed-by for these you can add mine or Samuel's. Iago > > On Wed, Feb 3, 2016 at 5:12 PM, Iago Toral <ito...@igalia.com

Re: [Mesa-dev] [PATCH 2/3] glsl: don't validate interface blocks twice

torage block or " > - "uniform block"); > + if (decl_type->contains_image()) { > +/* FINISHME: Same problem as with atomic counters. > + * FINISHME: Request clarification from Khronos and add > + * FINISHME: spec quo

Re: [Mesa-dev] [PATCH 1/3] glsl: remove duplicate embedded struct validation

Looks good to me, Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Thu, 2016-02-11 at 15:45 +1100, Timothy Arceri wrote: > Commit c98deb18d5836f in 2010 disallowed embedded struct definitions > in ES. Then in 2013 d9bb8b7b56ce65b disallowed it for everything but > GLSL 1.

Re: [Mesa-dev] [PATCH 00/12] i965+nir: Do pack/unpack lowering in NIR

, but it is probably unnecessary in practice so do with that as you will. Iago On Tue, 2016-01-26 at 16:33 +0100, Iago Toral wrote: > Patches 1 to 4 are, > > Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > > I intend to review the remaining patches tomorrow as well if n

Re: [Mesa-dev] [PATCH 09/12] nir: Add lowering support for packing opcodes.

On Thu, 2016-01-28 at 09:21 -0800, Matt Turner wrote: > On Thu, Jan 28, 2016 at 12:32 AM, Iago Toral <ito...@igalia.com> wrote: > > On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: (...) > >> diff --git a/src/glsl/nir/nir_opt_algebraic.py > >> b/src/glsl/ni

Re: [Mesa-dev] [PATCH 05/12] i965/fs: Switch from GLSL IR to NIR for un/packHalf2x16 lowering.

On Wed, 2016-01-27 at 12:29 -0800, Matt Turner wrote: > On Wed, Jan 27, 2016 at 5:22 AM, Iago Toral <ito...@igalia.com> wrote: > > I think it would be a good idea to change the shortlog so it is clear > > that we are only talking about the scalarization aspect. There is still

Re: [Mesa-dev] [PATCH 10/12] nir: Add lowering support for unpacking opcodes.

On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: > --- > src/glsl/nir/nir.h| 4 > src/glsl/nir/nir_opt_algebraic.py | 28 > 2 files changed, 32 insertions(+) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h > index bbd5b1a..3b90b51

Re: [Mesa-dev] [PATCH 11/12] i965/vec4: Implement nir_op_pack_uvec2_to_uint.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: > And mark nir_op_pack_uvec4_to_uint unreachable, since it's only produced > by lowering pack[SU]norm4x8 which the vec4 backend does not need. > --- > src/mes

Re: [Mesa-dev] [PATCH 09/12] nir: Add lowering support for packing opcodes.

On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: > --- > src/glsl/nir/nir.h | 4 > src/glsl/nir/nir_lower_alu_to_scalar.c | 32 > src/glsl/nir/nir_opcodes.py| 10 ++ > src/glsl/nir/nir_opt_algebraic.py | 20

Re: [Mesa-dev] [PATCH 12/12] i965/gen7+: Use NIR for lowering of pack/unpack opcodes.

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_compiler.c | 15 + > .../dri/i965/brw_fs_channel_expressions.cpp| 8 +++ > src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH v4 03/11] glsl: keep track of ssbo variable being accessed, add access params

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Sun, 2016-01-24 at 13:59 -0500, Ilia Mirkin wrote: > Currently any access params (coherent/volatile/restrict) are being lost > when lowering to the ssbo load/store intrinsics. Keep track of the > variable being used, and

Re: [Mesa-dev] [PATCH] meta: Check after null return value at blitframebuffer_texture()

Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Sun, 2016-01-31 at 20:39 +0200, Juha-Pekka Heikkila wrote: > Look after _mesa_meta_setup_sampler() return value. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> > --- > src/mesa/drivers/com

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

Hi Juha, I don't know why checking for this might be more relevant in Windows, but in any case: There are a ton of other places in mesa where we allocate memory via calloc/malloc and we don't check that the allocation actually succeeded so I am not sure that fixing a couple of instances of

<    1   2   3   4   5   6   7   8   9   10   >