On Tue, Sep 30, 2014 at 5:00 PM, Matt Turner matts...@gmail.com wrote:
On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner matts...@gmail.com wrote:
The compiler isn't privy to the knowledge that we're doing at least one
framebuffer write.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
1
This shouldn't be a functional change since reg_belongs_to_class is just a
wrapper around BITSET_TEST. It just makes the code a little easier to
read.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/util/register_allocate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
. This patch
should make generating the ra_set much faster and melt the piglit run
times.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 52 ++-
1 file changed, 50 insertions(+), 2 deletions(-)
diff --git a/src
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index 32669f6
On Oct 3, 2014 11:06 PM, Connor Abbott cwabbo...@gmail.com wrote:
On Fri, Oct 3, 2014 at 10:03 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
Previously, we were allowing the register allocation code to do the
computation for us in ra_set_finalize. However, the runtime
This shouldn't be a functional change since reg_belongs_to_class is just a
wrapper around BITSET_TEST. It just makes the code a little easier to
read.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/util/register_allocate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index 32669f6
is concerned, we only have 64. We were accidentally adding way too much
interference.
Signed-off-by: Jason Ekstrand jason.ekstr...@gmail.com
Cc: Connor Abbot cwabbo...@gmail.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Oct 7, 2014 12:04 PM, Iago Toral Quiroga ito...@igalia.com wrote:
There is a comment warning about the fact that this is not doing what we
expect, so fix it. This should be doing the same as unpack_B5G6R5_UNORM
but swapping B and R.
---
Jason started some work to auto-generate the
On Oct 8, 2014 6:36 AM, Iago Toral ito...@igalia.com wrote:
El 2014-10-07 21:46, Jason Ekstrand escribió:
On Oct 7, 2014 12:04 PM, Iago Toral Quiroga ito...@igalia.com
wrote:
There is a comment warning about the fact that this is not doing
what we
expect, so fix it. This should
On Oct 8, 2014 11:39 AM, Connor Abbott cwabbo...@gmail.com wrote:
On Tue, Oct 7, 2014 at 4:33 AM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On older GENs in SIMD16 mode, we were accidentally building too much
interference into our register classes. Since everything is divided by
2
,
we make more mistakes when guessing the key, which is how I spotted the
bug. It is reproducible on Haswell by making precompile choose daft
values for fields.
Cc: Jason Ekstrand ja...@jlekstrand.net
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965
. This will be
fixed in the next commit.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index 28a7483..46e465f 100644
On Mon, Oct 13, 2014 at 9:54 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
From: Connor Abbott connor.abb...@intel.com
At this point, the only thing it's used for is the opcode.
Signed-off-by: Connor Abbott connor.abb...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
---
On Tue, Oct 14, 2014 at 3:03 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Mon, Oct 13, 2014 at 9:54 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
From: Connor Abbott connor.abb...@intel.com
At this point, the only thing it's used for is the opcode.
Signed-off-by: Connor Abbott
On Tue, Oct 14, 2014 at 4:42 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
According to INTEL_DEBUG=perf, Borderlands: The Pre-Sequel was
stalling on nearly every glBufferSubData call, with very slightly
overlapping busy ranges.
It turns out the draw upload code was accidentally including
not just make type_size return 2 for doubles?
--Jason Ekstrand
+
this-width = v-dispatch_width;
assert(this-width == 8 || this-width == 16);
}
--
1.8.3.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org
instructions.
total instructions in shared programs: 5473519 - 5465864 (-0.14%)
instructions in affected programs: 432849 - 425194 (-1.77%)
GAINED:27
LOST: 0
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
src/mesa/drivers/dri
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index d4b72d8..49b50ee 100644
---
---
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
index c2010c0..c95beb6 100644
---
I thought this would be a clever way to make spilling less expensive.
However, it appears that the oword read/write messages we are using for
spilling ignore the execution size and assume SIMD16 whenever working with
more than one register.
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp |
---
src/mesa/drivers/dri/i965/brw_eu_emit.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c
b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 92f19e2..bb6334b 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index 49b50ee..3dedfa7 100644
---
On Oct 24, 2014 12:51 PM, Matt Turner matts...@gmail.com wrote:
On Fri, Oct 24, 2014 at 12:25 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
I thought this would be a clever way to make spilling less expensive.
However, it appears that the oword read/write messages we are using
On Fri, Oct 24, 2014 at 12:25 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965
On Fri, Oct 24, 2014 at 1:00 PM, Matt Turner matts...@gmail.com wrote:
On Fri, Oct 24, 2014 at 12:55 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Oct 24, 2014 12:51 PM, Matt Turner matts...@gmail.com wrote:
On Fri, Oct 24, 2014 at 12:25 PM, Jason Ekstrand ja...@jlekstrand.net
wrote
. This patch
should make generating the ra_set much faster and melt the piglit run
times.
v2: Fixed a couple of bugs. I have now verified that the same q-values are
generated both ways.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
Cc: Connor Abbot cwabbo...@gmail.com
---
src/mesa
This patch breaks a lot of piglit on my HSW.
https://bugs.freedesktop.org/show_bug.cgi?id=85425
On Fri, Oct 24, 2014 at 12:26 AM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich mathias.froehl...@gmx.net
Restore clip control to the default state if MESA_META_VIEWPORT
or
Fixes it for me. Also,
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
Push it!
On Fri, Oct 24, 2014 at 6:08 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
Fixes many piglit failures on IVB since 85edaa8.
Signed-off-by: Ian Romanick
On Fri, Oct 24, 2014 at 10:38 AM, Daniel Stone dan...@fooishbar.org wrote:
Hi,
On 24 October 2014 18:51, Emil Velikov emil.l.veli...@gmail.com wrote:
Sigh... why can't everyone be like Gentoo - set compiler flags and
rebuild for your machine/cpu :P
Apart from the Makefile.sources change
On Mon, Oct 27, 2014 at 10:36 AM, Kristian Høgsberg hoegsb...@gmail.com
wrote:
On Fri, Oct 24, 2014 at 12:25:06PM -0700, Jason Ekstrand wrote:
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/mesa
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
index da6da16..e48a4c6 100644
---
On Oct 28, 2014 11:57 AM, Matt Turner matts...@gmail.com wrote:
On Thu, Oct 16, 2014 at 3:40 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
Before, we used the a signed d-word for booleans and the immedates we
emitted varried between signed and unsigned. This commit changes the
type
On Tue, Oct 28, 2014 at 12:29 PM, Matt Turner matts...@gmail.com wrote:
On Tue, Oct 28, 2014 at 12:10 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Oct 28, 2014 11:57 AM, Matt Turner matts...@gmail.com wrote:
On Thu, Oct 16, 2014 at 3:40 PM, Jason Ekstrand ja...@jlekstrand.net
On Tue, Oct 28, 2014 at 5:23 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Tue, Oct 28, 2014 at 12:29 PM, Matt Turner matts...@gmail.com wrote:
On Tue, Oct 28, 2014 at 12:10 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Oct 28, 2014 11:57 AM, Matt Turner matts...@gmail.com
Ack
On Oct 28, 2014 7:24 PM, Kenneth Graunke kenn...@whitecape.org wrote:
Hello,
I'd like to rename some files in i965:
- brw_gs.c - brw_ff_gs.c
- brw_gs.h - brw_ff_gs.h
- brw_gs_emit.c - brw_ff_gs_emit.c
- brw_vec4_gs.c - brw_gs.c
- brw_vec4_gs.h - brw_gs.h
The current
---
.../drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 2 +-
.../drivers/dri/i965/brw_performance_monitor.c | 2 +-
.../drivers/dri/i965/brw_vec4_live_variables.h | 2 +-
src/mesa/drivers/dri/nouveau/nouveau_context.h
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 6 +-
src/gallium/state_trackers/glx/xlib/xm_api.c | 10 +-
src/mesa/drivers/common/meta.c| 3 +-
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 4 +-
src/mesa/drivers/dri/i965/brw_curbe.c |
and build it on MSVC and let me know if
anything needs to be squashed in so we don't break the build.
Roland
Am 29.10.2014 um 19:27 schrieb Jason Ekstrand:
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 6 +-
src/gallium/state_trackers/glx/xlib/xm_api.c | 10 +-
src/mesa
---
configure.ac | 1 +
src/gallium/auxiliary/tgsi/tgsi_exec.c | 1 +
src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 +-
src/gallium/auxiliary/util/u_helpers.c | 1 +
src/gallium/auxiliary/util/u_math.h|
On Wed, Oct 29, 2014 at 3:51 PM, Matt Turner matts...@gmail.com wrote:
On Wed, Oct 29, 2014 at 3:42 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
diff --git a/configure.ac b/configure.ac
index 03f1bca..e2258eb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -131,6 +131,7 @@ dnl Check
---
configure.ac | 1 +
scons/gallium.py | 2 +
src/gallium/auxiliary/tgsi/tgsi_exec.c | 1 +
src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 +-
src/gallium/auxiliary/util/u_helpers.c |
---
.../drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 2 +-
.../drivers/dri/i965/brw_performance_monitor.c | 2 +-
.../drivers/dri/i965/brw_vec4_live_variables.h | 2 +-
src/mesa/drivers/dri/nouveau/nouveau_context.h
---
src/mesa/main/bitset.h | 1 +
src/mesa/main/macros.h | 27 ---
src/util/macros.h | 27 +++
3 files changed, 28 insertions(+), 27 deletions(-)
diff --git a/src/mesa/main/bitset.h b/src/mesa/main/bitset.h
index f50b14f..dbf1af9 100644
---
Yes, please! I can't really comment on patch 1, but 2 and 3 are
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Fri, Oct 31, 2014 at 12:05 PM, Matt Turner matts...@gmail.com wrote:
Last use was in shader_time.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 17
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Mon, Nov 3, 2014 at 6:18 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
Otherwise, calling glPopAttrib on drivers that don't support
ARB_clip_control gives you a GL error, which is surprising at best.
Signed-off-by: Kenneth Graunke
This can be very useful for trying to debug list corruptions.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
Cc: Ian Romanick i...@freedesktop.org
---
src/glsl/list.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/glsl/list.h b/src/glsl/list.h
index aac13fd
On Wed, Nov 5, 2014 at 2:46 PM, Matt Turner matts...@gmail.com wrote:
On Wed, Nov 5, 2014 at 2:00 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
This can be very useful for trying to debug list corruptions.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
Cc: Ian Romanick i
In general, it seems as if this can miss several things. For instance, it
checks that all the predicessors are valid but never that we have all the
predecessors. Same for successors. If we really want to be able to
validate a CFG, maybe a stack-based approach like calculate_cfg would work
1 and 4 are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Wed, Nov 5, 2014 at 4:13 PM, Matt Turner matts...@gmail.com wrote:
---
src/mesa/drivers/dri/i965/brw_cfg.h | 74
+
1 file changed, 74 insertions(+)
diff --git a/src/mesa/drivers/dri
-parents.make_empty();
+ }
I *think* this is correct. I didn't really understand it before and I
don't 100% now.
Acked-by: Jason Ekstrand jason.ekstr...@intel.com
jump_block-add_successor(cfg-mem_ctx, later_block);
if (earlier_block-can_combine_with(jump_block
---
src/glsl/list.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/glsl/list.h b/src/glsl/list.h
index 1d18ec9..1fb9178 100644
--- a/src/glsl/list.h
+++ b/src/glsl/list.h
@@ -673,4 +673,13 @@ inline void exec_node::insert_before(exec_list *before)
__node = __next,
at the same time, or neither until NIR gets merged...
Fair enough. This at least gets it on the list for review.
Connor
On Fri, Nov 7, 2014 at 9:32 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
---
src/glsl/list.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src
Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Nov 10, 2014 11:37 PM, Matt Turner matts...@gmail.com wrote:
I used these in the SEL peephole, but they require extra tracking and
fix ups. The SEL peephole can pretty easily find the blocks it needs
without
Two questions: Does it fix the bug? And did you ever figure out what was
going on there?
On Nov 11, 2014 6:58 AM, Jason Ekstrand ja...@jlekstrand.net wrote:
Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Nov 10, 2014 11:37 PM, Matt Turner matts...@gmail.com wrote:
I
One more comment: These and the other two CFG fixes should probably be
promoted to stable.
On Tue, Nov 11, 2014 at 7:37 AM, Jason Ekstrand ja...@jlekstrand.net
wrote:
Two questions: Does it fix the bug? And did you ever figure out what was
going on there?
On Nov 11, 2014 6:58 AM, Jason
These too are
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
On Wed, Nov 12, 2014 at 11:28 AM, Matt Turner matts...@gmail.com wrote:
texture_offset was only used by some texturing operations, and offset
was only used by spill/unspill and some URB operations. These fields are
never used
Good catch!
Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com
Can you push or do you need me to?
On Sat, Nov 15, 2014 at 11:02 AM, Siavash Eliasi siavashser...@gmail.com
wrote:
---
src/mesa/main/texstore.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa
that base and
they
should be correct fixes to the currently existing code.
Iago Toral Quiroga (1):
swrast: Remove unused variable.
Jason Ekstrand (9):
mesa/format_utils: Fix a bug in one of the format helper functions
mesa: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM
mesa
In general, I like this patch. However, if we are going to claim to follow
the GL rule of Colors are clampped to their representable range, then
there still seem to be quite a few cases missing. For instance, when going
from signed to unsigned 8-bit formats, we should should take a min with 0
On Tue, Nov 18, 2014 at 12:43 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
An array format is a 32-bit integer format identifier that can represent
any format that can be represented as an array of standard GL datatypes.
While the MESA_FORMAT
On Tue, Nov 18, 2014 at 12:43 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
We were auto-generating it before. The problem was that the autogeneration
tool we were using was called copy, paste, and edit. Let's use a more
sensible solution
On Tue, Nov 18, 2014 at 12:44 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
We will use this later on to handle uint conversion scenarios in a master
convert function.
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
On Tue, Nov 18, 2014 at 12:44 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
src/mesa/main/format_pack.c.mako | 10 +-
1 file changed, 9 insertions(+), 1
On Tue, Nov 18, 2014 at 12:44 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This will be used to refactor code in pack.c and support conversion
to/from these types in a master convert function that will be added
later.
Signed-off-by:
this.
This is based on initial work by Jason Ekstrand.
Tested on i965, classic swrast and gallium (radeon, nouveau, llvmpipe)
without
regressions.
For software drivers we worked with a trimmed set of piglit tests (related
to
format conversion), ~5700 tests selected with the following filter:
-t
On Tue, Nov 18, 2014 at 1:42 PM, Jose Fonseca jfons...@vmware.com wrote:
On 18/11/14 17:10, Jason Ekstrand wrote:
Jose,
I haven't had time to fully review Iago and Samuel's code, so I can't
100% comment on it right now. However, let me make a few comments on
the overarching plan as it were
Pushed. Thanks!
--Jason
On Sat, Nov 15, 2014 at 7:07 PM, Siavash Eliasi siavashser...@gmail.com
wrote:
Please push it, I don't have write access.
Best regards,
Siavash Eliasi.
On 11/15/2014 11:06 PM, Jason Ekstrand wrote:
Good catch!
Reviewed-by: Jason Ekstrand jason.ekstr
On Wed, Nov 19, 2014 at 10:43 AM, Ian Romanick i...@freedesktop.org wrote:
On 11/16/2014 05:51 PM, Thomas Helland wrote:
They are bound between -1 and 1, so report that.
---
src/glsl/opt_minmax.cpp | 13 +
1 file changed, 13 insertions(+)
diff --git
...@igalia.com
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
v2 by Iago Toral ito...@igalia.com:
- When testing if we can directly pack we should use the src format to
check
if we are packing from an RGBA format. The original code used the dst
format
for the ubyte case by mistake.
- Fixed
I'm not sure what I think about this. Does it make a functional change
other than consistancy?
--Jason
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
In order to check if a format is normalized Mesa does something like this:
normalized =
A couple of specific comments are below. More generally, why are you only
considering the base format on two cases? Do we never use it for anything
else?
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
Add a dst_internal_format parameter to _mesa_format_convert,
A couple of general comments on this patch:
1) The prerequisites should be moved to before the first patch in the
series and it should be squashed into the patch that introduces the
function. There are one or two more patches which also modify it and those
should also be squashed in.
2) I
Any reason why you added 2 new functions, instead of just altering the ones
we have and updating where they are used?
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
We have _mesa_swap{2,4} but these do in-place byte-swapping only. The new
functions receive an
Can you remind me again as to what formats hit these paths? I remember you
hitting them, but I'm still not really seeing how it happens.
--Jason
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
We can have conversions from non-integer types to integer types, so
General comment: Maybe this would be better in gltypes rather than in
mesa_formats
On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
---
src/mesa/main/formats.c | 285
src/mesa/main/formats.h | 3 +
2 files
this shouldn't be strictly
needed. It may still be a good idea for consistency, but I want to make
sure we're doing the right thing in mesa_format_convert
--Jason
Iago
On Wed, 2014-11-19 at 11:31 -0800, Jason Ekstrand wrote:
I'm not sure what I think about this. Does it make a functional
change
On Wed, Nov 19, 2014 at 11:58 PM, Iago Toral ito...@igalia.com wrote:
On Wed, 2014-11-19 at 11:57 -0800, Jason Ekstrand wrote:
A couple of general comments on this patch:
1) The prerequisites should be moved to before the first patch in the
series and it should be squashed
On Thu, Nov 20, 2014 at 12:48 AM, Iago Toral ito...@igalia.com wrote:
On Wed, 2014-11-19 at 14:15 -0600, Patrick Baggett wrote:
On Tue, Nov 18, 2014 at 3:23 AM, Iago Toral Quiroga
ito...@igalia.com wrote:
We have _mesa_swap{2,4} but these do in-place byte-swapping
On Wed, Nov 19, 2014 at 11:42 PM, Iago Toral ito...@igalia.com wrote:
On Wed, 2014-11-19 at 11:43 -0800, Jason Ekstrand wrote:
A couple of specific comments are below. More generally, why are you
only considering the base format on two cases? Do we never use it for
anything else?
I
On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral ito...@igalia.com wrote:
On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote:
By and large, this looks good to me. Most of my comments are cosmetic
or suggestions for added documentation. There is one issue that I
think is subtly wrong
to indicate that that combination should result in
GL_INVALID_OPERATION.
Iago
On Wed, 2014-11-19 at 12:04 -0800, Jason Ekstrand wrote:
Can you remind me again as to what formats hit these paths? I
remember you hitting them, but I'm still not really seeing how it
happens.
--Jason
On Thu, Nov 20, 2014 at 9:33 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral ito...@igalia.com wrote:
It is explained here:
https://bugs.freedesktop.org/show_bug.cgi?id=84566#c35
So one example of this was a glReadPixels where we want to store
On Thu, Nov 20, 2014 at 11:33 PM, Iago Toral ito...@igalia.com wrote:
On Thu, 2014-11-20 at 10:40 -0800, Jason Ekstrand wrote:
On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral ito...@igalia.com
wrote:
Hi Jason,
we discussed this some weeks ago actually, the detailed
On Nov 21, 2014 1:06 PM, Matt Turner matts...@gmail.com wrote:
With bblock_t::end_ip, we can skip entire blocks rather than checking
every instruction in them. Also by making the loops nested (explicitly,
it already was a nested loop), the continue seen at the end of the first
hunk (when
the option for you to do your own hashing if
it's more efficient, but it's no longer needed. Also, if you do do your
own hashing, the hash table will assert that your hash matches what it
expects out of the hashing function. This should make it harder to mess up
your hashing.
Signed-off-by: Jason
If people like this change, I'll do the same thing to the hash set
implementation.
--Jason
On Mon, Nov 24, 2014 at 10:19 PM, Jason Ekstrand ja...@jlekstrand.net
wrote:
Previously, the hash_table API required the user to do all of the hashing
of keys as it passed them in. Since the hashing
On Tue, Nov 25, 2014 at 3:40 PM, Eric Anholt e...@anholt.net wrote:
Jason Ekstrand ja...@jlekstrand.net writes:
Previously, the hash_table API required the user to do all of the hashing
of keys as it passed them in. Since the hashing function is intrinsicly
tied to the comparison
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote:
The i965 backends pass something out of 'screen', which is allocated
per-process, making using this as a ralloc context not thread-safe.
All callers ra_alloc_interference_graph() already ralloc_free() its
return value.
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com wrote:
---
src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c
b/src/mesa/drivers/dri/i965/brw_eu_compact.c
index 7117890..8e33bcb
On Wed, Nov 26, 2014 at 10:59 AM, Matt Turner matts...@gmail.com wrote:
On Wed, Nov 26, 2014 at 10:56 AM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com
wrote:
The i965 backends pass something out of 'screen', which
On Wed, Nov 26, 2014 at 11:10 AM, Matt Turner matts...@gmail.com wrote:
On Wed, Nov 26, 2014 at 10:59 AM, Jason Ekstrand ja...@jlekstrand.net
wrote:
On Wed, Nov 26, 2014 at 10:39 AM, Matt Turner matts...@gmail.com
wrote:
---
src/mesa/drivers/dri/i965/brw_eu_compact.c | 5 +
1
that this
is well-defined to work for dst_size == 32 because a signed shift by 31
isn't well-defined according to the C spec.
With those two fixed, this one is Reviewed-by: Jason Ekstrand
jason.ekstr...@intel.com
--Jason
On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel
-format
piglit test on nouveau, since that test calls
_mesa_base_tex_format with GL_R16F with a context that does not
have ARB_texture_float, so it returns -1 for the BaseFormat, which
was not being catched properly by the ASSERT in init_teximage_fields_ms
until now.
Reviewed-by: Jason Ekstrand
On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
If we need the base format for a mesa_array_format we have to find the
matching mesa_format first. This is expensive because it requires
to loop through all existing mesa formats until we find the right match.
We can
On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
We will use this later on to handle uint conversion scenarios in a master
convert function.
v2:
- Modify pack_uint_*() function generation to use c.datatype()
On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
src/mesa/main/format_pack.c.mako | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
variable.
mesa: Let _mesa_get_format_base_format also handle mesa_array_format.
Jason Ekstrand (9):
mesa/format_utils: Fix a bug in unorm_to_float helper function
mesa: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM
mesa/colormac: Remove an unused macro
mesa: Fix A1R5G5B5
On Mon, Dec 1, 2014 at 11:03 PM, Samuel Iglesias Gonsálvez
sigles...@igalia.com wrote:
On 01/12/14 20:00, Jason Ekstrand wrote:
On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com
wrote:
From: Jason Ekstrand jason.ekstr...@intel.com
We were auto-generating
301 - 400 of 12044 matches
Mail list logo
