[Mesa-dev] [PATCH] nir: allow stitching of non-empty block

2019-01-25 Thread Juan A. Suarez Romero
When stitching two blocks A and B, where A's last instruction is a jump, it is not required that B is empty; it can be plainly removed. This can happen in a situation like this: vec1 1 ssa_1 = load_const (true) vec1 1 ssa_2 = load_const (false) block block_1: [...] loop { vec1 ssa_3 = phi

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-22 Thread Juan A. Suarez Romero
On Tue, 2019-01-15 at 07:21 -0500, Rob Clark wrote: > On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli wrote: > > > > > > On 1/14/19 2:36 PM, Daniel Stone wrote: > > > Hi, > > > > > > On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand wrote: > > > > 5. There's no way with gitlab for Reviewed-by tags

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-14 Thread Juan A. Suarez Romero
On Fri, 2019-01-11 at 16:43 +0200, Andres Gomez wrote: > "&>" is bash specific. > Reviewed-by: Juan A. Suarez J.A. > Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid > sha") > Cc: Juan A. Suarez > Cc: Eric Engestrom > Cc: Dylan Baker > Cc: Emil Velikov >

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-14 Thread Juan A. Suarez Romero
On Fri, 2019-01-11 at 16:42 +0200, Andres Gomez wrote: > "--summary" will also print extended header information such as > creations, renames and mode changes. > > Let's just use "-s", which suppresses the diff output. Reviewed-by: Juan A. Suarez J.A. > > Fixes: 559c32d2412

Re: [Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

2019-01-14 Thread Juan A. Suarez Romero
On Mon, 2019-01-07 at 19:04 +0200, Andres Gomez wrote: > As suggested by Emil Velikov. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- > docs/release-calendar.html | 10 ++ > docs/releasing.html| 14 -- > 2 files

[Mesa-dev] [ANNOUNCE] mesa 18.2.8

2018-12-27 Thread Juan A. Suarez Romero
clang r348827 Jason Ekstrand (1): nir/constant_folding: Fix source bit size logic Jon Turney (1): glx: Fix compilation with GLX_USE_WINDOWSGL Juan A. Suarez Romero (8): docs: add sha256 checksums for 18.2.7 cherry-ignore: add explicit 18.3 only nominations cherry-ignore:

[Mesa-dev] [ANNOUNCE] Mesa 18.2.8 release candidate

2018-12-25 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.8 is now available. Currently we have: - 35 queued - 0 nominated (outstanding) - and 7 rejected patch NOTE: It is anticipated that 18.2.8 will be the final release in the 18.2 series. Users of 18.2 are encouraged to migrate to the 18.3 series in

Re: [Mesa-dev] [PATCH 06/18] glx/test: meson: assorted include fixes

2018-12-24 Thread Juan A. Suarez Romero
On Thu, 2018-12-13 at 16:05 +, Emil Velikov wrote: > From: Emil Velikov > > Swap '..' with the symbolic inc_glx and add glproto as dependency. That > will pull the correct include, effectively fixing the tests on macOS. > > Fixes: a47c525f328 ("meson: build glx") > Signed-off-by: Emil

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

2018-12-24 Thread Juan A. Suarez Romero
On Fri, 2018-12-21 at 09:38 -0800, Kristian Høgsberg wrote: > This regresses at least > dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex > on freedreno: > > Test case > 'dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex'.. > deqp-gles3:

Re: [Mesa-dev] [PATCH] docs: update 18.3 and add 19.x cycles for the release calendar

2018-12-21 Thread Juan A. Suarez Romero
On Tue, 2018-12-18 at 01:09 +0200, Andres Gomez wrote: > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- Acked-by: Juan A. Suarez > docs/release-calendar.html | 118 - > 1 file changed, 116 insertions(+), 2

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

2018-12-20 Thread Juan A. Suarez Romero
On Wed, 2018-12-19 at 09:15 +0100, Iago Toral Quiroga wrote: > The former expects to see SSA-only things, but the latter injects registers. > > The assertions in the lowering where not seeing this because they asserted > on the bit_size values only, not on the is_ssa field, so add that assertion

Re: [Mesa-dev] [PATCH 07/11] radv: Add multiview clears.

2018-12-19 Thread Juan A. Suarez Romero
On Wed, 2017-08-23 at 22:51 +0200, Bas Nieuwenhuizen wrote: > --- > src/amd/vulkan/radv_cmd_buffer.c | 1 + > src/amd/vulkan/radv_meta_clear.c | 65 > > src/amd/vulkan/radv_private.h| 1 + > 3 files changed, 48 insertions(+), 19 deletions(-) > Hi.

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-18 Thread Juan A. Suarez Romero
On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote: > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero > wrote: > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > Cc: Emil Velikov > > > Cc: Andres Gomez > > > Cc: Juan

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-17 Thread Juan A. Suarez Romero
On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > Cc: Emil Velikov > Cc: Andres Gomez > Cc: Juan A. Suarez Romero > Cc: Dylan Baker > Signed-off-by: Eric Engestrom > --- > This patch depends on the releasing procedure in docs/releasing.html to > be updated

Re: [Mesa-dev] [PATCH] nir/constant_folding: Fix source bit size logic

2018-12-17 Thread Juan A. Suarez Romero
On Thu, 2018-12-06 at 14:36 -0600, Jason Ekstrand wrote: > Instead of looking at input_sizes[i] which contains the number of > components for each source, we look at the bit size of input_types[i]. > This fixes a regression in the 1-bit boolean series though I have no > idea how we haven't seen it

Re: [Mesa-dev] [PATCH] nir/constant_folding: fix incorrect bit-size check

2018-12-17 Thread Juan A. Suarez Romero
On Wed, 2018-10-31 at 12:18 +0100, Iago Toral Quiroga wrote: > nir_alu_type_get_type_size takes a type as parameter and we were > passing a bit-size instead, which did what we wanted by accident, > since a bit-size of zero matches nir_type_invalid, which has a > size of 0 too. > --- While this

Re: [Mesa-dev] [PATCH 2/2] ac: split 16-bit ssbo loads that may not be dword aligned

2018-12-17 Thread Juan A. Suarez Romero
On Thu, 2018-12-13 at 17:06 +, Rhys Perry wrote: > Fixes: 7e7ee826982 ('ac: add support for 16bit buffer loads') > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108114 > Signed-off-by: Rhys Perry This patch is a candidate for 18.2 stable, as 7e7ee826982 ('ac: add support for 16bit

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-14 Thread Juan A. Suarez Romero
On Tue, 2018-12-11 at 15:29 +0100, Erik Faye-Lund wrote: > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > Virglrenderer does the wrong thing when given an instance divisor; > > it tries to use the element-index rather than the binding-index as > > the argument to

Re: [Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-14 Thread Juan A. Suarez Romero
On Wed, 2018-12-12 at 09:03 -0800, Dylan Baker wrote: > Thanks for looking into these. I've gone ahead and added the Fixes and Emil's > rb, > plus my rb and pushed *this* patch to master. I've pulled all of the others > except the "delete me" fixup into my branch (since I'll drop that patch

[Mesa-dev] [ANNOUNCE] mesa 18.2.7

2018-12-13 Thread Juan A. Suarez Romero
Juan A. Suarez Romero (5): docs: add sha256 checksums for 18.2.6 cherry-ignore: freedreno: Fix autotools build. cherry-ignore: mesa: Revert INTEL_fragment_shader_ordering support Update version to 18.2.7 docs: add release notes for 18.2.7 Karol Herbst (1): nv50

[Mesa-dev] [ANNOUNCE] Mesa 18.2.7 release candidate

2018-12-11 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.7 is now available. Currently we have: - 30 queued - 0 nominated (outstanding) - and 2 rejected patch The current queue consists of: Several patches fixing leaks in Broadcom drivers, EGL/Wayland, and others. A fix for drisw that solves a crash in

[Mesa-dev] [PATCH] docs: extends 18.2 lifecycle

2018-12-10 Thread Juan A. Suarez Romero
As 18.3 was published with some delay, let's extend 18.2 life for another extra release. CC: Andres Gomez CC: Dylan Baker CC: Emil Velikov --- docs/release-calendar.html | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/release-calendar.html

Re: [Mesa-dev] [Mesa-stable] [PATCH] meson: link LLVM 'native' component when LLVM is available

2018-12-10 Thread Juan A. Suarez Romero
On Mon, 2018-12-10 at 11:52 +, Haehnle, Nicolai wrote: > On 10.12.18 12:36, Emil Velikov wrote: > > Hi Nicolai, > > > > On Thu, 6 Dec 2018 at 13:49, Nicolai Hähnle wrote: > > > From: Nicolai Hähnle > > > > > > Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise, > > > as the

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/8] radv: ignore subpass self-dependencies

2018-12-10 Thread Juan A. Suarez Romero
On Tue, 2018-06-26 at 23:49 +0200, Fredrik Höglund wrote: > These are not automatically performed during a render pass instance. > > Cc: > Signed-off-by: Fredrik Höglund A similar patch like this, 457ac6ce1e2 ("radv: ignore subpass self- dependencies"), is on master, but without the @stable

Re: [Mesa-dev] [PATCH] radv: Flush before vkCmdWriteTimestamp() if needed

2018-12-05 Thread Juan A. Suarez Romero
On Wed, 2018-12-05 at 09:52 +, Alex Smith wrote: > As done for vkCmdBeginQuery() already. Prevents timestamps from being > overwritten by previous vkCmdResetQueryPool() calls if the shader path > was used to do the reset. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108925 >

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

2018-12-04 Thread Juan A. Suarez Romero
On Tue, 2018-12-04 at 07:47 -0800, Matt Turner wrote: > On Tue, Dec 4, 2018 at 3:15 AM Juan A. Suarez Romero > wrote: > > On Mon, 2018-12-03 at 15:38 -0800, Matt Turner wrote: > > > On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov > > > wrote: > > > > On Thu

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Revert INTEL_fragment_shader_ordering support

2018-12-04 Thread Juan A. Suarez Romero
On Mon, 2018-12-03 at 15:38 -0800, Matt Turner wrote: > On Mon, Dec 3, 2018 at 8:12 AM Emil Velikov wrote: > > On Thu, 29 Nov 2018 at 23:54, Matt Turner wrote: > > > This extension is not properly tested (testing for > > > GL_ARB_fragment_shader_interlock is not sufficient), and since this was >

Re: [Mesa-dev] [PATCH] wayland/egl: Ensure EGL surface is resized on DRI update_buffers()

2018-12-03 Thread Juan A. Suarez Romero
On Mon, 2018-12-03 at 17:08 +, Emil Velikov wrote: > Hi Carlos, > > On Mon, 3 Dec 2018 at 08:09, Carlos Garnacho wrote: > > Fullscreening and unfullscreening a totem window while playing a video > > sometimes results in the video subsurface not changing size along. This > > is also

[Mesa-dev] [ANNOUNCE] mesa 18.2.6

2018-11-28 Thread Juan A. Suarez Romero
ers that are used by transform feedback objects r600: clean up the GS ring buffers when the context is destroyed glsl: free or reuse memory allocated for TF varying Jason Ekstrand (2): nir/lower_alu_to_scalar: Don't try to lower unpack_32_2x16 anv: Put robust buffer access in the

[Mesa-dev] [ANNOUNCE] Mesa 18.2.6 release candidate

2018-11-26 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.6 is now available. Currently we have: - 40 queued (+1 squashed) - 0 nominated (outstanding) - and 7 rejected patch The current queue consists of: Several patches fixing leaks in glsl, winsys and r600. Improvements in the scripts that helps in

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Juan A. Suarez Romero
On Mon, 2018-11-26 at 13:13 +0100, Erik Faye-Lund wrote: > On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > > If glGetTexImage or glGetnTexImage is called with a level that > > > doesn't &

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Juan A. Suarez Romero
On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > If glGetTexImage or glGetnTexImage is called with a level that doesn't > exist, we get an error message on this form: > > Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) > > This is clearly nonsensical, because these APIs

Re: [Mesa-dev] [PATCH 0/6] glGetTexImage fixes

2018-11-23 Thread Juan A. Suarez Romero
On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > I was recently investigating a gl-error that appears some times while > using virgl, where I got a pretty nonsensical GL-error: > > Mesa: User error: GL_INVALID_VALUE in glGetnTexImageARB(depth = 0) > > Now, the reason why this is

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-23 Thread Juan A. Suarez Romero
On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: Typo in the subject (s/detph/depth) > If glGetTexImage or glGetnTexImage is called with a level that doesn't > exist, we get an error message on this form: > > Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) > > This is

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] anv: Put robust buffer access in the pipeline hash

2018-11-23 Thread Juan A. Suarez Romero
On Wed, 2018-11-21 at 17:20 -0600, Jason Ekstrand wrote: > It affects apply_pipeline_layout. Shaders compiled with the wrong value > will work but they may not be robust as requested by the app. > > Cc: mesa-sta...@lists.freedesktop.org Hi, Jason. This patch does not apply cleanly in 18.2

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] travis: drop unneeded x11proto-xf86vidmode-dev

2018-11-21 Thread Juan A. Suarez Romero
On Fri, 2018-11-16 at 13:59 +, Emil Velikov wrote: > From: Emil Velikov > > The only place where the package is needed is for building the DRI > based libGL library. > This caused a conflict when applied to 18.2 branch. Resolved the (trivial) conflict as

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

2018-11-20 Thread Juan A. Suarez Romero
On Tue, 2018-11-20 at 11:13 +0100, Juan A. Suarez Romero wrote: > On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote: > > This reverts commit . > > > > For this to work the compiler must ensure that it never puts > > the values that arrive to this hel

Re: [Mesa-dev] [PATCH] Revert "nir/builder: Assert that intN_t immediates fit"

2018-11-20 Thread Juan A. Suarez Romero
On Tue, 2018-11-20 at 09:47 +0100, Iago Toral Quiroga wrote: > This reverts commit . > > For this to work the compiler must ensure that it never puts > the values that arrive to this helper into unsigned variables > at any point in its processing, since that would not apply sign > extension to

Re: [Mesa-dev] [PATCH] meson: Don't set -Wall

2018-11-19 Thread Juan A. Suarez Romero
On Fri, 2018-11-09 at 13:28 -0800, Dylan Baker wrote: > meson does this for you with it's warn levels, so we don't need to set > it ourselves. > > Fixes: d1992255bb29054fa51763376d125183a9f602f3 >("meson: Add build Intel "anv" vulkan driver") Hi. I've cherry-picked this commit for next

Re: [Mesa-dev] [PATCH mesa 3/3] meson: fix wayland-less builds

2018-11-19 Thread Juan A. Suarez Romero
On Thu, 2018-10-11 at 16:36 +0100, Eric Engestrom wrote: > Those empty variables in the !wayland case are useless and running that > meson.build with them breaks the build: > > [287/850] Generating wayland-drm-client-protocol.h with a custom command. > FAILED:

[Mesa-dev] [ANNOUNCE] mesa 18.2.5

2018-11-15 Thread Juan A. Suarez Romero
KHR/khrplatform.h when needed meson: install KHR/khrplatform.h when needed Gert Wollny (1): virgl/vtest-winsys: Use virgl version of bind flags Jonathan Gray (1): intel/tools: include stdarg.h in error2aub Juan A. Suarez Romero (5): docs: add sha256 checksums for 18.2.4

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.5 release candidate

2018-11-15 Thread Juan A. Suarez Romero
On Tue, 2018-11-13 at 16:26 -0800, Matt Turner wrote: > On Mon, Nov 12, 2018 at 8:35 AM Juan A. Suarez Romero > wrote: > > Hello list, > > > > The candidate for the Mesa 18.2.5 is now available. Currently we have: > > - 25 queued > > - 0 nominated (outs

Re: [Mesa-dev] [PATCH 10/9] bin/get-pick-list.sh: handle reverts prior to the branchpoint

2018-11-15 Thread Juan A. Suarez Romero
On Wed, 2018-11-14 at 18:52 +, Emil Velikov wrote: > On Wed, 14 Nov 2018 at 18:51, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently we detect when a breaking commit: > > - has landed in stable, and > > - is referenced by a untagged fix in master > > > > Yet we did not

Re: [Mesa-dev] [PATCH 2/9] bin/get-pick-list.sh: prefix output with "[stable] "

2018-11-15 Thread Juan A. Suarez Romero
On Thu, 2018-11-08 at 15:05 +, Emil Velikov wrote: > From: Emil Velikov > > With later commits we'll fold all the different scripts into one. > Add the explicit prefix, so that we know the origin of the nomination > > v2: > - pass the sha as argument to the function > - drop $tag = none

[Mesa-dev] [ANNOUNCE] Mesa 18.2.5 release candidate

2018-11-12 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.5 is now available. Currently we have: - 25 queued - 0 nominated (outstanding) - and 2 rejected patch The current queue consists of: A patch for nine state tracker that fixes several crashes using nine's thread_submit feature. There are other

Re: [Mesa-dev] [Mesa-stable] [PATCH v3] autotools: library-dependency when no sse and 32-bit

2018-11-09 Thread Juan A. Suarez Romero
On Thu, 2018-11-08 at 15:53 +, Emil Velikov wrote: > On Thu, 1 Nov 2018 at 11:03, Sergii Romantsov > wrote: > > Building of 32bit Mesa may fail if __SSE__ is not specified. > > Added missed dependency from libm. > > > > v2: avoided dependecy on any flag, just link > > > > v3: meson doesn't

Re: [Mesa-dev] [PATCH 3/3] docs: document the staging branch and add reference to it

2018-11-08 Thread Juan A. Suarez Romero
On Thu, 2018-11-08 at 14:48 +, Emil Velikov wrote: > On Thu, 8 Nov 2018 at 11:54, Juan A. Suarez Romero > wrote: > > On Wed, 2018-11-07 at 16:02 +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > A while back we agreed that hav

Re: [Mesa-dev] [PATCH 2/4] bin/get-pick-list.sh: prefix output with "[stable] "

2018-11-08 Thread Juan A. Suarez Romero
On Wed, 2018-11-07 at 12:07 +, Emil Velikov wrote: > From: Emil Velikov > > With later commits we'll fold all the different scripts into one. > Add the explicit prefix, so that we know the origin of the nomination > > Signed-off-by: Emil Velikov > --- > bin/get-pick-list.sh | 21

Re: [Mesa-dev] [PATCH 3/3] docs: document the staging branch and add reference to it

2018-11-08 Thread Juan A. Suarez Romero
e. > > CC: Andres Gomez > CC: Dylan Baker > CC: Juan A. Suarez Romero > Signed-off-by: Emil Velikov > --- > docs/releasing.html | 20 > docs/submittingpatches.html | 3 +++ > 2 files changed, 23 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 01/12] travis: bump required LLVM version to 5.0

2018-11-08 Thread Juan A. Suarez Romero
On Wed, 2018-10-31 at 13:29 +, Emil Velikov wrote: > From: Emil Velikov > > We'll bump the number in the build systems shortly. Update the travis > file, first, to avoid intermittent failures. > > This effectively removes LLVM 3.9 and 4.0 from the build matrix. >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: disable conditional rendering for vkCmdCopyQueryPoolResults()

2018-11-08 Thread Juan A. Suarez Romero
On Mon, 2018-11-05 at 09:54 +0100, Samuel Pitoiset wrote: > VK_EXT_conditional_rendering says that copy commands should not be > affected by conditional rendering. > > Cc: 18.2 18.3 > Signed-off-by: Samuel Pitoiset This patch didn't apply cleanly on 18.2, so I've resolved the trivial

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-07 Thread Juan A. Suarez Romero
On Tue, 2018-11-06 at 14:59 +0100, Erik Faye-Lund wrote: > > > On Nov 6, 2018 13:51, "Juan A. Suarez Romero" wrote: > > On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote: > > > On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund > > > wrote: >

Re: [Mesa-dev] [PATCH mesa 2/2] wsi/wayland: only finish() a successfully init()ed display

2018-11-06 Thread Juan A. Suarez Romero
On Mon, 2018-11-05 at 10:00 +, Eric Engestrom wrote: > Cc: Dave Airlie > Cc: Philipp Zabel > Signed-off-by: Eric Engestrom > --- > src/vulkan/wsi/wsi_common_wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/vulkan/wsi/wsi_common_wayland.c >

Re: [Mesa-dev] [Mesa-stable] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-11-06 Thread Juan A. Suarez Romero
On Tue, 2018-11-06 at 09:53 +0100, Olivier Fourdan wrote: > Hi > > On Thu, Oct 25, 2018 at 5:51 PM Juan A. Suarez Romero > wrote: > > On Thu, 2018-10-25 at 14:48 +0200, Olivier Fourdan wrote: > > > After commit a9fb331ea ("wayland/egl: update surface size on wi

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-06 Thread Juan A. Suarez Romero
On Tue, 2018-11-06 at 10:32 +, Emil Velikov wrote: > On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund > wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > > wrote: > > > > EXT_shader_implicit_conversions is a useful extension

Re: [Mesa-dev] [Mesa-stable] [PATCH] virgl/vtest-winsys: Use virgl version of bind flags

2018-11-06 Thread Juan A. Suarez Romero
On Fri, 2018-11-02 at 15:23 +, Emil Velikov wrote: > On Thu, 1 Nov 2018 at 09:50, Gert Wollny wrote: > > From: Gert Wollny > > > > The bind flags defined by mesa/gallium might not always be in sync > > with the ones copied to virglrenderer/gallium. Therefore, use the > > flags defined in

Re: [Mesa-dev] Mesa 18.3.0 release plan

2018-11-06 Thread Juan A. Suarez Romero
On Tue, 2018-10-30 at 17:45 +, Emil Velikov wrote: > Hi all, > > Here is the tentative release plan for 18.3.0. > > As many of you are well aware, it's time to the next branch point. > Although we were a bit slow on updating the calendar, it the dates > have been around for weeks. > > Oct

[Mesa-dev] [ANNOUNCE] mesa 18.2.4

2018-10-31 Thread Juan A. Suarez Romero
3DSTATE_WM prior to 3DSTATE_WM_HZ_OP anv: Flag semaphore BOs as external Juan A. Suarez Romero (4): docs: add sha256 checksums for 18.2.3 cherry-ignore: Revert "anv/skylake: disable ForceThreadDispatchEnable" Update version to 18.2.4 docs: add release notes

[Mesa-dev] [ANNOUNCE] Mesa 18.2.4 release candidate

2018-10-29 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.4 is now available. Currently we have: - 22 queued - 0 nominated (outstanding) - and 1 rejected patch The current queue consists of: Different fixes for different drivers: freedreno, radeonsi, swr, anv and radv. Also there are fixes for ac,

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Juan A. Suarez Romero
7d2429dacf650b4054638 > > > > Our submittingpatches.html doc says that using the Fixes tag should be > enough. Did I miss something here? > No, the fixes tag is correct. In fact the commit that Jason mentions is this one. > -Nanley > > > On October 29, 2018 06:49:47 &q

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-29 Thread Juan A. Suarez Romero
On Thu, 2018-10-25 at 16:25 -0700, nanleych...@gmail.com wrote: > From: Nanley Chery > > Follow the restriction of making sure the clear value is between the min > and max values defined in CC_VIEWPORT. Avoids a simulator warning for > some piglit tests, one of them being: > >

Re: [Mesa-dev] [PATCH 2/2] Revert "anv/skylake: disable ForceThreadDispatchEnable"

2018-10-29 Thread Juan A. Suarez Romero
On Tue, 2018-10-16 at 15:12 -0500, Jason Ekstrand wrote: > This reverts commit 0fa9e6d7b304f6a8064ed78a4b9c557e1026e7e5. The real > issue appears to have been that HiZ ops don't like having WM thread > dispatch force-enabled. The previous commit fixes that problem so we > can go back to using

Re: [Mesa-dev] [PATCH 1/2] blorp: Emit a dummy 3DSTATE_WM prior to 3DSTATE_WM_HZ_OP

2018-10-29 Thread Juan A. Suarez Romero
On Tue, 2018-10-16 at 15:12 -0500, Jason Ekstrand wrote: > Suggested-by: Francisco Jerez > --- > src/intel/blorp/blorp_genX_exec.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/blorp/blorp_genX_exec.h > b/src/intel/blorp/blorp_genX_exec.h > index

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] util: Change remaining uint32 cache ids to sha1

2018-10-26 Thread Juan A. Suarez Romero
On Fri, 2018-10-26 at 14:52 +1100, Timothy Arceri wrote: > Pushed. Thanks again! > > Ccing stable in case the Fixes tag isnt enough for this to get picked up > (since the previous cache fix this fixes was also backported) > Enqueued for 18.2. I didn't apply cleanly, so I've fixed the

Re: [Mesa-dev] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-10-25 Thread Juan A. Suarez Romero
e EGL surface size unchanged. > > To avoid the issue, partially revert the part of commit a9fb331ea for > `swrast_update_buffers()` and resize on the win size and not the > attached size. > > Fixes: a9fb331ea - wayland/egl: update surface size on window resize > Sig

Re: [Mesa-dev] 18.3 release plan

2018-10-25 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 09:19 -0700, Dylan Baker wrote: > Hi List, > > It's that time again, release time! We're a little late getting started, but > here's the plan: > > Branch point/RC1: 10/31 > RC2: 11/7 > RC3: 11/14 > RC4/final release: 11/21 > > With point releases following the normal two

Re: [Mesa-dev] [PATCH] docs/calendar: Add 18.3 plan and expand 18.2

2018-10-25 Thread Juan A. Suarez Romero
On Wed, 2018-10-24 at 18:32 +0100, Emil Velikov wrote: > From: Dylan Baker > > Emil will be helping out with 18.3, while Juan finalises 18.2 > > v2: add Emil for 18.3, fix typos Reviewed-by: Juan A. Suarez J.A. > > CC: Emil Velikov > CC: Juan A. Romero S

Re: [Mesa-dev] [PATCH 1/4] gen: Add EXT_vertex_attrib_64bit.xml to dependency lists

2018-10-24 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > Which is also required to put it in the tarball, a requirement for > building with meson from the tarball. > > CC: Ian Romanick > CC: Marek Olšák > Fixes: 263c962cfdee6b43578ee5f28601309ea77d1434 >("mesa: expose

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Juan A. Suarez Romero
On Wed, 2018-10-24 at 09:16 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-10-24 09:10:37) > > On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > > > There are two problems with the fixed patch. First, it fails to create a > > > dependency on the

Re: [Mesa-dev] [PATCH v2 1/2] move u_math to src/util

2018-10-24 Thread Juan A. Suarez Romero
On Wed, 2018-09-05 at 14:55 -0700, Dylan Baker wrote: > Currently we have two sets of functions for bit counts, one in gallium > and one in core mesa. The ones in core mesa are header only in many > cases, since they reduce to "#define _mesa_bitcount popcount", but they > provide a fallback

Re: [Mesa-dev] [PATCH 4/4] autotools: include intel_tiled_memcopy.c

2018-10-24 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > There are two problems with the fixed patch. First, it fails to create a > dependency on the sourced .c file, so changes to intel_tiled_memcpy.c > won't trigger a rebuild. It also doesn't get included in the dist > tarball. > > CC: Tapani

Re: [Mesa-dev] [PATCH 3/4] meson: fix formatting and add extra_files to i965

2018-10-24 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 15:56 -0700, Dylan Baker wrote: > extra_files is just a nice way to to tell certain IDE's (and those > reading the file) that this file is also a dependency. Meson will use > the .d file generated by the compiler to figure out what the target > actually depends on.

Re: [Mesa-dev] [PATCH] docs/calendar: Add 18.3 plan and expand 18.2

2018-10-23 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 09:30 -0700, Dylan Baker wrote: > CC: Emil Velikov > CC: Juan A. Romero Suarez > --- > docs/release-calendar.html | 38 +- > 1 file changed, 37 insertions(+), 1 deletion(-) > > diff --git a/docs/release-calenda

[Mesa-dev] [PATCH v2] nir: fix nir_copy_propagation test

2018-10-23 Thread Juan A. Suarez Romero
Use nir_src_comp_as_uint() to read the proper second component, as nir_src_as_uint() returns the first one. v2: Use nir_src_comp_as_uint() [Jason] Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core code") Signed-off-by: Juan A. Suarez Romero

Re: [Mesa-dev] [PATCH] nir: fix nir_copy_propagation test

2018-10-23 Thread Juan A. Suarez Romero
On Tue, 2018-10-23 at 09:26 -0500, Jason Ekstrand wrote: > The commit message is correct but doesn't match the patch. > > On October 23, 2018 08:59:25 "Juan A. Suarez Romero" > wrote: > > > Commit 16870de8a0a introduced the use of nir_src_as_* functions, so

[Mesa-dev] [PATCH] nir: fix nir_copy_propagation test

2018-10-23 Thread Juan A. Suarez Romero
Commit 16870de8a0a introduced the use of nir_src_as_* functions, so copy_propagation tests need to check expected value for the first component. Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core code") Signed-off-by: Juan A. Suarez Romero

[Mesa-dev] [ANNOUNCE] mesa 18.2.3

2018-10-19 Thread Juan A. Suarez Romero
to registers anv/batch_chain: Don't start a new BO just for BATCH_BUFFER_START nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions intel: Don't propagate conditional modifiers if a UD source is negated Juan A. Suarez Romero (3): docs: add sha256 checksu

[Mesa-dev] [ANNOUNCE] Mesa 18.2.3 release candidate

2018-10-18 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.3 is now available. Currently we have: - 38 queued - 1 nominated (outstanding) - and 0 rejected patches The current queue consists of: Several fixes and workarounds for different games, inlcuding RAGE, Yakuza and The Evil Within, Wolfenstein The

Re: [Mesa-dev] [Mesa-stable] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

2018-10-11 Thread Juan A. Suarez Romero
On Wed, 2018-10-03 at 11:49 +0100, Emil Velikov wrote: > HI Tim, > > On Wed, 19 Sep 2018 at 23:55, Timothy Arceri wrote: > > > > Timestamp can be zero for example when Flatpak is used. In this > > case just disable the cache rather then segfaulting when > > incompatible cache items are loaded.

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: ignore trailing whitespace when define redefined

2018-10-10 Thread Juan A. Suarez Romero
On Wed, 2018-10-10 at 11:03 +1100, Timothy Arceri wrote: > The Nvidia/AMD binary drivers allow this, as does GCC. > > This fixes shader compilation issues in the latest update of > No Mans Sky. > > Cc: mesa-sta...@lists.freedesktop.org This patch landed in upstream without the CC: mesa-stable.

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv: Use separate MOCS settings for external BOs

2018-10-10 Thread Juan A. Suarez Romero
On Tue, 2018-10-02 at 16:11 -0500, Jason Ekstrand wrote: > On Broadwell and above, we have to use different MOCS settings to allow > the kernel to take over and disable caching when needed for external > buffers. On Broadwell, this is especially important because the kernel > can't disable eLLC

[Mesa-dev] [ANNOUNCE] mesa 18.2.2

2018-10-05 Thread Juan A. Suarez Romero
support when not using dri Eric Anholt (1): vc4: Fix sin(0.0) and cos(0.0) accuracy to fix SDL rendering rotation. Eric Engestrom (1): vulkan/wsi/display: check if wsi_swapchain_init() succeeded Jason Ekstrand (1): anv,radv: Implement vkAcquireNextImage2 Juan A. Suarez Romero (3

[Mesa-dev] [PATCH] docs: update calendar

2018-10-05 Thread Juan A. Suarez Romero
I'll take care of 18.2 releases series on Andres behalf. CC: Andres Gomez CC: Dylan Baker CC: Emil Velikov --- docs/release-calendar.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.2 release candidate

2018-10-03 Thread Juan A. Suarez Romero
On Wed, 2018-10-03 at 16:54 +0200, Michel Dänzer wrote: > On 2018-10-03 2:41 p.m., Juan A. Suarez Romero wrote: > > Hello list, > > > > The candidate for the Mesa 18.2.2 is now available. Currently we have: > > - 20 queued (+1 squashed) > > - 2 nominated (o

[Mesa-dev] [ANNOUNCE] Mesa 18.2.2 release candidate

2018-10-03 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.2.2 is now available. Currently we have: - 20 queued (+1 squashed) - 2 nominated (outstanding) - and 0 rejected patches The current queue consists of: Different patches for the DirectX9 and DRI state trackers. A patch to implement

Re: [Mesa-dev] [Mesa-stable] [PATCH] vulkan: Disable randr lease for libxcb < 1.13

2018-10-02 Thread Juan A. Suarez Romero
On Tue, 2018-10-02 at 08:23 +1000, Stuart Young wrote: > Just a follow-up to make sure this makes it into mesa-stable. > > I know the release window for 18.2.2 is coming up. > This was already enqueued for 18.2. J.A. > > On Thu, 27 Sep 2018 at 16:32, Dave Airlie wrote: > > On Thu,

Re: [Mesa-dev] [Mesa-stable] [PATCH 22/22 v2] radeonsi: NaN should pass kill_if

2018-10-01 Thread Juan A. Suarez Romero
> Marek > > On Mon, Oct 1, 2018 at 6:25 PM Juan A. Suarez Romero > wrote: > > > > On Mon, 2018-10-01 at 14:29 -0400, Marek Olšák wrote: > > > The attached patch is for 18.2. > > > > > > > > > Not sure if I've explained myse

Re: [Mesa-dev] [Mesa-stable] [PATCH 22/22 v2] radeonsi: NaN should pass kill_if

2018-10-01 Thread Juan A. Suarez Romero
as 98f777f9d9c is not CCed as stable, it seems more logical just to ignore 0d495bec25b. But I'd like to know what's your preferrence. J.A. > Thanks, > Marek > On Mon, Oct 1, 2018 at 4:14 AM Juan A. Suarez Romero > wrote: > > > > On Mon, 2018-09-24 at 20:2

Re: [Mesa-dev] [PATCH] i965: Don't bother to call blorp if the blit is zero-sized

2018-10-01 Thread Juan A. Suarez Romero
On Tue, 2018-09-11 at 11:15 -0500, Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892 > --- > src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++ > 1 file changed, 3 insertions(+) > This has been reviewed, but not pushed

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/blorp: Emit depth flush and stall prior to HiZ clears

2018-10-01 Thread Juan A. Suarez Romero
On Fri, 2018-08-31 at 14:48 -0700, Chad Versace wrote: > On Fri 31 Aug 2018, Jason Ekstrand wrote: > > We had the flush/stall after the clear but missed the one that needs to > > go before the clear. > > IIUC, Chad has given a R+1 to this. So I think this patch can be pushed, right?

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 2/2] meson: swr: do a second llvm search with extra modules for llvm >= 7

2018-10-01 Thread Juan A. Suarez Romero
On Mon, 2018-09-24 at 13:33 -0700, Dylan Baker wrote: > Quoting Chuck Atkins (2018-09-24 13:24:29) > > Hi Dylan, > > > > > > I think you could simplify this: > > > > > + if dep_llvm.found() and with_gallium_swr and dep_llvm.version > > ().version_compare('>= 7') > > > +

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/nine: do not double-close the fd on teardown

2018-10-01 Thread Juan A. Suarez Romero
On Wed, 2018-08-29 at 18:13 +0100, Emil Velikov wrote: > From: Emil Velikov > > As the newly introduced comment says: > The pipe loader takes ownership of the fd > > Thus, there's no need to close it again. This patch seems to be already reviewed, but not pushed to upstream. J.A.

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/6] egl: make eglSwapBuffers* a no-op for !window surfaces

2018-10-01 Thread Juan A. Suarez Romero
On Mon, 2018-09-03 at 13:05 +0100, Emil Velikov wrote: > From: Emil Velikov > > Analogous to the previous commit - the spec says the function is a > no-op when a pbuffer or pixmap surface is used. > This series seems to be reviewed, but not pushed yet in master. J.A. > Cc: samiuddi

Re: [Mesa-dev] [Mesa-stable] [PATCH 22/22 v2] radeonsi: NaN should pass kill_if

2018-10-01 Thread Juan A. Suarez Romero
On Mon, 2018-09-24 at 20:21 -0400, Marek Olšák wrote: > Looks good to me. > > Marek This patch was nominated to stable, but I can't apply it on 18.2 because this patch requires 98f777f9d9c ("radeonsi: remove fetch_args callbacks for ALU instructions"), which was not nominated. WDYT? Should both

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: add a workaround for bitfield_extract when count is 0

2018-09-25 Thread Juan A. Suarez Romero
On Sat, 2018-09-22 at 12:38 +1000, Timothy Arceri wrote: > This ports the fix from 3d41757788ac. Both LLVM 7 & 8 continue > to have this problem. > > It fixes rendering issues in some menu and loading screens of > Civ VI which can be seen in the trace from bug 104602. > Thank you. Added this

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv, radv: Implement vkAcquireNextImage2

2018-09-24 Thread Juan A. Suarez Romero
On Sun, 2018-09-23 at 17:01 +0200, Jason Ekstrand wrote: > > On September 23, 2018 16:17:36 Emil Velikov wrote: > > > Hi Jason, > > > > On 20 September 2018 at 11:33, Jason Ekstrand wrote: > > > This was added as part of 1.1 but it's very hard to track exactly what > > > extension added it.

[Mesa-dev] [ANNOUNCE] mesa 18.2.1

2018-09-21 Thread Juan A. Suarez Romero
cks before unrolling nir/opt_if: Re-materialize derefs in use blocks before peeling loops Josh Pieper (1): st/mesa: Validate the result of pipe_transfer_map in make_texture (v2) Juan A. Suarez Romero (3): cherry-ignore: radv: fix descriptor pool allocation size Update version to 18

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.2.1 release candidate

2018-09-21 Thread Juan A. Suarez Romero
On Thu, 2018-09-20 at 19:21 +0200, Bas Nieuwenhuizen wrote: > On Wed, Sep 19, 2018 at 11:43 PM Juan A. Suarez Romero > wrote: > > > > Hello list, > > > > The candidate for the Mesa 18.2.1 is now available. Currently we have: > > - 57 queued (+1 squas

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix driver UUID SHA1 init.

2018-09-21 Thread Juan A. Suarez Romero
On Thu, 2018-09-20 at 20:16 +0200, Bas Nieuwenhuizen wrote: > On Thu, Sep 20, 2018 at 7:33 PM Eric Engestrom > wrote: > > > > On Thursday, 2018-09-20 19:17:57 +0200, Bas Nieuwenhuizen wrote: > > > Was missing the init, found by Emil. > > > > > > Fixes: d17443a4593 "radv: Use build ID if

Re: [Mesa-dev] [PATCH v2 4/5] gitlab-ci: update base + llvm images with scheduled pipelines

2018-09-21 Thread Juan A. Suarez Romero
On Thu, 2018-09-20 at 16:53 -0700, Eric Anholt wrote: > "Juan A. Suarez Romero" writes: > > > On Tue, 2018-09-04 at 08:19 -0700, Eric Anholt wrote: > > > "Juan A. Suarez Romero" writes: > > > > > > > Use scheduled pipelines to updat

<    1   2   3   4   5   6   7   8   9   10   >