[Mesa-dev] [PATCH] glx: Extra gc null check for glXMakeCurrent

Extra null check before accessing user given context pointer. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcurrent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c index a6884cf..b9f259e 100644

[Mesa-dev] [PATCH] mesa: add assert after calloc before access memory in attrib.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index c9332bd..5185f89 100644 --- a/src/mesa/main/attrib.c +++ b/src/mesa/main/attrib.c @@ -1488,6

[Mesa-dev] [PATCH] glx: Add assert after malloc before accessing memory in glx/clientattrib.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/clientattrib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/clientattrib.c b/src/glx/clientattrib.c index 1b306ea..6162b49 100644 --- a/src/glx/clientattrib.c +++ b/src/glx/clientattrib.c @@ -76,6 +76,9

[Mesa-dev] [PATCH 3/3] mesa: Verify memory allocations success in _mesa_PushAttrib

Check if any of the callocs fail and report it with _mesa_error if needed. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 106 - 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 0/3] Fix Klocwork found issues

probably will not be causing majority of problems in anycase. Juha-Pekka Heikkila (3): glx: Check malloc return value before accessing memory in glx/clientattrib.c mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success

[Mesa-dev] [PATCH 1/3] glx: Check malloc return value before accessing memory in glx/clientattrib.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/clientattrib.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glx/clientattrib.c b/src/glx/clientattrib.c index 1b306ea..a26906f 100644 --- a/src/glx/clientattrib.c +++ b/src/glx/clientattrib.c @@ -76,6

[Mesa-dev] [PATCH 2/3] mesa: Verify memory allocations success in _mesa_PushClientAttrib

Check if any of the callocs fail and report it with _mesa_error if needed. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/attrib.c b

[Mesa-dev] [PATCH] glx: Add missing null check in gxl/dri2_glx.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2_glx.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 3b33312..bfeebed 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -676,6 +676,10

[Mesa-dev] [PATCH 0/3] More Klocwork found issues

Simple memory allocation checks became long patches. Juha-Pekka Heikkila (3): Mesa: Change save_attrib_data() to return boolean mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success in _mesa_PushAttrib src/mesa/main/attrib.c | 394

[Mesa-dev] [PATCH 3/3] mesa: Verify memory allocations success in _mesa_PushAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 320 + 1 file changed, 272 insertions(+), 48 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 87797d1..3083e21 100644

[Mesa-dev] [PATCH 2/3] mesa: Verify memory allocations success in _mesa_PushClientAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..87797d1 100644

[Mesa-dev] [PATCH 1/3] Mesa: Change save_attrib_data() to return boolean

Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 8a2a268

[Mesa-dev] [PATCH] glx: Add missing null check in DRI2WireToEvent

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..deb50ab 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c @@ -102,6 +102,8 @@ DRI2WireToEvent(Display *dpy, XEvent

[Mesa-dev] [PATCH 2/5] mesa: Verify memory allocations success in _mesa_PushClientAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..87797d1 100644

[Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 8a2a268

[Mesa-dev] [PATCH 3/5] mesa: Verify memory allocations success in _mesa_PushAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 227 +++-- 1 file changed, 144 insertions(+), 83 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 87797d1..e41b981 100644

[Mesa-dev] [PATCH 0/5] Klocwork related patches

if it was to start handling allocation of the incoming attribute parameter allocation. Added the missing space for patch to DRI2WireToEvent (I blame autoformatter for losing this originally :) ) and new to the Klocwork patch list is patch to dri2CreateDrawable Juha-Pekka Heikkila (5): Mesa: Change

[Mesa-dev] [PATCH 4/5] glx: Add missing null check in DRI2WireToEvent

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glx/dri2.c b/src/glx/dri2.c index bcd1f9c..7e8fdea 100644 --- a/src/glx/dri2.c +++ b/src/glx/dri2.c @@ -102,6 +102,8 @@ DRI2WireToEvent(Display *dpy, XEvent

[Mesa-dev] [PATCH 5/5] glx: Add missing null check in dri2CreateDrawable

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2_glx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index bfeebed..e553004 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -397,6 +397,12

[Mesa-dev] [PATCH 5/5] glx: add missing null check in dri2_bind_tex_image

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2_glx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..b72a859 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -990,6 +990,9

[Mesa-dev] [PATCH 0/5] More null checks from Klocwork

not miss any of Brian's comments. Extra null checking in dri2_bind_tex_image is new to my set. /Juha-Pekka Juha-Pekka Heikkila (5): Mesa: Change save_attrib_data() to return boolean mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success

[Mesa-dev] [PATCH 2/5] mesa: Verify memory allocations success in _mesa_PushClientAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 70 ++ 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 3ecf533..4ce8923 100644

[Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 8a2a268

[Mesa-dev] [PATCH 4/5] glx: Add missing null check in dri2CreateDrawable

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2_glx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index bfeebed..309c1e7 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -366,6

[Mesa-dev] [PATCH 3/5] mesa: Verify memory allocations success in _mesa_PushAttrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c | 236 +++-- 1 file changed, 152 insertions(+), 84 deletions(-) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index 4ce8923..0671b74 100644

[Mesa-dev] [PATCH 1/3] glx: add missing null check in dri2_bind_tex_image

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri2_glx.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 309c1e7..ae807ee 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_glx.c @@ -991,10

[Mesa-dev] [PATCH 2/3] glx: Fix two identical null check errors in driSet/GetInterval

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri_glx.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..91cccac 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c

[Mesa-dev] [PATCH 3/3] Mesa: add asserts in load_texunit_bumpmap

In load_texunit_bumpmap tc_array is asserted so lets assert rot_mat_0 and rot_mat_1 also which are coming from same path. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 1/3] glx: Fix two identical null check errors in driSet/GetInterval

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/dri_glx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c index 0b89e3e..2e00bf0 100644 --- a/src/glx/dri_glx.c +++ b/src/glx/dri_glx.c

[Mesa-dev] [PATCH 2/3] Mesa: Add asserts into emit_fog_instructions

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 16715f6..6e91697 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 3/3] Mesa: Assert variable coming from get_variable() in get_current_attrib

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 6e91697..ba6258d 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH] glx: Add missing null checks in glxcmds.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index b5377c2..38a5262 100644 --- a/src/glx/glxcmds.c +++ b/src/glx

[Mesa-dev] [PATCH] glx: Add missing null check in __glXCloseDisplay

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 2711e57..4a195bd 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -269,7 +269,8

[Mesa-dev] [PATCH] glsl: Fix null access on file read error

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index aa188b1..755bc9a 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -221,7 +221,7

[Mesa-dev] [PATCH 2/2] glx: Add some missing null checks in glx_pbuffer.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glx_pbuffer.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 183fbaa..411d6e5 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx

[Mesa-dev] [PATCH 1/2] glsl: Fix null access on file read error

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index aa188b1..ff69c9a 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -221,7 +221,7

[Mesa-dev] [PATCH 0/2] two Klocwork related patches.

a build error. Juha-Pekka Heikkila (2): glsl: Fix null access on file read error glx: Add some missing null checks in glx_pbuffer.c src/glsl/main.cpp | 3 ++- src/glx/glx_pbuffer.c | 19 +++ 2 files changed, 17 insertions(+), 5 deletions(-) -- 1.8.1.2

[Mesa-dev] [PATCH 1/2] glx: Add missing null check in __glXNewIndirectAPI()

Add extra null check in auto generated indirect_init.c via src/mapi/glapi/gen/glX_proto_send.py Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mapi/glapi/gen/glX_proto_send.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b

[Mesa-dev] [PATCH 0/2] More null checks into glx

Still Klocwork related patches. Juha-Pekka Heikkila (2): glx: Add missing null check in __glXNewIndirectAPI() glx: check memory allocations in __glXInitVertexArrayState() src/glx/indirect_vertex_array.c | 27 +++ src/mapi/glapi/gen/glX_proto_send.py | 2 ++ 2

[Mesa-dev] [PATCH 2/2] glx: check memory allocations in __glXInitVertexArrayState()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_vertex_array.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/glx/indirect_vertex_array.c b/src/glx/indirect_vertex_array.c index 1d26c5e..0025cbb 100644

[Mesa-dev] [PATCH 2/2] mesa: Add extra null check in _mesa_GenerateMipmap()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/fbobject.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 2892784..6b88e7d 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 1/2] glsl: Fix memcpy size in ir_constant

ir_constant::ir_constant(const struct glsl_type, const ir_constant_data *) was copying too much memory. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/ir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index

[Mesa-dev] [PATCH] glx: Add missing null check in glXCreateContextAttribsARB

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/create_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/create_context.c b/src/glx/create_context.c index 38e949a..b15921f 100644 --- a/src/glx/create_context.c +++ b/src/glx/create_context.c

[Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/builtin_variables.cpp | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index f630923..9f4f7c7 100644 --- a/src

[Mesa-dev] [PATCH] glx: Add missing null check in glXCreateContextAttribsARB

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/create_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/create_context.c b/src/glx/create_context.c index 38e949a..de54117 100644 --- a/src/glx/create_context.c +++ b/src/glx/create_context.c

[Mesa-dev] [PATCH 1/9] glx: Add missing null checks in glxcmds.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index b5377c2..38a5262 100644 --- a/src/glx/glxcmds.c +++ b/src/glx

[Mesa-dev] [PATCH 0/9] Klocwork related patches

1..5 are previously submitted patches which seem to have been lost in the list, just resubmitting them here. Other patches are new. Juha-Pekka Heikkila (9): glx: Add missing null checks in glxcmds.c glx: Add missing null check in __glXCloseDisplay glsl: Fix null access on file read error

[Mesa-dev] [PATCH 4/9] glx: Add some missing null checks in glx_pbuffer.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glx_pbuffer.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 183fbaa..411d6e5 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx

[Mesa-dev] [PATCH 6/9] i965: Add missing null check in fs_visitor::dead_code_eliminate_local()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index c290c28..217892a 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 8/9] egl: Unhide functionality in _eglInitContext()

_eglInitResource() was used to memset entire _EGLContext by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLContext, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/egl/main

[Mesa-dev] [PATCH 3/9] glsl: Fix null access on file read error

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index 5ea57d5..3a0f812 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -232,7 +232,7

[Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

ir_constant::ir_constant(const struct glsl_type, const ir_constant_data *) was copying too much memory. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/ir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index

[Mesa-dev] [PATCH 2/9] glx: Add missing null check in __glXCloseDisplay

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 2711e57..4a195bd 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -269,7 +269,8

[Mesa-dev] [PATCH 9/9] egl: Unhide functionality in _eglInitSurface()

_eglInitResource() was used to memset entire _EGLSurface by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLSurface, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/egl/main

[Mesa-dev] [PATCH 7/9] glx: Add missing null check in __glX_send_client_info()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/clientinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/clientinfo.c b/src/glx/clientinfo.c index e90fd79..8f3fdeb 100644 --- a/src/glx/clientinfo.c +++ b/src/glx/clientinfo.c @@ -113,6 +113,10

[Mesa-dev] [PATCH 1/3] glx: Add extra null check in __glXClientInfo

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..4d8d0c2 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1392,13

[Mesa-dev] [PATCH 3/3] glx: add missing null check in SendMakeCurrentRequest

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0..41048f4 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c

[Mesa-dev] [PATCH 2/3] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..837c5b0 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -686,7 +686,8 @@ static

[Mesa-dev] [PATCH 0/3] Three simple Klocwork patches to glx

Three simple patches for glx to do some null checking. Juha-Pekka Heikkila (3): glx: Add extra null check in __glXClientInfo glx: add extra null check in getFBConfigs glx: add missing null check in SendMakeCurrentRequest src/glx/glxcmds.c | 13 - src/glx/glxext.c

[Mesa-dev] [PATCH 2/5] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..837c5b0 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -686,7 +686,8 @@ static

[Mesa-dev] [PATCH 3/5] glx: add missing null check in SendMakeCurrentRequest

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0..306bf5b 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c

[Mesa-dev] [PATCH 1/5] glx: Add extra null check in __glXClientInfo

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..4d8d0c2 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1392,13

[Mesa-dev] [PATCH 4/5] egl: Unhide functionality in _eglInitSync()

_eglInitResource() was used to memset entire _EGLSync by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLSync, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/egl/main/eglsync.c | 3

[Mesa-dev] [PATCH 5/5] mesa: Add missing null checks into prog_hash_table.c

Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_hash_table.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/mesa/program

[Mesa-dev] [PATCH 0/5] Klocwork related pathes

so many places thus the case of null (c)allocation is handled just inside the functions and relied low memory situation is handled outside the function properly. Juha-Pekka Heikkila (5): glx: Add extra null check in __glXClientInfo glx: add extra null check in getFBConfigs glx: add missing

[Mesa-dev] [PATCH 00/10] Klocwork related pathes

(), this was included also for optimized builds. Now these loops will run only on debug builds where assert could matter. Juha-Pekka Heikkila (10): glx: Add extra null check in __glXClientInfo glx: add extra null check in getFBConfigs glx: add missing null check in SendMakeCurrentRequest egl: Unhide

[Mesa-dev] [PATCH 04/10] egl: Unhide functionality in _eglInitSync()

_eglInitResource() was used to memset entire _EGLSync by writing more than size of pointed target. This does work as long as Resource is the first element in _EGLSync, this patch fixes such dependency. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/egl/main/eglsync.c | 3

[Mesa-dev] [PATCH 01/10] glx: Add extra null check in __glXClientInfo

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..4d8d0c2 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1392,13

[Mesa-dev] [PATCH 03/10] glx: add missing null check in SendMakeCurrentRequest

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 28b8cd0..306bf5b 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c

[Mesa-dev] [PATCH 05/10] mesa: Add missing null checks into prog_hash_table.c

Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_hash_table.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/mesa/program

[Mesa-dev] [PATCH 02/10] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..837c5b0 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -686,7 +686,8 @@ static

[Mesa-dev] [PATCH 09/10] mesa: add null checks for callocs in symbol_table.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 64e24d8..df1ec5c 100644

[Mesa-dev] [PATCH 08/10] mesa: remove redundant running of check_symbol_table()

Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 10/10] mesa: add missing null checks in _tnl_register_fastpath()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/tnl/t_vertex.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..a122334 100644 --- a/src

[Mesa-dev] [PATCH 07/10] mesa: Add missing null check in _mesa_parse_arb_program()

Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y

[Mesa-dev] [PATCH 06/10] mesa: Prevent negative indexing on noise2, noise3 and noise4

% operator could return negative value which would cause indexing before perm table. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_noise.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/program

[Mesa-dev] [PATCH 2/8] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean

[Mesa-dev] [PATCH 0/8] Klocwork related patches again.

in symbol_table.c and mesa: Add missing null checks into prog_hash_table.c for now because I did not yet find way to properly inform about memory allocation failure in glsl_compiler target. /Juha-Pekka Juha-Pekka Heikkila (8): glx: remove unused __glXClientInfo() glx: add extra null check

[Mesa-dev] [PATCH 1/8] glx: remove unused __glXClientInfo()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 38a5262..584d248 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1388,19 +1388,6

[Mesa-dev] [PATCH 6/8] mesa: add missing null checks in _tnl_register_fastpath()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/tnl/t_vertex.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..b3e70d3 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src

[Mesa-dev] [PATCH 5/8] mesa: remove redundant running of check_symbol_table()

Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 7/8] mesa: add extra null checks in vbo_rebase_prims()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/vbo/vbo_rebase.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index c700621..dd754e2 100644 --- a/src/mesa/vbo

[Mesa-dev] [PATCH 4/8] mesa: Add missing null check in _mesa_parse_arb_program()

Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y

[Mesa-dev] [PATCH 8/8] mesa: In emit_texenv() type mismatch was forced with typecast

Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 3/8] mesa: Prevent negative indexing on noise2, noise3 and noise4

% operator could return negative value which would cause indexing before perm table. Change %256 to 0xff Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions

[Mesa-dev] [PATCH 1/2] i965: Add accumulator flag support and MAC opcode to use it

This change MACH, ADDC and SUBB opcodes to use added accumulator flag and add new opcode MAC which use accumulator flag. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_eu.h | 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH 01/13] glx: remove unused __glXClientInfo()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 4b17d7c..7984715 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1378,19 +1378,6

[Mesa-dev] [PATCH 03/13] mesa: Prevent negative indexing on noise2, noise3 and noise4

% operator could return negative value which would cause indexing before perm table. Change %256 to 0xff Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions

[Mesa-dev] [PATCH 04/13] mesa: Add missing null check in _mesa_parse_arb_program()

Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y

[Mesa-dev] [PATCH 10/13] glsl: add missing null check in tfeedback_decl::init()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/link_varyings.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..226f012 100644 --- a/src/glsl/link_varyings.cpp +++ b/src

[Mesa-dev] [PATCH 08/13] mesa: In emit_texenv() type mismatch was forced with typecast

Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 13/13] mesa: add null checks in symbol_table.c

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..9c3556a

[Mesa-dev] [PATCH 07/13] mesa: add extra null checks in vbo_rebase_prims()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/vbo/vbo_rebase.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..7aa8d08 100644 --- a/src/mesa/vbo

[Mesa-dev] [PATCH 00/13] Klocwork patches

-Pekka Heikkila (13): glx: remove unused __glXClientInfo() glx: add extra null check in getFBConfigs mesa: Prevent negative indexing on noise2, noise3 and noise4 mesa: Add missing null check in _mesa_parse_arb_program() mesa: remove redundant running of check_symbol_table() mesa: add

[Mesa-dev] [PATCH 09/13] mesa: Add missing null checks into prog_hash_table.c

Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/prog_hash_table.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/mesa/program

[Mesa-dev] [PATCH 11/13] mesa: add missing null check in _mesa_NewHashTable()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/hash.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..592ef4d 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,6 +115,11

[Mesa-dev] [PATCH 12/13] i965: check malloc return value in intel_resolve_map_set()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..a338c5e 100644

[Mesa-dev] [PATCH 02/13] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean

[Mesa-dev] [PATCH 05/13] mesa: remove redundant running of check_symbol_table()

Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 06/13] mesa: add missing null checks in _tnl_register_fastpath()

Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5cdf743 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src

  1   2   3   4   >