Reviewed-by: Marek Olšák
Marek
On Wed, Oct 28, 2015 at 9:18 PM, Ilia Mirkin wrote:
> Not sure if this is actually reachable in practice (to have a complex
> copy with MS textures).
>
> Signed-off-by: Ilia Mirkin
> ---
> src/mesa/state_tracker/st_cb_copyimage.c | 8 ++--
On Wed, Oct 28, 2015 at 10:24 PM, Jimmy Berry wrote:
> I have found myself desiring the ability to manipulate the GALLIUM_HUD
> variable while an application is running. At the most basic simply
> being able to toggle the hud on and off would be great. Otherwise, one
> has to relaunch an applicati
etting added too, just didn't seem too important.
Yeah, the integer packing opcodes are a lot easier to recognize in
driver backends.
Patches 1 & 3 are:
Reviewed-by: Marek Olšák
Of course, r600 and radeonsi support needs to be done before pushing this patch.
radeonsi has 2 ways of conv
edesktop.org/show_bug.cgi?id=91993 .
>
> A piglit test has been submitted for review as well (subtest of
> arb_texture_storage-texture-storage).
>
> v2: also bypass all calls to st_finalize_texture (suggested by Marek Olšák)
>
> Cc: mesa-sta...@lists.freedesktop.org
> Reviewed-by
From: Marek Olšák
Untested. I don't have Stoney.
---
src/gallium/drivers/radeonsi/si_state.c | 28
src/gallium/drivers/radeonsi/sid.h | 20 ++--
2 files changed, 38 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/rad
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 11 +++
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/drivers/radeon
From: Marek Olšák
pipe->flush never returned SDMA fences. This fixes it.
This is only an issue on amdgpu where fences can signal out of order.
---
src/gallium/drivers/radeon/r600_pipe_common.c | 64 +++
1 file changed, 56 insertions(+), 8 deletions(-)
diff --git a/
Reviewed-by: Marek Olšák
What's the use case for this?
Marek
On Fri, Oct 30, 2015 at 8:17 AM, Ilia Mirkin wrote:
> This will allow gallium drivers to send messages to KHR_debug endpoints
>
> Signed-off-by: Ilia Mirkin
> ---
>
> This patch has a major
On Fri, Oct 30, 2015 at 3:33 AM, Michel Dänzer wrote:
> On 30.10.2015 08:11, Nicolai Hähnle wrote:
>>
>> I am not familiar with patchwork yet and have a related question: on my
>> push, I got the following error message related to patchwork:
>>
>> remote: E: failed to find patch for rev
>> f75f21a
I'm okay with adding flags wherever you want, but please note that if
you add flags to declarations, you may need array support on the
declarations, so that instructions can tell which variable is being
used when indirect addressing is being used. CONSTs don't need array
support because the declara
On Mon, Nov 2, 2015 at 8:07 PM, Ilia Mirkin wrote:
> I haven't the faintest idea about efficiently, but these things flags
> on the ld/st instructions in the nvidia ISA for SM20+ (and I just
> plain don't know about SM10). I'm moderately sure that's the case for
> GCN as well.
>
> The difficulty w
> diff --git a/src/gallium/include/pipe/p_state.h
> b/src/gallium/include/pipe/p_state.h
> index 4bf8d46..2843bb6 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -684,6 +684,35 @@ struct pipe_compute_state
> unsigned req_input_mem; /**< Require
On Mon, Nov 2, 2015 at 9:14 PM, Ilia Mirkin wrote:
> On Mon, Nov 2, 2015 at 3:07 PM, Marek Olšák wrote:
>>> diff --git a/src/gallium/include/pipe/p_state.h
>>> b/src/gallium/include/pipe/p_state.h
>>> index 4bf8d46..2843bb6 100644
>>> --- a/src/galli
On Tue, Nov 3, 2015 at 2:14 AM, Ilia Mirkin wrote:
> On Mon, Nov 2, 2015 at 8:07 PM, Ian Romanick wrote:
>> On 11/02/2015 04:50 PM, Ilia Mirkin wrote:
>>> GL_EXT_color_buffer_float adds support for float buffers in ES3.0+, but
>>> explicitly disallows 32-bit blending. However this restriction was
On Tue, Nov 3, 2015 at 9:51 AM, Marek Olšák wrote:
> On Tue, Nov 3, 2015 at 2:14 AM, Ilia Mirkin wrote:
>> On Mon, Nov 2, 2015 at 8:07 PM, Ian Romanick wrote:
>>> On 11/02/2015 04:50 PM, Ilia Mirkin wrote:
>>>> GL_EXT_color_buffer_float adds support fo
On Tue, Nov 3, 2015 at 11:43 AM, boombatower wrote:
> - env GALLIUM_HUD_VISIBLE: control default visibility
> - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal
> ---
> docs/envvars.html | 6 ++
> src/gallium/auxiliary/hud/hud_context.c | 23 +
On Wed, Oct 28, 2015 at 5:25 PM, Ilia Mirkin wrote:
> On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote:
>> +static void
>> +st_CopyImageSubData(struct gl_context *ctx,
>> +struct gl_texture_image *src_image,
>> +struct gl_ren
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 51 ++--
1 file changed, 23 insertions(+), 28 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium/drivers/radeonsi/si_cp_dma.c
index c563644..4cdde29 100644
--- a/src
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 71 +++-
1 file changed, 34 insertions(+), 37 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium/drivers/radeonsi/si_cp_dma.c
index 4cdde29..e6aa9ca 100644
--- a/src
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 90 ++--
1 file changed, 85 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium/drivers/radeonsi/si_cp_dma.c
index e6aa9ca..641a6d1 100644
--- a/src
From: Marek Olšák
There are a few non-stoney changes too.
---
src/gallium/drivers/radeonsi/sid.h | 322 +
1 file changed, 322 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/sid.h
b/src/gallium/drivers/radeonsi/sid.h
index 49d8e2c..3a5101a 100644
From: Marek Olšák
This should improve performance for big copies that need to be split.
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium/drivers/radeonsi/si_cp_dma.c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_blit.c | 55 ++
1 file changed, 55 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_blit.c
b/src/gallium/drivers/radeonsi/si_blit.c
index fce014a..e934146 100644
--- a/src/gallium/drivers/radeonsi
On Nov 4, 2015 9:31 AM, "Michel Dänzer" wrote:
>
> On 04.11.2015 08:46, Marek Olšák wrote:
> >
> > @@ -209,11 +211,48 @@ static void si_clear_buffer(struct pipe_context
*ctx, struct pipe_resource *dst,
> > r600_resource(dst)->TC_L2_dirty = true
On Nov 4, 2015 4:02 AM, "Alex Deucher" wrote:
>
> On Tue, Nov 3, 2015 at 6:47 PM, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > ---
> > src/gallium/drivers/radeonsi/si_blit.c | 55
++
> > 1 file changed, 55
Reviewed-by: Marek Olšák
On Nov 4, 2015 6:49 AM, "Ilia Mirkin" wrote:
> This will allow gallium drivers to send messages to KHR_debug endpoints
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/auxiliary/util/u_debug.c | 14 ++
> src/gallium/a
num mesa_debug_type type;
> + enum mesa_debug_severity severity;
Missing space between declarations and code. Other than that:
Reviewed-by: Marek Olšák
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Marek Olšák
Marek
On Thu, Nov 5, 2015 at 6:34 AM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
> src/mesa/state_tracker/st_cb_copyimage.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_cb_copyima
On Thu, Nov 5, 2015 at 7:58 PM, Nicolai Hähnle wrote:
> On 04.11.2015 00:47, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeonsi/si_blit.c | 55
>> ++
>> 1 file changed, 55 inserti
On Tue, Nov 3, 2015 at 8:40 PM, Ilia Mirkin wrote:
> Ian, any comment on this?
>
> On Fri, Sep 25, 2015 at 1:32 PM, Ilia Mirkin wrote:
>> Hi Ian (and other spec experts),
>>
>> The ARB_ssbo spec mentions the following:
>>
>> OpenGL 4.0 (either core or compatibility profile) is required.
>>
>> ...
> +long size_align;
Any reason to use "long"? It's not like this will ever be greater than
2^32. "unsigned" should be enough. Other than that:
Reviewed-by: Marek Olšák
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov wrote:
> On 3 October 2015 at 12:19, Emil Velikov wrote:
>> On 3 October 2015 at 02:12, Marek Olšák wrote:
>>> I'm not sure if this is correct or if we should just return NULL in
>>> this case like the
On Fri, Nov 6, 2015 at 8:24 PM, Marek Olšák wrote:
> On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov
> wrote:
>> On 3 October 2015 at 12:19, Emil Velikov wrote:
>>> On 3 October 2015 at 02:12, Marek Olšák wrote:
>>>> I'm not sure if this is correct or if w
From: Marek Olšák
Broken by the addition of r600_multi_fence
in 3b37155a68acc351cba86a1fa142bd0de2192d4c
---
src/gallium/drivers/radeon/r600_query.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/r600_query.c
b/src/gallium/drivers/radeon
From: Marek Olšák
This is unreachable currently, but it will be used by unaligned 8-bit and
16-bit fills.
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c
b/src/gallium
From: Marek Olšák
This can't crash currently, but it would crash if clear_buffer
from u_blitter were used with a clean context.
---
src/gallium/drivers/radeonsi/si_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/ga
From: Marek Olšák
Discovered by luck. This code path hasn't been exercised since transform
feedback was implemented.
---
src/gallium/drivers/r600/r600_blit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/r600/r600_blit.c
b/src/gallium/drivers/r600/r600_blit.c
From: Marek Olšák
Buffer clears via transform feedback won't set this.
---
src/gallium/drivers/radeonsi/si_blit.c | 44 +++---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_blit.c
b/src/gallium/drivers/rad
From: Marek Olšák
---
src/gallium/auxiliary/util/u_blitter.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c
b/src/gallium/auxiliary/util/u_blitter.c
index b7b1ece..fccc92c 100644
--- a/src/gallium/auxiliary
From: Marek Olšák
Unaligned 8-bit and 16-bit clears are done in software.
---
src/gallium/drivers/radeonsi/si_blit.c | 60 ++
1 file changed, 60 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_blit.c
b/src/gallium/drivers/radeonsi/si_blit.c
index
From: Marek Olšák
The recursion can only occur if you modify need_cs_space to always flush.
---
src/gallium/drivers/radeonsi/si_hw_context.c | 7 +++
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/src/gallium/drivers/radeonsi
From: Marek Olšák
---
src/gallium/drivers/r600/evergreen_compute.c| 14 ++---
src/gallium/drivers/r600/evergreen_hw_context.c | 10 ++--
src/gallium/drivers/r600/evergreen_state.c | 66
src/gallium/drivers/r600/r600_blit.c| 2 +-
src/gallium
From: Marek Olšák
KCACHE, TC L1 and TC L2 are renamed to:
- SMEM L1
- VMEM L1
- GLOBAL L2
You can easily tell what they are used for now.
Shaders must deal with coherency issues between both L1s manually,
e.g. by setting GLC=1 or by using s_dcache_*.
BOTH_ICACHE_KCACHE was an unused definition
From: Marek Olšák
Not needed anymore. A similar flag will be introduced in the next commit,
which will be private in radeonsi.
---
src/gallium/drivers/r600/r600_hw_context.c| 3 ---
src/gallium/drivers/radeon/r600_pipe_common.c | 9 ++---
src/gallium/drivers/radeon/r600_pipe_common.h
From: Marek Olšák
otherwise the SX or CB blocks can go bananas
---
src/gallium/drivers/radeonsi/si_state.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index eba9c61..6d97049 100644
--- a/src/gallium
From: Marek Olšák
need_cs_space isn't invoked so often and is called before all commands too.
This is a lot cleaner. The code in radeon_add_to_buffer_list always seemed
dodgy to me.
---
src/gallium/drivers/r600/r600_hw_context.c| 5 +
src/gallium/drivers/radeon/r600_cs.h
From: Marek Olšák
I missed this in commit c3e527f93d4281ad6e2ca165eaf6ff588e4faefa
radeonsi: only enable write confirmation on the last CP DMA packet
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers
From: Marek Olšák
This has no effect.
---
src/gallium/drivers/r600/r600_state_common.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_state_common.c
b/src/gallium/drivers/r600/r600_state_common.c
index e160857..eb54361 100644
From: Marek Olšák
Not setting the predication bit is sufficient.
---
src/gallium/drivers/radeon/r600_query.c | 60 +
1 file changed, 24 insertions(+), 36 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_query.c
b/src/gallium/drivers/radeon/r600_query.c
I thought this would fix a bug I was hunting, but it didn't. Well, at least it
simplifies render condition handling.
Please review.
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
From: Marek Olšák
just disable it by not setting the predication bit
---
src/gallium/drivers/r600/r600_blit.c | 12 +---
src/gallium/drivers/r600/r600_state_common.c | 11 ++-
src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++-
src/gallium/drivers/radeonsi
From: Marek Olšák
and ..._cond -> ..._invert
---
src/gallium/drivers/r600/r600_hw_context.c| 2 +-
src/gallium/drivers/r600/r600_state_common.c | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.h | 6 +++---
src/gallium/drivers/radeon/r600_query.c | 14 +++---
From: Marek Olšák
---
src/gallium/drivers/r600/r600_hw_context.c| 2 +-
src/gallium/drivers/r600/r600_state_common.c | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.h | 1 -
src/gallium/drivers/radeon/r600_query.c | 1 -
src/gallium/drivers/radeonsi/si_state_draw.c | 2 +-
5
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 22 +-
src/gallium/drivers/radeon/r600_pipe_common.h | 4
2 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/drivers/radeon
From: Marek Olšák
---
src/gallium/drivers/r600/evergreen_state.c| 1 +
src/gallium/drivers/r600/r600_hw_context.c| 1 +
src/gallium/drivers/r600/r600_pipe.h | 2 +-
src/gallium/drivers/r600/r600_state.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.c | 6
This fixes hangs on Tonga when the ESGS ring isn't large enough. It's also a
requirement for this not-yet-committed patch:
"radeonsi: link ES-GS just like LS-HS"
which makes GS hangs easier to reproduce. The ring size equations are based on
VGT docs and my discussion with VGT guys.
Please r
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.h| 1 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 22 ++
2 files changed, 7 insertions(+), 16 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.h
b/src/gallium/drivers/radeonsi
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.h| 3 ++-
src/gallium/drivers/radeonsi/si_state_shaders.c | 11 ++-
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.h
b/src/gallium/drivers/radeonsi/si_shader.h
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c
b/src/gallium/drivers/radeonsi/si_state_shaders.c
index 89d365b..c402ce2 100644
--- a/src/gallium
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.h| 1 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.h
b/src/gallium/drivers/radeonsi/si_shader.h
index ec2d8c5
From: Marek Olšák
I discovered that increasing the ESGS ring size fixes GS hangs on Tonga,
so let's do it properly.
There is now a separate init_config_gs_rings state that is not immutable,
because GS rings are resized when needed.
This also saves some memory. Most apps won't need
On Mon, Nov 9, 2015 at 1:05 PM, Emil Velikov wrote:
> On 8 November 2015 at 21:45, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> otherwise the SX or CB blocks can go bananas
>> ---
>
> Should we get this into stable as well, considering Alex requested
> th
On Mon, Nov 9, 2015 at 10:55 AM, Nicolai Hähnle wrote:
> On 08.11.2015 22:48, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/r600/r600_hw_context.c| 2 +-
>> src/gallium/drivers/r600/r600_state_common.c
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote:
> The goal is to allow the pipe driver to request something other than
> TGSI, but detect whether what is getting is TGSI vs what it requested.
> The pipe drivers will always have to support TGSI (and convert that into
> whatever it is that they pre
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote:
> ---
> src/gallium/include/pipe/p_defines.h | 1 +
> src/gallium/include/pipe/p_state.h | 7 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/src/gallium/include/pipe/p_defines.h
> b/src/gallium/include/pipe/p_defines.h
> index 0a9d9
In my opinion, glsl_to_nir should be in its own file and independent
of glsl_to_tgsi.
Marek
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote:
> ---
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410
> -
> src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 +
> src/mes
On Tue, Nov 10, 2015 at 5:42 PM, Rob Clark wrote:
> I think I'll end up moving st_glsl_to_nir (plus the fxns only called
> from it) into a new file. But I think get_mesa_program_nir() and
> get_mesa_program_tgsi() could end up sharing more common code like I
> am doing w/ st_translate_xyz_program
Patches 1-2:
Reviewed-by: Marek Olšák
Marek
On Mon, Nov 9, 2015 at 7:40 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
> src/mesa/state_tracker/st_cb_texture.c | 29 +
> src/mesa/state_tracker/st_extensions.c | 1 +
> 2 files changed
On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> Need to insert a SQ_NON_EVENT when ever geometry
> shaders are enabled.
>
> Signed-off-by: Dave Airlie
> ---
> src/gallium/drivers/r600/r600_hw_context.c | 5 +
> src/gallium/drivers/r600/r600_pipe.h | 1 +
On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> streamout, gs rings bug on certain r600s, requires a wait idle
> before each surface sync.
>
> Signed-off-by: Dave Airlie
> ---
> src/gallium/drivers/r600/r600_hw_context.c | 4
> src/gallium/drivers/r600/r600_p
Patches 1,2,4:
Reviewed-by: Marek Olšák
I replied on 3 and 6. I'm not sure off hand about 5,7,8.
Marek
On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> On some chips the GSVS itemsize needs to be aligned to a cacheline size.
>
> This only ap
From: Marek Olšák
Untested. I need a new PSU with two 8pin connectors to be able to use Fiji.
---
src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/drivers/radeon
Reviewed-by: Marek Olšák
Marek
On Thu, Jan 22, 2015 at 4:41 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Fixes writing beyond the allocated buffer:
>
> ==31855== Invalid write of size 1
> ==31855==at 0x50AB2A9: vsprintf (iovsprintf.c:43)
> ==31855==
Hi Eric,
They are not the same. Gallium has
68afbe89c72d085dcbbf2b264f0201ab73fe339e. If the change is applied to
the common version, you will have my Rb.
Marek
On Sat, Jan 24, 2015 at 12:37 AM, Eric Anholt wrote:
> The code was exactly the same, except util/ has c++ guards and a struct
> simpl
On Sat, Jan 24, 2015 at 4:32 AM, Michel Dänzer wrote:
> On 24.01.2015 11:56, Tom Stellard wrote:
>> On Thu, Jan 22, 2015 at 11:27:32AM +0900, Michel Dänzer wrote:
>>>
>>> Tom, for now I suggest this solution, summarized from Marek's previous
>>> descriptions:
>>>
>>> (At least) for shaders which h
Thanks Eric,
Reviewed-by: Marek Olšák
Marek
On Mon, Jan 26, 2015 at 8:45 PM, Eric Anholt wrote:
> The idea is that after a remove_from_list(), you might want to be able to
> do a remove_from_list() on it again or an is_empty_list(). This is
> apparently relied on by r300g.
> ---
Pushed, thanks.
Marek
On Mon, Dec 8, 2014 at 7:43 PM, Sven Arvidsson wrote:
> Signed-off-by: Sven Arvidsson
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87076
> ---
> src/mesa/drivers/dri/common/drirc | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri
The fact r300 has ARL is well known. However, r600 has it too. The
r600 equivalent of ARL is "MOVA", which allows translating TGSI
indirect addressing into bytecode directly. So there is a rather
significant user base of gallium which uses hardware with ARL.
I am not opposed to the idea of nuking
Thanks for adding Gallium support.
Reviewed-by: Marek Olšák
Marek
On Thu, Jan 29, 2015 at 10:14 PM, Martin Peres
wrote:
> While trying to understand a GLSL pass, curro and I tried running Unigine
> Tropics and the GLSL compilers would not compile the shaders.
>
> The reason is due
The commit message prefix should be "intel:" in this case.
Marek
On Fri, Jan 30, 2015 at 3:19 PM, Martin Peres
wrote:
> Reviewed-by: Kenneth Graunke
> Signed-off-by: Martin Peres
> ---
> src/mesa/drivers/dri/i915/intel_screen.c | 1 +
> src/mesa/drivers/dri/i965/brw_context.c | 3 +++
> src/
I recommend not using PIPE_BIND_TRANSFER_READ/WRITE. Transfers with
multisample textures should be supported, but the mapped texture is
always a resolved single-sample copy, so it's not really an MSAA
transfer.
Marek
On Fri, Jan 30, 2015 at 9:34 PM, Axel Davy wrote:
> Signed-off-by: Axel Davy
>
Hi Dave,
R600 supports 18 samplers per shader, so you can use a fixed slot
outside of the API range (16 or 17) and bind the stipple texture
statically there. The motivation is that you won't have to read the
shader to get the slot number, so it will be completely independent.
You don't have to unb
From: Marek Olšák
---
src/gallium/auxiliary/util/u_tests.c | 110 +--
1 file changed, 79 insertions(+), 31 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_tests.c
b/src/gallium/auxiliary/util/u_tests.c
index 764c4c3..89ae840 100644
--- a/src/gallium
From: Marek Olšák
It shouldn't crash the GPU and it should return (0, 0, 0, 1).
This is r300 behavior, so I assume it's also DX9 behavior.
Radeonsi can support this easily.
---
src/gallium/auxiliary/util/u_tests.c | 39
1 file changed, 39
From: Marek Olšák
This expects (0,0,0,0), though it can be changed to something else or allow
more than one set of values to be considered correct.
This is currently the radeonsi behavior.
---
src/gallium/auxiliary/util/u_tests.c | 57
1 file changed, 57
From: Marek Olšák
---
src/gallium/auxiliary/util/u_simple_shaders.c | 12 ++---
src/gallium/auxiliary/util/u_tests.c | 37 +--
2 files changed, 38 insertions(+), 11 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_simple_shaders.c
b/src/gallium
From: Marek Olšák
E.g. r600g can use slot 17, which is outside of the API range.
---
src/gallium/auxiliary/util/u_pstipple.c| 25 ++---
src/gallium/auxiliary/util/u_pstipple.h| 3 ++-
src/gallium/drivers/softpipe/sp_state_shader.c | 2 +-
3 files changed
From: Marek Olšák
---
src/gallium/auxiliary/tgsi/tgsi_parse.c | 12
src/gallium/auxiliary/tgsi/tgsi_parse.h | 2 ++
src/gallium/drivers/radeon/r600_pipe_common.c | 11 ---
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/gallium/auxiliary
From: Marek Olšák
---
src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4
src/gallium/auxiliary/util/u_tests.c | 9 -
src/gallium/auxiliary/util/u_tests.h | 4 ++--
3 files changed, 14 insertions(+), 3 deletions(-)
diff --git
From: Marek Olšák
For drivers that use higher slots not to crash in tgsi_shader_info.
---
src/gallium/include/pipe/p_state.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_state.h
b/src/gallium/include/pipe/p_state.h
index 43bc48b..e15860c 100644
From: Marek Olšák
Same as u_bit_scan, but for uint64_t.
---
src/gallium/auxiliary/util/u_math.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index 19c7343..f5d3487 100644
--- a/src/gallium/auxiliary/util
From: Marek Olšák
Also remove unused "tokens".
---
src/gallium/drivers/radeonsi/si_shader.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index 4b1279c..52f1fa4 100644
From: Marek Olšák
I will need this for polygon stippling.
---
src/gallium/drivers/radeonsi/si_pipe.h | 1 +
src/gallium/drivers/radeonsi/si_state_draw.c | 29 +++-
2 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/src/gallium/drivers/radeonsi
From: Marek Olšák
This will allow supporting NULL textures.
---
src/gallium/drivers/radeonsi/si_descriptors.c | 2 +-
src/gallium/drivers/radeonsi/si_pipe.h| 2 ++
src/gallium/drivers/radeonsi/si_shader.c | 4 ++--
src/gallium/drivers/radeonsi/si_state.c | 8
4 files
From: Marek Olšák
The hardware obeys swizzles even if the resource is NULL.
This will be used by set_polygon_stipple.
---
src/gallium/drivers/radeonsi/si_descriptors.c | 13 +
src/gallium/drivers/radeonsi/si_state.c | 15 +--
2 files changed, 22 insertions(+), 6
From: Marek Olšák
The FILLED_SIZE counter is uninitialized at the beginning, so we can't use it.
Instead, use offset = 0, which is what we always do when not appending.
This unexpectedly fixes spec/ARB_texture_multisample/sample-position/*.
Yes, the test does use transform feedback.
Cc:
From: Marek Olšák
Fixes piglit ARB_base_instance/arb_base_instance-drawarrays.
Cc: 10.3 10.4
---
src/gallium/drivers/radeonsi/si_shader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi
Patch summary:
These are bug fixes and one cleanup patch:
r600g,radeonsi: don't append to streamout buffers that haven't been used yet
radeonsi: fix instanced arrays with non-zero start instance
radeonsi: don't use tgsi_parse_context to get processor type
We previously supported NULL buffer
From: Marek Olšák
This used to hang.
---
src/gallium/drivers/radeonsi/si_descriptors.c | 30 +--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c
b/src/gallium/drivers/radeonsi/si_descriptors.c
index 372782f
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_descriptors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c
b/src/gallium/drivers/radeonsi/si_descriptors.c
index 15b4da1..372782f 100644
--- a/src/gallium/drivers/radeonsi
401 - 500 of 12391 matches
Mail list logo
