Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
I have these issues with the patch: 1) On GPUs without a vertex cache, you flush the texture cache every draw operation. Are you kidding? 2) All colorbuffers / streamout buffers are flushed, even those which are not enabled. E.g. instead of flushing only CB0 when there is only one, this code

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
On Fri, Jul 20, 2012 at 1:34 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 6:07 PM, Marek Olšák mar...@gmail.com wrote: I have these issues with the patch: 1) On GPUs without a vertex cache, you flush the texture cache every draw operation. Are you kidding? Show me one

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
at 9:00 PM, Marek Olšák mar...@gmail.com wrote: On Fri, Jul 20, 2012 at 1:34 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 6:07 PM, Marek Olšák mar...@gmail.com wrote: I have these issues with the patch: 1) On GPUs without a vertex cache, you flush the texture cache every

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-19 Thread Marek Olšák
On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák mar...@gmail.com wrote: I actually care a lot about lockups. Well, you are complaing about lockups, yet you have quite obvious bugs in your hyperz code, so let's fix them

[Mesa-dev] [PATCH] automake: add ARCH_FLAGS, OPT_FLAGS, PIC_FLAGS into AM_CFLAGS and AM_CXXFLAGS

2012-07-20 Thread Marek Olšák
This fixes a build system regression after Makefile conversions to automake. I need only OPT_FLAGS to set -fno-omit-frame-pointer. ARCH_FLAGS is for --enable-32-bit. I am not sure what PIC_FLAGS is good for, but r600g uses it. VISIBILITY_CFLAGS might be missing too. ---

[Mesa-dev] [PATCH] mesa: fix format checking when doing a multisample resolve

2012-07-21 Thread Marek Olšák
Check the internal format instead of gl_format. Sometimes a driver may allocate two textures of formats e.g. RGBA and ARGB from internalformat GL_RGBA8, and doing a resolve between those 2 GL_RGBA8 formats results in a GL error. Technically speaking, a user getting the error has done

[Mesa-dev] [PATCH] mesa: fix format checking when doing a multisample resolve

2012-07-21 Thread Marek Olšák
v2: make it more bullet-proof --- src/mesa/main/fbobject.c | 112 +- 1 file changed, 111 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4370c72..ca43f81 100644 --- a/src/mesa/main/fbobject.c +++

Re: [Mesa-dev] [PATCH] automake: add ARCH_FLAGS, OPT_FLAGS, PIC_FLAGS into AM_CFLAGS and AM_CXXFLAGS

2012-07-21 Thread Marek Olšák
On Sat, Jul 21, 2012 at 9:40 PM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: This fixes a build system regression after Makefile conversions to automake. I need only OPT_FLAGS to set -fno-omit-frame-pointer. ARCH_FLAGS is for --enable-32-bit. I am not sure what

[Mesa-dev] [PATCH] st/mesa: set the correct window renderbuffer internal format

2012-07-21 Thread Marek Olšák
The multisample-resolve blit relies on this being correct. --- src/mesa/state_tracker/st_cb_fbo.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index e1818ab..7eef5c6 100644 ---

[Mesa-dev] [PATCH] st/mesa: flush the glBitmap cache before changing framebuffer state

2012-07-21 Thread Marek Olšák
This fixes the piglit EXT_framebuffer_multisample/bitmap tests. Note that we must not rely on ctx-DrawBuffer when flushing the cache, because that's already updated with a new framebuffer. We want to draw into the old framebuffer where glBitmap was called. ---

[Mesa-dev] [PATCH 1/2] st/mesa: set the centroid qualifier in fragment shader inputs

2012-07-22 Thread Marek Olšák
This fixes some centroid tests in the EXT_framebuffer_multisample piglit group. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 10 ++ src/mesa/state_tracker/st_glsl_to_tgsi.h |1 + src/mesa/state_tracker/st_program.c|4 3 files changed, 11 insertions(+), 4

[Mesa-dev] [PATCH 2/2] st/mesa: fix DDY opcode for FBOs

2012-07-22 Thread Marek Olšák
This fixes piglit/fbo-deriv. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 45136de..fcd69b1 100644 ---

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-22 Thread Marek Olšák
On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák mar...@gmail.com wrote: On Fri, Jul 20, 2012 at 4:17 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 10:06 PM, Marek Olšák mar...@gmail.com wrote: I

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Marek Olšák
On Mon, Jul 23, 2012 at 4:25 PM, Jerome Glisse j.gli...@gmail.com wrote: On Sun, Jul 22, 2012 at 8:58 PM, Marek Olšák mar...@gmail.com wrote: On Fri, Jul 20, 2012 at 4:54 AM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Jul 19, 2012 at 10:25 PM, Marek Olšák mar...@gmail.com wrote: On Fri

Re: [Mesa-dev] [PATCH 2/2] r600g: simplify and fix flushing and synchronization v2

2012-07-23 Thread Marek Olšák
On Mon, Jul 23, 2012 at 11:42 PM, Jerome Glisse j.gli...@gmail.com wrote: No, it helps on evergreen too, redwood,juniper,turks and bart are the only one i tested with. Evergreen is in a slightly better position but when it comes to lockup there is no good metrics. Concerning older chipsets, I

Re: [Mesa-dev] [PATCH 2/5] r600g: Atomize compute shader state

2012-07-24 Thread Marek Olšák
On Tue, Jul 24, 2012 at 8:36 PM, Tom Stellard tstel...@gmail.com wrote: --- src/gallium/drivers/r600/evergreen_compute.c | 168 +- src/gallium/drivers/r600/evergreen_compute.h |2 + src/gallium/drivers/r600/evergreen_state.c |1 +

Re: [Mesa-dev] [PATCH 3/5] r600g: Emit CB_TARGET_MASK in compute_emit_cs()

2012-07-24 Thread Marek Olšák
On Tue, Jul 24, 2012 at 8:36 PM, Tom Stellard tstel...@gmail.com wrote: --- src/gallium/drivers/r600/evergreen_compute.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, while OPT_FLAGS was only appended to existing CFLAGS, which is the reason I have been using OPT_FLAGS. Is that not true anymore? Marek On Thu, Jul 26, 2012 at 6:52 PM, Eric Anholt e...@anholt.net wrote: If you want to change

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Ah, I see. Thank you for the clarification. Marek On Fri, Jul 27, 2012 at 12:29 AM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, while OPT_FLAGS was only appended to existing CFLAGS, which

Re: [Mesa-dev] [PATCH 1/2] r600g: add htile support v9

2012-07-29 Thread Marek Olšák
On Tue, Jul 17, 2012 at 7:58 PM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com htile is used for HiZ and HiS support and fast Z/S clears. This commit just adds the htile setup and Fast Z clear. We don't take full advantage of HiS with that patch. v2 really use fast

[Mesa-dev] [PATCH 01/18] gallium: rename cso_save/restore_samplers - cso_save/restore_fragment_samplers

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/cso_cache/cso_context.c |4 ++-- src/gallium/auxiliary/cso_cache/cso_context.h |4 ++-- src/gallium/auxiliary/util/u_blit.c |8 src/gallium/auxiliary/util/u_gen_mipmap.c |4 ++-- src/gallium/state_trackers/vega/renderer.c| 12

[Mesa-dev] [PATCH 02/18] gallium: set sample mask to ~0 for clear, blit and gen_mipmap

2012-08-02 Thread Marek Olšák
The sample mask affects single-sampled rendering too (it's orthogonal to the color mask). --- src/gallium/auxiliary/cso_cache/cso_context.c | 13 - src/gallium/auxiliary/cso_cache/cso_context.h |2 ++ src/gallium/auxiliary/util/u_blit.c |6 ++

[Mesa-dev] [PATCH 03/18] gallium/u_blit: check nr_samples before using resource_copy_region

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blit.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blit.c b/src/gallium/auxiliary/util/u_blit.c index 84af2b4..1beca0f 100644 --- a/src/gallium/auxiliary/util/u_blit.c +++

[Mesa-dev] [PATCH 04/18] gallium/u_blit: bail out if src is a multisample texture

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blit.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blit.c b/src/gallium/auxiliary/util/u_blit.c index 1beca0f..3992f71 100644 --- a/src/gallium/auxiliary/util/u_blit.c +++ b/src/gallium/auxiliary/util/u_blit.c @@

[Mesa-dev] [PATCH 05/18] gallium/u_blitter: set sample mask to ~0

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 10 ++ src/gallium/auxiliary/util/u_blitter.h | 10 ++ 2 files changed, 20 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index b31ac2d..1ad6c14 100644 ---

[Mesa-dev] [PATCH 06/18] gallium/tgsi: fixup texture name strings

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/tgsi/tgsi_strings.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c b/src/gallium/auxiliary/tgsi/tgsi_strings.c index b5fd1fc..5f8f4be 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_strings.c +++

[Mesa-dev] [PATCH 07/18] gallium/u_blitter: minor cleanup

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 12 ++-- src/gallium/auxiliary/util/u_blitter.h |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 1ad6c14..6015ad6 100644 ---

[Mesa-dev] [PATCH 08/18] gallium: define PIPE_MASK_RGBAZS

2012-08-02 Thread Marek Olšák
I need this and it seems like it could be useful. --- src/gallium/include/pipe/p_defines.h |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 8d787ec..59c6382 100644 --- a/src/gallium/include/pipe/p_defines.h

[Mesa-dev] [PATCH 09/18] gallium/u_blitter: add ability to blit only depth or only stencil

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 26 ++ src/gallium/auxiliary/util/u_blitter.h |3 ++- src/gallium/drivers/r300/r300_blit.c |2 +- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 10/18] gallium/u_blitter: remove fallback for stencil copy that all drivers skipped

2012-08-02 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c |6 ++ src/gallium/auxiliary/util/u_blitter.h | 10 +- src/gallium/drivers/i915/i915_surface.c |2 +- src/gallium/drivers/r600/r600_blit.c|2 +- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 11/18] r600g: correct texture memory size for Z32F_S8X24 on evergreen

2012-08-02 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_texture.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_texture.c b/src/gallium/drivers/r600/r600_texture.c index 4cf9cb8..5e99a04 100644 --- a/src/gallium/drivers/r600/r600_texture.c

[Mesa-dev] [PATCH 12/18] r600g: don't decompress depth or stencil if there isn't any

2012-08-02 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c |7 +-- src/gallium/drivers/r600/r600_blit.c | 12 +++- src/gallium/drivers/r600/r600_pipe.h |1 + src/gallium/drivers/r600/r600_state.c |6 -- 4 files changed, 17 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH 13/18] gallium/u_blitter: add a query for checking whether copying is supported

2012-08-02 Thread Marek Olšák
Cc: Stephane Marchesin stephane.marche...@gmail.com --- src/gallium/auxiliary/util/u_blitter.c | 86 ++ src/gallium/auxiliary/util/u_blitter.h |4 + src/gallium/drivers/i915/i915_resource_texture.c |7 +- src/gallium/drivers/i915/i915_surface.c

[Mesa-dev] [PATCH 14/18] r600g: make sure copying of all texture formats is accelerated

2012-08-02 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_blit.c| 60 +-- src/gallium/drivers/r600/r600_texture.c | 46 +++- 2 files changed, 54 insertions(+), 52 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] [PATCH 15/18] r600g: drop the old texture allocation code

2012-08-02 Thread Marek Olšák
Made obsolete by the libdrm surface allocator. --- .../drivers/r600/evergreen_compute_internal.c |2 +- src/gallium/drivers/r600/evergreen_state.c | 322 src/gallium/drivers/r600/r600_pipe.c |2 - src/gallium/drivers/r600/r600_pipe.h

[Mesa-dev] [PATCH 16/18] r600g: simplify create_surface

2012-08-02 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_texture.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/r600/r600_texture.c b/src/gallium/drivers/r600/r600_texture.c index 81b5777..507dc16 100644 ---

[Mesa-dev] [PATCH 17/18] r600g: precompute depth buffer state in pipe_surface and reuse it

2012-08-02 Thread Marek Olšák
This is done on-demand, because we don't know in advance if a zbuffer will be bound as depth or color. --- src/gallium/drivers/r600/evergreen_state.c | 104 ++-- src/gallium/drivers/r600/r600_resource.h | 12 src/gallium/drivers/r600/r600_state.c | 53

[Mesa-dev] [PATCH 18/18] r600g: precompute color buffer state in pipe_surface and reuse it

2012-08-02 Thread Marek Olšák
--- .../drivers/r600/evergreen_compute_internal.c | 22 ++- src/gallium/drivers/r600/evergreen_state.c | 143 ++-- src/gallium/drivers/r600/r600_pipe.h |6 +- src/gallium/drivers/r600/r600_resource.h | 17 +++

Re: [Mesa-dev] [PATCH] r600g: atomize sampler state

2012-08-02 Thread Marek Olšák
This generally looks good. I have tested it on R700 and there are 2 regressions. I'll try to take a look at them tomorrow. 1) The test arb_seamless_cubemap is failing. I think the only way to make that feature work correctly is to add a separate atom for it. 2)

Re: [Mesa-dev] [PATCH] gallium: consolidate CSO sampler and sampler_view functions

2012-08-02 Thread Marek Olšák
I just skimmed through it and couldn't find anything wrong. Reviewed-by: Marek Olšák mar...@gmail.com Someday we should definitely do something like this in pipe_context too. Marek On Thu, Aug 2, 2012 at 9:16 PM, Brian Paul bri...@vmware.com wrote: Merge the vertex/fragment versions

Re: [Mesa-dev] [PATCH] u_blitter: Move a pointer dereference after null check.

2012-08-03 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Fri, Aug 3, 2012 at 8:35 AM, Vinson Lee v...@freedesktop.org wrote: Fixes dereference before null check defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/auxiliary/util/u_blitter.c | 5 +++-- 1

Re: [Mesa-dev] [PATCH 1/2] winsys/radeon: fix VA allocation

2012-08-03 Thread Marek Olšák
FYI, you can find my reply to this patch in the bug report. Marek On Fri, Aug 3, 2012 at 5:06 PM, Christian König deathsim...@vodafone.de wrote: Wait for VA use to end before reusing it. Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=45018 Signed-off-by: Christian König

Re: [Mesa-dev] R600 VDPAU 422 regression since r600g: make sure copying of all texture formats is accelerated

2012-08-06 Thread Marek Olšák
Does the attached patch fix this issue? Marek On Mon, Aug 6, 2012 at 5:40 PM, Andy Furniss andy...@ukfsn.org wrote: Kernel is dcn card is rv790 - vdpau csc/scale regressed. This only shows with 422 colour so most things work. commit 7c371f46958910dd2ca9487c89af1b72bbfdada9 Author: Marek

Re: [Mesa-dev] R600 VDPAU 422 regression since r600g: make sure copying of all texture formats is accelerated

2012-08-07 Thread Marek Olšák
Do you have any idea what could be wrong with the patch? Also could please tell me how to setup VDPAU and where to download the tests, so that I can test this. Marek On Tue, Aug 7, 2012 at 11:25 AM, Andy Furniss andy...@ukfsn.org wrote: Marek Olšák wrote: Does the attached patch fix

[Mesa-dev] [PATCH 00/19] MSAA on Evergreen

2012-08-09 Thread Marek Olšák
Hi everyone, this series implements MSAA support for Evergreen. It passes most MSAA piglit tests. I think Cayman support is ready too, but I don't have a Cayman GPU to test it. In the last patch, a DRM version check has yet to be added for the kernel patches I sent earlier today. The tests

[Mesa-dev] [PATCH 01/19] mesa: flush vertices in test_framebuffer_completeness

2012-08-09 Thread Marek Olšák
--- src/mesa/main/fbobject.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index d558d7f..43ee3b4 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -685,6 +685,9 @@ _mesa_test_framebuffer_completeness(struct

[Mesa-dev] [PATCH 02/19] st/mesa: don't clamp fragment color with integer colorbuffer

2012-08-09 Thread Marek Olšák
--- src/mesa/state_tracker/st_atom_rasterizer.c |3 ++- src/mesa/state_tracker/st_atom_shader.c |5 +++-- src/mesa/state_tracker/st_cb_bitmap.c |3 ++- src/mesa/state_tracker/st_cb_drawpixels.c |6 -- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 03/19] gallium: make pipe_box signed in order to represent flipped blits

2012-08-09 Thread Marek Olšák
This will be used by u_blitter. --- src/gallium/include/pipe/p_state.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index c828c80..76559ad 100644 --- a/src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 04/19] gallium/u_blit: set dst format from pipe_resource, not pipe_surface

2012-08-09 Thread Marek Olšák
We use it to decide whether we can use resource_copy_region. NOTE: This is a candidate for the 8.0 branch. --- src/gallium/auxiliary/util/u_blit.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blit.c b/src/gallium/auxiliary/util/u_blit.c

[Mesa-dev] [PATCH 05/19] gallium/tgsi: fix TGSI text parser

2012-08-09 Thread Marek Olšák
The problem was that the string matching succeeded e.g. for 2D when there was actually 2D_MSAA and then failed parsing _MSAA. To prevent similar failures in the future, let's fix this kind of error everywhere. --- src/gallium/auxiliary/tgsi/tgsi_text.c | 174 ++-- 1

[Mesa-dev] [PATCH 06/19] gallium: add TGSI support for multisample textures

2012-08-09 Thread Marek Olšák
The only allowed instructions are TXQ_LZ and TXF. TXQ_LZ is like TXQ, but without the LOD parameter (which is always zero with MSAA textures) The 3rd or the 4th texcoord component in TXF should contain the sample index for a 2D_MSAA or 2D_ARRAY_MSAA texture, respectively. ---

[Mesa-dev] [PATCH 07/19] gallium/u_blitter: implement blitting multisample resources

2012-08-09 Thread Marek Olšák
It can blit only one sample at a time (it should be called in a loop). --- src/gallium/auxiliary/util/u_blit.c |8 +- src/gallium/auxiliary/util/u_blitter.c| 250 - src/gallium/auxiliary/util/u_blitter.h| 10 +-

[Mesa-dev] [PATCH 08/19] gallium/u_blitter: implement X and Y texture flipping

2012-08-09 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 37 ++-- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 7283a14..4cc3aa4 100644 ---

[Mesa-dev] [PATCH 09/19] winsys/radeon: print error if CS is overflowed

2012-08-09 Thread Marek Olšák
and don't submit the CS to the kernel. --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c index 186c5bc..7e0f2f9 100644 ---

[Mesa-dev] [PATCH 10/19] r600g: remove support for 3-channel colorbuffers

2012-08-09 Thread Marek Olšák
We have no sampler support for them. --- src/gallium/drivers/r600/evergreen_state.c |7 --- src/gallium/drivers/r600/r600_state.c |8 2 files changed, 15 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c

[Mesa-dev] [PATCH 11/19] r600g: implement alpha-to-one

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c |4 src/gallium/drivers/r600/r600_pipe.h |5 + src/gallium/drivers/r600/r600_shader.c |3 ++- src/gallium/drivers/r600/r600_state.c|5 + src/gallium/drivers/r600/r600_state_common.c |5 - 5

[Mesa-dev] [PATCH 12/19] r600g: implement alpha-to-coverage

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_hw_context.c |2 ++ src/gallium/drivers/r600/evergreen_state.c | 13 + src/gallium/drivers/r600/evergreend.h |7 +++ src/gallium/drivers/r600/r600_hw_context.c |1 + src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH 13/19] r600g: implement set_sample_mask

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c | 39 ++ src/gallium/drivers/r600/r600_blit.c |1 + src/gallium/drivers/r600/r600_hw_context.c |1 + src/gallium/drivers/r600/r600_pipe.h |7 + src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH 14/19] r600g: implement MSAA rendering and texturing for evergreen and cayman

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_hw_context.c | 13 ++ src/gallium/drivers/r600/evergreen_state.c | 220 --- src/gallium/drivers/r600/evergreend.h | 24 ++- src/gallium/drivers/r600/r600_texture.c |3 +- 4 files changed, 234 insertions(+),

[Mesa-dev] [PATCH 15/19] r600g: implement TXQ_LZ opcode

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_shader.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index d87e2af..cec167c 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++

[Mesa-dev] [PATCH 16/19] r600g: implemented MSAA depth-stencil decompression and resolve

2012-08-09 Thread Marek Olšák
and integer textures, which are resolved the same as depth, I think. --- src/gallium/auxiliary/util/u_blitter.c |2 + src/gallium/auxiliary/util/u_blitter.h |1 + src/gallium/drivers/r600/evergreen_state.c |3 +- src/gallium/drivers/r600/r600_blit.c | 164

[Mesa-dev] [PATCH 17/19] r600g: implement MSAA color resolve

2012-08-09 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 61 + src/gallium/auxiliary/util/u_blitter.h |8 +++ src/gallium/drivers/r600/evergreen_state.c | 24 +++-- src/gallium/drivers/r600/r600_blit.c | 80

[Mesa-dev] [PATCH 18/19] r600g: implement copying between MSAA textures

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_blit.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index 547386d..f3a3b8f 100644 --- a/src/gallium/drivers/r600/r600_blit.c +++

[Mesa-dev] [PATCH 19/19] r600g: enable MSAA on evergreen by default

2012-08-09 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index e6e2fb2..56e392e 100644 ---

Re: [Mesa-dev] [PATCH 00/19] MSAA on Evergreen

2012-08-09 Thread Marek Olšák
On Thu, Aug 9, 2012 at 10:38 PM, Dave Airlie airl...@gmail.com wrote: this series implements MSAA support for Evergreen. It passes most MSAA piglit tests. I think Cayman support is ready too, but I don't have a Cayman GPU to test it. In the last patch, a DRM version check has yet to be added

Re: [Mesa-dev] [PATCH 03/19] gallium: make pipe_box signed in order to represent flipped blits

2012-08-09 Thread Marek Olšák
this is a good idea. That dilutes the meaning of a box quite a bit (and I don't think x/y/z can actually be negative?). There are presumably also quite a lot of uses of pipe_box which might not be able to deal with such boxes. Roland Am 09.08.2012 18:07, schrieb Marek Olšák: This will be used

Re: [Mesa-dev] [PATCH 04/14] mesa: Don't advertise extensions that are part of GL 1.4 in a core context

2012-08-09 Thread Marek Olšák
On Fri, Aug 10, 2012 at 3:42 AM, Ian Romanick i...@freedesktop.org wrote: On 08/08/2012 10:53 AM, Brian Paul wrote: On 08/08/2012 11:38 AM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Signed-off-by: Ian Romanickian.d.roman...@intel.com --- src/mesa/main/extensions.c |

Re: [Mesa-dev] [PATCH 16/16] r600: update sampler, sampler_view code for the future

2012-08-10 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com On Fri, Aug 10, 2012 at 5:11 AM, Brian Paul bri...@vmware.com wrote: For when we have pipe-set_sampler_states(pipe, shader, start, num, samplers), etc. --- src/gallium/drivers/r600/evergreen_state.c |6 +-- src/gallium/drivers/r600/r600_pipe.h

Re: [Mesa-dev] [PATCH 04/14] mesa: Don't advertise extensions that are part of GL 1.4 in a core context

2012-08-10 Thread Marek Olšák
On Sat, Aug 11, 2012 at 4:11 AM, Ian Romanick i...@freedesktop.org wrote: On 08/09/2012 07:52 PM, Marek Olšák wrote: On Fri, Aug 10, 2012 at 3:42 AM, Ian Romanick i...@freedesktop.org wrote: On 08/08/2012 10:53 AM, Brian Paul wrote: On 08/08/2012 11:38 AM, Ian Romanick wrote: From: Ian

Re: [Mesa-dev] [PATCH 03/19] gallium: make pipe_box signed in order to represent flipped blits

2012-08-12 Thread Marek Olšák
On Fri, Aug 10, 2012 at 1:42 AM, Roland Scheidegger srol...@vmware.com wrote: Am 10.08.2012 00:37, schrieb Marek Olšák: I'd like to have either signed pipe_box or a new struct for that purpose. It looks to me like conceptually what you want is more like a coordinate pair. I dunno though

[Mesa-dev] [PATCH] r600g: implement timestamp query and get_timestamp hook

2012-08-12 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c | 13 - src/gallium/drivers/r600/r600_query.c | 17 - src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 21 + src/gallium/winsys/radeon/drm/radeon_winsys.h |7 +++

[Mesa-dev] [PATCH 1/2] gallium: remove PIPE_USAGE_IMMUTABLE, use STATIC instead

2012-08-13 Thread Marek Olšák
--- src/gallium/auxiliary/vl/vl_idct.c |2 +- src/gallium/auxiliary/vl/vl_zscan.c|4 ++-- src/gallium/docs/source/screen.rst |3 +-- src/gallium/drivers/i915/i915_resource_buffer.c|2 +- src/gallium/drivers/llvmpipe/lp_texture.c

[Mesa-dev] [PATCH 2/2] gallium: remove questionable PIPE_USAGE_DEFAULT, use STATIC instead

2012-08-13 Thread Marek Olšák
Despite the comment and documentation, drivers interpreted it as STATIC. --- src/gallium/auxiliary/vl/vl_winsys_xsp.c |2 +- src/gallium/docs/source/screen.rst |5 ++--- src/gallium/drivers/nouveau/nouveau_buffer.c |1 -

Re: [Mesa-dev] [PATCH] draw: fix assertion failure in draw_emit_vertex_attr

2012-10-30 Thread Marek Olšák
On Tue, Oct 30, 2012 at 3:37 PM, Andreas Boll andreas.boll@gmail.com wrote: 2012/10/30 Marek Olšák mar...@gmail.com: This is a regression since b3921e1f53833420e0a0fd581f7417. The array stores VS outputs, not FS inputs. Now llvmpipe can do 32 varyings too. NOTE: This is a candidate

[Mesa-dev] [PATCH] vbo: fix glVertexAttribI* functions

2012-10-30 Thread Marek Olšák
The functions were broken, because they converted ints to floats. Now we can finally advertise OpenGL 3.0. ;) In this commit, the vbo module also tracks the type for each attrib in addition to the size. It can be one of FLOAT, INT, UNSIGNED_INT. The little ugliness is the vertex attribs are

Re: [Mesa-dev] [PATCH 1/2] mesa/vbo: Fix scaling issue in 10-bit signed normalized packing.

2012-10-30 Thread Marek Olšák
This series passes the new attribs piglit tests I just sent to the piglit mailing list. Current Mesa git fails it. If the test looks alright to you, this is: Tested-by: Marek Olšák mar...@gmail.com Marek On Sun, Oct 14, 2012 at 9:02 PM, Kenneth Graunke kenn...@whitecape.org wrote: For the 10

Re: [Mesa-dev] [PATCH 09/16] mesa: remove EXT_texture3D extension enable flag

2012-10-30 Thread Marek Olšák
On Mon, Oct 29, 2012 at 7:52 PM, Ian Romanick i...@freedesktop.org wrote: On 10/28/2012 07:24 AM, Marek Olšák wrote: I think we should leave this flag. There is some hardware that can do ES1 that cannot do 3D texturing. Alright, but I'll move the enabling to _mesa_init_extensions. I'd like

Re: [Mesa-dev] [PATCH] r600g: avoid shader needing too many gpr to lockup the gpu v2

2012-10-30 Thread Marek Olšák
This looks good to me. Thank you. Marek On Tue, Oct 30, 2012 at 11:04 PM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com On r6xx/r7xx shader resource management need to make sure that the shader does not goes over the gpr register limit. Each specific asic has a maxmimum

Re: [Mesa-dev] R600 tiling halves the frame rate

2012-10-30 Thread Marek Olšák
On Wed, Oct 31, 2012 at 1:20 AM, Tzvetan Mikov tmi...@jupiter.com wrote: On 10/30/2012 11:45 AM, Jerome Glisse wrote: So tested, it's something inside egl that lead to this, same program as yours with glut on X11 with 2d tiling enabled and 2d color tiling have a slight advantage 140fps vs

Re: [Mesa-dev] [PATCH 1/2] mesa/vbo: Fix scaling issue in 10-bit signed normalized packing.

2012-10-31 Thread Marek Olšák
On Wed, Oct 31, 2012 at 7:45 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 10/15/2012 09:45 AM, Ian Romanick wrote: On 10/14/2012 12:02 PM, Kenneth Graunke wrote: For the 10-bit components, the divisor was incorrect. A 10-bit signed integer can represent -2^9 through 2^9 - 1, which

Re: [Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Marek Olšák
The missing features for GL 3.1 are just UBOs and TBOs. Dave Airlie has been working on TBOs. Nobody is working on UBOs as far as I know. Both features need changes in the driver and in the common code (st/mesa). Marek On Wed, Oct 31, 2012 at 7:34 PM, Patrick Baggett baggett.patr...@gmail.com

[Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Marek Olšák
The problem was we set VRAM|GTT for relocations of STATIC resources. Setting just VRAM increases the framerate 4 times on my machine. I rewrote the switch statement and adjusted the domains for window framebuffers too. --- src/gallium/drivers/r600/r600_buffer.c | 42

Re: [Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Marek Olšák
On Thu, Nov 1, 2012 at 2:13 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Oct 31, 2012 at 8:05 PM, Marek Olšák mar...@gmail.com wrote: The problem was we set VRAM|GTT for relocations of STATIC resources. Setting just VRAM increases the framerate 4 times on my machine. I rewrote

Re: [Mesa-dev] Gallium versioning, currently at 0.4

2012-11-01 Thread Marek Olšák
The Gallium version has no meaning to me. The renderer string could just be ATI RV530. Marek On Wed, Oct 31, 2012 at 6:05 PM, Fabio Pedretti fabio@libero.it wrote: Is there a reason to keep the '0.4' on Gallium renderer string ( 'Gallium 0.4 on ATI RV530' )? It never gets update, although

Re: [Mesa-dev] [PATCH 2/2] mesa: use the EXT_texture_compression_s3tc enable flag for all S3TC extensions

2012-11-02 Thread Marek Olšák
On Mon, Oct 29, 2012 at 7:36 PM, Ian Romanick i...@freedesktop.org wrote: On 10/29/2012 02:47 AM, Philipp Klaus Krause wrote: Am 28.10.2012 20:51, schrieb Kenneth Graunke: This makes sense to me. The original reason for splitting out the ANGLE vs. EXT bits was that the ANGLE extension only

Re: [Mesa-dev] [PATCH] mesa: Fix glGetVertexAttribI[u]iv now that we have real integer attribs.

2012-11-08 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com You can also use the COPY_4V macro like _mesa_GetVertexAttribfvARB does if you want. Marek On Thu, Nov 8, 2012 at 5:59 AM, Kenneth Graunke kenn...@whitecape.org wrote: Since cf438f5375e242, we store actual integers for the attribute data. We just need

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Tue, Nov 6, 2012 at 11:16 PM, Dave Airlie airl...@gmail.com wrote: This contains the evergreen support. Support is possible on rv670 upwards and the code in here should work, but it doesn't and I haven't debugged it to figure out why. Beyond just adding support for the cube map array

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Marek Olšák
On Thu, Nov 8, 2012 at 3:04 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2012-11-08 at 14:48 +0100, Marek Olšák wrote: Flushing here is unnecessary. The drivers which always flush in dri2Throttle or __DRI2flushExtensionRec::flush are just wasting time here. st/mesa is updated to do

Re: [Mesa-dev] [PATCH 1/3] glx: remove glFlush call in glXSwapBuffers

2012-11-08 Thread Marek Olšák
On Thu, Nov 8, 2012 at 7:59 PM, Ian Romanick i...@freedesktop.org wrote: On 11/08/2012 05:48 AM, Marek Olšák wrote: Flushing here is unnecessary. The drivers which always flush in dri2Throttle or __DRI2flushExtensionRec::flush are just wasting time here. st/mesa is updated to do what

Re: [Mesa-dev] [PATCH 10/10] r600g: add initial cube map array support

2012-11-08 Thread Marek Olšák
On Fri, Nov 9, 2012 at 1:23 AM, Dave Airlie airl...@gmail.com wrote: + I would prefer if the constant buffers were updated only if the sampler views were updated as well, so that it's not updated in every draw command that has a shader querying the array size. probably makes sense, I was

Re: [Mesa-dev] [PATCH] r600g: add initial cube map array support (v2)

2012-11-09 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Fri, Nov 9, 2012 at 5:12 AM, Dave Airlie airl...@gmail.com wrote: This contains the evergreen support. Support is possible on rv670 upwards and the code in here should work, but it doesn't and I haven't debugged it to figure out why

Re: [Mesa-dev] [PATCH 2/3] glx: add interface for flushing a drawable and throttling at the same time

2012-11-09 Thread Marek Olšák
On Fri, Nov 9, 2012 at 6:36 PM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: The motivation is to prevent a double flush in Gallium. Gallium flushes in __DRI2flushExtensionRec::flush and dri2Throttle. This will help consolidate the flushing. It looks like you've

Re: [Mesa-dev] [PATCH] st/mesa/dri: add blend func extended disable as per i965

2012-11-10 Thread Marek Olšák
BTW, I don't see any issue with ARB_blend_func_extended in Heaven, but the presence of ARB_shader_bit_encoding breaks shadows. This script for starting Heaven makes it render everything correctly on r600g: export MESA_EXTENSION_OVERRIDE=-GL_ARB_shader_bit_encoding export

Re: [Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-11-10 Thread Marek Olšák
On Fri, Nov 9, 2012 at 9:44 PM, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Nov 01, 2012 at 03:13:31AM +0100, Marek Olšák wrote: On Thu, Nov 1, 2012 at 2:13 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Oct 31, 2012 at 8:05 PM, Marek Olšák mar...@gmail.com wrote: The problem

[Mesa-dev] [PATCH] st/mesa: fix computation of last_level for array textures

2012-11-11 Thread Marek Olšák
NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_gen_mipmap.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mipmap.c index 8892006..7e97edd 100644

[Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Marek Olšák
MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c |6 ++-- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 2/6] mesa: use MaxNumlevels in _mesa_test_texobj_completeness

2012-11-11 Thread Marek Olšák
--- src/mesa/main/texobj.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index c083c72..d650c75 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -445,7 +445,7 @@

[Mesa-dev] [PATCH 3/6] mesa: fix error checking of TexStorage(levels) for array and rect textures

2012-11-11 Thread Marek Olšák
NOTE: This is a candidate for the stable branches. --- src/mesa/main/texstorage.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 9e0b543..00f19ba 100644 --- a/src/mesa/main/texstorage.c +++

[Mesa-dev] [PATCH 4/6] st/mesa: fix guessing the base level size

2012-11-11 Thread Marek Olšák
It was pretty broken with array textures, where the array size (height or depth depending on the target) shouldn't be magnified. The guessing also doesn't fail for 1D and cube textures. (I guess the problem was only with non-square or non-cube textures, right?) NOTE: This is a candidate for the

[Mesa-dev] [PATCH 5/6] st/mesa: fix computation of last_level during texture creation

2012-11-11 Thread Marek Olšák
Array textures were broken. NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_cb_texture.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index

<    5   6   7   8   9   10   11   12   13   14   >