[Mesa-dev] [PATCH 2/2] anv/image: Disable CCS if the image doesn't support rendering

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_image.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index c84fc8ddea..df505ce8f0 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH 1/2] Revert "intel/isl: Only create a CCS buffer if the image supports rendering"

://bugzilla.freedesktop.org/show_bug.cgi?id=101677 Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index bbbdb19df2..ba56d86c17 100644 --- a/src/intel/isl/isl.c +++ b/src/int

[Mesa-dev] [PATCH v3 10/16] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. v2: Avoid refactoring. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/

[Mesa-dev] [PATCH v3 12/16] anv/cmd_buffer: Warn about not enabling CCS_E

Use the performance warning infrastructure to provide helpful information when testing applications. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH v3 15/16] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index d5226c2248..1e96fb42b0 100644 --- a/src

[Mesa-dev] [PATCH v3 16/16] anv: Predicate fast-clear resolves

Image layouts only let us know that an image *may* be fast-cleared. For this reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.

[Mesa-dev] [PATCH v3 07/16] anv/cmd_buffer: Ensure fast-clear values are current

v2: Rewrite functions, change location of synchronization. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src

[Mesa-dev] [PATCH v3 13/16] anv: Stop resolving CCS implicitly

With an earlier patch from this series, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH v3 11/16] anv/cmd_buffer: Move aux_usage assignment up

For readability, bring the assignment of CCS closer to the assignment of NONE and MCS. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 62 ++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git

[Mesa-dev] [PATCH v3 14/16] anv/cmd_buffer: Skip some input attachment transitions

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index d71c3c92c9..62a2

[Mesa-dev] [PATCH v3 02/16] anv/image: Append CCS/MCS with a fast-clear state buffer

v2: Update comments, function signatures, and add assertions. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 12 +++ 2 files changed, 90 insertions(+) diff

[Mesa-dev] [PATCH v3 09/16] anv/cmd_buffer: Disable CCS on gen7 color attachments upfront

The next patch enables the use of CCS_D even when the color attachment will not be fast-cleared. Catch the gen7 case early to simplify the changes required. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 16 +--- 1 file chan

[Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

v2: Expound on comment for the pipe controls (Jason Ekstrand). Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp.c | 4 +- src/intel/vulkan/genX_cmd_buffer.c | 183 + 2 files changed, 167 insertions(+), 20 del

[Mesa-dev] [PATCH v3 05/16] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). v3: Allow some fast clears in the GENERAL layout. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_pass.c| 22 ++ src/intel/vulkan/anv_private.h | 2 ++ src/intel/

[Mesa-dev] [PATCH v3 06/16] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

We'll be performing a GPU memcpy in more places to copy small amounts of data. Add an alternate function that thrashes less state. v2: - Make a new function (Jason Ekstrand). - Move the #define into the function. v3: - Update the function name (Jason). - Update comments. Signed-off-by: Nanley

[Mesa-dev] [PATCH v3 03/16] anv/cmd_buffer: Initialize the clear values buffer

v2: Rewrite functions. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 93 ++ 1 file changed, 84 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/

[Mesa-dev] [PATCH v3 00/16] anv: Do CCS resolves at layout transitions

A quick test shows that this change still improves frame rates on a Dota 2 benchmark by about 3% at 1080p. Cc: Jason Ekstrand <ja...@jlekstrand.net> Nanley Chery (16): intel/isl: Add surface state clear value information anv/image: Append CCS/MCS with a fast-clear state buffer

[Mesa-dev] [PATCH v3 04/16] anv/cmd_buffer: Don't partially fast clear image layers

v2: Don't pass in the command buffer (Jason Ekstrand). v3: Remove an incorrect assertion and an if condition for gen7. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 31 +++ 1 file changed, 23 insertions(+), 8 del

[Mesa-dev] [PATCH v3 01/16] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 10:32:42AM -0700, Jason Ekstrand wrote: > On Thu, Jun 22, 2017 at 10:02 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > > > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanl

Re: [Mesa-dev] [PATCH] intel/anv: Add missing break in anv_CreateDevice()

On Mon, Jun 26, 2017 at 09:07:12PM +0300, Topi Pohjolainen wrote: > CID: 1413018 > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> > --- > src/intel/vulkan/anv_device.c | 1 + > 1 file changed, 1 insertion(+) > This patch is Reviewed-by: Nanley Chery &

Re: [Mesa-dev] [PATCH v2 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

...@jlekstrand.net> > > Given that you're changing core blorp, please make sure you run this > through Jenkins on GL. :-) > > --Jason > Thanks! I made the modification to patch 1 and I'll re-run jenkins for GL. -Nanley > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanl

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanleych...@gm

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > > > v2 (Jason Ekstrand): > > > - Upda

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > v2 (Jason Ekstrand): > > - Update commit title > > - Check aux level and layer as well > > > > Signed-off-

Re: [Mesa-dev] [PATCH v2 12/13] anv/blorp: Provide surface states for CCS resolves

On Wed, Jun 21, 2017 at 06:19:57PM -0700, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > In the future, we plan on using this method to resolve images whose > > surface state fast-clear value is dynamicall

[Mesa-dev] [PATCH v2 08/13] anv/blorp: Remove 3D subresource transition workaround

). Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> (v1) Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> (v1) --- src/intel/vulkan/anv_blorp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v2 11/13] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in the next patch. v2: - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand) - Update commit message. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> --- src/intel/vulkan/anv_bl

[Mesa-dev] [PATCH v2 09/13] anv: Adjust params of color buffer transitioning functions

Splitting out these fields will make the color buffer transitioning function simpler when it gains more features. v2: Remove unintended blank line (Iago Toral) Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> --- src/

[Mesa-dev] [PATCH v2 07/13] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Ch

[Mesa-dev] [PATCH v2 12/13] anv/blorp: Provide surface states for CCS resolves

In the future, we plan on using this method to resolve images whose surface state fast-clear value is dynamically updated during command buffer execution. Start using it now for testing and to reduce churn later on. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago

[Mesa-dev] [PATCH v2 10/13] blorp/clear: Add a binding-table-based CCS resolve function

v2: - Do layered resolves. (Jason Ekstrand): - Replace "bt" suffix with "attachment". - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral

[Mesa-dev] [PATCH v2 05/13] anv: Add and use color auxiliary buffer helpers

v2: - Check for aux levels in layer helper (Jason Ekstrand) - Don't assert aux is present, return 0 if it isn't. - Use the helpers. v3: - Make the helpers aspect-agnostic (Jason Ekstrand) - Drop anv_image_has_color_aux() Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by

[Mesa-dev] [PATCH v2 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

-by: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> (v2) --- src/intel/vulkan/anv_genX.h| 8 src/intel/vulkan/genX_cmd_buffer.c | 6 +++--- src/intel/vulkan/gen

[Mesa-dev] [PATCH v2 04/13] intel/isl: Only create a CCS buffer if the image supports rendering

v2: Omit the commit message. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> (v1) Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 02/13] intel/blorp: Check for layer fast-clear restriction

v2: Update commit title (Jason Ekstrand) Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> (v1) --- src/intel/blorp/blorp_clear.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

On Wed, Jun 21, 2017 at 09:04:01AM +0200, Iago Toral wrote: > On Tue, 2017-06-20 at 12:21 -0700, Nanley Chery wrote: > > On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery <nanleych...@gmail.co > > > m

Re: [Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

On Tue, Jun 20, 2017 at 02:50:33PM -0700, Jason Ekstrand wrote: > On Tue, Jun 20, 2017 at 2:43 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote: > > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley C

Re: [Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote: > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > src/intel/blorp/blorp_clear.c | 4

Re: [Mesa-dev] [PATCH 01/13] intel/blorp: Assert on subresource in surface_info_init

l have to send out a V2, so I'll update the 3 uses of that term. > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > src/intel/blorp/blorp.c | 4 &g

Re: [Mesa-dev] [PATCH 05/13] anv: Add and use color auxiliary buffer helpers

On Mon, Jun 19, 2017 at 05:03:51PM -0700, Jason Ekstrand wrote: > On Mon, Jun 19, 2017 at 4:46 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Mon, Jun 19, 2017 at 04:16:32PM -0700, Jason Ekstrand wrote: > > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley C

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote: > On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote: > > > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery

Re: [Mesa-dev] [PATCH 08/13] anv: Adjust params of color buffer transitioning functions

On Mon, Jun 19, 2017 at 04:33:29PM -0700, Jason Ekstrand wrote: > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > Splitting out these fields will make the color buffer transitioning > > function simpler when it gains more f

Re: [Mesa-dev] [PATCH 05/13] anv: Add and use color auxiliary buffer helpers

On Mon, Jun 19, 2017 at 04:16:32PM -0700, Jason Ekstrand wrote: > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > v2: > > - Check for aux levels in layer helper (Jason Ekstrand) > > - Don't assert aux is present, return 0 i

Re: [Mesa-dev] [PATCH 00/13] anv: Prep-work for layout-based CCS resolves

t you still need to wait until Vulkan issue #849 is > resolved before merging some of these too. > > Iago > Thank you for the review! I plan to merge parts of this series soon. -Nanley > > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > > This series implem

Re: [Mesa-dev] [PATCH 11/15] i965: Add isl based miptree creator

ags = 1u << isl_tiling > + }; > + > + if (!isl_surf_init_s(>isl_dev, >surf, _info)) > + goto fail; > + > + assert(mt->surf.size % mt->surf.row_pitch == 0); > + > + if (!bo) { > + unsigned pitch = mt->surf.row_pitch; ^ MAYBE_UNUSED for

Re: [Mesa-dev] [PATCH 10/15] i965/miptree: Add option to resolve offsets using isl_surf

ng that using these intermediate variables avoids casting warnings? With or without the code comment, this patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > + return; > + } > + > assert(slice < mt->level[level].depth); > > *x

Re: [Mesa-dev] [PATCH 09/15] i965: Prepare slice copy for isl based miptrees

_level); > > > + > > > + const unsigned level_depth = src_mt->surf.dim == ISL_SURF_DIM_3D ? > > > > > > > This needs a MAYBE_UNUSED or else we'll get warnings in release builds. > > Another option would be to do > > &

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

On Fri, Jun 16, 2017 at 07:58:02AM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 15, 2017 at 05:18:22PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> &

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

On Thu, Jun 15, 2017 at 06:23:24PM -0700, Jason Ekstrand wrote: > On Thu, Jun 15, 2017 at 5:18 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 05/15] i965: Prepare image validation for isl based miptrees

On Tue, Jun 13, 2017 at 05:50:03PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_blit.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h >

Re: [Mesa-dev] [PATCH V2] intel/isl: Add the maximum surface size limit

tricted to a maximum size in bytes. This > + * maximum is 2 GB for all products and all surface types. This block and the following are missing closing quotations. I think we can omit the opening quotes since you're doing a block quote. It's up to you though. With those t

Re: [Mesa-dev] [PATCH 08/13] anv: Adjust params of color buffer transitioning functions

On Wed, Jun 14, 2017 at 10:13:41AM +0200, Iago Toral wrote: > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > Splitting out these fields will make the color buffer transitioning > > function simpler when it gains more features. > > > > Signed-off-by

Re: [Mesa-dev] [PATCH 04/15] i965: Prepare up/downsampling for isl based miptrees

ons(-) > Patches 2-4 are Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > index 78a223a7f3..061860cdf6 100644 > --- a/src/mesa/drivers/dri/i965/intel_mipma

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

On Wed, Jun 14, 2017 at 09:45:46PM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 04:31:26PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> &

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote: > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > For 3D image subresources undergoing a layout transition via > > PipelineBarrier, we increase the number of fast-cleared layers to > > match >

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Wed, Jun 14, 2017 at 10:36:16AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 13, 2017 at 05:26:52PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com> &

Re: [Mesa-dev] [PATCH 06/15] i965: Prepare slice validator for isl based miptrees

On Tue, Jun 13, 2017 at 05:50:04PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 01/15] i965/miptree: Refactor mapping table alloc

On Tue, Jun 13, 2017 at 05:49:59PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 > +-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/blorp/blorp_clear.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 3d5c41cc71..f43d05ad19 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src

[Mesa-dev] [PATCH 12/13] anv/blorp: Provide surface states for CCS resolves

In the future, we plan on using this method to resolve images whose surface state fast-clear value is dynamically updated during command buffer execution. Start using it now for testing and to reduce churn later on. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/

[Mesa-dev] [PATCH 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

A GPU memcpy function could alternatively be implemented using MI_* commands. Provide more detail into how this one operates in case another memcpy function is created. v2: Update the commit message. Suggested-by: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Nanley Chery <na

[Mesa-dev] [PATCH 06/13] anv/cmd_buffer: Adjust layout transition aspect checking

Reflect the fact that an image view or subresource range with the color aspect cannot have any other aspect. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH 11/13] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in the next patch. v2: - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand) - Update commit message. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp.c | 41 + src/intel/vulkan/anv_pri

[Mesa-dev] [PATCH 08/13] anv: Adjust params of color buffer transitioning functions

Splitting out these fields will make the color buffer transitioning function simpler when it gains more features. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp.c | 33 src/intel/vulkan/anv_private.h | 4 ++-

[Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

tests. Instead, unify the behaviour in both scenarios, and wait for the CTS tests to catch up. See CL for the test fix. On SKL+, this causes 3 test failures under: dEQP-VK.pipeline.render_to_image.3d.* Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp

[Mesa-dev] [PATCH 00/13] anv: Prep-work for layout-based CCS resolves

This series implements refactors and behavioral changes to make the follow-on series which implements layout-based CCS resolves a lot clearer. Cc: Jason Ekstrand <ja...@jlekstrand.net> Nanley Chery (13): intel/blorp: Assert on subresource in surface_info_init intel/blorp: Assert on gen

[Mesa-dev] [PATCH 01/13] intel/blorp: Assert on subresource in surface_info_init

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/blorp/blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c index 9c88658e8a..993b42fa85 100644 --- a/src/intel/blorp/blorp.c +++ b/src/intel/blorp/blorp.c @@

[Mesa-dev] [PATCH 10/13] blorp/clear: Add a binding-table-based CCS resolve function

v2: - Do layered resolves. (Jason Ekstrand): - Replace "bt" suffix with "attachment". - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- Looks like layered CCS re

[Mesa-dev] [PATCH 04/13] intel/isl: Only create a CCS buffer if the image supports rendering

v2: Omit the commit message. Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> (v1) Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c inde

[Mesa-dev] [PATCH 03/13] intel/isl: Limit CCS to one subresource on gen7

Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/isl/isl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 860fc28b27..b593e153dc 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1

[Mesa-dev] [PATCH 09/13] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Ch

[Mesa-dev] [PATCH 05/13] anv: Add and use color auxiliary buffer helpers

v2: - Check for aux levels in layer helper (Jason Ekstrand) - Don't assert aux is present, return 0 if it isn't. - Use the helpers. Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/vulkan/anv_blorp.c | 4 src/intel/vulkan/anv_private.

Re: [Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote: > This commit adds a new unified interface for doing resolves. The basic > format is that, prior to any surface access such as texturing or > rendering, you call intel_miptree_prepare_access. If the surface was > written, you call

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Fri, Jun 02, 2017 at 01:05:47PM -0700, Jason Ekstrand wrote: > On Fri, Jun 2, 2017 at 12:57 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > > This enum describes all of the states

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > This enum describes all of the states that a auxiliary compressed ^ an > surface can have. All of the states as well as normative language

Re: [Mesa-dev] [PATCH 05/24] i965/cnl: Include gen10_pack.h

On Fri, May 12, 2017 at 04:38:09PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> > --- > src/intel/genxml/genX_pack.h | 2 ++ > 1 file changed, 2 insertions(+) > Patches 4-5 are Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com>

Re: [Mesa-dev] [PATCH 05/16] anv/image: Get rid of the memset(aux, 0, sizeof(aux)) hack

tel/vulkan/anv_image.c | 28 > 1 file changed, 28 deletions(-) > I'm glad that we're fixing this. This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c > index d65ef47..351018

Re: [Mesa-dev] [PATCH v2 4/16] anv: Handle color layout transitions from the UNINITIALIZED layout

ws what > will > +* happen to caching at that point. It's probably best if we don't let > +* this happen at the same time as other rendering. Flush the render > cache > +* and stall prior to this operation. > +*/ Stale comment? This patch is Reviewed-by: N

Re: [Mesa-dev] [PATCH 15/16] anv: Require vertex buffers to come from a 32-bit heap

On Thu, May 18, 2017 at 02:01:02PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 12 > 1 file changed, 12 insertions(+) > Patches 9 and 15 are Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH 12/16] anv: Make supports_48bit_addresses a heap property

On Thu, May 18, 2017 at 02:00:59PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > src/intel/vulkan/anv_private.h | 11 ++- > 2 files changed, 14 insertions(+), 3 deletions(-) > This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

arger than 3GiB which most likely means they have 8 GiB > > of > > > + * video memory and so carving off 2 GiB for the 32-bit heap > > should be > > > + * reasonable. > > > + */ > > > + const uint32_t heap_size_32bit = 2ull * (1ull

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

On Fri, May 19, 2017 at 10:53:12AM -0700, Jason Ekstrand wrote: > On Thu, May 18, 2017 at 2:01 PM, Jason Ekstrand > wrote: > > > --- > > src/intel/vulkan/anv_device.c | 42 ++ > > ++-- > > 1 file changed, 36 insertions(+), 6 deletions(-)

Re: [Mesa-dev] [PATCH 13/16] anv: Refactor memory type setup

insertions(+), 36 deletions(-) > This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index bb02378..6ea8dfe 100644 > --- a/src/intel/vulkan/anv_device.c > +++ b/src/intel/

Re: [Mesa-dev] [PATCH 11/16] anv: Stop setting BO flags in bo_init_new

On Thu, May 18, 2017 at 02:00:58PM -0700, Jason Ekstrand wrote: > The idea behind doing this was to make it easier to set various flags. > However, we have enough custom flag settings floating around the driver > that this is more of a nuisance than a help. > --- >

Re: [Mesa-dev] [PATCH 10/16] anv: Set image memory types based on the type count

On Thu, May 18, 2017 at 02:00:57PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/anv

Re: [Mesa-dev] [PATCH 08/16] anv: Determine the type of mapping based on type metadata

_device.c | 12 ++-- > src/intel/vulkan/anv_private.h | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > Patches 7 and 8 are Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index

Re: [Mesa-dev] [PATCH 06/16] anv: Predicate 48bit support on gen >= 8

7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 50486b6..b80715f 100644 > --- a/src/intel/vulkan/a

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 04:29:16PM -0700, Ian Romanick wrote: > On 05/19/2017 10:28 AM, Nanley Chery wrote: > > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > >> From: Ian Romanick <ian.d.roman...@intel.com> > >> > >> The previous code ha

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Fri, May 19, 2017 at 06:09:49PM -0700, Nanley Chery wrote: > On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > > > On Thu, May 18, 2017 at 02:00:51

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_image.

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 05:32:07PM -0700, Ian Romanick wrote: > On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > >> I missed that glsl_parser_extras.cpp has its own implementation of the > >> has_XXX_foo() functions that

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 12 ++-- > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH 03/16] anv: Handle color layout transitions from the UNINITIALIZED layout

On Thu, May 18, 2017 at 02:00:50PM -0700, Jason Ekstrand wrote: > This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start > failing due to test bugs. See CL 1031 for a test fix. > --- > src/intel/vulkan/anv_blorp.c | 40 > ++ >

[Mesa-dev] [PATCH] docs: Document ASTC extension support for SKL and BXT

Cc: Anuj Phogat <anuj.pho...@gmail.com> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index e18bf54a48..05d776be08 100644 --- a/docs/features.tx

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

On Fri, May 19, 2017 at 10:41:22AM -0700, Anuj Phogat wrote: > On Thu, May 18, 2017 at 3:53 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > This platform passes the following GLES3 tests: > > ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* > >

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > From: Ian Romanick > > The previous code handled everything with the general case. I noticed > that every time I converted an open-coded check to use a > _mesa_has_EXT_foo() function, the text size of the

[Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

This platform passes the following GLES3 tests: ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drive

<    1   2   3   4   5   6   7   8   9   10   >