Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: > On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: > >> To support the EGL_KHR_fence_sync extension on the DR

[Mesa-dev] [PATCH] st/dri: fix winsys handle stride calculation for block formats

This fixes the stride calculation for pipe formats with a block width larger than one. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Am Donnerstag, den 26.05.2016, 10:36 -0400 schrieb Ilia Mirkin: > On Thu, May 26, 2016 at 10:31 AM, Marek Olšák <mar...@gmail.com> wrote: > > On Wed, May 25, 2016 at 3:34 PM, Philipp Zabel <p.za...@pengutronix.de> > > wrote: > >> Am Mittwoch, den 25.05.2

Re: [Mesa-dev] [PATCH] st/dri: fix winsys handle stride calculation for block formats

Am Donnerstag, den 26.05.2016, 12:43 +0100 schrieb Emil Velikov: > Hi gents, > > On 26 May 2016 at 11:28, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Hi Michel, > > > > Am Donnerstag, den 26.05.2016, 17:59 +0900 schrieb Michel Dänzer: > >>

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Hi Emil, Am Mittwoch, den 25.05.2016, 23:42 +0100 schrieb Emil Velikov: [...] > Or in other words, in case of egl + gbm, egl inherits the screen from > the gbm device. As such platform_gbm does not call the core egl setup > function, dri2_create_screen (like everyone else does x11, wayland...) >

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Hi Marek, Am Mittwoch, den 25.05.2016, 20:52 +0200 schrieb Marek Olšák: > On Wed, May 25, 2016 at 4:46 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: > >> On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel

Re: [Mesa-dev] [PATCH] st/dri: fix winsys handle stride calculation for block formats

Hi Michel, Am Donnerstag, den 26.05.2016, 17:59 +0900 schrieb Michel Dänzer: > On 25.05.2016 22:20, Philipp Zabel wrote: > > This fixes the stride calculation for pipe formats with a block width > > larger than one. > > > > Signed-off-by: Philipp Zabel <p.za...@pe

[Mesa-dev] [PATCH] anv: pCreateInfo->pApplicationInfo parameter to vkCreateInstance may be NULL

Fix a NULL pointer dereference in anv_CreateInstance in case the pApplicationInfo field of the supplied VkInstanceCreateInfo structure is NULL [1]. [1] https://www.khronos.org/registry/vulkan/specs/1.0/apispec.html#VkInstanceCreateInfo Signed-off-by: Philipp Zabel <philipp.za...@gmail.

[Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

To support the EGL_KHR_fence_sync extension on the DRM EGL platform, add the DRI2 fence extension to the dri_core_extensions match table. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gbm/backends/dri/gbm_dri.c| 1 + src/gbm/backends/dri/gbm_driint.h | 1 + 2 files chan

[Mesa-dev] [PATCH 2/2] egl_dri2: Enable the DRI2 fence extension

To support the EGL_KHR_fence_sync extension on the DRM EGL platform, copy the DRI2 fence extension from the GBM DRI backend. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/egl/drivers/dri2/platform_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/driver

[Mesa-dev] [PATCH 1/2] mesa: Allow to invalidate external textures when (re-)binding

mesa_BindTextures if the target is external. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/main/texobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index c9502bd..6219617 100644 --- a/src/mes

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

Am Mittwoch, den 25.05.2016, 09:23 -0400 schrieb Ilia Mirkin: > Iirc invalidate_resource is to allow backend to discard the contents... Thanks, I didn't know that. So this would need a new callback then? Specifically I want to discard a copy in tiled layout that was derived from a linear external

[Mesa-dev] [PATCH 2/2] st/mesa: Invalidate external textures when (re-)binding

to the values in the external texture at or after the time that glBindTexture was called. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_atom_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/sr

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: > To support the EGL_KHR_fence_sync extension on the DRM EGL platform, > add the DRI2 fence extension to the dri_core_extensions match table. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Gentle p

[Mesa-dev] [PATCH v5 0/7] etnaviv: update derived texture resources of (re)imported buffers

the resource_changed wrapper only if resource_changed is implemented by the wrapped pipe_screen, add SCR_INIT macros to the rbug and trace wrappers. - Fix rbug_screen_resource_changed return value. Philipp Zabel (7): gallium: add pipe_screen::resource_changed st/dri: ask the driver to update

[Mesa-dev] [PATCH v5 1/7] gallium: add pipe_screen::resource_changed

Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Roland Scheidegger <srol...@vmware.com> --- src/gallium/docs/source/scre

[Mesa-dev] [PATCH v5 4/7] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Reviewed-by: Christian Gmeiner <chris

[Mesa-dev] [PATCH v5 7/7] gallium: add pipe_screen::resource_changed callback wrappers

Add resource_changed to the ddebug, rbug, and trace wrappers. Since it is optional, there is no need to add it to noop. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Suggested-by: Nicolai Hähnle <nhaeh...@gmail.com> --- Changes since v4: - Use SCR_INIT to initialize the reso

[Mesa-dev] [PATCH v5 2/7] st/dri: ask the driver to update its internal copies on reimport

. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 77523e9..c4f2c57 100644 --- a/src/gallium/state_tracke

[Mesa-dev] [PATCH v5 3/7] etnaviv: initialize seqno of imported resources

Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Christian Gmeiner <chris

[Mesa-dev] [PATCH v5 5/7] mesa: update external textures when (re-)binding

mesa_BindTextures if the target is external. This will later allow the state tracker to instruct the pipe driver to invalidate internal resources derived from the external texture. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/main/texobj.c | 5 +++-- 1 file changed, 3 inse

[Mesa-dev] [PATCH v5 6/7] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

values that correspond to the values in the external texture at or after the time that glBindTexture was called. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_atom_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_t

[Mesa-dev] [PATCH] anv: fix GetPhysicalDeviceProperties to return timestampPeriod in ns

According to chapters 16.5. (Timestamp Queries) and 30.2 (Limits) of the Vulkan Specification 1.0.29, the .limits.timestampPeriod field returned by vkGetPhysicalDeviceProperties is measured in nanoseconds, not in seconds. Signed-off-by: Philipp Zabel <philipp.za...@gmail.com> --- src

[Mesa-dev] [PATCH v3 2/6] st/dri: ask the driver to update its internal copies on reimport

. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 9ec069b..a216e83 100644 --- a/src/gallium/state_tracke

[Mesa-dev] [PATCH v3 5/6] mesa: update external textures when (re-)binding

mesa_BindTextures if the target is external. This will later allow the state tracker to instruct the pipe driver to invalidate internal resources derived from the external texture. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/main/texobj.c | 5 +++-- 1 file changed, 3 inse

[Mesa-dev] [PATCH v3 4/6] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/etnaviv/etnaviv_resource.

[Mesa-dev] [PATCH v3 6/6] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

values that correspond to the values in the external texture at or after the time that glBindTexture was called. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_atom_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_t

[Mesa-dev] [PATCH v3 3/6] etnaviv: initialize seqno of imported resources

Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/e

[Mesa-dev] [PATCH v4 7/7] gallium: add pipe_screen::resource_changed callback wrappers

Add resource_changed to the ddebug, rbug, and trace wrappers. Since it is optional, there is no need to add it to noop. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Suggested-by: Nicolai Hähnle <nhaeh...@gmail.com> --- src/gallium/drivers/ddebug/dd_screen.c | 10 ++

[Mesa-dev] [PATCH v4 2/7] st/dri: ask the driver to update its internal copies on reimport

. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 9ec069b..a216e83 100644 --- a/src/gallium/state_tracke

[Mesa-dev] [PATCH v4 3/7] etnaviv: initialize seqno of imported resources

Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/e

[Mesa-dev] [PATCH v4 1/7] gallium: add pipe_screen::resource_changed

Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Roland Scheidegger <srol...@vmware.com> --- src/gallium/docs/source/scre

[Mesa-dev] [PATCH v4 5/7] mesa: update external textures when (re-)binding

mesa_BindTextures if the target is external. This will later allow the state tracker to instruct the pipe driver to invalidate internal resources derived from the external texture. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/main/texobj.c | 5 +++-- 1 file changed, 3 inse

[Mesa-dev] [PATCH v4 0/7] etnaviv: update derived texture resources of (re)imported buffers

and trigger the resolve on first use. Changes since v3: - Added resource_changed to ddebug, rbug, and trace wrapper drivers regards Philipp Philipp Zabel (7): gallium: add pipe_screen::resource_changed st/dri: ask the driver to update its internal copies on reimport etnaviv: initialize seqno

[Mesa-dev] [PATCH v4 6/7] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

values that correspond to the values in the external texture at or after the time that glBindTexture was called. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_atom_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_t

[Mesa-dev] [PATCH v4 4/7] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/etnaviv/etnaviv_resource.

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

a wl_surface. I see resource_changed as complementary to the resource_create / resource_from_handle functionality, which already resides in pipe_screen. regards Philipp > Marek > > On Fri, Dec 2, 2016 at 4:27 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Add a hook to tell

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

Am Montag, den 05.12.2016, 11:19 +0100 schrieb Philipp Zabel: > Hi Marek, > > Am Freitag, den 02.12.2016, 23:10 +0100 schrieb Marek Olšák: > > Shouldn't this be in pipe_context if it does a copy? Actually, resource_changed is not supposed to create a copy immediately. Maybe inst

[Mesa-dev] [PATCH v2 4/6] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/etnaviv/etnaviv_resource.

[Mesa-dev] [PATCH v2 1/6] gallium: add pipe_screen::resource_changed

Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v1: - Clarified intended of pipe_screen::resource_changed --- src/gallium/includ

[Mesa-dev] [PATCH v2 5/6] mesa: update external textures when (re-)binding

mesa_BindTextures if the target is external. This will later allow the state tracker to instruct the pipe driver to invalidate internal resources derived from the external texture. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/main/texobj.c | 5 +++-- 1 file changed, 3 inse

[Mesa-dev] [PATCH v2 2/6] st/dri: ask the driver to update its internal copies on reimport

. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 9ec069b..a216e83 100644 --- a/src/gallium/state_tracke

[Mesa-dev] [PATCH v2 0/6] etnaviv: update derived texture resources of (re)imported buffers

and trigger the resolve on first use. Changes since v1: - Clarify intended use of pipe_screen::resource_changed - Add updated GL_OES_EGL_image_external patches regards Philipp Philipp Zabel (6): gallium: add pipe_screen::resource_changed st/dri: ask the driver to update its internal copies

[Mesa-dev] [PATCH v2 3/6] etnaviv: initialize seqno of imported resources

Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/e

[Mesa-dev] [PATCH v2 6/6] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

values that correspond to the values in the external texture at or after the time that glBindTexture was called. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_atom_texture.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_t

[Mesa-dev] [PATCH 1/4] gallium: add pipe_screen::resource_changed

Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/include/pipe/p_screen.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/g

[Mesa-dev] [PATCH 4/4] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

Implement the new resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables that may contain new contents. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/e

[Mesa-dev] [PATCH 2/4] st/dri: ask the driver to update its internal copies on reimport

. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/state_trackers/dri/dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 9ec069b..a216e83 100644 --- a/src/gallium/state_tracke

[Mesa-dev] [PATCH 3/4] etnaviv: initialize seqno of imported resources

Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if they had already been rendered to. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/e

[Mesa-dev] [PATCH 0/4] etnaviv: update derived texture resources of (re)imported buffers

so that texture resources created from them are actually older and trigger the resolve on first use. regards Philipp Philipp Zabel (4): gallium: add pipe_screen::resource_changed st/dri: ask the driver to update its internal copies on reimport etnaviv: initialize seqno of imported resources

[Mesa-dev] [PATCH v3 0/6] etnaviv: update derived texture resources of (re)imported buffers

and trigger the resolve on first use. Changes since v2: - Added resource_changed paragraph to screen.rst regards Philipp Philipp Zabel (6): gallium: add pipe_screen::resource_changed st/dri: ask the driver to update its internal copies on reimport etnaviv: initialize seqno of imported resources

[Mesa-dev] [PATCH v3 1/6] gallium: add pipe_screen::resource_changed

Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v2: - Added resource_changed paragraph to screen.rst --- src/gallium/docs/source/scre

[Mesa-dev] [PATCH 2/2] st/mesa: EGLImageTarget* error handling

error is generated. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_cb_eglimage.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_eglimage.c b/src/mesa/state_tracker/st_cb_egli

[Mesa-dev] [PATCH 1/2] st/mesa: move st_manager_get_egl_image_surface into st_cb_eglimage.c

The only callers are here, and we will add generation of GL errors in the following patch. Rename the function to st_egl_image_get_surface, pass the gl_context instead of st_context, and move the cast from GLeglImageOES to void* into st_egl_image_get_surface. Signed-off-by: Philipp Zabel <p

[Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

error is generated. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> --- v2: fixed get_surface to actually use the usage and error parameters --- src/mesa/state_tracker/st_cb_eglimage.c | 23 +++ 1 file

[Mesa-dev] [PATCH v2 1/2] st/mesa: move st_manager_get_egl_image_surface into st_cb_eglimage.c

The only callers are here, and we will add generation of GL errors in the following patch. Rename the function to st_egl_image_get_surface, pass the gl_context instead of st_context, and move the cast from GLeglImageOES to void* into st_egl_image_get_surface. Signed-off-by: Philipp Zabel <p

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: EGLImageTarget* error handling

On Wed, 2017-03-29 at 13:01 +0200, Nicolai Hähnle wrote: > On 29.03.2017 09:44, Philipp Zabel wrote: > > Stop trying to specify texture or renderbuffer objects for unsupported > > EGL images. Generate the error codes specified in the OES_EGL_image > > extension. > >

Re: [Mesa-dev] [PATCH] st/mesa: EGLImageTarget error handling

Hi Nicolai, thank you for the comments. On Wed, 2017-03-22 at 07:58 +0100, Nicolai Hähnle wrote: > On 21.03.2017 17:51, Philipp Zabel wrote: > > Stop trying to specify texture or renderbuffer objects for unsupported > > EGL images. Generate the error codes specified in th

Re: [Mesa-dev] [PATCH v2] etnaviv: native fence fd support

On Tue, 2017-04-11 at 19:20 +0200, Wladimir J. van der Laan wrote: > On Fri, Apr 07, 2017 at 02:21:35PM +0200, Philipp Zabel wrote: > > This adds native fence fd support to etnaviv, similarly to commit > > 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kern

[Mesa-dev] [PATCH] etnaviv: increment the resource seqno in resource_changed

Just increment the resource seqno instead of setting the texture seqno to be lower by one than the resource seqno. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v3] etnaviv: native fence fd support

This adds native fence fd support to etnaviv, similarly to commit 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel driver version 1.1 or later. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com>

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

On Wed, 2017-04-05 at 19:46 +0200, Christian Gmeiner wrote: [...] > > --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c > > +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c > > @@ -137,6 +137,9 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum > > pipe_cap param) > > case

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

On Wed, 2017-04-05 at 13:12 -0400, Rob Clark wrote: > On Wed, Apr 5, 2017 at 12:14 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > +void > > +etna_fence_server_sync(struct pipe_context *pctx, > > + struct pipe_fence_handle *pfence) > &g

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

On Thu, 2017-04-06 at 09:54 +0200, Christian Gmeiner wrote: > /2017-04-05 18:14 GMT+02:00 Philipp Zabel <p.za...@pengutronix.de>: > > This adds native fence fd support to etnaviv, similarly to commit > > 0b98e84e9ba0 ("freedreno: native fence fd"), enabled fo

[Mesa-dev] [PATCH v2] etnaviv: native fence fd support

This adds native fence fd support to etnaviv, similarly to commit 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel driver version 1.1 or later. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- v2: address review comments - always call etna_cmd_stream_flush

[Mesa-dev] [RFC] etnaviv: native fence fd support

This adds native fence fd support to etnaviv, similarly to commit 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel driver version 1.1 or later. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- This depends on libdrm patches [1][2] which may or may no

Re: [Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

Hi Wladimir, On Thu, 2017-04-13 at 16:05 +0200, Wladimir J. van der Laan wrote: > This patch adds support for the SINGLE_BUFFER feature on GC3000 > GPUs, which allows rendering to a single buffer using multiple pixel > pipes. > > This feature is always used when it is available, which means that

[Mesa-dev] [PATCH] st/mesa: EGLImageTarget error handling

Stop trying to specify texture or renderbuffer objects for unsupported EGL images. Generate the error codes specified in the OES_EGL_image extension. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call the pipe dr

Re: [Mesa-dev] [PATCH v2] egl/dri2: Allow modifiers to add FDs to imports

iersLo[i].IsPresent && > +  attrs->DMABufPlaneModifiersHi[i].IsPresent) { > + plane_n = i + 1; > +  } > +   } > + Nice, this makes sure that all planes up to the last modifier have fds present. And since all fds are guaranteed to be present, the modifier equality check in dri2_c

Re: [Mesa-dev] [PATCH] st/dri: allow direct YUYV import

_format dri2_format_to_pipe_format (int > format) > case __DRI_IMAGE_FORMAT_GR88: >pf = PIPE_FORMAT_RG88_UNORM; >break; > + case __DRI_IMAGE_FORMAT_YUYV: > + pf = PIPE_FORMAT_YUYV; > + break; > default: >pf = PIPE_FORMAT_NONE; &

[Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

ted(). Fixes: 83e9de25f325 ("st/mesa: EGLImageTarget* error handling") Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/mesa/state_tracker/st_cb_eglimage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_eglimage.c b/src/mesa/state_track

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

DER_TARGET) { > - /* Render targets are linear in Xorg but must be tiled > - * here. It would be nice if dri_drawable_get_format() > - * set scanout for these buffers too. */ > + if (rsc->layout == ETNA_LAYOUT_LINEAR) { > + /* > + * Both samp

Re: [Mesa-dev] [PATCH] etnaviv: flush source TS before resolve

etna_set_state(ctx->stream, VIVS_TS_FLUSH_CACHE, > VIVS_TS_FLUSH_CACHE_FLUSH); > } > > /* Set up color TS to source surface before blit, if needed */ Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] renderonly: close transfer prime_fd

prime_fd is only used to transfer the scanout buffer to the GPU inside renderonly_create_kms_dumb_buffer_for_resource. It should be closed immediately to avoid leaking the DMA-BUF file handle. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/auxiliary/renderonly/render

[Mesa-dev] [PATCH 2/2] renderonly: drop resources on destroy

The renderonly_scanout holds a reference on its prime pipe resource, which should be released when it is destroyed. If it was created by renderonly_create_kms_dumb_buffer_for_resource, the dumb BO also has to be destroyed. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/g

[Mesa-dev] [PATCH] renderonly: use drmIoctl

To restart interrupted system calls, use drmIoctl. Suggested-by: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Applies on top of the "renderonly: drop resources on destroy" patch: https://patchwork.freedesktop.org/patch/15

Re: [Mesa-dev] [PATCH 2/2] renderonly: drop resources on destroy

On Fri, 2017-04-28 at 11:19 +0100, Emil Velikov wrote: > On 27 April 2017 at 17:44, Philipp Zabel <p.za...@pengutronix.de> wrote: > > The renderonly_scanout holds a reference on its prime pipe resource, > > which should be released when it is destroy

[Mesa-dev] [PATCH] renderonly: use drmIoctl

To restart interrupted system calls, use drmIoctl. Suggested-by: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Applies on top of the "renderonly: drop resources on destroy" patch: https://patchwork.freedesktop.org/patch/15

Re: [Mesa-dev] [PATCH] etnaviv: Add support for R8_UNORM textures

E), > V_(R8_UINT,UNSIGNED_BYTE, NONE), > V_(R8_SINT,BYTE, NONE), Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

On Tue, 2017-08-08 at 07:29 +0300, Tapani Pälli wrote: > > On 08/07/2017 03:05 PM, Philipp Zabel wrote: > > On Mon, 2017-07-31 at 18:35 +0100, Daniel Stone wrote: > >> When using dmabuf import, make sure that the modifier is actually > >> allowed to add planes

Re: [Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

gt; > _eglError(EGL_BAD_ATTRIBUTE, "too many plane attributes"); > return 0; Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote: > On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > > Look up BOs from the name table using the name parameter instead of > > req.handle (which at this point is always zero). > > Good

[Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

Look up BOs from the name table using the name parameter instead of req.handle (which at this point is always zero). Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- etnaviv/etnaviv_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etnaviv/etnaviv_bo.c b/e

[Mesa-dev] [PATCH 2/2] etnaviv: add etna_bo_from_handle

Although etnaviv_drmif.h declared etna_bo_from_handle from the start, there was no implementation. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- etnaviv/etnaviv_bo.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnavi

Re: [Mesa-dev] [PATCH 5/5] etnaviv: increment the resource seqno in resource_changed

it. regards Philipp > > On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote: > > From: Philipp Zabel <p.za...@pengutronix.de> > > > > Just increment the resource seqno instead of setting the texture > > seqno to be lower by one than the resource seqno.

[Mesa-dev] [PATCH] configure.ac: Fix help string for --disable-pwr8 configure option

Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index df3eb6b29a..5c460f43d5 100644 --- a/configure.ac +++ b/configure.ac @@ -455,7 +455,7 @@ int main () { CFLAGS=$save_

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

On Tue, 2017-05-09 at 12:48 +0200, Volker Vogelhuber wrote: [...] > Ok thanks for the clarification. There is only one missing part for the > GL_TEXTURE_2D case. The second EGLImage is created internally when > calling eglCreateImage with EGL_LINUX_DMA_BUF_EXT, so I only > have one return value I

Re: [Mesa-dev] Sampling DRM_FORMAT_YUYV in GLSL

On Tue, 2017-05-09 at 12:31 +0300, Tapani Pälli wrote: > > On 05/09/2017 12:29 PM, Tapani Pälli wrote: > > > > > > On 05/09/2017 12:14 PM, Volker Vogelhuber wrote: > >> Hi, > >> > >> first sorry, for missing the subject in my mail to the mailing list, > >> then thanks > >> for the hint with

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Check extended format availability on GPU

Hi Wladimir, On Tue, 2017-05-16 at 10:42 +0200, Wladimir J. van der Laan wrote: > Current information shows that both extended texture/render formats > and texture swizzling were introduced with the HALTI0 feature bit, > available on GC2000/GC3000. With this patch applied, trying to import

Re: [Mesa-dev] [PATCH] mesa/st: fix yuv EGLImage's

On Tue, 2017-05-16 at 10:33 -0400, Rob Clark wrote: > Don't reject YUV formats that the driver doesn't handle natively, since > mesa/st already knows how to lower this in shader. > > Fixes: 83e9de2 ("st/mesa: EGLImageTarget* error handling") > Cc: 17.1

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

, >base, 0, > view->texture->last_level); > - etna_resource(res->texture)->seqno = res->seqno; > - } else if (etna_resource_needs_flush(res)) { > - etna_copy_resource(view->context, view->texture, view->texture, 0, 0); > -

Re: [Mesa-dev] [PATCH 02/11] etnaviv: fix memory leak when BO allocation fails

memory for resource"); > - return NULL; > + goto free_rsc; > } > > rsc->bo = bo; > @@ -223,6 +223,10 @@ etna_resource_alloc(struct pipe_screen *pscreen, > unsigned layout, > } > > return >base; > + > +free_rsc: > + FREE(rsc); >

Re: [Mesa-dev] [PATCH 03/11] renderonly/etnaviv: stop importing resource from renderonly

On Fri, 2017-06-23 at 17:50 +0200, Lucas Stach wrote: > The current way of importing the resource from renderonly after allocation > is opaque and is taking away control from the driver, which it needs in > order to implement more advanced scenarios, than the simple linear > scanout with matching

Re: [Mesa-dev] [PATCH 01/11] etnaviv: fill in layer_stride for imported resources

a BO which conforms to our padding size. > * The stride of the BO must be greater or equal to our padded Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/11] etnaviv: pad scanout buffer size to RS alignment

plat.width0, padX); > + scanout_templat.height0 = align(scanout_templat.height0, padY); > + > + rsc->scanout = renderonly_scanout_for_resource(_templat, > + screen->ro,

Re: [Mesa-dev] [PATCH 05/11] etnaviv: increment correct seqno for external resources

ct pipe_screen *pscreen, > struct pipe_resource *prsc) > { > struct etna_resource *res = etna_resource(prsc); > > - res->seqno++; > + if (res->external) > + etna_resource(res->external)->seqno++; > + else > + res->seqno+

Re: [Mesa-dev] [PATCH] etnaviv: only flush resource to self if no scanout buffer exists

, rsc)) { > + etna_copy_resource(pctx, rsc->scanout->prime, prsc, 0, 0); > + etna_resource(rsc->scanout->prime)->seqno = rsc->seqno; > + } > } else if (etna_resource_needs_flush(rsc)) { >etna_copy_resource(pctx, prsc, prsc, 0, 0);

[Mesa-dev] [RFC v2] etnaviv: flush color cache and depth cache together before resolves

hows through. Other attempts such as adding a pipeline stall before the color flush or a TS cache flush afterwards or flushing multiple times, with stalls before and after each flush, have shown no effect. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v1: - Add a

Re: [Mesa-dev] [PATCH v3 01/15] st/dri: refactor multi-planar YUV import path

On Tue, 2017-05-23 at 14:40 +0530, Varad Gautam wrote: > Hi Lucas, > > On Mon, May 22, 2017 at 11:16 PM, Lucas Stach wrote: > > Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam: > >> From: Varad Gautam > >> > >> we currently

[Mesa-dev] [RFC] etnaviv: flush color cache and depth cache together before resolves

hows through. Other attempts such as adding a pipeline stall before the color flush or a TS cache flush afterwards or flushing multiple times, with stalls before and after each flush, have shown no effect. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- src/gallium/drivers/etnaviv

  1   2   >