Re: [Mesa-dev] [PATCH 2/8] mesa: define and use ALL_TYPE_BITS in varray.c code

2014-08-08 Thread Roland Scheidegger
*ctx) { - GLbitfield legalTypesMask = ~0u; /* all */ + GLbitfield legalTypesMask = ALL_TYPE_BITS; if (_mesa_is_gles(ctx)) { legalTypesMask = ~(FIXED_GL_BIT | 1/8, 2/8 are Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

2014-08-08 Thread Roland Scheidegger
Am 08.08.2014 23:20, schrieb Brian Paul: Silences MinGW warnings: warning: unknown conversion type character ‘l’ in format [-Wformat] warning: too many arguments for format [-Wformat-extra-args] --- src/mesa/main/bufferobj.c | 33 + src/mesa/main/varray.c

Re: [Mesa-dev] [PATCH 6/8] mesa: whitespace, 80-column wrapping in program.c

2014-08-08 Thread Roland Scheidegger
, GLuint id) { if (prog) { init_program_struct(prog-Base, target, id); 5/8 and 6/8 are Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

2014-08-08 Thread Roland Scheidegger
Am 09.08.2014 02:24, schrieb Matt Turner: Other than that, is there some recommendation wrt whitespace around that ugly format specifier? Some places seem to use it, some don't. Either way it's ugly dunno which one is worse. Would be nice though if we'd be consistent imho. I've always seen

Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

2014-08-08 Thread Roland Scheidegger
did the copy because _mesa_drawbuffers will write the same ctx-Color.DrawBuffer bits that are passed in as buffers. Looks safe to me though so Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

2014-08-08 Thread Roland Scheidegger
Am 08.08.2014 23:20, schrieb Brian Paul: Fixes failed assertion when _mesa_update_draw_buffers() was called with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit this. Cc: 10.2 mesa-sta...@lists.freedesktop.org --- src/mesa/main/buffers.c |5 +++-- 1 file changed, 3

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Roland Scheidegger
On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily from glsl) which is really my only problem with it but it's not really all that important so Reviewed-by: Roland Scheidegger srol...@vmware.com Am

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Roland Scheidegger
Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily If you can briefly

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Roland Scheidegger
Am 09.08.2014 05:24, schrieb Connor Abbott: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like stuff to get existing things

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-11 Thread Roland Scheidegger
Am 09.08.2014 17:25, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 11:12 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't

Re: [Mesa-dev] [PATCH 3/8] mesa: use PRIu64 for printing 64-bit uints

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 15:29, schrieb Brian Paul: On 08/08/2014 06:15 PM, Roland Scheidegger wrote: Am 08.08.2014 23:20, schrieb Brian Paul: Silences MinGW warnings: warning: unknown conversion type character ‘l’ in format [-Wformat] warning: too many arguments for format [-Wformat-extra-args

Re: [Mesa-dev] [PATCH 1/2] mesa: use PRId64 for printing 64-bit ints

2014-08-11 Thread Roland Scheidegger
Both patches Reviewed-by: Roland Scheidegger srol...@vmware.com Am 11.08.2014 17:24, schrieb Brian Paul: Silences MinGW warnings: warning: unknown conversion type character ‘l’ in format [-Wformat] warning: too many arguments for format [-Wformat-extra-args] v2: use signed types/formats

Re: [Mesa-dev] [PATCH v2 1/4] gallium: add basic support for BPTC formats

2014-08-11 Thread Roland Scheidegger
, + PIPE_FORMAT_BPTC_RGBA_UNORM = 255, + PIPE_FORMAT_BPTC_SRGBA_UNORM= 256, + PIPE_FORMAT_BPTC_RGB_FLOAT = 257, + PIPE_FORMAT_BPTC_RGB_UFLOAT = 258, + PIPE_FORMAT_COUNT }; For the series: Reviewed-by: Roland Scheidegger srol...@vmware.com

Re: [Mesa-dev] [PATCH] mesa/st: emit sampler declarations as arrays when indirect accesses are done

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 17:18, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This applies on top of my previous patch to allow dynamic sampler offsets. Roland, I believe this should address your concerns. The generated code looks like: FRAG PROPERTY

Re: [Mesa-dev] [PATCH] mesa/st: emit sampler declarations as arrays when indirect accesses are done

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 18:56, schrieb Ilia Mirkin: On Mon, Aug 11, 2014 at 12:43 PM, Roland Scheidegger srol...@vmware.com wrote: Am 11.08.2014 17:18, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This applies on top of my previous patch to allow dynamic sampler offsets

Re: [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 00:51, schrieb Brian Paul: On 08/08/2014 07:43 PM, Roland Scheidegger wrote: Am 08.08.2014 23:20, schrieb Brian Paul: Fixes failed assertion when _mesa_update_draw_buffers() was called with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit this. Cc: 10.2 mesa-sta

Re: [Mesa-dev] [PATCH 5/5] docs: add GL4.5 section, mark ARB_texture_barrier as done

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 21:07, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Not 100% sure about the KHR_robust_buffer_access_behavior -- is that part of GL4.5? Well this is mostly the same as ARB_robust_buffer_access_behavior which is core in 4.3. Except

Re: [Mesa-dev] [PATCH 5/5] docs: add GL4.5 section, mark ARB_texture_barrier as done

2014-08-11 Thread Roland Scheidegger
Am 11.08.2014 22:56, schrieb Ilia Mirkin: On Mon, Aug 11, 2014 at 4:34 PM, Roland Scheidegger srol...@vmware.com wrote: Am 11.08.2014 21:07, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Not 100% sure about the KHR_robust_buffer_access_behavior -- is that part

Re: [Mesa-dev] [PATCH] i965: Store uniform constant values in a gl_constant_value instead of float

2014-08-12 Thread Roland Scheidegger
This looks good to me. However I'm wondering if it would be better to use a generic float/int union. I guess though these values actually really are gl_constant_value type (as they come as gl params) so this looks good. Roland Am 12.08.2014 20:04, schrieb Neil Roberts: Hi, Here is a

Re: [Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

2014-08-12 Thread Roland Scheidegger
Am 06.08.2014 11:28, schrieb Michel Dänzer: On 06.08.2014 03:08, Jason Ekstrand wrote: Module: Mesa Branch: master Commit: 850fb0d1dca616179d3239a7b7bd94fe1979604c URL:

Re: [Mesa-dev] [PATCH] mesa: fix texstore with GL_COLOR_INDEX data

2014-08-13 Thread Roland Scheidegger
. Roland Am 13.08.2014 19:35, schrieb Jason Ekstrand: Roland, I just sent the exact same patch. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com mailto:jason.ekstr...@intel.com On Wed, Aug 13, 2014 at 10:33 AM, srol...@vmware.com mailto:srol...@vmware.com wrote: From: Roland

Re: [Mesa-dev] [PATCH] mesa: fix texstore with GL_COLOR_INDEX data

2014-08-13 Thread Roland Scheidegger
:46, schrieb Roland Scheidegger: Ha one minute faster :-). FWIW interestingly this one also fixes the other conform failures I was seeing (with GL_BYTE/GL_RGB data) when unconditionally disabling texstore_swizzle so I guess the results of the swizzle path aren't quite identical to the fallback

Re: [Mesa-dev] [PATCH] mesa/texstore: Don't use the _mesa_swizzle_and_convert if we need transfer ops

2014-08-13 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com Not sure though why you moved the function, it's declared elsewhere anyway. (And I bet there's cases where transfer ops wouldn't actually be required which aren't caught by this check, like for instance RGB formats with only alpha pixel scale

Re: [Mesa-dev] [PATCH 3/5] gallium: add opcodes/cap for fine derivative support

2014-08-14 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com llvmpipe also already does the fine version. A coarse version (which we indeed do when used implicitly for sampling though with some other changes) might be minimally simpler though not even sure (might save a shuffle instruction somewhere

Re: [Mesa-dev] [PATCH 3/5] gallium: add opcodes/cap for fine derivative support

2014-08-14 Thread Roland Scheidegger
texture sampling for multiple quads at once this is something which needs to be handled in any case. I suspect hw being slower with different effective lods per pixel has similar reasons - there's just more work to be done. Roland On Thu, Aug 14, 2014 at 10:12 AM, Roland Scheidegger srol

Re: [Mesa-dev] [PATCH 16/19] gallium/nouveau: handle query_renderer caps

2014-08-14 Thread Roland Scheidegger
Am 15.08.2014 00:33, schrieb Ilia Mirkin: Hm, I wonder what GETPARAM_PCI_DEVICE returns for GK20A. Also, not 100% sure what UMA means, but GK20A (NVEA) would defnitely qualify. Not sure about the other IGP's that steal vram from the system. All IGPs end in 0xa-0xf though, so they're easy to

Re: [Mesa-dev] [RFC] gallium/st/drivers: Extend render_condition() Add a new boolean flag: inverted Adopt all places where we make use of this This will be used to implement ARB_conditional_render_inv

2014-08-14 Thread Roland Scheidegger
NAK. This is unnecessary, the condition parameter can already handle that (and was added for that purpose, though for d3d10 only at that time - 793e8e3d7ed816cc9a066245dde798afdcf8b581). Can't speak for other drivers, but llvmpipe/softpipe already handle it in any case. Otherwise, I'd still have

Re: [Mesa-dev] [PATCH 2/6] gallium/st: Add PIPE_CAP_CONDITIONAL_RENDER_INVERTED

2014-08-15 Thread Roland Scheidegger
Am 16.08.2014 01:59, schrieb Tobias Klausmann: with this we determine if the driver wants to enable GL_ARB_conditional_render_inverted Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/docs/source/screen.rst | 2 ++

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Roland Scheidegger
Am 16.08.2014 02:12, schrieb Connor Abbott: I know what you might be thinking right now. Wait, *another* IR? Don't we already have like 5 of those, not counting all the driver-specific ones? Isn't this stuff complicated enough already? Well, there are some pretty good reasons to start afresh

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 19:05, schrieb Connor Abbott: On Mon, Aug 18, 2014 at 12:38 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Aug 18, 2014 at 12:25 PM, Connor Abbott cwabbo...@gmail.com wrote: On Mon, Aug 18, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 18/08/14 14:21, Marek

Re: [Mesa-dev] [PATCH 5/6] rbug: fix a crash in sampler_view_destroy caused by incorrect context

2014-08-18 Thread Roland Scheidegger
reference counts) compared to surface_create / surface_destroy which sounds fishy but in any case 1/6, 4/6, 5/6 are Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:24, schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/rbug/rbug_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index

Re: [Mesa-dev] [PATCH 6/6] rbug: only add textures to the list

2014-08-18 Thread Roland Scheidegger
, rb_resource); pipe_resource_reference(rb_resource-resource, NULL); FREE(rb_resource); I wonder if there would be some value in trying to make them displayable? I guess though it would be pretty difficult without any means to figure out what kind of data it is. Reviewed-by: Roland

Re: [Mesa-dev] [PATCH 2/6] gallium/u_blitter: don't use an empty fragment shader if there's a colorbuffer

2014-08-18 Thread Roland Scheidegger
, ctx-velem_state); /* set a framebuffer state */ 1/6,2/6 are Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 1/6] mesa: add ARB_conditional_render_inverted flags

2014-08-18 Thread Roland Scheidegger
Series looks good to me too, just one minor nitpick below, otherwise 1-4, and 6 are Reviewed-by: Roland Scheidegger srol...@vmware.com Am 19.08.2014 00:06, schrieb Tobias Klausmann: Also add an extension bit so we can safely enable Signed-off-by: Tobias Klausmann tobias.johannes.klausm

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Roland Scheidegger
Am 19.08.2014 01:35, schrieb Marek Olšák: On Tue, Aug 19, 2014 at 1:10 AM, Roland Scheidegger srol...@vmware.com wrote: Am 18.08.2014 23:24, schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/rbug/rbug_context.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

2014-08-18 Thread Roland Scheidegger
Am 19.08.2014 01:43, schrieb Marek Olšák: On Tue, Aug 19, 2014 at 1:12 AM, Roland Scheidegger srol...@vmware.com wrote: Am 18.08.2014 23:24, schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/rbug/rbug_context.c | 46 + 1

Re: [Mesa-dev] [PATCH] mesa: fix NULL pointer deref bug in _mesa_drawbuffers()

2014-08-19 Thread Roland Scheidegger
-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] cant build mesa against current llvm(3.6 git)

2014-08-19 Thread Roland Scheidegger
Am 19.08.2014 23:29, schrieb Enrico Horn: Hi everyone, tried to build mesa just now with llvm from git and get the following error: gallivm/lp_bld_misc.cpp: In function 'LLVMBool lp_build_create_jit_compiler_for_module(LLVMOpaqueExecutionEngine**, lp_generated_code**, LLVMModuleRef,

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map arrays) to 2d arrays and vice versa (also 1d/2d to the respective array type), and we cannot express that in sampler views (yet) (we can't express it in

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
? On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger srol...@vmware.com wrote: Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map arrays) to 2d arrays and vice versa (also 1d/2d to the respective array

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
suggestions on how to fix it? Should the target be added to pipe_sampler_view? On Wed, Aug 20, 2014 at 11:25 AM, Roland Scheidegger srol...@vmware.com wrote: Didn't look at it that closely, but I'm pretty surprised this really works. One things ARB_texture_view can do is cast cube maps (and cube map

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:12, schrieb Jose Fonseca: On 20/08/14 17:02, Roland Scheidegger wrote: Am 20.08.2014 17:47, schrieb Jose Fonseca: On 20/08/14 16:31, Ilia Mirkin wrote: Hm, it's not tested. And you're right, that would (most likely) mess up, since it would only have the pipe_resource's target

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 20:13, schrieb Kenneth Graunke: On Wednesday, August 20, 2014 06:41:08 PM Michel Dänzer wrote: On 20.08.2014 00:04, Connor Abbott wrote: On Mon, Aug 18, 2014 at 8:52 PM, Michel Dänzer mic...@daenzer.net wrote: On 19.08.2014 01:28, Connor Abbott wrote: On Mon, Aug 18, 2014 at

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 20:45, schrieb Matt Turner: On Wed, Aug 20, 2014 at 11:28 AM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 20:13, schrieb Kenneth Graunke: For example, Debian was stuck on Mesa 9.2.2 for 4 months (2013-12-08 to 2014-03-22), and I was told this was because of LLVM

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 18:48, schrieb Roland Scheidegger: Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20/08/14 17:14, Roland Scheidegger wrote: Am 20.08.2014 17:55, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 11:47 AM, Jose

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add ARB_texture_view support

2014-08-20 Thread Roland Scheidegger
Am 20.08.2014 22:27, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 4:12 PM, Roland Scheidegger srol...@vmware.com wrote: Am 20.08.2014 18:48, schrieb Roland Scheidegger: Am 20.08.2014 18:33, schrieb Ilia Mirkin: On Wed, Aug 20, 2014 at 12:22 PM, Jose Fonseca jfons...@vmware.com wrote: On 20

Re: [Mesa-dev] [RFC] gallium: add support for rectangle primitives

2014-08-21 Thread Roland Scheidegger
Am 21.08.2014 18:44, schrieb Marek Olšák: From: Marek Olšák marek.ol...@amd.com This is already supported by r600g and radeonsi. Alex suggested this could be useful for video acceleration state trackers. --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 3 ++-

Re: [Mesa-dev] [PATCH v2 2/4] gallium: add a texture target to sampler view and a CAP to use it

2014-08-21 Thread Roland Scheidegger
*/ struct pipe_resource *texture; /** texture into which this is a view */ struct pipe_context *context; /** context this view belongs to */ It would be good though to get some other feedback, personally I think this solution is ok. 1/4, 2/4 are Reviewed-by: Roland Scheidegger srol

Re: [Mesa-dev] [PATCH v2 3/4] mesa/st: add ARB_texture_view support

2014-08-21 Thread Roland Scheidegger
Am 21.08.2014 04:42, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- v1 - v2: - make use of new PIPE_CAP to determine whether ARB_texture_view is available - set the gl_texture_object's Target in the sampler view object src/mesa/state_tracker/st_atom_texture.c

Re: [Mesa-dev] [PATCH v2 2/4] gallium: add a texture target to sampler view and a CAP to use it

2014-08-21 Thread Roland Scheidegger
Am 21.08.2014 19:39, schrieb Ilia Mirkin: On Thu, Aug 21, 2014 at 1:35 PM, Roland Scheidegger srol...@vmware.com wrote: Am 21.08.2014 04:42, schrieb Ilia Mirkin: This allows a sampler view to have a different texture target than the underlying resource. This will be used to implement

Re: [Mesa-dev] The GL3.txt format

2014-08-25 Thread Roland Scheidegger
Am 25.08.2014 07:56, schrieb Kenneth Graunke: On Monday, August 25, 2014 12:05:07 AM Romain Failliot wrote: Some folks helped me and a lot of detection bug have been fixed! I have a question though (for my own culture): what's with the swrast, the softpipe and the llvmpipe? Aren't they all

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: allocate and enlarge arrays for temporaries on demand

2014-08-25 Thread Roland Scheidegger
Am 24.08.2014 23:51, schrieb Marek Olšák: On Sun, Aug 24, 2014 at 6:15 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Sun, Aug 24, 2014 at 7:44 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This fixes crashes if the number of temporaries is greater than 4096.

Re: [Mesa-dev] The GL3.txt format

2014-08-25 Thread Roland Scheidegger
might have bug reports saying that softpipe is green but it's never mentioned in the original file) 2014-08-25 10:28 GMT-04:00 Roland Scheidegger srol...@vmware.com mailto:srol...@vmware.com: Am 25.08.2014 07 tel:25.08.2014%2007:56, schrieb Kenneth Graunke: On Monday, August 25

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: allocate and enlarge arrays for temporaries on demand

2014-08-25 Thread Roland Scheidegger
Am 26.08.2014 01:58, schrieb Ian Romanick: On 08/24/2014 02:51 PM, Marek Olšák wrote: On Sun, Aug 24, 2014 at 6:15 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Sun, Aug 24, 2014 at 7:44 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This fixes crashes if the

Re: [Mesa-dev] [PATCH V4 2/3] gallium: add cap for MAX_VERTEX_ATTRIB_STRIDE

2014-08-27 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com Though I think most drivers can probably support a lot more (everything draw based should be able to support virtually unlimited strides I believe, up to max_int32 probably though this doesn't make much sense, and I suspect that's true for all

Re: [Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-08-28 Thread Roland Scheidegger
cares about that anyway). Don't know though how that could be fixed. Roland Am 28.08.2014 04:28, schrieb Ian Romanick: Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 08/27/2014 06:00 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com mesa was creating a cube map

Re: [Mesa-dev] [PATCH] softpipe: handle vertex texture sampling when using llvm for draw

2014-08-28 Thread Roland Scheidegger
Ahh wrong patch sent again. This one is unchanged. Roland Am 28.08.2014 18:17, schrieb srol...@vmware.com: From: Roland Scheidegger srol...@vmware.com Pretty trivial, just fill in the offsets and such. The implementation is near 100% copy and paste from llvmpipe. Should be useful

Re: [Mesa-dev] [PATCH 1/3] gallivm: handle cube map arrays for texture sampling

2014-08-28 Thread Roland Scheidegger
Am 28.08.2014 18:19, schrieb Jose Fonseca: On 28/08/14 04:15, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Pretty easy, just make sure that all paths testing for PIPE_TEXTURE_CUBE also recognize PIPE_TEXTURE_CUBE_ARRAY, and add the layer * 6 calculation

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Roland Scheidegger
Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series covers a few state-tracker files missed out previously, picks up all the gallium tests,

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to properly implement TCS outputs in TGSI. As a quick reminder, there are per-vertex (i.e. invocation) and per-patch outputs in TCS. And while you can only write to the current invocation's per-vertex

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 17:55, schrieb Emil Velikov: On 01/09/14 16:31, Roland Scheidegger wrote: Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 18:19, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to properly implement TCS outputs in TGSI. As a quick reminder, there are per-vertex

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 18:53, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:47 PM, Roland Scheidegger srol...@vmware.com wrote: Am 01.09.2014 18:19, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN = r216982

2014-09-03 Thread Roland Scheidegger
Oh, interesting. The patch though is Reviewed-by: Roland Scheidegger srol...@vmware.com Am 03.09.2014 04:36, schrieb Michel Dänzer: From: Michel Dänzer michel.daen...@amd.com Only MCJIT is available anymore. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/auxiliary

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float.

2014-09-08 Thread Roland Scheidegger
Am 06.09.2014 19:17, schrieb Mathias Froehlich: Hi, Please review: Add support for the unclamped versions of glDepthRange and relatives. Also starting with OpenGL 4.2 the traditional functions for this should no longer clamp the values to [0, 1]. This looks wrong to me (the

Re: [Mesa-dev] [PATCH v3 2/3] mesa/st: add ARB_texture_view support

2014-09-09 Thread Roland Scheidegger
Looks good to me if there's no piglit regressions. Reviewed-by: Roland Scheidegger srol...@vmware.com Am 09.09.2014 02:59, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Roland, it was unclear to me whether you were happy with this change or not. v2 - v3

Re: [Mesa-dev] [PATCH] mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC

2014-09-10 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com Am 10.09.2014 16:21, schrieb Brian Paul: MSVC replaces the F in 255.0F with the macro argument which leads to an error. s/F/FLT/ to avoid that. It turns out we weren't using this macro at all on MSVC until the recent mesa: Drop USE_IEEE

Re: [Mesa-dev] [PATCH] llvmpipe: fix PIPE_FORMAT_Z24_UNORM_S8_UINT depth on big endian

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 12:22, schrieb Dave Airlie: We had a bug report from some screensavers in xscreensaver package not working on ppc64be, I took a day out to cause myself undue pain. I tracked it down to the depth buffer not being read correctly, I've no idea if this is the proper fix for it, I

Re: [Mesa-dev] [PATCH] llvmpipe: fix rast debugging output

2014-09-15 Thread Roland Scheidegger
, + triangle_32_3_16, + triangle_32_4_16, }; static const char *cmd_name(unsigned cmd) Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] gallium: introduce PIPE_CAP_UNCLAMPED_DEPTH_VALUES.

2014-09-15 Thread Roland Scheidegger
, }; #define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 0) Reviewed-by: Roland Scheidegger srol...@vmware.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-15 Thread Roland Scheidegger
Am 14.09.2014 16:07, schrieb mathias.froehl...@gmx.net: From: Mathias Fröhlich mathias.froehl...@gmx.net Will be used in the implementation of NV_depth_buffer_float. Signed-off-by: Mathias Froehlich mathias.froehl...@web.de --- src/mesa/main/glformats.c | 18 ++

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 16:41, schrieb Roland Scheidegger: Am 14.09.2014 16:07, schrieb mathias.froehl...@gmx.net: From: Mathias Fröhlich mathias.froehl...@gmx.net Will be used in the implementation of NV_depth_buffer_float. Signed-off-by: Mathias Froehlich mathias.froehl...@web.de --- src/mesa

Re: [Mesa-dev] [PATCH 4/4] mesa: Add support for NV_depth_buffer_float.

2014-09-15 Thread Roland Scheidegger
Am 14.09.2014 16:07, schrieb mathias.froehl...@gmx.net: From: Mathias Fröhlich mathias.froehl...@gmx.net This is mostly support for the unclamped versions of glDepthRangedNV, glClearDepthdNV and glDepthBoundsdNV. Note that OpenGL 4.2 introduced that the traditonal glDepthRange functions may

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 16:57, schrieb Roland Scheidegger: Am 15.09.2014 16:41, schrieb Roland Scheidegger: Am 14.09.2014 16:07, schrieb mathias.froehl...@gmx.net: From: Mathias Fröhlich mathias.froehl...@gmx.net Will be used in the implementation of NV_depth_buffer_float. Signed-off-by: Mathias

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 18:28, schrieb Mathias Fröhlich: Hi Roland, On Monday, September 15, 2014 16:57:49 Roland Scheidegger wrote: Hmm actually that wasn't right, it does make a difference if the nv or core format enums are used, at least for texture specification (nv won't clamp, whereas core

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 19:04, schrieb Mathias Fröhlich: Hi again, On Monday, September 15, 2014 18:11:51 Roland Scheidegger wrote: btw I'm not entirely sure everything is really correct with llvmpipe wrt that extension (the rasterization stuff, gallium isn't involved in the texture conversion

Re: [Mesa-dev] [PATCH 4/5] gallivm: add texture target information for sample opcodes to tgsi info

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 21:00, schrieb Ilia Mirkin: On Mon, Sep 15, 2014 at 2:51 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com sample opcodes don't have valid texture target information (and I don't think this should be changed), however it would be nice if we had

Re: [Mesa-dev] [PATCH] llvmpipe: fix PIPE_FORMAT_Z24_UNORM_S8_UINT depth on big endian

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 22:48, schrieb Dave Airlie: I never really looked at the big endian stuff so I have no idea if this is right. I thought though the channel shift thing now should work without endianness awareness if you fetch one 32bit number and then break it up into parts with shifts due to

Re: [Mesa-dev] [RFC PATCH] mesa: Delete VAO _MaxElement code and index buffer bounds checking.

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 08:31, schrieb Kenneth Graunke: Fredrik's implementation of ARB_vertex_attrib_binding introduced new gl_vertex_attrib_array and gl_vertex_buffer_binding structures, and converted Mesa's older gl_client_array to be derived state. Ultimately, we'd like to drop gl_client_array and

Re: [Mesa-dev] [PATCH 4/5] gallivm: add texture target information for sample opcodes to tgsi info

2014-09-15 Thread Roland Scheidegger
Am 15.09.2014 21:28, schrieb Roland Scheidegger: Am 15.09.2014 21:00, schrieb Ilia Mirkin: On Mon, Sep 15, 2014 at 2:51 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com sample opcodes don't have valid texture target information (and I don't think this should

Re: [Mesa-dev] [RFC PATCH] mesa: Delete VAO _MaxElement code and index buffer bounds checking.

2014-09-16 Thread Roland Scheidegger
Am 16.09.2014 17:48, schrieb Brian Paul: On 09/15/2014 06:00 PM, Roland Scheidegger wrote: Am 15.09.2014 08:31, schrieb Kenneth Graunke: Fredrik's implementation of ARB_vertex_attrib_binding introduced new gl_vertex_attrib_array and gl_vertex_buffer_binding structures, and converted Mesa's

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-16 Thread Roland Scheidegger
Am 16.09.2014 18:41, schrieb Ilia Mirkin: On Tue, Sep 16, 2014 at 12:29 PM, Marek Olšák mar...@gmail.com wrote: On Tue, Sep 16, 2014 at 5:42 PM, Ilia Mirkin imir...@alum.mit.edu wrote: OK, so just to summarize: The approach suggested by Roland is to have the outputs be one-dimensional and

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-16 Thread Roland Scheidegger
Am 16.09.2014 19:40, schrieb Marek Olšák: On Tue, Sep 16, 2014 at 7:31 PM, Roland Scheidegger srol...@vmware.com wrote: Am 16.09.2014 18:41, schrieb Ilia Mirkin: On Tue, Sep 16, 2014 at 12:29 PM, Marek Olšák mar...@gmail.com wrote: On Tue, Sep 16, 2014 at 5:42 PM, Ilia Mirkin imir

Re: [Mesa-dev] [PATCH 07/11] util: Define PIPE_FORMAT_xyzw8888_{SNORM, SRGB} aliases

2014-09-16 Thread Roland Scheidegger
Am 16.09.2014 08:28, schrieb Dave Airlie: From: Richard Sandiford rsand...@linux.vnet.ibm.com ...i.e. formats in which the first listed component is in the least significant byte of the integer. The corresponding UNORM aliases already exist. Signed-off-by: Richard Sandiford

Re: [Mesa-dev] Mesa 10.3 release plan

2014-09-17 Thread Roland Scheidegger
Am 17.09.2014 02:13, schrieb Emil Velikov: On 12/09/14 10:10, Emil Velikov wrote: On 11/09/14 23:21, Ian Romanick wrote: On 09/10/2014 05:45 AM, Emil Velikov wrote: Hello all, The original plan from Ian was to have four release candidates prior to the final release. From what I can see

[Mesa-dev] ARB_fragment_layer_viewport in gallium

2014-09-17 Thread Roland Scheidegger
ARB_fragment_layer_viewport is enabled unconditionally if geometry shaders / multiple viewports are also enabled. This seems reasonable, though I noticed at least it won't work for llvmpipe - entirely due to the requirement of the viewport/layer value being zero if it wasn't output by the gs (or

Re: [Mesa-dev] ARB_fragment_layer_viewport in gallium

2014-09-17 Thread Roland Scheidegger
Am 18.09.2014 00:28, schrieb Roland Scheidegger: ARB_fragment_layer_viewport is enabled unconditionally if geometry shaders / multiple viewports are also enabled. This seems reasonable, though I noticed at least it won't work for llvmpipe - entirely due to the requirement of the viewport/layer

Re: [Mesa-dev] ARB_fragment_layer_viewport in gallium

2014-09-17 Thread Roland Scheidegger
Am 18.09.2014 00:37, schrieb Ilia Mirkin: On Wed, Sep 17, 2014 at 6:28 PM, Roland Scheidegger srol...@vmware.com wrote: ARB_fragment_layer_viewport is enabled unconditionally if geometry shaders / multiple viewports are also enabled. This seems reasonable, I avoided adding a cap when

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-17 Thread Roland Scheidegger
Am 17.09.2014 09:21, schrieb Mathias Fröhlich: Good Morning, On Monday, September 15, 2014 20:33:17 Roland Scheidegger wrote: I don't really know what to do though. It looks like the implementation doesn't really do what the nv spec claims anyway, so it's difficult to even figure out what

Re: [Mesa-dev] [PATCH 2/4] mesa: Add helper function to see if we have a float depth format.

2014-09-22 Thread Roland Scheidegger
Am 21.09.2014 16:40, schrieb Mathias Fröhlich: Hi, On Thursday, September 18, 2014 03:56:11 Roland Scheidegger wrote: I agree it is something which would be nice to have in mesa, however I'm not really a big proponent of implementing some half-baked bogus mess extension, which is further

Re: [Mesa-dev] [PATCH 2/3] gallium: replace pipe_type enum with tgsi_type enum

2014-09-22 Thread Roland Scheidegger
The series looks good to me, though could rename the (quite underused) pipe_type enum to tgsi_return_type instead and leave tgsi_type alone? Or for further clarity, rename both (to tgsi_opcode_type and tgsi_ret_type or something). Either way though looks ok to me. (That said, I don't understand

Re: [Mesa-dev] [PATCH] gallium: replace pipe_type enum with tgsi_return_type enum

2014-09-22 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger srol...@vmware.com Roland Am 22.09.2014 21:36, schrieb Brian Paul: The only place the enum pipe_type was used is for the TGSI sampler view return type. So make it a TGSI type. Note: it appears this part of TGSI isn't used by anyone so it may be removed

Re: [Mesa-dev] [PATCH] gallivm: fix idiv

2014-09-23 Thread Roland Scheidegger
To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger; 10.2 10.3 Subject: [PATCH] gallivm: fix idiv From: Roland Scheidegger srol...@vmware.com ffeb77c7b0552a8624e46e65d6347240ac5ae84d had a typo which turned all signed integer divisions into unsigned ones. Oops. This gets us

Re: [Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-23 Thread Roland Scheidegger
This change seems to cause compile failure with scons: Compiling src/util/register_allocate.c ... src/util/register_allocate.c:76:26: fatal error: main/imports.h: No such file or directory #include main/imports.h Looks like it could be fixed by patching up the CPPPATH in the SConscript file

Re: [Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-23 Thread Roland Scheidegger
. -Brian On 09/23/2014 04:26 PM, Roland Scheidegger wrote: This change seems to cause compile failure with scons: Compiling src/util/register_allocate.c ... src/util/register_allocate.c:76:26: fatal error: main/imports.h: No such file or directory #include main/imports.h Looks like

Re: [Mesa-dev] [PATCH] mesa: Move register_allocate.c to util.

2014-09-23 Thread Roland Scheidegger
Oh yes and missing ALIGN + MAX2 too. I guess we could easily move these to util code. That plus the things I already mentioned should be all needed I think. But I strongly believe either this needs to be done or we should revert it. Roland Am 24.09.2014 00:44, schrieb Roland Scheidegger

Re: [Mesa-dev] [PATCH] mesa/st: NumLayers is only valid for array textures

2014-09-24 Thread Roland Scheidegger
Yes cubemaps should have array_size == 6 always in gallium. You just have to be careful whenever translating things from mesa to gallium as things like that won't be true in core mesa of course (similar to 1d array textures having height and so on) due to OpenGL weirdness for historical reasons.

Re: [Mesa-dev] [PATCH] mesa/st: NumLayers is only valid for array textures

2014-09-24 Thread Roland Scheidegger
this out tonight, pending a full piglit run. On Wed, Sep 24, 2014 at 1:35 PM, Roland Scheidegger srol...@vmware.com wrote: Yes cubemaps should have array_size == 6 always in gallium. You just have to be careful whenever translating things from mesa to gallium as things like that won't be true

<    3   4   5   6   7   8   9   10   11   12   >