Re: [Mesa-dev] [libdrm 4/4] etnaviv: support performance monitor requests

On Fri, Jun 09, 2017 at 12:27:37PM +0200, Christian Gmeiner wrote: > Add etna_cmd_stream_perf(..) to submit perform requests. > Userspace can submit pmrs via submit ioctl to sample perfmon > signals. Comment in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [libdrm 3/4] etnaviv: add permon support

On Fri, Jun 09, 2017 at 12:27:36PM +0200, Christian Gmeiner wrote: > Query all domains and their signals and provide it this information > via struct etna_perfmon and the corresponding api functions. Comments in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [libdrm 2/4] etnaviv: sync uapi header

monitor domains and their signals. Looks straightforward. Cannot find the associated kernel patch, so I could not check if the interface matches. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> &g

Re: [Mesa-dev] glmark2 segfault on imx6

Hello Fabio, Can you get a traceback using gdb? That'd be very useful to find out where in the driver this crash happens. Regards, Wladimir On Tue, Jun 13, 2017 at 04:20:23PM -0300, Fabio Estevam wrote: > Hi, > > I am running kernel 4.11.4 with Etnaviv 17.1.2 on a imx6qsabresd board > and

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

he coherent which you mention), so Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Am Freitag, den 19.05.2017, 11:41 +0200 schrieb Lucas Stach: > > Stolen from VC4. As we don't do any fancy reallocation tricks yet, it's > > possible to upgrade also coher

Re: [Mesa-dev] [PATCH 5/6] etnaviv: simplify transfer tiling handling

ood to me. Resource layout is explicit, and not dependent on the compressed-ness of the texture format. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 70 > +++

Re: [Mesa-dev] [PATCH 4/6] etnaviv: don't read back resource if transfer discards contents

rce don't matter if DISCARD_WHOLE_RESOURCE. Reviewed-By: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --

Re: [Mesa-dev] [PATCH 3/6] etnaviv: honor PIPE_TRANSFER_UNSYNCHRONIZED flag

there exists a temporary resource, as those ones are > never busy. OK. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 22 ++ >

Re: [Mesa-dev] [PATCH 2/6] etnaviv: slim down resource waiting

On Fri, May 19, 2017 at 11:41:08AM +0200, Lucas Stach wrote: > cpu_prep() already does all the required waiting, so the only thing that > needs to be done is flushing the commandstream, if a GPU write is pending. Looks good to me. Reviewed-By: Wladimir J. van der Laan <laa...@

Re: [Mesa-dev] [PATCH 1/2] etnaviv: don't flush resource to self without TS

<d...@lynxeye.de> Does this take into account the case on GC2000, where there can be a texture resource that is out of date with the rendered-to resource? If so: Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.h |

Re: [Mesa-dev] [PATCH 1/6] etnaviv: always do cpu_fini in transfer_unmap

o do > so at a later point in time. If there is a temporary resource the fini needs > to happen before the RS uses this one as the source for the upload. > > Also remove an invalid comment about flushing CPU caches, cpu_fini takes > care of everything involved in this. Reviewed-By:

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

> Thx - will send out updated patches the next days. I quite busy with > lot of stuff atm but > a long weekend is coming :) Yeah np I could update my patches to that too and re-send them if that is more convenient, Wladimir ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

On Tue, May 16, 2017 at 09:31:38PM +0200, Christian Gmeiner wrote: > Hi Wladimir. > > I started working on this topic last week and thought some time on how > to add those ext texture formats in a clean and nice way. I come up > with this patches: > >

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Check extended format availability on GPU

Hello Philipp, On Tue, May 16, 2017 at 04:33:34PM +0200, Philipp Zabel wrote: > Hi Wladimir, > > On Tue, 2017-05-16 at 10:42 +0200, Wladimir J. van der Laan wrote: > > Current information shows that both extended texture/render formats > > and texture swizzling were intro

[Mesa-dev] [PATCH 4/3] etnaviv: Add support for ETC2 texture compression

Add support for ETC2 compressed textures in the etnaviv driver. These are available on GC2000+. One step closer towards GL ES 3 support. --- src/gallium/drivers/etnaviv/etnaviv_format.c | 11 +++ 1 file changed, 11 insertions(+) Mesa does not export the ETC2 formats without OpenGL ES 3,

[Mesa-dev] [PATCH 3/3] etnaviv: Check extended format availability on GPU

Current information shows that both extended texture/render formats and texture swizzling were introduced with the HALTI0 feature bit, available on GC2000/GC3000. --- src/gallium/drivers/etnaviv/etnaviv_format.c | 12 src/gallium/drivers/etnaviv/etnaviv_format.h | 3 +++

[Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

This adds support for extended texture formats through TEXTURE_FORMAT_EXT. Two of these extended formats are added: - R8_SNORM - R8G8_UNORM --- src/gallium/drivers/etnaviv/etnaviv_format.c | 49 ++- src/gallium/drivers/etnaviv/etnaviv_format.h | 3 ++

[Mesa-dev] [PATCH 2/3] etnaviv: Add support for swizzled texture formats

--- src/gallium/drivers/etnaviv/etnaviv_format.c | 50 +-- src/gallium/drivers/etnaviv/etnaviv_format.h | 3 ++ src/gallium/drivers/etnaviv/etnaviv_texture.c | 15 +--- 3 files changed, 54 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/5] etnaviv: increment the resource seqno in resource_changed

Seems more straightforward, but I don't know the rationale why it was done the way it was. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote: > From: Philipp Zabel <p.za...@pengutronix.de> > > Just increme

Re: [Mesa-dev] [PATCH 3/5] etnaviv: apply feature overrides in one central location

Yes, good idea to do this in one place. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:06PM +0200, Lucas Stach wrote: > This way we can just test the feature bits and don't need to spread > the debug overrides to all locations touchi

Re: [Mesa-dev] [PATCH 1/5] etnaviv: stop oversizing buffer resources

Good catch! Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:04PM +0200, Lucas Stach wrote: > PIPE_BUFFER is a target enum, not a binding. This caused the driver to > up-align the height of buffer resources, leading to largely oversizing >

[Mesa-dev] [PATCH] etnaviv: Supertiled texture support on gc3000

this is just a matter of allowing it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 9 +++-- src/gallium/drivers/etnaviv/etnaviv_texture.c | 10 -- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] etnaviv: When to use supertiled layout?

Hello, Currently etnaviv chooses supertiled layout always for new resources that can be rendered to, when this is available: bool want_supertiled = screen->specs.can_supertile && !DBG_ENABLED(ETNA_DBG_NO_SUPERTILE); However, etnaviv does not support render *from* supertiled textures

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

On Sat, Apr 15, 2017 at 07:49:53AM +0200, Wladimir J. van der Laan wrote: > On Fri, Apr 14, 2017 at 11:57:21PM +0200, Christian Gmeiner wrote: > > > +#define INST_OPCODE_IMADLOSAT0 0x004e > > > +#define I

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

On Fri, Apr 14, 2017 at 11:57:21PM +0200, Christian Gmeiner wrote: > > +#define INST_OPCODE_IMADLOSAT0 0x004e > > +#define INST_OPCODE_IMADLOSAT0 0x004f > > INST_OPCODE_IMADLOSAT0 got redefined... Second one should be

[Mesa-dev] [PATCH v2 3/3] etnaviv: SINGLE_BUFFER support on GC3000

. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 3 ++ src/gallium/drivers/etnaviv/etnaviv_emit.c | 6 ++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 3 ++ src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 +

[Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

Update to etna_viv commit 411bd69. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common.xml.h| 10 ++-- src/gallium/drivers/etnaviv/hw/isa.xml.h | 75 +

[Mesa-dev] [PATCH v2 1/3] etnaviv: Add chipMinorFeatures4 and 5

Request chipMinorFeatures bitfields 4 and 5 from the drm driver. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 de

[Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

This patch adds support for the SINGLE_BUFFER feature on GC3000 GPUs, which allows rendering to a single buffer using multiple pixel pipes. This feature is always used when it is available, which means that multi-tiled formats are no longer being used in that case, and all buffers will be normal

[Mesa-dev] [PATCH 2/3] etnaviv: Update includes from rnndb

) - copyright.xml ( 1597 bytes, from 2016-10-29 07:29:22) -- common.xml( 23473 bytes, from 2016-12-11 10:32:13) +- common.xml( 23473 bytes, from 2017-01-07 14:27:54) Copyright (C) 2012-2016 by the following authors: - Wladimir J. van der Laan <laa...@gmail.com> diff --git

[Mesa-dev] [PATCH 1/3] etnaviv: Add chipMinorFeatures4 and 5

Request chipMinorFeatures bitfields 4 and 5 from the drm driver. --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) Adds two further chipminorfeatures words -

Re: [Mesa-dev] [PATCH v2] etnaviv: native fence fd support

za...@pengutronix.de> Patch looks good to me, Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: address review comments > - always call etna_cmd_stream_flush2 > - remove FIXME comment about in_fence_fd storage > - simplify version check and add an ETNA_DRM

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 06:39:32PM +0100, Christian Gmeiner wrote: > > By only reverting: > > > > commit 6c89a728d9e5d072cb504453e73077564c6523d3 > > Author: Wladimir J. van der Laan <laa...@gmail.com> > > Date: Wed Dec 7 12:59:54 2016 + > > &g

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

> Okay.. I will add the id member in a later patch to etna_shader > object. For the moment > I will pass it as an argument to dump_shader_info(..). Will send a V2 > of that series later the day. To be honest I think it's nonsense to change this now, if you need an id in the shader object then add

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

> > >> /* shader object, for linking */ > > >> struct etna_shader { > > >> + uint32_t id; /* for debug */ > > > > > > Do you need this? It can certainly be removed from this patch, but I > > > don't know if you have other stuff building on top of this. > > > > > > > It gets used in

[Mesa-dev] [PATCH 2/2] etnaviv: Set shader instruction area correctly for GC3000

- Use the same instruction area on GC3000 as the Vivante driver. This allows the same number of instructions on GC3000 as GC2000 instead of half. - Makes sure that the "PE to FE" stall before updating the shader code or constants is hit (which is conditional on vs_offset > 0x4000). This

[Mesa-dev] [PATCH 1/2] etnaviv: Update hw header files

) +- common.xml( 23473 bytes, from 2016-12-11 10:32:13) Copyright (C) 2012-2016 by the following authors: - Wladimir J. van der Laan <laa...@gmail.com> diff --git a/src/gallium/drivers/etnaviv/hw/common.xml.h b/src/gallium/drivers/etnaviv/hw/common.xml.h index 8d8ef7d..0f99db2 100644 ---

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

On Wed, Feb 08, 2017 at 12:10:25PM +0100, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freede

Re: [Mesa-dev] [PATCH 2/3] etnaviv: keep track of emitted loops

On Wed, Feb 08, 2017 at 12:10:24PM +0100, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Sure why not. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 6 ++ &

Re: [Mesa-dev] Question about handling RGBA/BGRA in etnaviv driver

> > Another way that I just realized would be to convert a texture to BGRA the > > first time it's rendered to. > > > > In contrast to the shader solution that has only a one-time overhead. Is > > this a stupid idea for any reason? > We are doing something similar to convert sampled textures to

<    1   2   3