[Mesa-dev] [PATCH 2/3] remove main page tags from source files

--- src/gbm/main/gbm.h | 10 +- src/mapi/glapi/glapi.h | 17 + src/mesa/main/context.c | 45 - src/mesa/program/program.h | 8 +--- src/mesa/swrast/s_context.h | 10 +- src/mesa/tnl/t_context.h

[Mesa-dev] [PATCH 3/3] doxy-text files added

--- doxygen/all.doxy | 1 + src/gbm/gbm.doxy_text| 15 ++ src/mesa/drivers/dri/i965/i965.doxy_text | 176 + src/mesa/main/main.doxy_text | 257 +++ src/mesa/program/program.doxy_text |

[Mesa-dev] [PATCH 2/3] remove main page tags from source files

--- src/gbm/main/gbm.h | 10 +- src/mapi/glapi/glapi.h | 17 + src/mesa/main/context.c | 45 - src/mesa/program/program.h | 8 +--- src/mesa/swrast/s_context.h | 10 +- src/mesa/tnl/t_context.h

[Mesa-dev] [PATCH 3/3] doxy-text files added

--- doxygen/all.doxy | 1 + src/gbm/gbm.doxy_text| 15 ++ src/mesa/drivers/dri/i965/i965.doxy_text | 176 + src/mesa/main/main.doxy_text | 257 +++ src/mesa/program/program.doxy_text |

[Mesa-dev] [PATCH] nicer-no-wrap-patch

This patch adds a function interface for enabling no wrap on batch commands, adds to it assert enforcement that the number bytes added to the batch buffer does not exceed a passed value and finally this is used in brw_try_draw_prims() to help make sure that estimated_max_prim_size is a good value.

[Mesa-dev] [PATCH] nicer-no-wrap-patch

feedback integrated space-pace --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 + src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++ 4 files

[Mesa-dev] [PATCH] nicer-no-wrap-patch

Track bytes written during no flush phases for debug builds --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 +

[Mesa-dev] [PATCH] nicer-no-wrap-patch

feedback integrated space-pace --- src/mesa/drivers/dri/i965/brw_context.h | 85 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +- src/mesa/drivers/dri/i965/brw_state_batch.c | 15 + src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++ 4 files

[Mesa-dev] [PATCH 1/2] Allow for GLSL shaders to have #extension directive anywhere in source file.

Allow for GLSL shaders to have #extension directive anywhere in source file; during preprocessor, #extension directives are saved to a list rather than being added to the pre-processed string. That list is played back before parsing of pre-processed text takes place. ---

[Mesa-dev] [PATCH 2/2] add MESA_GLSL option to require that #extension directives come before any variable or function declarations, etc

Add an additional bit flag, GLSL_EXTENSION_STRICT for gl_context#Shader#Flags to require that #extension directives must come before variable of function declarations. The flag is set to on if MESA_GLSL has the option extension_strict_ordering in it. --- src/glsl/glsl_parser_extras.cpp | 6

[Mesa-dev] [PATCH 1/2] Allow for GLSL shaders to have #extension directive anywhere in source file. (reworked)

Allow for GLSL shaders to have #extension directive anywhere in source file; during preprocessor, #extension directives are saved to a list rather than being added to the pre-processed string. That list is played back before parsing of pre-processed text takes place. ---

[Mesa-dev] [PATCH 2/2] add MESA_GLSL option to require that #extension directives come before any variable or function declarations, etc (reworked)

Add an additional bit flag, GLSL_EXTENSION_STRICT for gl_context#Shader#Flags to require that #extension directives must come before variable or function declarations. The flag is set to on if MESA_GLSL has the option extension_strict_ordering in it. --- src/glsl/glsl_parser_extras.cpp | 7

[Mesa-dev] [PATCH] Fix line number on no matching function call

This (very tiny) patch fixes the bug (#72264) where when no matching function call was found the error message gave the line and column number as 0. --- src/glsl/ast_function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_function.cpp

[Mesa-dev] [PATCH] Use line number information from entire function expression

This patch changes the error reporting behavior for incorrect function invocation (triggered by match_function_by_name() unable to find a matching function call) from using the line number information associated to the function name term to using the line number information of the entire function

[Mesa-dev] [PATCH] Report that no function found if signature lookup is empty

Enhancement: if no function signature is found for a function name, report that the function is not found instead of printing an empty list of candidates. --- src/glsl/ast_function.cpp | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH] Correct test for depth parameter for checking if dimension is legal

Fixes the tests for the depth parameter for TexImage3D calls when the target type is GL_TEXTURE_2D_ARRAY or GL_TEXTURE_CUBE_MAP_ARRAY so that a depth value of 0 is accepted. Previously, the check incorrectly required the depth argument to be atleast 1. --- src/mesa/main/teximage.c | 4 ++-- 1

[Mesa-dev] [PATCH] Allow sampler arrays to have precision qualifier

Fixes a minor oversight where a precision qualifier was not allowed for an array of samplers. --- src/glsl/ast_to_hir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 1bfb4e5..08fd0d3 100644 ---

[Mesa-dev] [PATCH] centroid affects interpolation

Place centroid keyword as an interpolation qualifier. Previously was a storage qualifier. Fixes front end to accept input of the form centroid in type variable --- src/glsl/glsl_parser.yy | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_parser.yy

[Mesa-dev] [PATCH] meta_blitframebuffer integer format corrections

Corrects the format for the temp texture used in for the case where source framebuffer is an integer texture when blitframebuffer_texture() cannot be used. Note: Does NOT correct the underling blits, rather only corrects the format of the temporary texture to be an integer format. ---

[Mesa-dev] [PATCH] Channels alive in fast clear

When deciding if a clear color is suitable for fast clear, take into account if a color channel is active in the buffer format. --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp

[Mesa-dev] [PATCH] GL_OES_texture_float and GL_OES_texture_half_float support

Add support for GLES2 extentions for floating point and half floating point textures (GL_OES_texture_float, GL_OES_texture_half_float, GL_OES_texture_float_linear and GL_OES_texture_half_float_linear). --- src/mesa/main/extensions.c | 12 + src/mesa/main/glformats.c | 27

[Mesa-dev] [PATCH] mesa: Expose GL_OES_texture_float and GL_OES_texture_half_float.

Add support for GLES2 extensions for floating point and half floating point textures (GL_OES_texture_float, GL_OES_texture_half_float, GL_OES_texture_float_linear and GL_OES_texture_half_float_linear). --- src/mesa/main/extensions.c | 12 +- src/mesa/main/glformats.c | 25

[Mesa-dev] [PATCH] define GL_OES_standard_derivatives if extension is supported

From: Kevin Rogovin kevin.rogo...@intel.com Define the macro GL_OES_standard_derivatives as 1 if the extension GL_OES_standard_derivatives is supported. --- src/glsl/glcpp/glcpp-parse.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp

[Mesa-dev] [PATCH 1/7] Define extension ARB_framebuffer_no_attachments and additions to gl_framebuffer for extension ARB_framebuffer_no_attachments

From: Kevin Rogovin kevin.rogo...@intel.com Add extension flag and constant values for ARB_framebuffer_no_attachments. --- src/mesa/main/extensions.c | 1 + src/mesa/main/fbobject.c| 1 + src/mesa/main/framebuffer.c | 1 + src/mesa/main/mtypes.h | 52

[Mesa-dev] [PATCH 6/7] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

From: Kevin Rogovin kevin.rogo...@intel.com Ensure that the GPU spawns the fragment shader thread for those fragment shaders with atomic buffer access. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++ src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 2 files changed, 11 insertions

[Mesa-dev] [PATCH 2/7] Define constants and functions for ARB_framebuffer_no_attachment extension

From: Kevin Rogovin kevin.rogo...@intel.com Define enumerations, functions and associated glGet's for extension ARB_framebuffer_no_attachment. --- .../glapi/gen/ARB_framebuffer_no_attachments.xml | 33 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi

[Mesa-dev] [PATCH] i965: Fix intel_miptree_copy_teximage for GL_TEXTURE_1D_ARRAY

From: Noone no...@mailinator.com For GL_TEXTURE_1D_ARRAY targets we store the depth of the array in the Height field and leave Depth=1 in the underlying texture object. When we call intel_miptree_copy_teximage in the process of re-creating a miptree (possibily because the number of miplevels has

[Mesa-dev] [PATCH] i965: Fix intel_miptree_copy_teximage for GL_TEXTURE_1D_ARRAY

From: Noone no...@mailinator.com For GL_TEXTURE_1D_ARRAY targets we store the depth of the array in the Height field and leave Depth=1 in the underlying texture object. When we call intel_miptree_copy_teximage in the process of re-creating a miptree (possibily because the number of miplevels has

[Mesa-dev] [PATCH 4/7] helper-conveniance functions for drivers to implement ARB_framebuffer_no_attachment

From: Kevin Rogovin kevin.rogo...@intel.com To assist drivers to implement ARB_framebuffer_no_attachment, provide a set of convenience functions that check for gl_framebuffer::_HasAttachments that return the geometry of the gl_framebuffer. --- src/mesa/main/framebuffer.c | 49

[Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

From: Kevin Rogovin kevin.rogo...@intel.com To prepare for i965 to support ARB_framebuffer_no_attachment, use the convenience functions mesa_geometry_width/height/layers/samples to specify the geometry of the render target surfaces to the GPU. --- src/mesa/drivers/dri/i965/brw_clip_state.c

[Mesa-dev] [PATCH 3/7] Complete implementation for ARB_framebuffer_no_attachment in Mesa core: implement GetFramebufferParameteriv, FramebufferParameteri and changes to _mesa_test_framebuffer_complete

From: Kevin Rogovin kevin.rogo...@intel.com Complete the implementation of ARB_framebuffer_no_attachment in Mesa core: 1. Implement _mesa_GetFramebufferParameteriv() and _mesa_FramebufferParameteri() 2. Additions to _mesa_test_framebuffer_completeness() --- src/mesa/main/fbobject.c | 153

[Mesa-dev] [PATCH 7/7] i965: enable ARB_framebuffer_no_attachment extension

From: Kevin Rogovin kevin.rogo...@intel.com Enable extension GL_ARB_framebuffer_no_attachment in i965 for Gen7 and higher. Lower gens are left disabled because those generations do not support fragment shaders with side effects. --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src

[Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

From: Kevin Rogovin kevin.rogo...@intel.com Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then the gl_framebuffer has no attachments. --- src/mesa/main

[Mesa-dev] [PATCH 3/9] mesa: Complete implementation for GL_ARB_framebuffer_no_attachments in Mesa core

From: Kevin Rogovin kevin.rogo...@intel.com Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in GL_ARB_framebuffer_no_attachments --- src/mesa/main/fbobject.c | 154

[Mesa-dev] [PATCH 1/9] mesa:Define extension GL_ARB_framebuffer_no_attachments

From: Kevin Rogovin kevin.rogo...@intel.com Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer --- src/mesa/main/extensions.c | 1 + src/mesa/main/fbobject.c| 1 + src/mesa/main/framebuffer.c | 1 + src/mesa

[Mesa-dev] [PATCH 6/9] i965: Use _mesa_geometry_ functions appropriately

From: Kevin Rogovin kevin.rogo...@intel.com Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection

[Mesa-dev] [PATCH 2/9] mesa:Define constants and functions for GL_ARB_framebuffer_no_attachment extension

From: Kevin Rogovin kevin.rogo...@intel.com Define the enumeration constants, function entry points and glGet for the GL_ARB_framebuffer_no_attachments --- .../glapi/gen/ARB_framebuffer_no_attachments.xml | 33 +++ src/mapi/glapi/gen/Makefile.am | 1 + src

[Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

From: Kevin Rogovin kevin.rogo...@intel.com If the fragment shader has atomic buffer access, the shader must execute even if the current draw buffer has no attachments. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++ src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 2 files changed

[Mesa-dev] [PATCH 5/9] mesa: add helper convenience functions for computing box intersected against scissors of gl_framebuffer

From: Kevin Rogovin kevin.rogo...@intel.com Add helper convenience function that intersects the scissor values against a passed bounding box. In addition, to avoid replicated code, make the function _mesa_scissor_bounding_box() use this new function. --- src/mesa/main/framebuffer.c | 63

[Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 172fd3c..cf3b5a2 100644

[Mesa-dev] [PATCH 8/9] i965: enable ARB_framebuffer_no_attachments extension for Gen7 and later

From: Kevin Rogovin kevin.rogo...@intel.com Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [v4 PATCH 00/10] Implement extension ARB_framebuffer_no_attachments

This patch series implements: - the needed functionality in Mesa-core for ARB_framebuffer_no_attachments - implements and enables the extension i965 Kevin Rogovin (10): mesa: Define infrastructure for ARB_framebuffer_no_attachments mesa: Constants and functions

[Mesa-dev] [v4 PATCH 02/10] mesa: Constants and functions for ARB_framebuffer_no_attachments

error. v4: Formatting fixes. Remove added documentation of how to add enums for glGet Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- .../glapi/gen/ARB_framebuffer_no_attachments.xml | 32 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi

[Mesa-dev] [v4 PATCH 05/10] mesa: helper function for scissor box of gl_framebuffer

ARB_framebuffer_no_attachment. White space and long line fixes. v3: No changes. v4: No changes. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/main/framebuffer.c | 63 +++-- src/mesa/main/framebuffer.h | 5 2 files changed, 48

[Mesa-dev] [v4 PATCH 03/10] mesa: Complete ARB_framebuffer_no_attachments in Mesa core

functions of extension. v4: Formatting fixes. Add early return to functions when extension(s) not present. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/main/fbobject.c | 220 --- 1 file changed, 187 insertions(+), 33 deletions(-) diff

[Mesa-dev] [v4 PATCH 04/10] mesa: add helper functions for geometry of gl_framebuffer

for drivers to implement ARB_framebuffer_no_attachment. v3: Add error check for functions of extension. Implement DSA functions dependent on extension. v4: Formatting fixes. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/main/framebuffer.h | 28 src/mesa

[Mesa-dev] [v4 PATCH 09/10] i965: enable ARB_framebuffer_no_attachments for Gen7+

Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. v2: No changes. v3: intel_extensions.c: Alphabetize insertion. v4: No changes. Reviewed-by: Ian Romanick ian.d.roman...@intel.com (v2) Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/drivers/dri/i965

[Mesa-dev] [v4 PATCH 08/10] i965: execution of frag-shader when it has atomic buffer

Ensure that the GPU spawns the fragment shader thread for those fragment shaders with atomic buffer access. v2: No change. v3: Use utility function _mesa_active_fragment_shader_has_atomic_ops(). v4: Formatting fixes. Reviewed-by: Tapani Pälli tapani.pa...@intel.com (v1) Signed-off-by: Kevin

[Mesa-dev] [v4 PATCH 01/10] mesa: Define infrastructure for ARB_framebuffer_no_attachments

Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer v2: Formatting fixes. v3: mtypes.h: Correct comment on _HasAttachments. v4: Formatting fixes. mtypes.h: Clarify comments Signed-off-by: Kevin Rogovin

[Mesa-dev] [v4 PATCH 10/10] mark GL_ARB_framebuffer_no_attachments as done for i965

(v2) Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- docs/GL3.txt | 4 ++-- docs/relnotes/10.7.0.html | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 9d56ee5..fae8253 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt

[Mesa-dev] [v4 PATCH 07/10] mesa: function for testing if current frag-shader has atomics

Add helper function that checks if current fragment shader active of gl_context has atomic buffer access. v3: Added in v3 of patch series. v4: Formatting fixes. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/main/mtypes.h | 7 ++- 1 file changed, 6 insertions(+), 1

[Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

and remove casts to int. Formatting fixes. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/drivers/dri/i965/brw_clip_state.c | 9 ++--- src/mesa/drivers/dri/i965/brw_misc_state.c | 9 ++--- src/mesa/drivers/dri/i965/brw_sf_state.c | 6

[Mesa-dev] [v3 PATCH 08/10] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

From: Kevin Rogovin kevin.rogo...@intel.com Ensure that the GPU spawns the fragment shader thread for those fragment shaders with atomic buffer access. v1 - v2 No change. v2 - v3 Use utility function _mesa_active_fragment_shader_has_atomic_ops(). Reviewed-by: Tapani Pälli tapani.palli

[Mesa-dev] [v3 PATCH 07/10] mesa: add helper function for testing if current fragment shader has atomics

From: Kevin Rogovin kevin.rogo...@intel.com Add helper function that checks if current fragment shader active of gl_context has atomic buffer access. v1 - v3 Added in v3 of patch series. Signed-off-by: Kevin Rogovin kevin.rogo...@intel.com --- src/mesa/main/mtypes.h | 7 ++- 1 file

[Mesa-dev] [v3 PATCH 01/10] mesa:Define extension ARB_framebuffer_no_attachments

From: Kevin Rogovin kevin.rogo...@intel.com Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments: - extension table - additions to gl_framebuffer v1 - v2 Spacing and trailing spaces fixes. v2 - v3 mtypes.h: Correct comment on _HasAttachments. Signed-off-by: Kevin

[Mesa-dev] [v3 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

From: Kevin Rogovin kevin.rogo...@intel.com Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection

[Mesa-dev] [v3 PATCH 04/10] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

From: Kevin Rogovin kevin.rogo...@intel.com Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then the gl_framebuffer has no attachments. v1 - v2 Split from

[Mesa-dev] [v3 PATCH 09/10] i965: enable ARB_framebuffer_no_attachment extension for Gen7 and later

From: Kevin Rogovin kevin.rogo...@intel.com Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher. v1 - v2 No changes. v2 - v3 intel_extensions.c: Alphabetize insertion. Reviewed-by: Ian Romanick ian.d.romanick at intel.com (v2) Signed-off-by: Kevin Rogovin kevin.rogo

[Mesa-dev] [v3 PATCH 05/10] mesa: add helper convenience functions for computing box intersected against scissors of gl_framebuffer

From: Kevin Rogovin kevin.rogo...@intel.com Add helper convenience function that intersects the scissor values against a passed bounding box. In addition, to avoid replicated code, make the function _mesa_scissor_bounding_box() use this new function. v1 - v2 Split from patch mesa:helper

[Mesa-dev] [v3 PATCH 00/10] Implement extension ARB_framebuffer_no_attachments

From: Kevin Rogovin kevin.rogo...@intel.com This patch series implements: - the needed functionality in Mesa-core for ARB_framebuffer_no_attachments - implements and enables the extension i965 Kevin Rogovin (10): mesa:Define extension ARB_framebuffer_no_attachments to gl_framebuffer

[Mesa-dev] [v3 PATCH 03/10] mesa: Complete implementation for ARB_framebuffer_no_attachments in Mesa core

From: Kevin Rogovin kevin.rogo...@intel.com Implement GL_ARB_framebuffer_no_attachments in Mesa core - changes to conditions for framebuffer completenss - implement set/get functions for framebuffers for new functions in GL_ARB_framebuffer_no_attachments v1 - v2 Spacing and exceed 80

[Mesa-dev] [v3 PATCH 02/10] mesa:Define constants and functions for ARB_framebuffer_no_attachment extension

From: Kevin Rogovin kevin.rogo...@intel.com Define the enumeration constants, function entry points and glGet for the GL_ARB_framebuffer_no_attachments. v1 - v2 Add output=true for GetFramebufferParameteriv parameter params. Alphabetical insertion. v2 - v3 Implement

[Mesa-dev] [v3 PATCH 10/10] mark GL_ARB_framebuffer_no_attachments as done for i965

From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. v1 - v2 File added to patch series v2 - v3 docs/GL3.txt : add done mark under GLES3.1 docs/relnotes/10.6.0.html : maintain alphabetical order Reviewed-by: Ian Romanick ian.d.romanick

[Mesa-dev] [PATCH 0/2] Extra check for GenQueriesARB and DeleteQueriesARB

From: Kevin Rogovin <kevin.rogo...@intel.com> This patch sequence enforces an extra check for GenQueriesARB and DeleteQueriesARB that is not preset in GenQueries and DeleteQueries. Kevin Rogovin (2): Differentiate between GenQueries and GenQueriesARB Differentiate between DeleteQ

[Mesa-dev] [PATCH 1/2] Differentiate between GenQueries and GenQueriesARB

From: Kevin Rogovin <kevin.rogo...@intel.com> The extension, GL_ARB_occlusion_queries mandates that an INVALID_OPERATION should be thrown if GenQueriesARB is called while a query is active. In contrast, the GL spec has no such requirement for GenQueries. This patch unaliases the two fun

[Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

From: Kevin Rogovin <kevin.rogo...@intel.com> The extension, GL_ARB_occlusion_queries mandates that an INVALID_OPERATION should be thrown if DeleteQueriesARB is called while a query is active. In contrast, the GL spec has no such requirement for DeleteQueries. This patch unaliases t

[Mesa-dev] [PATCH] Initial Intel Vulkan internals documentation

From: Kevin Rogovin <kevin.rogo...@intel.com> This is an RFC for documentation I am making for the Intel OTC Vulkan driver. The eventual goal for the documentation is to help new developers understand the code base more quickly so that they can contribute more easily. Kevin Rogo

[Mesa-dev] [PATCH] i965: add 2xMSAA 16xMSAA modes to DRI configs.

From: Kevin Rogovin <kevin.rogo...@intel.com> For Gen8, add 2xMSAA. For Gen9, add 2xMSAA and 16xMSAA. Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. V2: Make pointer name less ugly + add 2xMSAA for Gen8 --- sr

[Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

From: Kevin Rogovin <kevin.rogo...@intel.com> This patch series defines and implements a BatchbufferLogger for Intel GEN. The main purpose of the BatchbufferLogger is to strongly correlate API calls to data added to a batchbuffer. In addition to this function, the BatchbufferLogger also

[Mesa-dev] [PATCH 04/22] i965: assign BindingTableEntryCount of INTERFACE_DESCRIPTOR_DATA

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/drivers/dri/i965/genX_state_upload.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/driv

[Mesa-dev] [PATCH 06/22] i965: Enable BatchbufferLogger in i965 driver

From: Kevin Rogovin <kevin.rogo...@intel.com> The interface for BatchbufferLogger is that it is active only if it is LD_PRELOAD'ed. Thus, the i965 driver is to use dlsym to see if it is there, and if so fetch the object at intel_screen creation. Signed-off-by: Kevin Rogovin <k

[Mesa-dev] [PATCH 01/22] intel/tools: define BatchBufferLogger driver interface

From: Kevin Rogovin <kevin.rogo...@intel.com> Define the driver interface for BatchbufferLogger. The interface assumes that for any -thread- there is only one batchbuffer to which commands are to be added. A driver needs to provide the information on what is the active batchbuffer on a c

[Mesa-dev] [PATCH 03/22] intel/tools: BatchBufferLogger define output file format of tool

From: Kevin Rogovin <kevin.rogo...@intel.com> Define the output format of the BatchbufferLogger. The output is a sequence of blocks where blocks can have member blocks or values. The top level blocks come from the application calling into the BatchBufferLogger when an GL/GLES API call is s

[Mesa-dev] [PATCH 02/22] intel/tools: define BatchbufferLogger application interface

From: Kevin Rogovin <kevin.rogo...@intel.com> Define the application interface to BatchbufferLogger. The BatchbufferLogger needs from the application when a GL/GLES API call is issues and returns. It will use this information to correctly correlate batchbuffer additions to GL/GLES API

[Mesa-dev] [PATCH 11/22] intel/tools/disasm: correctly observe FILE *out parameter

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/tools/disasm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index 361885b..251acd3 1006

[Mesa-dev] [PATCH 15/22] intel/tools/disasm: make sure that entire range is disassembled

From: Kevin Rogovin <kevin.rogo...@intel.com> Without this patch, if a shader has errors, the disassembly of the shader often stops after the first opcode that has errors. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/tools/disasm.c | 13 + 1 fil

[Mesa-dev] [PATCH 08/22] intel/compiler: brw_validate_instructions to take const void* instead of void*

From: Kevin Rogovin <kevin.rogo...@intel.com> The disassembler does not (and should not) be modifying the data. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/compiler/brw_eu.h | 2 +- src/intel/compiler/brw_eu_validate.c | 2 +- 2 files changed,

[Mesa-dev] [PATCH 07/22] intel/common/gen_decoder: make useable from C++ source

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/common/gen_decoder.h | 7 +++ src/intel/common/gen_device_info.h | 8 2 files changed, 15 insertions(+) diff --git a/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH 19/22] intel/tools/BatchbufferLogger (txt-output): example txt dumper

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am | 5 ++ src/intel/tools/.gitignore | 1 + src/intel/tools/i965_batchbuffer_dump_show.c | 129 ++

[Mesa-dev] [PATCH 18/22] inte/tools/BatchbufferLogger : add shell script for batchbuffer logger

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am | 8 ++ src/intel/tools/.gitignore| 1 + src/intel/tools/i965_batchbuffer_logger

[Mesa-dev] [PATCH 17/22] intel/tools/BatchbufferLogger: install i965_batchbuffer non-driver interface headers

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am index 6e3e497..7845a57 100644 ---

[Mesa-dev] [PATCH 13/22] intel/tools/disasm: gen_disasm_disassemble to take const void* instead of void*

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/tools/disasm.c | 6 +++--- src/intel/tools/gen_disasm.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/tools/disasm.c b/src

[Mesa-dev] [PATCH 10/22] intel/compiler:add function to give option to print offsets into assembly

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/compiler/brw_eu.c | 11 ++- src/intel/compiler/brw_eu.h | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_eu.c

[Mesa-dev] [PATCH 14/22] intel/tools/disasm: add gen_disasm_assembly_length function

From: Kevin Rogovin <kevin.rogo...@intel.com> The length function is needed if one wishes to save GEN binary shaders to file. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/tools/disasm.c | 7 +++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed,

[Mesa-dev] [PATCH 12/22] intel/tools/disasm: make useable from C++ sources

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/tools/gen_disasm.h | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/tools/gen_disasm.h b/src/intel/tools/gen_disasm.h index 24b56c9..d2764bb 1006

[Mesa-dev] [PATCH 09/22] intel/compiler: fix for memmove argument on annotating error

From: Kevin Rogovin <kevin.rogo...@intel.com> Without this fix, disassembling of GEN shaders with GPU commands that the disassembler does not know would result in errors being added to the annotator which would crash when more than one error was added. Signed-off-by: Kevin Rogovin <k

[Mesa-dev] [PATCH 05/22] i965: correctly assign SamplerCount of INTERFACE_DESCRIPTOR_DATA

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/driv

[Mesa-dev] [PATCH 20/22] intel/tools/BatchbufferLogger (output-xml): add outputter to XML

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am| 6 +- src/intel/tools/.gitignore | 1 + src/intel/tools/i965_batchbuffer_dump_show_x

[Mesa-dev] [PATCH 22/22] intel/tools: add command line GEN shader disassembler tool

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am | 21 ++- src/intel/tools/.gitignore| 1 + src/intel/tools/gen_shader_disassembler.c | 218 +++

[Mesa-dev] [PATCH 21/22] intel/tools/BatchbufferLogger (output-json): add json outputter

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/Makefile.tools.am| 6 +- src/intel/tools/.gitignore | 1 + .../tools/i965_batchbuffer_dump_show_json.cp

[Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

From: Kevin Rogovin <kevin.rogo...@intel.com> Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 14 +

[Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

From: Kevin Rogovin <kevin.rogo...@intel.com> Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 14 +

[Mesa-dev] [PATCH 1/5] i965: define astc5x5 workaround infrastructure

From: Kevin Rogovin <kevin.rogo...@intel.com> Some GEN's have a bug in the sample where if the sampler accesses a texture with an auxialry surface and an ASTC5x5 texture without having the texture cache invalidated between such accesses, then the GPU will hang. This patch d

[Mesa-dev] [PATCH 4/5] i965: use ASTC5x5 workaround in brw_draw

From: Kevin Rogovin <kevin.rogo...@intel.com> Perform the ASTC5x5 workaround tasks for drawing; note that the function does not do anything and immediately returns if the bug is not present on the hardware. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/driv

[Mesa-dev] [PATCH 0/5] i965: ASTC5x5 workaround

From: Kevin Rogovin <kevin.rogo...@intel.com> This patch series implements a needed workaround for Gen9 for ASTC5x5 sampler reads. The crux of the work around is to make sure that the sampler does not read an ASTC5x5 texture and a surface with an auxilary buffer without having a texture

[Mesa-dev] [PATCH 2/5] i965: ASTC5x5 workaround logic for blorp

From: Kevin Rogovin <kevin.rogo...@intel.com> Blorp will only read from an ASTC5x5 texture if it copies from such a surface, that can only if an application is fetching such pixels. Because an ASTC5x3 texture can never be a render target, we do not need to worry about blorp reading such su

[Mesa-dev] [PATCH 3/5] i965: set ASTC5x5 workaround texture type tracking on texture validate

From: Kevin Rogovin <kevin.rogo...@intel.com> One of the presteps in each draw (and compute) call is to validate the textures. This is the perfect place (since all texture units are looped through) to see if ASTC5x5 and/or textures with an auxilary surface are accessed by the GPU. Sign

[Mesa-dev] [PATCH 5/5] i965: use ASTC5x5 workaround in brw_compute

From: Kevin Rogovin <kevin.rogo...@intel.com> Perform the ASTC5x5 workaround tasks for compute; note that the function does not do anything and immediately returns if the bug is not present on the hardware. Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/driv

[Mesa-dev] [PATCH v2 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

From: Kevin Rogovin <kevin.rogo...@intel.com> v2: Comments indicating that brw_bo_padding_is_good() will do the required waiting for GPU commands to finish Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 19 +++

[Mesa-dev] [PATCH v2 1/3] intel/common:add debug flag for adding and checking padding on BO's

From: Kevin Rogovin <kevin.rogo...@intel.com> Signed-off-by: Kevin Rogovin <kevin.rogo...@intel.com> --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_d

  1   2   >