Re: [Mesa-dev] [PATCH] nir: delete magic number

2017-02-08 Thread tournier.elie
On 8 February 2017 at 17:12, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 8:56 AM, Elie Tournier > wrote: > >> Explaining what is the "26" for. >> >> PS: I don't have git rights. Can you push this patch for me? >> >> Signed-off-by: Elie Tournier >> --- >> src/compiler/nir/nir_opt_loop_unroll

Re: [Mesa-dev] [PATCH mesa] docs: reword sentence that my brain can't parse

2017-02-09 Thread tournier.elie
Reviewed-by: Elie Tournier On 9 February 2017 at 11:46, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/egl.html | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/egl.html b/docs/egl.html > index 6868448bc4..c22aa4a338 100644 > --- a/docs/egl

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-12 Thread tournier.elie
On 9 February 2017 at 02:48, Timothy Arceri wrote: > On Wed, 8 Feb 2017 15:54:46 -0800 > Jason Ekstrand wrote: > > > On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier > > wrote: > > > > > Signed-off-by: Elie Tournier > > > --- > > > src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > > > 1

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-13 Thread tournier.elie
the same results. Around 5 instructions per node. But some loops that would unroll with GLSL IR fail to unroll if we set this to 25 so we set it to 26. Elie On 13 February 2017 at 01:00, tournier.elie wrote: > > On 9 February 2017 at 02:48, Timothy Arceri wrote: > > > On Wed, 8

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-21 Thread tournier.elie
On 13 February 2017 at 20:35, Rhys Kidd wrote: > > On Mon, Feb 13, 2017 at 9:43 AM Elie Tournier > wrote: > >> Seems good to me. >> >> Reviewed-by: Elie Tournier >> > > Thanks Elie. > > Given we are both "new-er" Mesa contributors I might wait for one more > Reviewed-by before asking for it to

Re: [Mesa-dev] [PATCH 1/4] compiler: style clean-ups in blob.h

2017-02-24 Thread tournier.elie
Reviewed-by: Elie Tournier On 24 February 2017 at 04:34, Timothy Arceri wrote: > --- > src/compiler/glsl/blob.h | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/src/compiler/glsl/blob.h b/src/compiler/glsl/blob.h > index 81b9

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

2017-02-24 Thread tournier.elie
Ping. On 13 February 2017 at 10:17, tournier.elie wrote: > Whoops I answer 2 times. > > Would the comment bellow be appropriate? > > This limit is chosen fairly arbitrarily. > GLSL IR max iteration is 32 instructions. (Multiply counting nodes and > magic number 5).

Re: [Mesa-dev] [GSoC] Update about floating point library

2016-08-20 Thread tournier.elie
html Have a nice day! Elie 2016-07-29 7:10 GMT+02:00 Connor Abbott : > (Re-adding the list) > > On Mon, Jul 25, 2016 at 4:46 AM, tournier.elie > wrote: > > Hi. > > > > Thanks for your email. > > It seems that you don't work for nvidia. :P. > > &

Re: [Mesa-dev] [PATCH] docs/submitting patches: mention get_reviewers.pl

2016-11-21 Thread tournier.elie
Nice, Reviewed-by: Elie Tournier 2016-11-21 18:56 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Mention the script - why/how to use alongside a useful trick to make it > work interactively (thanks Rob!). > > Signed-off-by: Emil Velikov > --- > Based on top of the "git tips" from earlier

Re: [Mesa-dev] [PATCH 2/3] st/va: remove unused variable pbuff

2016-12-02 Thread tournier.elie
Reviewed-by: Elie Tournier 2016-12-02 17:26 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/gallium/state_trackers/va/surface.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/state_trackers/va/surface.c > b/src/gallium/state_trac

[Mesa-dev] [GSoC] Update about floating point library

2016-07-23 Thread tournier.elie
Hello, I hope you are well and that you enjoy these beautiful summer days. You can found a new post on my blog : https://hopetech.github.io/ . During these few days, I implemented eq_fp64, le_fp64, lt_fp64, mul_fp64, add_fp64 and fp64-to-fp32-conversion. The code can be found on https://github.co

Re: [Mesa-dev] [PATCH] doxygen: update glsl link

2016-04-05 Thread tournier.elie
2016-04-05 4:04 GMT+02:00 Rhys Kidd : > On 4 April 2016 at 17:44, Emil Velikov wrote: > >> On 4 April 2016 at 21:38, Elie TOURNIER wrote: >> > --- >> > doxygen/glsl.doxy | 7 +++ >> > 1 file changed, 3 insertions(+), 4 deletions(-) >> > >> > diff --git a/doxygen/glsl.doxy b/doxygen/glsl.dox

Re: [Mesa-dev] [PATCH v2] doxygen: update glsl link

2016-04-11 Thread tournier.elie
Thanks. I wrote an other patch call "*[PATH v2] doxygen: Generate Doxygen for NIR*". Rhys reviewed it. But I'm not sure he tested it. If it's the case, you can push it too. Regards, Elie 2016-04-11 16:10 GMT+02:00 Emil Velikov : > On 9 April 2016 at 13:55, Rhys Kidd wrote: > > On 7 April 2016

[Mesa-dev] [GSoC2016] Interested in implementing "Soft" double precision floating point support

2016-03-09 Thread tournier.elie
Hi everyone. My name is Elie TOURNIER, I am enrolled in a French Engineering school (Telecom Physique Strasbourg) specialized in Medical ICT. I'm interested in implementing "Soft" double precision floating point support [1]. Taking this subject seem to be a good way to get my feet wet in the Mesa

Re: [Mesa-dev] [GSoC2016] Interested in implementing "Soft" double precision floating point support

2016-03-10 Thread tournier.elie
n 03/09/2016 02:25 AM, tournier.elie wrote: > >> Hi everyone. > >> > >> My name is Elie TOURNIER, I am enrolled in a French Engineering school > >> (Telecom Physique Strasbourg) specialized in Medical ICT. > >> I'm interested in implementing "So

Re: [Mesa-dev] [GSoC2016] Interested in implementing "Soft" double precision floating point support

2016-03-12 Thread tournier.elie
GSoC in which I will resume everything. 2016-03-11 22:00 GMT+01:00 Ian Romanick : > On 03/10/2016 03:09 PM, Dylan Baker wrote: > > Quoting Marek Olšák (2016-03-10 06:57:57) > >> On Thu, Mar 10, 2016 at 3:30 PM, tournier.elie > wrote: > >>> First, thank you all for

[Mesa-dev] [GSoC lib soft float] Blog update

2016-06-13 Thread tournier.elie
Hi, After a few weeks of coding, I wrote a new post on my blog ( https://hopetech.github.io/). I speak about the progress of my project, the difficulties encountered and the tools I use. Happy reading, Elie ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] [GSoC lib soft float] Blog update

2016-06-22 Thread tournier.elie
2016-06-16 1:32 GMT+02:00 Rhys Kidd : > On Monday, June 13, 2016, tournier.elie wrote: > >> Hi, >> >> After a few weeks of coding, I wrote a new post on my blog ( >> https://hopetech.github.io/). I speak about the progress of my project, >> the difficul

Re: [Mesa-dev] [PATCH] tgsi: remove unused tgsi_is_passthrough_shader()

2017-05-23 Thread tournier.elie
On 23 May 2017 at 14:31, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Elie Tournier > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 76 > -- > src/gallium/auxiliary/tgsi/tgsi_scan.h | 3 -- > 2 files changed, 79 deletions(-) > > diff -

Re: [Mesa-dev] soft fp64 on evergreen

2017-05-26 Thread tournier.elie
Hi, First of all sorry for the mess in my repo. ;) On 26 May 2017 at 11:16, Thomas Helland wrote: > 2017-05-26 8:13 GMT+02:00 Dave Airlie : >> Hi Elie, >> >> Thanks for the fp64 work. >> >> I've pulled the latest branch from your repo and start running piglit >> on a BARTS (r600g) GPU. >> >> I'v

Re: [Mesa-dev] [PATCH] i965: fix missing break

2017-06-12 Thread tournier.elie
Reviewed by: Elie Tournier On 12 June 2017 at 10:37, Lionel Landwerlin wrote: > Pretty obvious missing break statement. > > CID: 1412564 > Fixes: 641405f797 "i965: Use the new tracking mechanism for HiZ" > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c |

Re: [Mesa-dev] [PATCH 4/5] nir: implement GLSL.std.450 NMax operation

2017-06-12 Thread tournier.elie
On 12 June 2017 at 17:33, Juan A. Suarez Romero wrote: > --- > src/compiler/spirv/vtn_glsl450.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/src/compiler/spirv/vtn_glsl450.c > b/src/compiler/spirv/vtn_glsl450.c > index 5e75c3c..ce80360 100644 > --- a/src/comp

Re: [Mesa-dev] [PATCH 0/5] Add new SPIR-V functions in NIR

2017-06-12 Thread tournier.elie
This series is: Reviewed by: Elie Tournier On 12 June 2017 at 17:33, Juan A. Suarez Romero wrote: > This short series of 5 patches extend a couple of functions SPIR-V functions > to > support 64-bit, as well as it adds new functions defined in GLSL.450.std. > > The first 2 commits add support f

Re: [Mesa-dev] [RFC 00/10] WIP: NIR soft fp64 for ARB_gpu_shader_fp64 on gen6

2017-04-24 Thread tournier.elie
Hi list, I'm still interested by a review or some comments/ideas to help me land this series. I'm trying to figure out why mul/div and add/sub fail the piglit test. I already investigated about using "nir_ushr" instead of "nir_ishr". I also checked if the "nir_bcsel" were done correctly. Without s

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-26 Thread tournier.elie
Hello, I'm not an r600g person but I will be pleased to have a look to this work. I'm currently working on the fp64 for r600g. Hope to be able to send a series in fews days. The fp64 code is not HW specific, I can test it on my laptop with an Intel card. I don't even own a r600g card. Have a nice

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-05-08 Thread tournier.elie
On 8 May 2017 at 00:25, Dieter Nützel wrote: > Am 26.04.2017 14:37, schrieb tournier.elie: >> >> Hello, >> >> I'm not an r600g person but I will be pleased to have a look to this work. > > > Hello Elie, > > I know, read most of your posts abo

Re: [Mesa-dev] [PATCH] mesa: remove never used gl_shader_compiler_options::EmitNoFunctions

2017-05-08 Thread tournier.elie
On 8 May 2017 at 21:54, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Elie Tournier > --- > src/mesa/main/mtypes.h | 1 - > src/mesa/state_tracker/st_extensions.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/

Re: [Mesa-dev] [PATCH 1/4] mesa: fix indentation in _mesa_associate_uniform_storage()

2017-05-15 Thread tournier.elie
Hello Samuel, With the small fix below, the series is: Reviewed-by: Elie Tournier On 15 May 2017 at 11:55, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/program/ir_to_mesa.cpp | 101 > +++- > 1 file changed, 49 insertions(+), 52

Re: [Mesa-dev] [PATCH v2 3/3] nir: implement GLSL.std.450 NMax, NMIn and NClamp operations

2017-06-26 Thread tournier.elie
On 26 June 2017 at 11:15, Juan A. Suarez Romero wrote: > On Tue, 2017-06-13 at 11:14 +0200, Juan A. Suarez Romero wrote: >> v2: NIR fmax/fmin already handles NaN (Connor). >> --- > > Implemented the functions using fmax/fmin. > > Could you review it? Thank you! Sorry, I missed this one. Reviewed

Re: [Mesa-dev] [PATCH] meson: fix typo in isl

2017-10-12 Thread tournier.elie
On 12 October 2017 at 17:12, Dylan Baker wrote: > For list posterity, since my intel mail isn't subscribed to the list... > > Reviewed-by: Dylan Baker Ack. Feel free to push this patch for me. (I don't have git access) > > Quoting Elie Tournier (2017-10-12 04:24:10) >> Signed-off-by: Elie Tourni

Re: [Mesa-dev] [PATCH] glsl: there is no need to check for < 0

2017-01-21 Thread tournier.elie
Reviewed-by: Elie Tournier 2017-01-20 23:20 GMT+01:00 Christian Gmeiner : > size_t is defined in the C Standard section 4.1.5 as an > 'unsigned integral type'. > > Fixes the following clang compile warning: > > glsl/blob.c:110:15: warning: comparison of unsigned expression < 0 is > always false

Re: [Mesa-dev] [PATCH 3/8] nir/i965: add before ffma algebraic opts

2017-04-18 Thread tournier.elie
On 18 April 2017 at 06:52, Timothy Arceri wrote: > From: Timothy Arceri > > This shuffles constants down in the reverse of what the previous > patch does and applies some simpilifications that may be made > possible from doing so. > > Shader-db results BDW: > > total instructions in shared progra

Re: [Mesa-dev] [PATCH 8/8] i965: remove now unused GLSL IR optimisations

2017-04-19 Thread tournier.elie
On 18 April 2017 at 06:52, Timothy Arceri wrote: > These are no longer used since the previous commit. Patches 4 - 8 are: Acked-by: Elie Tournier > --- > src/mesa/drivers/dri/i965/Makefile.sources | 2 - > .../dri/i965/brw_fs_channel_expressions.cpp| 483 > --

Re: [Mesa-dev] [RFC 02/11] glsl: Add "built-in" function to do neg(fp64)

2017-03-03 Thread tournier.elie
On 3 March 2017 at 16:29, Ilia Mirkin wrote: > On Fri, Mar 3, 2017 at 11:22 AM, Elie Tournier > wrote: >> Signed-off-by: Elie Tournier >> --- >> src/compiler/glsl/builtin_float64.h | 19 +++ >> src/compiler/glsl/builtin_functions.cpp | 4 >> src/compiler/glsl/builtin_

Re: [Mesa-dev] [RFC 07/11] glsl: Add "built-in" functions to do mul(fp64, fp64)

2017-03-03 Thread tournier.elie
On 3 March 2017 at 17:46, Eric Engestrom wrote: > On Friday, 2017-03-03 16:23:03 +, Elie Tournier wrote: >> Signed-off-by: Elie Tournier >> --- >> src/compiler/glsl/builtin_float64.h | 2558 >> +++ >> src/compiler/glsl/builtin_functions.cpp |4 + >> src/c

Re: [Mesa-dev] [RFC] nir: Improve induction variables detection

2017-03-06 Thread tournier.elie
Any comments, tips before I go to deep in the code? On 24 February 2017 at 12:17, Elie Tournier wrote: > The actual code detect only basic induction variables (i = i +/- c). > I'm working on improve the detection in order to reconize derived induction > varibles (j = c1 * i +/- c2). > I obtain t

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-08 Thread tournier.elie
Right. But did we generate lots of files w/ this method? I only files I know are udivmod64.h and builtin_int64.h that you generated for ARB_gpu_shader_int64. And these files are not impacted. On 7 March 2017 at 20:23, Ian Romanick wrote: > Since this will affect generated code that is tracked in

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

2017-03-09 Thread tournier.elie
I understand the concern about reviewing auto-generated files. An other solution is to generate the builtin_float64.h during the compilation time. So we just have to land the float64.glsl file. Would anyone see merit in bootstrapping? Elie On 6 March 2017 at 18:13, Emil Velikov wrote: > On 6 Ma

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

2017-03-13 Thread tournier.elie
To resume, using NIR resolve some troubles: fp64 can be use by Intel, no autogen code, SPIR-V on OpenGL. So if nobody opposes (too hard), i will start implement fp64 in NIR. But NIR doesn't solve everything. How to handle drivers without NIR support like r600? Should we land the GLSL IR version of

Re: [Mesa-dev] [PATCH] spirv: Implement IsInf using an integer comparison

2017-03-17 Thread tournier.elie
Reviewed-by: Elie Tournier On 17 March 2017 at 04:18, Jason Ekstrand wrote: > Since we already do fabs on the one source, we're guaranteed to get > positive infinity if we get any infinity at all. Since +inf only has > one IEEE 754 representation, we can use an integer comparison and avoid > al

Re: [Mesa-dev] [PATCH] glsl: don't leak memory when trying to count loop iterations

2017-03-17 Thread tournier.elie
You can probably add a "Suggested-by" in the message. Reviewed-by: Elie Tournier On 17 March 2017 at 10:53, Timothy Arceri wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99789 > --- > src/compiler/glsl/loop_controls.cpp | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-20 Thread tournier.elie
On 8 March 2017 at 14:56, tournier.elie wrote: > Right. > But did we generate lots of files w/ this method? > I only files I know are udivmod64.h and builtin_int64.h that you > generated for ARB_gpu_shader_int64. And these files are not impacted. Ping. Is anyone know the files gene

Re: [Mesa-dev] [RFC 04/12] anv/nir: Delete the apply_dynamic_offsets prototype

2017-03-23 Thread tournier.elie
Reviewed-by: Elie Tournier On 23 March 2017 at 04:01, Jason Ekstrand wrote: > That pass hasn't existed since dd4db84640bbb694f180dd50850c3388f67228be > but the prototype stuck around for no reason. > --- > src/intel/vulkan/anv_nir.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src

Re: [Mesa-dev] [RFC 00/11] GL_ARB_gpu_shader_fp64

2017-03-23 Thread tournier.elie
ie On 13 March 2017 at 17:00, tournier.elie wrote: > To resume, using NIR resolve some troubles: fp64 can be use by Intel, > no autogen code, SPIR-V on OpenGL. > So if nobody opposes (too hard), i will start implement fp64 in NIR. > > But NIR doesn't solve everything. How to h

Re: [Mesa-dev] [PATCH 00/47] WIP: fp64 support for r600g

2017-08-24 Thread tournier.elie
On 24 August 2017 at 15:26, Marc Dietrich wrote: > Hi Elie, > > Am Mittwoch, 23. August 2017, 13:07:30 CEST schrieb Elie Tournier: >> From: Elie Tournier >> >> TL;DR >> This series is a "status update" of my work done for adding fp64 support on >> r600g. One of the biggest issue is due to a lake

Re: [Mesa-dev] [PATCH 00/47] WIP: fp64 support for r600g

2017-08-24 Thread tournier.elie
Hi Gert, On 24 August 2017 at 12:27, Gert Wollny wrote: > Hello Elie, > > thanks for you work on this. I'd thought I'd share my test results on > BARTS: > > - your tree was build with debug enabled, so some of the crashes > relate to assertion failures (at least one in r600/sb which also > fa

Re: [Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

2017-09-13 Thread tournier.elie
On 13 September 2017 at 13:13, Alejandro Piñeiro wrote: > Series: > Reviewed-by: Alejandro Piñeiro FWIW Reviewed-by: Elie Tournier > > On 12/09/17 18:41, Ian Romanick wrote: >> From: Ian Romanick >> >> glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, >> _mesa_glsl_parse

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

2017-09-14 Thread tournier.elie
With the small nitpick from Eric, the series is: Reviewed-by: Elie Tournier On 14 September 2017 at 05:47, Timothy Arceri wrote: > These instruction will be executed on every iteration of the loop > we cannot drop them. > --- > src/compiler/glsl/loop_analysis.h | 7 +++ > src/compiler/gl