CFLAGS="-fPIC" CXXFLAGS="-fPIC" LDFLAGS="-fPIC" make -j && sudo make install
On Thu, Sep 26, 2019 at 2:34 AM Karol Herbst wrote:
>
> I think you only need to recompile the translator with -fPIC enabled.
> At least that's what the error is sayin
Pretty sure I'm running into the same thing trying to build clover
with llvm-spirv enabled. If it's a known solution, I wouldn't mind
having some time saved :)
--Aaron
On Wed, Sep 25, 2019 at 10:30 AM Dieter Nützel wrote:
>
> Hello Karol and Pierre,
>
> tried it on radeonsi/NIR with Nine and Op
I had come up with an almost identical patch last night, but hadn't
gotten around to testing it before turning in.
Reviewed-by: Aaron Watry
On Tue, Aug 6, 2019 at 12:59 PM Jan Vesely wrote:
>
> v2: Drop special case of llvm-9
> Signed-off-by: Jan Vesely
> ---
> src/ga
Thanks Jan.
Reviewed-by: Aaron Watry
On Thu, Dec 13, 2018 at 3:17 PM Jan Vesely wrote:
>
> CodeGenOptions were moved to Basic.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109039
> Signed-off-by: Jan Vesely
> ---
> src/gallium/state_trackers/clove
Tested-by: Aaron Watry
Yay, I can finally use gnome/wayland with the Slack snap again without
insta-crashing my session.
--Aaron
On Thu, Aug 2, 2018 at 7:29 AM, Olivier Fourdan wrote:
> st_renderbuffer_delete() can segfault if we get a non-NULL context
> pointer but if the st_context i
I can confirm that all 28 CTS 'events' tests pass now on my BARTS
(6850) instead of hanging after an intentionally failing event.
I'll let Francisco give his say to whether it looks correct, but for
this version you can have:
Tested-By: Aaron Watry
--Aaron
On Tue, Jul 24, 2
Question: How'd you run across this? CTS, an application?
I saw this and had hoped that it finally fixed a CTS hang I've been
experiencing when running:
test_conformance/events/test_events test_userevents
But at least when SSH'd into my R600-based box, it still seems to
pause waiting for an eve
On Tue, Jun 12, 2018 at 10:31 AM, Eric Engestrom
wrote:
> On Tuesday, 2018-06-12 18:22:03 +0300, Sergii Romantsov wrote:
>> Added support of wayland-egl-backend for old Ubuntus.
>> Building of mesa with parameter "--with-egl-platforms=x11,wayland"
>> fails:
>> "configure: error: Package requiremen
45,6 +245,16 @@ namespace clover {
> ::llvm::WriteBitcodeToFile(mod, os);
> #else
> ::llvm::WriteBitcodeToFile(&mod, os);
> +#endif
> + }
Add an empty line before this function to separate it from the previous?
With those changes, this on
On Mon, May 21, 2018 at 9:34 AM, Aaron Watry wrote:
> On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote:
>> On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote:
>>> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote:
>>> > On Fri, May 18, 2018 at 1:15 PM, Jan V
On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote:
> On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote:
>> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote:
>> > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > > wrote:
>> > > On Thu, 2018-
On Fri, May 18, 2018 at 1:15 PM, Jan Vesely wrote:
> On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote:
>> They're not used anywhere else, so keep them private
>>
>> Signed-off-by: Aaron Watry
>
> I'm not sure what the original purpose of the removed func
Signed-off-by: Aaron Watry
---
.../drivers/r600/compute_memory_pool.c| 92 ---
.../drivers/r600/compute_memory_pool.h| 11 ---
2 files changed, 103 deletions(-)
diff --git a/src/gallium/drivers/r600/compute_memory_pool.c
b/src/gallium/drivers/r600
They're not used anywhere else, so keep them private
Signed-off-by: Aaron Watry
---
.../drivers/r600/compute_memory_pool.c| 35 +++
.../drivers/r600/compute_memory_pool.h| 24 -
2 files changed, 29 insertions(+), 30 deletions(-)
diff --git
Given the discussion that's ongoing, this patch might not land as-is,
but if it does:
Tested-By: Aaron Watry
Note: The meson build currently works as-is and doesn't require an
equivalent patch.
--Aaron
On Tue, May 1, 2018 at 7:14 AM, Kai Wasserbäch
wrote:
> Otherwise the build
On Wed, Apr 25, 2018 at 9:03 AM, Jan Vesely wrote:
> On Thu, 2018-04-19 at 20:39 -0500, Aaron Watry wrote:
>> From CL 1.2 Section 5.2.1:
>> CL_INVALID_VALUE if buffer was created with CL_MEM_HOST_WRITE_ONLY and
>> flags specify CL_MEM_HOST_READ_ONLY , or if bu
CL_MEM_HOST_NO_ACCESS and flags specify
CL_MEM_HOST_READ_ONLY or CL_MEM_HOST_WRITE_ONLY .
Fixes CL 1.2 CTS test/api get_buffer_info
v2: Correct host_access_flags check (Francisco)
Signed-off-by: Aaron Watry
Cc: Francisco Jerez
---
src/gallium/state_trackers/clover/api/memory.cpp | 8 ++--
1 file changed
On Mon, Apr 16, 2018, 5:24 PM Francisco Jerez wrote:
> Aaron Watry writes:
>
> > From CL 1.2 Section 5.2.1:
> > CL_INVALID_VALUE if buffer was created with CL_MEM_HOST_WRITE_ONLY
> and
> > flags specify CL_MEM_HOST_READ_ONLY , or
, but you can
definitely have a:
Tested-By: Aaron Watry
--Aaron
On Sat, Apr 14, 2018 at 12:23 PM, Jan Alexander Steffens (heftig)
wrote:
> This is for parity with autotools. It names the library
> libMesaOpenCL.so.1.0.0 and points mesa.icd to the .1 symlink.
>
> opencl_version
CL_MEM_HOST_NO_ACCESS and flags specify
CL_MEM_HOST_READ_ONLY or CL_MEM_HOST_WRITE_ONLY .
Fixes CL 1.2 CTS test/api get_buffer_info
Signed-off-by: Aaron Watry
Cc: Francisco Jerez
---
src/gallium/state_trackers/clover/api/memory.cpp | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a
Signed-off-by: Aaron Watry
Cc: Eric Anholt
---
I still have to build at least one drm driver with pci support,
but I've at least managed an out-of-tree build with these changes.
src/broadcom/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/broadcom/Makefile.am
The opencl 1.0 langstandard was renamed in 5.0+
v2: Move preprocessor check into compat.hpp
Cc: Mark Janes
Cc: Francisco Jerez
---
src/gallium/state_trackers/clover/llvm/compat.hpp | 2 ++
src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +-
2 files changed, 3 insertions(+), 1 del
On Wed, Mar 21, 2018, 4:49 PM Francisco Jerez wrote:
> Aaron Watry writes:
>
> > The opencl 1.0 langstandard was renamed in 5.0+
> >
> > Cc: Mark Janes
> > ---
> > src/gallium/state_trackers/clover/llvm/invocation.cpp | 4
> > 1 file changed
The opencl 1.0 langstandard was renamed in 5.0+
Cc: Mark Janes
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index af
On Wed, Mar 21, 2018 at 2:52 PM, Aaron Watry wrote:
> On Wed, Mar 21, 2018 at 2:37 PM, Mark Janes wrote:
>> Aaron, this patch breaks the meson build-test in our CI:
>>
>> ../src/gallium/state_trackers/clover/llvm/invocation.cpp:88:36: error:
>> ‘lang_opencl10
vers=radeonsi,r600,swrast -D
vulkan-drivers=radeon ../
That being said, I'm building against an llvm/clang 7.0 build
installed in /usr/local which meson picks up in preference to the
system headers.
--Aaron
>
> Pierre Moreau writes:
>
>> Oops, sorry.
>>
>> Reviewe
ping.
This is the last of the series that still needs review.
--Aaron
On Thu, Mar 1, 2018 at 1:39 PM, Aaron Watry wrote:
> Use get_language_version to calculate default cl standard based on
> device capabilities and -cl-std specified in build options.
>
> v4: Squash the __OPENCL_V
ping.
--Aaron
On Thu, Mar 1, 2018 at 8:02 PM, Aaron Watry wrote:
> Used to calculate the default CLC language version based on the --cl-std in
> build args
> and the device capabilities.
>
> According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by:
> 1) I
Useful for testing API, builtin library, and device completeness of
not-yet-supported versions.
Signed-off-by: Aaron Watry
(v1) Reviewed-by: Pierre Moreau
(v2) Reviewed-by: Francisco Jerez
Cc: Jan Vesely
Cc: Emil Velikov
v3: mark CL version overrides as static and const
v2: Make
the device supports
Curiously, there is no valid value for -cl-std=CL1.0
Validates requested cl-std against device_clc_version
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
v6: (Pierre) Add more const and fix some whitespace
v5: (Aaron) Use a collection of cl versions instead of switch cases
On Thu, Mar 1, 2018 at 3:43 PM, Pierre Moreau wrote:
> On 2018-03-01 — 13:39, Aaron Watry wrote:
>> Used to calculate the default CLC language version based on the --cl-std in
>> build args
>> and the device capabilities.
>>
>> According to section 5.8.4.5 of
On Thu, Mar 1, 2018, 5:19 PM Francisco Jerez wrote:
> Aaron Watry writes:
>
> > Fixes auto-completion for some device and kernel methods in my IDE.
> >
> > No functional change intended.
> >
>
> NAK to this one. object.hpp goes through quite some effort to
Useful for testing API, builtin library, and device completeness of
not-yet-supported versions.
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
Cc: Jan Vesely
Cc: Francisco Jerez
---
src/gallium/state_trackers/clover/api/platform.cpp | 7 ++-
src/gallium/state_trackers/clover/core
Fixes auto-completion for some device and kernel methods in my IDE.
No functional change intended.
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/api/device.cpp | 2 +-
src/gallium/state_trackers/clover/api/kernel.cpp | 22 +++---
2 files changed, 12
The first two patches of the previous series [1] landed upstream a while back.
When I bump my platform/device versions to 1.2, the clang instance has
been confirmed to enable 1.2 language features (like the static keyword
required in test/cl/program/execute/static.cl, which goes skip->pass), while
the device supports
Curiously, there is no valid value for -cl-std=CL1.0
Validates requested cl-std against device_clc_version
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
v5: (Aaron) Use a collection of cl versions instead of switch cases
Consolidates the string, numeric version, and clc
We'll be using dev.device_clc_version to select the default language version
soon along with the existing ir_target field.
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
Cc: Jan Vesely
v4: Pass the device down instead of device_clc_version as a separate field
v3: Revise to acknowledge th
Copying the individual fields from the device when compiling/linking
will lead to an unnecessarily large number of fields getting passed
around.
v3: Rebase on current master
v2: Use device in function args before making additional changes in following
patches
Signed-off-by: Aaron Watry
Cc: Jan
We'll need to be able to detect device version to define the appropriate
__OPENCL_VERSION__ header.
v2: Rebase after removing the previous patch (Pierre)
- Removed "clover: Add device_clc_version to llvm::create_compiler_instance"
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
-
get_cl_version to calculate version instead
v2: Split out from the previous patch (Pierre)
Signed-off-by: Aaron Watry
CC: Pierre Moreau
CC: Jan Vesely
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium
6 is Acked-By: Aaron Watry
7-11 (regardless of my comment in 9) are Reviewed-By: Aaron Watry
--Aaron
On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote:
> Reviewed-by: Francisco Jerez
> Signed-off-by: Pierre Moreau
> ---
> src/gallium/state_trackers/clover/api/platf
On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote:
> One flag that needs to be tracked is whether a library is allowed to
> received mathematics optimisations or not, as the authorisation is given
> when creating the library while the optimisations are specified when
> creating the executable.
Patches 1-5:
Reviewed-By: Aaron Watry
On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote:
> Signed-off-by: Pierre Moreau
> ---
> src/gallium/state_trackers/clover/core/device.cpp | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/src/gallium/sta
(taken from the old patch 4), and could be squashed with patch
> 8
> as well.
> * and at this point, I think the old patch 3 can be dropped as it is no longer
> useful.
>
> Regards,
> Pierre
>
> On 2017-07-30 — 20:26, Aaron Watry wrote:
>> I've dropped the
On Tue, 2017-12-12 at 12:08 -0800, Francisco Jerez wrote:
> Dylan Baker writes:
>
> > This has only been compile tested.
> >
> > cc: Curro Jerez
> > Signed-off-by: Dylan Baker
> > ---
> > include/meson.build | 19
> > meson.build
On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote:
> ---
> meson.build | 34 +-
> meson_options.txt | 13 ++
> src/gallium/meson.build | 7 ++-
> src/gallium/state_trackers/xvmc/meson.build | 52
> +++
Both this and the va state tracker seem to just install a
libgallium*.so file, but don't actually install the megadriver-esque
links for the hardware-specific driver (e.g. radeonsi_drv_video.so and
libvdpau_radeonsi*).
When I copy the VA driver over my old auto-tools one, I get a libva
initializat
On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote:
> ---
> meson.build | 35 +-
> meson_options.txt | 13 ++
> src/gallium/meson.build | 7 ++-
> src/gallium/state_trackers/va/meson.build | 39 +
On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote:
> ---
> meson.build | 40 -
> meson_options.txt| 13 +
> src/gallium/meson.build | 7 ++-
> src/gallium/state_trackers/vdpau/meson.build | 32 +++
LLVM dependency when that state tracker is enabled, as well...
I did end up having to do some mild rebasing of this patch on top of
current master, but it was pretty trivial.
That being said, this patch seems to be working as intended, so you can add:
Tested-by: Aaron Watry
If you want, I can di
re, some applications expect the library to provide
> annotated/versioned symbols.
>
> https://lists.freedesktop.org/archives/mesa-dev/2017-September/171093.html
>
> *Fedora, Suse, Arch, Debian, Ubuntu, FreeBSD use the ICD
> Gentoo manages the conflicting files via eselect.
>
On Fri, Sep 29, 2017 at 10:14 AM, Emil Velikov wrote:
> Hi all,
>
> Currently nearly all the distributions I've seen* enable and use the ICD.
> Only Gentoo does not use it, but manages the OpenCL.so conflicts via eselect.
>
> They have the ocl-icd library as a separate option, which makes me
> won
On Wed, Sep 20, 2017 at 3:23 PM, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
> ---
> CC: Francisco Jerez
> This exposes both extensions on GCN+ GPUs.
>
> src/gallium/state_trackers/clover/api/device.cpp | 6 --
> src/gallium/state_trackers/clover/core/device.cpp | 6 ++
> src/gallium
On Fri, Sep 15, 2017 at 8:46 PM, Jan Vesely wrote:
> On Thu, 2017-09-14 at 14:39 -0700, Francisco Jerez wrote:
>> Jan Vesely writes:
>>
>> > On Mon, 2017-09-04 at 13:23 -0700, Francisco Jerez wrote:
>> > > Jan Vesely writes:
>> > >
>> > > > v2: wait in map_buffer and map_image as well
>> > > > v
On Tue, Sep 19, 2017 at 9:23 AM, Vedran Miletić wrote:
> On 09/18/2017 06:00 PM, Emil Velikov wrote:
>> Hi all,
>>
>> As you may know, different components in Mesa use LLVM for various purposes.
>>
>> In particular:
>> - 3.3.0 for the aux gallium module, gallivm
>> - 3.6.0 for the opencl state-t
h: No such file or directory
#include "ir_expression_operation.h"
Signed-off-by: Aaron Watry
---
src/mesa/state_tracker/tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/tests/Makefile.am
b/src/mesa/state_tracker/tests/Makefile.am
index 12ae7fab1
On Sun, Sep 3, 2017 at 3:20 PM, David Niklas wrote:
> Hello,
> I'm interested in knowing why there are two different OpenCL
> implementations of OpenCL drivers for AMD cards.
> Is it because they support different ASICs?
> One is older and going to be replaced?
As near as I can tell, ROCm require
On Fri, Sep 1, 2017 at 7:55 PM, Jan Vesely wrote:
> Denotes native half precision float operations capability
>
> Signed-off-by: Jan Vesely
> ---
> I can change the spelling to HALVES, but simplified english sounded more
> appropriate.
>
> src/gallium/docs/source/screen.rst | 1 +
>
On Thu, Aug 10, 2017 at 11:07 AM, Jan Vesely wrote:
> On Wed, 2017-08-09 at 22:36 -0500, Aaron Watry wrote:
>> On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote:
>> > On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> > > Signed-off-by: Aaron Watry
>>
-by: Aaron Watry
Cc: Francisco Jerez
Cc: Jan Vesely
---
src/gallium/state_trackers/clover/api/device.cpp | 3 ++-
src/gallium/state_trackers/clover/core/device.cpp | 5 +
src/gallium/state_trackers/clover/core/device.hpp | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a
On Wed, Aug 16, 2017 at 9:48 PM, Alex Deucher wrote:
> On Wed, Aug 16, 2017 at 10:39 PM, Michel Dänzer wrote:
>> On 17/08/17 10:52 AM, Aaron Watry wrote:
>>> PIPE_CAP_RESOURCE_FROM_USER_MEMORY says that size must be page aligned,
>>> but doesn't necessarily say
PIPE_CAP_RESOURCE_FROM_USER_MEMORY says that size must be page aligned,
but doesn't necessarily say anything about the size of those pages.
Signed-off-by: Aaron Watry
---
src/gallium/docs/source/screen.rst | 4
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
EMBEDDED
profile) for devices that are not of type CL_DEVICE_TYPE_CUSTOM.
Signed-off-by: Aaron Watry
Cc: Francisco Jerez
Cc: Jan Vesely
---
src/gallium/state_trackers/clover/api/device.cpp | 3 ++-
src/gallium/state_trackers/clover/core/device.cpp | 5 +
src/gallium/state_trackers/clover
On Tue, Aug 15, 2017 at 7:30 PM, Michel Dänzer wrote:
> On 15/08/17 11:04 PM, Aaron Watry wrote:
>> On Mon, Aug 14, 2017 at 10:11 PM, Michel Dänzer wrote:
>>> On 15/08/17 12:00 PM, Aaron Watry wrote:
>>>> On Mon, Aug 14, 2017 at 7:54 PM, Michel Dänzer wr
On Mon, Aug 14, 2017 at 7:42 PM, Aaron Watry wrote:
> From CL 2.0 Section 5.11 (Event Objects):
> clSetEventCallback returns CL_SUCCESS if the function is executed
> successfully. Otherwise, it
> returns one of the following errors:
> ...
> CL_INVALID_VALUE if p
, CL_RUNNING or CL_COMPLETE .
Fixes: OpenCL CTS test_conformance/events/test_events callbacks
Signed-off-by: Aaron Watry
Cc: Francisco Jerez
---
src/gallium/state_trackers/clover/api/event.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/api
On Mon, Aug 14, 2017 at 4:29 PM, Aaron Watry wrote:
> On Mon, Aug 14, 2017 at 1:53 PM, Francisco Jerez
> wrote:
>> Aaron Watry writes:
>>
>>> On Sat, Aug 12, 2017 at 10:14 PM, Francisco Jerez
>>> wrote:
>>>> Jan Vesely writes:
>>>&
On Mon, Aug 14, 2017 at 1:53 PM, Francisco Jerez wrote:
> Aaron Watry writes:
>
>> On Sat, Aug 12, 2017 at 10:14 PM, Francisco Jerez
>> wrote:
>>> Jan Vesely writes:
>>>
>>>> On Sat, 2017-08-05 at 12:34 -0700, Francisco Jerez wrote:
>>
On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> Signed-off-by: Aaron Watry
>> CC: Jan Vesely
>>
>> v2: base it on the device version
>> ---
>> src/gallium/state_trackers/clover/llvm/invoc
On Sat, Aug 5, 2017 at 8:56 PM, Jan Vesely wrote:
> On Sat, 2017-08-05 at 19:46 -0500, Aaron Watry wrote:
>> On Fri, Aug 4, 2017 at 1:32 PM, Jan Vesely wrote:
>> > On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> > > According to section 5.8.4.5 of the
On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> Signed-off-by: Aaron Watry
>> CC: Jan Vesely
>>
>> v2: base it on the device version
>> ---
>> src/gallium/state_trackers/clover/llvm/invoc
On Fri, Aug 4, 2017 at 1:32 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by:
>> 1) If you have -cl-std=CL1.1+ use the version specified
>> 2) If not, use the highest
On Fri, Aug 4, 2017 at 1:22 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> We'll be using it to select the default language version soon.
>>
>> Signed-off-by: Aaron Watry
>> Cc: Pierre Moreau
>> Cc: Jan Vese
On Fri, Aug 4, 2017 at 1:14 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> device_version and device_clc_version are not necessarily the same for
>> devices that support CL 1.0, but have a 1.1 compiler and the necessary
>> extensions.
>&
On Fri, Aug 4, 2017 at 1:11 PM, Jan Vesely wrote:
> On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote:
>> The device version is the maximum CL version that the device supports.
>>
>> Eventually, this will be based on the features/extensions of the actual
>> device
On Fri, Aug 4, 2017 at 4:08 AM, Nicolai Hähnle wrote:
> On 04.08.2017 10:27, Nicolai Hähnle wrote:
>>
>> On 04.08.2017 06:24, Aaron Watry wrote:
>>>
>>> Gets rid of a bunch of errors like the following:
>>>
>>> make[4]: Entering directory
>
Gets rid of a bunch of errors like the following:
make[4]: Entering directory '/home/me/src/mesa/build/src/gallium/targets/opencl'
CXXLDlibOpenCL.la
../../../../src/util/.libs/libxmlconfig.a(libxmlconfig_la-xmlconfig.o): In
function `driParseOptionInfo':
/home/me/src/mesa/src/util/xmlconfig
Fixes a segfault when running clinfo on my r600 (BARTS/6850). Valgrind
led me straight to the same line.
Tested-by: Aaron Watry
On Wed, Aug 2, 2017 at 1:15 PM, Jan Vesely wrote:
> Fixes: Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create
> functions")
>
On Thu, Aug 3, 2017 at 11:53 AM, Jan Vesely wrote:
> On Thu, 2017-08-03 at 00:28 -0500, Aaron Watry wrote:
>> /
>>
>> On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote:
>> > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>> > > Fixes: OpenC
/
On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote:
> On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>> Fixes: OpenCL CTS test/conformance/buffers/buffer_copy
>
> Similar patch was pushed in 2013:
> 56647c5d8f8e60269f0a3277e3caa7ee57d1fe6a
> "clove
What's here is:
Reviewed-By: Aaron Watry
That being said, are clEnqueueMapBuffer/clEnqueueMapImage still
affected or are those always done as blocking operations and my c++ is
weak?
--Aaron
On Fri, Jul 28, 2017 at 10:36 PM, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
> ---
Copying the individual fields from the device when compiling/linking
will lead to an unnecessarily large number of fields getting passed
around.
Signed-off-by: Aaron Watry
Cc: Jan Vesey
---
src/gallium/state_trackers/clover/core/program.cpp | 9 +++--
.../state_trackers/clover/llvm
Signed-off-by: Aaron Watry
CC: Jan Vesely
v2: base it on the device version
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
index 16966bedb3
We'll need to be able to detect device version to define the appropriate
__OPENCL_VERSION__ header.
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/c
device_version and device_clc_version are not necessarily the same for
devices that support CL 1.0, but have a 1.1 compiler and the necessary
extensions.
CC: Jan Vesey
---
src/gallium/state_trackers/clover/api/device.cpp | 2 +-
src/gallium/state_trackers/clover/core/device.cpp | 5 +
src/g
According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by:
1) If you have -cl-std=CL1.1+ use the version specified
2) If not, use the highest 1.x version that the device supports
Curiously, there is no valid value for -cl-std=CL1.0
Signed-off-by: Aaron Watry
Cc: Pierre
We'll be using it to select the default language version soon.
Signed-off-by: Aaron Watry
Cc: Pierre Moreau
Cc: Jan Vesely
v2: (Pierre) Move changes to create_compiler_instance invocation to correct
patch to prevent temporary build breakage.
(Jan) Use device_clc_version inste
The device version is the maximum CL version that the device supports.
Eventually, this will be based on the features/extensions of the actual
device, but for now move it a bit closer to its eventual destination.
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/api/device.cpp
I've dropped the first patch of the previous series for now. I'm not
withdrawing it completely, just going to see if there's anything about
the user_ptr stuff that could have been causing the issue instead, and
if I'm using too big a hammer in this patch. If I convince myself of its
correctness, it
On Mon, Jul 24, 2017 at 9:41 PM, Aaron Watry wrote:
> On Sat, Jul 22, 2017 at 2:59 PM, Jan Vesely wrote:
>> On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>>> Base it on the active language version
>>>
>>> Signed-off-by: Aaron Watry
>>> --
On Sat, Jul 22, 2017 at 2:59 PM, Jan Vesely wrote:
> On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>> Base it on the active language version
>>
>> Signed-off-by: Aaron Watry
>> ---
>> src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++-
>&
Base it on the active language version
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm
The device version is the maximum CL version that the device supports.
Eventually, this will query the pipe_driver itself, but for now move it
a bit closer to its eventual destination.
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/api/device.cpp | 4 ++--
src/gallium
We'll be using it to select the default language version soon.
Signed-off-by: Aaron Watry
---
src/gallium/state_trackers/clover/core/program.cpp| 6 --
src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +-
src/gallium/state_trackers/clover/llvm/invocation.hpp | 2 ++
3
According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by:
1) If you have -cl-std=CL1.1+ use the version specified
2) If not, use the highest 1.x version that the device supports
Curiously, there is no valid value for -cl-std=CL1.0
Signed-off-by: Aaron Watry
Fixes: OpenCL CTS test/conformance/buffers/buffer_copy
Signed-off-by: Aaron Watry
CC: Francisco Jerez
---
src/gallium/state_trackers/clover/core/memory.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/core/memory.cpp
b/src/gallium
The first patch is one I've been sitting on for a few weeks while
I've tried to chase down other issues with clover/llvm/libclc. It
fixes at least one CTS test that I know of for CL 1.2.
The other 4 patches move the device version declaration to core/device
and then use that along with the -cl-std
Hey all,
We haven't landed the fixes to break the r600g dependency on AMDGPU yet.
I'm headed out of town for a long weekend and don't feel like risking the
push before being gone for five days.
I've got a v3 of Emil's patch 4/5 that removes the AMDGPU header dependency
from r600 and I'm good with
Looks like Mark beat me to reporting this one (was still bisecting
when this patch was sent).
Tested-by: Aaron Watry
On Wed, Jun 14, 2017 at 11:08 AM, Samuel Pitoiset
wrote:
> Fixes: 5f249b9f05e ("mapi: add GL_ARB_bindless_texture entry points")
> Reported-by: Mark Janes
1 - 100 of 392 matches
Mail list logo
