> For virgl/svga: I'd be inclined not to build them automatically. They're not
> useful outside of a VM, so most developers either will be exclusively building
> one (not both) of those, or not be interested in them at all. And Distros
> don't
> use auto options so we don't need to worry about
"auto" pays attention to the OS and architecture of the target system,
but not the available libraries. If, say, libdrm isn't available, "auto"
won't work, and a manual list of drivers will be required anyway. It
would also try building the virgl and svga gallium drivers, even when
unsupported due
A build with svga or virgl, but without DRI or Vulkan, still requires
libdrm, but this wasn't caught by meson.
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 13b561f99de..52dd5be25e7 100644
--- a/meson.build
+++ b/meson.build
@@
t to avoid ever choosing drivers that can't actually be built.
Alyssa Ross (2):
meson: require libdrm for gallium svga or virgl
meson: make "auto" only choose buildable drivers
meson.build | 185
1 file changed, 114 inserti
> > me know if it works on your end or not.
Emil, this works for me. Thank you.
Tested-by: Alyssa Ross
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> if test -n "$with_gallium_drivers" -a "x$with_gallium_drivers" != xswrast;
> then
> if test "x$enable_xvmc" = xauto -a "x$have_xvmc_platform" = xyes; then
> PKG_CHECK_EXISTS([xvmc >= $XVMC_REQUIRED], [enable_xvmc=yes],
> [enable_xvmc=no])
> fi
> ...
> fi
>
> Thus auto-detection
> Off the top of my head - none of the VL code should be build when we
> have only a swrast driver.
> Can you try and kill that bug, or shall I?
Isn't that what this patch does?
If there's only swrast, this patch prevents enabling any of the state
trackers, so need_gallium_vl won't be set, and
The meson build system already has these checks. I've just copied them
to autotools.
Without this, state trackers could be enabled when building with the
following set of options, which resulted in a compile error due to VL
being built without DRM.
--enable-autotools
I meant to add to the previous message:
I note that the documentation on submitting patches says that patches
must land in master before being applied to a stable release. In this
case, the autotools files have been removed in master, but I think it
is still worth considering applying this patch
Not all package managers / users will install perl into /usr/bin,
but /usr/bin/env /should/ always be present.
Using /usr/bin/env means that we can't give the -w argument to Perl,
so I added `use warnings' in the script.
Cc: Rob Clark
---
scripts/get_reviewer.pl | 3 ++-
1 file changed, 2
The meson build system already has these checks. I've just copied them
to autotools.
Without this, state trackers could be enabled when building with the
following set of options, which resulted in a compile error due to VL
being built without DRM.
--enable-autotools
11 matches
Mail list logo
