Re: [Mesa-dev] [Nouveau] Questions on GPU syncpoint handling from inside the GPU

2019-04-10 Thread Ben Skeggs
On Wed, 10 Apr 2019 at 22:45, Ilia Mirkin wrote: > > All docs are in the proper method address, i.e. "in bytes" -- in the > future, please refer to them that way since all the code and > documentation do. > > There is no reference to method 2c8 in the mesa driver (except the > GLOBAL_BASE thing

[Mesa-dev] [PATCH 2/2] nvc0: fix transfer of larger rectangles with DmaCopy on gk104 and up

2017-01-27 Thread Ben Skeggs
From: Ben Skeggs <bske...@redhat.com> By treating the rectangles as 1cpp, we can run up against some internal copy engine limits and trigger a MEM2MEM_RECT_OUT_OF_BOUNDS error check at launch time. This commit enables the REMAP hardware, which allows us to specify both the componen

[Mesa-dev] [PATCH 1/2] nvc0: copy engine surface params are only relevant for tiled surfaces

2017-01-27 Thread Ben Skeggs
From: Ben Skeggs <bske...@redhat.com> Aside from reducing pushbuf usage in some situations, this commit should have no other effect, and is just to make it somewhat obvious that those methods have zero effect on linear surfaces. Signed-off-by: Ben Skeggs <bske...@redhat.com> ---

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ben Skeggs
a single place. This fixes the exceptions that some NVIDIA GPUs are raising when executing getteximage-depth in non-debug builds that don't hit the assertion. Reviewed-by: Ben Skeggs <bske...@redhat.com> Thanks! > > Signed-off-by: Dave Airlie <airl...@redhat.com&

Re: [Mesa-dev] [Nouveau] [PATCH mesa 3/3] nv30: Disable msaa for now because it causes lockups

2015-09-08 Thread Ben Skeggs
On 8 September 2015 at 18:00, Hans de Goede wrote: > Hi, > > On 07-09-15 22:00, Ilia Mirkin wrote: >> >> On Mon, Sep 7, 2015 at 3:50 PM, Hans de Goede wrote: >>> >>> msaa use on nv30 may trigger a (mesa?) bug where dmesg says: >>> [ 1197.850642]

Re: [Mesa-dev] [Nouveau] [PATCH v3 0/2] nouveau: support for custom VRAM domains

2015-06-19 Thread Ben Skeggs
On 19 June 2015 at 21:51, Martin Peres martin.pe...@free.fr wrote: On 19/06/2015 13:02, Alexandre Courbot wrote: New revision of this patchset that prevents VRAM objects from being allocated on VRAM-less systems like Tegra. This is required for Mesa to work on such systems. Changes since

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Ben Skeggs
On Mon, Jun 23, 2014 at 5:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: nv30 seems to not support dma objects with offset, so simply extend the

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Ben Skeggs
On Mon, Jun 23, 2014 at 5:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 23-06-14 09:24, Ben Skeggs schreef: On Mon, Jun 23, 2014 at 5:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM

Re: [Mesa-dev] [PATCH 02/11] Makes DRI3 use invalidate.

2014-06-21 Thread Ben Skeggs
Seems to fix the same issue as the patch in Keith's tree was fixing for me. Reviewed-by: Ben Skeggs bske...@redhat.com --- src/glx/dri3_glx.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index 55eed39..b309cd4 100644 --- a/src/glx/dri3_glx.c

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

2014-06-18 Thread Ben Skeggs
Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Marek Olšákmarek.ol...@amd.com Good timing, I did the exact same thing myself a couple of hours ago :P Reviewed-by: Ben Skeggs bske...@redhat.com Previous patches were: Signed-off-by: Ben Skeggs bske...@redhat.com Signed-off-by: Keith

Re: [Mesa-dev] [Nouveau] [PATCH 1/3] gk110/ir: emit texbar the same way that the blob does

2014-06-06 Thread Ben Skeggs
On Sat, Jun 7, 2014 at 5:43 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 mesa-sta...@lists.freedestkop.org For the series: Reviewed-by: Ben Skeggs bske...@redhat.com --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2

Re: [Mesa-dev] [PATCH] nvc0: maxwell has a new video engine, don't return a decoder object

2014-05-18 Thread Ben Skeggs
On Mon, May 19, 2014 at 12:16 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video.c

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: fix setting of texture ms info to be per-stage

2014-05-11 Thread Ben Skeggs
10.2 mesa-sta...@lists.freedesktop.org Reviewed-by: Ben Skeggs bske...@redhat.com --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp | 4 src/gallium/drivers/nouveau/nv50/nv50_context.h | 10 +- src/gallium/drivers/nouveau/nv50/nv50_tex.c

Re: [Mesa-dev] [Nouveau] [PATCH] nv50/ir: make sure to reverse cond codes on all the OP_SET variants

2014-05-11 Thread Ben Skeggs
On Sun, May 11, 2014 at 5:06 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 10.1 mesa-sta...@lists.freedesktop.org Reviewed-by: Ben Skeggs bske...@redhat.com --- Found this while tracking a regression on nvc0 for my patch which fixes

Re: [Mesa-dev] [PATCH] nv50, nvc0: fix blit 3d path for 1d array textures

2014-05-11 Thread Ben Skeggs
-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 mesa-sta...@lists.freedesktop.org Reviewed-by: Ben Skeggs bske...@redhat.com --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_surface.c b/src

Re: [Mesa-dev] [PATCH v2 3/3] nv50, nvc0: leave queries on during blit, turn them on for 2d engine

2014-05-11 Thread Ben Skeggs
On Sun, May 11, 2014 at 10:34 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Fixes the new logic of the conditional rendering piglit test. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 mesa-sta...@lists.freedesktop.org Reviewed-by: Ben Skeggs bske...@redhat.com --- src/gallium

Re: [Mesa-dev] [Nouveau] [PATCH] nv50/ir/gk110: fix set with f32 dest

2014-05-07 Thread Ben Skeggs
On Wed, May 7, 2014 at 9:57 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Should fix SGE/SSG instructions, which were previously getting integer 0/-1 values. I hit the same issue on Maxwell. Soo... Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Reviewed-by: Ben Skeggs bske...@redhat.com

Re: [Mesa-dev] [PATCH 1/2] gallium: remove PIPE_CAP_MAX_COMBINED_SAMPLERS

2014-02-03 Thread Ben Skeggs
On Tue, Feb 4, 2014 at 1:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: OK, so from the _looks_ of it, vertex and fragment texture/sampler bindings are totally separate. Based on what I'm seeing, there are 16 slots for fragment shaders, and 4 for vertex shaders. From what I understand, they're

Re: [Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 7 (v3)

2013-11-24 Thread Ben Skeggs
On Mon, Nov 25, 2013 at 1:57 PM, christopher.halse.rog...@canonical.com wrote: From: Christopher James Halse Rogers christopher.halse.rog...@canonical.com http://cgit.freedesktop.org/~keithp/mesa/log/?h=dri3 v2: Fix up queryImage return for ATTRIB_FD Use driver_descriptor.configuration to

Re: [Mesa-dev] S2TC - yet another attempt to solve the S3TC issue

2011-08-10 Thread Ben Skeggs
On Wed, 2011-08-10 at 08:50 +0200, Marek Olšák wrote: On Wed, Aug 10, 2011 at 7:11 AM, Rudolf Polzer divver...@xonotic.org wrote: On Tue, Aug 09, 2011 at 11:45:23PM +0200, Marek Olšák wrote: On Tue, Aug 9, 2011 at 12:25 PM, Jose Fonseca jfons...@vmware.com wrote: I don't have time for a