set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register
if the gen attribute, 'disable_ccs_repack' is set.
Signed-off-by: Dongwon Kim
---
src/gallium/drivers/iris/iris_state.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/gallium/drivers/iris/iris_state.c
b
set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register
if the gen attribute, 'disable_ccs_repack' is set.
Signed-off-by: Dongwon Kim
---
src/intel/vulkan/genX_state.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/intel/vulkan/genX_state.c b/src
set bit15 (Disable Rebacking for Compression) of CACHE_MODE_0 register
if the gen attribute, 'disable_ccs_repack' is set.
Signed-off-by: Dongwon Kim
---
src/mesa/drivers/dri/i965/brw_defines.h | 1 +
src/mesa/drivers/dri/i965/brw_state_upload.c | 9 +
2 files changed, 10 insertions
correct bit fields information of CACHE_MODE_0 reg in current gen11.xml
Signed-off-by: Dongwon Kim
---
src/intel/genxml/gen11.xml | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/intel/genxml/gen11.xml b/src/intel/genxml/gen11.xml
index
add a new attribute, 'disable_ccs_repack' to gen_device info, which
indicates whether repacking of components in certain pixel formats
before compression needs to be disabled to keep the compatibility
with decompression capability of display controller (gen11+)
Signed-off-by: Dongwon Kim
Repacking components in certain pixel formats before compression
shouldn't be done for EHL to keep the compatibility with decompression
capability in its display controller.
Signed-off-by: Dongwon Kim
---
src/gallium/drivers/iris/iris_state.c | 10 +
src/intel/dev/gen_device_info.c
be a gdb backtrace?
>
> Thanks,
>
> -
> Lionel
>
> On 05/07/18 19:27, Dongwon Kim wrote:
> >'ISL_FORMAT_UNSUPPORTED' shouldn't be passed down for evaluation as it is
> >strictly prohibited in isl code (e.g. format_info_exists).
> >
> >Signed-of
'ISL_FORMAT_UNSUPPORTED' shouldn't be passed down for evaluation as it is
strictly prohibited in isl code (e.g. format_info_exists).
Signed-off-by: Dongwon Kim
---
src/mesa/drivers/dri/i965/intel_screen.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/mesa
Thanks, Matt!!
I am glad to see it is finally merged. By the way, not sure if you
saw this patch.
[PATCH shaderdb] run: handling binding of attribute variable name (v2)
https://lists.freedesktop.org/archives/mesa-dev/2018-March/190179.html
This is required for pre-binding of uniforms. It would
ram.
v2: get_shaders returns its own head of list for binding variables
instead of using a global head to support parallel processing of
multiple shader_tests
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.c | 81 +--
I realized this model won't work with parellel execution.
I will fix it and post another version shortly.
On Wed, Mar 14, 2018 at 03:15:20PM -0700, Kenneth Graunke wrote:
> On Friday, March 9, 2018 2:28:36 PM PDT Dongwon Kim wrote:
> > Optional binding of variables can be processed befor
5. several consecutive fprintfs are consolidated
6. removed MAX_LOG_LEN and MAX_PROG_SIZE
v5: bug fix: +1 to the length of the output file to cover '/0'
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.c | 81 ---
5. several consecutive fprintfs are consolidated
6. removed MAX_LOG_LEN and MAX_PROG_SIZE
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.c | 81 ---
1 file changed, 78 insertions(+), 3 deletions(-)
diff --git
-p option now takes hex format pci-id of target architecture.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.c | 35 +--
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/run.c b/run.c
index 69e64c7..3db97ec 100644
--- a/run.c
+++ b
I see. Because user will be putting PCI_ID instead if a specific device
variant is required. I shouldn't have been confused in the first
place :-).
Thanks,
On Wed, Mar 14, 2018 at 04:03:05PM -0700, Kenneth Graunke wrote:
> On Wednesday, March 14, 2018 3:43:18 PM PDT Dongwon Kim wrote:
>
Thanks for the review, Ken
I agree on most of your proposals.
I will upload another version shortly.
On Wed, Mar 14, 2018 at 03:10:25PM -0700, Kenneth Graunke wrote:
> On Monday, February 26, 2018 2:17:05 PM PDT Dongwon Kim wrote:
> > extraction of linked binary program to a f
Yeah, I am using "intel_run" script that lets "run" use intel_stub
layer instead. Pretty useful..
On Wed, Mar 14, 2018 at 02:54:08PM -0700, Kenneth Graunke wrote:
> On Monday, February 12, 2018 5:26:15 PM PDT Dongwon Kim wrote:
> > Add a new option, '--pciid' to ov
-ID
first) should cover that case
I will upload v2 with this change shortly.
On Wed, Mar 14, 2018 at 02:52:36PM -0700, Kenneth Graunke wrote:
> On Monday, February 12, 2018 5:26:15 PM PDT Dongwon Kim wrote:
> > Add a new option, '--pciid' to override a pci id of the target arch
> >
ertex 1
BindAttrbLoc coord 2
BindAttrbLoc col 3
This makes the shader-db run
glBindAttribLocation(p, 1, "vertex");
glBindAttribLocation(p, 2, "coord");
glBindAttribLocation(p, 3, "col");
before glLinkProgram() to include these binding info in binary shader
program.
that enables getting program binary as a file.
3. Now it tries to get the length of binary by reading program's
GL_PROGRAM_BINARY_LENGTH_OES parameter
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.c | 68 +
and use it as the size of gl log
2. define MAX_PROG_SIZE and use it as the max size of extracted
shader_program
3. out_file is now pointer allocated by strdup for the file name
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
run.
Thanks for the review. I put my comments below yours.
On Wed, Feb 14, 2018 at 10:56:14AM +0200, Eero Tamminen wrote:
> Hi,
>
> On 13.02.2018 03:26, Dongwon Kim wrote:
> >extraction of linked binary program to a file using glGetProgramBinary.
> >This file is
Add a new option, '--pciid' to override a pci id of the target arch
to support cross-architecture shader compilation. Not like "-p" option,
it is for accepting any GFX devices supported by the driver.
Setting both "-p" and "--pciid" is blocked to avoid conflic
extraction of linked binary program to a file using glGetProgramBinary.
This file is intended to be loaded by glProgramBinary in the graphic
application running on the target system.
A new option, '--out=' is available to be used for specifying
the output file name.
Signed-off-by: Dongwon Kim
To prevent a segfault, pci-id is set only if INTEL_DEVID_OVERRIDE exists.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
intel_stub.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/intel_stub.c b/intel_stub.c
index ea88400..cf9ddff 100644
--- a/intel_
ci-id' option for overriding pci-id"
was written to add support for other GEN architectures that is not listed in
run.c.
The first patch, "intel_stub: override pci-id only if INTEL_DEVID_OVERRIDE is
set"
is for fixing a segfault problem when ./intel_run is executed without
INTEL_DEVID_OV
Yeah, I understood your point. Manual updating of viewport and
drawable seems to be needed in this case unless we change
EGL specificiation. Thanks
On Tue, Aug 23, 2016 at 05:51:23PM +0100, Emil Velikov wrote:
> On 23 August 2016 at 17:36, Dongwon Kim <dongwon@intel.com> wrote:
&
with different dimension, there's no way the context
updates its viewport accordingly.
On Tue, Aug 23, 2016 at 12:23:47PM +0100, Emil Velikov wrote:
> On 15 August 2016 at 23:58, Dongwon Kim <dongwon@intel.com> wrote:
> > 'ViewportInitialized' flag in gl_context has to be reset
Sure, I will. Thanks
On Tue, Aug 23, 2016 at 11:39:52AM +0100, Emil Velikov wrote:
> Hi Dongwon,
>
> On 15 August 2016 at 23:20, Dongwon Kim <dongwon@intel.com> wrote:
> > A new patch, "[PATCH] egl/dri2: remove error checks on return values from
> > mtx_l
surfaces
(or same surfaces but with different size.) next time when the
context is made current again.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/mesa/main/context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
A new patch, "[PATCH] egl/dri2: remove error checks on return values from
mtx_lock
and cnd_wait" containing additional clean-up has been submitted. Please
disregard
this one.
On Thu, Jul 28, 2016 at 02:38:35PM -0700, Dongwon Kim wrote:
> This removes unnecessary error checks on
, Aug 15, 2016 at 02:45:04PM +0100, Emil Velikov wrote:
> Hi Kim,
>
> On 28 July 2016 at 22:38, Dongwon Kim <dongwon@intel.com> wrote:
> > This removes unnecessary error checks on return result of mtx_lock
> > calls as in all other places in MESA source since t
EGL_FALSE check in the bottom of dri2_client_wait_sync.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/egl/drivers/dri2/egl_dri2.c | 47 +++--
1 file changed, 12 insertions(+), 35 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/s
, Aug 15, 2016 at 02:45:04PM +0100, Emil Velikov wrote:
> Hi Kim,
>
> On 28 July 2016 at 22:38, Dongwon Kim <dongwon@intel.com> wrote:
> > This removes unnecessary error checks on return result of mtx_lock
> > calls as in all other places in MESA source since there is
This removes unnecessary error checks on return result of mtx_lock
calls as in all other places in MESA source since there is no chance
that mtx_lock returns any of error codes in current implementation.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/egl/drivers/dri2/egl_dri2.
There are four different places where the program pointer may jump to
'cleanup:' while the mutex is still possilby being locked. Two
of those cases are when mtx_lock(pthread_mutex_lock) fails to lock
the mutex. However, this can't be a problem because the mutex is either
not in "locked" state
:
> Hi Dongwon,
>
> On 5 April 2016 at 01:14, Dongwon Kim <dongwon@intel.com> wrote:
> > This patch enables an EGL extension, EGL_KHR_reusable_sync.
> > This new extension basically provides a way for multiple APIs or
> > threads to be excuted synchronously vi
now became 'void' type. No more error check
is needed for this function call as a result.
- (bug fix) resolved issue with duplicated unlocking of display in
eglClientWaitSync when type of sync is "EGL_KHR_REUSABLE_SYNC"
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/e
_wait_sync, case EGL_SYNC_CL_EVENT_KHR
has been added.
- (bug fix) in dri2_destroy_sync, return from cond_broadcast
call is now stored in 'err' intead of 'ret' to prevent 'ret'
from being reset to 'EGL_FALSE' even in successful case
- corrected minor syntax problems
Signed-off-by: Dongwon Ki
at
https://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_reusable_sync.txt
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/egl/drivers/dri2/egl_dri2.c | 197 ++--
src/egl/drivers/dri2/egl_dri2.h | 2 +
src/egl/main/eglapi.c | 8
just like
host in which same ASM codes will be supported. 'enable_asm'
should not be forced to be "no" anymore in this case.
v2: corrected commit message
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
configure.ac | 6 --
1 file changed, 4 insertions(+), 2 deletion
t in cross-compilation
environment.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
configure.ac | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index b05f33d..0ad27c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -710,8 +7
y possible segfaults.
Signed-off-by: Dongwon Kim <dongwon@intel.com>
---
src/egl/main/eglapi.c | 10 --
src/egl/main/eglsync.c | 3 ---
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 323634e..32f6823 100644
--
above to resolve the issue.
v2: added a case of XRGB, format and bpp selection is done
via switch-case (not if-else anymore)
Signed-off-by: Vivek Kasireddy vivek.kasire...@intel.com
Signed-off-by: Dongwon Kim dongwon@intel.com
---
src/egl/drivers/dri2/platform_wayland.c | 41
GL_NORMALIZE.
Signed-off-by: Dongwon Kim dongwon@intel.com
---
src/egl/opengles1/torus.c |4
1 file changed, 4 insertions(+)
diff --git a/src/egl/opengles1/torus.c b/src/egl/opengles1/torus.c
index 8f262b5..bb20670 100644
--- a/src/egl/opengles1/torus.c
+++ b/src/egl/opengles1
vivek.kasire...@intel.com
Signed-off-by: Dongwon Kim dongwon@intel.com
---
src/egl/drivers/dri2/platform_wayland.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers/dri2/platform_wayland.c
index 3c34e07..78761e2
46 matches
Mail list logo
