Re: [Mesa-dev] Android + tegra + mesa

2019-01-17 Thread Ilia Mirkin
I believe it should work in principle [at least the tegra drm + nouveau bit, perhaps not the android things], however it's not well-tested. I have a Jetson TK1, but it dies fairly instantaneously once any network goes through the NIC, which is a bad situation for a netboot setup. If you're

Re: [Mesa-dev] [PATCH v3 5/5] nvc0, nv50/ir: enable support for formatted image loads on GM107+

2019-01-16 Thread Ilia Mirkin
Still some bits missing (I think from 4/5): NVC0LoweringPass::handleSurfaceOpGM107(TexInstruction *su) { processSurfaceCoordsGM107(su); if (su->op == OP_SULDP) { convertSurfaceFormat(su); insertOOBSurfaceOpResult(su); } and convertSurfaceFormat will unconditionally flip

Re: [Mesa-dev] [PATCH v3 2/5] mesa, glsl: add support for EXT_shader_image_load_formatted

2019-01-16 Thread Ilia Mirkin
On Wed, Jan 16, 2019 at 6:20 PM Rhys Perry wrote: > > v3: rebase > > Signed-off-by: Rhys Perry > Reviewed-by: Marek Olšák (v2) > --- > src/compiler/glsl/ast_to_hir.cpp | 5 + > src/compiler/glsl/glsl_parser_extras.cpp | 1 + > src/compiler/glsl/glsl_parser_extras.h | 7 +++ >

[Mesa-dev] [PATCH] mesa/main: return GL_BGRA as the preferred color read format more often

2019-01-13 Thread Ilia Mirkin
Currently we were only returning it for BGRA8. But it makes sense to return it for all the BGR[AX] variants. This was discovered when figuring out why wlroots was sending a RGBX instead of BGRX image when screenshotting. Signed-off-by: Ilia Mirkin --- Not sure that this can really matter

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-12 Thread Ilia Mirkin
On Sat, Jan 12, 2019 at 9:40 AM Gert Wollny wrote: > I will not push it with > the strong NAK you gave, Ilia. To me consensus means that all who > contribute significantly to the project (like you certainly do) agree > or abstain, but don't object. A single actor should not prevent a group from

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019 at 5:38 PM Matt Turner wrote: > > On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > > > From: Gert Wollny > > > > > > Since Meson will eventually

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > From: Gert Wollny > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > NAKed-by: Ilia Mirkin [no

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
On Tue, Jan 8, 2019 at 7:26 PM Marek Olšák wrote: > > On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: >> >> On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: >> > >> > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: >> >> >> >>

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: >> >> Why does this need to be in p_state? And who is responsible for >> setting it (and how will it be set)? > > > Oh right, there is a way to get it out of p

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
Why does this need to be in p_state? And who is responsible for setting it (and how will it be set)? On Tue, Jan 8, 2019 at 2:47 PM Jiang, Sonny wrote: > > and add radeonsi support. This will be used by radeonsi internally. > > Signed-off-by: Sonny Jiang > --- >

Re: [Mesa-dev] [PATCH] autotools: Remove tegra vdpau driver

2019-01-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Thanks! On Tue, Dec 18, 2018 at 5:41 PM Dylan Baker wrote: > > This has never functioned and probably wont ever function, due to the > way gallium media state trackers are architected and the tegra video > decoder is architected. > > Cc: Thier

[Mesa-dev] Chromium - Application-level nouveau blacklist

2019-01-05 Thread Ilia Mirkin
It looks like as of Chromium 71, nouveau is completely blacklisted. I don't really see a way back from this, since they don't cite any easily reproducible issues, except that some people had some issues with indeterminate hardware and indeterminate versions of mesa. In the bug that triggered

Re: [Mesa-dev] [RFC 4/6] dri: Enable fp16 configs and visuals

2019-01-04 Thread Ilia Mirkin
On Fri, Jan 4, 2019 at 5:04 PM Ilia Mirkin wrote: > > On Fri, Jan 4, 2019 at 4:56 PM Kevin Strasser > wrote: > > diff --git a/src/mesa/drivers/dri/common/utils.c > > b/src/mesa/drivers/dri/common/utils.c > > index b52c59f..1cf9362 100644 > > --- a/src/mesa/dri

Re: [Mesa-dev] [RFC 4/6] dri: Enable fp16 configs and visuals

2019-01-04 Thread Ilia Mirkin
On Fri, Jan 4, 2019 at 4:56 PM Kevin Strasser wrote: > diff --git a/src/mesa/drivers/dri/common/utils.c > b/src/mesa/drivers/dri/common/utils.c > index b52c59f..1cf9362 100644 > --- a/src/mesa/drivers/dri/common/utils.c > +++ b/src/mesa/drivers/dri/common/utils.c > @@ -200,6 +200,10 @@

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-04 Thread Ilia Mirkin
llabora.com> wrote: >> > > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote: >> > > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin >> > > > wrote: >> > > > > Have a look at the first 4 patches in the series from Jonathan >> &g

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-02 Thread Ilia Mirkin
On Wed, Jan 2, 2019 at 11:17 AM Jason Ekstrand wrote: > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin wrote: >> >> Have a look at the first 4 patches in the series from Jonathan Marek >> to address some of these issues: >> >> https://patchwork.freedesktop.org/

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-02 Thread Ilia Mirkin
Have a look at the first 4 patches in the series from Jonathan Marek to address some of these issues: https://patchwork.freedesktop.org/series/54295/ Not sure exactly what state that work is in, but I've added Jonathan to CC, perhaps he can provide an update. Cheers, -ilia On Wed, Jan 2,

Re: [Mesa-dev] [PATCH 1/2] egl/egldevice: Fix broken reference to dev->device without LIBDRM

2018-12-29 Thread Ilia Mirkin
On Sat, Dec 29, 2018 at 6:17 AM Mathias Fröhlich wrote: > In Emils patches building on top, _eglGetDRMDeviceRenderNode is only called > from > code paths guarded with HAVE_LIBDRM. OK, so we could also guard the function's existence on HAVE_LIBDRM as well. I think that's the most logical way

Re: [Mesa-dev] [PATCH 1/2] egl/egldevice: Fix broken reference to dev->device without LIBDRM

2018-12-27 Thread Ilia Mirkin
rather stick the entire function under a HAVE_LIBDRM guard instead of having it return NULL unexpectedly. But I'd definitely like to hear from Emil in case I'm missing something. On Thu, Dec 27, 2018 at 3:59 PM Ilia Mirkin wrote: > > I don't see this function used anywhere... it's not exp

Re: [Mesa-dev] [PATCH 1/2] egl/egldevice: Fix broken reference to dev->device without LIBDRM

2018-12-27 Thread Ilia Mirkin
I don't see this function used anywhere... it's not exported either. It was added in dbb4457d9858fa977246aa5e9cabe83455022dfe by Emil as part of EGL_EXT_device_drm, but appears unused in that commit as well. Emil - can this function just be removed perhaps? -ilia On Thu, Dec 27, 2018 at 3:47

[Mesa-dev] [PATCH 2/2] nv30: fix rare issue with fp unbinding not finding the bufctx

2018-12-26 Thread Ilia Mirkin
strictly after a validation is run. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102349 Signed-off-by: Ilia Mirkin --- Fairly sure this should be EXTREMELY difficult to trigger in practice, but this is the only use PUSH_RESET not in a validation path. Fix it. src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 1/2] nv30: avoid setting user_priv without setting cur_ctx

2018-12-26 Thread Ilia Mirkin
pointing at some old context. Then we wouldn't run the switch logic, which in turn led to a NULL bufctx being dereferenced. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102349 Signed-off-by: Ilia Mirkin --- This is the underlying issue of the referenced bug src/gallium/drivers/nouveau/nv30

[Mesa-dev] [PATCH] docs: fix gallium screen cap docs

2018-12-26 Thread Ilia Mirkin
Make sure that the next line starts with spaces so that bullets are maintained throughout, add `` around a few more special tokens, and fix SAMPLE_COUNT_TEXTURE -> SAMPLE_COUNT. Signed-off-by: Ilia Mirkin --- Hardly exhaustive or complete, but a handful of things I noticed. src/gallium/d

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-26 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 10:12 AM Brian Paul wrote: > > On 12/19/2018 06:47 AM, Ilia Mirkin wrote: > > On Wed, Dec 19, 2018 at 8:38 AM Brian Paul wrote: > >> > >> On 12/18/2018 08:50 PM, Ilia Mirkin wrote: > >>> Not sure if this ever worked, but the c

Re: [Mesa-dev] last call for autotools

2018-12-23 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 1:30 PM Dylan Baker wrote: > > Quoting Nicolai Hähnle (2018-12-18 09:37:43) > > On 17.12.18 23:46, Dylan Baker wrote: > > > Quoting Marek Olšák (2018-12-17 12:25:29) > > >> On Mon, Dec 17, 2018 at 1:18 PM Eric Anholt wrote: > > >> > > >> Eero Tamminen writes: > > >>

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Ilia Mirkin
On Fri, Dec 21, 2018, 19:16 Marek Olšák > > On Fri, Dec 21, 2018, 6:28 PM Kenneth Graunke wrote: > >> That seems like a reasonable interface to me. >> >> But, I don't think it's backwards compatible. Today, don't state >> trackers set index = 0 and expect all 11 to be returned? We could >>

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Ilia Mirkin
On Fri, Dec 21, 2018 at 9:37 AM Gert Wollny wrote: > > Hello Stuart, > > Am Donnerstag, den 20.12.2018, 13:40 +1100 schrieb Stuart Young: > > Gert/Ilia, > > > > Could this be reduced this from an error to a warning, with the > > command-line option suppressing the warning? > > > > Perhaps as well

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 12:50 PM Jason Ekstrand wrote: > What do you suggest to solve this communication issue? If autotools survives > another release, so be it. However, I want to get us out of the vicious > cycle of long e-mail threads and endless debates and on to a model where > Dylan

Re: [Mesa-dev] [PATCH] freedreno/ir3: Handle GL_NONE in get_num_components_for_glformat()

2018-12-19 Thread Ilia Mirkin
> + /* Omitting the image format qualifier is allowed on GL > profiles. I realize you're trying to make the distinction against GL ES, but that may not be clear. You could say "... on desktop GL profiles", for example. Your call. Either way, Reviewed-by

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
e later discussion: Strongly NAKed-by: Ilia Mirkin This should not be applied to the repository. > --- > IMO autotools should be properly deprecated prior it its removal, so here > is a patch to do just that. I think autotools should be marked as deprecated > for the 19.0 rele

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 12:15 PM Matt Turner wrote: > > On Wed, Dec 19, 2018 at 12:06 PM Ilia Mirkin wrote: > > > We're simply trying to get the feedback from users sooner. And the > > > cost to you is very small: Use an extra flag. It's not a burden. > > >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 11:12 AM Matt Turner wrote: > Regardless of all of that, what you're suggesting is only marking > autotools as deprecated (i.e., this patch) after all known problems > with the Meson build are fixed. At that point in 3 months down the > line if we get another bug report

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 11:03 AM Jason Ekstrand wrote: > > On Wed, Dec 19, 2018 at 9:32 AM Ilia Mirkin wrote: >> >> On Wed, Dec 19, 2018 at 10:25 AM Matt Turner wrote: >> > >> > On Wed, Dec 19, 2018 at 8:06 AM Ilia Mirkin wrote: >> > > >>

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 10:25 AM Matt Turner wrote: > > On Wed, Dec 19, 2018 at 8:06 AM Ilia Mirkin wrote: > > > > On Wed, Dec 19, 2018 at 1:01 AM Matt Turner wrote: > > > WTF would you have us do? > > > > Same thing as for any change with an impact this w

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 8:38 AM Brian Paul wrote: > > On 12/18/2018 08:50 PM, Ilia Mirkin wrote: > > Not sure if this ever worked, but the current logic for setting the > > min/max index is definitely wrong for indexed draws. While we're at it, > > bring in all the

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 1:01 AM Matt Turner wrote: > WTF would you have us do? Same thing as for any change with an impact this wide -- 1. Identify stakeholders. In this case, probably the sub-project maintainers, major contributors, and a smattering of distro maintainers. 2. Make them happy,

[Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-18 Thread Ilia Mirkin
Not sure if this ever worked, but the current logic for setting the min/max index is definitely wrong for indexed draws. While we're at it, bring in all the usual logic from the non-indirect drawing path. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109086 Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-18 Thread Ilia Mirkin
On Tue, Dec 18, 2018 at 6:40 PM Gert Wollny wrote: > > Hi Ilia, > > Am Sonntag, den 16.12.2018, 12:40 -0500 schrieb Ilia Mirkin: > > On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny > > wrote: > > > > > > Since Meson will eventually be the only build system d

Re: [Mesa-dev] [PATCH v3] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
t; } > > instruction count is reduced in at least 3 instructions (note image > format is r32f, 1 component only). > > This obviously reduces register pressure as well. > > v2: - Added support for image formats from NV_image_format extension > (Ilia Mirkin). > - Return

Re: [Mesa-dev] [PATCH v2] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
... >imageStore (u_image, some_offset, vec4(1.0)); >... > } > > instruction count is reduced in at least 3 instructions (note image > format is r32f, 1 component only). > > This obviously reduces register pressure as well. > > v2: - Added support for image form

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Ilia Mirkin
Nv_image_formats adds all the core formats to gles. It's pretty easy to add them all in, so I don't see why not. On Tue, Dec 18, 2018, 03:17 Eduardo Lima Mitev > > On 12/18/18 9:05 AM, Eduardo Lima Mitev wrote: > > On 12/17/18 10:02 PM, Ilia Mirkin wrote: > >> Not

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Ilia Mirkin
On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/22 > > This series adds a new optimization pass that tries to replace code > sequences like > > if (x < y) { > z = y - x; > ... > } > > with a sequence like > > t = x - y; > if

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-17 Thread Ilia Mirkin
Note that the format may not be known. I suspect that falls into your "default" case. On Mon, Dec 17, 2018 at 3:41 PM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g,

Re: [Mesa-dev] [PATCH 1/6] st/mesa: Drop dead 'passthrough_fs' field.

2018-12-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Dec 17, 2018 at 1:37 PM Kenneth Graunke wrote: > > Dead since 2015 (commit 5142564734bd68f165b02e29e384ebbcf91cce38). > --- > src/mesa/state_tracker/st_context.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/mesa/state_trac

Re: [Mesa-dev] Suggestions for improving meson-based builds

2018-12-17 Thread Ilia Mirkin
On Mon, Dec 17, 2018 at 6:59 AM Lionel Landwerlin wrote: > > On 17/12/2018 00:33, Jason Ekstrand wrote: > > On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin wrote: >> >> 1. Build creation command recovery. With autotools, "head config.log" >> will tell you

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-16 Thread Ilia Mirkin
A diffstat would also be nice as it would better inform people reading emails whether they need to care or not. On Sun, Dec 16, 2018 at 7:53 PM Jason Ekstrand wrote: > > One of these days, we will hopefully have a script to just do this for us. > In the mean-time, manual isn't too bad. > > On

[Mesa-dev] Suggestions for improving meson-based builds

2018-12-16 Thread Ilia Mirkin
Hello all, There has been some discussion of late about dropping autotools or making it a second-class citizen. I firmly believe such discussions are premature. I've had a chance to try meson recently. First off, I'd like to commend the meson team (both the core project as well as the mesa

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-16 Thread Ilia Mirkin
On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny wrote: > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny > --- > IMO autotools should be properly

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Ilia Mirkin
On Sat, Dec 15, 2018 at 4:12 PM Kenneth Graunke wrote: > > On Saturday, December 15, 2018 9:10:46 AM PST Ilia Mirkin wrote: > > On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke > > wrote: > > > Gallium handles pipeline statistics queries as a single query > >

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: convert slct with boolean result to set

2018-12-15 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > From: Karol Herbst > > helps mainly feral ported games > > changes in shader-db: > total instructions in shared programs : 7565661 -> 7545812 (-0.26%) > total gprs used in shared programs: 797213 -> 797088 (-0.02%) > total

Re: [Mesa-dev] [PATCH 2/3] nv50/ir: optimize slct(b, c, set(a, 0)) to slct(b, c, a)

2018-12-15 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > From: Karol Herbst > > helps mainly feral ported games > > shader-db changes: > total instructions in shared programs : 7614782 -> 7565661 (-0.65%) > total gprs used in shared programs: 798045 -> 797213 (-0.10%) > total shared

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-15 Thread Ilia Mirkin
On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke wrote: > Gallium handles pipeline statistics queries as a single query > (PIPE_QUERY_PIPELINE_STATISTICS) which returns a struct with 11 values. > Sometimes it's useful to refer to each of those values individually, > rather than as a group. To

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: clean up src2 in ConstantFolding

2018-12-14 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 6:12 PM Karol Herbst wrote: > > no changes in shader-db > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp >

[Mesa-dev] [PATCH] st/mesa: remove sampler associated with buffer texture in pbo logic

2018-12-14 Thread Ilia Mirkin
a fuller investigation and fix in nouveau. Now that this is done, this code should no longer need a sampler state for fetching texels from a buffer texture. Signed-off-by: Ilia Mirkin --- This was introduced in 2b938a390 which fixed a number of legitimate issues, as well as this which ultimately

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and

Re: [Mesa-dev] last call for autotools

2018-12-13 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 2:13 AM Matt Turner wrote: > > On Thu, Dec 13, 2018 at 10:19 PM Ilia Mirkin wrote: > > So now what? I don't remember how that config was done, except that it > > was done the way I decided I needed it at the time. I have no way to > > re

Re: [Mesa-dev] last call for autotools

2018-12-13 Thread Ilia Mirkin
I have to say that the user experience for autotools is WAY better than for meson. As a concrete example, I had a meson build. Then I updated meson (0.48.1 to 0.48.2). Now ninja -C foo doesn't work. meson --reconfigure (which presumably is what ninja would end up running) doesn't work.

Re: [Mesa-dev] [PATCH 2/2] nvc0/ir: replace cvt instructions with add to improve shader performance

2018-12-13 Thread Ilia Mirkin
On Thu, Dec 13, 2018 at 6:14 PM Karol Herbst wrote: > > gives me an performance boost of 0.2% in pixmark_piano on my gk106, gm204 and > gp107. > > changes in shader-db: > > total instructions in shared programs : 7614782 -> 7614782 (0.00%) > total cvt instructions in shared programs : 139343

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Ilia Mirkin
On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand wrote: > > On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: >> >> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: >> > >> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset >> > wrote: >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Ilia Mirkin
On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: > > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > wrote: > > > > Personally, I will continue to use the list, at least for a simplicity > > point of view. I'm not sure if using a new tool will improve quality and > > code review process. >

Re: [Mesa-dev] [PATCH v2 5/6] mesa/st: use invalidate_surface() for scissored clears

2018-12-12 Thread Ilia Mirkin
On Wed, Dec 12, 2018 at 10:54 AM Ilia Mirkin wrote: > > On Wed, Dec 12, 2018 at 10:49 AM Rob Clark wrote: > > > > Now that we have pipe_context::invalidate_surface(), we can also > > use this to hint to driver about scissored clears (which use draw_vbo()). > >

Re: [Mesa-dev] [PATCH v2 5/6] mesa/st: use invalidate_surface() for scissored clears

2018-12-12 Thread Ilia Mirkin
On Wed, Dec 12, 2018 at 10:49 AM Rob Clark wrote: > > Now that we have pipe_context::invalidate_surface(), we can also > use this to hint to driver about scissored clears (which use draw_vbo()). > This is useful in particular for tilers because the driver can avoid > bringing (some) tiles back

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Ilia Mirkin
On Tue, Dec 11, 2018 at 6:34 PM Rob Clark wrote: > > On Tue, Dec 11, 2018 at 6:10 PM Ilia Mirkin wrote: > > > > On Tue, Dec 11, 2018 at 5:50 PM Rob Clark wrote: > > > > > > Signed-off-by: Rob Clark > > > --- > > > src/gallium/inc

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

2018-12-11 Thread Ilia Mirkin
On Tue, Dec 11, 2018 at 5:50 PM Rob Clark wrote: > > Signed-off-by: Rob Clark > --- > src/gallium/include/pipe/p_context.h | 11 +++ > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > 2 files changed, 37 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Ilia Mirkin
have been an issue for > is_snorm() too except they are unsigned) > > The 10_10_10_2 formats are not mixed. > > In either case, I'm not sure is_norm() returning true is *incorrect*.. > > BR, > -R > > On Tue, Dec 11, 2018 at 4:21 PM Ilia Mirkin wrote: > > >

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

2018-12-11 Thread Ilia Mirkin
So ... Z24 will end up with is_unorm() == true? [Just guessing -- assume it doesn't hae is_mixed == true.] Also, does RGB10A2 have mixed set? If so, then it won't report unorm. Not 100% sure if is_mixed is only for norm + int mixing. On Tue, Dec 11, 2018 at 4:05 PM Rob Clark wrote: > > We already

Re: [Mesa-dev] [PATCH] mesa: Fix GLES2 OES float texture framebuffer rendering.

2018-12-10 Thread Ilia Mirkin
On Mon, Dec 10, 2018 at 4:28 PM Nick Kreeger wrote: > > This change enables GLES2 chagnes to render > > This change enables GLES2 to render float/half-float textures to a > framebuffer when the appropriate OES extensions are available. > > This commit regressed OES GLES2 float texture rendering:

Re: [Mesa-dev] [PATCH 3/3] nir: fixed some missed varying compaction opportunities

2018-12-10 Thread Ilia Mirkin
FWIW you can't rely on things being packed. With something like SSO, or enhanced layouts, you can get some funky stuff. On Mon, Dec 10, 2018 at 9:22 AM Rob Clark wrote: > > That is fine by me. I've come up with a workaround for now (just > adding some dummy output components to handle the .x__w

Re: [Mesa-dev] [PATCH v2 1/2] nv50/ir: fix use-after-free in ConstantFolding::visit

2018-12-08 Thread Ilia Mirkin
On Sat, Dec 8, 2018 at 12:10 PM Karol Herbst wrote: > > opnd() might delete the passed in instruction, but it's used through > i->srcExists() later in visit > > v2: use continue instead return Can you verify that this change has no effect on compilation results (at least the high-level stats)

Re: [Mesa-dev] [PATCH 2/2] nouveau: use atomic operations for driver statistics

2018-12-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Dec 8, 2018 at 12:10 PM Karol Herbst wrote: > > multiple threads can write to those at the same time > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/nouveau_screen.h | 7 --- > 1 file changed, 4 insertions(+), 3

Re: [Mesa-dev] [PATCH 1/2] nv50/ir: fix use-after-free in ConstantFolding::visit

2018-12-07 Thread Ilia Mirkin
On Fri, Dec 7, 2018 at 3:57 AM Karol Herbst wrote: > > opnd() might delete the passed in instruction, but it's used through > i->srcExists() later in visit > > Signed-off-by: Karol Herbst > --- > .../nouveau/codegen/nv50_ir_peephole.cpp | 71 +++ > 1 file changed, 43

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: initialize relDegree staticly

2018-12-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Dec 7, 2018 at 3:57 AM Karol Herbst wrote: > > this race condition is pretty harmless, but also pretty trivial to fix > > Signed-off-by: Karol Herbst > --- > .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 23 +-- > 1 file c

Re: [Mesa-dev] [PATCH 00/11] i965 shader debug through KHR_debug

2018-12-06 Thread Ilia Mirkin
On Thu, Dec 6, 2018 at 7:36 PM Mark Janes wrote: > > This series provides Intel shader compilation debug information via > KHR_debug. Previously, shader assembly and related compilation > artifacts were dumped to stderr. Tools associating compilation > artifacts with programs (e.g.

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-06 Thread Ilia Mirkin
On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom wrote: > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > Under what circumstances would tegra have a vdpau implementation? > > I don't know about that, but this patch brings meson on par with > autotools. Are

Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver

2018-12-06 Thread Ilia Mirkin
Under what circumstances would tegra have a vdpau implementation? On Thu, Dec 6, 2018 at 11:57 AM Eric Engestrom wrote: > > From: Igor Gnatenko > > Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker" > Cc: Dylan Baker > --- > src/gallium/targets/vdpau/meson.build | 3 ++- >

Re: [Mesa-dev] [PATCH 7/8] gm107/ir: add lowering of atomic f32 add on shared memory

2018-12-05 Thread Ilia Mirkin
On Wed, Dec 5, 2018 at 4:59 AM Karol Herbst wrote: > > On Wed, Dec 5, 2018 at 6:30 AM Ilia Mirkin wrote: > > > > Signed-off-by: Ilia Mirkin > > --- > > .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 49 +++ > > .../nouveau/codegen/nv50_ir_l

[Mesa-dev] [PATCH 3/8] st/mesa: select ATOMFADD when source type is float

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

[Mesa-dev] [PATCH 8/8] nvc0: expose ATOMFADD on all generations

2018-12-04 Thread Ilia Mirkin
-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index bd48f15063a..729b7640186 100644 --- a/src/gallium/drivers/nouveau/nvc0

[Mesa-dev] [PATCH 2/8] gallium: add PIPE_CAP_TGSI_ATOMFADD to indicate support

2018-12-04 Thread Ilia Mirkin
ATOMFADD is a little special -- make drivers have to specify it explicitly. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 2 ++ src/gallium/include/pipe/p_defines.h | 1 + 3 files changed, 4 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 1/8] tgsi: add ATOMFADD operation

2018-12-04 Thread Ilia Mirkin
This is supported by at least NVIDIA hardware, and exposeable via GL extensions. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 4 src/gallium/auxiliary/tgsi/tgsi_info_opcodes.h | 2 +- src/gallium/auxiliary/tgsi/tgsi_scan.c | 1 + src/gallium

[Mesa-dev] [PATCH 6/8] nv50/ir: ensure that the constraint mov is placed above flow control

2018-12-04 Thread Ilia Mirkin
This is tickled by the Maxwell lowering logic for shared floating point add, but it could potentially come up in other ways too. Signed-off-by: Ilia Mirkin --- Note that this may depend slightly on a local patch. However the overall idea remains entirely the same. src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 5/8] nv50/ir: add support for converting ATOMFADD to proper ir

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index c6e69ff1230..afd7916a321

[Mesa-dev] [PATCH 7/8] gm107/ir: add lowering of atomic f32 add on shared memory

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 49 +++ .../nouveau/codegen/nv50_ir_lowering_nvc0.h | 1 + 2 files changed, 50 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers

[Mesa-dev] [PATCH 4/8] st/mesa: expose GL_NV_shader_atomic_float when ATOMFADD is supported

2018-12-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 002866d4cdb..8d0e8e0292f 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src

[Mesa-dev] [PATCH 1/2] nvc0: replace use of explicit default_tsc with entry 0

2018-12-03 Thread Ilia Mirkin
that even before it ever gets initialized, the sRGB-decoding enable bit is set. Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/nvc0/nvc0_context.c| 10 ++ .../drivers/nouveau/nvc0/nvc0_context.h| 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 src/gallium

[Mesa-dev] [PATCH 2/2] NEEDS TEST nvc0: always keep TSC slot 0 bound to fix TXF

2018-12-03 Thread Ilia Mirkin
. Signed-off-by: Ilia Mirkin --- I haven't tested this on nvc0 hardware yet, but it seems like it should work, based on my original investigation and the results on nv50. However all this stuff is subtle, so even if it looks like it works in principle, it might be missing some bit in practice. Sending

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-03 Thread Ilia Mirkin
On Mon, Dec 3, 2018 at 7:49 PM Jason Ekstrand wrote: > > Jordan has requested to be made an Owner of the mesa project. As much as I > may be the guy who pushed to get everything set up, I don't want to do this > sort of thing on my own. As such, I'm asking for some ACKs. If I can get 5 >

[Mesa-dev] [PATCH] nouveau: set texture upload budget

2018-12-02 Thread Ilia Mirkin
It doesn't seem like the exact number has too much effect on the performaince in "teximage". However setting it to just about anything prevents some OOMs from getting hit. These values are not well-tuned, but don't seem too bad. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/no

[Mesa-dev] [PATCH] nv50: always keep TSC slot 0 bound

2018-12-01 Thread Ilia Mirkin
to this as they don't bind a sampler.) Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/nv50/nv50_context.c | 9 .../drivers/nouveau/nv50/nv50_context.h | 1 + src/gallium/drivers/nouveau/nv50/nv50_tex.c | 21 +++ 3 files changed, 31 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH v3] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-12-01 Thread Ilia Mirkin
Looks right. Reviewed-by: Ilia Mirkin On Sat, Dec 1, 2018 at 1:18 PM Karol Herbst wrote: > > The new approach is that samplers don't get unbound even if they won't be used > in a draw and we should just leave them be as well. > > Fixes a regression in multiple windows games usi

Re: [Mesa-dev] [PATCH] st/mesa: expose EXT_render_snorm on GLES

2018-11-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Nov 29, 2018 at 3:36 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > docs/relnotes/19.0.0.html | 1 + > src/mesa/state_tracker/st_extensions.c | 8 > 2 files changed, 9 insertions(+) > > diff --git a/docs/

Re: [Mesa-dev] [PATCH 3/3] mesa: expose AMD_texture_texture4

2018-11-28 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin Note that AMD_texture_texture4 is only defined for single-component textures (not even RED allowed due to the age of the ext -- only ALPHA / LUMINANCE / DEPTH_COMPONENT / INTENSITY) -- but it doesn't say what will happen when a "bad" texture is s

Re: [Mesa-dev] [PATCH 1/2] st/mesa: expose GL_OES_texture_view

2018-11-27 Thread Ilia Mirkin
enabled for any drivers that PIPE_CAP_SAMPLER_VIEW_TARGET is enabled for. Assuming neither of those have surprising responses, this series is Reviewed-by: Ilia Mirkin > --- > docs/features.txt | 2 +- > docs/relnotes/19.0.0.html | 1 + > src/mesa/state_tracker/st_exte

Re: [Mesa-dev] [PATCH] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-25 Thread Ilia Mirkin
Would it make sense to instead keep track of a samplers_bound[] like we do for textures? It's only ever used in a context of for (i = 0; i < num_samplers; i++) if (samplers[i]) do stuff So having a mask would actually optimize that, and make this logic much simpler. On Sun, Nov 25, 2018

Re: [Mesa-dev] [PATCH] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-25 Thread Ilia Mirkin
:15 PM Karol Herbst wrote: > > On Mon, Nov 26, 2018 at 12:08 AM Ilia Mirkin wrote: > > > > On Sun, Nov 25, 2018 at 5:43 PM Karol Herbst wrote: > > > > > > On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote: > > > > > > > > Would it

Re: [Mesa-dev] [PATCH] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-25 Thread Ilia Mirkin
On Sun, Nov 25, 2018 at 5:43 PM Karol Herbst wrote: > > On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote: > > > > Would it make sense to instead keep track of a samplers_bound[] like > > we do for textures? It's only ever used in a context of > > >

[Mesa-dev] [PATCH] nv50/ir: remove dnz flag when converting MAD to ADD due to optimizations

2018-11-24 Thread Ilia Mirkin
dnz flag only applies for multiplications (e.g. to make 0 * Infinity becomes 0 instead of NaN). Once we optimize a MAD into an ADD, the dnz flag no longer makes sense, and upsets the GM107 emitter (since it looks at the ftz and dnz flags together). Signed-off-by: Ilia Mirkin --- src/gallium

Re: [Mesa-dev] [PATCH 1/2] nv50/ir: don't optimize dnz muls to add

2018-11-24 Thread Ilia Mirkin
Can you elaborate as to what the issue is? The dnz flag is set when we want to make NaN -> Infinity. Do you have a concrete TGSI program that triggers issues? On Sat, Nov 24, 2018 at 6:04 PM Karol Herbst wrote: > > fixes asserts with gallium nine > > Signed-off-by: Karol Herbst > --- >

Re: [Mesa-dev] [PATCH 2/2] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-11-24 Thread Ilia Mirkin
Using this approach, num_samplers will never go down. Also, this applies to more than just samplers -- textures, everything else. On Sat, Nov 24, 2018 at 6:04 PM Karol Herbst wrote: > > The new approach is that samplers don't get unbound even if they won't be used > in a draw and we should just

Re: [Mesa-dev] [PATCH 3/3] glsl: fix typos in comments "transfor" -> "transform"

2018-11-21 Thread Ilia Mirkin
Oh, yay, you fixed the typos here. I just had to keep reading. This patch is obviously Reviewed-by: Ilia Mirkin For the others ... have you run these through intel's CI? I'm interested in verifying that dEQP, CTS, and piglit all remain happy with the changes. The program resource stuff took

  1   2   3   4   5   6   7   8   9   10   >