[Mesa-dev] [PATCH] intel/fs: Don't apply the des stride alignment rule to accumulators

2019-01-16 Thread Jason Ekstrand
The pass was discovered to cause problems with the MUL+MACH combination we emit for nir_[iu]mul_high. In an experimental branch of mine, I ran into issues where the MUL+MACH ended up using a strided source due to working on half of a uint64_t and the new lowering pass helpfully tried to fix the

Re: [Mesa-dev] [PATCH v4] anv/device: fix maximum number of images supported

2019-01-16 Thread Jason Ekstrand
Yup. Reviewed-by: Jason Ekstrand On Wed, Jan 16, 2019 at 6:08 AM Iago Toral wrote: > Jason, does this version look good to you? > > On Mon, 2019-01-14 at 12:42 +0100, Iago Toral Quiroga wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > ima

Re: [Mesa-dev] [PATCH] intel/fs: Do the grf127 hack on SIMD8 instructions in SIMD16 mode

2019-01-15 Thread Jason Ekstrand
On January 15, 2019 17:55:31 Matt Turner wrote: On Tue, Jan 15, 2019 at 8:58 AM Jason Ekstrand wrote: Previously, we only applied the fix to shaders with a dispatch mode of SIMD8 but the code it relies on for SIMD16 mode only applies to SIMD16 instructions. If you have a SIMD8 instruction

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-15 Thread Jason Ekstrand
On Tue, Jan 15, 2019 at 12:52 PM Eric Anholt wrote: > Daniel Stone writes: > > > Hi, > > > > On Tue, 15 Jan 2019 at 12:21, Rob Clark wrote: > >> On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli > wrote: > >> > On 1/14/19 2:36 PM, Daniel Stone wro

[Mesa-dev] [PATCH] intel/fs: Do the grf127 hack on SIMD8 instructions in SIMD16 mode

2019-01-15 Thread Jason Ekstrand
Previously, we only applied the fix to shaders with a dispatch mode of SIMD8 but the code it relies on for SIMD16 mode only applies to SIMD16 instructions. If you have a SIMD8 instruction in a SIMD16 shader, neither would trigger and the restriction could still be hit. Cc: Jose Maria Casanova

Re: [Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

2019-01-14 Thread Jason Ekstrand
On Mon, Jan 14, 2019 at 1:16 AM Iago Toral wrote: > On Fri, 2019-01-11 at 12:31 -0600, Jason Ekstrand wrote: > > > On Fri, Jan 11, 2019 at 3:21 AM Iago Toral wrote: > > On Mon, 2019-01-07 at 09:39 -0600, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_devic

[Mesa-dev] [PATCH] intel/eu: Stop overriding exec sizes in send_indirect_message

2019-01-12 Thread Jason Ekstrand
For a long time, we based exec sizes on destination register widths. We've not been doing that since 1ca3a9442760b6f7 but a few remnants accidentally remained. --- src/intel/compiler/brw_eu_emit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-12 Thread Jason Ekstrand
rkin > >> > >> [nouveau] > >> > >>> Acked-by: Eric Engestrom > >>> Acked-by: Kenneth Graunke > >>> Acked-by: Lionel Landwerlin > >>> Acked-by: Jason Ekstrand > >>> Reviewed-by: Matt Turner > >> > >

Re: [Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-12 Thread Jason Ekstrand
On January 12, 2019 03:06:07 Lionel Landwerlin wrote: On 12/01/2019 03:45, Jason Ekstrand wrote: Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we

[Mesa-dev] [PATCH] nir/gcm: Support deref instructions

2019-01-12 Thread Jason Ekstrand
Even though no one's been brave enough to ever use this pass, I like to keep it functionally working. --- src/compiler/nir/nir_opt_gcm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_opt_gcm.c b/src/compiler/nir/nir_opt_gcm.c index 879a77a884b..e7d3f8ec424 100644

[Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-11 Thread Jason Ekstrand
Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we were going to have to build a default case anyway which would need them all. However, we can just trust

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Jason Ekstrand
Acked-by: Eric Engestrom > Acked-by: Kenneth Graunke > Acked-by: Lionel Landwerlin > Acked-by: Jason Ekstrand > Acked-by: Rob Clark > Acked-by: Marek Olšák > Reviewed-by: Christian Gmeiner > Reviewed-by: Matt Turner > Reviewed-by: Eric Anholt > Signed-off-by: Gert Wol

[Mesa-dev] [PATCH 1/3] spirv: Whack sampler/image pointers to uniform

2019-01-11 Thread Jason Ekstrand
A long time in a galaxy far far away, there was a GLSLang bug with how it handled samplers passed in as function parameters. (The bug can be found here: https://github.com/KhronosGroup/glslang/issues/179.) Unfortunately, that version was shipped in several apps and has been causing heartburn for

[Mesa-dev] [PATCH 3/3] intel/nir: Call nir_opt_deref in brw_nir_optimize

2019-01-11 Thread Jason Ekstrand
It's an optimization so we should probably be calling it in the optimization loop. --- src/intel/compiler/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 749c00ebcc6..92d7fe4bede 100644 ---

[Mesa-dev] [PATCH 2/3] spirv: Contain the GLSLang issue #179 workaround to old GLSLang

2019-01-11 Thread Jason Ekstrand
Instead of applying the workaround universally, detect semi-old GLSLang via the generator ID and only enable the workaround on old GLSLang. This isn't nearly as precise as one would like it to be because the first GLSLang generator id version bump was on October 7, 2017 which is about 1.5 years

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:55 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > I think I kind of like having "mem" be on external things. Shared is a > > little weird there because it never leaves the chip so is it mem

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:50 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke < > kenn...@whitecape.org> > > > wrote: > &

Re: [Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 3:21 AM Iago Toral wrote: > On Mon, 2019-01-07 at 09:39 -0600, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_device.c | 28 ++ > > src/intel/vulkan/anv_extensions.py | 1 + > > src/intel/vulkan/anv_pass.c| 37 +++

Re: [Mesa-dev] [PATCH 4/6] anv/blorp: Refactor MSAA resolves into an exportable helper function

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 2:19 AM Iago Toral wrote: > On Mon, 2019-01-07 at 09:39 -0600, Jason Ekstrand wrote: > > This function is modeled after the aux_op functions except that it > > has a > > lot more parameters because it deals with two images as well as > > source

[Mesa-dev] [MR] anv: Implement SSBOs bindings with GPU addresses in a descriptor BO

2019-01-11 Thread Jason Ekstrand
This merge request, which I've marked WIP, is trying to push ANV in a more modern direction. Whereas most other drivers have abandon binding tables in favour of descriptor buffers, we've been holding on to binding tables like our lives depended on it. This MR attempts to start moving us into the

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
tor of merge request to add/change > tags if he doesn't have "Developer" role? > I'm not sure. > - Maybe adding more tags/more granular tags would be a good idea. > - Could Intel CI be integrated in some way with gitlab? > > Overall as someone who didn't interact with mai

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > > Those names (nir_var_func_local, nir_var_thread_local, and > > > nir_var_thr

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 9:13 AM Iago Toral Quiroga wrote: > We had defined MAX_IMAGES as 8, which we used to size the array for > image push constant data. The comment there stated that this was for > gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes > that array, asserting

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
ly applied as part of the merging process. This makes merging a bit more manual than it needs to be but is really no worse than it was before. Ok, there you have my thoughts. I'd be happy to hear others. --Jason On Fri, Jan 11, 2019 at 10:57 AM Jason Ekstrand wrote: > All, > > The mesa

[Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
All, The mesa project has now hit 100 merge requests (36 are still open). I (and I'm sure others) would be curious to hear people's initial thoughts on the process. What's working well? What's not working? Is it total fail and should we go back to mailing lists? --Jason

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how you

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-10 Thread Jason Ekstrand
> Reviewed-by: Matt Turner > Acked-by: Eric Engestrom > Acked-by: Kenneth Graunke > Acked-by: Jason Ekstrand > and I would probably include Jason and Marek in this group as well, > though they did not offer a *-by. > > I don't think there's anything to continue deb

[Mesa-dev] intel: 8 and 16-bit booleans

2019-01-10 Thread Jason Ekstrand
Topi just asked me on IRC what I thought about handling 16-bit booleans on Intel hardware in the light of the 1-bit boolean stuff. The current state of the driver is that we use nir_lower_bool_to_int32 pass to produce NIR that looks basically identical to the NIR we were getting in the back-end

Re: [Mesa-dev] [PATCH] nir: fix copy-paste error in nir_lower_constant_initializers

2019-01-10 Thread Jason Ekstrand
Pushed. On Thu, Jan 10, 2019 at 10:35 AM Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Thu, Jan 10, 2019 at 5:57 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > >> Reviewed-by: Erik Faye-Lund >> >> On Thu, 2019-01-10 at 11

Re: [Mesa-dev] [PATCH] nir: fix copy-paste error in nir_lower_constant_initializers

2019-01-10 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Jan 10, 2019 at 5:57 AM Erik Faye-Lund wrote: > Reviewed-by: Erik Faye-Lund > > On Thu, 2019-01-10 at 11:23 +, Rhys Perry wrote: > > Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1 > > ('nir: Rework nir_lower_constant_ini

Re: [Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

2019-01-10 Thread Jason Ekstrand
Anyone? On Mon, Jan 7, 2019 at 9:39 AM Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 28 ++ > src/intel/vulkan/anv_extensions.py | 1 + > src/intel/vulkan/anv_pass.c| 37 +++- > src/intel/vulkan/anv_private.h | 3 + >

[Mesa-dev] [MR] anv/pipeline: Constant fold after apply_pipeline_layout

2019-01-09 Thread Jason Ekstrand
Thanks to the new NIR load_descriptor intrinsic added by the UBO/SSBO lowering series, we weren't getting UBO pushing because the UBO range detection pass couldn't see the constants it needed. This fixes that problem with a quick round of constant folding. Because we're folding we no longer need

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-09 Thread Jason Ekstrand
On Tue, Jan 8, 2019 at 11:57 PM Kenneth Graunke wrote: > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > the naming is a bit confusing no matter how you look at it. Within SPIR-V > > "global" memory is memory accessible from all threads. glsl "global" > memory > > normally

Re: [Mesa-dev] [PATCH v2] nir: fix warning in nir_lower_io.c

2019-01-08 Thread Jason Ekstrand
ACK On Tue, Jan 8, 2019 at 12:27 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Initialize the variable with NULL. Fixes the following > > In file included from ../src/compiler/nir/nir_lower_io.c:34: > ../src/compiler/nir/nir_lower_io.c: In function >

Re: [Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

2019-01-08 Thread Jason Ekstrand
On Tue, Jan 8, 2019 at 1:03 PM Karol Herbst wrote: > On Mon, Jan 7, 2019 at 6:16 PM Jason Ekstrand > wrote: > > > > On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > >> > >> With OpenCL some system values match the address bits, but in GLSL we > als

Re: [Mesa-dev] [ANNOUNCE] 19.0 branchpoint on 2019/01/29

2019-01-08 Thread Jason Ekstrand
There are two things I'd like to land prior to the branch point (as an FYI): - Rafiel's code to stop using userptr for ANV state pools (!11) - VK_EXT_transform_feedback (!2) Both are pretty close at this point so I think it's feasible. --Jason On Tue, Jan 8, 2019 at 11:52 AM Dylan Baker

[Mesa-dev] [MR] intel: Add support for split SEND instructions

2019-01-08 Thread Jason Ekstrand
We've had split send instructions in the hardware since Sky Lake but haven't bothered to wire them up yet. In order to get there, this MR adds a new SHADER_OPCODE_SEND opcode which does a generic send without all the special-casing in fs_generator. At the end, it switches us to sends for surface

Re: [Mesa-dev] [PATCH 1/6] vulkan: Update the XML and headers to 1.1.97

2019-01-08 Thread Jason Ekstrand
Thanks! Pushed. On Mon, Jan 7, 2019 at 9:46 AM Samuel Pitoiset wrote: > Acked-by: Samuel Pitoiset > > On 1/7/19 4:39 PM, Jason Ekstrand wrote: > > --- > > include/vulkan/vulkan.h | 2 +- > > include/vulkan/vulkan_android.h | 2 +- > &g

Re: [Mesa-dev] [PATCH 12/12] nir/spirv: handle ContractionOff execution mode

2019-01-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/spirv_info.h| 1 + > src/compiler/spirv/spirv_info_c.py | 1 + > src/compiler/spirv/spirv_to_nir.c | 9 - > src/compil

Re: [Mesa-dev] [PATCH 11/12] nir: add support for address bit sized system values

2019-01-07 Thread Jason Ekstrand
On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/amd/vulkan/radv_meta_buffer.c | 8 ++-- > src/amd/vulkan/radv_meta_bufimage.c| 28 +++--- > src/amd/vulkan/radv_meta_clear.c | 4 +- >

Re: [Mesa-dev] [PATCH 10/12] nir: add bit_size parameter to system values with multiple allowed bit sizes

2019-01-07 Thread Jason Ekstrand
First off, thank you very much for cleaning this up! On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/nir/nir_builder_opcodes_h.py | 14 -- > src/compiler/nir/nir_lower_system_values.c| 4 ++-- >

Re: [Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

2019-01-07 Thread Jason Ekstrand
On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > With OpenCL some system values match the address bits, but in GLSL we also > have some system values being 64 bit like subgroup masks. > > With this it is possible to adjust the builder functions so that depending > on the bit_sizes the

Re: [Mesa-dev] [PATCH 06/12] nir/spirv: handle SpvStorageClassCrossWorkgroup

2019-01-07 Thread Jason Ekstrand
This seems reasonable. However, I'd like to ask that you land patch 5 ASAP and wait a little while on landing this one. Having a at least couple weeks with the rename but without adding back in nir_var_global with a different meaning will increase the liklihood that merge conflicts will result

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-07 Thread Jason Ekstrand
Assuming it builds everywhere (probably best to double-check before pushing anything) Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within SPIR-V > "global" memory is memory acc

Re: [Mesa-dev] [PATCH 04/12] nir/spirv: improve parsing of the memory model

2019-01-07 Thread Jason Ekstrand
On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/nir/nir.h| 8 > src/compiler/nir/nir_clone.c | 1 + > src/compiler/nir/nir_serialize.c | 2 ++ > src/compiler/spirv/spirv_to_nir.c | 26

Re: [Mesa-dev] [PATCH 03/12] nir/vtn: add caps for some cl related capabilities

2019-01-07 Thread Jason Ekstrand
at this list isn't sorted in any meaningful way. I just sent out a patch to sort it. With that fixed and these put in the right order, the first three patches are Reviewed-by: Jason Ekstrand > }; > > typedef struct shader_info { > diff --git a/src/compiler/spirv/spirv_to_nir.c >

[Mesa-dev] [PATCH 1/2] spirv: Sort supported capabilities

2019-01-07 Thread Jason Ekstrand
--- src/amd/vulkan/radv_shader.c| 24 - src/compiler/shader_info.h | 34 - src/intel/vulkan/anv_pipeline.c | 18 ++--- src/mesa/drivers/dri/i965/brw_context.c | 10 4 files changed, 43 insertions(+), 43

[Mesa-dev] [PATCH 2/2] anv: Sort properties and features switch statements

2019-01-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 84 +-- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 2a3919d2949..cd179e6801c 100644 --- a/src/intel/vulkan/anv_device.c +++

[Mesa-dev] [PATCH 1/6] vulkan: Update the XML and headers to 1.1.97

2019-01-07 Thread Jason Ekstrand
--- include/vulkan/vulkan.h | 2 +- include/vulkan/vulkan_android.h | 2 +- include/vulkan/vulkan_core.h| 155 +++- include/vulkan/vulkan_fuchsia.h | 2 +- include/vulkan/vulkan_ios.h | 2 +- include/vulkan/vulkan_macos.h | 2

[Mesa-dev] [PATCH 3/6] anv: Rename has_resolve to has_color_resolve

2019-01-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/anv_pass.c| 4 ++-- src/intel/vulkan/anv_private.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 478b8e7a3db..eee7a8c3b3c 100644 ---

[Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

2019-01-07 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 28 ++ src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pass.c| 37 +++- src/intel/vulkan/anv_private.h | 3 + src/intel/vulkan/genX_cmd_buffer.c | 136 + 5 files changed, 204

[Mesa-dev] [PATCH 5/6] anv: Move resolve_subpass to genX_cmd_buffer.c

2019-01-07 Thread Jason Ekstrand
We may have to do transitions around certain kinds of resolves so it helps to have it genX code. --- src/intel/vulkan/anv_blorp.c | 66 -- src/intel/vulkan/anv_private.h | 2 - src/intel/vulkan/genX_cmd_buffer.c | 61 ++- 3 files

[Mesa-dev] [PATCH 4/6] anv/blorp: Refactor MSAA resolves into an exportable helper function

2019-01-07 Thread Jason Ekstrand
This function is modeled after the aux_op functions except that it has a lot more parameters because it deals with two images as well as source and destination regions. --- src/intel/vulkan/anv_blorp.c | 225 ++--- src/intel/vulkan/anv_private.h | 14 ++ 2 files

[Mesa-dev] [PATCH 2/6] intel/blorp: Add two more filter modes

2019-01-07 Thread Jason Ekstrand
--- src/intel/blorp/blorp.h | 2 ++ src/intel/blorp/blorp_blit.c | 62 +--- 2 files changed, 52 insertions(+), 12 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 1e22712602d..bb83650092a 100644 --- a/src/intel/blorp/blorp.h

Re: [Mesa-dev] Chromium - Application-level nouveau blacklist

2019-01-05 Thread Jason Ekstrand
On Sat, Jan 5, 2019 at 2:40 PM Ilia Mirkin wrote: > It looks like as of Chromium 71, nouveau is completely blacklisted. > That's rather unfortunate. :-( The intel mesa drivers were also blacklisted for quite some time a while back. I'm not really sure what we did to get blacklisted or what we

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-05 Thread Jason Ekstrand
12:40 AM Ilia Mirkin wrote: > > > > On Fri, Jan 4, 2019 at 10:46 AM Jason Ekstrand > wrote: > > > > > > On Fri, Jan 4, 2019 at 4:07 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > >> > > >> On Thu, 2019-01-0

[Mesa-dev] [PATCH] nir: Add a SSA type gathering pass

2019-01-05 Thread Jason Ekstrand
This new pass (which isn't even compile-tested) attempts to determine the ALU type of all the SSA values in a function impl. It takes a greedy approach and assigns intness or floatness to everything it thinks can possibly contain an int or a float. Some values will be labled as both int and

[Mesa-dev] [PATCH] intel/blorp: Be more conservative about copying clear colors

2019-01-04 Thread Jason Ekstrand
In 92eb5bbc68d7324 we attempted to avoid copying clear colors whenever we weren't doing a resolve. However, this broke MSAA resolves because we need the clear color in the source. This patch makes blorp much more conservative such that it only avoids the clear color copy if either aux_usage ==

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-04 Thread Jason Ekstrand
On Fri, Jan 4, 2019 at 4:07 AM Erik Faye-Lund wrote: > On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote: > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund < > > erik.faye-l...@collabora.com> wrote: > > > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrot

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-03 Thread Jason Ekstrand
On Thu, Jan 3, 2019 at 2:03 PM Bas Nieuwenhuizen wrote: > On Thu, Jan 3, 2019 at 6:59 PM Jason Ekstrand > wrote: > > > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > >> > >> On Wed, 2019-01-02 at 10:16 -060

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-03 Thread Jason Ekstrand
On Thu, Jan 3, 2019 at 1:37 PM Roland Scheidegger wrote: > Am 03.01.19 um 18:58 schrieb Jason Ekstrand: > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund > > mailto:erik.faye-l...@collabora.com>> > wrote: > > > > On Wed, 2019-01-02 at 10:16 -0600, Jason E

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-03 Thread Jason Ekstrand
On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund wrote: > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote: > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin > > wrote: > > > Have a look at the first 4 patches in the series from Jonathan > > > Marek >

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

2019-01-02 Thread Jason Ekstrand
On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin wrote: > Have a look at the first 4 patches in the series from Jonathan Marek > to address some of these issues: > > https://patchwork.freedesktop.org/series/54295/ > > Not sure exactly what state that work is in, but I've added Jonathan > to CC,

Re: [Mesa-dev] [PATCH] i965: Drop mark_surface_used mechanism.

2018-12-30 Thread Jason Ekstrand
Finally! I haven't read the patch but whole-heartedly Acked-by: Jason Ekstrand On December 30, 2018 00:01:46 Kenneth Graunke wrote: The original idea was that the backend compiler could eliminate surfaces, so we would have it mark which ones are actually used, then shrink the binding table

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

2018-12-22 Thread Jason Ekstrand
is R8G8B8A8_UNORM while the view is R8G8B8A8_SRGB. I think this might be the problem. Currently looking at adding anv_image_view_mcs_op/anv_image_view_ccs_op and see if that breaks the world. - Lionel On 21/12/2018 13:09, Jason Ekstrand wrote: This isn't quite true. Fast-clear without CCS compression (also

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

2018-12-21 Thread Jason Ekstrand
This isn't quite true. Fast-clear without CCS compression (also known as CCS_D) is supported on gen9. There is, however, a bug with blending and non-0/1 clear colors that we don't currently bother handling in anv. See also:

Re: [Mesa-dev] [PATCH 1/2] radv/query: Add a nir_flag_set helper

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 4:06 PM Bas Nieuwenhuizen wrote: > On Wed, Dec 19, 2018 at 8:45 PM Jason Ekstrand > wrote: > > > > This is little more than an iadd_imm right now but it will help in the > > next commit where we refactor things further. > > --- > &g

[Mesa-dev] [PATCH v2 2/2] radv/query: Use 1-bit booleans in query shaders

2018-12-19 Thread Jason Ekstrand
Fixes: 44227453ec03f "nir: Switch to using 1-bit Booleans for almost..." Reviewed-by: Rhys Perry --- src/amd/vulkan/radv_query.c | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c

Re: [Mesa-dev] [PATCH 01/16] glsl/nir: int constants as float for native_integers=false

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 12:22 PM Eric Anholt wrote: > Jonathan Marek writes: > > > Note: the backend must take care that uniform index is now a float > > This makes me think that lowering ints to float should be done near the > end of the compile (followed by maybe an algebraic and a dce). As

[Mesa-dev] [PATCH 2/2] radv/query: Use 1-bit booleans in query shaders

2018-12-19 Thread Jason Ekstrand
Fixes: 44227453ec03f "nir: Switch to using 1-bit Booleans for almost..." --- src/amd/vulkan/radv_query.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c index

[Mesa-dev] [PATCH 0/2] radv/query: Use 1-bit booleans in query shaders

2018-12-19 Thread Jason Ekstrand
rewrite them if appropriate). Cc: Dave Airlie Cc: Timothy Arceri Cc: Bas Nieuwenhuizen Jason Ekstrand (2): radv/query: Add a nir_flag_set helper radv/query: Use 1-bit booleans in query shaders src/amd/vulkan/radv_query.c | 67 +++-- 1 file changed, 34

[Mesa-dev] [PATCH 1/2] radv/query: Add a nir_flag_set helper

2018-12-19 Thread Jason Ekstrand
This is little more than an iadd_imm right now but it will help in the next commit where we refactor things further. --- src/amd/vulkan/radv_query.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_query.c

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 1:12 PM Alan Swanson wrote: > On Mon, 2018-12-17 at 16:16 +, Rhys Perry wrote: > > Signed-off-by: Rhys Perry > > --- > > src/compiler/nir/nir_opt_peephole_select.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Mesa-dev] [PATCH v2 11/53] compiler/spirv: use 32-bit polynomial approximation for 16-bit asin()

2018-12-19 Thread Jason Ekstrand
I've sent a nit or two but the first 11 patches are Reviewed-by: Jason Ekstrand I'd be very happy for you to push them ahead of the rest of the series so they don't end up in a v3 unless someone else requests significant changes. On Wed, Dec 19, 2018 at 5:51 AM Iago Toral Quiroga wrote

Re: [Mesa-dev] [PATCH v2 09/53] compiler/spirv: implement 16-bit hyperbolic trigonometric functions

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 5:51 AM Iago Toral Quiroga wrote: > v2: > - use nir_fadd_imm and nir_fmul_imm helpers (Jason) > --- > src/compiler/spirv/vtn_glsl450.c | 44 +++- > 1 file changed, 26 insertions(+), 18 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 04/53] compiler/spirv: implement 16-bit asin

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 5:51 AM Iago Toral Quiroga wrote: > v2: > - use nir_fmul_imm and nir_fadd_imm helpers (Jason) > --- > src/compiler/spirv/vtn_glsl450.c | 23 ++- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/src/compiler/spirv/vtn_glsl450.c >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 10:32 AM Ilia Mirkin wrote: > On Wed, Dec 19, 2018 at 11:03 AM Jason Ekstrand > wrote: > > > > On Wed, Dec 19, 2018 at 9:32 AM Ilia Mirkin > wrote: > >> > >> On Wed, Dec 19, 2018 at 10:25 AM Matt Turner > wrote: > >> &

Re: [Mesa-dev] [PATCH v2 02/53] compiler/nir: add nir_fadd_imm() and nir_fadd_imm() helpers

2018-12-19 Thread Jason Ekstrand
The commit message says fadd twice. On Wed, Dec 19, 2018 at 5:51 AM Iago Toral Quiroga wrote: > --- > src/compiler/nir/nir_builder.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h > b/src/compiler/nir/nir_builder.h > index

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-19 Thread Jason Ekstrand
On Tue, Dec 18, 2018 at 2:51 AM Juan A. Suarez Romero wrote: > On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote: > > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero > > wrote: > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > > Cc: Emil Velikov > > > > Cc:

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Jason Ekstrand
On Wed, Dec 19, 2018 at 9:32 AM Ilia Mirkin wrote: > On Wed, Dec 19, 2018 at 10:25 AM Matt Turner wrote: > > > > On Wed, Dec 19, 2018 at 8:06 AM Ilia Mirkin > wrote: > > > > > > On Wed, Dec 19, 2018 at 1:01 AM Matt Turner > wrote: > > > > WTF would you have us do? > > > > > > Same thing as

Re: [Mesa-dev] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

2018-12-19 Thread Jason Ekstrand
Rb On December 19, 2018 02:15:59 Iago Toral Quiroga wrote: The former expects to see SSA-only things, but the latter injects registers. The assertions in the lowering where not seeing this because they asserted on the bit_size values only, not on the is_ssa field, so add that assertion too.

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Jason Ekstrand
that the validator doesn't complain. However, most passes are only set up to handle one type of Boolean so it's far safer if everything is 1-bit prior to lowering. Otherwise you may find yourself fixing a lot of these. --Jason On Wed, 19 Dec 2018 at 00:59, Jason Ekstrand wrote: Seems reasonable

Re: [Mesa-dev] [PATCH] nir: create 32-bit bcsel for 32-bit conditions

2018-12-18 Thread Jason Ekstrand
Seems reasonable though I'm a bit surprised your running peephole_select after lowering booleans. On December 18, 2018 18:16:46 Timothy Arceri wrote: Reviewed-by: Timothy Arceri On 18/12/18 3:16 am, Rhys Perry wrote: Signed-off-by: Rhys Perry ---

[Mesa-dev] [PATCH 3/7] nir/lower_io_arrays_to_elements: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 13 - 1

[Mesa-dev] [PATCH 6/7] nir/copy_prop_vars: Get modes directly from derefs

2018-12-17 Thread Jason Ekstrand
Instead of going all the way back to the variable, just look at the deref. The modes are guaranteed to be the same by nir_validate whenever the variable can be found. This fixes apply_barrier_for_modes for derefs that don't have an accessible variable. ---

[Mesa-dev] [PATCH 7/7] nir/dead_write_vars: Get modes directly from derefs

2018-12-17 Thread Jason Ekstrand
Instead of going all the way back to the variable, just look at the deref. The modes are guaranteed to be the same by nir_validate whenever the variable can be found. This fixes clear_unused_for_modes for derefs that don't have an accessible variable. ---

[Mesa-dev] [PATCH 5/7] nir/lower_wpos_center: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_wpos_center.c | 6 -- 1 file changed, 4

[Mesa-dev] [PATCH 0/7] nir: Prepare various passes for cast derefs

2018-12-17 Thread Jason Ekstrand
as making pass bail a tiny bit earlier by checking the deref mode before looking for the variable. Cc: Timothy Arceri Jason Ekstrand (7): nir/propagate_invariant: Skip unknown vars nir/linking_helpers: Look at derefs for modes nir/lower_io_arrays_to_elements: Look at derefs for modes nir

[Mesa-dev] [PATCH 4/7] nir/lower_io_to_scalar: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_io_to_scalar.c | 9 ++--- 1 file changed, 6

[Mesa-dev] [PATCH 2/7] nir/linking_helpers: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_linking_helpers.c | 23 +++ 1 file

[Mesa-dev] [PATCH 1/7] nir/propagate_invariant: Skip unknown vars

2018-12-17 Thread Jason Ekstrand
If we can't find the variable from the deref, just assume it isn't invariant and continue on. This can happen if, for instance, we're writing to a deref that points into an SSBO. --- src/compiler/nir/nir_propagate_invariant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 10, 2018 at 10:28 PM Timothy Arceri wrote: > If we are outputting the same value to more than one output > component rewrite the inputs to read from a single component. > > This will allow the duplicate varying components to be optimised > away by the existing opts. > > shader-db

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand wrote: > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt wrote: > >> Jason Ekstrand writes: >> >> > I don't know if it was actually in the doc that Jordan wrote up but it's >> > courteous of you to send a quick

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt wrote: > Jason Ekstrand writes: > > > I don't know if it was actually in the doc that Jordan wrote up but it's > > courteous of you to send a quick e-mail to the mailing list when you > create > > a new MR so that people wh

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 8:54 AM Eero Tamminen wrote: > Hi, > > On 17.12.2018 8.08, Marek Olšák wrote: > [...] > > I think one of the serious usability issues is that environment > > variables such as CFLAGS, CXXFLAGS, LDFLAGS, and PKG_CONFIG_PATH are not > > saved by meson for future

[Mesa-dev] [PATCH] anv: Bump the patch version to 96

2018-12-17 Thread Jason Ekstrand
--- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index b6269d0047a..a0bf4127002 100644 --- a/src/intel/vulkan/anv_extensions.py +++

Re: [Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.96

2018-12-17 Thread Jason Ekstrand
Thanks! Both pushed. On Mon, Dec 17, 2018 at 9:45 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Reviewed-by: Lionel Landwerlin > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/2] anv,radv: Re-enable VK_EXT_pci_bus_info

2018-12-17 Thread Jason Ekstrand
Now at version 2 with the fixed header. --- src/amd/vulkan/radv_extensions.py | 2 +- src/intel/vulkan/anv_extensions.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py index ae5e6950f1e..8ac8ae6698c

[Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.96

2018-12-17 Thread Jason Ekstrand
--- include/vulkan/vulkan_core.h | 16 src/vulkan/registry/vk.xml | 22 +++--- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/vulkan/vulkan_core.h b/include/vulkan/vulkan_core.h index 50064109ef3..72542c72ec8 100644 ---

Re: [Mesa-dev] [PATCH] nir/constant_folding: fix incorrect bit-size check

2018-12-17 Thread Jason Ekstrand
On December 17, 2018 06:09:36 "Juan A. Suarez Romero" wrote: On Wed, 2018-10-31 at 12:18 +0100, Iago Toral Quiroga wrote: nir_alu_type_get_type_size takes a type as parameter and we were passing a bit-size instead, which did what we wanted by accident, since a bit-size of zero matches

  1   2   3   4   5   6   7   8   9   10   >