Re: [Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-04-02 Thread Lin, Johnson
Guy, Then how can we deal with android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F It is blocked by this error check.. -Original Message- From: Palli, Tapani Sent: Tuesday, April 3, 2018 1:42 PM To: Eric Anholt ; Lin, Johnson ; mesa-dev@lists.freedesktop.org Subject: Re

[Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-26 Thread Lin Johnson
Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest v2: remove commtens of Ext_color_buffer_half_float. As Ext_color_buffer__float can use type GL_HALF_FLOAT Reviewed-by: Palli, Tapani Signed-off-by: Lin

[Mesa-dev] [PATCH v2] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-26 Thread Lin Johnson
Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest v2: remove commtens of Ext_color_buffer_half_float. As Ext_color_buffer__float can use type GL_HALF_FLOAT Reviewed-by: Palli, Tapani Signed-off-by: Lin

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-25 Thread Lin, Johnson
Cool. Thanks. Will update the patch. -Original Message- From: Palli, Tapani Sent: Friday, March 23, 2018 4:59 PM To: Lin, Johnson ; Alejandro Piñeiro ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT On 03/23/2018 07:54 AM

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-22 Thread Lin, Johnson
So the solution will be query if EXT_color_buffer_half_float is supported? -Original Message- From: Palli, Tapani Sent: Friday, March 23, 2018 1:53 PM To: Lin, Johnson ; Alejandro Piñeiro ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] mesa: readpixels add support for

Re: [Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-21 Thread Lin, Johnson
Hi, Thanks for the comments. I just noticed it does not check the extension support for EXT_color_buffer_float neither? -Original Message- From: Palli, Tapani Sent: Wednesday, March 21, 2018 6:57 PM To: Alejandro Piñeiro ; Lin, Johnson ; mesa-dev@lists.freedesktop.org Subject: Re

[Mesa-dev] [PATCH] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-20 Thread Lin Johnson
Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest #TestWindowProducerCopyToRGBA16F Signed-off-by: Lin Johnson --- src/mesa/main/readpix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH v4 1/3] dri: Add UYVY as available format

2017-06-21 Thread Lin, Johnson
@Kristian -Original Message- From: Lin, Johnson Sent: Thursday, June 22, 2017 11:28 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject: [PATCH v4 1/3] dri: Add UYVY as available format UYVY is diffrent with YUYV in byte order. YUYV is already declared in dri_interface.h

[Mesa-dev] FW: [PATCH v3 2/3] nir: Add a lowering pass for UYVY textures

2017-06-20 Thread Lin, Johnson
Kristian, Thanks for reviewing. You are right. I had a swap in DRI formats which I have fixed in patch3. So the order is corrected here. -Original Message- From: Lin, Johnson Sent: Wednesday, June 21, 2017 11:24 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject: [PATCH v3

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-20 Thread Lin, Johnson
oegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of Kristian Høgsberg Sent: Wednesday, June 21, 2017 12:50 AM To: Lin, Johnson Cc: mesa-dev@lists.freedesktop.org Subject: Re: [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures On Mon, Jun 19, 2017 at 7:07 PM, Lin, Johnson wrote: >

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-19 Thread Lin, Johnson
Kristian, Thanks for the review comments. By my tests, UYVY buffer can be sampled and rendered correctly. So there is no swap of U/V channel here. -Original Message- From: Lin, Johnson Sent: Tuesday, June 20, 2017 9:43 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-05-02 Thread Lin, Johnson
Thanks for the comments and have updated the patch! -Original Message- From: Matt Turner [mailto:matts...@gmail.com] Sent: Wednesday, May 3, 2017 2:37 AM To: Lin, Johnson Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader

2017-04-28 Thread Lin, Johnson
Yes, We can. Will do it -Original Message- From: Eric Anholt [mailto:e...@anholt.net] Sent: Saturday, April 29, 2017 6:02 AM To: Lin, Johnson ; mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject: Re: [Mesa-dev] [PATCH] fix minor error in YUV2RGB matrix used in shader Johnson Lin