Re: [Mesa-dev] [PATCH 1/4] nv50ir: fix memset on non trivial types warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 4 +--- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- > src/gallium/drive

Re: [Mesa-dev] [PATCH 3/4] nv50ir/nir: comparison of integer expressions of different signedness warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH 2/4] nv50ir: fix unnecessary parentheses warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/c

[Mesa-dev] [PATCH] nv50, nvc0: add missing CAPs for unsupported features

2019-01-19 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c index

[Mesa-dev] [MR] nv50, nvc0: add missing CAPs for unsupported features

2019-01-19 Thread Rhys Kidd
nouveau warns on unhandled pipe CAPs, including where they may be set by u_pipe_screen_get_param_defaults() This patch avoids spurious text in debug outputs, e.g. when running piglit. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/133 Rhys

Re: [Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

2019-01-08 Thread Rhys Kidd
On Tue, 11 Dec 2018 at 10:22, Jon Turney wrote: > Restore optional xf86vidmode, and fix the meson build to actually use it. > > Jon Turney (2): > Revert "glx: make xf86vidmode mandatory for direct rendering" > Fix typo preventing xxf86vm being used in meson build > Jon I don't believe these

Re: [Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-12-20 Thread Rhys Kidd
Awesome, thanks! Apologies that I was unable to get around to looking at your feedback in the intervening period of time. On Thu, Dec 20, 2018 at 2:34 PM Eric Anholt wrote: > Eric Anholt writes: > > > [ Unknown signature status ] > > Rhys Kidd writes: > > >

[Mesa-dev] [PATCH] iris: Fix assertion in iris_resource_from_handle() tiling usage

2018-12-16 Thread Rhys Kidd
p glx/glx-visuals-depth -pixmap glx/glx-visuals-stencil -pixmap spec/egl 1.4/eglcreatepbuffersurface and then glclear spec/egl 1.4/largest possible eglcreatepbuffersurface and then glclear spec/egl_nok_texture_from_pixmap/basic Cc: Kenneth Graunke Cc: Jason Ekstrand Signed-off-by: Rhys Kidd --- sr

Re: [Mesa-dev] [PATCH 00/18] Meson fixes and Travis integration

2018-12-13 Thread Rhys Kidd
up. > > Let me know what you think. > Emil > > Cc: Rhys Kidd > Cc: Dylan Baker > > For the series: Acked-by: Rhys Kidd > Dylan Baker (3): > travis: meson: use native files to override llvm-config > travis: Don't try to read libdrm out of configure.ac > tr

Re: [Mesa-dev] last call for autotools

2018-12-11 Thread Rhys Kidd
On Tue, 11 Dec 2018 at 16:46, Emil Velikov wrote: > On Tue, 11 Dec 2018 at 19:49, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-11 10:48:56) > > > On Tue, 11 Dec 2018 at 18:18, Eric Anholt wrote: > > > > > > > > Emil Velikov writes: > > > > > > > > > On Mon, 10 Dec 2018 at 23:11,

[Mesa-dev] [RFC PATCH 3/5] travis: radeonsi and radv require LLVM 7.0 (meson)

2018-12-11 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- .travis.yml | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 60ef236e7be..070c9ef6773 100644 --- a/.travis.yml +++ b/.travis.yml @@ -81,20 +81,21 @@ matrix: - VULKAN_DRIVERS

[Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-11 Thread Rhys Kidd
Error message building freedreno Gallium driver with meson: ../src/gallium/drivers/freedreno/freedreno_fence.c:27:21: fatal error: libsync.h: No such file or directory \#include Signed-off-by: Rhys Kidd --- src/gallium/drivers/freedreno/meson.build | 4 +--- 1 file changed, 1 insertion

[Mesa-dev] [RFC PATCH 2/5] travis: Add libclc-dev, clang and libclang-dev dependencies of clover

2018-12-11 Thread Rhys Kidd
Fixes: 98a3f027aaf ("travis: enable nine and clover") Signed-off-by: Rhys Kidd --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index aec1b001083..60ef236e7be 100644 --- a/.travis.yml +++ b/.travis.yml @@ -90,8 +90,11 @@ matrix:

[Mesa-dev] [RFC PATCH 1/5] travis: fix python3.5 dependency for "meson Gallium Drivers"

2018-12-11 Thread Rhys Kidd
debug log for failure in /home/travis/.pip/pip.log Fixes: 05edf75f42e ("wip") Signed-off-by: Rhys Kidd --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index fb86418b2b0..aec1b001083 100644 --- a/.travis.yml +++ b/.travis.yml @@ -

[Mesa-dev] [RFC PATCH 0/5] last call for autotools (meson travis fixes)

2018-12-11 Thread Rhys Kidd
chelon9/mesa/builds/466840665 * gallium pipeloaders: There's an ongoing scoping problem with the LLVM libraries as a dependency. I was unable to fix yet. See further here: https://travis-ci.org/Echelon9/mesa/jobs/466861661#L9112 Rhys Kidd (5): travis: fix python3.5 dependency for &q

[Mesa-dev] [RFC PATCH 4/5] travis: delete remaining scons residuals

2018-12-11 Thread Rhys Kidd
Fixes: 53d5129ded5 ("delete me: remove scons") Signed-off-by: Rhys Kidd --- .travis.yml | 12 1 file changed, 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index 070c9ef6773..442afea3a74 100644 --- a/.travis.yml +++ b/.travis.yml @@ -138,12 +138,6 @@ install:

[Mesa-dev] [PATCH] travis: radeonsi and radv require LLVM 7.0

2018-12-09 Thread Rhys Kidd
Fixes: 3fbdcd942fe ("amd: remove support for LLVM 6.0") Cc: Samuel Pitoiset Cc: Marek Olšák Cc: Emil Velikov Cc: Jan Vesely Cc: Andres Gomez Cc: Dylan Baker Signed-off-by: Rhys Kidd --- .travis.yml | 29 - 1 file changed, 16 insertions(+), 13 deletion

[Mesa-dev] [PATCH] nv50/ir: silence partitionLoadStore() unused function warning

2018-08-10 Thread Rhys Kidd
[2], uint8_t mask) Fixes: 86e4440361 ("nouveau: codegen: Disable more old resource handling code") Signed-off-by: Rhys Kidd Cc: Hans de Goede Cc: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 2/2] v3d: Wire up core pipe_debug_callback

2018-08-10 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- src/gallium/drivers/v3d/v3d_context.c | 13 + src/gallium/drivers/v3d/v3d_context.h | 1 + 2 files changed, 14 insertions(+) diff --git a/src/gallium/drivers/v3d/v3d_context.c b/src/gallium/drivers/v3d/v3d_context.c index 2fd2fa0bbf..0737713e8b 100644

[Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-08-10 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- src/gallium/drivers/vc4/vc4_context.c | 13 + src/gallium/drivers/vc4/vc4_context.h | 1 + 2 files changed, 14 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_context.c b/src/gallium/drivers/vc4/vc4_context.c index 9ff39c2655..6f91d0567c 100644

Re: [Mesa-dev] [PATCH 10/17] glsl/tests: Fix strict aliasing warning about int64/double.

2018-02-10 Thread Rhys Kidd
On 10 February 2018 at 11:33, Eric Anholt <e...@anholt.net> wrote: > Cc: Rhys Kidd <rhysk...@gmail.com> > Fixes: 4bf986274728 ("glsl/tests: Add UINT64 and INT64 types") > Reviewed-by: Rhys Kidd <rhysk...@gmail.com> > --- > .../glsl/tes

[Mesa-dev] [PATCH] i915: No longer rely on compatability define in intel_bufmgr.h

2018-01-16 Thread Rhys Kidd
Symbol rename from dri_* to drm_intel_* introduced a number of compatability defines within intel_bufmgr.h. Replace the old function with the new function, consistent with the balance of this file. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/mesa/drivers/dri/i915/intel_regions

Re: [Mesa-dev] [PATCH v2 0/3] nouveau compiler warning cleanups

2017-12-29 Thread Rhys Kidd
sh://git.freedesktop.org/git/mesa/mesa.git 878bc4a5ae..60c2d09483 master -> master > > On 2017-12-16 — 23:00, Rhys Kidd wrote: > > Couple of little compiler warning cleanups so that nouveau builds > without any > > warnings for meson's debug and release builds with gcc

[Mesa-dev] [PATCH v2 1/3] nv50: Fix unused var warning in release build

2017-12-16 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/nv50/nv98_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv98_video.c b/src/gallium/drivers/nouveau/nv50/nv98_video.c index 92526d9f64..da0267e646

[Mesa-dev] [PATCH v2 0/3] nouveau compiler warning cleanups

2017-12-16 Thread Rhys Kidd
Couple of little compiler warning cleanups so that nouveau builds without any warnings for meson's debug and release builds with gcc 7.2.0 v2: Add preventative comment (Ilia Mirkin) Rhys Kidd (3): nv50: Fix unused var warning in release build nvc0: Fix unused var warnings in release build

[Mesa-dev] [PATCH v2 2/3] nvc0: Fix unused var warnings in release build

2017-12-16 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video.c b/src/gallium/drivers/nouveau/nvc0/nvc0_video.c index b5e7bba5f9..5c1c

[Mesa-dev] [PATCH v2 3/3] nv50/ir: Fix unused var warnings in release build

2017-12-16 Thread Rhys Kidd
v2: Add preventative comment (Ilia Mirkin) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 4 +

[Mesa-dev] [PATCH 0/3] nouveau compiler warning cleanups

2017-12-02 Thread Rhys Kidd
Couple of little compiler warning cleanups so that nouveau builds without any warnings for meson's debug and release builds with gcc 7.2.0 Rhys Kidd (3): nv50: Fix unused var warning in release build nvc0: Fix unused var warnings in release build nv50/ir: Fix unused var warnings in release

[Mesa-dev] [PATCH 1/3] nv50: Fix unused var warning in release build

2017-12-02 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/nv50/nv98_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv98_video.c b/src/gallium/drivers/nouveau/nv50/nv98_video.c index 92526d9f64..da0267e646

[Mesa-dev] [PATCH 3/3] nv50/ir: Fix unused var warnings in release build

2017-12-02 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/c

[Mesa-dev] [PATCH 2/3] nvc0: Fix unused var warnings in release build

2017-12-02 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video.c b/src/gallium/drivers/nouveau/nvc0/nvc0_video.c index b5e7bba5f9..5c1c

Re: [Mesa-dev] [PATCH] meson: fix egl build for meson version < 0.43

2017-10-22 Thread Rhys Kidd
pi, > libmesa_util], >link_args : [ld_args_bsymbolic, ld_args_gc_sections], >dependencies : [deps_for_egl, dep_dl, dep_libdrm, dep_clock, > dep_thread], > -- > 2.14.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedeskto

Re: [Mesa-dev] [PATCH] build: Fix up spirv_info.Plo

2017-08-10 Thread Rhys Kidd
On 10 August 2017 at 12:46, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Thanks Matt. Patch is: > > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > It's a little late, but gets my: Tested-by: Rhys Kidd <rhysk...@gmail.com> Thanks Matt for fixing the o

Re: [Mesa-dev] [shader-db 0/3] Small README clean ups

2017-07-25 Thread Rhys Kidd
On 24 July 2017 at 23:42, Rhys Kidd <rhysk...@gmail.com> wrote: > Update or fix a few small items that I noticed when running through piglit > setup on a new development environment. > Ah, whoops. The subject prefix for this series should be [piglit] not [shader-db]. > >

[Mesa-dev] [shader-db 0/3] Small README clean ups

2017-07-24 Thread Rhys Kidd
there was a difference in the output format for no particular reason midway through. The change is not carried forward either past those two commands. This might be a difference without a distinction, but it draws unnececssary attention away when a user should be learning the principles. Rhys Kidd (3

[Mesa-dev] [shader-db 2/3] README: Correct typo deQP -> dEQP

2017-07-24 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index cb49516b7..56ea52b62 100644 --- a/README +++ b/README @@ -414,13 +414,13 @@ deqp_egl.py Support for running dEQP's EGL p

[Mesa-dev] [shader-db 1/3] README: Update the list of test profiles

2017-07-24 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- README | 30 ++ 1 file changed, 30 insertions(+) diff --git a/README b/README index 43bdfcae7..cb49516b7 100644 --- a/README +++ b/README @@ -386,6 +386,9 @@ glslparser.py shader.py A subset of all.py

[Mesa-dev] [shader-db 3/3] README: Make initial smoke tests steps internally consistent

2017-07-24 Thread Rhys Kidd
No other stage of the suggested initial sanity.py test or other tests uses a folder structure with *.results. Use a consistent naming approach throughout the initial README to make initial setup clearer. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- README | 4 ++-- 1 file chan

[Mesa-dev] [PATCH] nvc0: Clean up unnecessary includes from gallium/auxiliary/vl/

2017-05-31 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index f2ae4f3ae3..c636926994 100644 ---

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

2017-05-22 Thread Rhys Kidd
On Mon, May 22, 2017 at 1:07 PM Jose Fonseca <jfons...@vmware.com> wrote: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change s/does/doesn't/ With that commit message fix: Reviewed-by: Rhys Kidd <rhysk...@gm

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

2017-05-21 Thread Rhys Kidd
On 21 May 2017 at 19:33, Roland Scheidegger wrote: > I suppose the s3tc problems should go away rather sooner than later, but > isn't it possible to just disable the formats tests? > Yes, see USE_TXC_DXTN that was introduced in 29322daef2b77c4d869d2945fa1226e6b433c68 to

[Mesa-dev] [PATCH] vc4: Remove dead code in vc4_dump_surface_msaa()

2017-05-21 Thread Rhys Kidd
Coverity caught the use of dead code copy-paste for found_colors[] and num_found_colors. CID: 1341850 Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/vc4/vc4_resource.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c

[Mesa-dev] [PATCH shader-db] Add ".so" shared objects to .gitignore

2017-04-08 Thread Rhys Kidd
For intel_stubs.so Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- I don't have commit access, so I would appreciate a reviewer pushing this to master. .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index f69750a..95a04f6 100644 --- a/.gitignore

Re: [Mesa-dev] [PATCH 2/2] travis: add the txc-dxtn library so scons check can pass

2017-04-05 Thread Rhys Kidd
anholt.net> > Cc: Emil Velikov <emil.l.veli...@gmail.com> > Tested-by: Rhys Kidd <rhysk...@gmail.com> Although let's be clear that Travis is green because of the last line in the following from the log: scons: Building targets ... Running build/linux-x86_64-debug/util/u

Re: [Mesa-dev] [PATCH 1/2] travis: replace Trusty-based LLVM toolchain apt-get with apt addon

2017-04-05 Thread Rhys Kidd
;ago...@igalia.com> > Cc: Rhys Kidd <rhysk...@gmail.com> > Cc: Emil Velikov <emil.l.veli...@gmail.com> > With the link in the commit message pointing to the Trusty change [0], this gets my: Reviewed-by: Rhys Kidd <rhysk...@gmail.com> [0] ht

Re: [Mesa-dev] [PATCH 2/2] travis: add the txc-dxtn library so scons check can pass

2017-04-05 Thread Rhys Kidd
On Wed, Apr 5, 2017 at 1:49 PM Emil Velikov wrote: > On 5 April 2017 at 18:27, Andres Gomez wrote: > > The packaged libtxc-dxtn-s2tc0 will make scons check fail. Manually > > remove this package and install libtxc-dxtn instead. > > > Don't recall

Re: [Mesa-dev] [PATCH] travis: remove r600 as it requires llvm 3.8

2017-04-04 Thread Rhys Kidd
On 2 April 2017 at 17:26, Dave Airlie <airl...@gmail.com> wrote: > On 3 April 2017 at 06:44, Rhys Kidd <rhysk...@gmail.com> wrote: > > On 2 April 2017 at 08:42, Christian Gmeiner <christian.gmei...@gmail.com > > > > wrote: > >> > >> A

[Mesa-dev] [PATCH] travis: Add radv vulkan driver to continuous integration

2017-04-04 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index aa212b1..0b03ae7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -115,6 +115,7 @@ script: --with-egl-platforms=x11,drm --wi

[Mesa-dev] [PATCH] travis: Add radeonsi to continuous integration

2017-04-04 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index aa212b1..c0b2c1f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -114,7 +114,7 @@ script: ./autogen.sh --enable

[Mesa-dev] [PATCH] travis: Support LLVM 3.8+ on Trusty-based Travis-CI via apt-get not apt addon

2017-04-02 Thread Rhys Kidd
-environment/#Fully-virtualized-via-sudo%3A-required https://github.com/travis-ci/apt-source-whitelist/pull/205#issuecomment-216054237 Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- .travis.yml | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/.travis

Re: [Mesa-dev] [PATCH] travis: remove r600 as it requires llvm 3.8

2017-04-02 Thread Rhys Kidd
On 2 April 2017 at 08:42, Christian Gmeiner wrote: > At the moment travis ci failes with the following error: > > checking for RADEON... yes > checking for RADEON... yes > configure: error: LLVM 3.8.0 or newer is required for r600 > make: *** No targets specified and

Re: [Mesa-dev] [PATCH] travis: bring the scons build on par with AppVeyor

2017-02-18 Thread Rhys Kidd
On 16 February 2017 at 09:09, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Namely, always build with LLVM and run the check target. > > Cc: Rhys Kidd <rhysk...@gmail.com> > Cc: Eric Anholt <e...@an

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-13 Thread Rhys Kidd
before asking for it to be merged. > On Sat, Feb 11, 2017 at 05:31:09PM -0500, Rhys Kidd wrote: > > glsl/tests/uniform_initializer_utils.cpp:83:14: warning: enumeration > value ‘GLSL_TYPE_UINT64’ not handled in switch [-Wswitch] > >switch (type->base_type) { > >

[Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

2017-02-11 Thread Rhys Kidd
tch [-Wswitch] Fixes: 8ce53d4a2f3 ("glsl: Add basic ARB_gpu_shader_int64 types") Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/compiler/glsl/tests/uniform_initializer_utils.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/

Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

2017-02-02 Thread Rhys Kidd
On 2 February 2017 at 02:53, Andres Gomez <ago...@igalia.com> wrote: > LGTM > > Reviewed-by: Andres Gomez <ago...@igalia.com> > Reviewed-by: Rhys Kidd <rhysk...@gmail.com> > > On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > > From

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-30 Thread Rhys Kidd
On Sun, Jan 22, 2017 at 1:49 PM Rhys Kidd <rhysk...@gmail.com> wrote: > On 20 January 2017 at 17:06, Christian Gmeiner < > christian.gmei...@gmail.com> wrote: > > Hi Rhys, > > 2017-01-19 7:02 GMT+01:00 Rhys Kidd <rhysk...@gmail.com>: > > Use of unsign

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-22 Thread Rhys Kidd
On 20 January 2017 at 17:06, Christian Gmeiner <christian.gmei...@gmail.com> wrote: > Hi Rhys, > > 2017-01-19 7:02 GMT+01:00 Rhys Kidd <rhysk...@gmail.com>: > > Use of unsigned loop control variable with '>= 0' would lead to infinite > loop. > > > >

[Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-18 Thread Rhys Kidd
>= 0; sp--) ~~ ^ ~ Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I compile tested etnaviv but have not functionally tested on real hardware. diff --git a/src/galli

Re: [Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-13 Thread Rhys Kidd
On 13 January 2017 at 02:05, Christian Gmeiner <christian.gmei...@gmail.com> wrote: > 2017-01-13 5:06 GMT+01:00 Rhys Kidd <rhysk...@gmail.com>: > > Signed-off-by: Rhys Kidd <rhysk...@gmail.com> > > --- > > .travis.yml | 6 +++--- > > 1 file changed,

[Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-12 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3d107aa..dfbc052 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,7 +32,7 @@ env: - DRI3PROTO_VERSION=dri3pro

Re: [Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test

2016-10-27 Thread Rhys Kidd
> > On Wed, 2016-10-26 at 00:13 -0400, Rhys Kidd wrote: > > Fixes the following compile error, present when the SHA1 library is > > libgcrypt: > > > > CCLD glsl/tests/cache-test > > glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function > > `c

[Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test

2016-10-25 Thread Rhys Kidd
-by: Rhys Kidd <rhysk...@gmail.com> --- v2: Add additional comment to the commit message (Timothy Arceri) src/compiler/Makefile.glsl.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/Makefile.glsl.am b/src/compiler/Makefile.glsl.am index 80dfb73..15bea6b

[Mesa-dev] [PATCH] glsl: Add pthread libs to cache_test

2016-10-22 Thread Rhys Kidd
Fixes the following compile error: CCLD glsl/tests/cache-test glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function `call_once': /mesa/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once' Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --

Re: [Mesa-dev] [PATCH] vulkan: Initial partial documentation for Vulkan internals.

2016-10-14 Thread Rhys Kidd
On 14 October 2016 at 10:36, wrote: > From: Kevin Rogovin > > A main page ala Doxygen together with a Doxygen file added. > In addition, documentation for portions of anv_private.h: > - placing portions into doxygen groups > - some cross

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

2016-09-11 Thread Rhys Kidd
On 27 August 2016 at 01:09, Nicholas Bishop wrote: > Hi, > > I'd like to propose a conversion of Mesa's documentation to > reStructuredText (RST) and hosting the result on readthedocs.org. The > intent is to make Mesa's documentation more accessible, searchable, and >

Re: [Mesa-dev] [PATCH 2/2] r600g: Clean up defined magic numbers for TGSI opcodes

2016-08-29 Thread Rhys Kidd
d please push to master. Regards, Rhys > > On Sat, Aug 27, 2016 at 6:05 PM, Rhys Kidd <rhysk...@gmail.com > <javascript:;>> wrote: > > Small code clean up that removes magic numbers where a TGSI > > opcode has been defined. > > > > No functiona

Re: [Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

2016-08-29 Thread Rhys Kidd
On Monday, August 29, 2016, James Harvey <lothmor...@gmail.com> wrote: > Hi Rhys, > > I ran piglit on my Evergreen HD5850 with your patches. > > No regressions here. > > Tested-by: James Harvey <lothmor...@gmail.com> Thanks James. > > Thanks, > Jam

Re: [Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

2016-08-28 Thread Rhys Kidd
On Saturday, August 27, 2016, Jan Vesely <jan.ves...@rutgers.edu> wrote: > On Sat, 2016-08-27 at 12:05 -0400, Rhys Kidd wrote: > > As reported by Clang, TGSI_OPCODE_DFMA (defined magic number 118) is > > currently initialized twice for Cayman and Evergreen. > > W

[Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

2016-08-27 Thread Rhys Kidd
this so would appreciated Tested-by's. I do not have commit rights to fd.o so after R-B would appreciate if the reviewer(s) could push to master. Rhys Kidd (2): r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA r600g: Clean up defined magic numbers for TGSI opcodes src/gallium

[Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

2016-08-27 Thread Rhys Kidd
.@gmail.com> Signed-off-by: Marek Olšák <marek.ol...@amd.com> Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/r600/r600_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/

[Mesa-dev] [PATCH 2/2] r600g: Clean up defined magic numbers for TGSI opcodes

2016-08-27 Thread Rhys Kidd
Small code clean up that removes magic numbers where a TGSI opcode has been defined. No functional change expected as each opcode is unsupported on the respective hardware. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/r600/r600_shader.c | 14 +++--

[Mesa-dev] [PATCH] gallium/ttn: Remove duplicated TGSI_OPCODE_DP2A initialization

2016-08-23 Thread Rhys Kidd
Duplicate line is currently on 1535. Identified by Clang, when run through Eric Anholt's Travis harness. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c

Re: [Mesa-dev] [PATCH 0/4] Travis CI build fixes

2016-08-23 Thread Rhys Kidd
anged, 20 insertions(+), 8 deletions(-) > > -- > 2.8.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > The series gets my Reviewed-by: Rhys Kidd <rhysk...@gmail.com> ___

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

2016-07-15 Thread Rhys Kidd
Whilst I don't know that code as well as I'd like. It does get my Tested-by: Rhys Kidd <rhysk...@gmail.com> for fixing that piglit on i965 ILK. Thanks for the two patches! On 15 July 2016 at 04:28, Nicolas Boichat <drink...@chromium.org> wrote: > android.opengl.cts.WrapperTest#t

Re: [Mesa-dev] [PATCH 1/2] i965/gen4: Pull texture formats from the texture object not the miptree

2016-06-22 Thread Rhys Kidd
slate_tex_format(brw, intelObj->_Format, >sampler->sRGBDecode); > > if (tObj->Target == GL_TEXTURE_EXTERNAL_OES) { > > For what it is worth, this series is: Reviewed-by: Rhys Kidd <rhysk...@gmail.com> Tested-by: Rhys Kidd

Re: [Mesa-dev] [GSoC lib soft float] Blog update

2016-06-15 Thread Rhys Kidd
On Monday, June 13, 2016, tournier.elie wrote: > Hi, > > After a few weeks of coding, I wrote a new post on my blog ( > https://hopetech.github.io/). I speak about the progress of my project, > the difficulties encountered and the tools I use. > > Happy reading, > Elie >

Re: [Mesa-dev] [PATCH] vc4: Fix failed instruction path of QIR validate pass

2016-05-27 Thread Rhys Kidd
On 19 May 2016 at 23:17, Rhys Kidd <rhysk...@gmail.com> wrote: > Correct use of qir_dump_inst() within QIR validate pass. > > Reported by the following GCC warning: > > mesa/src/gallium/drivers/vc4/vc4_qir_validate.c: In function 'fail_instr': > mesa/src/gallium/drivers/v

[Mesa-dev] [PATCH 2/2] vc4: Fix doxygen warnings

2016-05-25 Thread Rhys Kidd
Now that vc4 automated code documentation can be generated with doxygen, fix the warnings issued by Doxygen 1.8.11. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/vc4/vc4_qir_schedule.c | 4 ++-- src/gallium/drivers/vc4/vc4_tiling.c | 8 2 files chan

[Mesa-dev] [PATCH 0/2] vc4: Add automated code documentation

2016-05-25 Thread Rhys Kidd
Simple patchset to provide doxygen-based automated code documentation of the vc4 driver for developers. By plumbing this through we get the same for all Gallium-based drivers for free. Post review I will need someone with Mesa commit access to push these for me. Rhys Kidd (2): doxygen: Plumb

[Mesa-dev] [PATCH 1/2] doxygen: Plumb through gallium/ to automated documentation

2016-05-25 Thread Rhys Kidd
-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doxygen/Makefile b/doxygen/Makefile index 6685b99..e5fac32 100644 --- a/doxygen/Makefile +++ b/doxygen/Makefile @@ -25,7 +25,8 @@ full: $(FULL:.doxy=.tag)

Re: [Mesa-dev] [PATCH v2] doxygen: Add missing modules to Windows runner

2016-05-20 Thread Rhys Kidd
On 11 May 2016 at 07:51, Rhys Kidd <rhysk...@gmail.com> wrote: > On 10 May 2016 at 16:04, Elie TOURNIER <tournier.e...@gmail.com> wrote: > >> --- >> doxygen/doxy.bat | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/doxygen/doxy.

[Mesa-dev] [PATCH] vc4: Fix failed instruction path of QIR validate pass

2016-05-19 Thread Rhys Kidd
(struct vc4_compile *c, struct qinst *inst); ^ Introduced in 8e2d0843c02daf5280184f179ae8ed440ac90d7f. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/gallium/drivers/vc4/vc4_qir_validate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] doxygen: Add missing modules to Windows runner

2016-05-11 Thread Rhys Kidd
h (passing the '-s' or '--signoff' parameter to git format-patch). Shouldn't be a need to send a v3 for this patch as you did do so on your v1. Whomever pushes the patch can add that for you I'd expect. Whilst I don't have a Windows development environment to test t

Re: [Mesa-dev] [PATCH 1/2] i965: Reduce the SIMD8 GS push constant threshold from 32 to 24.

2016-05-10 Thread Rhys Kidd
Hello Kenneth, On 10 May 2016 at 03:46, Kenneth Graunke wrote: > Three Shadow of Mordor geometry shaders increase by a single > instruction, but the number of spills/fills in Orbital Explorer > is reduced from 194:1279 -> 82:454. No other programs are affected. > >

Re: [Mesa-dev] [PATCH] Update Doxygen for Windows users

2016-04-20 Thread Rhys Kidd
On 20 April 2016 at 01:46, Elie TOURNIER wrote: > Now Windows users have the same doxygen files than *nix users > Not tested (I don't have a windows) > > Signed-off-by: Elie TOURNIER > --- > doxygen/doxy.bat | 7 +++ > 1 file changed, 7

[Mesa-dev] [PATCH] glsl: Update hash table comments in constant propagation

2016-04-10 Thread Rhys Kidd
Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- src/compiler/glsl/opt_constant_propagation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/glsl/opt_constant_propagation.cpp index 416ba16..4764d16

[Mesa-dev] [PATCH 8/9] doxygen: Fix typo in doxygen/tnl.doxy

2016-04-09 Thread Rhys Kidd
TAGFILE relative folder should match .tag file Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/tnl.doxy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doxygen/tnl.doxy b/doxygen/tnl.doxy index b985b8d..e6d6572 100644 --- a/doxygen/tnl.doxy +++ b/doxygen/tn

[Mesa-dev] [PATCH 5/9] doxygen: Remove references to miniglx

2016-04-09 Thread Rhys Kidd
miniglx was removed in February 2010. Clean up remaining unnecessary doxygen references. commit a9e36696837b2c31ecee4017a0adffbd987c1eff Author: Kristian Høgsberg <k...@bitplanet.net> Date: Thu Feb 25 16:17:04 2010 -0500 Remove remaining miniglx references Signed-off-by: Rhy

[Mesa-dev] [PATCH 9/9] doxygen: Remove deprecated settings in common.doxy

2016-04-09 Thread Rhys Kidd
this line from your configuration file or upgrade it using "doxygen -u" Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/common.doxy | 51 --- 1 file changed, 51 deletions(-) diff --git a/doxygen/common.doxy b/doxygen/commo

[Mesa-dev] [PATCH 2/9] doxygen: Fix doxygen/glapi.doxy

2016-04-09 Thread Rhys Kidd
es1api,es2api}. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/glapi.doxy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doxygen/glapi.doxy b/doxygen/glapi.doxy index 3290f84..0e169e4 100644 --- a/doxygen/glapi.doxy +++ b/doxygen/glapi.doxy @@ -9,7 +9,7 @@

[Mesa-dev] [PATCH 3/9] doxygen: Correct TAGFILE relative paths

2016-04-09 Thread Rhys Kidd
a relative path it should be relative with respect to the directory where the HTML output of your project is generated; so a relative path from the HTML output directory of a project to the HTML output of the other project that is linked to. Signed-off-by: Rhys Kidd <rhysk...@gmail.

[Mesa-dev] [PATCH 6/9] doxygen: Update .gitignore

2016-04-09 Thread Rhys Kidd
' with 'main'. Other minor updates. commit 69db632a9df035cdc852cc64fb14038919929a70 Author: Jose Fonseca <j_r_fons...@yahoo.co.uk> Date: Thu May 1 23:32:54 2003 + Move the Doxygen configuration files into the usual places and integrate with the build system. Signed-off-by

[Mesa-dev] [PATCH 7/9] doxygen: Correct TAGFILE linkage of main

2016-04-09 Thread Rhys Kidd
2 2004 + Replaced 'core' with 'main'. Other minor updates. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/gbm.doxy | 2 +- doxygen/glapi.doxy| 2 +- doxygen/math.doxy | 2 +- doxygen/swrast.doxy | 2 +- doxygen/swrast_setup.doxy | 2

[Mesa-dev] [PATCH 4/9] doxygen: Fix doxygen/gbm.doxy TAGFILES

2016-04-09 Thread Rhys Kidd
There has never been a doxygen/gbm_setup output folder. Appears to have been a copy-paste error from original commit in 245341f406bbdf23fec3d8ea8ad95c147c11ad1c. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/gbm.doxy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 1/9] doxygen: Remove src/mesa/shader/ references

2016-04-09 Thread Rhys Kidd
in the consolidated Doxygen output caused by doxygen/shader.doxy inadvertently overwriting doxygen/swrast.tag via its GENERATE_TAGFILE setting. This bug depended upon the specific order each *.tag was built. Signed-off-by: Rhys Kidd <rhysk...@gmail.com> --- doxygen/.gitignore | 1 - d

[Mesa-dev] [PATCH 0/9] doxygen: Clean up configuration file bit rot

2016-04-09 Thread Rhys Kidd
recent work in this area. Hopefully also assists in getting the right eyes reviewing the patchset. Rhys Kidd (9): doxygen: Remove src/mesa/shader/ references doxygen: Fix doxygen/glapi.doxy doxygen: Correct TAGFILE relative paths doxygen: Fix doxygen/gbm.doxy TAGFILES doxygen: Remove

Re: [Mesa-dev] Updating mesa3d.org docs?

2016-04-09 Thread Rhys Kidd
On 9 April 2016 at 16:19, Brian Paul <bri...@vmware.com> wrote: > On 04/09/2016 01:09 PM, Rhys Kidd wrote: > >> On Thursday, October 15, 2015, Brian Paul <bri...@vmware.com >> <mailto:bri...@vmware.com>> wrote: >> >> On 10/15/2015 01:

Re: [Mesa-dev] Updating mesa3d.org docs?

2016-04-09 Thread Rhys Kidd
On Thursday, October 15, 2015, Brian Paul wrote: > On 10/15/2015 01:18 PM, Sarah Sharp wrote: > >> Hi Brian! >> > > Hi Sarah, > > > I'm a new Mesa developer in Intel's OTC graphics team (although not new >> to open source, I've been a Linux kernel developer for the last seven

Re: [Mesa-dev] [PATH v2] doxygen: Generate Doxygen for NIR

2016-04-09 Thread Rhys Kidd
LGTM, Reviewed-by: Rhys Kidd <rhysk...@gmail.com> On Saturday, April 9, 2016, Elie TOURNIER <tournier.e...@gmail.com> wrote: > Now, one can do the following to generate and read the nir Doxygen: > cd $MESA_TOP/doxygen > make > firefox nir/index.html > > Update v2:

Re: [Mesa-dev] [PATCH] doxygen: Generate Doxygen for NIR

2016-04-09 Thread Rhys Kidd
math.tag=../math \ > + swrast.tag=../swrast \ > + swrast_setup.tag=../swrast_setup \ > + tnl.tag=../tnl \ > + tnl_dd.tag=../tnl_dd \ > + vbo.tag=vbo > With the abo

  1   2   3   >