This patch is
Reviewed-by: Robert Foss
On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote:
Via the prototyping cycle, a substantial amount of dead code and other
cruft has accumulated in the Panfrost tree, which is a burden for both
maintenance and aesthetic.
This patch series removes dead code when
On 2/10/19 6:58 PM, Robert Foss wrote:
This patch is
s/patch/series
Reviewed-by: Robert Foss
On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote:
Via the prototyping cycle, a substantial amount of dead code and other
cruft has accumulated in the Panfrost tree, which is a burden for both
maintenance
This patch has been:
Reviewed-by: Robert Foss
On 2018-11-27 20:50, Gert Wollny wrote:
From: Gert Wollny
vtest doesn't implement the according API and would segfault:
Program received signal SIGSEGV, Segmentation fault.
#0 0x in ?? ()
#1 in virgl_fence_server
This patch has been:
Reviewed-by: Robert Foss
On 2018-11-27 20:50, Gert Wollny wrote:
From: Gert Wollny
Avoids:
Conditional jump or move depends on uninitialised value(s)
at 0x9E2B39F: virgl_vtest_winsys_resource_cache_create
(virgl_vtest_winsys.c:379)
by 0x9E2725F
Verify the pipe_fd_type to be of PIPE_FD_TYPE_NATIVE_SYNC.
Suggested-by: Eric Engestrom
Signed-off-by: Robert Foss
---
src/gallium/drivers/virgl/virgl_context.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_context.c
b/src/gallium
Hey Eric,
On 2018-11-20 13:36, Eric Engestrom wrote:
Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support"
Cc: Robert Foss
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
I don't know if something should be done with the fd type in this
function, so one of you mig
Hey Dave,
Thanks for catching this, pushed!
On 2018-11-19 06:47, Dave Airlie wrote:
From: Dave Airlie
The in_fence_fd needs to be initialised to -1.
Fixes: d1a1c21e7 (virgl: native fence fd support)
---
src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 1 +
1 file changed, 1 insertion
Hey Gert,
Nice catch!
Reviewed-by: Robert Foss
On 2018-11-19 10:56, Gert Wollny wrote:
From: Gert Wollny
The structure qdws is not allocated at this point, nor is the
file descriptor set to it's member. Use the fd directly instead.
Fixes: d1a1c21e7621b5177febf191fcd3d3b8ef6
Remove a dead variable, an unneeded int->bool conversion
and some whitespace changes.
Signed-off-by: Robert Foss
---
Sorry about the spam, and this not being included in
v5 which was upstreamed. But nevertheless it should be fixed,
and here's the commit.
src/gallium/drive
Hey Emil,
I just pushed v5 upstream. Let me spin a cleanup patch and send that to the ML.
Rob.
On 2018-11-16 14:03, Emil Velikov wrote:
Hi Rob,
I've spotted a couple of nitpicks, but I don't feel too strongly either way.
On Thu, 15 Nov 2018 at 13:28, Robert Foss wrote:
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Sorry about the spam, but I realized Emils r-b wasn't
includ
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
This patch has been tested using Qemu & Virglrenderer.
Linux virtgpu fences branch:
h
From: Gustavo Padovan
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
Retransmission: Missed CC-ing mesa-dev
Linux virtgpu fences branch
Hey,
On 27/08/2018 11.47, Emil Velikov wrote:
On 24 August 2018 at 18:55, Robert Foss wrote:
Hey Emil,
On 24/08/2018 14.21, Emil Velikov wrote:
From: Emil Velikov
Unlike the other platforms, here we aim do guess if the device that we
somewhat arbitrarily picked, is supported or not.
In
userspace will be able to create a
separate EGL display for each device, query device details and make the
conscious decision which one to use.
Cc: Robert Foss
Cc: Tomasz Figa
Signed-off-by: Emil Velikov
---
Thanks for the clarification Tomasz. The original code was using a
fall-back even a
alloc.
If we are going to support the drm_gralloc usecase and this patch is needed
to do so, I'm all for it.
With the above suggestion fixed:
Reviewed-by: Robert Foss
Rob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hey again
On 13/08/2018 21.01, Robert Foss wrote:
Hey Emil,
On 13/08/2018 16.44, Emil Velikov wrote:
From: Emil Velikov
Replace the manual handling of /dev/dri in famour of the drmDevice API.
The latter provides a consistent way of enumerating the devices,
providing device details as needed
Hey Emil,
On 13/08/2018 16.44, Emil Velikov wrote:
From: Emil Velikov
Replace the manual handling of /dev/dri in famour of the drmDevice API.
The latter provides a consistent way of enumerating the devices,
providing device details as needed.
Cc: Robert Foss
Cc: Tomasz Figa
Signed-off-by
ay to go since vitio-gpu
support landed in libdrm.
Reviewed-by: Robert Foss
Cc: Robert Foss
Cc: Tomasz Figa
Signed-off-by: Emil Velikov
---
If using VGEM the following patch is needed [1]. It's been on the list
for ages - will double-check and commmit it to drm-misc.
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having to debug a null pointer dereference,
simplify that process for the next guy.
So is this working for you
Hey Mauro,
This looks good to me.
Signed-off-by: Robert Foss
On 2018-07-22 10:14, Mauro Rossi wrote:
Patch changes radv entrypoints generator to not skip this extension even
though it is set as disabled in the vk.xml
Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer&qu
Hey Mauro,
This looks good to me.
Reviewed-by: Robert Foss
On 2018-07-22 10:15, Mauro Rossi wrote:
src/amd/Android.mk requires to include src/amd/vulkan/Android.mk
to enable the build of vulkan.radv module
Signed-off-by: Mauro Rossi
---
src/amd/Android.mk | 1 +
1 file changed, 1
Hey Mauro,
This looks good to me.
Signed-off-by: Robert Foss
On 2018-07-22 10:14, Mauro Rossi wrote:
Android build system will try to compile vk_format_table.c
as a shipped source, but at compile time it will be missing,
we move it to generated source, where it belongs
Signed-off-by: Mauro
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
Reviewed-by: Brian Paul
---
Changes since v2:
- Added r-b
Changes since v1:
- Patch added
src/gallium
ned-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
Changes since v2:
- Further remove variable/argument that is just a copy of other variable
Changes since v1:
- Added r-b
- Removed local variable
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to
ixed various smaller issues
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (3):
softpipe: Add assert verifying successful pipe_transfer_map
egl/android: Add Android property for forcing software rendering
platform/android: Enable kms_swrast fallback
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added
Hey Rob,
On 2018-07-19 09:26, Tomasz Figa wrote:
On Thu, Jul 19, 2018 at 12:08 AM Robert Foss wrote:
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having
Hey Rob,
On 2018-07-18 15:30, Rob Herring wrote:
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
This series implements kms_swrast support for the Android
platform. And since having to debug a null pointer dereference,
simplify that process for the next guy.
So is this working for you
Thanks Brian!
On 2018-07-17 16:18, Brian Paul wrote:
On 07/17/2018 04:32 AM, Robert Foss wrote:
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
---
Changes
Hey Eric,
Thanks for the review, adding you r-b.
On 2018-07-17 12:48, Eric Engestrom wrote:
On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
pro
Hey Eric,
On 2018-07-17 12:48, Eric Engestrom wrote:
On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swra
This failure mode is a bit tricky to debug and manifests itself
later as a null pointer dereference, for which finding the origin
is needlessly tricky.
Signed-off-by: Robert Foss
---
Changes since v1:
- Patch added
src/gallium/drivers/softpipe/sp_tile_cache.c | 1 +
1 file changed, 1
"st/dri: Allow kms_swrast to work without a device FD"
- Removed software renderer fallback from platform_android
- Fixed various smaller issues
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (3):
softpipe: Add assert verifying successful pipe_transf
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
ned-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
Changes since v1:
- Added r-b
- Removed local variable
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to EGLBoolean
- Removed software renderer fallback from platform_android, since
it
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added r-b
src/egl/main/egldri
Hey,
On 2018-07-09 13:01, Robert Foss wrote:
NOTE: This series has not been tested successfully, and I'm seeing a segfault
during the boot process. Which I'm currently looking into.
Tracking down the segfault I've been seeing through mesa and aosp and
bootanimation.
Hey Mauro,
On 09/07/18 14:27, Mauro Rossi wrote:
Hi Robert,
Il giorno lun 9 lug 2018 alle ore 13:01 Robert Foss <mailto:robert.f...@collabora.com>> ha scritto:
NOTE: This series has not been tested successfully, and I'm seeing a
segfault
during the boot proc
Hey Eric,
Thanks for the quick reviews!
On 09/07/18 15:45, Eric Engestrom wrote:
On Monday, 2018-07-09 13:01:49 +0200, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to
ssues
Rob.
Rob Herring (1):
android: Build kms_swrast for the Android platform
Robert Foss (2):
egl/android: Add Android property for forcing software rendering
platform/android: Enable kms_swrast fallback
src/egl/drivers/dri2/platform_android.c | 19 ++-
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Fixed EGLBoolean comparison
- Added r-b
src/egl/main/egldri
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Changes since RFC:
- Added r-b
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk
ned-off-by: Robert Foss
---
Changes since RFC:
- Removed whitespace change
- Switched variable type from int to EGLBoolean
- Removed software renderer fallback from platform_android, since
it is already implemented in _eglMatchDriver()
src/egl/drivers/dri2/platform_andr
Hey Emil,
On 05/07/18 15:04, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swrast is also
On 05/07/18 17:50, Robert Foss wrote:
Hey Emil,
On 05/07/18 15:13, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
@@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
char path[PATH_MAX], *search_paths, *next, *end;
char *get_extensions_name
Hey Tomasz,
On 05/07/18 16:26, Tomasz Figa wrote:
Hi Rob,
On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swra
Hey Emil,
On 05/07/18 15:13, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
@@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
char path[PATH_MAX], *search_paths, *next, *end;
char *get_extensions_name;
const __DRIextension **(*get_extensions
Hey Tomasz,
On 05/07/18 16:16, Tomasz Figa wrote:
On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote:
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
---
sr
Hey Tomasz,
On 05/07/18 15:07, Tomasz Figa wrote:
Hi Emil, Robert,
On Thu, Jul 5, 2018 at 9:57 PM Emil Velikov wrote:
On 5 July 2018 at 12:32, Robert Foss wrote:
Hey Eric!
On 05/07/18 12:35, Eric Engestrom wrote:
On Thursday, 2018-07-05 12:07:36 +0200, Robert Foss wrote:
From: Tomeu
+ Wu Zhen
On 05/07/18 12:07, Robert Foss wrote:
This series is an early draft a kms_swrast implementation for the Android
platform.
It's available here:
https://gitlab.collabora.com/robertfoss/mesa/tree/kms_swrast_rfc
The current state isn't entirely functional, but the driver l
Hey Eric!
On 05/07/18 12:35, Eric Engestrom wrote:
On Thursday, 2018-07-05 12:07:36 +0200, Robert Foss wrote:
From: Tomeu Vizoso
A KMS device isn't strictly needed for the kms_swrast to work, so stop
failing to init if the FD is -1. Also don't call DRM_IOCTL_GET_CAP in
that c
From: Rob Herring
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
---
src/gallium/Android.mk | 2 +-
src/gallium/auxiliary/pipe-loader/Android.mk | 1 +
src/gallium/drivers/softpipe/Android.mk | 4 +--
src/gallium/state_trackers/dri/Android.mk| 1
ned-off-by: Robert Foss
---
src/egl/drivers/dri2/platform_android.c | 26 +
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl/drivers/dri2/platform_android.c
index 92b2d2b343e..bc644c25bf9 100644
--- a/src/egl/dr
Signed-off-by: Robert Foss
---
src/egl/drivers/dri2/egl_dri2.c | 29 +++
src/egl/drivers/dri2/platform_android.c | 27 +
src/egl/main/egldriver.c | 8 -
src/gallium/auxiliary/Android.mk | 5
src
From: Tomeu Vizoso
A KMS device isn't strictly needed for the kms_swrast to work, so stop
failing to init if the FD is -1. Also don't call DRM_IOCTL_GET_CAP in
that case.
This allows the driver to be used in machines where no KMS device at all
is present.
Signed-off-by: Tomeu Vizoso
---
src/g
Build kms_swrast for the Android platform
Robert Foss (3):
egl/android: Add Android property for forcing kms_swrast
platform/android: Enable kms_swrast fallback
DEBUG
Tomeu Vizoso (1):
st/dri: Allow kms_swrast to work without a device FD
src/egl/drivers/dri2/egl_dri2.c
In order to simplify Android bringup on new devices,
provide the property "drm.gpu.force_software" which
forces kms_swrast to be used.
Signed-off-by: Robert Foss
---
src/egl/main/egldriver.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/egl/main/egldriver.c b/sr
Pushed.
On 2018-06-25 13:39, Robert Foss wrote:
[RESEND] due to the previous version sent to the ML mistakenly being
v4 again. Please excuse the spam.
This series replaces the dependency on
GRALLOC_MODULE_PERFORM_GET_DRM_FD with DRM node
probing and disables the support for drm_gralloc.
The
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by
y.
Signed-off-by: Robert Foss
Reviewed-by: Tomasz Figa
---
Changes since v4:
- Removed dead continue statement
- Switched function argument to const char* from char*
- Added r-b from Tomasz
Changes since v3:
- Reduced number of probing return codes
- Simplified driver vendor check in droi
Signed-off-by: Robert Foss
Reviewed-by: Tomasz Figa
Reviewed-by: Marek Olšák
---
Changes since v4:
- Added r-b from Marek
Changes since v3:
- Added r-b from Tomasz
src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
m devices are found
Changes since RFC:
- Rebased work on the libdrm patch [2].
- Included patch from Rob Herring disabling drm_gralloc/flink
support by default.
- Added device handler driver probing.
Rob Herring (1):
egl/android: #ifdef out flink name support
Robert Foss (2):
gallium/ut
m Rob Herring disabling drm_gralloc/flink
support by default.
- Added device handler driver probing.
Rob Herring (1):
egl/android: #ifdef out flink name support
Robert Foss (2):
gallium/util: Fix build error due to cast to different size
egl/android: Add DRM node probing and filtering
src/e
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by
Signed-off-by: Robert Foss
Reviewed-by: Tomasz Figa
Reviewed-by: Marek Olšák
---
Changes since v4:
- Added r-b from Marek
Changes since v3:
- Added r-b from Tomasz
src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
y.
Signed-off-by: Robert Foss
Reviewed-by: Tomasz Figa
---
Changes since v4:
- Removed dead continue statement
- Switched function argument to const char* from char*
- Added r-b from Tomasz
Changes since v3:
- Reduced number of probing return codes
- Simplified driver vendor check in droi
ng (1):
egl/android: #ifdef out flink name support
Robert Foss (2):
gallium/util: Fix build error due to cast to different size
egl/android: Add DRM node probing and filtering
src/egl/Android.mk| 6 +-
src/egl/drivers/dri2/egl_dri2.h | 2 -
sr
Signed-off-by: Robert Foss
Reviewed-by: Tomasz Figa
---
Changes since v3:
- Added r-b from Tomasz
src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp
b/src/gallium
y.
Signed-off-by: Robert Foss
---
Changes since v3:
- Reduced number of probing return codes
- Simplified driver vendor check in droid_probe_device()
- Fixed type with ';' prepended to a if-statement
- Removed a strlen call
- Switched a sprintf to snprintf
- Replaced fd == -1 chec
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
Reviewed-by
Hey Tomasz,
Thanks for the quick feedback.
On 2018-06-14 08:30, Tomasz Figa wrote:
Hi Rob,
Thanks for sending v3. Please see few more comments inline.
On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote:
This patch both adds support for probing & filtering DRM nodes
and switches away
On 2018-06-14 04:54, Tomasz Figa wrote:
On Thu, Jun 14, 2018 at 4:14 AM Rob Herring wrote:
On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote:
On 13 June 2018 at 20:45, Rob Herring wrote:
+Amit and John
On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote:
This patch both adds
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp
b/src/gallium/auxiliary/util/u_debug_stack_android.cpp
index b3d56aebe6..395a1fe911
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
---
Changes
y.
Signed-off-by: Robert Foss
---
Changes since v2:
- Switch from drmGetDevices2 to manual renderD node iteration
- Add probe_res enum to communicate probing results better
- Avoid using _eglError() in internal static functions
- Avoid actually loading the driver while probing, just verify
:
- Rebased work on the libdrm patch [2].
- Included patch from Rob Herring disabling drm_gralloc/flink
support by default.
- Added device handler driver probing.
Rob Herring (1):
egl/android: #ifdef out flink name support
Robert Foss (2):
gallium/util: Fix build error due to cast to
Hey,
On 2018-05-25 17:38, Rob Herring wrote:
On Fri, May 25, 2018 at 9:25 AM, Tomasz Figa wrote:
On Fri, May 25, 2018 at 10:59 PM Rob Herring wrote:
On Fri, May 25, 2018 at 4:15 AM, Robert Foss
wrote:
On 2018-05-25 10:38, Tomasz Figa wrote:
On Fri, May 25, 2018 at 5:33 PM Robert
Hey Tomasz,
On 2018-05-25 09:27, Tomasz Figa wrote:
> Hi Rob,
>
> Finally got to review this. Please see my comments inline.
>
> On Fri, May 11, 2018 at 10:48 PM Robert Foss
> wrote:
> [snip]
>> +EGLBoolean
>> +droid_load_driver(_EGLDisplay *disp)
>
On 2018-05-25 10:38, Tomasz Figa wrote:
On Fri, May 25, 2018 at 5:33 PM Robert Foss
wrote:
Hey,
On 2018-05-25 02:17, Rob Herring wrote:
On Thu, May 24, 2018 at 6:23 AM, Robert Foss
wrote:
Hey,
I don't think I've received any feedback on this version yet.
If anyone has so
Hey,
On 2018-05-25 02:17, Rob Herring wrote:
On Thu, May 24, 2018 at 6:23 AM, Robert Foss wrote:
Hey,
I don't think I've received any feedback on this version yet.
If anyone has some time to spare, it would be nice to get it merged.
Just to be clear about the libdrm branch lin
on.
Rob.
On 2018-05-11 15:47, Robert Foss wrote:
This series replaces the dependency on
GRALLOC_MODULE_PERFORM_GET_DRM_FD with DRM node
probing and disables the support for drm_gralloc.
The series has been tested on Qemu+AOSP, where a
virtio gpu was successfully probed for and
opened.
Th
Hey,
After today I'll be out of the office until the 23rd,
So if this series looks ok, I won't be able to re-spin it
with more tags.
So feel free to just push it if possible.
Rob.
On 2018-05-11 15:47, Robert Foss wrote:
This series replaces the dep
:
- Rebased work on the libdrm patch [2].
- Included patch from Rob Herring disabling drm_gralloc/flink
support by default.
- Added device handler driver probing.
Rob Herring (1):
egl/android: #ifdef out flink name support
Robert Foss (2):
gallium/util: Fix build error due to cast to
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
---
Changes
property.
The filtering itself is done using the newly introduced
libdrm drmHandleMatch() call.
Signed-off-by: Robert Foss
---
Changes since v1:
- Do not rely on libdrm for probing
- Distinguish between errors and when no drm devices are found
Changes since RFC:
- Rebased on newer libdrm drmHan
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp
b/src/gallium/auxiliary/util/u_debug_stack_android.cpp
index b3d56aebe6..395a1fe911
Heya,
On 2018-05-01 18:44, Rob Herring wrote:
On Tue, May 1, 2018 at 3:13 AM, Robert Foss wrote:
Hey Rob,
On 2018-05-01 04:20, Rob Herring wrote:
On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss
wrote:
From: Rob Herring
Maintaining both flink names and prime fd support which are provided
Hey Rob,
On 2018-05-01 04:20, Rob Herring wrote:
On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote:
From: Rob Herring
Maintaining both flink names and prime fd support which are provided by
2 different gralloc implementations is problematic because we have a
dependency on a specific
Hey,
On 2018-05-01 08:29, Tomasz Figa wrote:
On Tue, May 1, 2018 at 11:20 AM Rob Herring wrote:
On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss
wrote:
From: Rob Herring
[snip]
@@ -1228,20 +1254,31 @@ dri2_initialize_android(_EGLDriver *drv,
_EGLDisplay *disp)
dri2_dpy
property.
The filtering itself is done using the newly introduced
libdrm drmHandleMatch() call.
Signed-off-by: Robert Foss
---
Changes since RFC:
- Instead of removing code, #ifdef it out.
src/egl/drivers/dri2/platform_android.c | 193 ++--
1 file changed, 135 insertions(+)
. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
drm_gralloc support can be enabled by setting
BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk.
Signed-off-by: Rob Herring
Signed-off-by: Robert Foss
---
Changes
] https://patchwork.freedesktop.org/patch/219194/
Rob Herring (1):
egl/android: #ifdef out flink name support
Robert Foss (1):
egl/android: Add DRM node probing and filtering
src/egl/Android.mk | 6 +-
src/egl/drivers/dri2/egl_dri2.h | 2 -
src/egl/drivers
On 04/26/2018 07:43 PM, Emil Velikov wrote:
On 26 April 2018 at 18:34, Rob Herring wrote:
On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote:
On 26 April 2018 at 03:30, Chih-Wei Huang wrote:
2018-04-25 19:55 GMT+08:00 Robert Foss :
Hey Emil & Chih-Wei,
On 04/24/2018 01:59 PM,
Hey Emil & Chih-Wei,
On 04/24/2018 01:59 PM, Emil Velikov wrote:
On 24 April 2018 at 12:28, Emil Velikov wrote:
On the topic of keeping the old code behind a #define or just removing
it, it'll be great if interested parties can reach a consensus.
Actually one can simply drop this code and
Hey Chih-Wei,
On 04/23/2018 04:17 AM, Chih-Wei Huang wrote:
What's the impact to drm_gralloc?
I'm not terribly familiar with drm_gralloc, but as far as I understand it
depends on flink name support at the moment.
The overarching idea here is to make mesa gralloc independent, but also at the
Hey Rob,
This looks good to me.
Do you mind if I carry this patch my series to get it all pushed upstream at
once?
Rob.
On 04/19/2018 11:09 PM, Rob Herring wrote:
Maintaining both flink names and prime fd support which are provided by
2 different gralloc implementations is problematic becaus
On 04/20/2018 09:38 AM, Tomasz Figa wrote:
On Fri, Apr 20, 2018 at 4:17 PM Robert Foss
wrote:
On 04/20/2018 06:41 AM, Tomasz Figa wrote:
Hi Rob,
On Thu, Apr 19, 2018 at 1:03 AM Robert Foss
wrote:
This patch both adds support for probing & filtering DRM nodes
and switches away
On 04/20/2018 06:41 AM, Tomasz Figa wrote:
Hi Rob,
On Thu, Apr 19, 2018 at 1:03 AM Robert Foss
wrote:
This patch both adds support for probing & filtering DRM nodes
and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD
gralloc call.
Currently the filtering is based jus
1 - 100 of 266 matches
Mail list logo
