Re: [Mesa-dev] winsys/svga/drm: Include sys/types.h

2018-06-15 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh On Tue, Jun 12, 2018 at 03:27:04PM +0100, Ross Burton wrote: > From: Khem Raj > > vmw_screen.h uses dev_t which is defines in sys/types.h > this header is required to be included for getting dev_t > definition. This issue happens on musl C librar

Re: [Mesa-dev] [PATCH] glapi: add glBlendBarrier(), glPrimitiveBoundingBox() prototypes

2018-03-26 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh <s...@vmware.com> On Mon, Mar 26, 2018 at 04:56:22PM -0600, Brian Paul wrote: > in glapi_dispatch.c, as we have for many other GLES functions. > Fixes a cross-compile issue (missing prototype) when GLES support > is disabled. > --- > src/mapi/glapi

Re: [Mesa-dev] [PATCH 1/3] loader/dri3: Use local blits and local buffers when resizing

2017-10-03 Thread Sinclair Yeh
rawable is resized, and we we fill the resized buffers, with data ^ typo For 3/3, I don't know which buffer LOADER_DRI3_FRONT_ID represents, so I'm assuming that line checks the correct condition. Other than those the series: Reviewed-b

Re: [Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

2017-08-02 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh <s...@vmware.com> On Wed, Aug 02, 2017 at 02:23:52PM +0200, Thomas Hellstrom wrote: > In v2 of the patch series, one freestanding patch has already been committed > and the back-to-fake-front flip patch has been dropped since it requires some > more work t

Re: [Mesa-dev] [PATCH 0/5] dri3, gallium: Correctness and performance fixes

2017-07-04 Thread Sinclair Yeh
This series: Reviewed-by: Sinclair Yeh <s...@vmware.com> On Thu, Jun 22, 2017 at 12:42:32PM +0200, Thomas Hellstrom wrote: > A patch series that deals with dri3 correctness- and performance fixes. > > The corectness fixes attempts to deal with the fact that we need to wait fo

Re: [Mesa-dev] [PATCH] mesa/st: Reduce the number of frontbuffer flush calls

2017-07-04 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh <s...@vmware.com> On Thu, Jun 22, 2017 at 01:00:39PM +0200, Thomas Hellstrom wrote: > The mesa state tracker was needlessly flushing the front buffer even if it > hadn't been drawn to since the last flush. This was happening during > glXSwapBuffers if w

Re: [Mesa-dev] problem on building vmwgfx

2017-02-28 Thread Sinclair Yeh
On Tue, Feb 28, 2017 at 04:41:48PM +, Eric Engestrom wrote: > > Looks like there are more issues than I thought. > I don't know this codebase at all, I just recognized the first error you > saw and knew how to fix it. > > For more in-depth help, I suggest asking Sinclair or Thomas (both

Re: [Mesa-dev] [PATCH] main: uses casts to silence some _mesa_debug() format warnings

2016-05-04 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh <s...@vmware.com> On Mon, May 02, 2016 at 07:15:11PM -0600, Brian Paul wrote: > Silences warnings with 32-bit Linux gcc builds and MinGW which doesn't > recognize the ‘t’ conversion character. > --- > src/mesa/main/bufferobj.c | 10 ++ &g

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

2016-04-28 Thread Sinclair Yeh
Maybe add a short commit message for 3/4 Reviewed-by: Sinclair Yeh <s...@vmware.com> On Thu, Apr 28, 2016 at 12:27:05PM +0100, Jose Fonseca wrote: > As they are not standard C++ and are not supported by MSVC C++ compiler. > > Just have nir_imm_double match nir_imm_float abov

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-20 Thread Sinclair Yeh
Minor comment below. Either way: Reviewed-by: Sinclair Yeh <s...@vmware.com> On Wed, Apr 20, 2016 at 05:52:17PM +0200, Mircea Gherzan wrote: > This header should not blindly include the GLX and should also > conditionally define functions that use GLX parameters. The > MESA_EGL

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify st_generate_mipmap()

2016-03-28 Thread Sinclair Yeh
One typo below otherwise: Reviewed-by: Sinclair Yeh <s...@vmware.com> On Sat, Mar 26, 2016 at 11:21:19AM -0600, Brian Paul wrote: > The whole st_generate_mipmap() function was overly complicated. Now > we just call the new _mesa_prepare_mipmap_levels() function to prepare > the

Re: [Mesa-dev] Command buffer error in vmwgfx kernel module

2016-01-28 Thread Sinclair Yeh
Hi Loukas, To help me reproduce this 1. which application(s) was running? 2. what is the distro and kernel version? 3. can you send me your vmware.log? Can you file a bug on bugs.freedesktop.org? thanks, Sinclair On Tue, Jan 26, 2016 at 02:06:14AM +0200, Agorgianitis Loukas wrote: >

Re: [Mesa-dev] [PATCH 10/10] vbo: convert display list GL_LINE_LOOP prims to GL_LINE_STRIP

2015-10-19 Thread Sinclair Yeh
Acked-by: Sinclair Yeh <s...@vmware.com> On Fri, Oct 16, 2015 at 03:25:17PM -0600, Brian Paul wrote: > When a long GL_LINE_LOOP prim was split across primitives we drew > stray lines. See previous commit for details. > > This patch converts GL_LINE_LOOP prims into GL_L

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-18 Thread Sinclair Yeh
On Fri, Oct 16, 2015 at 03:25:16PM -0600, Brian Paul wrote: > When long GL_LINE_LOOP primitives don't fit in one vertex buffer they > have to be split across buffers. The code to do this was basically correct > but drivers had to pay special attention to the _mesa_prim::begin,end flags > in order

Re: [Mesa-dev] [PATCH 01/10] tnl: add some comments in render_line_loop code

2015-10-18 Thread Sinclair Yeh
Patches 1-8 look good. I'm spending a bit more time on 10. Reviewed-by: Sinclair Yeh <s...@vmware.com> From: Brian Paul <bri...@vmware.com> Sent: Friday, October 16, 2015 2:25 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonse

Re: [Mesa-dev] [PATCH 3/4] mesa: make memcpy_texture() non-static

2015-10-16 Thread Sinclair Yeh
Reviewed-by: Sinclair Yeh <s...@vmware.com> On Thu, Oct 15, 2015 at 01:01:42PM -0600, Brian Paul wrote: > So that we can use it directly from the mesa/gallium state tracker. > --- > src/mesa/main/texstore.c | 40 > src/mesa/ma

Re: [Mesa-dev] [PATCH 1/4] st/mesa: use MAX3() instead of MAX2(MAX2) in draw_textured_quad()

2015-10-16 Thread Sinclair Yeh
1 and 3 look good to me. On Thu, Oct 15, 2015 at 01:01:40PM -0600, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_drawpixels.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c >

Re: [Mesa-dev] [PATCH 06/10] vbo: simplify some code in vbo_exec_debug_verts()

2015-10-16 Thread Sinclair Yeh
On Fri, Oct 16, 2015 at 03:25:13PM -0600, Brian Paul wrote: > As before, use a new 'last_prim' pointer to simplify things. Plus, add > some const qualifiers. > --- > src/mesa/vbo/vbo_exec_draw.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] svga: add missing padding to SVGA3dSize

2015-02-20 Thread Sinclair Yeh
On Fri, Feb 20, 2015 at 09:22:20AM +, Van Der Wath, DanielX J wrote: From: Daniel van der Wath danielx.j.van.der.w...@intel.com The kernel side equivalent of struct SVGA3dSize (struct drm_vmw_size) has an extra padding word that SVGA3dSize lacks. This was causing data to be written past

Re: [Mesa-dev] [PATCH] svga: fix sid corruption in vmw_drm_surface_from_handle()

2015-02-17 Thread Sinclair Yeh
On Tue, Feb 03, 2015 at 03:16:51PM +, danielx.j.van.der.w...@intel.com wrote: From: Daniel van der Wath danielx.j.van.der.w...@intel.com The value stored in handle is trashed before being copied into the surface's sid. Use the original value from whandle-handle instead. This fixes a

Re: [Mesa-dev] [PATCH] mesa: fix spurious wglGetProcAddress / GL_INVALID_OPERATION error

2014-10-03 Thread Sinclair Yeh
This looks reasonable to me. Acked-by: Sinclair Yeh s...@vmware.com On Thu, Oct 02, 2014 at 09:49:04AM -0600, Brian Paul wrote: On Windows, the Piglit primitive-restart test was failing a glGetError()==0 assertion when it was run w/out any command line arguments. Piglit's all.py script only

Re: [Mesa-dev] [PATCH] st/xa: Fix regression in xa_yuv_planar_blit()

2014-09-29 Thread Sinclair Yeh
Looks good. Reviewed-by: Sinclair Yeh s...@vmware.com On Mon, Sep 29, 2014 at 08:13:46AM +0200, Thomas Hellstrom wrote: Commit st/xa: scissor to help tilers broke xa_yuv_planar_blit() and vmwgfx textured video. Fix this by implementing scissors also in the yuv draw path. Signed-off

[Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Sinclair Yeh
v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way to test the robustness of the API. Without this check, EGL will segfault trying to dereference dri2_surf-wl_win-private because wl_win is NULL. This fix adds a check and

[Mesa-dev] [PATCH] Check for NULL native_window into dri2_wl_create_surface

2014-05-30 Thread Sinclair Yeh
We have customers using NULL as a way to test the robustness of the API. Without this check, EGL will segfault trying to dereference dri2_surf-wl_win-private because wl_win is NULL. This fix adds a check and sets EGL_BAD_NATIVE_WINDOW --- src/egl/drivers/dri2/platform_wayland.c | 7 +++ 1

Re: [Mesa-dev] [PATCH 1/6] dri2: Create image from texture

2013-01-08 Thread Sinclair Yeh
On Fri, Dec 14, 2012 at 03:28:13PM +0200, Abdiel Janulgue wrote: Add create image from texture extension. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- include/GL/internal/dri_interface.h | 12 + src/egl/drivers/dri2/egl_dri2.c | 83