Re: Intel clc dependency

On 11.4.2024 1.15, Brian Paul wrote: On 4/10/24 13:53, Timo Aaltonen wrote: Brian Paul kirjoitti 6.4.2024 klo 1.05: I'm trying to build the Intel Vulkan driver.  First time in a few months.  I'm having build problems related to clc.  I'm on Ubuntu 22.04 [...] [1347/3181] Generating

Re: [ANNOUNCE] mesa 22.3.0-rc1

On 2.11.2022 23.25, Eric Engestrom wrote: Hello everyone, I'm happy to announce the start of a new release cycle with the first release candidate, 22.3.0-rc1. New features (in no particular order): - GL_ARB_shader_clock on llvmpipe - VK_KHR_shader_clock on lavapipe - Mesa-DB, the new single

Re: [Mesa-dev] bad performance issue in GPU & CPU data sharing

Hi; On 5/31/21 12:33 PM, Zong, Wei wrote: Hello, I'm using GLES shader to run algorithms on image frames, I got very bad performance issue in GPU & CPU data sharing, especially retrieve data from GPU to CPU. Basically, I use */glGenBuffers/*/*/glBindBuffer/*/*/glBufferData(target, size,

Re: [Mesa-dev] Fwd: [Mesa-users] Surfaceless mesa 20.3.X?

Hi; On 27.1.2021 15.01, Brian Paul wrote: Forwarding to mesa-dev where you may get more help.  There was talk of changing software rendering but I'm not sure what's changed.  What version of Mesa are you using? -Brian Forwarded Message Subject: [Mesa-users]

Re: [Mesa-dev] [EXT] Re: GLES 3.2 support for android

(I don't know if that really works though): setprop ro.opengles.version=196610 Hopefully this helps! --- I SurfaceFlinger: version : OpenGL ES 3.1 Mesa 20.1.0-devel (git-87924646db) Regards, Vinay -Original Message- From: Tapani Pälli Sent: Thursday, June 18, 2020 3:19 PM

Re: [Mesa-dev] GLES 3.2 support for android

Hi; On 6/17/20 11:51 AM, Vinay Kumar Madaralli Panchakshari wrote: Dear mesa-dev team, Is there a support for GLES 3.2 ? What kind of hardware and Android version/release are you using? The latest we are using on android points to 3.1 version. While in practice there may be 3.2 support

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

Hi; On 12/4/19 2:39 AM, Marek Olšák wrote: Hi, Here are 2 proposals to simplify and better optimize the GL->Gallium translation. 1) Move classic drivers to a fork of Mesa, and remove them from master. Classic drivers won't share any code with master. glvnd will load them, but glvnd is not

Re: [Mesa-dev] How to merge Mesa changes which require corresponding piglit changes

On 12/2/19 5:25 PM, Michel Dänzer wrote: On 2019-12-02 3:15 p.m., Tapani Pälli wrote: On 11/15/19 8:41 PM, Mark Janes wrote: Michel Dänzer writes: On 2019-11-15 4:02 p.m., Mark Janes wrote: Michel Dänzer writes: Now that the GitLab CI pipeline tests a snapshot of piglit with llvmpipe

Re: [Mesa-dev] How to merge Mesa changes which require corresponding piglit changes

Hi; On 11/15/19 8:41 PM, Mark Janes wrote: Michel Dänzer writes: On 2019-11-15 4:02 p.m., Mark Janes wrote: Michel Dänzer writes: Now that the GitLab CI pipeline tests a snapshot of piglit with llvmpipe (https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2468), the question has come

Re: [Mesa-dev] [PATCH] egl: Mention if swrast is being forced

Makes sense; Reviewed-By: Tapani Pälli On 10/31/19 9:35 AM, Chris Wilson wrote: The system can be disabling HW acceleration unbeknowst to the user, leading to a long debug session trying to work out which component is failing. A quick mention that it is the environment override would be very

Re: [Mesa-dev] [PATCH] egl/android: Enable HAL_PIXEL_FORMAT_RGBA_FP16 format

Reviewed-by: Tapani Pälli On 8/29/19 12:18 AM, Nataraj Deshpande wrote: The patch adds support for 64 bit HAL_PIXEL_FORMAT_RGBA_FP16 for android platform. Fixes android.graphics.cts.BitmapColorSpaceTest#test16bitHardware which failed in egl due to "Unsupported native buffer format

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

On 8/15/19 12:52 PM, Mauro Rossi wrote: Hi Tapani, On Thu, Aug 15, 2019 at 7:29 AM Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote: On 8/13/19 9:55 PM, Mauro Rossi wrote: > Hi, > > On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli mailto:tapa

Re: [Mesa-dev] [PATCH] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

://android.googlesource.com/platform/frameworks/native/+/refs/heads/master/opengl/libs/EGL/eglApi.cpp#608 No concerns, this is fine. Reviewed-by: Tapani Pälli On Wed, Jul 31, 2019 at 3:50 PM Lepton Wu wrote: From: Emil Velikov As said in the EGL_KHR_platform_android extensions For each EGLConfig

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

On 8/13/19 9:55 PM, Mauro Rossi wrote: Hi, On Tue, Aug 13, 2019 at 3:51 PM Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote: On 8/13/19 3:32 PM, Mauro Rossi wrote: > Hi, > > On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli mailto:tapa

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

On 8/13/19 3:32 PM, Mauro Rossi wrote: Hi, On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote: Hi; On 8/13/19 2:43 PM, Mauro Rossi wrote: > Hi Tapani, > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi mailto:iss

Re: [Mesa-dev] [PATCH] gbm: add gbm_{bo, surface}_create_with_modifiers2

On 6/24/19 9:51 PM, Simon Ser wrote: gbm_{bo,surface}_create_with_modifiers is missing the usage flags. Add a new function which lets library users specify it. Signed-off-by: Simon Ser --- src/gbm/main/gbm.c | 38 ++ src/gbm/main/gbm.h | 17

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

On 6/15/19 8:42 AM, Mauro Rossi wrote: Hi, there is a typo in the commit title, the library is libmesa_winsys_virgl_common I will correct it in the final commit Reviewed-by: Tapani Pälli Mauro On Sat, Jun 15, 2019 at 7:39 AM Mauro Rossi <mailto:issor.or...@gmail.com>&

Re: [Mesa-dev] [PATCH] android: radv: fix necessary dependecies

This looks good; Reviewed-by: Tapani Pälli Note that there is ongoing work to get rid of the whole libexpat dependency for Android. But until that happens, let's do this. On 4/24/19 4:44 PM, Mauro Rossi wrote: Fixes building errors due to missing libmesa_util generated files include

Re: [Mesa-dev] Zero-Copy Texture usage from OpenCL

Hi; On 5/30/19 12:03 PM, Rudrappa, Shiva Kumara wrote: Hi, Can someone please help to validate below MESA features. “system shall allow 3D rendering to make use of OpenCL buffers in a zero-copy manner” “system shall allow 3D rendering to make use of Media SDK buffers in a zero-copy

Re: [Mesa-dev] Zero-Copy Texture usage from OpenCL

On 6/3/19 1:17 PM, Tapani Pälli wrote: Hi; On 5/30/19 12:03 PM, Rudrappa, Shiva Kumara wrote: Hi, Can someone please help to validate below MESA features. “system shall allow 3D rendering to make use of OpenCL buffers in a zero-copy manner” “system shall allow 3D rendering to make use

Re: [Mesa-dev] [PATCH] st/glsl: make sure to propagate initialisers to driver storage

Verified to fix the test as initializers get propagated; Reviewed-by: Tapani Pälli On 5/29/19 6:13 AM, Timothy Arceri wrote: This essentially reverts 20234cfe3a20. Fixes piglit test: tests/spec/arb_get_program_binary/execution/uniform-after-restore.shader_test Fixes: 20234cfe3a20 "st

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

On 5/23/19 8:22 PM, Sumit Semwal wrote: Hi Eric, On Thu, 23 May 2019 at 20:25, Eric Engestrom wrote: On Thursday, 2019-05-23 08:34:40 +0300, Tapani Pälli wrote: Hi; On 5/22/19 9:20 PM, Alistair Strachan wrote: On Tue, May 21, 2019 at 10:10 PM Tapani Pälli wrote: On 5/21/19 4:53 PM

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

Hi; On 5/22/19 9:20 PM, Alistair Strachan wrote: On Tue, May 21, 2019 at 10:10 PM Tapani Pälli wrote: On 5/21/19 4:53 PM, Sumit Semwal wrote: Hello everyone, First up, my apologies on not being able to respond earlier; secondly, thanks very much for your review. On Wed, 15 May 2019 at 19

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

On 5/21/19 4:53 PM, Sumit Semwal wrote: Hello everyone, First up, my apologies on not being able to respond earlier; secondly, thanks very much for your review. On Wed, 15 May 2019 at 19:27, Emil Velikov wrote: Hi all, On Tue, 14 May 2019 at 08:18, Tapani Pälli wrote: On 5/13/19 6:52

Re: [Mesa-dev] [PATCH] util: add missing include to build_id.h

Reviewed-by: Tapani Pälli On 5/17/19 8:23 AM, Timothy Arceri wrote: Required to use uint8_t --- src/util/build_id.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/build_id.h b/src/util/build_id.h index 86d611d8db7..1872ca5c7e5 100644 --- a/src/util/build_id.h +++ b/src/util

Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism

On 5/13/19 6:52 PM, Haehnle, Nicolai wrote: This approach seems entirely incompatible with si_debug_options.h, and will be an absolute maintenance nightmare going forward for adding / removing options, because you're introducing a second location where options are defined. Quite frankly, this

Re: [Mesa-dev] [PATCH] android: amd/common: fix missing include path

Reviewed-by: Tapani Pälli On 5/5/19 7:54 PM, Mauro Rossi wrote: Fixes the following building error in Android: In file included from external/mesa/src/amd/common/ac_llvm_helper.cpp:34: In file included from external/mesa/src/amd/common/ac_llvm_build.h:30: In file included from external/mesa

Re: [Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

r_program *prog, unsigned num_buffers = 0; unsigned buffers = 0; + BITSET_WORD *used_components[MAX_FEEDBACK_BUFFERS]; You need to initialize it here, otherwise things end up bad: BITSET_WORD *used_components[MAX_FEEDBACK_BUFFERS] = {}; With this change; Reviewed-

Re: [Mesa-dev] [PATCH] Revert "compiler/glsl: handle case where we have multiple users for types"

On 4/18/19 8:50 AM, Timothy Arceri wrote: On 18/4/19 3:08 pm, Tapani Pälli wrote: On 4/18/19 8:05 AM, Timothy Arceri wrote: This reverts commit 624789e3708c87ea2a4c8d2266266b489b421cba. It caused 400+ piglit tests to crash on radeonsi, I haven't been able to track down the reason yet

Re: [Mesa-dev] [PATCH] Revert "compiler/glsl: handle case where we have multiple users for types"

On 4/18/19 8:05 AM, Timothy Arceri wrote: This reverts commit 624789e3708c87ea2a4c8d2266266b489b421cba. It caused 400+ piglit tests to crash on radeonsi, I haven't been able to track down the reason yet. Could you share the backtrace? --- src/amd/vulkan/radv_device.c | 3

Re: [Mesa-dev] [PATCH] nir: initialise some variables in opt_if_loop_last_continue()

Reviewed-by: Tapani Pälli On 4/11/19 2:38 AM, Timothy Arceri wrote: Fixes a couple of Coverity warnings CID 1444626. Fixes: e30804c6024f ("nir/radv: remove restrictions on opt_if_loop_last_continue()") --- src/compiler/nir/nir_opt_if.c | 4 ++-- 1 file changed, 2 insert

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

ilename scheme? Just a suggestion. - file = fopen(filename, "w"); + } + FILE *file = fopen(filename, "r"); + if (!file) +break; I'm surprised we don't have some helper like 'util_path_exists' but this works, I guess then we should have 'util_pat

Re: [Mesa-dev] [PATCH v7 1/5] util: Get program name based on path when possible

On 3/21/19 12:02 PM, Eric Engestrom wrote: On Thursday, 2019-03-21 09:14:15 +0200, Tapani Pälli wrote: Hello; One *very late* comment below .. On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote: Some programs start with the path and command line arguments in argv[0] (program_invocation_name

Re: [Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

On 3/21/19 4:03 PM, Józef Kucia wrote: On Thu, Mar 21, 2019 at 1:24 PM Tapani Pälli wrote: Yeah, checked that value matches of find_value_indexed; Reviewed-by: Tapani Pälli I don't have commits rights. Please push the patch for me. sure Does this affect 'ext_semaphore-api-errors

Re: [Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

in find_value_indexed(). Yeah, checked that value matches of find_value_indexed; Reviewed-by: Tapani Pälli Does this affect 'ext_semaphore-api-errors' Piglit test that calls this in any way? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https

Re: [Mesa-dev] [PATCH v7 1/5] util: Get program name based on path when possible

doh, it seems I used reply-list instead of reply-all, sending again with original author of the patch .. On 3/21/19 9:14 AM, Tapani Pälli wrote: Hello; One *very late* comment below .. On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote: Some programs start with the path and command line

Re: [Mesa-dev] [PATCH v7 1/5] util: Get program name based on path when possible

Hello; One *very late* comment below .. On 10/23/18 6:38 PM, Nicholas Kazlauskas wrote: Some programs start with the path and command line arguments in argv[0] (program_invocation_name). Chromium is an example of an application using mesa that does this. This tries to query the real path for

Re: [Mesa-dev] MESA_Build_ERROR

On 3/14/19 1:26 PM, Milav wrote: Hello Sir, This Is Milav Soni From TEQ DILIGENT. I cross compiled the xserver using jhbuild. I follow the following link. https://www.x.org/wiki/CrossCompilingXorg/ But when it comes in mesa configuration, it gives following error.

Re: [Mesa-dev] [PATCH] anv: destroy descriptor sets when pool gets reset

Makes sense, sorry I missed this one; Reviewed-by: Tapani Pälli On 3/11/19 7:33 PM, Juan A. Suarez Romero wrote: As stated in Vulkan spec: "Resetting a descriptor pool recycles all of the resources from all of the descriptor sets allocated from the descriptor pool

Re: [Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

On 3/5/19 11:09 AM, Chih-Wei Huang wrote: Tapani Pälli 於 2019年3月5日 週二 下午4:48寫道： On 3/5/19 9:26 AM, Chih-Wei Huang wrote: Mauro Rossi 於 2019年3月4日 週一 上午3:58寫道： Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies Rename the variable labels according to targets

Re: [Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

On 3/5/19 9:26 AM, Chih-Wei Huang wrote: Mauro Rossi 於 2019年3月4日 週一 上午3:58寫道： Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies Rename the variable labels according to targets and python scripts Align the building rules as per Automake for simplification Fixes

Re: [Mesa-dev] [PATCH] android: anv: fix generated files depedencies (v2)

Reviewed-by: Tapani Pälli On 3/4/19 2:45 PM, Mauro Rossi wrote: Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies Rename the variable labels according to targets and python scripts Align the building rules as per Automake for simplification Fixes building errors during

Re: [Mesa-dev] [PATCH 2/2] android: anv: fix libexpat shared dependency

Never saw this error but change looks correct, Reviewed-by: Tapani Pälli On 3/3/19 9:57 PM, Mauro Rossi wrote: Fixes undefined reference building errors for XML_* functions Signed-off-by: Mauro Rossi Cc: "19.0" --- src/intel/Android.vulkan.mk | 2 +- 1 file changed, 1 inser

Re: [Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

On 3/3/19 9:57 PM, Mauro Rossi wrote: Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies Rename the variable labels according to targets and python scripts Align the building rules as per Automake for simplification Fixes building errors during rebuils due to missing

Re: [Mesa-dev] [PATCH] android, autotools: st/mesa: fix location of float64_glsl.h

Hi; On 3/3/19 10:10 PM, Mauro Rossi wrote: Necessary to avoid building error in Android, due to 'compiler/glsl/float64_glsl.h' file not found Fixes: cb4e3e3 ("st/mesa: add support for lowering fp64/int64 for nir drivers") Signed-off-by: Mauro Rossi --- src/mesa/Android.libmesa_st_mesa.mk

Re: [Mesa-dev] [PATCH] mesa/prgram: Use nir_variable_create in prog_to_nir to avoid a memleak.

Hi Matthias; I pushed this change earlier (commit 1d5e5ec30a6) with you in 'Reported-by'. Thanks; // Tapani On 2/25/19 1:16 PM, Matthias Lorenz wrote: Use of nir_variable_create was suggested by Jason Ekstrand. Fixes: 3d7611e9 "st/nir: use NIR for asm programs" ---

[Mesa-dev] [PATCH] nir: use nir_variable_create instead of open-coding the logic

Fixes: 3d7611e9 "st/nir: use NIR for asm programs" Reported-by: Matthias Lorenz Signed-off-by: Tapani Pälli --- src/mesa/program/prog_to_nir.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_n

Re: [Mesa-dev] [PATCH 1/1] Avoid leaking parameter name in prog_to_nir.

Yep, confirmed that this plugs the leak. FWIW there seems to be also "Conditional jump or move depends on uninitialised value(s)" from valgrind but that is for something different. Reviewed-by: Tapani Pälli On 2/21/19 11:09 AM, Matthias Lorenz wrote: Fixes: 3d7611e9 "

Re: [Mesa-dev] [PATCH] android: intel/isl: remove redundant building rules

OK now I understand, this hunk got added accidentially twice from 2 separate commits! Reviewed-by: Tapani Pälli On 2/22/19 7:50 AM, Tapani Pälli wrote: Hi; On 2/22/19 1:30 AM, Mauro Rossi wrote: Fixes the following building error: including ./external/mesa/Android.mk ... build/core

Re: [Mesa-dev] [PATCH] android: intel/isl: remove redundant building rules

Hi; On 2/22/19 1:30 AM, Mauro Rossi wrote: Fixes the following building error: including ./external/mesa/Android.mk ... build/core/base_rules.mk:183: *** external/mesa/src/intel: MODULE.TARGET.STATIC_LIBRARIES.libmesa_isl_tiled_memcpy already defined by external/mesa/src/intel. make: ***

Re: [Mesa-dev] [PATCH] glsl: Fix function return typechecking

On 2/21/19 11:35 AM, Tapani Pälli wrote: Hi; On 2/11/19 6:46 PM, Oscar Blumberg wrote: apply_implicit_conversion only converts and check base types but we need actual type equality for function returns, otherwise you can return a vec2 from a function declared as returning a float. Do you

Re: [Mesa-dev] [PATCH] glsl: Fix function return typechecking

Hi; On 2/11/19 6:46 PM, Oscar Blumberg wrote: apply_implicit_conversion only converts and check base types but we need actual type equality for function returns, otherwise you can return a vec2 from a function declared as returning a float. Do you have some test shader that hits this

Re: [Mesa-dev] [PATCH] mesa: INVALID_VALUE for wrong type or format in Clear*Buffer*Data

On 2/14/19 2:41 PM, Andres Gomez wrote: On Thu, 2019-02-14 at 14:31 +0200, Tapani Pälli wrote: LGTM Reviewed-by: Tapani Pälli Thanks for the review, Tapani ☺ On 2/12/19 2:17 PM, Andres Gomez wrote: Instead of generating a GL_INVALID_ENUM error when the type or format is incorrect

Re: [Mesa-dev] [PATCH] mesa: INVALID_VALUE for wrong type or format in Clear*Buffer*Data

LGTM Reviewed-by: Tapani Pälli On 2/12/19 2:17 PM, Andres Gomez wrote: Instead of generating a GL_INVALID_ENUM error when the type or format is incorrect while using glClear{Named}Buffer{Sub}Data, generate GL_INVALID_VALUE. From page 72 (page 94 of the PDF) of the OpenGL 4.6 spec

Re: [Mesa-dev] [PATCH 1/3] mesa: add explicit enable for EXT_float_blend, and error condition

Patches 1 and 3 are Reviewed-by: Tapani Pälli On 2/13/19 5:40 AM, Ilia Mirkin wrote: If EXT_float_blend is not supported, error out on blending of FP32 attachments in an ES2 context. Signed-off-by: Ilia Mirkin --- src/mesa/main/draw_validate.c| 19 +++ src/mesa/main

Re: [Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

On 2/8/19 11:39 AM, Michel Dänzer wrote: On 2019-02-08 10:30 a.m., Tapani Pälli wrote: On 2/6/19 7:40 PM, Michel Dänzer wrote: On 2019-02-06 12:55 p.m., Tapani Pälli wrote: On 2/6/19 1:16 PM, Michel Dänzer wrote: On 2019-02-05 11:30 p.m., Marek Olšák wrote: Hi, Video players request

Re: [Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

On 2/6/19 7:40 PM, Michel Dänzer wrote: On 2019-02-06 12:55 p.m., Tapani Pälli wrote: On 2/6/19 1:16 PM, Michel Dänzer wrote: On 2019-02-05 11:30 p.m., Marek Olšák wrote: Hi, Video players request fbconfigs with these attributes: GLX_RED_SIZE = 8 GLX_GREEN_SIZE = 8 GLX_BLUE_SIZE = 8

Re: [Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

On 2/6/19 1:16 PM, Michel Dänzer wrote: On 2019-02-05 11:30 p.m., Marek Olšák wrote: Hi, Video players request fbconfigs with these attributes: GLX_RED_SIZE = 8 GLX_GREEN_SIZE = 8 GLX_BLUE_SIZE = 8 GLX_ALPHA_SIZE = 0 Note that the values specify MINIMUM required component sizes, not exact

Re: [Mesa-dev] last call for autotools

On 2/5/19 8:20 PM, Marek Olšák wrote: PKG_CONFIG_PATH still seems to be forgotten by meson. Is there an alternative? Maybe this can be worked out since at least for me it seems to complain that 'different PKG_CONFIG_PATH' was used when configuring last time: WARNING: PKG_CONFIG_PATH has

Re: [Mesa-dev] [PATCH] glsl: use remap location when serialising uniform program resource data

too many (IIRC had something like 12000) Reviewed-by: Tapani Pälli Fixes: c4cff5f40254 ("glsl: add basic support for resource list to shader cache") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109229 --- src/compiler/glsl/serialize.cpp | 33 ++-

Re: [Mesa-dev] Thoughts on fp64 for GLES?

On 1/25/19 8:25 AM, Stéphane Marchesin wrote: On Thu, Jan 24, 2019 at 10:17 PM Tapani Pälli wrote: Hi; On 1/25/19 4:57 AM, Stéphane Marchesin wrote: Hi, We'd like to expose fp64 functionality on Chrome OS where we only have GLES. It seems like a simple approach is to enable

Re: [Mesa-dev] Thoughts on fp64 for GLES?

Hi; On 1/25/19 4:57 AM, Stéphane Marchesin wrote: Hi, We'd like to expose fp64 functionality on Chrome OS where we only have GLES. It seems like a simple approach is to enable this extension for GLES: https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_gpu_shader_fp64.txt Anyone knows

Re: [Mesa-dev] [PATCH] anv: Only parse pImmutableSamplers if the descriptor has samplers

Reviewed-by: Tapani Pälli On 1/19/19 9:04 PM, Jason Ekstrand wrote: --- src/intel/vulkan/anv_descriptor_set.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c

Re: [Mesa-dev] [PATCH] relnotes: Add newly added Vulkan extensions

Acked-by: Tapani Pälli On 1/19/19 9:11 PM, Jason Ekstrand wrote: Both the Intel and RADV people have been really bad about adding things to the release notes. We should start actually paying attention. --- docs/relnotes/19.0.0.html | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

On 1/17/19 12:32 PM, apinheiro wrote: On 17/1/19 9:39, Kenneth Graunke wrote: On Wednesday, January 16, 2019 11:38:05 PM PST Erik Faye-Lund wrote: On Fri, 2019-01-11 at 10:57 -0600, Jason Ekstrand wrote: All, The mesa project has now hit 100 merge requests (36 are still open). I (and I'm

Re: [Mesa-dev] [PATCH] nir/lower_tex: Fix the channel ordering during conversion of AYUV images

On 1/15/19 9:45 AM, Tapani Pälli wrote: On 1/15/19 4:34 AM, Lionel Landwerlin wrote: When writing this I used this page to figure the bytes' ordering : https://docs.microsoft.com/en-us/windows/desktop/medfound/recommended-8-bit-yuv-formats-for-video-rendering#ayuv Of course endianess

Re: [Mesa-dev] [PATCH] nir/lower_tex: Fix the channel ordering during conversion of AYUV images

On 1/15/19 4:34 AM, Lionel Landwerlin wrote: When writing this I used this page to figure the bytes' ordering : https://docs.microsoft.com/en-us/windows/desktop/medfound/recommended-8-bit-yuv-formats-for-video-rendering#ayuv Of course endianess confuses everything :( sunxi seems to support

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

On 1/14/19 2:36 PM, Daniel Stone wrote: Hi, On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand wrote: 5. There's no way with gitlab for Reviewed-by tags to get automatically applied as part of the merging process. This makes merging a bit more manual than it needs to be but is really no

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

On 1/11/19 5:01 PM, Emil Velikov wrote: Hi Kevin, Thanks for that massive undertaking in addressing this. On 2019/01/04, Kevin Strasser wrote: The dri core api was written with the assumption that all attribute values would fit into 32 bits. This limitation means the config handlers can't

Re: [Mesa-dev] [PATCH] nir: fix copy-paste error in nir_lower_constant_initializers

Wrote the same patch and it fixes issues for me; Reviewed-by: Tapani Pälli On 1/10/19 1:23 PM, Rhys Perry wrote: Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1 ('nir: Rework nir_lower_constant_initializers() to handle functions') --- src/compiler/nir/nir_lower_constant_initializers.c

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

On 1/7/19 6:25 PM, Strasser, Kevin wrote: On 1/7/19 8:44 AM, Tapani Pälli wrote: On 1/4/19 11:56 PM, Kevin Strasser wrote: While I have run this series against Piglit, I still need to sort out test coverage for these formats. If anyone has pointers to existing tests that would be really

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 1/7/19 1:28 PM, Bas Nieuwenhuizen wrote: On Mon, Jan 7, 2019 at 11:54 AM Tapani Pälli wrote: On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

On 1/7/19 8:44 AM, Tapani Pälli wrote: Hi; On 1/4/19 11:56 PM, Kevin Strasser wrote: This series enables fp16 fbconfigs and visuals by leveraging existing off-screen rendering support. These formats can be used in conjunction with EXT_surface_SMPTE2086_metadata (not yet implemented

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli wrote: On 12/5/18 1:44 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:37 PM Tapani Pälli

Re: [Mesa-dev] Chromium - Application-level nouveau blacklist

On 1/6/19 9:37 AM, Jason Ekstrand wrote: On Sat, Jan 5, 2019 at 2:40 PM Ilia Mirkin > wrote: It looks like as of Chromium 71, nouveau is completely blacklisted. That's rather unfortunate. :-(  The intel mesa drivers were also blacklisted for quite some time

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

Hi; On 1/4/19 11:56 PM, Kevin Strasser wrote: This series enables fp16 fbconfigs and visuals by leveraging existing off-screen rendering support. These formats can be used in conjunction with EXT_surface_SMPTE2086_metadata (not yet implemented by any drivers) to support EXT_gl_colorspace_scrgb

Re: [Mesa-dev] [PATCH] glsl/linker: complete documentation for assign_attribute_or_color_locations

Thanks Andres; Reviewed-by: Tapani Pälli On 1/2/19 3:21 PM, Andres Gomez wrote: Commit 27f1298b9d9 ("glsl/linker: validate attribute aliasing before optimizations") forgot to complete the documentation. Cc: Tapani Pälli Signed-off-by: Andres Gomez --- src/compiler/glsl/linke

Re: [Mesa-dev] Let's talk about -DDEBUG

On 12/14/18 12:53 PM, Erik Faye-Lund wrote: On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: Dylan Baker writes: [ Unknown signature status ] In the autotools discussion I've come to realize that we also need to talk about the -DDEBUG guard. It seems that there are two different uses,

Re: [Mesa-dev] [PATCH 15/15] anv/android: turn on VK_ANDROID_external_memory_android_hardware_buffer

On 12/11/18 4:33 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin Thanks a lot! I've applied all changes you proposed and sent new versions on the ones where r-b was not given. I also pushed a new branch

Re: [Mesa-dev] [PATCH 13/15] anv: support VkSamplerYcbcrConversionInfo in vkCreateImageView

On 12/11/18 3:48 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: If a conversion struct was passed, then initialize view using format from the conversion structure. v2: use vk_format directly from the anv_format struct Signed-off-by: Tapani Pälli One suggestion

[Mesa-dev] [PATCH v3] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

If external format is used, we store the external format identifier in conversion to be used later when creating VkImageView. v2: rebase to b43f955037c changes v3: added assert, ignore components when creating external format conversion (Lionel) Signed-off-by: Tapani Pälli --- src/intel

Re: [Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

On 12/11/18 3:27 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: Since we don't know the exact format at creation time, some initialization is done only when bound with memory in vkBindImageMemory. v2: demand dedicated allocation in vkGetImageMemoryRequirements2

[Mesa-dev] [PATCH v5] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

as expected for HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL v5: set linear tiling for GPU_DATA_BUFFER usage, add comment about multi-bo support to clarify current implementation (Lionel) Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 119 + 1 file

Re: [Mesa-dev] [PATCH] mesa: ES2 glReadPixels support for OES float extensions.

On 12/12/18 7:10 AM, Nick Kreeger wrote: The OES extensions for float/half-float allow glReadPixels to read GL_RGBA values as GL_FLOAT for both floats and half-floats. This patch ensures that ES2 context versions allows this if at least one of the extensions is present. Reading the extension

Re: [Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

On 12/11/18 3:05 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) v5: rebase to b43f955037c changes

Re: [Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

On 12/12/18 8:42 AM, Tapani Pälli wrote: On 12/12/18 5:05 AM, Nick Kreeger wrote: This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering: https

Re: [Mesa-dev] [PATCH v3] mesa: Fix GLES2 OES float texture framebuffer rendering.

On 12/12/18 5:05 AM, Nick Kreeger wrote: This change enables GLES2 to render float/half-float textures to a framebuffer when the appropriate OES extensions are available. This commit regressed OES GLES2 float texture rendering:

Re: [Mesa-dev] [PATCH 05/15] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On 12/11/18 1:22 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: Use the anv_format address in formats table as implementation-defined external format identifier for now. When adding YUV format support this might need to change. v2: code cleanup (Jason) v3: set

Re: [Mesa-dev] [PATCH 04/15] anv: add from/to helpers with android and vulkan formats

On 12/11/18 12:56 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason) v3: add HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL, we make it define for now to avoid direct dependency to minigbm headers Signed-off-by: Tapani Pälli ---   src

Re: [Mesa-dev] [PATCH 00/15] VK_ANDROID_external_memory_android_hardware_buffer

ping! On 11/27/18 12:53 PM, Tapani Pälli wrote: Hi; Series was rebased and fixes applied from review, also some changes applied to support HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL. With these changes android.graphics.cts.MediaVulkanGpuTest starts to pass, now all tests utilizing AHardwareBuffer

Re: [Mesa-dev] [PATCH 03/11] mesa: add logging function for formatted string

On 12/7/18 2:35 AM, Mark Janes wrote: --- src/mesa/main/errors.c | 27 +++ src/mesa/main/errors.h | 8 2 files changed, 35 insertions(+) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index fad8cb59cae..995b0510575 100644 ---

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli wrote: On 12/5/18 1:44 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:37 PM Tapani Pälli wrote: On 12/5/18 1:22 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:15 PM Tapani

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 12/5/18 1:44 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:37 PM Tapani Pälli wrote: On 12/5/18 1:22 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:15 PM Tapani Pälli wrote: On 12/5/18 1:01 PM, Bas Nieuwenhuizen wrote: On Fri, Sep 7, 2018 at 12:54 AM Kevin

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 12/5/18 1:22 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:15 PM Tapani Pälli wrote: On 12/5/18 1:01 PM, Bas Nieuwenhuizen wrote: On Fri, Sep 7, 2018 at 12:54 AM Kevin Strasser wrote: Android P and earlier expect that the surface supports storage images, and so many

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 12/5/18 1:01 PM, Bas Nieuwenhuizen wrote: On Fri, Sep 7, 2018 at 12:54 AM Kevin Strasser wrote: Android P and earlier expect that the surface supports storage images, and so many of the tests fail when the framework checks for that support. The framework also includes various image

Re: [Mesa-dev] [PATCH] anv/android: Do not reject storage images.

On 12/5/18 12:34 PM, Bas Nieuwenhuizen wrote: We do the ImageFormatProperties check already, and rejecting an usage flag when both ImageFormatProperties and the WSI (which is Android) support it is not allowed. Intel does support storage for some of the support WSI formats, such as

Re: [Mesa-dev] [PATCH 2/2] i965: Set the FBO error state INCOMPLETE_ATTACHMENT only for SRGB_R8

: ebcde3454552adc6d3fea8af2207aafaba857796 i965: be more specific about FBO completeness errors Like with patch 1, fix 'Fixes', with that Reviewed-by: Tapani Pälli Signed-off-by: Gert Wollny --- src/mesa/drivers/dri/i965/intel_fbo.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [Mesa-dev] [PATCH 1/2] i965: Explicitely handle swizzles for MESA_FORMAT_R_SRGB8

: 5363869d4971780401b21bb75083ef2518c12be 965: Force zero swizzles for unused components in GL_RED and GL_RG As Emil said, 'Fixes' line needs to be fixed before committing. Otherwise this LGTM; Reviewed-by: Tapani Pälli Signed-off-by: Gert Wollny --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

, calculate stride correctly for rgb(x) surfaces, rename as 'resolve_ahw_image' v4: rebase to b43f955037c changes Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 36 ++ src/intel/vulkan/anv_android.h | 8 +++ src/intel/vulkan/anv_android_stubs.c | 10

[Mesa-dev] [PATCH 07/15] anv: refactor, remove else block in AllocateMemory

This makes it cleaner to introduce more cases where we import memory from different types of external memory buffers. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 64 +++ 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/src/intel

  1   2   3   4   5   6   7   8   9   10   >