Re: [Mesa-dev] [PATCH v3] broadcom/vc4: Expand width of dst surface

2019-09-02 Thread Zhaowei Yuan
I used git send-email to send this patch to mailing list and cc you, but your email address is not in the cc list finally, so I forward it to  you again On 2019/9/3 10:58 AM, Zhaowei Yuan wrote: > Four bytes of src_surf will be compressed into a 32-bits data > and stored into ds

Re: [Mesa-dev] [PATCH v2] broadcom/vc4: Expand width of dst surface

2019-09-02 Thread Zhaowei Yuan
On 2019/9/2 3:17 PM, apinheiro wrote: > > On 28/8/19 3:16, Zhaowei Yuan wrote: >> Four bytes of src_surf will be compressed into a 32-bits data >> and stored into dst_surf, and dst_surf is read as z-order,so >> its width must be aligned to multiples of 8(4x2) before d

[Mesa-dev] [PATCH v3] broadcom/vc4: Expand width of dst surface

2019-09-02 Thread Zhaowei Yuan
Four bytes of src_surf will be compressed into a 32-bits data and stored into dst_surf, and dst_surf is read as z-order,so its width must be aligned to multiples of 8(4x2) before divided by 2. Signed-off-by: Zhaowei Yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111266 --- src

Re: [Mesa-dev] [PATCH] broadcom/vc4: Expand width of dst surface

2019-08-27 Thread Zhaowei Yuan
Thank you for your reminding, I've sent [patch v2] to this mailing list,  I'd prefer to waiting for response here before I get familiar with gitlab MR. On 2019/8/27 下午6:15, apinheiro wrote: > > On 27/8/19 11:13, Zhaowei Yuan wrote: >> Four bytes of src_surf will be compressed in

[Mesa-dev] [PATCH v2] broadcom/vc4: Expand width of dst surface

2019-08-27 Thread Zhaowei Yuan
Four bytes of src_surf will be compressed into a 32-bits data and stored into dst_surf, and dst_surf is read as z-order,so its width must be aligned to multiples of 8(4x2) before devided by 2. Signed-off-by: Zhaowei Yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111266 --- src

[Mesa-dev] [PATCH] broadcom/vc4: Expand width of dst surface

2019-08-27 Thread Zhaowei Yuan
Four bytes of src_surf will be compressed into a 32-bits data and stored into dst_surf, and dst_surf is read as z-order,so its width must be aligned to multiples of 8(4x2) before devided by 2. Signed-off-by: Zhaowei Yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111266 --- src

Re: [Mesa-dev] [PATCH] configure.ac: make judgement logic cleaner

2018-11-05 Thread Zhaowei YUan
Can anyone review this patch? On 10/29/18 3:08 PM, Zhaowei Yuan wrote: > The purpose of judegment here is to output error message > and abort configure procedure if gbm is not enabled, the > original statement makes it work, however, its logic is > not clear and easy to make peo

Re: [Mesa-dev] [PATCH] egl_dri2: check if driver_name is NULL before releasing it

2018-10-30 Thread Zhaowei YUan
I don't think it's fine, usually, freeing an NULL pointer will cause unexpected errors. It's better to check this for the robustness. On 10/30/18 3:17 PM, Tapani Pälli wrote: > On 10/30/18 8:26 AM, Zhaowei Yuan wrote: >> Pointer dri2_dpy->driver_name is probably NULL

[Mesa-dev] [PATCH] egl_dri2: check if device_name is NULL before releasing it

2018-10-30 Thread Zhaowei Yuan
Pointer dri2_dpy->device_name is probably NULL when calling dri2_display_destory, check this before releasing it. Signed-off-by: Zhaowei Yuan --- src/egl/drivers/dri2/egl_dri2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/

[Mesa-dev] [PATCH] egl_dri2: check if driver_name is NULL before releasing it

2018-10-30 Thread Zhaowei Yuan
Pointer dri2_dpy->driver_name is probably NULL when calling dri2_display_destory, check this before releasing it. Signed-off-by: Zhaowei Yuan --- src/egl/drivers/dri2/egl_dri2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/

[Mesa-dev] [PATCH] configure.ac: make judgement logic cleaner

2018-10-29 Thread Zhaowei Yuan
The purpose of judegment here is to output error message and abort configure procedure if gbm is not enabled, the original statement makes it work, however, its logic is not clear and easy to make people confused. Signed-off-by: Zhaowei Yuan --- configure.ac | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH] glcpp: Expand macro before expanding __LINE__ in its replacement

2018-08-16 Thread Zhaowei Yuan
From: zhaowei yuan If a macro which contains __LINE__ in its replacement, we should expand the macro itself firstly and then expanding __LINE__, otherwise __LINE__ will be expanded as an wrong line number. This patch fixes following CTS test case: dEQP-GLES2

Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-10 Thread Zhaowei Yuan
Okay, got it, thank you for your verification On 8/10/2018 2:15 PM, Tapani Pälli wrote: > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tapani P?lli > Sent: Friday, August 10, 2018 2:15 PM > To: Zhaowei

Re: [Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-08-10 Thread Zhaowei Yuan
wrote: > On 07/22/2018 11:36 PM, zhaowei yuan wrote: > > Line number of a predefined macro should be set > > as where it is referenced rather than declared > > > > Patch v2 does nothing more except ccing more maintainers > > > > Signed-of

[Mesa-dev] [PATCH] broadcom/vc4: Add NULL pointer checking

2018-08-04 Thread zhaowei yuan
In some cases, texstate->textures and texstate->samplers cann't be set properly, add NULL pointer checking here to protect program from crashed Signed-off-by: zhaowei yuan --- src/gallium/drivers/vc4/vc4_uniforms.c | 43 ++ 1 file changed, 43 insertions(+)

[Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-07-23 Thread zhaowei yuan
Line number of a predefined macro should be set as where it is referenced rather than declared Patch v2 does nothing more except ccing more maintainers Signed-off-by: zhaowei yuan Bugzilla: https://patchwork.freedesktop.org/patch/225818/ --- src/compiler/glsl/glcpp/glcpp-lex.l | 1 + src

[Mesa-dev] [PATCH] glsl: Take sampler2DRect and sampler2DRectShadow as reserved

2018-06-13 Thread zhaowei yuan
"sampler2DRect" and "sampler2DRectShadow" are specified as reserved from GLSL 1.1 and GLSL ES 1.0 Signed-off-by: zhaowei yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106906 --- src/compiler/glsl/glsl_lexer.ll | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[Mesa-dev] [PATCH] glsl: Take 'double' as reserved after GLSL ES 1.0

2018-06-05 Thread zhaowei yuan
GLSL ES 1.0.17 specifies that "double" is a keyword reserved Signed-off-by: zhaowei yuan --- src/compiler/glsl/glsl_lexer.ll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index b7cf100..de6d

[Mesa-dev] [PATCH] glcpp: Sync line number for macro

2018-05-29 Thread zhaowei yuan
Line number of a predefined macro should be set as where it is referenced rather than declared Signed-off-by: zhaowei yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- src/compiler/glsl/glcpp/glcpp-lex.l | 1 + src/compiler/glsl/glcpp/glcpp-parse.y | 55