Re: [EXTERNAL] Re: Zink MR signoff tags

and for Nouveau while I am at it. Unless somebody screams and still wants them. On Wed, Oct 19, 2022 at 12:12 AM Karol Herbst wrote: > > Same for Rusticl > > On Mon, Oct 17, 2022 at 10:28 PM Jesse Natalie wrote: > > > > Jumping on the bandwagon, I'm going to adopt this

Re: [EXTERNAL] Re: Zink MR signoff tags

Same for Rusticl On Mon, Oct 17, 2022 at 10:28 PM Jesse Natalie wrote: > > Jumping on the bandwagon, I'm going to adopt this for Microsoft-owned code as > well (src/gallium/d3d12, src/microsoft/*). > > -Jesse > > -Original Message- > From: mesa-dev On Behalf Of Gert > Wollny > Sent:

Re: Rust in our code base

will merge Rusticl tomorrow or so unless somebody complains. On Wed, Aug 24, 2022 at 5:34 PM Karol Herbst wrote: > > On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand > wrote: > > > > +mesa-dev and my jlekstrand.net e-mail > > > > On Sun, 2022-08-21 at 20:44 +0200,

Re: Rust in our code base

On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand wrote: > > +mesa-dev and my jlekstrand.net e-mail > > On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > > On Sun, Aug 21, 2022 at 8:34 PM Rob Clark > > wrote: > > > > > > On Sun, Aug 21,

[PATCH] test email smtp google whatever

uhm.. does this still work? --- README.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/README.rst b/README.rst index b35246e034c..6a7112c0473 100644 --- a/README.rst +++ b/README.rst @@ -1,3 +1,4 @@ + `Mesa `_ - The 3D Graphics Library

Re: [Mesa-dev] OpenGL and OpenCL on top of D3D12

On Tue, Mar 24, 2020 at 5:39 PM Gert Wollny wrote: > > Dear Mesa developers, > > Today, we at Collabora together with Microsoft have announced a new > project based on Mesa: OpenGL and OpenCL on top of Microsoft's D3D12. > You can find the full announcements here: > >

Re: [Mesa-dev] [RFC PATCH v2 1/6] nv50/ir: add nv50_ir_prog_info_out

On Fri, Mar 20, 2020 at 10:20 AM Juan A. Suarez Romero wrote: > > On Thu, 2020-03-19 at 21:57 +0100, Mark Menzynski wrote: > > From: Karol Herbst > > > > Split out the output relevant fields from the nv50_ir_prog_info struct > > in order to have a cleaner separatio

Re: [Mesa-dev] [PATCH] nv50/ir: get rid of smemSize

please ignore, there is actually a use of that, but not through TGSI. On Fri, Mar 6, 2020 at 3:07 PM Karol Herbst wrote: > > we can rely on the value we get through the cso > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h |

[Mesa-dev] [PATCH] nv50/ir: get rid of smemSize

we can rely on the value we get through the cso Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 1 - src/gallium/drivers/nouveau/nv50/nv50_program.c | 4 +--- src/gallium/drivers

Re: [Mesa-dev] [PATCH v2 1/7] nv50/ir: add nv50_ir_prog_info_out

On Wed, Mar 4, 2020 at 6:37 PM Emil Velikov wrote: > > Hi Mark, > > On Fri, 21 Feb 2020 at 12:20, Mark Menzynski wrote: > > > - ret = nv50_ir_generate_code(info); > > + /* these fields might be overwritten by the compiler */ > > + info_out.bin.smemSize = prog->cp.smem_size; > > +

Re: [Mesa-dev] [PATCH 8/8] nvc0: Add shader disk caching

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds shader disk caching for nvc0 to reduce the need to every time compile > shaders. Shaders are saved into disk_shader_cache from nvc0_screen structure. > > It serializes the input nv50_ir_prog_info to compute the hash key and > also to

Re: [Mesa-dev] [PATCH 7/8] nv50/ir: Move separateFragData

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Nv50_ir_prog_info (input) was in the wrong place, moved it to > nv50_ir_prog_info_out. > > Signed-off-by: Mark Menzynski > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 2 +- >

Re: [Mesa-dev] [PATCH 6/8] tgsi/util: Change boolean for bool

by the way: Mind creating a MR on gitlab with this and the 2nd patch? This way we can get them reviewed and tested there and merged before the nouveau related patches. On Mon, Feb 17, 2020 at 9:09 PM Karol Herbst wrote: > > Reviewed-by: Karol Herbst > > On Mon, Feb 17, 2020 at

Re: [Mesa-dev] [PATCH 6/8] tgsi/util: Change boolean for bool

Reviewed-by: Karol Herbst On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > I was getting errors with "boolean" when compiling. This patch changes > boolean to bool from . > > Signed-off-by: Mark Menzynski > --- > src/gallium/auxiliary/tgsi/tgsi_util.c

Re: [Mesa-dev] [PATCH 5/8] nv50/ir: Add nv50_ir_prog_info serialize

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds a function for serializing a nv50_ir_prog_info structure, which is > needed for shader caching. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 4 + >

Re: [Mesa-dev] [PATCH 4/8] nv50/ir: Add prog_info_out print

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds a function for printing nv50_ir_prog_info_out structure > in JSON-like format, which could be used in debugging. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 3 + >

Re: [Mesa-dev] [PATCH 3/8] nv50/ir: Add nv50_ir_prog_info_out serialize and deserialize

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Adds functions for serializing and deserializing > nv50_ir_prog_info_out structure, which are needed for shader caching. > > Signed-off-by: Mark Menzynski > --- > .../drivers/nouveau/codegen/nv50_ir_driver.h | 44 >

Re: [Mesa-dev] [PATCH 2/8] util/blob: Add overwrite function for uint8

On Mon, Feb 17, 2020 at 6:41 PM Mark Menzynski wrote: > > Overwrite function for this type was missing and I needed it for my project. > > Signed-off-by: Mark Menzynski > --- > src/util/blob.c | 9 + > src/util/blob.h | 15 +++ > 2 files changed, 24 insertions(+) > > diff

Re: [Mesa-dev] [ANNOUNCE] Mesa 20.0 branchpoint planned for 2020/01/29, Milestone opened

On Thu, Jan 30, 2020 at 2:37 AM Dieter Nützel wrote: > > Maybe compilation with '-Dopencl-spirv=true', again. > > It is broken, now. > Even LLVM 10.0 won't compile for me with SPIRV-LLVM-Translator, > currently. > do you have any more details on that? It could be that the spirv-llvm-translator

[Mesa-dev] [PATCH v3 2/2] nv50/ir/ra: fix memory corruption when spilling

Shadow gap: cc ==612087==ABORTING v2: full rework v3: manage a full copy instead of recreating new lists on every access Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 93 ++- 1 file changed, 71 insertions(+), 22 deletions(-) diff --g

[Mesa-dev] [PATCH v3 1/2] nv50/ir/ra: convert some for loops to Range-based for loops

I will touch them in the next commit Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH v3 1/2] nv50/ir/ra: convert some for loops to Range-based for loops

I will touch them in the next commit Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH v2 2/2] nv50/ir/ra: fix memory corruption when spilling

Shadow gap: cc ==612087==ABORTING v2: full rework Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 87 ++- 1 file changed, 66 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/galliu

[Mesa-dev] [PATCH v2 1/2] nv50/ir/ra: convert some for loops to Range-based for loops

I will touch them in the next commit Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_ra.cpp| 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouveau/codegen

Re: [Mesa-dev] [PATCH] nv50/ir: implement global atomics and handle it for nir

On Thu, Dec 5, 2019 at 11:57 AM Karol Herbst wrote: > > TGSI doesn't have any concept of global memory right now. > > Signed-off-by: Karol Herbst > --- > .../nouveau/codegen/nv50_ir_from_nir.cpp | 43 +-- > .../nouveau/codegen/nv50_ir_lowering_nvc0.

[Mesa-dev] [PATCH] nouveau: limit reported compute max memory and allocation size

Otherwise applications (like the OpenCL CTS) will try to allocate more memory than what the GPU is actually able to provide. Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 7 +-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 7 +-- 2 files changed

[Mesa-dev] [PATCH] nv50/ir: implement global atomics and handle it for nir

TGSI doesn't have any concept of global memory right now. Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 43 +-- .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 + 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] LLVM + SPIRV-LLVM-Translator - compilation errors

might be that those definitions moved elsewhere or the headers were never directly included. In llvm 9 there are in llvm/InitializePasses.h, but maybe that's changed? And if not, maybe that file needs to be included in SPIRVLowerSPIRBlocks.cpp? On Fri, Nov 15, 2019 at 2:34 AM Dieter Nützel

[Mesa-dev] [PATCH] nv50/ir/ra: fix memory corruption when spilling

Poisoned by user:f7 Container overflow: fc Array cookie:ac Intra object redzone:bb ASan internal: fe Left alloca redzone: ca Right alloca redzone:cb Shadow gap: cc ==612087==ABORTING Signed-off-by: Karol Herbs

[Mesa-dev] [PATCH] nv50/ir: fix crash in isUniform for undefined values

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp index a181a13a3b1..ae07d967221 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH] nv50/ir: remove DUMMY edge type

On Mon, Oct 14, 2019 at 5:10 PM Karol Herbst wrote: > > > > it was never used > > > > Signed-off-by: Karol Herbst > > --- > > src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp| 3 --- > > src/gallium/drivers/nouveau/codegen/nv50_ir_graph.cpp | 8 +

[Mesa-dev] [PATCH] nv50/ir: remove DUMMY edge type

it was never used Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp| 3 --- src/gallium/drivers/nouveau/codegen/nv50_ir_graph.cpp | 8 +--- src/gallium/drivers/nouveau/codegen/nv50_ir_graph.h | 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp

Re: [Mesa-dev] [Nouveau] [PATCH] nv50/ir: mark STORE destination inputs as used

Reviewed-by: Karol Herbst On Mon, Oct 14, 2019 at 8:47 AM Ilia Mirkin wrote: > > Observed an issue when looking at the code generatedy by the > image-vertex-attrib-input-output piglit test. Even though the test > itself worked fine (due to TIC 0 being used for the image)

Re: [Mesa-dev] [Nouveau] [PATCH] gm107/ir: fix loading z offset for layered 3d image bindings

I don't think this is a good idea overall. The way simpler solution would be to disable tiling on the z axis for 3d images so that we don't hurt the most common case, 2d images. And that's what I was seeing nvidia doing anyway. So with that we would end up adding a bunch of instructions hurting

Re: [Mesa-dev] [clover/spirv] radeonsi/NIR (with Nine) - final linking failed on libOpenCL.so.1.0.0

I think you only need to recompile the translator with -fPIC enabled. At least that's what the error is saying. On Thu, Sep 26, 2019 at 6:53 AM Aaron Watry wrote: > > Pretty sure I'm running into the same thing trying to build clover > with llvm-spirv enabled. If it's a known solution, I

[Mesa-dev] [PATCH 4/4] nv50, nvc0: fix must_check warning of util_dynarray_resize_bytes

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 10 +++--- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 10 +++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_state.c b/src/gallium/drivers

[Mesa-dev] [PATCH 2/4] nv50ir: fix unnecessary parentheses warning

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_util.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_util.h index 307c23d5e03..b1766f48205 100644

[Mesa-dev] [PATCH 3/4] nv50ir/nir: comparison of integer expressions of different signedness warning

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 4e86ab8f8cc

[Mesa-dev] [PATCH 1/4] nv50ir: fix memset on non trivial types warning

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 4 +--- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

t;data" pointer) > > Let me know if you want me to resend. > no, that's fine.. > On Fri, Jul 26, 2019 at 5:51 AM Karol Herbst wrote: > > > > Reviewed-by: Karol Herbst > > > > On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote: > > > > > > Pr

Re: [Mesa-dev] [PATCH] nv50/ir: don't consider the main compute function as taking arguments

OpenCL nir path and that works out quite nicely as now you can just call different entry points without having to deal with this "if this function is the entry point, args get passed differently than being a called function" situation. Anyway, the for the patch itself: Reviewed-by: Karol

Re: [Mesa-dev] [PATCH] nv50/ir: handle insn not being there for definition of CVT arg

Reviewed-by: Karol Herbst On Fri, Jul 26, 2019 at 7:03 AM Ilia Mirkin wrote: > > This can happen if it's e.g. a uniform or a function argument. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111217 > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedeskto

Re: [Mesa-dev] [PATCH 4/4] nouveau: flip DEBUG -> !NDEBUG

Reviewed-by: Karol Herbst On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote: > > The meson conversion chose to change the meaning of DEBUG to "used for > debugging" to be "used for expensive things for debugging", primarily > for nir_validate. Flip things

Re: [Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

Reviewed-by: Karol Herbst On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote: > > Previously the code only handled it for positions 1 and up (as would be > for UBO's in GL). It's not a lot of trouble to handle this, and vl or > vdpau want this. > > Bugzilla: https://bu

Re: [Mesa-dev] [PATCH 2/4] nv50, nvc0: update sampler/view bind functions to accept NULL array

Reviewed-by: Karol Herbst On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote: > > Apparently vl (or vdpau) wants to pass that in now. Handle it. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedeskto

Re: [Mesa-dev] [PATCH] nvc0/ir: Fix assert accessing null pointer

it's only fixing a crash in a build with asserts enabled, but if somebody wants to apply those to stable, then go ahead. On Wed, Jul 24, 2019 at 12:48 PM Juan A. Suarez Romero wrote: > > On Fri, 2019-07-19 at 13:56 +0200, Mark Menzynski wrote: > > Fixes:

Re: [Mesa-dev] [PATCH] nv50/ir: Add mul and mod constant optimizations

yeah.. I am not quite sure myself about it. But skipping on the div emulation seems like a good idea in general. But it's also not common enough to actually care all that much about it. On Tue, Jul 23, 2019 at 5:18 PM Ilia Mirkin wrote: > > On Tue, Jul 23, 2019 at 11:15 AM Karol Herbst

Re: [Mesa-dev] [PATCH] nv50/ir: Add mul and mod constant optimizations

On Tue, Jul 23, 2019 at 4:50 PM Ilia Mirkin wrote: > > You handle 1/n but not 1%n? TBH, the 1/n code isn't 100% obvious to > me... 1/n = |n|-1 > 0 ? i forget how SLCT works, but I can't > think of a way to finish that expression in terms of |n|-1 and n. And > what about n == 0. I'd just as

[Mesa-dev] [PATCH] nvc0: remove nvc0_program.tp.input_patch_size

right now that's dead code Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 - src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 src/gallium/drivers/nouveau/nvc0/nvc0_program.h | 1 - 3 files changed, 6 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] nouveau: handle new CAPS

VATIVES one, but I could add another one for CS_DERIVED_SYSTEM_VALUES > On Tue, Jul 2, 2019 at 11:49 AM Karol Herbst wrote: > > > > Signed-off-by: Karol Herbst > > --- > > src/gallium/drivers/nouveau/nv50/nv50_screen.c | 13 + > > src/gallium/drivers/nouveau/

[Mesa-dev] [PATCH] nouveau: handle new CAPS

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 13 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 13 + 2 files changed, 26 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > From: Dave Airlie > > This is pointless in that we won't ever hit those paths in real life, > but coverity complains. > what does it actually complain about? > Fixes: f014ae3c7cce ("nouveau: add support for nir") > --- >

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

ohh, nvm... I already know... On Tue, Jun 18, 2019 at 11:18 PM Karol Herbst wrote: > > On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > > > From: Dave Airlie > > > > This is pointless in that we won't ever hit those paths in real life, > > but c

Re: [Mesa-dev] undefined behaviour in spirv_to_nir.c

ts > out, it probably is safe to just delete. However, I'd feel slightly better > about it if we figured out the right bit size and just called > nir_eval_const_opcode to do a u2u32 on the value. > > --Jason > > On Fri, May 17, 2019 at 1:24 AM Karol Herbst wrote: >> >>

Re: [Mesa-dev] undefined behaviour in spirv_to_nir.c

ohhh, yeah.. I think we can actually just remove that code, as it shouldn't have any affect on the constants value. On Fri, May 17, 2019 at 4:07 AM Jason Ekstrand wrote: > > I think it's fine but I'm not at my computer right now. > > --Jason > > On May 16, 2019 20:58:03 Dave Airlie wrote: > > >

[Mesa-dev] [PATCH] nv50/ir/nir: make use of SYSTEM_VALUE_MAX when iterating read sysvals

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 7e59b83e8fc

[Mesa-dev] [PATCH] nv50/ir/nir: prefer to shift 1ull instead of 1ll

Signed-off-by: Karol Herbst Suggested-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 14/15] clover: add support for consuming spirv

v2: rework arguments to compiler::compile_program add assert to device::ir_format Signed-off-by: Karol Herbst Reviewed-by: Francisco Jerez --- src/gallium/include/pipe/p_defines.h | 1 + .../state_trackers/clover/core/compiler.hpp | 68 +++ .../state_trackers

[Mesa-dev] [PATCH 11/15] rename pipe_llvm_program_header to pipe_binary_program_header

We want to use it for other formats as well, so give it a more generic name Signed-off-by: Karol Herbst Reviewed-by: Francisco Jerez --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/include/pipe

[Mesa-dev] [PATCH 04/15] nv50/ir/nir: implement load/store_global

required by OpenCL v2: fix setting globalAccess Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 36 +++ 1 file changed, 36 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src

[Mesa-dev] [PATCH 12/15] nir/spirv: add spirv_to_nir_cl

Signed-off-by: Karol Herbst --- src/compiler/Makefile.sources| 1 + src/compiler/nir/meson.build | 1 + src/compiler/spirv/nir_spirv.h | 4 + src/compiler/spirv/spirv_to_nir_cl.c | 124 +++ 4 files changed, 130 insertions(+) create mode 100644

[Mesa-dev] [PATCH 08/15] clover/llvm: Add options for dumping SPIR-V binaries

From: Pierre Moreau Reviewed-by: Karol Herbst --- .../state_trackers/clover/llvm/util.hpp | 4 ++- .../clover/spirv/invocation.cpp | 30 +++ .../clover/spirv/invocation.hpp | 4 +++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 03/15] nv50/ir/nir: handle kernel inputs

required by OpenCL Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 21 --- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers

[Mesa-dev] [PATCH 00/15] Clover: support CL through SPIR-V

library to convert llvm to spirv. Karol Herbst (10): nv50/ir/nir: parse system values first and stop for compute shaders nv50/ir/nir: don't assert on !main nv50/ir/nir: handle kernel inputs nv50/ir/nir: implement load/store_global gallium: add blob field to pipe_llvm_program_header

[Mesa-dev] [PATCH 15/15] nvc0: expose spirv support

required for OpenCL Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nouveau_screen.c | 1 + src/gallium/drivers/nouveau/nouveau_screen.h | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 2 ++ src

[Mesa-dev] [PATCH 13/15] gallium: add entry_point field to pipe_compute_state

. Signed-off-by: Karol Herbst --- src/gallium/include/pipe/p_state.h| 1 + src/gallium/state_trackers/clover/core/kernel.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index c94dfb0ba78..d043f0d19af 100644

[Mesa-dev] [PATCH 09/15] clover/llvm: Add functions for compiling from source to SPIR-V

From: Pierre Moreau Reviewed-by: Karol Herbst --- .../state_trackers/clover/llvm/invocation.cpp | 100 +++--- .../state_trackers/clover/llvm/invocation.hpp | 8 ++ src/gallium/state_trackers/clover/meson.build | 2 +- 3 files changed, 92 insertions(+), 18 deletions(-) diff

[Mesa-dev] [PATCH 07/15] clover/spirv: Add functions for parsing arguments, linking programs, etc.

From: Pierre Moreau v2 (Karol Herbst): silence warnings about unhandled enum values --- .../clover/spirv/invocation.cpp | 598 ++ .../clover/spirv/invocation.hpp | 12 + 2 files changed, 610 insertions(+) diff --git a/src/gallium/state_trackers

[Mesa-dev] [PATCH 06/15] clover/spirv: Add functions for validating SPIR-V binaries

From: Pierre Moreau Changes since: * v12: remove autotools (Karol Herbst) * v11: Fix compilation error introduced in v11. * v10: - Reuse format_validation_msg in is_valid_spirv. - Remove LVL2STR macro in format_validation_msg. * v9: Add `clover_cpp_std` to the overrides of the `libclspirv

[Mesa-dev] [PATCH 05/15] meson: Check for SPIRV-Tools and llvm-spirv

From: Pierre Moreau Changes since: * v11 (Karol Herbst): - only set new defines for clover to speed up recompilation - remove autotools * v10: - Add a new flag (`--enable-opencl-spirv` for autotools, and `-Dopencl-spirv=true` for meson) for enabling SPIR-V support in clover

[Mesa-dev] [PATCH 10/15] gallium: add blob field to pipe_llvm_program_header

makes it easier to consume a IR_NATIVE binary Signed-off-by: Karol Herbst Reviewed-by: Francisco Jerez --- src/gallium/drivers/r600/evergreen_compute.c | 4 +--- src/gallium/drivers/radeonsi/si_compute.c | 4 +--- src/gallium/include/pipe/p_state.h

[Mesa-dev] [PATCH 01/15] nv50/ir/nir: parse system values first and stop for compute shaders

required by OpenCL Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 61 ++- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers

[Mesa-dev] [PATCH 02/15] nv50/ir/nir: don't assert on !main

required for OpenCL Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

Re: [Mesa-dev] [PATCH] nir: Constant values are per-column not per-component

Reviewed-by: Karol Herbst On Wed, Mar 20, 2019 at 1:22 PM Lionel Landwerlin wrote: > > Reviewed-by: Lionel Landwerlin > > On 19/03/2019 19:15, Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH] android: nouveau: add support for nir

On Sun, Mar 17, 2019 at 11:56 PM Mauro Rossi wrote: > > Hi Karol, > > On Sun, Mar 17, 2019 at 11:25 PM Karol Herbst wrote: > > > > On Sun, Mar 17, 2019 at 10:52 PM Mauro Rossi wrote: > > > > > > Add the necessary build rules for android, to avoid b

Re: [Mesa-dev] [PATCH] android: nouveau: add support for nir

On Sun, Mar 17, 2019 at 10:52 PM Mauro Rossi wrote: > > Add the necessary build rules for android, to avoid building errors. > > Fixes: f014ae3 ("nouveau: add support for nir") > Signed-off-by: Mauro Rossi > --- > src/gallium/drivers/nouveau/Android.mk | 7 ++- > 1 file changed, 6

Re: [Mesa-dev] [PATCH 33/34] nv50/ir/nir: handle user clip planes for each emitted vertex

On Tue, Mar 12, 2019 at 1:09 AM Ilia Mirkin wrote: > > On Mon, Mar 11, 2019 at 8:05 PM Karol Herbst wrote: > > > > v9: convert to C++ style comments > > Signed-off-by: Karol Herbst > > --- > > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 6

[Mesa-dev] [PATCH 17/34] nv50/ir/nir: implement nir_intrinsic_store_(per_vertex_)output

Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index dc8dbcfb48b

[Mesa-dev] [PATCH 23/34] nv50/ir/nir: add skeleton getOperation for intrinsics

v7: don't assert in default case for getSubOp Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 22 +++ 1 file changed, 22 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src

[Mesa-dev] [PATCH 20/34] nv50/ir/nir: implement loading system values

-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 122 ++ 1 file changed, 122 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 5c372794e02..43c9a468f5a 100644

[Mesa-dev] [PATCH 29/34] nv50/ir/nir: implement images

instructions don't require C++11 features v9: implement MS images rebase on master (image modifiers) fix regressions due to variable src compnents replace '(*it).' with 'it->' convert to C++ style comments Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.

[Mesa-dev] [PATCH 34/34] nv50ir/nir: move immediates before use

Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 59 +-- 1 file changed, 41 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index

[Mesa-dev] [PATCH 12/34] nv50/ir/nir: parse NIR shader info

v2: parse a few more fields v3: add special handling for GL_ISOLINES v8: set info->prop.fp.readsSampleLocations don't require C++11 features v9: replace '(*it).' with 'it->' convert to C++ style comments Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp

[Mesa-dev] [PATCH 32/34] nv50/ir/nir: implement intrinsic shader_clock

v9: mark as fixed Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index

[Mesa-dev] [PATCH 25/34] nv50/ir/nir: implement variable indexing

v5: use loadFrom helper v8: don't require C++11 features v9: convert to C++ style comments Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 58 +++ 1 file changed, 58 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp

[Mesa-dev] [PATCH 24/34] nv50/ir/nir: implement vote and ballot

-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 48 +++ 1 file changed, 48 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index ab3bf7f843a..7a10a408b70 100644

[Mesa-dev] [PATCH 26/34] nv50/ir/nir: implement geometry shader nir_intrinsics

v4: use smarter getIndirect helper use new getSlotAddress helper use loadFrom helper v8: don't require C++11 features Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 21/34] nv50/ir/nir: implement nir_ssa_undef_instr

v2: use mkOp v8: don't require C++11 features Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp| 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src

[Mesa-dev] [PATCH 13/34] nv50/ir/nir: implement nir_load_const_instr

v8: fix loading 8/16 bit constants Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 28 +++ 1 file changed, 28 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers

[Mesa-dev] [PATCH 22/34] nv50/ir/nir: implement nir_instr_type_tex

txf with a uniform constant 0 lod Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 234 ++ 1 file changed, 234 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/cod

[Mesa-dev] [PATCH 09/34] nv50/ir/nir: add nir type helper functions

v4: treat imul as unsigned v5: remove pointless !! v7: inot is unsigned as well v8: don't require C++11 features v9: convert to C++ style comments improve formatting print error in all cases where codegen doesn't support a given type Signed-off-by: Karol Herbst Acked-by: Pierre Moreau

[Mesa-dev] [PATCH 19/34] nv50/ir/nir: implement intrinsic_discard(_if)

v9: use getSSA instead of new_LValue Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 18/34] nv50/ir/nir: implement load_(interpolated_)input/output

->prop.fp.readsSampleLocations for at_sample interpolation don't require C++11 features v9: convert to C++ style comments Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 135 ++ 1 file changed, 135 insertions(+) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 16/34] nv50/ir/nir: implement nir_intrinsic_load_uniform

v2: use new getIndirect helper fixes symbols for 64 bit types v4: use smarter getIndirect helper simplify address calculation use loadFrom helper v8: don't require C++11 features Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 10

[Mesa-dev] [PATCH 14/34] nv50/ir/nir: add skeleton for nir_intrinsic_instr

Signed-off-by: Karol Herbst Reviewed-by: Pierre Moreau --- .../nouveau/codegen/nv50_ir_from_nir.cpp| 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp

[Mesa-dev] [PATCH 30/34] nv50/ir/nir: add memory barriers

v5: add more barrier intrinsics Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 21 +++ 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 33/34] nv50/ir/nir: handle user clip planes for each emitted vertex

v9: convert to C++ style comments Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 28/34] nv50/ir/nir: implement ssbo intrinsics

v4: use loadFrom helper v5: support indirect buffer access v8: don't require C++11 features Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 90 +++ 1 file changed, 90 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 11/34] nv50/ir/nir: add loadFrom and storeTo helpler

v8: don't require C++11 features Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 72 +++ 1 file changed, 72 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 15/34] nv50/ir/nir: implement nir_alu_instr handling

to make it easier to grep them add handling for fpow Signed-off-by: Karol Herbst --- .../nouveau/codegen/nv50_ir_from_nir.cpp | 562 +- 1 file changed, 561 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium

  1   2   3   4   5   6   7   8   9   10   >