Re: [Mesa-dev] [PATCH] clover: make older c++ (4.8.x) happy

[Eric Engestrom]

On Tue, Jul 26, 2016 at 04:21:26AM +0200, Dieter Nützel wrote:
> Signed-off-by: Dieter Nützel 

The change itself looks good, but could you replace "c++ 4.8" with
"GCC 4.8" in the commit title, and add a commit message with the error?
For reference:

  error: invalid initialization of non-const reference of type
  'clover::llvm::compat::raw_ostream_to_emit_file {aka 
llvm::raw_svector_ostream&}'
  from an rvalue of type ''

> ---
>  src/gallium/state_trackers/clover/llvm/codegen/native.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/state_trackers/clover/llvm/codegen/native.cpp 
> b/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
> index b96236b..f5e887e 100644
> --- a/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
> +++ b/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
> @@ -126,7 +126,7 @@ namespace {
>{
>   compat::pass_manager pm;
>   ::llvm::raw_svector_ostream os { data };
> - compat::raw_ostream_to_emit_file fos { os };
> + compat::raw_ostream_to_emit_file fos ( os );
>  
>   mod.setDataLayout(compat::get_data_layout(*tm));
>   tm->Options.MCOptions.AsmVerbose =
> -- 
> 2.1.4
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: make older c++ (4.8.x) happy

[Dieter Nützel]

Signed-off-by: Dieter Nützel 
---
 src/gallium/state_trackers/clover/llvm/codegen/native.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/clover/llvm/codegen/native.cpp 
b/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
index b96236b..f5e887e 100644
--- a/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
+++ b/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
@@ -126,7 +126,7 @@ namespace {
   {
  compat::pass_manager pm;
  ::llvm::raw_svector_ostream os { data };
- compat::raw_ostream_to_emit_file fos { os };
+ compat::raw_ostream_to_emit_file fos ( os );
 
  mod.setDataLayout(compat::get_data_layout(*tm));
  tm->Options.MCOptions.AsmVerbose =
-- 
2.1.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev