Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-22 Thread Emil Velikov
It should be in master now.

-Emil

On 21 July 2015 at 23:34, Dylan Baker baker.dyla...@gmail.com wrote:
 Cool, I was under that impression too, but having it confirmed is great.

 Since these do matter and I don't have push access, could you make sure this
 lands?

 On Jul 21, 2015 15:33, Emil Velikov emil.l.veli...@gmail.com wrote:

 It seems that I was under the wrong impression on the hole thing.

 Some of the files generated from these scripts are used in/by xserver.
 Although they are imported/tracked into version control of the latter in
 order to prevent the xserver build directly diving into mesa source tree.

 The XORG_GLAPI_OUTPUTS files on the other hand, are the ones that were
 removed from xserver with commit be6680967a4(glx: convert to direct GL
 dispatch (v2)). Unfortunatelly they only cover ~20 lines of makefile
 rules, thus none of the python scripts can be removed/simplified.

 Apologies if I mislead anyone.

 -Emil


 On 04/07/15 10:42, Emil Velikov wrote:
  Seems like there is a misunderstanding somewhere - perhaps some on my
  end. Yet I do recall Adam Jackson stating on numerous occasions, on
  IRC, that we don't want/need any sources from mesa (outside
  dri_interface.h and the gl* headers) for xserver.
 
  Adam can we truly nuke (some of) the generated sources in mesa, or
  does X/xserver relies on them ?
 
  Cheers,
  Emil
 
  On 3 July 2015 at 21:13, Dylan Baker baker.dyla...@gmail.com wrote:
  I asked about dumping them and was told that they would leave mesa only
  when
  x itself died. If be more than happy to see them go if they're not
  useful
 
  On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:
 
  On 02/07/15 18:25, Dylan Baker wrote:
  One of the plugins I use with vim helpfully added an underscore to
  the
  front of mode for kicks.
 
  Obviously this isn't a feature used very often because it's been
  broken
  since d986cb7c70db (since May 20th), and no one has noticed.
 
  Iirc these have a long and boring history with xserver. The short
  version is that they (and many other files reciding in
  XORG_GL{API,X}_DIR) have been dead/unused for a long while.
 
  If you want to avoid the rewriting them a few times, I would suggest
  that we nuke them up first. That's why I've asked about your plans
  earlier :)
 
  -Emil
 
 


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-21 Thread Dylan Baker
Cool, I was under that impression too, but having it confirmed is great.

Since these do matter and I don't have push access, could you make sure
this lands?
On Jul 21, 2015 15:33, Emil Velikov emil.l.veli...@gmail.com wrote:

 It seems that I was under the wrong impression on the hole thing.

 Some of the files generated from these scripts are used in/by xserver.
 Although they are imported/tracked into version control of the latter in
 order to prevent the xserver build directly diving into mesa source tree.

 The XORG_GLAPI_OUTPUTS files on the other hand, are the ones that were
 removed from xserver with commit be6680967a4(glx: convert to direct GL
 dispatch (v2)). Unfortunatelly they only cover ~20 lines of makefile
 rules, thus none of the python scripts can be removed/simplified.

 Apologies if I mislead anyone.

 -Emil


 On 04/07/15 10:42, Emil Velikov wrote:
  Seems like there is a misunderstanding somewhere - perhaps some on my
  end. Yet I do recall Adam Jackson stating on numerous occasions, on
  IRC, that we don't want/need any sources from mesa (outside
  dri_interface.h and the gl* headers) for xserver.
 
  Adam can we truly nuke (some of) the generated sources in mesa, or
  does X/xserver relies on them ?
 
  Cheers,
  Emil
 
  On 3 July 2015 at 21:13, Dylan Baker baker.dyla...@gmail.com wrote:
  I asked about dumping them and was told that they would leave mesa only
 when
  x itself died. If be more than happy to see them go if they're not
 useful
 
  On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:
 
  On 02/07/15 18:25, Dylan Baker wrote:
  One of the plugins I use with vim helpfully added an underscore to
 the
  front of mode for kicks.
 
  Obviously this isn't a feature used very often because it's been
 broken
  since d986cb7c70db (since May 20th), and no one has noticed.
 
  Iirc these have a long and boring history with xserver. The short
  version is that they (and many other files reciding in
  XORG_GL{API,X}_DIR) have been dead/unused for a long while.
 
  If you want to avoid the rewriting them a few times, I would suggest
  that we nuke them up first. That's why I've asked about your plans
  earlier :)
 
  -Emil
 
 


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-21 Thread Emil Velikov
It seems that I was under the wrong impression on the hole thing.

Some of the files generated from these scripts are used in/by xserver.
Although they are imported/tracked into version control of the latter in
order to prevent the xserver build directly diving into mesa source tree.

The XORG_GLAPI_OUTPUTS files on the other hand, are the ones that were
removed from xserver with commit be6680967a4(glx: convert to direct GL
dispatch (v2)). Unfortunatelly they only cover ~20 lines of makefile
rules, thus none of the python scripts can be removed/simplified.

Apologies if I mislead anyone.

-Emil


On 04/07/15 10:42, Emil Velikov wrote:
 Seems like there is a misunderstanding somewhere - perhaps some on my
 end. Yet I do recall Adam Jackson stating on numerous occasions, on
 IRC, that we don't want/need any sources from mesa (outside
 dri_interface.h and the gl* headers) for xserver.
 
 Adam can we truly nuke (some of) the generated sources in mesa, or
 does X/xserver relies on them ?
 
 Cheers,
 Emil
 
 On 3 July 2015 at 21:13, Dylan Baker baker.dyla...@gmail.com wrote:
 I asked about dumping them and was told that they would leave mesa only when
 x itself died. If be more than happy to see them go if they're not useful

 On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:

 On 02/07/15 18:25, Dylan Baker wrote:
 One of the plugins I use with vim helpfully added an underscore to the
 front of mode for kicks.

 Obviously this isn't a feature used very often because it's been broken
 since d986cb7c70db (since May 20th), and no one has noticed.

 Iirc these have a long and boring history with xserver. The short
 version is that they (and many other files reciding in
 XORG_GL{API,X}_DIR) have been dead/unused for a long while.

 If you want to avoid the rewriting them a few times, I would suggest
 that we nuke them up first. That's why I've asked about your plans
 earlier :)

 -Emil



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-04 Thread Emil Velikov
Seems like there is a misunderstanding somewhere - perhaps some on my
end. Yet I do recall Adam Jackson stating on numerous occasions, on
IRC, that we don't want/need any sources from mesa (outside
dri_interface.h and the gl* headers) for xserver.

Adam can we truly nuke (some of) the generated sources in mesa, or
does X/xserver relies on them ?

Cheers,
Emil

On 3 July 2015 at 21:13, Dylan Baker baker.dyla...@gmail.com wrote:
 I asked about dumping them and was told that they would leave mesa only when
 x itself died. If be more than happy to see them go if they're not useful

 On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:

 On 02/07/15 18:25, Dylan Baker wrote:
  One of the plugins I use with vim helpfully added an underscore to the
  front of mode for kicks.
 
  Obviously this isn't a feature used very often because it's been broken
  since d986cb7c70db (since May 20th), and no one has noticed.
 
 Iirc these have a long and boring history with xserver. The short
 version is that they (and many other files reciding in
 XORG_GL{API,X}_DIR) have been dead/unused for a long while.

 If you want to avoid the rewriting them a few times, I would suggest
 that we nuke them up first. That's why I've asked about your plans
 earlier :)

 -Emil


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-03 Thread Emil Velikov
On 02/07/15 18:25, Dylan Baker wrote:
 One of the plugins I use with vim helpfully added an underscore to the
 front of mode for kicks.
 
 Obviously this isn't a feature used very often because it's been broken
 since d986cb7c70db (since May 20th), and no one has noticed.
 
Iirc these have a long and boring history with xserver. The short
version is that they (and many other files reciding in
XORG_GL{API,X}_DIR) have been dead/unused for a long while.

If you want to avoid the rewriting them a few times, I would suggest
that we nuke them up first. That's why I've asked about your plans
earlier :)

-Emil

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-03 Thread Dylan Baker
I asked about dumping them and was told that they would leave mesa only
when x itself died. If be more than happy to see them go if they're not
useful
On Jul 3, 2015 06:28, Emil Velikov emil.l.veli...@gmail.com wrote:

 On 02/07/15 18:25, Dylan Baker wrote:
  One of the plugins I use with vim helpfully added an underscore to the
  front of mode for kicks.
 
  Obviously this isn't a feature used very often because it's been broken
  since d986cb7c70db (since May 20th), and no one has noticed.
 
 Iirc these have a long and boring history with xserver. The short
 version is that they (and many other files reciding in
 XORG_GL{API,X}_DIR) have been dead/unused for a long while.

 If you want to avoid the rewriting them a few times, I would suggest
 that we nuke them up first. That's why I've asked about your plans
 earlier :)

 -Emil


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-02 Thread Dylan Baker
One of the plugins I use with vim helpfully added an underscore to the
front of mode for kicks.

Obviously this isn't a feature used very often because it's been broken
since d986cb7c70db (since May 20th), and no one has noticed.

Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com
---
 src/mapi/glapi/gen/glX_proto_recv.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mapi/glapi/gen/glX_proto_recv.py 
b/src/mapi/glapi/gen/glX_proto_recv.py
index da468dc..5d95f27 100644
--- a/src/mapi/glapi/gen/glX_proto_recv.py
+++ b/src/mapi/glapi/gen/glX_proto_recv.py
@@ -549,9 +549,9 @@ def main():
 Main function.
 args = _parser()
 
-if args._mode == dispatch_c:
+if args.mode == dispatch_c:
 printer = PrintGlxDispatchFunctions(args.swap)
-elif args._mode == dispatch_h:
+elif args.mode == dispatch_h:
 printer = PrintGlxDispatch_h()
 
 api = gl_XML.parse_GL_API(
-- 
2.4.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev