Re: [Mesa-dev] [PATCH 2/4] intel/sanitize_gpu: add help/gdb options to wrapper

2019-01-16 Thread Lionel Landwerlin 

On 16/01/2019 01:31, Matt Turner wrote:

On Mon, Oct 29, 2018 at 11:16 AM Lionel Landwerlin
 wrote:

Signed-off-by: Lionel Landwerlin 
---
  src/intel/tools/intel_sanitize_gpu.in | 55 ++-
  1 file changed, 54 insertions(+), 1 deletion(-)

diff --git a/src/intel/tools/intel_sanitize_gpu.in 
b/src/intel/tools/intel_sanitize_gpu.in
index 3dac954c408..7e4c96d8738 100755
--- a/src/intel/tools/intel_sanitize_gpu.in
+++ b/src/intel/tools/intel_sanitize_gpu.in
@@ -1,4 +1,57 @@
  #!/bin/bash
  # -*- mode: sh -*-

-LD_PRELOAD="@install_libexecdir@/libintel_sanitize_gpu.so${LD_PRELOAD:+:$LD_PRELOAD}" 
exec "$@"
+function show_help() {
+cat <
No idea why this patch never landed, but

s/intel_aubdump/intel_sanitize_gpu/

(I just came across it when trying to figure out whether we ever moved
intel_aubdump from igt into Mesa.


I think it did land as (with your correction!) :

commit c5fca35af1694bd515883ade4b4ab723fe7fcad0
Author: Lionel Landwerlin 
Date:   Mon Oct 29 18:14:45 2018 +

    intel/sanitize_gpu: add help/gdb options to wrapper

    Signed-off-by: Lionel Landwerlin 
    Reviewed-by: Tapani Pälli 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] intel/sanitize_gpu: add help/gdb options to wrapper

2019-01-15 Thread Matt Turner 
On Mon, Oct 29, 2018 at 11:16 AM Lionel Landwerlin
 wrote:
>
> Signed-off-by: Lionel Landwerlin 
> ---
>  src/intel/tools/intel_sanitize_gpu.in | 55 ++-
>  1 file changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/tools/intel_sanitize_gpu.in 
> b/src/intel/tools/intel_sanitize_gpu.in
> index 3dac954c408..7e4c96d8738 100755
> --- a/src/intel/tools/intel_sanitize_gpu.in
> +++ b/src/intel/tools/intel_sanitize_gpu.in
> @@ -1,4 +1,57 @@
>  #!/bin/bash
>  # -*- mode: sh -*-
>
> -LD_PRELOAD="@install_libexecdir@/libintel_sanitize_gpu.so${LD_PRELOAD:+:$LD_PRELOAD}"
>  exec "$@"
> +function show_help() {
> +cat < +Usage: intel_sanitize_gpu [OPTION]... [--] COMMAND ARGUMENTS
> +
> +Run COMMAND with ARGUMENTS and verify the GPU doesn't write outside its 
> memory
> +mapped buffers.
> +
> +  -g, --gdb  Launch GDB
> +
> +  --help Display this help message and exit
> +
> +EOF
> +
> +exit 0
> +}
> +
> +gdb=""
> +
> +while true; do
> +case "$1" in
> +--gdb)
> +gdb=1
> +shift
> +;;
> +-g)
> +gdb=1
> +shift
> +;;
> +--help)
> +show_help
> +;;
> +--)
> +shift
> +break
> +;;
> +-*)
> +echo "intel_aubdump: invalid option: $1"

No idea why this patch never landed, but

s/intel_aubdump/intel_sanitize_gpu/

(I just came across it when trying to figure out whether we ever moved
intel_aubdump from igt into Mesa.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/4] intel/sanitize_gpu: add help/gdb options to wrapper

2018-10-29 Thread Lionel Landwerlin 
Signed-off-by: Lionel Landwerlin 
---
 src/intel/tools/intel_sanitize_gpu.in | 55 ++-
 1 file changed, 54 insertions(+), 1 deletion(-)

diff --git a/src/intel/tools/intel_sanitize_gpu.in 
b/src/intel/tools/intel_sanitize_gpu.in
index 3dac954c408..7e4c96d8738 100755
--- a/src/intel/tools/intel_sanitize_gpu.in
+++ b/src/intel/tools/intel_sanitize_gpu.in
@@ -1,4 +1,57 @@
 #!/bin/bash
 # -*- mode: sh -*-
 
-LD_PRELOAD="@install_libexecdir@/libintel_sanitize_gpu.so${LD_PRELOAD:+:$LD_PRELOAD}"
 exec "$@"
+function show_help() {
+cat