Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Thu, Feb 25, 2016 at 4:18 PM, Miklós Máté wrote: > On 02/25/2016 11:40 AM, Marek Olšák wrote: >> >> On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: >>> >>> v2: fix arithmetic for special opcodes, >>> fix fog state, cleanup >>> v3: simplify handling

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 08:20 AM, Miklós Máté wrote: On 02/25/2016 02:37 AM, Brian Paul wrote: + if (texinst->Opcode == ATI_FRAGMENT_SHADER_SAMPLE_OP) { + /* use the current texture target for the sample operation + * note: this implementation doesn't support re-using an ATI_fs + *

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 02:37 AM, Brian Paul wrote: I think this patch could be broken up a bit... Yes, I agree that this is very long, but I couldn't decide on how to split it up. On 02/24/2016 04:35 PM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3:

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 11:40 AM, Marek Olšák wrote: On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes, > fix fog state, cleanup > v3: simplify handling of special opcodes, > fix rebinding with different textargets or fog equation, > lots of formatting fixes > > Signed-off-by: Miklós

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

I think this patch could be broken up a bit... On 02/24/2016 04:35 PM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes

[Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes Signed-off-by: Miklós Máté --- src/mesa/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

I see that the shader doesn't specify texture target types and they must be obtained from the current GL states. That means texture targets have to be properly listed in the shader key. The shader compilation *must not* read any states from the current context. The shader key is the only place

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Fri, Feb 5, 2016 at 1:11 PM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes > (based on comments from Marek and Ilia), > fix fog state, cleanup > --- > src/mesa/Makefile.sources | 1 + > src/mesa/program/program.h| 2 + >

[Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes (based on comments from Marek and Ilia), fix fog state, cleanup --- src/mesa/Makefile.sources | 1 + src/mesa/program/program.h| 2 + src/mesa/state_tracker/st_atifs_to_tgsi.c | 734 ++

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Fri, Feb 5, 2016 at 4:11 PM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes > (based on comments from Marek and Ilia), > fix fog state, cleanup > --- > src/mesa/Makefile.sources | 1 + > src/mesa/program/program.h| 2 + >

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/05/2016 01:11 PM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes > (based on comments from Marek and Ilia), > fix fog state, cleanup > --- > src/mesa/Makefile.sources | 1 + > src/mesa/program/program.h| 2 + >